Page MenuHomePhabricator

j2kun (Jeremy Kun)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 14 2023, 11:37 AM (12 w, 4 d)

Recent Activity

Apr 17 2023

j2kun added a comment to D148477: [mlir][math] Properly disable ctlz conversion in MathToFuncs..

What exactly is the followup here? I see the extra test added that ensures ctlz is not lowered when the flag is disabled. Is another test helpful?

Apr 17 2023, 10:00 AM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2023

j2kun added a comment to D146261: Add support for math.ctlz in convert-math-to-funcs.

I can fix it Monday morning. A rollback is fine if it's urgent.

Apr 16 2023, 12:21 PM · Restricted Project, Restricted Project

Apr 15 2023

j2kun updated subscribers of D146261: Add support for math.ctlz in convert-math-to-funcs.

I'm not able to get to my computer til Monday, but perhaps your issue is
that this feature is disabled by default (see comments above), and you need
to explicitly enable it. The test files in this patch show the invocation.

Apr 15 2023, 9:02 AM · Restricted Project, Restricted Project

Apr 10 2023

j2kun added a comment to D146261: Add support for math.ctlz in convert-math-to-funcs.

@vzakhari ping :) thanks for your review and advice!

Apr 10 2023, 8:51 AM · Restricted Project, Restricted Project

Apr 6 2023

j2kun added a comment to D146261: Add support for math.ctlz in convert-math-to-funcs.

(btw, I don't have commit access, so someone else will need to commit it for me)

Apr 6 2023, 11:16 PM · Restricted Project, Restricted Project
j2kun added a comment to D146261: Add support for math.ctlz in convert-math-to-funcs.

This time only Bazel failed, so ok to merge :)

Apr 6 2023, 11:07 PM · Restricted Project, Restricted Project
j2kun updated the diff for D146261: Add support for math.ctlz in convert-math-to-funcs.

Try syncing with head

Apr 6 2023, 10:14 PM · Restricted Project, Restricted Project

Apr 4 2023

j2kun updated the diff for D146261: Add support for math.ctlz in convert-math-to-funcs.

break -> continue, plus move mlir-cpu-runner

Apr 4 2023, 1:46 PM · Restricted Project, Restricted Project

Mar 30 2023

j2kun updated the diff for D146261: Add support for math.ctlz in convert-math-to-funcs.

Fixed a typo/bad variable name choice from the last update

Mar 30 2023, 11:38 AM · Restricted Project, Restricted Project
j2kun added a comment to D146261: Add support for math.ctlz in convert-math-to-funcs.

Sorry for the delay, I was in Korea at a conference.

Mar 30 2023, 11:33 AM · Restricted Project, Restricted Project
j2kun updated the diff for D146261: Add support for math.ctlz in convert-math-to-funcs.

Address reviewer comments

Mar 30 2023, 11:33 AM · Restricted Project, Restricted Project

Mar 20 2023

j2kun updated the diff for D146261: Add support for math.ctlz in convert-math-to-funcs.

Added default-disabled convert-ctlz option

Mar 20 2023, 1:43 PM · Restricted Project, Restricted Project

Mar 17 2023

j2kun added a comment to D146261: Add support for math.ctlz in convert-math-to-funcs.

The backend we're ultimately planning to support does not have a ctlz builtin, so we have no choice but to emulate it in software. This is why lowering to llvm's builtin doesn't help us (and IIUC CIRCT also doesn't support llvm's ctlz)

Mar 17 2023, 11:58 AM · Restricted Project, Restricted Project
j2kun updated the summary of D146261: Add support for math.ctlz in convert-math-to-funcs.
Mar 17 2023, 10:20 AM · Restricted Project, Restricted Project
j2kun updated the diff for D146261: Add support for math.ctlz in convert-math-to-funcs.

Added mlir-cpu-runner tests for ctlz

Mar 17 2023, 10:20 AM · Restricted Project, Restricted Project
j2kun added reviewers for D146261: Add support for math.ctlz in convert-math-to-funcs: vzakhari, Mogball.
Mar 17 2023, 9:48 AM · Restricted Project, Restricted Project
j2kun published D146261: Add support for math.ctlz in convert-math-to-funcs for review.
Mar 17 2023, 9:47 AM · Restricted Project, Restricted Project