Paths
| Differential D98152
[InstCombine] Canonicalize SPF to min/max intrinsics ClosedPublic Authored by nikic on Mar 7 2021, 1:21 PM.
Details Summary Now that min/max intrinsics have good support in both InstCombine and other passes, start canonicalizing SPF min/max to intrinsic min/max. Once this sticks, we can stop matching SPF min/max in various places, and can remove hacks we have for preventing infinite loops / breaking SPF canonicalization.
Diff Detail
Unit TestsFailed Event TimelineHerald added subscribers: lxfind, kerbowa, dmgreen and 3 others. · View Herald TranscriptMar 7 2021, 1:21 PM
Comment Actions Thanks for sharing this! I added a couple of 'not' op enhancements to instcombine, so we should be slightly closer now.
Comment Actions
Thanks! I've updated with new results. It looks like we still need a few more folds for not to reach parity.
Comment Actions @nikic What do you think is left to do before taking this forward for general review? Comment Actions prof metadata support for abs/min/max is still missing.
dmgreen mentioned this in D109645: [LV] Recognize intrinsic min/max reductions.Sep 11 2021, 11:20 AM
Comment Actions A local rebase indicates that after rGaca355a3bb99 the most obvious regressions have been squashed
Comment Actions
I think we're close. Even if there are some regressions still visible, the benefits should outweigh those? We could file issues for whatever is known left to do based on a rebased patch.
Comment Actions I just went through all the tests again, and these are the remaining regressions I spotted. (There are some differences in canonicalization, but these are the ones where it's clearly worse now.)
Comment Actions
That was fast! I was going to look at the remaining bits, but too late. :) Thank you for pushing it forward. LGTM. For reference, these were at least some of the commits to handle the last round of missing folds: This revision is now accepted and ready to land.Feb 23 2022, 7:51 AM This revision was landed with ongoing or failed builds.Feb 24 2022, 12:09 AM Closed by commit rGa266af721153: [InstCombine] Canonicalize SPF to min/max intrinsics (authored by nikic). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions This fixed 9 bugs reports by Alive2:
Thank you!
Revision Contents
Diff 329374 llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
llvm/test/CodeGen/AMDGPU/reqd-work-group-size.ll
llvm/test/Transforms/Coroutines/coro-retcon-once-value.ll
llvm/test/Transforms/InstCombine/2007-12-18-AddSelCmpSub.ll
llvm/test/Transforms/InstCombine/CPP_min_max.ll
llvm/test/Transforms/InstCombine/abs-1.ll
llvm/test/Transforms/InstCombine/adjust-for-minmax.ll
llvm/test/Transforms/InstCombine/canonicalize-clamp-with-select-of-constant-threshold-pattern.ll
llvm/test/Transforms/InstCombine/clamp-to-minmax.ll
llvm/test/Transforms/InstCombine/div-shift.ll
llvm/test/Transforms/InstCombine/icmp.ll
llvm/test/Transforms/InstCombine/max-of-nots.ll
llvm/test/Transforms/InstCombine/max_known_bits.ll
llvm/test/Transforms/InstCombine/min-positive.llllvm/test/Transforms/InstCombine/minmax-demandbits.ll
llvm/test/Transforms/InstCombine/minmax-fold.ll
llvm/test/Transforms/InstCombine/minmax-fp.ll
llvm/test/Transforms/InstCombine/minmax-of-minmax.ll
llvm/test/Transforms/InstCombine/pr21199.ll
llvm/test/Transforms/InstCombine/pr27236.ll
llvm/test/Transforms/InstCombine/pr38897.ll
llvm/test/Transforms/InstCombine/pr38915.ll
llvm/test/Transforms/InstCombine/pr44541.ll
llvm/test/Transforms/InstCombine/pr44835.ll
llvm/test/Transforms/InstCombine/preserve-sminmax.ll
llvm/test/Transforms/InstCombine/sadd_sat.llllvm/test/Transforms/InstCombine/saturating-add-sub.ll
llvm/test/Transforms/InstCombine/select-gep.ll
llvm/test/Transforms/InstCombine/select-imm-canon.ll
llvm/test/Transforms/InstCombine/select-pr39595.ll
llvm/test/Transforms/InstCombine/select.ll
llvm/test/Transforms/InstCombine/select_meta.ll
llvm/test/Transforms/InstCombine/sext.ll
llvm/test/Transforms/InstCombine/smax-icmp.ll
llvm/test/Transforms/InstCombine/smin-icmp.ll
llvm/test/Transforms/InstCombine/sub-ashr-or-to-icmp-select.ll
llvm/test/Transforms/InstCombine/sub-minmax.ll
llvm/test/Transforms/InstCombine/sub.ll
llvm/test/Transforms/InstCombine/umax-icmp.ll
llvm/test/Transforms/InstCombine/umin-icmp.ll
llvm/test/Transforms/InstCombine/with_overflow.ll
llvm/test/Transforms/InstCombine/xor.ll
llvm/test/Transforms/LoopVectorize/ARM/mve-reduction-predselect.ll
llvm/test/Transforms/LoopVectorize/ARM/tail-fold-multiple-icmps.ll
llvm/test/Transforms/LoopVectorize/X86/x86-interleaved-accesses-masked-group.ll
llvm/test/Transforms/LoopVectorize/bzip_reverse_loops.ll
llvm/test/Transforms/LoopVectorize/reduction-inloop-pred.ll
llvm/test/Transforms/LoopVectorize/reduction-inloop.ll
llvm/test/Transforms/LoopVectorize/reduction-predselect.ll
llvm/test/Transforms/PhaseOrdering/X86/vector-reductions-expanded.ll
llvm/test/Transforms/PhaseOrdering/min-max-abs-cse.ll
llvm/test/Transforms/PhaseOrdering/minmax.ll
llvm/test/Transforms/SLPVectorizer/X86/pr46983.ll
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
NewAbs -> NewSPF