[sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl

[MaskRay]

Summary

Several #if SANITIZER_LINUX && !SANITIZER_ANDROID guards are replaced
with the more appropriate #if SANITIZER_GLIBC (the headers are glibc
extensions, not specific to Linux (i.e. if we ever support GNU/kFreeBSD
or Hurd, the guards may automatically work)).

Several #if SANITIZER_LINUX && !SANITIZER_ANDROID guards are refined
with #if SANITIZER_GLIBC (the definitions are available on Linux glibc,
but may not be available on other libc (e.g. musl) implementations).

This patch makes ninja asan cfi lsan msan stats tsan ubsan xray build on a musl based Linux distribution (apk install musl-libintl)
Notes about disabled interceptors for musl:

• SANITIZER_INTERCEPT_GLOB: musl does not implement GLOB_ALTDIRFUNC (GNU extension)
• Some ioctl structs and functions operating on them.
• SANITIZER_INTERCEPT___PRINTF_CHK: _FORTIFY_SOURCE functions are GNU extension
• SANITIZER_INTERCEPT___STRNDUP: dlsym(RTLD_NEXT, "__strndup") errors so a diagnostic is formed. The diagnostic uses write which hasn't been intercepted => SIGSEGV
• SANITIZER_INTERCEPT_*64: the _LARGEFILE64_SOURCE functions are glibc specific. musl does something like #define pread64 pread
• Disabled msg_iovlen msg_controllen cmsg_len checks: musl is conforming while many implementations (Linux/FreeBSD/NetBSD/Solaris) are non-conforming. Since we pick the glibc definition, exclude the checks for musl (incompatible sizes but compatible offsets)

Pass through LIBCXX_HAS_MUSL_LIBC to make check-msan/check-tsan able to build libc++ (https://bugs.llvm.org/show_bug.cgi?id=48618).

Many sanitizer features are available now.

% ninja check-asan
(known issues:
* ASAN_OPTIONS=fast_unwind_on_malloc=0 odr-violations hangs
)
...
Testing Time: 53.69s
  Unsupported      : 185
  Passed           : 512
  Expectedly Failed:   1
  Failed           :  12

% ninja check-ubsan check-ubsan-minimal check-memprof # all passed

% ninja check-cfi
( all cross-dso/)
...
Testing Time: 8.68s
  Unsupported      : 264
  Passed           :  80
  Expectedly Failed:   8
  Failed           :  32

% ninja check-lsan
(With GetTls (D93972), 10 failures)
Testing Time: 4.09s
  Unsupported:  7
  Passed     : 65
  Failed     : 22

% ninja check-msan
(Many are due to functions not marked unsupported.)
Testing Time: 23.09s
  Unsupported      :   6
  Passed           : 764
  Expectedly Failed:   2
  Failed           :  58

% ninja check-tsan
Testing Time: 23.21s
  Unsupported      :  86
  Passed           : 295
  Expectedly Failed:   1
  Failed           :  25

Used ASAN_OPTIONS=verbosity=2 to verify there is no unneeded interceptor.

Partly based on Jari Ronkainen's https://reviews.llvm.org/D63785#1921014

Note: we need to place _FILE_OFFSET_BITS above #include "sanitizer_platform.h" to avoid #define __USE_FILE_OFFSET64 1 in 32-bit ARM features.h

[MaskRay]

.

[MaskRay]

I pushed some trivial portability fixes.

Made some tests on Alpine Linux (musl based distribution) with this patch.

There is a GetTls assertion failure. Simply making
compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:GetTls return 0
gets sanitizers into a quite decent situation.

% ninja check-asan
...
Testing Time: 332.62s
  Unsupported      : 177
  Passed           : 482
  Expectedly Failed:   1
  Failed           :  20

% ninja check-ubsan
... (TestCases/Misc/monitor.cpp failed)
Testing Time: 98.92s
  Unsupported      :  50
  Passed           : 596
  Expectedly Failed:   2
  Failed           :   8

% ninja check-memprof # all passed

% ninja check-cfi
...
Testing Time: 8.68s
  Unsupported      : 264
  Passed           :  80
  Expectedly Failed:   8
  Failed           :  32

check-xray all failed.

For msan/tsan, I'll need to figure out some libc++ related compile issues.

---

About GetTlsSize. It is used in two places (1) msan/tsan/lsan call AdjustStackSize (https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/sanitizer_posix_libcdep.cpp#L407) in their pthread_create interceptors (https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/msan/msan_interceptors.cpp#L1037 ) (2) https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp#L547-L555 (this looks suspicious and can probably be removed; sent D93866)

[krytarowski]

Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.

[MaskRay]

In D93848#2472833, @krytarowski wrote:

Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.

Hurd and GNU/kFreeBSD are not supported. Even if they do, many defined(__GLIBC__) is inside a #if SANITIZER_LINUX, so they will work automatically.

/usr/include/features.h is needed to get __GLIBC__. tsan is built with a standalone sysroot so /usr/include/features.h is unavailable. So it is not straightforward to create a SANITIZER_GLIBC in lib/sanitizer_common/sanitizer_platform.h

[ronchaine]

Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.

When I made the original patch, I was looking through what was defined in what standard, and SANITIZER_GNU (or __GLIBC__) here
without SANITIZER_LINUX should be available on those platforms. I can't say for certain since it's been a while since I made that, but
it *should* work on those platforms too. I used SANITIZER_LINUX && SANITIZER_GNU when both were needed by the standard.

If I made a mistake with those, I would concider it a bug.

I would also do declare the SANITIZER_GNU as well, while it can be just __GLIBC__ here in practice, it is not technically the same,
and it's more in line with the style of the rest of the file. It also allows some future-proofing if some platform is crazy enough to provide
GNU extensions without defining __GLIBC__ it could just be added to where we declare SANITIZER_GNU instead of needing to
figure out how to refactor the file again. (i.e. use SANITIZER_GNU to mean "we have GNU extensions")

[MaskRay]

In D93848#2472929, @ronchaine wrote:

Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.

When I made the original patch, I was looking through what was defined in what standard, and SANITIZER_GNU (or __GLIBC__) here
without SANITIZER_LINUX should be available on those platforms. I can't say for certain since it's been a while since I made that, but
it *should* work on those platforms too. I used SANITIZER_LINUX && SANITIZER_GNU when both were needed by the standard.

If I made a mistake with those, I would concider it a bug.

I would also do declare the SANITIZER_GNU as well, while it can be just __GLIBC__ here in practice, it is not technically the same,
and it's more in line with the style of the rest of the file. It also allows some future-proofing if some platform is crazy enough to provide
GNU extensions without defining __GLIBC__ it could just be added to where we declare SANITIZER_GNU instead of needing to
figure out how to refactor the file again. (i.e. use SANITIZER_GNU to mean "we have GNU extensions")

I think having GLIBC in the macro name is important. There are GNU extensions and glibc headers. The problem with GNU is that it is less specific. Some platforms (FreeBSD) have implemented many GNU extensions (compiler extensions/ELF extensions) but may not provide the header files (obstack.h fstab.h ...; Some of the headers collide with Linux headers). For such headers, I guard them with nested #if SANITIZER_LINUX # ifdef __GLIBC__.

For things may likely work on non-Linux glibc, I just use`#ifdef GLIBC`, e.g.

#ifdef __GLIBC__
int glob_nomatch = GLOB_NOMATCH;  // musl has this but not the following, for simplicity just exclude all
int glob_altdirfunc = GLOB_ALTDIRFUNC;
#endif

In the end I still feel the current organization is great:)

[krytarowski]

In D93848#2472902, @MaskRay wrote:

In D93848#2472833, @krytarowski wrote:

Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.

Hurd and GNU/kFreeBSD are not supported. Even if they do, many defined(__GLIBC__) is inside a #if SANITIZER_LINUX, so they will work automatically.

At least, GNU/kFreeBSD is supported in other components of LLVM and introducing it in sanitizers should be relatively simple. However I don't plan to maintain these targets myself.

In D93848#2472929, @ronchaine wrote:

I would also do declare the SANITIZER_GNU as well, while it can be just __GLIBC__ here in practice, it is not technically the same,
and it's more in line with the style of the rest of the file.

Please beware that __GNU__ is HURD, not Linux, thus SANITIZER_GNU should be HURD.

[ronchaine]

I think having GLIBC in the macro name is important. There are GNU extensions and glibc headers. The problem with GNU is that it is less specific. Some platforms (FreeBSD) have implemented many GNU extensions (compiler extensions/ELF extensions) but may not provide the header files (obstack.h fstab.h ...; Some of the headers collide with Linux headers). For such headers, I guard them with nested #if SANITIZER_LINUX # ifdef __GLIBC__.

Yeah, that makes sense.

In the end I still feel the current organization is great:)

I just feel like the defines should follow the specifications, otherwise this is just pushing the problem to the next libc.
If the defines followed specifications in the first place, musl wouldn't have needed special treatment to compile.

Please beware that GNU is HURD, not Linux, thus SANITIZER_GNU should be HURD.

Makes sense, I would just like that there would be something else than the __GLIBC__ macro, that would be
controlled inside platform interceptors, like the other defines there. I don't really care that much what it would
be named.

[MaskRay]

In D93848#2473073, @ronchaine wrote:

In the end I still feel the current organization is great:)

I just feel like the defines should follow the specifications, otherwise this is just pushing the problem to the next libc.
If the defines followed specifications in the first place, musl wouldn't have needed special treatment to compile.

Yes, I am aware. Several __GLIBC__ guards are really indeed glibc mess (conflicting with Linux header; likely available on other OSes glibc supports) so glibc instead of GNU is more appropriate.
These are things I think are highly glibc specific and other libc implementation adopting a few GNU extensions may not support (or even if they do decide support, annotating that on top of this patch should not be too difficult).

[vitalybuka]

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

272 ↗

(On Diff #313820)

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp

170–171

please clang format the patch and resolve clang-tidy warnings

[vitalybuka]

LGTM, I'll accept in a day or so if no other feedback

[MaskRay]

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

272 ↗

(On Diff #313820)

*Nod*
Will fix once the other comment is answered

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp

170–171

The clang-tidy warning asks me to remove the spaces in # include.

IMO this will make it less readable. If you it looks fine I'll delete the spaces.

[vitalybuka]

check-asan on debian complains like thins:

ninja: Entering directory `../out/z/'
[0/1] Running the AddressSanitizer tests
FAIL: AddressSanitizer-i386-linux :: TestCases/Linux/pthread_create_version.cpp (551 of 1438)
******************** TEST 'AddressSanitizer-i386-linux :: TestCases/Linux/pthread_create_version.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';      /usr/local/google/home/vitalybuka/src/llvm.git/out/z/./bin/clang  --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -m32  -std=c++11 -pthread /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/test/asan/TestCases/Linux/pthread_create_version.cpp -o /usr/local/google/home/vitalybuka/src/llvm.git/out/z/projects/compiler-rt/test/asan/I386LinuxConfig/TestCases/Linux/Output/pthread_create_version.cpp.tmp &&  /usr/local/google/home/vitalybuka/src/llvm.git/out/z/projects/compiler-rt/test/asan/I386LinuxConfig/TestCases/Linux/Output/pthread_create_version.cpp.tmp 2>&1
--
Exit Code: 1

Command Output (stdout):
--
AddressSanitizer:DEADLYSIGNAL
=================================================================
==974260==ERROR: AddressSanitizer: SEGV on unknown address 0xfffffb40 (pc 0xf7bcca11 bp 0xffb65548 sp 0xffb654c0 T0)
==974260==The signal is caused by a WRITE memory access.
    #0 0xf7bcca11 in pthread_create@@GLIBC_2.1 (/lib/i386-linux-gnu/libpthread.so.0+0x8a11)
    #1 0xf7bcd42b in pthread_create@GLIBC_2.0 (/lib/i386-linux-gnu/libpthread.so.0+0x942b)
    #2 0x80caff0 in pthread_create /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:230:14
    #3 0x81186b7 in main /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/test/asan/TestCases/Linux/pthread_create_version.cpp:19:3
    #4 0xf79c9e45 in __libc_start_main (/lib/i386-linux-gnu/libc.so.6+0x1ee45)
    #5 0x8065321 in _start (/usr/local/google/home/vitalybuka/src/llvm.git/out/z/projects/compiler-rt/test/asan/I386LinuxConfig/TestCases/Linux/Output/pthread_create_version.cpp.tmp+0x8065321)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/lib/i386-linux-gnu/libpthread.so.0+0x8a11) in pthread_create@@GLIBC_2.1
==974260==ABORTING

[vitalybuka]

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp

170–171

Yes, that's what I am asking too. It's not worth of hassle correcting auto format in future.

[MaskRay]

In D93848#2473145, @vitalybuka wrote:

check-asan on debian complains like thins:

ninja: Entering directory `../out/z/'
[0/1] Running the AddressSanitizer tests
FAIL: AddressSanitizer-i386-linux :: TestCases/Linux/pthread_create_version.cpp (551 of 1438)
******************** TEST 'AddressSanitizer-i386-linux :: TestCases/Linux/pthread_create_version.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';      /usr/local/google/home/vitalybuka/src/llvm.git/out/z/./bin/clang  --driver-mode=g++ -fsanitize=address -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer -fno-optimize-sibling-calls -gline-tables-only  -m32  -std=c++11 -pthread /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/test/asan/TestCases/Linux/pthread_create_version.cpp -o /usr/local/google/home/vitalybuka/src/llvm.git/out/z/projects/compiler-rt/test/asan/I386LinuxConfig/TestCases/Linux/Output/pthread_create_version.cpp.tmp &&  /usr/local/google/home/vitalybuka/src/llvm.git/out/z/projects/compiler-rt/test/asan/I386LinuxConfig/TestCases/Linux/Output/pthread_create_version.cpp.tmp 2>&1
--
Exit Code: 1

Command Output (stdout):
--
AddressSanitizer:DEADLYSIGNAL
=================================================================
==974260==ERROR: AddressSanitizer: SEGV on unknown address 0xfffffb40 (pc 0xf7bcca11 bp 0xffb65548 sp 0xffb654c0 T0)
==974260==The signal is caused by a WRITE memory access.
    #0 0xf7bcca11 in pthread_create@@GLIBC_2.1 (/lib/i386-linux-gnu/libpthread.so.0+0x8a11)
    #1 0xf7bcd42b in pthread_create@GLIBC_2.0 (/lib/i386-linux-gnu/libpthread.so.0+0x942b)
    #2 0x80caff0 in pthread_create /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/lib/asan/asan_interceptors.cpp:230:14
    #3 0x81186b7 in main /usr/local/google/home/vitalybuka/src/llvm.git/llvm-project/compiler-rt/test/asan/TestCases/Linux/pthread_create_version.cpp:19:3
    #4 0xf79c9e45 in __libc_start_main (/lib/i386-linux-gnu/libc.so.6+0x1ee45)
    #5 0x8065321 in _start (/usr/local/google/home/vitalybuka/src/llvm.git/out/z/projects/compiler-rt/test/asan/I386LinuxConfig/TestCases/Linux/Output/pthread_create_version.cpp.tmp+0x8065321)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/lib/i386-linux-gnu/libpthread.so.0+0x8a11) in pthread_create@@GLIBC_2.1
==974260==ABORTING

The problem is that __GLIBC__ is not defined in lib/interception/interception_linux.h (so the unversioned pthread_create is selected and fails on i386 rL248325).

#include <features.h> (or any other glibc header) needs to be included to get __GLIBC__. However, ninja tsan specifies --sysroot=. (lib/tsan/CMakeLists.txt:246) and /usr/include is not in the search path so features.h cannot be found by tsan.

Any thought making __GLIBC__ available on tsan?

[vitalybuka]

Can we add #include "sanitizer_common/sanitizer_glibc_version.h" into interception_linux.h ?

[MaskRay]

Address comments.

Properly set GLIBC in lib/interception/interception_linux.h

[vitalybuka]

compiler-rt/lib/interception/interception_linux.h

24 ↗

(On Diff #313907)

@eugenis @dvyukov I propose to remove sysroot=. from tsan. There was idea that we should do that for all sanitizers to avoid random unwanted includes, but now it looks to me as unnecessary hassle.

[krytarowski]

compiler-rt/lib/interception/interception_linux.cpp

67

dlvsym is available on NetBSD too.

compiler-rt/lib/interception/interception_linux.h

48 ↗

(On Diff #313907)

dlvsym is available on NetBSD too.

[emaste]

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

243 ↗

(On Diff #313907)

FreeBSD has glob(3), NetBSD probably does but I'm not certain. Is there an issue with intercepting glob there?

272 ↗

(On Diff #313820)

!LINUX_NOT_ANDROID seems confusing; how do FreeBSD/NetBSD factor into ioctl?

[MaskRay]

Enable dlvsym on NetBSD. Some other adjustment

[MaskRay]

compiler-rt/lib/interception/interception_linux.h

24 ↗

(On Diff #313907)

I second the idea.

It caused hassle to FreeBSD and NetBSD
https://bugs.llvm.org/show_bug.cgi?id=26651

[MaskRay]

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

243 ↗

(On Diff #313907)

This is related to

#ifdef __GLIBC__
int glob_nomatch = GLOB_NOMATCH;
int glob_altdirfunc = GLOB_ALTDIRFUNC;
#endif

glob is simple so I can send a separate patch for FreeBSD. I'll not make functional changes for *BSD in this patch, though.

272 ↗

(On Diff #313820)

ioctl is very complex. It requires many headers. This patch intends to be a NFC for non-Linux and I'll not touch ioctl for FreeBSD.

[MaskRay]

Drop --sysroot=.
Mark more glibc specific functions. Tested with ASAN_OPTIONS=verbosity=2.
Pushed a semarate commit. ninja check-ubsan passed now
UNSUPPORTED some tests separately. ninja check-asan has only 13 failures now (several symbolizer tests are related to a dead futex __sanitizer::BufferedStackTrace::Unwind->_Unwind_Backtrace->_Unwind_Find_FDE->__pthread_mutex_timedlock->__timedwait->__timedwait_cp->__futex4_cp. I don't investigate further)

[MaskRay]

Make check-msan build

[MaskRay]

Make ioctl work (some like struct termio have to be disabled)
FreeBSD does not have features.h. Add a guard
Tested Android

[MaskRay]

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

243 ↗

(On Diff #313907)

sanitizer_platform_limits_posix.h:752

__sanitizer_glob_t does not match FreeBSD include/glob.h. So glob cannot be enabled on FreeBSD.

[MaskRay]

Enable sendmsg/recvmsg on musl

Most implementations are non-conforming (FreeBSD/NetBSD/OpenBSD/Solaris/macOS/Linux). Exclude the size checks for the conforming musl fields.

[vitalybuka]

compiler-rt/lib/tsan/CMakeLists.txt

252 ↗

(On Diff #313988)

please extract this into a separate patch

[MaskRay]

Rebase on D93921 (Remove --sysroot=.)

[vitalybuka]

compiler-rt/lib/asan/asan_interceptors.h

63 ↗

(On Diff #314018)

what if we define SANITIZER_GLIBC in sanitizer_platform.h

as is if we remove include features.h, defined(GLIBC) will silently calculated as false.

compiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h

192–193 ↗

(On Diff #314018)

[MaskRay]

compiler-rt/lib/asan/asan_interceptors.h

63 ↗

(On Diff #314018)

An undefined macro evaluates to 0. Adding SANITIZER_GLIBC does not seem to improve the situation...

[MaskRay]

Add parentheses around SI_GLIBC || something

[vitalybuka]

compiler-rt/lib/asan/asan_interceptors.h

63 ↗

(On Diff #314018)

My mistake.
Still we pretty sure that platform.h is included everywhere.
and it will make look these #ifs more consistent

[MaskRay]

Use SANITIZER_GLIBC

[aeubanks]

I believe this is causing issues on the Chrome Android bots:

FAILED: lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_malloc_linux.cpp.o
/b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/clang++ -DASAN_DYNAMIC=1 -I/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/.. --target=aarch64-linux-android21 --sysroot=/b/s/w/ir/cache/builder/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot --gcc-toolchain=/b/s/w/ir/cache/builder/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64 -Wall -std=c++14 -Wno-unused-parameter -O3 -DNDEBUG -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -nostdinc++ -fno-rtti -ftls-model=initial-exec -MD -MT lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_malloc_linux.cpp.o -MF lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_malloc_linux.cpp.o.d -o lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_malloc_linux.cpp.o -c /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:262:3: error: unknown type name 'fake_mallinfo'

fake_mallinfo (*mallinfo)(void);
^

/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:277:53: error: use of undeclared identifier 'interceptor_mallinfo'; did you mean 'interceptor_malloc'?

WRAP(calloc),         WRAP(free),               WRAP(mallinfo),
                                                ^~~~~~~~~~~~~~
                                                __interceptor_malloc

/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../interception/interception.h:149:18: note: expanded from macro 'WRAP'

define WRAP(x) __interceptor_ ## x

^

<scratch space>:144:1: note: expanded from here
interceptor_mallinfo
^
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:140:1: note: 'interceptor_malloc' declared here
INTERCEPTOR(void*, malloc, uptr size) {
^
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../interception/interception.h:232:12: note: expanded from macro 'INTERCEPTOR'

ret_type WRAP(func)(__VA_ARGS__)
         ^

/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../interception/interception.h:149:18: note: expanded from macro 'WRAP'

define WRAP(x) __interceptor_ ## x

^

<scratch space>:60:1: note: expanded from here
__interceptor_malloc
^

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8859402008562911568/+/steps/gclient_runhooks/0/stdout?format=raw

[MaskRay]

In D93848#2476055, @aeubanks wrote:

I believe this is causing issues on the Chrome Android bots:

FAILED: lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_malloc_linux.cpp.o
/b/s/w/ir/cache/builder/src/third_party/llvm-build/Release+Asserts/bin/clang++ -DASAN_DYNAMIC=1 -I/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/.. --target=aarch64-linux-android21 --sysroot=/b/s/w/ir/cache/builder/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64/sysroot --gcc-toolchain=/b/s/w/ir/cache/builder/src/third_party/android_ndk/toolchains/llvm/prebuilt/linux-x86_64 -Wall -std=c++14 -Wno-unused-parameter -O3 -DNDEBUG -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -nostdinc++ -fno-rtti -ftls-model=initial-exec -MD -MT lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_malloc_linux.cpp.o -MF lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_malloc_linux.cpp.o.d -o lib/asan/CMakeFiles/RTAsan_dynamic.aarch64.dir/asan_malloc_linux.cpp.o -c /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:262:3: error: unknown type name 'fake_mallinfo'

fake_mallinfo (*mallinfo)(void);
^

/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:277:53: error: use of undeclared identifier 'interceptor_mallinfo'; did you mean 'interceptor_malloc'?

WRAP(calloc),         WRAP(free),               WRAP(mallinfo),
                                                ^~~~~~~~~~~~~~
                                                __interceptor_malloc

/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../interception/interception.h:149:18: note: expanded from macro 'WRAP'

define WRAP(x) __interceptor_ ## x

^

<scratch space>:144:1: note: expanded from here
interceptor_mallinfo
^
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:140:1: note: 'interceptor_malloc' declared here
INTERCEPTOR(void*, malloc, uptr size) {
^
/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../interception/interception.h:232:12: note: expanded from macro 'INTERCEPTOR'

ret_type WRAP(func)(__VA_ARGS__)
         ^

/b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/asan/../interception/interception.h:149:18: note: expanded from macro 'WRAP'

define WRAP(x) __interceptor_ ## x

^

<scratch space>:60:1: note: expanded from here
__interceptor_malloc
^

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8859402008562911568/+/steps/gclient_runhooks/0/stdout?format=raw

I was misled by a disabled mallinfo guard in tsan for Android. Bionic seems to provide mallinfo: D93970
(I don't know how to test, though)

[aeubanks]

compiler-rt/lib/sanitizer_common/sanitizer_platform.h

24 ↗

(On Diff #314174)

compiler-rt/lib/hwasan/hwasan_setjmp.S includes sanitizer_platform.h. With this new include, on Android it ends up including C function declarations into a .S file which doesn't compile. https://crbug.com/1162741

[thakis]

Reverted in fe9976c02c09f105751f787ec998abeb3414a235 for now. If you could wait with relanding during working hours, that'd be super appreciated. Thanks!

[MaskRay]

compiler-rt/lib/sanitizer_common/sanitizer_platform.h

24 ↗

(On Diff #314174)

Thanks for the information. This looks like an Android header file bug. Including features.h should not pull in additional random symbols which cause a compile error.

[ostannard]

This is causing a build failure on the 32-bit ARM bots:

/usr/local/bin/c++  -DHAVE_RPC_XDR_H=1 -D_DEBUG -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iprojects/compiler-rt/lib/sanitizer_common -I/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common -Iinclude -I/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/llvm/include -I/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/.. -mcpu=cortex-a57 -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -Wall -std=c++14 -Wno-unused-parameter -O3     -march=armv7-a -mfloat-abi=hard -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fno-sanitize=safe-stack -fvisibility=hidden -fno-lto -O3 -gline-tables-only -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -nostdinc++ -fno-rtti -Wframe-larger-than=570 -Wglobal-constructors -UNDEBUG -std=c++14 -MD -MT projects/compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.armhf.dir/sanitizer_platform_limits_posix.cpp.o -MF projects/compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.armhf.dir/sanitizer_platform_limits_posix.cpp.o.d -o projects/compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.armhf.dir/sanitizer_platform_limits_posix.cpp.o -c /home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:1046:1: error: static_assert failed due to requirement 'sizeof (((__sanitizer::__sanitizer_dirent *)__null)->d_ino) == sizeof (((dirent *)__null)->d_ino)' ""
CHECK_SIZE_AND_OFFSET(dirent, d_ino);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h:1438:3: note: expanded from macro 'CHECK_SIZE_AND_OFFSET'
  COMPILER_CHECK(sizeof(((__sanitizer_##CLASS *)NULL)->MEMBER) == \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:332:30: note: expanded from macro 'COMPILER_CHECK'
#define COMPILER_CHECK(pred) static_assert(pred, "")
                             ^             ~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:1052:1: error: static_assert failed due to requirement 'sizeof (((__sanitizer::__sanitizer_dirent *)__null)->d_off) == sizeof (((dirent *)__null)->d_off)' ""
CHECK_SIZE_AND_OFFSET(dirent, d_off);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h:1438:3: note: expanded from macro 'CHECK_SIZE_AND_OFFSET'
  COMPILER_CHECK(sizeof(((__sanitizer_##CLASS *)NULL)->MEMBER) == \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:332:30: note: expanded from macro 'COMPILER_CHECK'
#define COMPILER_CHECK(pred) static_assert(pred, "")
                             ^             ~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:1052:1: error: static_assert failed due to requirement '__builtin_offsetof(__sanitizer::__sanitizer_dirent, d_off) == __builtin_offsetof(dirent, d_off)' ""
CHECK_SIZE_AND_OFFSET(dirent, d_off);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h:1440:3: note: expanded from macro 'CHECK_SIZE_AND_OFFSET'
  COMPILER_CHECK(offsetof(__sanitizer_##CLASS, MEMBER) ==         \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:332:30: note: expanded from macro 'COMPILER_CHECK'
#define COMPILER_CHECK(pred) static_assert(pred, "")
                             ^             ~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp:1054:1: error: static_assert failed due to requirement '__builtin_offsetof(__sanitizer::__sanitizer_dirent, d_reclen) == __builtin_offsetof(dirent, d_reclen)' ""
CHECK_SIZE_AND_OFFSET(dirent, d_reclen);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h:1440:3: note: expanded from macro 'CHECK_SIZE_AND_OFFSET'
  COMPILER_CHECK(offsetof(__sanitizer_##CLASS, MEMBER) ==         \
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/tcwg-buildslave/worker/clang-cmake-armv8-lld/llvm/compiler-rt/lib/sanitizer_common/sanitizer_internal_defs.h:332:30: note: expanded from macro 'COMPILER_CHECK'
#define COMPILER_CHECK(pred) static_assert(pred, "")
                             ^             ~~~~
4 errors generated.

Full log at http://lab.llvm.org:8011/#/builders/126/builds/1192. This is affecting quite a few bots (all of the ARM bots which build compiler-rt), so I've reverted it as 4839378ca05f88faed53ea25457fd93fcad93460 for now.

[MaskRay]

Move _FILE_OFFSET_BITS above to appease 32-bit ARM features.h
Add a release note

compiler-rt/lib/interception/interception_linux.cpp

 
 bool InterceptFunction(const char *name, uptr *ptr_to_real, uptr func,
                        uptr wrapper) {
   void *addr = GetFuncAddr(name, wrapper);
   *ptr_to_real = (uptr)addr;
   return addr && (func == wrapper);
 }
 
-// Android and Solaris do not have dlvsym
-#if !SANITIZER_ANDROID && !SANITIZER_SOLARIS
+// dlvsym is a GNU extension supported by some other platforms.
+#if __GLIBC__ || SANITIZER_FREEBSD
 static void *GetFuncAddr(const char *name, const char *ver) {
   return dlvsym(RTLD_NEXT, name, ver);
 }
 
 bool InterceptFunction(const char *name, const char *ver, uptr *ptr_to_real,
                        uptr func, uptr wrapper) {
   void *addr = GetFuncAddr(name, ver);
   *ptr_to_real = (uptr)addr;
   return addr && (func == wrapper);
 }
-#endif  // !SANITIZER_ANDROID
+#endif  // __GLIBC__ || SANITIZER_FREEBSD
 
 }  // namespace __interception
 
 #endif  // SANITIZER_LINUX || SANITIZER_FREEBSD || SANITIZER_NETBSD ||
         // SANITIZER_SOLARIS

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.cpp

 #if !SANITIZER_MAC
 #include <utmp.h>
 #endif
 
 #if !SANITIZER_IOS
 #include <net/route.h>
 #endif
 
-#if !SANITIZER_ANDROID
+#ifdef __GLIBC__
 #include <fstab.h>
+#endif
+#if !SANITIZER_ANDROID
 #include <sys/mount.h>
 #include <sys/timeb.h>
 #include <utmpx.h>
 #endif
 
 #if SANITIZER_LINUX
 #include <malloc.h>
 #include <mntent.h>

 #endif
 
 #if !SANITIZER_ANDROID
 #include <ifaddrs.h>
 #include <sys/ucontext.h>
 #include <wordexp.h>
 #endif
 
-#if SANITIZER_LINUX && !SANITIZER_ANDROID
+#ifdef __GLIBC__
 #include <glob.h>
 #include <obstack.h>
 #include <mqueue.h>
 #include <net/if_ppp.h>
 #include <netax25/ax25.h>
 #include <netipx/ipx.h>
 #include <netrom/netrom.h>
 #if HAVE_RPC_XDR_H

 #include <linux/if_plip.h>
 #include <linux/lp.h>
 #include <linux/mroute.h>
 #include <linux/mroute6.h>
 #include <linux/scc.h>
 #include <linux/serial.h>
 #include <sys/msg.h>
 #include <sys/ipc.h>
-#include <crypt.h>
-#endif // SANITIZER_LINUX && !SANITIZER_ANDROID
+#endif  // __GLIBC__
 
-#if SANITIZER_ANDROID
+#if SANITIZER_LINUX && !defined(__GLIBC__)
 #include <linux/kd.h>
 #include <linux/mtio.h>
 #include <linux/ppp_defs.h>
 #include <linux/if_ppp.h>
-#endif
+# if !SANITIZER_ANDROID
+# include <linux/ax25.h>
+# include <linux/cyclades.h>
+# include <linux/ipx.h>
+// #include <linux/mtio.h> doesn't have the required mtconfiginfo
+// #include <linux/netrom.h> doesn't have the required nr_parms_struct
+# include <linux/scc.h>
+# include <linux/mroute.h>
+# include <linux/if_eql.h>
+# include <linux/lp.h>
+# include <linux/if_plip.h>
+# include <linux/netrom.h>
+# include <linux/ipc.h>
+# include <linux/shm.h>
+# endif
+#endif // SANITIZER_LINUX && !defined(__GLIBC__)
 
 #if SANITIZER_LINUX
+#include <crypt.h>
 #include <link.h>
 #include <sys/vfs.h>
 #include <sys/epoll.h>
 #include <linux/capability.h>
 #endif // SANITIZER_LINUX
 
 #if SANITIZER_MAC
 #include <net/ethernet.h>
 #include <sys/filio.h>
 #include <sys/sockio.h>
 #endif
 
#endif // !SANITIZER_IOS && !(SANITIZER_MAC && TARGET_CPU_ARM64)
   unsigned struct_sched_param_sz = sizeof(struct sched_param);
   unsigned struct_regex_sz = sizeof(regex_t);
   unsigned struct_regmatch_sz = sizeof(regmatch_t);
 
 #if (SANITIZER_MAC && !TARGET_CPU_ARM64) && !SANITIZER_IOS
   unsigned struct_statfs64_sz = sizeof(struct statfs64);
 #endif // (SANITIZER_MAC && !TARGET_CPU_ARM64) && !SANITIZER_IOS
 
-#if !SANITIZER_ANDROID
+#ifdef __GLIBC__
   unsigned struct_fstab_sz = sizeof(struct fstab);
   unsigned struct_statfs_sz = sizeof(struct statfs);
   unsigned struct_sockaddr_sz = sizeof(struct sockaddr);
   unsigned ucontext_t_sz = sizeof(ucontext_t);
-#endif // !SANITIZER_ANDROID
+#endif  // __GLIBC__
 
 #if SANITIZER_LINUX
   unsigned struct_epoll_event_sz = sizeof(struct epoll_event);
   unsigned struct_sysinfo_sz = sizeof(struct sysinfo);
   unsigned __user_cap_header_struct_sz =
       sizeof(struct __user_cap_header_struct);
   unsigned __user_cap_data_struct_sz = sizeof(struct __user_cap_data_struct);
   unsigned struct_new_utsname_sz = sizeof(struct new_utsname);

 #error Unknown size of struct ustat
 #endif
   unsigned struct_ustat_sz = SIZEOF_STRUCT_USTAT;
   unsigned struct_rlimit64_sz = sizeof(struct rlimit64);
   unsigned struct_statvfs64_sz = sizeof(struct statvfs64);
   unsigned struct_crypt_data_sz = sizeof(struct crypt_data);
 #endif // SANITIZER_LINUX && !SANITIZER_ANDROID
 
-#if SANITIZER_LINUX && !SANITIZER_ANDROID
+#ifdef __GLIBC__
   unsigned struct_timex_sz = sizeof(struct timex);
   unsigned struct_msqid_ds_sz = sizeof(struct msqid_ds);
   unsigned struct_mq_attr_sz = sizeof(struct mq_attr);
   unsigned struct_statvfs_sz = sizeof(struct statvfs);
-#endif // SANITIZER_LINUX && !SANITIZER_ANDROID
+#endif  // __GLIBC__
 
   const uptr sig_ign = (uptr)SIG_IGN;
   const uptr sig_dfl = (uptr)SIG_DFL;
   const uptr sig_err = (uptr)SIG_ERR;
   const uptr sa_siginfo = (uptr)SA_SIGINFO;
 
 #if SANITIZER_LINUX
   int e_tabsz = (int)E_TABSZ;
 #endif
 
 
-#if SANITIZER_LINUX && !SANITIZER_ANDROID
+#ifdef __GLIBC__
   unsigned struct_shminfo_sz = sizeof(struct shminfo);
   unsigned struct_shm_info_sz = sizeof(struct shm_info);
   int shmctl_ipc_stat = (int)IPC_STAT;
   int shmctl_ipc_info = (int)IPC_INFO;
   int shmctl_shm_info = (int)SHM_INFO;
   int shmctl_shm_stat = (int)SHM_STAT;
 #endif
 
#endif
   }
 
 #if SANITIZER_LINUX
 unsigned struct_ElfW_Phdr_sz = sizeof(ElfW(Phdr));
 #elif SANITIZER_FREEBSD
 unsigned struct_ElfW_Phdr_sz = sizeof(Elf_Phdr);
 #endif
 
-#if SANITIZER_LINUX && !SANITIZER_ANDROID
+#ifdef __GLIBC__
   int glob_nomatch = GLOB_NOMATCH;
   int glob_altdirfunc = GLOB_ALTDIRFUNC;
 #endif
 
-#if SANITIZER_LINUX && !SANITIZER_ANDROID &&                               \
+#if defined(__GLIBC__) &&                                                  \
     (defined(__i386) || defined(__x86_64) || defined(__mips64) ||          \
      defined(__powerpc64__) || defined(__aarch64__) || defined(__arm__) || \
      defined(__s390__) || SANITIZER_RISCV64)
 #if defined(__mips64) || defined(__powerpc64__) || defined(__arm__)
   unsigned struct_user_regs_struct_sz = sizeof(struct pt_regs);
   unsigned struct_user_fpregs_struct_sz = sizeof(elf_fpregset_t);
 #elif SANITIZER_RISCV64
   unsigned struct_user_regs_struct_sz = sizeof(struct user_regs_struct);
#if SANITIZER_LINUX
   unsigned struct_floppy_write_errors_sz = sizeof(struct floppy_write_errors);
   unsigned struct_format_descr_sz = sizeof(struct format_descr);
   unsigned struct_hd_driveid_sz = sizeof(struct hd_driveid);
   unsigned struct_hd_geometry_sz = sizeof(struct hd_geometry);
   unsigned struct_input_absinfo_sz = sizeof(struct input_absinfo);
   unsigned struct_input_id_sz = sizeof(struct input_id);
   unsigned struct_mtpos_sz = sizeof(struct mtpos);
   unsigned struct_rtentry_sz = sizeof(struct rtentry);
+#if defined(__GLIBC__) || SANITIZER_ANDROID
   unsigned struct_termio_sz = sizeof(struct termio);
+#endif
   unsigned struct_vt_consize_sz = sizeof(struct vt_consize);
   unsigned struct_vt_sizes_sz = sizeof(struct vt_sizes);
   unsigned struct_vt_stat_sz = sizeof(struct vt_stat);
 #endif // SANITIZER_LINUX
 
 #if SANITIZER_LINUX
 #if SOUND_VERSION >= 0x040000
   unsigned struct_copr_buffer_sz = 0;
#endif
   unsigned struct_mtop_sz = sizeof(struct mtop);
   unsigned struct_sbi_instrument_sz = sizeof(struct sbi_instrument);
   unsigned struct_seq_event_rec_sz = sizeof(struct seq_event_rec);
   unsigned struct_synth_info_sz = sizeof(struct synth_info);
   unsigned struct_vt_mode_sz = sizeof(struct vt_mode);
 #endif // SANITIZER_LINUX
 
 #if SANITIZER_LINUX && !SANITIZER_ANDROID
+#ifdef __GLIBC__
   unsigned struct_ax25_parms_struct_sz = sizeof(struct ax25_parms_struct);
+#endif
   unsigned struct_cyclades_monitor_sz = sizeof(struct cyclades_monitor);
 #if EV_VERSION > (0x010000)
   unsigned struct_input_keymap_entry_sz = sizeof(struct input_keymap_entry);
 #else
   unsigned struct_input_keymap_entry_sz = 0;
 #endif
   unsigned struct_ipx_config_data_sz = sizeof(struct ipx_config_data);
   unsigned struct_kbdiacrs_sz = sizeof(struct kbdiacrs);
   unsigned struct_kbentry_sz = sizeof(struct kbentry);
   unsigned struct_kbkeycode_sz = sizeof(struct kbkeycode);
   unsigned struct_kbsentry_sz = sizeof(struct kbsentry);
+#ifdef __GLIBC__
   unsigned struct_mtconfiginfo_sz = sizeof(struct mtconfiginfo);
   unsigned struct_nr_parms_struct_sz = sizeof(struct nr_parms_struct);
+#endif
   unsigned struct_scc_modem_sz = sizeof(struct scc_modem);
   unsigned struct_scc_stat_sz = sizeof(struct scc_stat);
+#ifdef __GLIBC__
   unsigned struct_serial_multiport_struct_sz
       = sizeof(struct serial_multiport_struct);
   unsigned struct_serial_struct_sz = sizeof(struct serial_struct);
+#endif
   unsigned struct_sockaddr_ax25_sz = sizeof(struct sockaddr_ax25);
   unsigned struct_unimapdesc_sz = sizeof(struct unimapdesc);
   unsigned struct_unimapinit_sz = sizeof(struct unimapinit);
 #endif // SANITIZER_LINUX && !SANITIZER_ANDROID
 
 #if SANITIZER_LINUX && !SANITIZER_ANDROID
   unsigned struct_audio_buf_info_sz = sizeof(struct audio_buf_info);
   unsigned struct_ppp_stats_sz = sizeof(struct ppp_stats);
 #endif // (SANITIZER_LINUX || SANITIZER_FREEBSD) && !SANITIZER_ANDROID
 
 #if !SANITIZER_ANDROID && !SANITIZER_MAC
   unsigned struct_sioc_sg_req_sz = sizeof(struct sioc_sg_req);
   unsigned struct_sioc_vif_req_sz = sizeof(struct sioc_vif_req);
 #endif
 
+#if defined(BUFSIZ)
   const unsigned long __sanitizer_bufsiz = BUFSIZ;
+#else
+  const unsigned long __sanitizer_bufsiz = 4096;
+#endif
 
   const unsigned IOCTL_NOT_PRESENT = 0;
 
   unsigned IOCTL_FIOASYNC = FIOASYNC;
   unsigned IOCTL_FIOCLEX = FIOCLEX;
   unsigned IOCTL_FIOGETOWN = FIOGETOWN;
   unsigned IOCTL_FIONBIO = FIONBIO;
   unsigned IOCTL_FIONCLEX = FIONCLEX;
#endif
   unsigned IOCTL_LPCAREFUL = LPCAREFUL;
   unsigned IOCTL_LPCHAR = LPCHAR;
   unsigned IOCTL_LPGETIRQ = LPGETIRQ;
   unsigned IOCTL_LPGETSTATUS = LPGETSTATUS;
   unsigned IOCTL_LPRESET = LPRESET;
   unsigned IOCTL_LPSETIRQ = LPSETIRQ;
   unsigned IOCTL_LPTIME = LPTIME;
   unsigned IOCTL_LPWAIT = LPWAIT;
+#ifdef __GLIBC__
   unsigned IOCTL_MTIOCGETCONFIG = MTIOCGETCONFIG;
   unsigned IOCTL_MTIOCSETCONFIG = MTIOCSETCONFIG;
+#endif
   unsigned IOCTL_PIO_CMAP = PIO_CMAP;
   unsigned IOCTL_PIO_FONT = PIO_FONT;
   unsigned IOCTL_PIO_UNIMAP = PIO_UNIMAP;
   unsigned IOCTL_PIO_UNIMAPCLR = PIO_UNIMAPCLR;
   unsigned IOCTL_PIO_UNISCRNMAP = PIO_UNISCRNMAP;
+#ifdef __GLIBC__
   unsigned IOCTL_SCSI_IOCTL_GET_IDLUN = SCSI_IOCTL_GET_IDLUN;
   unsigned IOCTL_SCSI_IOCTL_PROBE_HOST = SCSI_IOCTL_PROBE_HOST;
   unsigned IOCTL_SCSI_IOCTL_TAGGED_DISABLE = SCSI_IOCTL_TAGGED_DISABLE;
   unsigned IOCTL_SCSI_IOCTL_TAGGED_ENABLE = SCSI_IOCTL_TAGGED_ENABLE;
+#endif
   unsigned IOCTL_SIOCAIPXITFCRT = SIOCAIPXITFCRT;
   unsigned IOCTL_SIOCAIPXPRISLT = SIOCAIPXPRISLT;
   unsigned IOCTL_SIOCAX25ADDUID = SIOCAX25ADDUID;
   unsigned IOCTL_SIOCAX25DELUID = SIOCAX25DELUID;
+#ifdef __GLIBC__
   unsigned IOCTL_SIOCAX25GETPARMS = SIOCAX25GETPARMS;
+#endif
   unsigned IOCTL_SIOCAX25GETUID = SIOCAX25GETUID;
   unsigned IOCTL_SIOCAX25NOUID = SIOCAX25NOUID;
+#ifdef __GLIBC__
   unsigned IOCTL_SIOCAX25SETPARMS = SIOCAX25SETPARMS;
+#endif
   unsigned IOCTL_SIOCDEVPLIP = SIOCDEVPLIP;
   unsigned IOCTL_SIOCIPXCFGDATA = SIOCIPXCFGDATA;
   unsigned IOCTL_SIOCNRDECOBS = SIOCNRDECOBS;
+#ifdef __GLIBC__
   unsigned IOCTL_SIOCNRGETPARMS = SIOCNRGETPARMS;
   unsigned IOCTL_SIOCNRRTCTL = SIOCNRRTCTL;
   unsigned IOCTL_SIOCNRSETPARMS = SIOCNRSETPARMS;
+#endif
   unsigned IOCTL_TIOCGSERIAL = TIOCGSERIAL;
   unsigned IOCTL_TIOCSERGETMULTI = TIOCSERGETMULTI;
   unsigned IOCTL_TIOCSERSETMULTI = TIOCSERSETMULTI;
   unsigned IOCTL_TIOCSSERIAL = TIOCSSERIAL;
 #endif // SANITIZER_LINUX && !SANITIZER_ANDROID
 
 #if SANITIZER_LINUX && !SANITIZER_ANDROID
   unsigned IOCTL_GIO_SCRNMAP = GIO_SCRNMAP;

 // in.
 COMPILER_CHECK(sizeof(__sanitizer_dl_phdr_info) <= sizeof(dl_phdr_info));
 CHECK_SIZE_AND_OFFSET(dl_phdr_info, dlpi_addr);
 CHECK_SIZE_AND_OFFSET(dl_phdr_info, dlpi_name);
 CHECK_SIZE_AND_OFFSET(dl_phdr_info, dlpi_phdr);
 CHECK_SIZE_AND_OFFSET(dl_phdr_info, dlpi_phnum);
 #endif // SANITIZER_LINUX || SANITIZER_FREEBSD
 
-#if (SANITIZER_LINUX || SANITIZER_FREEBSD) && !SANITIZER_ANDROID
+#if defined(__GLIBC__) || SANITIZER_FREEBSD
 CHECK_TYPE_SIZE(glob_t);
 CHECK_SIZE_AND_OFFSET(glob_t, gl_pathc);
 CHECK_SIZE_AND_OFFSET(glob_t, gl_pathv);
 CHECK_SIZE_AND_OFFSET(glob_t, gl_offs);
 CHECK_SIZE_AND_OFFSET(glob_t, gl_flags);
 CHECK_SIZE_AND_OFFSET(glob_t, gl_closedir);
 CHECK_SIZE_AND_OFFSET(glob_t, gl_readdir);
 CHECK_SIZE_AND_OFFSET(glob_t, gl_opendir);
 CHECK_SIZE_AND_OFFSET(glob_t, gl_lstat);
 CHECK_SIZE_AND_OFFSET(glob_t, gl_stat);
-#endif
+#endif  // defined(__GLIBC__) || SANITIZER_FREEBSD
 
 CHECK_TYPE_SIZE(addrinfo);
 CHECK_SIZE_AND_OFFSET(addrinfo, ai_flags);
 CHECK_SIZE_AND_OFFSET(addrinfo, ai_family);
 CHECK_SIZE_AND_OFFSET(addrinfo, ai_socktype);
 CHECK_SIZE_AND_OFFSET(addrinfo, ai_protocol);
 CHECK_SIZE_AND_OFFSET(addrinfo, ai_protocol);
 CHECK_SIZE_AND_OFFSET(addrinfo, ai_addrlen);
 CHECK_SIZE_AND_OFFSET(addrinfo, ai_canonname);
 CHECK_SIZE_AND_OFFSET(addrinfo, ai_addr);
 
 CHECK_TYPE_SIZE(hostent);
 CHECK_SIZE_AND_OFFSET(hostent, h_name);
 CHECK_SIZE_AND_OFFSET(hostent, h_aliases);
 CHECK_SIZE_AND_OFFSET(hostent, h_addrtype);
 CHECK_SIZE_AND_OFFSET(hostent, h_length);
 CHECK_SIZE_AND_OFFSET(hostent, h_addr_list);
 
 CHECK_TYPE_SIZE(iovec);
 CHECK_SIZE_AND_OFFSET(iovec, iov_base);
 CHECK_SIZE_AND_OFFSET(iovec, iov_len);
 
+#if defined(__GLIBC__) || SANITIZER_ANDROID
 CHECK_TYPE_SIZE(msghdr);
 CHECK_SIZE_AND_OFFSET(msghdr, msg_name);
 CHECK_SIZE_AND_OFFSET(msghdr, msg_namelen);
 CHECK_SIZE_AND_OFFSET(msghdr, msg_iov);
 CHECK_SIZE_AND_OFFSET(msghdr, msg_iovlen);
 CHECK_SIZE_AND_OFFSET(msghdr, msg_control);
 CHECK_SIZE_AND_OFFSET(msghdr, msg_controllen);
 CHECK_SIZE_AND_OFFSET(msghdr, msg_flags);
 
 CHECK_TYPE_SIZE(cmsghdr);
 CHECK_SIZE_AND_OFFSET(cmsghdr, cmsg_len);
 CHECK_SIZE_AND_OFFSET(cmsghdr, cmsg_level);
 CHECK_SIZE_AND_OFFSET(cmsghdr, cmsg_type);
+#endif
 
 #if SANITIZER_LINUX && (__ANDROID_API__ >= 21 || __GLIBC_PREREQ (2, 14))
 CHECK_TYPE_SIZE(mmsghdr);
 CHECK_SIZE_AND_OFFSET(mmsghdr, msg_hdr);
 CHECK_SIZE_AND_OFFSET(mmsghdr, msg_len);
 #endif
 
 COMPILER_CHECK(sizeof(__sanitizer_dirent) <= sizeof(dirent));

 CHECK_SIZE_AND_OFFSET(mntent, mnt_type);
 CHECK_SIZE_AND_OFFSET(mntent, mnt_opts);
 CHECK_SIZE_AND_OFFSET(mntent, mnt_freq);
 CHECK_SIZE_AND_OFFSET(mntent, mnt_passno);
 #endif
 
 CHECK_TYPE_SIZE(ether_addr);
 
-#if (SANITIZER_LINUX || SANITIZER_FREEBSD) && !SANITIZER_ANDROID
+#if defined(__GLIBC__) || SANITIZER_FREEBSD
 CHECK_TYPE_SIZE(ipc_perm);
 # if SANITIZER_FREEBSD
 CHECK_SIZE_AND_OFFSET(ipc_perm, key);
 CHECK_SIZE_AND_OFFSET(ipc_perm, seq);
 # else
 CHECK_SIZE_AND_OFFSET(ipc_perm, __key);
 CHECK_SIZE_AND_OFFSET(ipc_perm, __seq);
 # endif
COMPILER_CHECK(offsetof(__sanitizer_ifaddrs, ifa_dstaddr) ==
                offsetof(ifaddrs, ifa_ifu));
 # endif // SANITIZER_FREEBSD
 #else
 CHECK_SIZE_AND_OFFSET(ifaddrs, ifa_dstaddr);
 #endif // SANITIZER_LINUX
 CHECK_SIZE_AND_OFFSET(ifaddrs, ifa_data);
 #endif
 
-#if SANITIZER_LINUX
+#if defined(__GLIBC__) || SANITIZER_ANDROID
 COMPILER_CHECK(sizeof(__sanitizer_struct_mallinfo) == sizeof(struct mallinfo));
 #endif
 
 #if !SANITIZER_ANDROID
 CHECK_TYPE_SIZE(timeb);
 CHECK_SIZE_AND_OFFSET(timeb, time);
 CHECK_SIZE_AND_OFFSET(timeb, millitm);
 CHECK_SIZE_AND_OFFSET(timeb, timezone);

 CHECK_SIZE_AND_OFFSET(XDR, x_private);
 CHECK_SIZE_AND_OFFSET(XDR, x_base);
 CHECK_SIZE_AND_OFFSET(XDR, x_handy);
 COMPILER_CHECK(__sanitizer_XDR_ENCODE == XDR_ENCODE);
 COMPILER_CHECK(__sanitizer_XDR_DECODE == XDR_DECODE);
 COMPILER_CHECK(__sanitizer_XDR_FREE == XDR_FREE);
 #endif
 
-#if SANITIZER_LINUX && !SANITIZER_ANDROID
+#ifdef __GLIBC__
 COMPILER_CHECK(sizeof(__sanitizer_FILE) <= sizeof(FILE));
 CHECK_SIZE_AND_OFFSET(FILE, _flags);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_read_ptr);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_read_end);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_read_base);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_write_ptr);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_write_end);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_write_base);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_buf_base);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_buf_end);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_save_base);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_backup_base);
 CHECK_SIZE_AND_OFFSET(FILE, _IO_save_end);
 CHECK_SIZE_AND_OFFSET(FILE, _markers);
 CHECK_SIZE_AND_OFFSET(FILE, _chain);
 CHECK_SIZE_AND_OFFSET(FILE, _fileno);
-#endif
 
-#if SANITIZER_LINUX && !SANITIZER_ANDROID
 COMPILER_CHECK(sizeof(__sanitizer__obstack_chunk) <= sizeof(_obstack_chunk));
 CHECK_SIZE_AND_OFFSET(_obstack_chunk, limit);
 CHECK_SIZE_AND_OFFSET(_obstack_chunk, prev);
 CHECK_TYPE_SIZE(obstack);
 CHECK_SIZE_AND_OFFSET(obstack, chunk_size);
 CHECK_SIZE_AND_OFFSET(obstack, chunk);
 CHECK_SIZE_AND_OFFSET(obstack, object_base);
 CHECK_SIZE_AND_OFFSET(obstack, next_free);
 
 CHECK_TYPE_SIZE(cookie_io_functions_t);
 CHECK_SIZE_AND_OFFSET(cookie_io_functions_t, read);
 CHECK_SIZE_AND_OFFSET(cookie_io_functions_t, write);
 CHECK_SIZE_AND_OFFSET(cookie_io_functions_t, seek);
 CHECK_SIZE_AND_OFFSET(cookie_io_functions_t, close);
-#endif
+#endif  // __GLIBC__
 
 #if SANITIZER_LINUX || SANITIZER_FREEBSD
 CHECK_TYPE_SIZE(sem_t);
 #endif
 
 #if SANITIZER_LINUX && defined(__arm__)
 COMPILER_CHECK(ARM_VFPREGS_SIZE == ARM_VFPREGS_SIZE_ASAN);
 #endif
 
 #endif // SANITIZER_LINUX || SANITIZER_FREEBSD || SANITIZER_MAC