- User Since
- Dec 3 2015, 1:10 AM (202 w, 4 d)
Thu, Oct 17
I got another testcase that also started failing with the original commit that I hoped would be the same problem, but that isn't solved yet with this fix so I'll need to dig into that one and see what's going on there.
Wed, Oct 16
I'm struggling with a case for my out-of-tree target where I think debug info is wrong with this change.
Mon, Oct 7
Sun, Oct 6
clang-cuda-build buildbot failed too:
Fri, Oct 4
Does this make sense?
Wed, Oct 2
Wed, Sep 25
Disallow this case in ValidTriangle instead.
Tue, Sep 24
Mon, Sep 23
Sep 20 2019
It fixes the problem I reported. Thanks!
Sep 11 2019
I've no idea if the fix itself makes sense but at least it does seem to fix my reproducer for PR38513 and I didn't see any problems with the patch during the (limited) testing I've done.
Sep 10 2019
When compiling with gcc, we get warnings with this commit:
[100/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regfree.c.o cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C [101/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regstrlcpy.c.o cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C [102/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regerror.c.o cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C [107/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regexec.c.o cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C [114/4153] Building C object lib/Support/CMakeFiles/LLVMSupport.dir/regcomp.c.o cc1: warning: command line option '-fno-rtti' is valid for C++/ObjC++ but not for C
Sep 6 2019
I did a minor change to the test case in r371171 since the
checks matched on the line
;ModuleID = '/repo/bb/
in the output instead of the wanted "bb.0:".
Sep 4 2019
Normally we do use basicaa, the crash was found in "fuzz" tests where we compile the code with random flags.
Why would it be ok to give the assert when we run
I've hit the new assertion when compiling for my out of tree target when using -Osize in combination with
Aug 16 2019
Jul 11 2019
Jul 10 2019
Jul 9 2019
Jul 4 2019
Jun 27 2019
Jun 17 2019
Jun 14 2019
Jun 12 2019
With r363169 the problem seems to be fixed, so this patch is probably not needed anymore.
Jun 10 2019
Jun 6 2019
Jun 5 2019
Jun 3 2019
Jun 2 2019
May 20 2019
May 14 2019
May 12 2019
May 10 2019
When the assertion fails we have:
(gdb) call F.dump()
May 9 2019
With this patch the following starts hitting an assertion:
May 8 2019
This is as far as I've come:
I'm experiencing problems with this patch as well. I'm not 100% sure what the
problem is yet but I have a suspicion:
May 3 2019
Anyone has an opinion about this?
Rebased, fixed a spelling mistake.
Apr 29 2019
Should we/someone push this?
Apr 24 2019
Thanks for fixing!
The original case where I saw the crash compiles successfully with this patch.
Apr 16 2019
I see crashed with this patch. E.g.
Apr 10 2019
Apr 3 2019
When looking at some code changes for my out-of-tree target with this commit I noticed a change that I thought I'd ask if you think
is good or not.
Apr 2 2019
I noticed that with this commit I get a whole bunch (~40) of warnings like the below when compiling with gcc 7.4:
[10/16] Building CXX object tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/clangTidyUtils.dir/HeaderGuard.cpp.o In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:12:0, from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9: ../tools/clang/tools/extra/clang-tidy/utils/../ClangTidy.h:161:16: warning: 'virtual void clang::tidy::ClangTidyCheck::registerPPCallbacks(const clang::SourceManager&, clang::Preprocessor*, clang::Preprocessor*)' was hidden [-Woverloaded-virtual] virtual void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP, ^~~~~~~~~~~~~~~~~~~ In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9:0: ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:35:8: warning: by 'virtual void clang::tidy::utils::HeaderGuardCheck::registerPPCallbacks(clang::CompilerInstance&)' [-Woverloaded-virtual] void registerPPCallbacks(CompilerInstance &Compiler) override; ^~~~~~~~~~~~~~~~~~~