- User Since
- Dec 3 2015, 1:10 AM (176 w, 4 d)
Tue, Apr 16
I see crashed with this patch. E.g.
Wed, Apr 10
Wed, Apr 3
When looking at some code changes for my out-of-tree target with this commit I noticed a change that I thought I'd ask if you think
is good or not.
Tue, Apr 2
I noticed that with this commit I get a whole bunch (~40) of warnings like the below when compiling with gcc 7.4:
[10/16] Building CXX object tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/clangTidyUtils.dir/HeaderGuard.cpp.o In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:12:0, from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9: ../tools/clang/tools/extra/clang-tidy/utils/../ClangTidy.h:161:16: warning: 'virtual void clang::tidy::ClangTidyCheck::registerPPCallbacks(const clang::SourceManager&, clang::Preprocessor*, clang::Preprocessor*)' was hidden [-Woverloaded-virtual] virtual void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP, ^~~~~~~~~~~~~~~~~~~ In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9:0: ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:35:8: warning: by 'virtual void clang::tidy::utils::HeaderGuardCheck::registerPPCallbacks(clang::CompilerInstance&)' [-Woverloaded-virtual] void registerPPCallbacks(CompilerInstance &Compiler) override; ^~~~~~~~~~~~~~~~~~~
Mon, Apr 1
Great! I'll update the test and submit in a little bit.
Mar 21 2019
Mar 15 2019
I'll push this for JesperAntonsson in a bit since he's having some environment issues.
Mar 14 2019
Feb 26 2019
Added a few nits about too long lines.
Nice! I ran a new bunch of llvm-stress tests with this patch and now I don't see the crashes anymore.
Feb 19 2019
Feb 18 2019
Feb 14 2019
Nice to see this fix get in because we've seen the need for such a change for our out-of-tree target as well.
Feb 13 2019
Thanks for fixing!
Feb 6 2019
Managed to drop the new testcase when I rebased >.<
Is this ok or is it better to go down the CGP route instead? If so, can we really guarantee that all dead code is always removed when we get to StackProtector so we don't end up with this problem anyway?
Jan 31 2019
Jan 30 2019
The fix makes sense to me but please let others have an opinion too.
Jan 29 2019
We're having issues with this as well, we don't have any libunwind so this change causes
/usr/bin/ld: cannot find -lunwind
Jan 28 2019
Jan 25 2019
I don't know this code at all.
It solves the problem I saw, thanks!
Jan 24 2019
Fixed typo, reformulated a piece of a comment.
Not sure who should review this, I added the three last persons that I think did non-NFC changes to StackProtector.cpp.
Is this a proper way of solving the problem? Is it ok to require DT?
Jan 22 2019
Just saw build-bots failed the same way
We've been having issues with std::is_trivially_copyable too, and it seems not even this patch solves the problems for us.
Jan 2 2019
The problem I saw goes away with this patch and I haven't seen any new failures with the limited testing I've done on the patch. Thanks!
I don't know this code though, so I don't know if this is the way the problem should be solved.
Dec 12 2018
Dec 11 2018
Dec 10 2018
If I change what I think is two typos, then the patch compiles for me and solves the issue I had.
A late question about this change. I notice that this change sometimes gives me additional DIFiles in the clang output compared to before.
E.g. if I have a file
Dec 6 2018
I don't know this code but at least it makes the reproducer I had compile succesfully now. Thanks!
Dec 5 2018
Nov 30 2018
Nov 23 2018
I've verifed that it solves the problem I reported. I've done a little bit of testing with the patch and didn't see anything obviously broken yet at least.
Nov 21 2018
I submitted this for markus since he doesn't have commit access yet.
Nov 15 2018
Nov 7 2018
I've got a post-review comment about the use of SCHED_IDLE vs the needed gcc version.
Oct 17 2018
Was it something like this you had in mind Eli?
Oct 16 2018
Oct 15 2018
A late comment about a problem I've noticed with this change.
Oct 2 2018
We are using the Scalarizer in our out-of-tree target and I've run some tests with the patch without problems so I think it's ok.
Please wait a day before submitting though in case someone who really knows this code objects, but if not I think it's ok to push.