- User Since
- Dec 3 2015, 1:10 AM (184 w, 6 d)
Mon, Jun 17
Fri, Jun 14
Wed, Jun 12
With r363169 the problem seems to be fixed, so this patch is probably not needed anymore.
Mon, Jun 10
Thu, Jun 6
Wed, Jun 5
Mon, Jun 3
Sun, Jun 2
May 20 2019
May 14 2019
May 12 2019
May 10 2019
When the assertion fails we have:
(gdb) call F.dump()
May 9 2019
With this patch the following starts hitting an assertion:
May 8 2019
This is as far as I've come:
I'm experiencing problems with this patch as well. I'm not 100% sure what the
problem is yet but I have a suspicion:
May 3 2019
Anyone has an opinion about this?
Rebased, fixed a spelling mistake.
Apr 29 2019
Should we/someone push this?
Apr 24 2019
Thanks for fixing!
The original case where I saw the crash compiles successfully with this patch.
Apr 16 2019
I see crashed with this patch. E.g.
Apr 10 2019
Apr 3 2019
When looking at some code changes for my out-of-tree target with this commit I noticed a change that I thought I'd ask if you think
is good or not.
Apr 2 2019
I noticed that with this commit I get a whole bunch (~40) of warnings like the below when compiling with gcc 7.4:
[10/16] Building CXX object tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/clangTidyUtils.dir/HeaderGuard.cpp.o In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:12:0, from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9: ../tools/clang/tools/extra/clang-tidy/utils/../ClangTidy.h:161:16: warning: 'virtual void clang::tidy::ClangTidyCheck::registerPPCallbacks(const clang::SourceManager&, clang::Preprocessor*, clang::Preprocessor*)' was hidden [-Woverloaded-virtual] virtual void registerPPCallbacks(const SourceManager &SM, Preprocessor *PP, ^~~~~~~~~~~~~~~~~~~ In file included from ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.cpp:9:0: ../tools/clang/tools/extra/clang-tidy/utils/HeaderGuard.h:35:8: warning: by 'virtual void clang::tidy::utils::HeaderGuardCheck::registerPPCallbacks(clang::CompilerInstance&)' [-Woverloaded-virtual] void registerPPCallbacks(CompilerInstance &Compiler) override; ^~~~~~~~~~~~~~~~~~~
Apr 1 2019
Great! I'll update the test and submit in a little bit.
Mar 21 2019
Mar 15 2019
I'll push this for JesperAntonsson in a bit since he's having some environment issues.
Mar 14 2019
Feb 26 2019
Added a few nits about too long lines.
Nice! I ran a new bunch of llvm-stress tests with this patch and now I don't see the crashes anymore.
Feb 19 2019
Feb 18 2019
Feb 14 2019
Nice to see this fix get in because we've seen the need for such a change for our out-of-tree target as well.
Feb 13 2019
Thanks for fixing!
Feb 6 2019
Managed to drop the new testcase when I rebased >.<
Is this ok or is it better to go down the CGP route instead? If so, can we really guarantee that all dead code is always removed when we get to StackProtector so we don't end up with this problem anyway?
Jan 31 2019
Jan 30 2019
The fix makes sense to me but please let others have an opinion too.
Jan 29 2019
We're having issues with this as well, we don't have any libunwind so this change causes
/usr/bin/ld: cannot find -lunwind
Jan 28 2019
Jan 25 2019
I don't know this code at all.
It solves the problem I saw, thanks!
Jan 24 2019
Fixed typo, reformulated a piece of a comment.
Not sure who should review this, I added the three last persons that I think did non-NFC changes to StackProtector.cpp.
Is this a proper way of solving the problem? Is it ok to require DT?