Page MenuHomePhabricator
Differential D93866

[sanitizer-common] Delete ancient glibc TLS workaround
AbandonedPublic
Actions

Authored by MaskRay on Dec 28 2020, 11:01 AM.

Details

Reviewers
zatrazz
vitalybuka
Group Reviewers
Restricted Project
Summary

rL156542 introduced this to work around very old glibc. This should be no longer needed.

Diff Detail

Unit TestsFailed
View All

TimeTest
10 msx64 debian > SanitizerCommon-Unit._/Sanitizer-x86_64-Test::SanitizerCommon.ThreadStackTlsWorker
Note: Google Test filter = SanitizerCommon.ThreadStackTlsWorker [==========] Running 1 test from 1 test case. [----------] Global test environment set-up.
800 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::tls_race2.cpp
Script: -- : 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=thread -Wall -m64 -gline-tables-only -I/mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/tsan/../ -std=c++11 -I/mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/tsan/../ -O1 /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/tsan/tls_race2.cpp -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/tls_race2.cpp.tmp && /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/tsan/deflake.bash 10 /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/tls_race2.cpp.tmp | FileCheck /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/tsan/tls_race2.cpp --check-prefix=CHECK-Linux --check-prefix=CHECK

Event Timeline

MaskRay requested review of this revision.Dec 28 2020, 11:01 AM
MaskRay created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2020, 11:01 AM
MaskRay mentioned this in D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.Dec 28 2020, 11:01 AM
Harbormaster completed remote builds in B83594: Diff 313877.Dec 28 2020, 11:36 AM
vitalybuka accepted this revision.Dec 28 2020, 1:14 PM
This revision is now accepted and ready to land.Dec 28 2020, 1:14 PM
MaskRay mentioned this in D40159: Correct handling of the TLS/NetBSD block of the main program.Jan 1 2021, 8:28 PM
MaskRay mentioned this in D93972: [sanizier] Implement GetTls on musl.Jan 5 2021, 2:18 PM
MaskRay abandoned this revision.Mar 25 2021, 10:11 PM

My understanding was incorrect:( On glibc/musl and potentially other libc implementations, the static TLS range may be part of the allocated thread stack. *stk_size -= *tls_size; looks a bit weird, though. Hope D98926 sticks and fixes the problem

Revision Contents
Changeset List

PathSize
compiler-rt/
lib/
sanitizer_common/
10 lines

Diff 313877

View Options

compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp

Loading...