This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer-common] Delete ancient glibc TLS workaround

Authored by MaskRay on Dec 28 2020, 11:01 AM.


Group Reviewers
Restricted Project

rL156542 introduced this to work around very old glibc. This should be no longer needed.

Diff Detail

Event Timeline

MaskRay requested review of this revision.Dec 28 2020, 11:01 AM
MaskRay created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 28 2020, 11:01 AM
vitalybuka accepted this revision.Dec 28 2020, 1:14 PM
This revision is now accepted and ready to land.Dec 28 2020, 1:14 PM
MaskRay abandoned this revision.Mar 25 2021, 10:11 PM

My understanding was incorrect:( On glibc/musl and potentially other libc implementations, the static TLS range may be part of the allocated thread stack. *stk_size -= *tls_size; looks a bit weird, though. Hope D98926 sticks and fixes the problem