krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (160 w, 1 d)

Recent Activity

Wed, Sep 5

krytarowski resigned from D51681: [Msan] Fix unit test linkage issue on FreeBSD.
Wed, Sep 5, 6:11 AM
krytarowski added a comment to D51681: [Msan] Fix unit test linkage issue on FreeBSD.

In general -fPIC is probably the way to go.. but I don't know about this particular case. I defer decision to FreeBSD maintainers.

Wed, Sep 5, 5:59 AM
krytarowski added a comment to D51681: [Msan] Fix unit test linkage issue on FreeBSD.

What's the error message?

Wed, Sep 5, 5:53 AM

Tue, Sep 4

krytarowski added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

Now SANITIZER_NETBSD shares almost nothing with the rest
May I ask you to create sanitizer_netbsd.cc and move code there?

Tue, Sep 4, 5:11 PM · Restricted Project
krytarowski added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

ping?

Tue, Sep 4, 9:03 AM · Restricted Project

Mon, Sep 3

krytarowski added a comment to D51577: MidnightBSD support in LLVM.

https://llvm.org/docs/HowToAddABuilder.html

Mon, Sep 3, 8:08 AM
krytarowski added a comment to D51577: MidnightBSD support in LLVM.

Adding some more context, there are a few remixes of FreeBSD such as TruOS, GhostBSD, DesktopBSD etc... and all of them are custom reconfiguration of defaults and they keep self recognition to __FreeBSD__. MidnightBSD is similar, it's a remix of FreeBSD with GNUSTEP. For some reason the project decided to fork the FreeBSD distribution entirely, however over the years there were no[t so many] distinct features to recognize this OS as a distinct version of BSD ( https://github.com/freebsd/freebsd/blob/master/share/misc/bsd-family-tree ).

Mon, Sep 3, 4:12 AM
krytarowski added a comment to D51577: MidnightBSD support in LLVM.

Are there any actual codegen changes vs. FreeBSD, since you seem to have just added handling to everywhere FreeBSD is? if not, can you just make this an alias of freebsd in the triple parsing?

Mon, Sep 3, 3:41 AM

Sun, Sep 2

krytarowski added a comment to D51577: MidnightBSD support in LLVM.

Why to patch mips-specific code for MidnightBSD? Why to patch code for sanitizers and instrumentation in general?

Sun, Sep 2, 1:31 PM

Fri, Aug 31

krytarowski updated the diff for D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

When possible, switch indirect calls to direct calls of internal libc symbols.

Fri, Aug 31, 2:29 PM · Restricted Project
krytarowski added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

What's the internal variant for e.g. dup2(2) or getpid(2)?

Fri, Aug 31, 6:03 AM · Restricted Project

Thu, Aug 30

krytarowski added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

OK, it looks like these ones are cancel points. I will switch them to _sys_.

Thu, Aug 30, 4:09 AM · Restricted Project
krytarowski added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

Personally, I prefer to go for public symbols as with next major libc bump, they might stay around. So not depend too much on the internals that shall be rather not used by 3rd party software.

Thu, Aug 30, 2:35 AM · Restricted Project
krytarowski added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

_sys_ seems to be available only for a small set of of system calls and is not universal.

Thu, Aug 30, 2:20 AM · Restricted Project

Wed, Aug 29

krytarowski created D51425: Add internal_sysctl() used by FreeBSD, NetBSD, OpenBSD and MacOSX.
Wed, Aug 29, 7:05 AM · Restricted Project
krytarowski added a comment to D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.

Just curious, any impact in term of performance ?

Wed, Aug 29, 6:24 AM · Restricted Project
krytarowski updated the summary of D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.
Wed, Aug 29, 6:15 AM · Restricted Project
krytarowski created D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.
Wed, Aug 29, 6:10 AM · Restricted Project
krytarowski added a comment to D51106: Introduce new type for inteceptors UINTMAX_T.

I will prepare a test and submit as a new revision to review.

Wed, Aug 29, 2:12 AM · Restricted Project

Tue, Aug 28

krytarowski added a comment to D51106: Introduce new type for inteceptors UINTMAX_T.

Do you mean a test for strtoumax(3)?

Tue, Aug 28, 1:25 PM · Restricted Project
krytarowski added a comment to D51106: Introduce new type for inteceptors UINTMAX_T.

ping?

Tue, Aug 28, 11:38 AM · Restricted Project
krytarowski added a comment to D51368: SafeStack: Fix thread liveness check on *BSD.

NetBSD is fixed, as I was observing previously:

Tue, Aug 28, 11:27 AM
krytarowski added a comment to D51368: SafeStack: Fix thread liveness check on *BSD.
[100%] Running the SafeStack tests
-- Testing: 9 tests, 8 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 0.61s
  Expected Passes    : 8
  Unsupported Tests  : 1
[100%] Built target check-safestack
Tue, Aug 28, 11:14 AM
krytarowski added a comment to D51368: SafeStack: Fix thread liveness check on *BSD.

I'm going to test NetBSD soon.

Tue, Aug 28, 11:05 AM

Aug 22 2018

krytarowski created D51106: Introduce new type for inteceptors UINTMAX_T.
Aug 22 2018, 8:39 AM · Restricted Project
krytarowski added a comment to D50894: Pull google/benchmark library to the LLVM tree.

From NetBSD point of view, this looks fine, 1.4.1 contains upstreamed support.

Aug 22 2018, 7:28 AM

Aug 20 2018

krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

@chandlerc thank you for your note. I've originally treated this change as an obvious code change, just the reviewers regardless of reviewing an analogous change for MUSL, had no interest in NetBSD.

Aug 20 2018, 1:39 PM
krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

If there are no more comments, I will land this by the end of this week.

Aug 20 2018, 12:51 PM
krytarowski added a comment to D50413: [libunwind][include] Add some missing definitions to <unwind.h>..

From my point of view, the number of people who have idea about these types and why do they differ between ABIs and OSes is so low, that it's even hard to get someone to review it here.

Aug 20 2018, 12:19 PM

Aug 8 2018

krytarowski updated subscribers of D50413: [libunwind][include] Add some missing definitions to <unwind.h>..

NetBSD uses typedef void *_Unwind_Ptr; unconditionally in its <unwind.h>... if that has to be matched.

Done.

Additionally: typedef long _Unwind_Word;.

Done.

Aug 8 2018, 9:18 AM

Aug 7 2018

krytarowski added a comment to D50413: [libunwind][include] Add some missing definitions to <unwind.h>..

NetBSD uses typedef void *_Unwind_Ptr; unconditionally in its <unwind.h>... if that has to be matched.

Aug 7 2018, 5:09 PM

Aug 1 2018

krytarowski added inline comments to D49942: [ASAN] Port asan to FreeBSD/mips64..
Aug 1 2018, 4:33 PM

Jul 25 2018

krytarowski accepted D49784: [Asan][Msan] Unit tests Disable some tests for FreeBSD.
Jul 25 2018, 5:31 AM

Jul 11 2018

krytarowski added inline comments to D47208: [profile] Support profiling runtime on Fuchsia.
Jul 11 2018, 3:02 PM

Jul 10 2018

krytarowski added a comment to D49110: [testsuite] Implement a category to skip libstdcxx tests.

Through pkgsrc a user can install LLDB with either style of distribution, including GCC with libstdc++ one (I'm using this myself also for the development of LLVM related code).

Jul 10 2018, 3:03 PM
krytarowski added a comment to D49110: [testsuite] Implement a category to skip libstdcxx tests.

Probably the former with ship GDB at least for long time, the latter will switch to LLDB.

Jul 10 2018, 3:00 PM
krytarowski added a comment to D49110: [testsuite] Implement a category to skip libstdcxx tests.

NetBSD ships with GCC style and Clang style userland. The former one ships with GNU libstdc++, the latter with libc++.

Jul 10 2018, 2:59 PM

Jul 7 2018

krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

A problem is that NetBSD is probably the only mainstream OS left using gnu ld (at least for linking Clang/LLVM) and we catch issues of ld vs gold/lld on NetBSD.

Jul 7 2018, 1:31 AM

Jul 2 2018

krytarowski added a comment to D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.

Maybe we need to move from pthread_get/set_specific ? https://reviews.llvm.org/D47448

Jul 2 2018, 4:31 PM
krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

ping^3

Jul 2 2018, 7:03 AM
krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

ping^4

Jul 2 2018, 7:03 AM

Jul 1 2018

krytarowski added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

Fixed for FreeBSD? There is still a problem for NetBSD, but I'm still swamped with other things.

Fixed for FreeBSD 12.0-CURRENT (which lives in my qemu :( ). Other have told me OpenBSD is good. What's the issue for NetBSD?

Jul 1 2018, 3:06 PM
krytarowski added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

Fixed for FreeBSD? There is still a problem for NetBSD, but I'm still swamped with other things.

Jul 1 2018, 12:14 PM

Jun 30 2018

krytarowski accepted D48805: [UBsan] Enable subset of unit tests for OpenBSD.
Jun 30 2018, 2:23 PM
krytarowski added a comment to D48805: [UBsan] Enable subset of unit tests for OpenBSD.

Please add comments why tests are failed/unsupported.

Jun 30 2018, 1:00 PM

Jun 28 2018

krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

It's similar to MUSL, __DEFINED_max_align_t is musl specific and they don't care about libc++ or not on top of it.

Jun 28 2018, 4:15 AM
krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

I saw this and I think that it shall be handled in libc++. NetBSD doesn't care if c++ runtime library is libstdc++, libc++, none or a different one.

Jun 28 2018, 3:21 AM

Jun 25 2018

krytarowski added inline comments to D48525: Handle NetBSD specific path in findDebugBinary().
Jun 25 2018, 11:48 AM
krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

ping^3

Jun 25 2018, 11:11 AM
krytarowski added inline comments to D48525: Handle NetBSD specific path in findDebugBinary().
Jun 25 2018, 11:10 AM
krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

ping^2

Jun 25 2018, 11:09 AM

Jun 23 2018

krytarowski created D48525: Handle NetBSD specific path in findDebugBinary().
Jun 23 2018, 5:02 PM

Jun 18 2018

krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

ping

Jun 18 2018, 5:03 AM
krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

ping2

Jun 18 2018, 5:03 AM

Jun 16 2018

krytarowski updated subscribers of D48250: [sanitizer_common] Use O_TRUNC for WrOnly access mode..
Jun 16 2018, 2:44 AM

Jun 11 2018

krytarowski added inline comments to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.
Jun 11 2018, 1:16 AM · Restricted Project

Jun 9 2018

krytarowski added a comment to D47977: [Fuzzer] First step to thread affinity.

I understand your points, but usually see the jobs are often bound to cpu0 while this cpu can be potentially pretty busy.
But I put it as an option it s something not to be forced.

Jun 9 2018, 2:44 AM
krytarowski added a comment to D47977: [Fuzzer] First step to thread affinity.

What's the gain? Performance improvement? What are the numbers for benchmarking?

Jun 9 2018, 2:34 AM

Jun 8 2018

krytarowski added a comment to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

It causes breakage because there is called an interceptor inside libc that is reported as false positive.

Jun 8 2018, 9:46 AM · Restricted Project
krytarowski updated subscribers of D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

We are now requiring this on NetBSD for MSanitized userland. Some programs break without puts(3) / fputs(3) interceptors there.

Is there a link/discussion to this issue? (f)puts just read from a buffer, how would lack of interceptors cause MSan to break?
I found https://github.com/google/sanitizers/issues/955, but it does not directly mention such an issue.

(This change is still on my TODO list.)

Jun 8 2018, 9:43 AM · Restricted Project
krytarowski added a comment to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

We are now requiring this on NetBSD for MSanitized userland. Some programs break without puts(3) / fputs(3) interceptors there.

Jun 8 2018, 9:24 AM · Restricted Project
krytarowski added a comment to D35165: [sanitizer] Support compiler-rt builtins.

I've got a local patch that detect building .a file for each arch separately:

Jun 8 2018, 7:59 AM
krytarowski added a comment to D35165: [sanitizer] Support compiler-rt builtins.

@phosek ^

Jun 8 2018, 6:57 AM
krytarowski added a comment to D35165: [sanitizer] Support compiler-rt builtins.

I think that this is broken for multilib (-m32 + -m64 builds, the default one for NetBSD, Linux, FreeBSD and maybe others):

Jun 8 2018, 6:56 AM
krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

ping?

Jun 8 2018, 1:28 AM

Jun 6 2018

krytarowski added a comment to D47650: Disable recursive interceptors in signal(3)/MSan.

ping?

Jun 6 2018, 12:16 PM · Restricted Project
krytarowski accepted D47830: [asan] Fix Myraid RTEMS port broken by r333985.
Jun 6 2018, 8:40 AM
krytarowski created D47814: Teach libc++ to use native NetBSD's max_align_t.
Jun 6 2018, 2:33 AM
krytarowski added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

I'm not sure whether this is equivalent.

Jun 6 2018, 1:57 AM

Jun 5 2018

krytarowski added a comment to D47442: Introduce CheckASLR() in sanitizers.

They claim to sync with FreeBSD daily.. so perhaps they should first try to upstream ASLR to FreeBSD.

Jun 5 2018, 1:05 AM · Restricted Project
krytarowski added a comment to D47442: Introduce CheckASLR() in sanitizers.

I don't know about other BSDs, I've never installed them.

Jun 5 2018, 12:48 AM · Restricted Project

Jun 4 2018

krytarowski added reviewers for D47719: Disable ENABLE_EXPORTS for NetBSD static linking: chandlerc, ruiu.

+ chandlerc (CMake maintainer)
+ ruiu (lld maintainer for insight)

Jun 4 2018, 8:01 AM

Jun 2 2018

krytarowski added a reviewer for D47677: [TSan] FreeBSD / intercept thr_exit: dvyukov.
Jun 2 2018, 1:24 PM

Jun 1 2018

krytarowski created D47650: Disable recursive interceptors in signal(3)/MSan.
Jun 1 2018, 12:33 PM · Restricted Project
krytarowski added a comment to D47625: [cmake] Detect presence of wide-char libedit at build time.

The original reason to switch NetBSD to wide characters was to unbreak the input parser. It used to mix wide and short characters.

Jun 1 2018, 8:41 AM

May 29 2018

krytarowski added a comment to D47442: Introduce CheckASLR() in sanitizers.

In the PaX ASLR NetBSD implementation we add a random offset to all allocations including text (for PIE programs), heap and stack.

May 29 2018, 12:02 PM · Restricted Project

May 28 2018

krytarowski added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

NetBSD is also affected. We shall go for a shared solution at least between BSDs and Linux.

May 28 2018, 4:04 AM
krytarowski created D47442: Introduce CheckASLR() in sanitizers.
May 28 2018, 12:37 AM · Restricted Project

May 26 2018

krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.

This design is most likely the same on all current BSDs. OpenBSD borrowed UVM from NetBSD. FreeBSD has its distinct memory subsystem.

May 26 2018, 12:43 AM
krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.

On NetBSD NORESERVE is enforced by default, so this flag is dummy.

May 26 2018, 12:38 AM

May 25 2018

krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.

I defer it to maintainers!

May 25 2018, 2:43 AM

May 24 2018

krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.

The code looks fine.. but I don't like the description.

May 24 2018, 9:57 PM

May 23 2018

krytarowski added inline comments to D47208: [profile] Support profiling runtime on Fuchsia.
May 23 2018, 12:58 AM

May 21 2018

krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.
$ grep -r MAP_NORESERVE /usr/include/sys          
/usr/include/sys/mman.h:#define	MAP_NORESERVE	 0x0040	/* Sun: don't reserve needed swap area */
$ uname -a
NetBSD rugged 8.99.14 NetBSD 8.99.14 (GENERIC) #1: Thu Apr 26 15:16:44 CEST 2018  root@chieftec:/public/netbsd-root/sys/arch/amd64/compile/GENERIC amd64
May 21 2018, 9:59 AM
krytarowski added inline comments to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.
May 21 2018, 9:56 AM

May 18 2018

krytarowski added inline comments to D46712: Port msan_test.cc to NetBSD.
May 18 2018, 6:15 PM · Restricted Project

May 17 2018

krytarowski added inline comments to D46712: Port msan_test.cc to NetBSD.
May 17 2018, 2:35 PM · Restricted Project

May 13 2018

krytarowski abandoned D43879: Cleanup in sanitizer_common_interceptors.inc.
May 13 2018, 6:39 AM · Restricted Project
krytarowski added a comment to D43879: Cleanup in sanitizer_common_interceptors.inc.

Addressed by @vitalybuka.

May 13 2018, 6:38 AM · Restricted Project

May 11 2018

krytarowski added a comment to D46585: Align ClearShadowForThreadStackAndTLS for NetBSD/i386.

I need to align both in order to make it to work.

May 11 2018, 9:04 AM · Restricted Project
krytarowski added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 11 2018, 8:44 AM

May 10 2018

krytarowski created D46737: Permit -fxray-instrument for NetBSD/amd64.
May 10 2018, 5:45 PM
krytarowski added a comment to D46721: Support XRay in the NetBSD driver.

This is an intermediate commit. I'm unloading local patches.

May 10 2018, 5:39 PM · Restricted Project
krytarowski created D46729: Enable SANITIZER_INTERCEPTOR_HOOKS for NetBSD.
May 10 2018, 3:05 PM · Restricted Project
krytarowski created D46724: Register NetBSD/i386 in AddressSanitizer.cpp.
May 10 2018, 1:26 PM
krytarowski created D46721: Support XRay in the NetBSD driver.
May 10 2018, 1:15 PM · Restricted Project
krytarowski created D46718: Setup ORIGIN/NetBSD option in sanitizer tests.
May 10 2018, 12:54 PM · Restricted Project
krytarowski created D46713: Do not link with -ldl in NetBSD/ASan tests.
May 10 2018, 12:19 PM · Restricted Project
krytarowski created D46712: Port msan_test.cc to NetBSD.
May 10 2018, 12:11 PM · Restricted Project
krytarowski created D46708: Register NetBSD/i386 in asan_mapping.h.
May 10 2018, 11:13 AM · Restricted Project