krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (103 w, 1 d)

Recent Activity

Today

krytarowski added a comment to D36331: Add ARC backend.

Any comments or suggestions about Krzysztof's copyright notice question here? Are they OK in, or should the notices be taken out?

Tue, Aug 22, 8:43 AM
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

ping x2

Tue, Aug 22, 6:15 AM · Restricted Project
krytarowski added a comment to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

Ping x2

Tue, Aug 22, 6:15 AM · Restricted Project

Yesterday

krytarowski added a reviewer for D35554: Add NetBSD support in sanitizer_platform_limits_posix.*: fjricci.
Mon, Aug 21, 12:34 PM · Restricted Project
krytarowski closed D36935: Enable libfuzzer on NetBSD/amd64.
Mon, Aug 21, 12:13 PM · Restricted Project
krytarowski added a comment to D33878: Handle NetBSD specific _Unwind_Ptr.

Well, the libexecinfo one exists as fallback because gcc doesn't provide one.

Mon, Aug 21, 10:21 AM
krytarowski added a comment to D33878: Handle NetBSD specific _Unwind_Ptr.

Kamil, which unwind.h are you using? The outdated copy in libexecinfo.h or the modern one used by libunwind? I see little reason to cater to the bugs in the former...

Mon, Aug 21, 9:38 AM
krytarowski added a comment to D33878: Handle NetBSD specific _Unwind_Ptr.

https://github.com/NetBSD/src/blob/trunk/lib/libexecinfo/unwind.h here is the refrenced header used by GCC.

Mon, Aug 21, 9:37 AM

Sun, Aug 20

krytarowski added a reviewer for D36935: Enable libfuzzer on NetBSD/amd64: george.karpenkov.
Sun, Aug 20, 9:00 AM · Restricted Project
krytarowski created D36935: Enable libfuzzer on NetBSD/amd64.
Sun, Aug 20, 8:56 AM · Restricted Project

Sat, Aug 19

krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.
In D36908#846734, @kcc wrote:

Rule of thumb: never mix refactoring with functional changes (or porting to new platforms, etc) in a single change.

Sat, Aug 19, 7:25 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.
In D36908#846732, @kcc wrote:

Any such change during a large refactoring is a burden, sorry.

Sat, Aug 19, 7:11 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.
In D36908#846722, @kcc wrote:

Please amend this patch with support for NetBSD:

http://www.netbsd.org/~kamil/llvm/libfuzzer-netbsd.txt

Not everything is ready, like missing lsan... but it's good enough for start and improve in future.

Let's not overcomplicate the move to compiler-rt, it's pretty involved any way.
We would welcome support for any new platform in a separate patch once the dust settles (a week or two).
For any new supported platform will require a public build bot and a contact person.
Lacking that we can't promise to keep the port alive. (For further discussion, please start a new thread).

Sat, Aug 19, 7:00 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.

Please amend this patch with support for NetBSD:

Sat, Aug 19, 3:26 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.

I will move it here (from the mailing list):

Sat, Aug 19, 2:43 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.

A side notice but wouldn't it be better to make libFuzzer a completely separate component (like openmp)? I've seen people take interest in it outside LLVM toolchain.

Sat, Aug 19, 1:14 PM

Fri, Aug 18

krytarowski added inline comments to D36908: Moving libFuzzer to compiler-rt.
Fri, Aug 18, 7:21 PM
krytarowski added inline comments to D36908: Moving libFuzzer to compiler-rt.
Fri, Aug 18, 6:19 PM
krytarowski added a comment to D36810: Minimal runtime for UBSan..

ubsan and suitable on production? I don't understand this phrasing, sounds to me like oxymoron.

Fri, Aug 18, 11:00 AM

Thu, Aug 17

krytarowski added reviewers for D36587: Add NetBSD ASAN shadow mapping for x86-64: eugenis, pcc.

Adding more reviewers to get feedback.

Thu, Aug 17, 8:36 AM · Restricted Project

Wed, Aug 16

krytarowski added a comment to D35667: [DragonEgg] Initial migration to GCC v8.x and LLVM v6.x.

What's your particular need for this project? If just for fan, this might not be worth to maintain.

There is ongoing effort to upstream Fortran support to LLVM.

For reference: https://github.com/flang-compiler/flang

Hi Leslie,
If you focused your efforts on trying to get flang integrated with top of trunk LLVM this would be incredibly helpful to the community. :D

Wed, Aug 16, 2:52 AM

Tue, Aug 15

krytarowski added a comment to D36265: Support lib changes to allow VFS implementation handling working dir locally..

It's not just Windows, but not even all unixes support openat. Minimum required version of various Unixes are:

DragonFly 2.3.
FreeBSD 8.0.
Linux 2.6.16
NetBSD 7.0.
OpenBSD 5.0.
OS X 10.10.

I don't know how old some of these are, but you should check first to make sure we don't support any versions of these unix variants with versions older than specified above. As for Windows, If we're going to use Nt functions, I would rather they be entirely separate functions. i.e. not done via an optional parameter to an existing function, but a completely new function.

Tue, Aug 15, 2:15 PM
krytarowski added a comment to D36603: Enable profile on NetBSD.

I've compressed the whole directory (for which I had more issues) and uploaded:

Tue, Aug 15, 9:01 AM · Restricted Project
krytarowski added a comment to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

ping

Tue, Aug 15, 3:09 AM · Restricted Project
krytarowski added a comment to D36603: Enable profile on NetBSD.

I've reverted the commit on demand.

Tue, Aug 15, 3:09 AM · Restricted Project

Sun, Aug 13

krytarowski closed D36603: Enable profile on NetBSD.
Sun, Aug 13, 1:19 PM · Restricted Project
krytarowski added a comment to D36603: Enable profile on NetBSD.
In D36603#839356, @vsk wrote:

I think it would be better to XFAIL the test from the onset so that people reading the source are aware of the issue. That way, if for any reason this can't make its way back on your priority list, the build will remain in good shape.

Sun, Aug 13, 12:38 PM · Restricted Project

Fri, Aug 11

krytarowski added a comment to D36603: Enable profile on NetBSD.
In D36603#839335, @vsk wrote:

What's causing the test failure? Do you plan on XFAIL'ing the test on NetBSD initially?

Fri, Aug 11, 10:35 AM · Restricted Project

Thu, Aug 10

krytarowski created D36603: Enable profile on NetBSD.
Thu, Aug 10, 7:13 PM · Restricted Project
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

I don't really get why the shadow offset differs between systems, I copied it from FreeBSD.
Please help to optimize it.

Thu, Aug 10, 12:43 PM · Restricted Project
krytarowski created D36587: Add NetBSD ASAN shadow mapping for x86-64.
Thu, Aug 10, 12:33 PM · Restricted Project
krytarowski added a comment to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

ASAN, UBSAN and SAFESTACK are already committed.

Thu, Aug 10, 12:13 PM · Restricted Project
krytarowski closed D36490: Enable ASAN on NetBSD.
Thu, Aug 10, 12:09 PM · Restricted Project
krytarowski closed D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64.
Thu, Aug 10, 11:54 AM · Restricted Project
krytarowski closed D36488: Add NetBSD support in asan_linux.cc.
Thu, Aug 10, 11:52 AM · Restricted Project
krytarowski added inline comments to D36490: Enable ASAN on NetBSD.
Thu, Aug 10, 11:50 AM · Restricted Project
krytarowski added inline comments to D36488: Add NetBSD support in asan_linux.cc.
Thu, Aug 10, 11:47 AM · Restricted Project
krytarowski added inline comments to D36490: Enable ASAN on NetBSD.
Thu, Aug 10, 11:44 AM · Restricted Project
krytarowski closed D36542: Enable SafeStack on NetBSD.
Thu, Aug 10, 11:41 AM · Restricted Project
krytarowski added inline comments to D36490: Enable ASAN on NetBSD.
Thu, Aug 10, 11:40 AM · Restricted Project

Wed, Aug 9

krytarowski added inline comments to D36484: Add NetBSD support in asan_symbolize.py.
Wed, Aug 9, 6:26 PM · Restricted Project
krytarowski created D36542: Enable SafeStack on NetBSD.
Wed, Aug 9, 12:28 PM · Restricted Project
krytarowski added inline comments to D36385: [asan] Refactor thread creation bookkeeping.
Wed, Aug 9, 11:37 AM · Restricted Project
krytarowski updated the diff for D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64.

Fix lsan entry.
Add tests.

Wed, Aug 9, 11:19 AM · Restricted Project
krytarowski retitled D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64 from Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64 to Enable bunch of sanitizers on NetBSD/X86 and X86_64.
Wed, Aug 9, 10:24 AM · Restricted Project
krytarowski added a comment to D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64.
-- Testing: 8 tests, 8 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 0.56s
  Expected Passes    : 7
  Unsupported Tests  : 1
Wed, Aug 9, 10:09 AM · Restricted Project
krytarowski updated the diff for D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64.

Enable more sanitizers.

Wed, Aug 9, 10:02 AM · Restricted Project
krytarowski added a comment to D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64.
-- Testing: 172 tests, 8 threads --
Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
Testing Time: 20.19s
  Expected Passes    : 156
  Unsupported Tests  : 16
Wed, Aug 9, 9:14 AM · Restricted Project
krytarowski added inline comments to D36385: [asan] Refactor thread creation bookkeeping.
Wed, Aug 9, 3:57 AM · Restricted Project

Tue, Aug 8

krytarowski added a comment to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

This is the last patch needed for common-sanitizer on NetBSD.

Tue, Aug 8, 7:01 PM · Restricted Project
krytarowski updated the diff for D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

Apply changes from review.

Tue, Aug 8, 6:53 PM · Restricted Project
krytarowski added a comment to D36490: Enable ASAN on NetBSD.
Failing Tests (2):
    AddressSanitizer-Unit :: ./Asan-x86_64-inline-Test/AddressSanitizerInterface.ManyThreadsWithStatsStressTest
    AddressSanitizer-Unit :: ./Asan-x86_64-with-calls-Test/AddressSanitizerInterface.ManyThreadsWithStatsStressTest
Tue, Aug 8, 5:59 PM · Restricted Project
krytarowski added a comment to D36376: Add NetBSD support in asan_malloc_linux.cc.

This bot is unhappy about your change: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/3307. Please fix.

Tue, Aug 8, 4:40 PM · Restricted Project
krytarowski created D36490: Enable ASAN on NetBSD.
Tue, Aug 8, 2:43 PM · Restricted Project
krytarowski created D36488: Add NetBSD support in asan_linux.cc.
Tue, Aug 8, 2:34 PM · Restricted Project
krytarowski added inline comments to D33878: Handle NetBSD specific _Unwind_Ptr.
Tue, Aug 8, 2:05 PM
krytarowski added reviewers for D33878: Handle NetBSD specific _Unwind_Ptr: vitalybuka, fjricci.
Tue, Aug 8, 2:03 PM
krytarowski closed D36376: Add NetBSD support in asan_malloc_linux.cc.
Tue, Aug 8, 1:53 PM · Restricted Project
krytarowski closed D36484: Add NetBSD support in asan_symbolize.py.
Tue, Aug 8, 1:50 PM · Restricted Project
krytarowski closed D36483: Enable ubsan on NetBSD.
Tue, Aug 8, 1:50 PM · Restricted Project
krytarowski added a comment to D36483: Enable ubsan on NetBSD.

Are there buildbots for NetBSD?

Tue, Aug 8, 1:46 PM · Restricted Project
krytarowski closed D36325: Reuse sanitizer_linux for NetBSD.
Tue, Aug 8, 1:39 PM · Restricted Project
krytarowski created D36484: Add NetBSD support in asan_symbolize.py.
Tue, Aug 8, 1:19 PM · Restricted Project
krytarowski created D36483: Enable ubsan on NetBSD.
Tue, Aug 8, 12:48 PM · Restricted Project
krytarowski created D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64.
Tue, Aug 8, 12:39 PM · Restricted Project
krytarowski closed D36470: Add NetBSD support in asan_interceptors.cc.
Tue, Aug 8, 12:10 PM · Restricted Project
krytarowski closed D36469: NetBSD compatibility nit in asan_test_utils.h.
Tue, Aug 8, 11:17 AM · Restricted Project
krytarowski closed D36312: Enable COMPILER_RT_HAS_SANITIZER_COMMON on NetBSD.
Tue, Aug 8, 8:26 AM · Restricted Project
krytarowski added a comment to D36312: Enable COMPILER_RT_HAS_SANITIZER_COMMON on NetBSD.

2 patches to be reviewed left.. I'm going to commit it now, soon I will prompt for enabling asan.

Tue, Aug 8, 8:26 AM · Restricted Project
krytarowski created D36470: Add NetBSD support in asan_interceptors.cc.
Tue, Aug 8, 8:05 AM · Restricted Project
krytarowski created D36469: NetBSD compatibility nit in asan_test_utils.h.
Tue, Aug 8, 7:50 AM · Restricted Project
krytarowski closed D36321: Reuse interception_linux for NetBSD.
Tue, Aug 8, 5:10 AM · Restricted Project
krytarowski added a comment to D36321: Reuse interception_linux for NetBSD.

Could you please add test?

Tue, Aug 8, 4:55 AM · Restricted Project
krytarowski closed D35553: Define OFF_T as 64-bit integer on NetBSD.
Tue, Aug 8, 4:41 AM · Restricted Project
krytarowski added a comment to D35667: [DragonEgg] Initial migration to GCC v8.x and LLVM v6.x.

What's your particular need for this project? If just for fan, this might not be worth to maintain.

Tue, Aug 8, 4:26 AM
krytarowski added a comment to D35553: Define OFF_T as 64-bit integer on NetBSD.

Please fix the comment

Tue, Aug 8, 4:21 AM · Restricted Project
krytarowski added a comment to D35667: [DragonEgg] Initial migration to GCC v8.x and LLVM v6.x.

What's your particular need for this project? If just for fan, this might not be worth to maintain.

Tue, Aug 8, 4:17 AM

Mon, Aug 7

krytarowski closed D36406: Fix asan_test.cc build on NetBSD.
Mon, Aug 7, 4:38 PM · Restricted Project
krytarowski closed D36377: Add NetBSD support in asan_stack.h.
Mon, Aug 7, 4:35 PM · Restricted Project
krytarowski added inline comments to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.
Mon, Aug 7, 10:06 AM · Restricted Project
krytarowski created D36406: Fix asan_test.cc build on NetBSD.
Mon, Aug 7, 9:20 AM · Restricted Project
krytarowski added a comment to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

ping?

Mon, Aug 7, 4:29 AM · Restricted Project
krytarowski closed D36373: Add NetBSD support in sanitizer_test_utils.h.
Mon, Aug 7, 4:03 AM · Restricted Project
krytarowski added a comment to D35553: Define OFF_T as 64-bit integer on NetBSD.

ping?

Mon, Aug 7, 4:03 AM · Restricted Project
krytarowski closed D36374: Add NetBSD support in asan_errors.cc.
Mon, Aug 7, 3:59 AM · Restricted Project
krytarowski closed D36375: Add NetBSD support in asan_interceptors.h.
Mon, Aug 7, 3:58 AM · Restricted Project
krytarowski closed D36378: Enable LLVM asan support for NetBSD/i386.
Mon, Aug 7, 3:57 AM · Restricted Project

Sun, Aug 6

krytarowski added a comment to D36377: Add NetBSD support in asan_stack.h.

Kamil, a fair amount of these changes seem to just replace SANITIZER_FREEBSD with SANITIZER_FREEBSD || SANITIZER_NETBSD.
I wonder whether it makes sense to define a SANITIZER_BSD macro for both of them?

Also, what's the difference in support you expect between NetBSD and FreeBSD to support sanitizers?

Sun, Aug 6, 6:07 PM · Restricted Project
krytarowski created D36378: Enable LLVM asan support for NetBSD/i386.
Sun, Aug 6, 8:00 AM · Restricted Project
krytarowski created D36377: Add NetBSD support in asan_stack.h.
Sun, Aug 6, 6:53 AM · Restricted Project
krytarowski created D36376: Add NetBSD support in asan_malloc_linux.cc.
Sun, Aug 6, 6:49 AM · Restricted Project
krytarowski created D36375: Add NetBSD support in asan_interceptors.h.
Sun, Aug 6, 6:46 AM · Restricted Project
krytarowski created D36374: Add NetBSD support in asan_errors.cc.
Sun, Aug 6, 6:19 AM · Restricted Project
krytarowski created D36373: Add NetBSD support in sanitizer_test_utils.h.
Sun, Aug 6, 6:13 AM · Restricted Project

Sat, Aug 5

krytarowski closed D36360: Add NetBSD support in sanitizer_errno.h.
Sat, Aug 5, 11:11 AM · Restricted Project
krytarowski created D36360: Add NetBSD support in sanitizer_errno.h.
Sat, Aug 5, 9:28 AM · Restricted Project
krytarowski closed D36314: Add NetBSD support in sanitizer_unwind_linux_libcdep.cc.
Sat, Aug 5, 6:37 AM · Restricted Project
krytarowski added inline comments to D36314: Add NetBSD support in sanitizer_unwind_linux_libcdep.cc.
Sat, Aug 5, 4:45 AM · Restricted Project

Fri, Aug 4

krytarowski added inline comments to D36321: Reuse interception_linux for NetBSD.
Fri, Aug 4, 4:48 PM · Restricted Project
krytarowski added a comment to D36312: Enable COMPILER_RT_HAS_SANITIZER_COMMON on NetBSD.

I will hold on with committing this until merging all the remaining patches for COMPILER_RT_HAS_SANITIZER_COMMON.

Fri, Aug 4, 4:16 PM · Restricted Project