- User Since
- Aug 30 2015, 11:51 AM (168 w, 20 h)
Sat, Nov 17
Is this Linux-only?
Fri, Nov 16
Committed non-controversial chunks of this. The rest is rescheduled for future in separate review.
As I understand it -ltinfo vs -lterminfo is mixing native curses(3) and external ncurses(3) from pkgsrc, while we prefer to use entirely our native version for all LLVM projects.
Do not return -ltinfo from llvm-config --system-libs --link-static
under NetBSD. Bump PKGREVISION
Rust language 1.20.0 uses these options and Rust build system uses it
as '-l tinfo' and our wrapper does not handle this.
I have got a local patch in pkgsrc-wip/llvm-netbsd:
Thu, Nov 15
- add more tests
- add missing rename
@hfinkel any comments on this? If not I recommend to land this patch as it is.
Wed, Nov 14
Tue, Nov 13
There is also start_deactivated in ASan.
Sat, Nov 10
It's not complete, there is remaining L24.
Please replace defined(BSD).
Fri, Nov 9
Thanks @mgorny for debugging on Linux.
- fix Linux
There is also sparc and sparc64 support in sanitizers on NetBSD... but I cannot say for now how well it works. For sure we run UBSan and ASan for both of them.
Yes, please iterate over explicit BSDs. We don't support BSD4.4 or BSD/OS or such.
Wed, Nov 7
- add more checks
- apply fixes from review
On NetBSD one has to check PaX MPROTECT property of a traced process.
Tue, Nov 6
In this test parent_tid = 1, child_tid = 1 always and distinguishing this way child and parent is broken. Switching syscall_gettid() to behave like getpid() is not sufficient as the test has assumptions that thread is like pid.
Mon, Nov 5
Why? We already put a lot of effort into reusing code from LLVM.
Interesting, are these tools open-source? I would be interested to port them to NetBSD.
Is this out of process only to enumarate? Is there an option to support this through debugging interfaces and analysis of a program?
This test seems to have a Linux assumption and I have concerns how to port it to NetBSD.
The proper way to handle is to go for wrapping it with strtod(3), however it requires refactoring of existing sanitizers (msan, dfsan...).
Sun, Nov 4
This change happened to be required in downstream usage.. knowing its limits can we merge it as it is?
I will abandon it for now, if it will make problems again I will show up with a new patch.
Sat, Nov 3
@hfinkel I would still like to drop W|X support from MemoryBlock for everybody, restricting this class to swapping between RW and RX in JIT code. For those who need RWX allocations it's more convenient to add a dedicated allocator (and NetBSD can support it). It's just a matter of time when new features on security hardened OSes will break and lose feature parity.
+ hfinkel for JIT API reference.
This looks fine to me.
Fri, Nov 2
Remove unwanted SI_MAC.
Adding @ro for check whether it's fine for Solaris and SPARC.
Tue, Oct 30
Mon, Oct 29
Oct 8 2018
The NetBSD part looks fine. I will be out of the office soon as I will visit California for GSoC Mentor Summit and MeetBSDCa (until October 23rd).
Oct 5 2018
Oct 4 2018
Oct 2 2018
Oct 1 2018
Sep 30 2018
Sep 29 2018
- reduce code duplication with addition of helper macros
Sep 28 2018
- add CHECK()
- add forgotten TgKill()