krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (150 w, 6 d)

Recent Activity

Wed, Jul 11

krytarowski added inline comments to D47208: [profile] Support profiling runtime on Fuchsia.
Wed, Jul 11, 3:02 PM

Tue, Jul 10

krytarowski added a comment to D49110: [testsuite] Implement a category to skip libstdcxx tests.

Through pkgsrc a user can install LLDB with either style of distribution, including GCC with libstdc++ one (I'm using this myself also for the development of LLVM related code).

Tue, Jul 10, 3:03 PM
krytarowski added a comment to D49110: [testsuite] Implement a category to skip libstdcxx tests.

Probably the former with ship GDB at least for long time, the latter will switch to LLDB.

Tue, Jul 10, 3:00 PM
krytarowski added a comment to D49110: [testsuite] Implement a category to skip libstdcxx tests.

NetBSD ships with GCC style and Clang style userland. The former one ships with GNU libstdc++, the latter with libc++.

Tue, Jul 10, 2:59 PM

Sat, Jul 7

krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

A problem is that NetBSD is probably the only mainstream OS left using gnu ld (at least for linking Clang/LLVM) and we catch issues of ld vs gold/lld on NetBSD.

Sat, Jul 7, 1:31 AM

Mon, Jul 2

krytarowski added a comment to D48806: [asan] Fix deadlock issue on FreeBSD, caused by use of .preinit_array in rL325240.

Maybe we need to move from pthread_get/set_specific ? https://reviews.llvm.org/D47448

Mon, Jul 2, 4:31 PM
krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

ping^3

Mon, Jul 2, 7:03 AM
krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

ping^4

Mon, Jul 2, 7:03 AM

Sun, Jul 1

krytarowski added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

Fixed for FreeBSD? There is still a problem for NetBSD, but I'm still swamped with other things.

Fixed for FreeBSD 12.0-CURRENT (which lives in my qemu :( ). Other have told me OpenBSD is good. What's the issue for NetBSD?

Sun, Jul 1, 3:06 PM
krytarowski added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

Fixed for FreeBSD? There is still a problem for NetBSD, but I'm still swamped with other things.

Sun, Jul 1, 12:14 PM

Sat, Jun 30

krytarowski accepted D48805: [UBsan] Enable subset of unit tests for OpenBSD.
Sat, Jun 30, 2:23 PM
krytarowski added a comment to D48805: [UBsan] Enable subset of unit tests for OpenBSD.

Please add comments why tests are failed/unsupported.

Sat, Jun 30, 1:00 PM

Thu, Jun 28

krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

It's similar to MUSL, __DEFINED_max_align_t is musl specific and they don't care about libc++ or not on top of it.

Thu, Jun 28, 4:15 AM
krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

I saw this and I think that it shall be handled in libc++. NetBSD doesn't care if c++ runtime library is libstdc++, libc++, none or a different one.

Thu, Jun 28, 3:21 AM

Mon, Jun 25

krytarowski added inline comments to D48525: Handle NetBSD specific path in findDebugBinary().
Mon, Jun 25, 11:48 AM
krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

ping^3

Mon, Jun 25, 11:11 AM
krytarowski added inline comments to D48525: Handle NetBSD specific path in findDebugBinary().
Mon, Jun 25, 11:10 AM
krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

ping^2

Mon, Jun 25, 11:09 AM

Sat, Jun 23

krytarowski created D48525: Handle NetBSD specific path in findDebugBinary().
Sat, Jun 23, 5:02 PM

Jun 18 2018

krytarowski added a comment to D47814: Teach libc++ to use native NetBSD's max_align_t.

ping

Jun 18 2018, 5:03 AM
krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

ping2

Jun 18 2018, 5:03 AM

Jun 16 2018

krytarowski updated subscribers of D48250: [sanitizer_common] Use O_TRUNC for WrOnly access mode..
Jun 16 2018, 2:44 AM

Jun 11 2018

krytarowski added inline comments to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.
Jun 11 2018, 1:16 AM · Restricted Project

Jun 9 2018

krytarowski added a comment to D47977: [Fuzzer] First step to thread affinity.

I understand your points, but usually see the jobs are often bound to cpu0 while this cpu can be potentially pretty busy.
But I put it as an option it s something not to be forced.

Jun 9 2018, 2:44 AM
krytarowski added a comment to D47977: [Fuzzer] First step to thread affinity.

What's the gain? Performance improvement? What are the numbers for benchmarking?

Jun 9 2018, 2:34 AM

Jun 8 2018

krytarowski added a comment to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

It causes breakage because there is called an interceptor inside libc that is reported as false positive.

Jun 8 2018, 9:46 AM · Restricted Project
krytarowski updated subscribers of D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

We are now requiring this on NetBSD for MSanitized userland. Some programs break without puts(3) / fputs(3) interceptors there.

Is there a link/discussion to this issue? (f)puts just read from a buffer, how would lack of interceptors cause MSan to break?
I found https://github.com/google/sanitizers/issues/955, but it does not directly mention such an issue.

(This change is still on my TODO list.)

Jun 8 2018, 9:43 AM · Restricted Project
krytarowski added a comment to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

We are now requiring this on NetBSD for MSanitized userland. Some programs break without puts(3) / fputs(3) interceptors there.

Jun 8 2018, 9:24 AM · Restricted Project
krytarowski added a comment to D35165: [sanitizer] Support compiler-rt builtins.

I've got a local patch that detect building .a file for each arch separately:

Jun 8 2018, 7:59 AM
krytarowski added a comment to D35165: [sanitizer] Support compiler-rt builtins.

@phosek ^

Jun 8 2018, 6:57 AM
krytarowski added a comment to D35165: [sanitizer] Support compiler-rt builtins.

I think that this is broken for multilib (-m32 + -m64 builds, the default one for NetBSD, Linux, FreeBSD and maybe others):

Jun 8 2018, 6:56 AM
krytarowski added a comment to D47719: Disable ENABLE_EXPORTS for NetBSD static linking.

ping?

Jun 8 2018, 1:28 AM

Jun 6 2018

krytarowski added a comment to D47650: Disable recursive interceptors in signal(3)/MSan.

ping?

Jun 6 2018, 12:16 PM · Restricted Project
krytarowski accepted D47830: [asan] Fix Myraid RTEMS port broken by r333985.
Jun 6 2018, 8:40 AM
krytarowski created D47814: Teach libc++ to use native NetBSD's max_align_t.
Jun 6 2018, 2:33 AM
krytarowski added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

I'm not sure whether this is equivalent.

Jun 6 2018, 1:57 AM

Jun 5 2018

krytarowski added a comment to D47442: Introduce CheckASLR() in sanitizers.

They claim to sync with FreeBSD daily.. so perhaps they should first try to upstream ASLR to FreeBSD.

Jun 5 2018, 1:05 AM · Restricted Project
krytarowski added a comment to D47442: Introduce CheckASLR() in sanitizers.

I don't know about other BSDs, I've never installed them.

Jun 5 2018, 12:48 AM · Restricted Project

Jun 4 2018

krytarowski added reviewers for D47719: Disable ENABLE_EXPORTS for NetBSD static linking: chandlerc, ruiu.

+ chandlerc (CMake maintainer)
+ ruiu (lld maintainer for insight)

Jun 4 2018, 8:01 AM

Jun 2 2018

krytarowski added a reviewer for D47677: [TSan] FreeBSD / intercept thr_exit: dvyukov.
Jun 2 2018, 1:24 PM

Jun 1 2018

krytarowski created D47650: Disable recursive interceptors in signal(3)/MSan.
Jun 1 2018, 12:33 PM · Restricted Project
krytarowski added a comment to D47625: [cmake] Detect presence of wide-char libedit at build time.

The original reason to switch NetBSD to wide characters was to unbreak the input parser. It used to mix wide and short characters.

Jun 1 2018, 8:41 AM

May 29 2018

krytarowski added a comment to D47442: Introduce CheckASLR() in sanitizers.

In the PaX ASLR NetBSD implementation we add a random offset to all allocations including text (for PIE programs), heap and stack.

May 29 2018, 12:02 PM · Restricted Project

May 28 2018

krytarowski added a comment to D47448: [Asan] Attempt to fix for FreeBSD.

NetBSD is also affected. We shall go for a shared solution at least between BSDs and Linux.

May 28 2018, 4:04 AM
krytarowski created D47442: Introduce CheckASLR() in sanitizers.
May 28 2018, 12:37 AM · Restricted Project

May 26 2018

krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.

This design is most likely the same on all current BSDs. OpenBSD borrowed UVM from NetBSD. FreeBSD has its distinct memory subsystem.

May 26 2018, 12:43 AM
krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.

On NetBSD NORESERVE is enforced by default, so this flag is dummy.

May 26 2018, 12:38 AM

May 25 2018

krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.

I defer it to maintainers!

May 25 2018, 2:43 AM

May 24 2018

krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.

The code looks fine.. but I don't like the description.

May 24 2018, 9:57 PM

May 23 2018

krytarowski added inline comments to D47208: [profile] Support profiling runtime on Fuchsia.
May 23 2018, 12:58 AM

May 21 2018

krytarowski added a comment to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.
$ grep -r MAP_NORESERVE /usr/include/sys          
/usr/include/sys/mman.h:#define	MAP_NORESERVE	 0x0040	/* Sun: don't reserve needed swap area */
$ uname -a
NetBSD rugged 8.99.14 NetBSD 8.99.14 (GENERIC) #1: Thu Apr 26 15:16:44 CEST 2018  root@chieftec:/public/netbsd-root/sys/arch/amd64/compile/GENERIC amd64
May 21 2018, 9:59 AM
krytarowski added inline comments to D47146: Memorysanitizer fix mmap test for oses not supporting MAP_NORESERVE flag.
May 21 2018, 9:56 AM

May 18 2018

krytarowski added inline comments to D46712: Port msan_test.cc to NetBSD.
May 18 2018, 6:15 PM · Restricted Project

May 17 2018

krytarowski added inline comments to D46712: Port msan_test.cc to NetBSD.
May 17 2018, 2:35 PM · Restricted Project

May 13 2018

krytarowski abandoned D43879: Cleanup in sanitizer_common_interceptors.inc.
May 13 2018, 6:39 AM · Restricted Project
krytarowski added a comment to D43879: Cleanup in sanitizer_common_interceptors.inc.

Addressed by @vitalybuka.

May 13 2018, 6:38 AM · Restricted Project

May 11 2018

krytarowski added a comment to D46585: Align ClearShadowForThreadStackAndTLS for NetBSD/i386.

I need to align both in order to make it to work.

May 11 2018, 9:04 AM · Restricted Project
krytarowski added inline comments to D46456: [asan] Add support for Myriad RTEMS memory map.
May 11 2018, 8:44 AM

May 10 2018

krytarowski created D46737: Permit -fxray-instrument for NetBSD/amd64.
May 10 2018, 5:45 PM
krytarowski added a comment to D46721: Support XRay in the NetBSD driver.

This is an intermediate commit. I'm unloading local patches.

May 10 2018, 5:39 PM · Restricted Project
krytarowski created D46729: Enable SANITIZER_INTERCEPTOR_HOOKS for NetBSD.
May 10 2018, 3:05 PM · Restricted Project
krytarowski created D46724: Register NetBSD/i386 in AddressSanitizer.cpp.
May 10 2018, 1:26 PM
krytarowski created D46721: Support XRay in the NetBSD driver.
May 10 2018, 1:15 PM · Restricted Project
krytarowski created D46718: Setup ORIGIN/NetBSD option in sanitizer tests.
May 10 2018, 12:54 PM · Restricted Project
krytarowski created D46713: Do not link with -ldl in NetBSD/ASan tests.
May 10 2018, 12:19 PM · Restricted Project
krytarowski created D46712: Port msan_test.cc to NetBSD.
May 10 2018, 12:11 PM · Restricted Project
krytarowski created D46708: Register NetBSD/i386 in asan_mapping.h.
May 10 2018, 11:13 AM · Restricted Project

May 8 2018

krytarowski added a comment to D46517: [sanitizer] Don't miss threads by ThreadSuspender.

But we can skip it, I will address it in future.

May 8 2018, 7:50 PM
krytarowski added a comment to D46517: [sanitizer] Don't miss threads by ThreadSuspender.

While there, listing threads on NetBSD has to be done differently. If I'm looking correctly this code will be used for this OS too... and fail.

May 8 2018, 7:36 PM
krytarowski added a comment to D46622: wrong usages of sem_open in the libFuzzer.

It looks good to me, but I will wait for the final word from @vitalybuka

May 8 2018, 7:33 PM
krytarowski updated the diff for D46585: Align ClearShadowForThreadStackAndTLS for NetBSD/i386.

Typo.

May 8 2018, 9:49 AM · Restricted Project
krytarowski created D46585: Align ClearShadowForThreadStackAndTLS for NetBSD/i386.
May 8 2018, 9:31 AM · Restricted Project
krytarowski added a comment to D45652: Asan, fix FreeBSD support.

BTW. Does FreeBSD/i386 work? The NetBSD 32-bit code broke due to shadow granularity assert in:

void PoisonShadow(uptr addr, uptr size, u8 value) {

if (!CanPoisonMemory()) return;
CHECK(AddrIsAlignedByGranularity(addr)); // <- here, addr=0xxxxxxxx4
CHECK(AddrIsInMem(addr));
CHECK(AddrIsAlignedByGranularity(addr + size));
CHECK(AddrIsInMem(addr + size - SHADOW_GRANULARITY));
CHECK(REAL(memset));
FastPoisonShadow(addr, size, value);

}

May 8 2018, 8:47 AM

May 7 2018

krytarowski added a comment to D46545: [sanitizer] Add fgets, fputs and puts into sanitizer_common.

It looks fine. It would be nicer to use separate tests for each function. Not all in one.

May 7 2018, 6:09 PM · Restricted Project

May 6 2018

krytarowski added a comment to D45652: Asan, fix FreeBSD support.

BTW. Does FreeBSD/i386 work? The NetBSD 32-bit code broke due to shadow granularity assert in:

May 6 2018, 10:28 AM

May 4 2018

krytarowski added inline comments to D46454: [sanitizer] Trivial portion of the port to Myriad RTEMS.
May 4 2018, 1:53 PM
krytarowski added inline comments to D45652: Asan, fix FreeBSD support.
May 4 2018, 12:21 PM

May 2 2018

krytarowski added a comment to D45652: Asan, fix FreeBSD support.

@vitalybuka do you agree with this patch?

May 2 2018, 8:37 PM
krytarowski accepted D45652: Asan, fix FreeBSD support.

This is now needed on NetBSD too. Do we know what change caused this regression?

May 2 2018, 7:59 PM
krytarowski added a comment to D45149: MallocChecker, adding specific BSD calls.

These calls are not 'BSD' specific.. but OpenBSD.

May 2 2018, 7:48 PM

Apr 25 2018

krytarowski added a comment to D45652: Asan, fix FreeBSD support.

Please fix the hang in AsanTSDInit

Apr 25 2018, 10:26 AM
krytarowski added a comment to D46006: [Sanitizers] Fix Solaris build.

Not bad. It looks like FreeBSD ASan broke too... https://bugs.llvm.org/show_bug.cgi?id=37238

Apr 25 2018, 8:01 AM · Restricted Project
krytarowski added a comment to D46006: [Sanitizers] Fix Solaris build.
In D46006#1077941, @ro wrote:

Can you run tests on SunOS? check-asan, check-ubsan etc.

Of course: that's the first thing I did after fixing the build (run make check-all, that is, which includes the above). Same as before the
breakage.

Apr 25 2018, 7:45 AM · Restricted Project

Apr 24 2018

krytarowski added a comment to D46006: [Sanitizers] Fix Solaris build.

Can you run tests on SunOS? check-asan, check-ubsan etc.

Apr 24 2018, 8:34 AM · Restricted Project

Apr 23 2018

krytarowski updated subscribers of D41240: [Solaris] __float128 is supported on Solaris/x86.

Does it work for you for 32-bit? @joerg opposed adoption of 32-bit version as it seemed to be unimplemented..

Apr 23 2018, 5:57 AM

Apr 6 2018

krytarowski added a comment to D45359: [cmake] Improve pthread_[gs]etname_np detection code.

This patch looks fine, not sure if we can improve it.

Apr 6 2018, 8:34 AM
krytarowski added a comment to D45359: [cmake] Improve pthread_[gs]etname_np detection code.

FreeBSD also uses pthread_np.h header.

Apr 6 2018, 5:41 AM
krytarowski added a comment to D45359: [cmake] Improve pthread_[gs]etname_np detection code.

Just a note that FreeBSD calls its function pthread_set_name_np.

Apr 6 2018, 5:39 AM

Mar 17 2018

krytarowski added a comment to D44604: Make stdarg.h compatible with FreeBSD.

This does not fix the potential problem on NetBSD. We define __VA_LIST_DECLARED (with extra _ on the beginning).

Mar 17 2018, 7:40 PM

Mar 12 2018

krytarowski accepted D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).

I cannot test it shortly on NetBSD, but if there are any issues left (probably none) - I will fix it in future.

Mar 12 2018, 10:29 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 9:52 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 8:53 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 8:50 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 8:23 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 8:10 AM

Mar 8 2018

krytarowski added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

In fact setting -z origin here on (current) versions of FreeBSD serves no purpose, but it also doesn't hurt anything.

Mar 8 2018, 1:48 AM

Mar 7 2018

krytarowski added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

ld(1) might accept -z origin, but why do we want it for other OSes? I don't see it used in the NetBSD dynamic ELF loader. DF_ORIGIN is just defined but not used by anything.

Mar 7 2018, 6:26 PM
krytarowski added a comment to D42702: Fix llvm-config --system-libs output on FreeBSD and NetBSD.

While there. There is feature in Clang/LLVM to print stacktrace on a crash. This is unusable on BSDs, as it prints signal handler's stacktrace instead of the program one. So regardless of cargo culting backtrace(3) it does not work as intended.

Mar 7 2018, 10:57 AM
krytarowski planned changes to D42050: Intercept tzset in MSan on NetBSD.

I've entirely switched to NetBSD kernel fixes in order to host fully-functional LLDB. Once I will be done with the debugger, I will be back to sanitizers and work on connecting a buildbot and remaining fixes and cleanup.

Mar 7 2018, 1:27 AM · Restricted Project
krytarowski planned changes to D43879: Cleanup in sanitizer_common_interceptors.inc.

I've entirely switched to NetBSD kernel fixes in order to host fully-functional LLDB. Once I will be done with the debugger, I will be back to sanitizers and work on connecting a buildbot and remaining fixes and cleanup.

Mar 7 2018, 1:27 AM · Restricted Project