User Details
- User Since
- Aug 30 2015, 11:51 AM (395 w, 6 d)
Jun 19 2022
Jun 1 2022
Nov 26 2021
Sep 27 2021
NetBSD and FreeBSD do not support non-stop in the kernel.
Sep 22 2021
Sep 9 2021
Looks still fine.
Sep 8 2021
There is an unhandled comment.
Sep 7 2021
Looks good
Sep 6 2021
Looks correct.
Looks good
Sep 2 2021
Looks good
Aug 31 2021
Let's see.
Looks reasonable
Looks correct.
Aug 30 2021
Looks good.
Jun 20 2021
May 11 2021
May 1 2021
Apr 25 2021
Apr 20 2021
Sanitizers run on NetBSD/sparc64.
Mar 7 2021
Looks ok for NetBSD.
Feb 20 2021
NetBSD OK!
Feb 13 2021
MAP_NORESERVE is dead on NetBSD as this is the default mode always.
Feb 8 2021
Would it be possible for NetBSD to also use this approach for the libc_pthread_ functions? Or is only a subset exported as libc_pthread_?
Can you follow the NetBSD approach and go for something like TSAN_MAYBE_INTERCEPT_NETBSD_ALIAS instead of patching shared code between all platforms?
Feb 4 2021
Merging is a good idea as NetBSD might duplicate these code chunks too.
Jan 30 2021
Jan 29 2021
@clayborg please have a look!
Jan 18 2021
These symbols are usually macros + libc calls.
Jan 13 2021
NetBSD uses macros too, but undefines them inside the header for __cplusplus. The proposed patch looks fine. This is a common source of portability issues, the stdio macros.
Jan 12 2021
Dec 28 2020
Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.
Dec 15 2020
Dec 10 2020
Please include stdlib.h for alloca, unless you target SunOS. alloca.h is unavailable on NetBSD.
Dec 4 2020
Dec 1 2020
Ideally we should iterate over the startup process and investigate the state of the r_debug structure. Once it gets initialized, set the software brakpoint to r_brk and keep track of the dynamic loading and unloading of libraries. The tricky part is to detect the right moment to plug into r_brk, early enough in the startup process before calling constructors, loading the libraries etc and late enough to become initialized.
Nov 30 2020
Nov 23 2020
I would mark stmmX as an alias to stX and keep stX as the default for all platforms. stmmX could be an alias for everybody for legacy reasons.
Nov 19 2020
Nov 11 2020
Nov 10 2020
Nov 9 2020
Nov 8 2020
Nov 7 2020
I propose to filter all user induced signals at once and check & 0x10000 and SI_USER.
Nov 6 2020
I wonder why NetBSD fails having the same event handling.
Nov 5 2020
Nov 2 2020
It's relevant but I encountered issues to pass the review..
Oct 31 2020
Oct 28 2020
Oct 26 2020
Looks OK from the NetBSD point of view.
Oct 25 2020
Oct 24 2020
Oct 23 2020
Oct 21 2020
Oct 20 2020
Host a LLVM buildbot for DragonFly first, otherwise it will be even not ever build-tested.
Oct 19 2020
Oct 18 2020
Please leave builtins intact. ubsan might work, but removing it too is fine.
Oct 17 2020
Please, First remove unused + unusable code for already introduced OS. At most cutting it to ubsan.
This contains unrelated code to ubsan/dragonflybsd. While there can you remove unsupported code for other OSs you introduced? That was never operational?
Oct 15 2020
Oct 14 2020
Oct 13 2020
Oct 12 2020
Oct 10 2020
+ @bsdjhb John, could you have a look?