krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (119 w, 1 d)

Recent Activity

Sat, Dec 9

krytarowski created D41054: Teach clang/NetBSD about additional dependencies for sanitizers.
Sat, Dec 9, 6:49 PM · Restricted Project
krytarowski added a comment to D41053: Set of corrections for MSan/NetBSD.
********************
Testing Time: 94.77s
********************
Failing Tests (7):
    MemorySanitizer-x86_64 :: chained_origin_with_signals.cc
    MemorySanitizer-x86_64 :: dtls_test.c
    MemorySanitizer-x86_64 :: fork.cc
    MemorySanitizer-x86_64 :: sem_getvalue.cc
    MemorySanitizer-x86_64 :: signal_stress_test.cc
    MemorySanitizer-x86_64 :: textdomain.cc
    MemorySanitizer-x86_64 :: tzset.cc
Sat, Dec 9, 6:00 PM · Restricted Project
krytarowski created D41053: Set of corrections for MSan/NetBSD.
Sat, Dec 9, 5:54 PM · Restricted Project
krytarowski planned changes to D41013: Fix test/msan/textdomain.cc on NetBSD.
Sat, Dec 9, 10:33 AM · Restricted Project

Fri, Dec 8

krytarowski reopened D41013: Fix test/msan/textdomain.cc on NetBSD.

Reverted, it breaks Linux.

Fri, Dec 8, 6:40 PM · Restricted Project
krytarowski added a comment to D40159: Correct handling of the TLS/NetBSD block of the main program.

As discussed with Joerg, this TLS handling is questionable by design, but the proposed NetBSD code is not worse than any other OS.

Fri, Dec 8, 6:09 PM · Restricted Project
krytarowski added inline comments to D41017: Fix test/msan/iconv.cc on NetBSD.
Fri, Dec 8, 4:41 PM · Restricted Project
krytarowski closed D41022: Register NetBSD/x86_64 in MemorySanitizer.cpp.
Fri, Dec 8, 4:32 PM · Restricted Project
krytarowski added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.

http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/1187

Fri, Dec 8, 3:51 PM · Restricted Project
krytarowski planned changes to D40714: Correct atexit(3) support in MSan/NetBSD.

I'm not reproducing the issues on NetBSD, so for now I will move this to background and keep patches locally.

Fri, Dec 8, 10:45 AM · Restricted Project
krytarowski reopened D40714: Correct atexit(3) support in MSan/NetBSD.

Reverted, as it broke Linux.

Fri, Dec 8, 10:42 AM · Restricted Project
krytarowski created D41023: Add NetBSD/x86_64 mapping in MSan.
Fri, Dec 8, 10:12 AM · Restricted Project
krytarowski created D41022: Register NetBSD/x86_64 in MemorySanitizer.cpp.
Fri, Dec 8, 10:10 AM · Restricted Project
krytarowski created D41021: Don't link NetBSD programs with -ldl in linkXRayRuntimeDeps.
Fri, Dec 8, 9:46 AM · Restricted Project
krytarowski created D41019: NetBSD ships with POSIX strerror_r(3).
Fri, Dec 8, 9:22 AM · Restricted Project
krytarowski created D41018: Disable test/msan/ftime.cc on NetBSD.
Fri, Dec 8, 9:15 AM · Restricted Project
krytarowski created D41017: Fix test/msan/iconv.cc on NetBSD.
Fri, Dec 8, 8:59 AM · Restricted Project
krytarowski created D41015: Fix test/msan/ifaddrs.cc for NetBSD.
Fri, Dec 8, 8:55 AM · Restricted Project
krytarowski created D41014: Disable test/msan/pvalloc.cc on NetBSD.
Fri, Dec 8, 8:52 AM · Restricted Project
krytarowski created D41013: Fix test/msan/textdomain.cc on NetBSD.
Fri, Dec 8, 8:48 AM · Restricted Project
krytarowski created D41011: Disable test/msan/tsearch.cc on NetBSD.
Fri, Dec 8, 8:44 AM · Restricted Project
krytarowski added a reviewer for D40159: Correct handling of the TLS/NetBSD block of the main program: vitalybuka.
Fri, Dec 8, 8:22 AM · Restricted Project

Thu, Dec 7

krytarowski added inline comments to D40935: Hardware-assisted AddressSanitizer (compiler-rt).
Thu, Dec 7, 4:03 PM

Wed, Dec 6

krytarowski added inline comments to D40935: Hardware-assisted AddressSanitizer (compiler-rt).
Wed, Dec 6, 5:36 PM
krytarowski added a comment to D40159: Correct handling of the TLS/NetBSD block of the main program.

I've addressed the comments in review.

Wed, Dec 6, 2:12 PM · Restricted Project
krytarowski added a comment to D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.

I think it's done now.

Wed, Dec 6, 12:45 PM · Restricted Project
krytarowski updated the diff for D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.

Apply changes from review.

Wed, Dec 6, 12:30 PM · Restricted Project
krytarowski added inline comments to D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Wed, Dec 6, 11:34 AM · Restricted Project
krytarowski closed D39798: [Sanitizers] Use SANITIZER_* macros in lib/interception.
Wed, Dec 6, 9:02 AM · Restricted Project
krytarowski accepted D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].

Looks fine.

Wed, Dec 6, 8:34 AM
krytarowski added inline comments to D40900: [Sanitizers, test] Fix sanitizer tests on Solaris (PR 33274).
Wed, Dec 6, 8:24 AM · Restricted Project
krytarowski added inline comments to D40898: [Sanitizers] Basic sanitizer Solaris support (PR 33274).
Wed, Dec 6, 8:19 AM · Restricted Project

Tue, Dec 5

krytarowski added a comment to D40767: Support pthread_key_create symbol alias in MSan/NetBSD.

Just reminding about my side question:

Tue, Dec 5, 7:07 PM · Restricted Project
krytarowski updated the diff for D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
  • rename sigaction_symname to SIGACTION_SYMNAME
  • put SIGACTION_SYMNAME in sanitizer_common/sanitizer_platform_limits_posix.h and ..netbsd.h
Tue, Dec 5, 6:27 PM · Restricted Project
krytarowski added inline comments to D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Tue, Dec 5, 6:09 PM · Restricted Project
krytarowski updated the diff for D40714: Correct atexit(3) support in MSan/NetBSD.

Remove comments stating obvious.

Tue, Dec 5, 5:30 PM · Restricted Project
krytarowski added inline comments to D40714: Correct atexit(3) support in MSan/NetBSD.
Tue, Dec 5, 5:24 PM · Restricted Project
krytarowski closed D40767: Support pthread_key_create symbol alias in MSan/NetBSD.
Tue, Dec 5, 5:17 PM · Restricted Project
krytarowski updated the diff for D40767: Support pthread_key_create symbol alias in MSan/NetBSD.
Tue, Dec 5, 5:15 PM · Restricted Project
krytarowski updated the diff for D40767: Support pthread_key_create symbol alias in MSan/NetBSD.
Tue, Dec 5, 5:12 PM · Restricted Project
krytarowski closed D40764: Disable absent functions in MSan/NetBSD interceptors.
Tue, Dec 5, 5:03 PM · Restricted Project
krytarowski added inline comments to D40714: Correct atexit(3) support in MSan/NetBSD.
Tue, Dec 5, 4:57 PM · Restricted Project
krytarowski added inline comments to D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Tue, Dec 5, 4:47 PM · Restricted Project
krytarowski added inline comments to D40767: Support pthread_key_create symbol alias in MSan/NetBSD.
Tue, Dec 5, 4:45 PM · Restricted Project
krytarowski updated the diff for D40159: Correct handling of the TLS/NetBSD block of the main program.
Tue, Dec 5, 8:21 AM · Restricted Project
krytarowski added a comment to D40159: Correct handling of the TLS/NetBSD block of the main program.

@joerg done. I will fix improve handling of dynamically allocated vectors in another revision.

Tue, Dec 5, 5:38 AM · Restricted Project
krytarowski retitled D40159: Correct handling of the TLS/NetBSD block of the main program from Make TLS/NetBSD handling more generic to Make static TLS/NetBSD handling more generic.
Tue, Dec 5, 5:37 AM · Restricted Project
krytarowski updated the diff for D40159: Correct handling of the TLS/NetBSD block of the main program.
  • Fix bug with static TLS vector index.
  • Reuse dl_iterate_phdr().
  • Simplify code.
Tue, Dec 5, 5:35 AM · Restricted Project

Mon, Dec 4

krytarowski added a comment to D40159: Correct handling of the TLS/NetBSD block of the main program.

Back to it as required for MSan.

Mon, Dec 4, 2:43 PM · Restricted Project
krytarowski updated the diff for D40714: Correct atexit(3) support in MSan/NetBSD.

Rebase to trunk.
Reuse __sanitizer::Vector.

Mon, Dec 4, 11:32 AM · Restricted Project
krytarowski closed D40765: Handle NetBSD symbol renaming in sanitizer_common_interceptors.inc.
Mon, Dec 4, 10:24 AM · Restricted Project
krytarowski closed D40726: Move __tsan::Vector to __sanitizer.
Mon, Dec 4, 4:30 AM · Restricted Project

Sat, Dec 2

krytarowski added a comment to D40767: Support pthread_key_create symbol alias in MSan/NetBSD.

While there.. is lib/sanitizer_common/sanitizer_common_syscalls.inc required for MSan?

Sat, Dec 2, 6:52 AM · Restricted Project
krytarowski updated the diff for D40767: Support pthread_key_create symbol alias in MSan/NetBSD.
Sat, Dec 2, 5:42 AM · Restricted Project
krytarowski created D40767: Support pthread_key_create symbol alias in MSan/NetBSD.
Sat, Dec 2, 5:39 AM · Restricted Project
krytarowski updated the diff for D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Sat, Dec 2, 5:34 AM · Restricted Project
krytarowski created D40766: Handle NetBSD symbol renaming in msan_interceptors.cc.
Sat, Dec 2, 5:33 AM · Restricted Project
krytarowski added inline comments to D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].
Sat, Dec 2, 3:56 AM
krytarowski created D40765: Handle NetBSD symbol renaming in sanitizer_common_interceptors.inc.
Sat, Dec 2, 3:56 AM · Restricted Project
krytarowski created D40764: Disable absent functions in MSan/NetBSD interceptors.
Sat, Dec 2, 3:00 AM · Restricted Project

Fri, Dec 1

krytarowski added inline comments to D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].
Fri, Dec 1, 11:34 AM
krytarowski added inline comments to D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].
Fri, Dec 1, 11:10 AM
krytarowski planned changes to D40714: Correct atexit(3) support in MSan/NetBSD.
Fri, Dec 1, 7:24 AM · Restricted Project
krytarowski updated the diff for D40726: Move __tsan::Vector to __sanitizer.

Remove unrelated local changes from this patch.

Fri, Dec 1, 7:21 AM · Restricted Project
krytarowski added inline comments to D40714: Correct atexit(3) support in MSan/NetBSD.
Fri, Dec 1, 7:05 AM · Restricted Project
krytarowski created D40726: Move __tsan::Vector to __sanitizer.
Fri, Dec 1, 7:04 AM · Restricted Project
krytarowski created D40714: Correct atexit(3) support in MSan/NetBSD.
Fri, Dec 1, 4:23 AM · Restricted Project

Thu, Nov 30

krytarowski added inline comments to D40679: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator [redo].
Thu, Nov 30, 4:25 PM
krytarowski added a comment to D40659: Fix the MIPS baremetal build.

OK, so we can reschedule it for later. Excuse me for noise. It looks like compiler-rt wasn't built (in a while) on NetBSD/evbmips (release engineering machines test x86_64, i386, ppc, sparc, sparc64, arm). Once it will be done, we will address it.

Thu, Nov 30, 3:43 PM
krytarowski added a comment to D40659: Fix the MIPS baremetal build.

It looks like current NetBSD has it as <mips/cachectl.h>, my mistake.

Thu, Nov 30, 3:14 PM
krytarowski added a comment to D40659: Fix the MIPS baremetal build.

Please correct this commit. This header is also present on NetBSD/MIPS.

We can add

|| defined(__NetBSD__)

What about FreeBSD, is it the same?

Thu, Nov 30, 3:08 PM
krytarowski added a comment to D40657: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator.

@krytarowski: so directly call the syscall on NetBSD or is there a possible performance gain calling the libc function as opposed to the syscall?

Thu, Nov 30, 12:28 PM
krytarowski added inline comments to D40666: [sanitizer] Use MADV_FREE on Darwin/BSD to release pages to the OS.
Thu, Nov 30, 12:10 PM · Restricted Project
krytarowski added a comment to D40657: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator.

Additionally NetBSD requires symbol mangling: clock_gettime -> __clock_gettime50.

Thu, Nov 30, 11:50 AM
krytarowski added a comment to D40657: [sanitizer] Introduce a vDSO aware time function, and use it in the allocator.

NetBSD does not ship with vDSO and the code should/could be disabled for it.

Thu, Nov 30, 11:46 AM
krytarowski added a comment to D40659: Fix the MIPS baremetal build.

Please correct this commit. This header is also present on NetBSD/MIPS.

Thu, Nov 30, 11:18 AM

Wed, Nov 29

krytarowski added a comment to D40583: Defer StartBackgroundThread() and StopBackgroundThread() in TSan.

Interesting. Did you see the same problem with ASan spawning its background thread (the one that does RSS limiting) too early as well? If not, then what's different between that and TSan?

Wed, Nov 29, 11:38 AM · Restricted Project
krytarowski added a comment to D40583: Defer StartBackgroundThread() and StopBackgroundThread() in TSan.

Thank you again for the great support!

Wed, Nov 29, 2:33 AM · Restricted Project
krytarowski closed D40583: Defer StartBackgroundThread() and StopBackgroundThread() in TSan.
Wed, Nov 29, 2:24 AM · Restricted Project
krytarowski updated the diff for D40583: Defer StartBackgroundThread() and StopBackgroundThread() in TSan.
  • rename TSanMaybeSpawnBackgroundThread() to MaybeSpawnBackgroundThread ()
  • simplify atomic check in MaybeSpawnBackgroundThread()
Wed, Nov 29, 2:23 AM · Restricted Project

Tue, Nov 28

krytarowski updated the diff for D40583: Defer StartBackgroundThread() and StopBackgroundThread() in TSan.

Try to make the code prettier.

Tue, Nov 28, 3:59 PM · Restricted Project
krytarowski created D40583: Defer StartBackgroundThread() and StopBackgroundThread() in TSan.
Tue, Nov 28, 3:10 PM · Restricted Project
krytarowski closed D40337: Support the setjmp(3) family of functions in TSan/NetBSD.
Tue, Nov 28, 9:35 AM · Restricted Project
krytarowski updated the diff for D40337: Support the setjmp(3) family of functions in TSan/NetBSD.

Try to share more code between NetBSD and Linux.

Tue, Nov 28, 7:57 AM · Restricted Project
krytarowski added a comment to D40337: Support the setjmp(3) family of functions in TSan/NetBSD.

I will give it a try.

Tue, Nov 28, 3:00 AM · Restricted Project
krytarowski closed D40341: Handle symbol renaming of sigaction for NetBSD.
Tue, Nov 28, 2:55 AM · Restricted Project
krytarowski added a comment to D40341: Handle symbol renaming of sigaction for NetBSD.

Thanks! I've uploaded a slightly older diff, that has another renaming in sanitizer_signal_interceptors.inc. I will commit the newer version and check the remaining portability issues on buildbots.

Tue, Nov 28, 2:51 AM · Restricted Project
krytarowski resigned from D40498: [compiler-rt] Set up .arcconfig to point to new Diffusion CRT repository.
Tue, Nov 28, 12:32 AM

Mon, Nov 27

krytarowski closed D40464: Build more sanitizers for NetBSD.
Mon, Nov 27, 9:54 AM · Restricted Project
krytarowski added a reviewer for D40423: [ARM][AArch64] Workaround ARM/AArch64 percularity in clearing icache.: lhames.
Mon, Nov 27, 3:31 AM
krytarowski added a comment to D40423: [ARM][AArch64] Workaround ARM/AArch64 percularity in clearing icache..

I think Memory should be removed as it's impossible to make it portable as is to every combination of OS and hardware. It's too low-level interface.

Mon, Nov 27, 3:29 AM

Sun, Nov 26

krytarowski closed D40456: Enable additonal features in NetBSD.
Sun, Nov 26, 2:25 PM · Restricted Project
krytarowski added a comment to D40456: Enable additonal features in NetBSD.

D40464 related.

Sun, Nov 26, 1:59 PM · Restricted Project
krytarowski closed D40294: Prevent Thread Exited/Joined events race.
Sun, Nov 26, 12:20 PM · Restricted Project
krytarowski created D40464: Build more sanitizers for NetBSD.
Sun, Nov 26, 3:07 AM · Restricted Project
krytarowski closed D40457: Detect thread termination in LSan/NetBSD.
Sun, Nov 26, 1:42 AM · Restricted Project
krytarowski added a comment to D40456: Enable additonal features in NetBSD.

Evgenii, do you know what's the policy for enabling these flags?

Sun, Nov 26, 1:36 AM · Restricted Project

Sat, Nov 25

krytarowski closed D40382: Plug dlerror() leak for swift_demangle.
Sat, Nov 25, 8:47 AM · Restricted Project
krytarowski created D40457: Detect thread termination in LSan/NetBSD.
Sat, Nov 25, 8:41 AM · Restricted Project
krytarowski created D40456: Enable additonal features in NetBSD.
Sat, Nov 25, 7:32 AM · Restricted Project