krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (138 w, 4 d)

Recent Activity

Yesterday

krytarowski added a comment to D45652: Asan, fix FreeBSD support.

Please fix the hang in AsanTSDInit

Wed, Apr 25, 10:26 AM
krytarowski added a comment to D46006: [Sanitizers] Fix Solaris build.

Not bad. It looks like FreeBSD ASan broke too... https://bugs.llvm.org/show_bug.cgi?id=37238

Wed, Apr 25, 8:01 AM · Restricted Project
krytarowski added a comment to D46006: [Sanitizers] Fix Solaris build.
In D46006#1077941, @ro wrote:

Can you run tests on SunOS? check-asan, check-ubsan etc.

Of course: that's the first thing I did after fixing the build (run make check-all, that is, which includes the above). Same as before the
breakage.

Wed, Apr 25, 7:45 AM · Restricted Project

Tue, Apr 24

krytarowski added a comment to D46006: [Sanitizers] Fix Solaris build.

Can you run tests on SunOS? check-asan, check-ubsan etc.

Tue, Apr 24, 8:34 AM · Restricted Project

Mon, Apr 23

krytarowski updated subscribers of D41240: [Solaris] __float128 is supported on Solaris/x86.

Does it work for you for 32-bit? @joerg opposed adoption of 32-bit version as it seemed to be unimplemented..

Mon, Apr 23, 5:57 AM

Fri, Apr 6

krytarowski added a comment to D45359: [cmake] Improve pthread_[gs]etname_np detection code.

This patch looks fine, not sure if we can improve it.

Fri, Apr 6, 8:34 AM
krytarowski added a comment to D45359: [cmake] Improve pthread_[gs]etname_np detection code.

FreeBSD also uses pthread_np.h header.

Fri, Apr 6, 5:41 AM
krytarowski added a comment to D45359: [cmake] Improve pthread_[gs]etname_np detection code.

Just a note that FreeBSD calls its function pthread_set_name_np.

Fri, Apr 6, 5:39 AM

Mar 17 2018

krytarowski added a comment to D44604: Make stdarg.h compatible with FreeBSD.

This does not fix the potential problem on NetBSD. We define __VA_LIST_DECLARED (with extra _ on the beginning).

Mar 17 2018, 7:40 PM

Mar 12 2018

krytarowski accepted D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).

I cannot test it shortly on NetBSD, but if there are any issues left (probably none) - I will fix it in future.

Mar 12 2018, 10:29 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 9:52 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 8:53 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 8:50 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 8:23 AM
krytarowski added inline comments to D44379: [cmake] Fix standalone+LLVM_LINK_LLVM_DYLIB builds (pr36687).
Mar 12 2018, 8:10 AM

Mar 8 2018

krytarowski added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

In fact setting -z origin here on (current) versions of FreeBSD serves no purpose, but it also doesn't hurt anything.

Mar 8 2018, 1:48 AM

Mar 7 2018

krytarowski added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

ld(1) might accept -z origin, but why do we want it for other OSes? I don't see it used in the NetBSD dynamic ELF loader. DF_ORIGIN is just defined but not used by anything.

Mar 7 2018, 6:26 PM
krytarowski added a comment to D42702: Fix llvm-config --system-libs output on FreeBSD and NetBSD.

While there. There is feature in Clang/LLVM to print stacktrace on a crash. This is unusable on BSDs, as it prints signal handler's stacktrace instead of the program one. So regardless of cargo culting backtrace(3) it does not work as intended.

Mar 7 2018, 10:57 AM
krytarowski planned changes to D42050: Intercept tzset in MSan on NetBSD.

I've entirely switched to NetBSD kernel fixes in order to host fully-functional LLDB. Once I will be done with the debugger, I will be back to sanitizers and work on connecting a buildbot and remaining fixes and cleanup.

Mar 7 2018, 1:27 AM · Restricted Project
krytarowski planned changes to D43879: Cleanup in sanitizer_common_interceptors.inc.

I've entirely switched to NetBSD kernel fixes in order to host fully-functional LLDB. Once I will be done with the debugger, I will be back to sanitizers and work on connecting a buildbot and remaining fixes and cleanup.

Mar 7 2018, 1:27 AM · Restricted Project

Mar 5 2018

krytarowski added a comment to D43751: [cmake] Append -Wl,-rpath-link conditionally to GNULD.

LGTM from the FreeBSD perspective

(Aside, it seems to me -Wl,-z,origin could be applied unconditionally, not only on FreeBSD/DragonFly).

Mar 5 2018, 8:38 AM

Mar 4 2018

krytarowski added inline comments to D43879: Cleanup in sanitizer_common_interceptors.inc.
Mar 4 2018, 1:51 AM · Restricted Project

Mar 3 2018

krytarowski added a comment to D44035: Support OpenBSD in common interceptors.

Another failure example:

Mar 3 2018, 7:31 AM
krytarowski added inline comments to D44035: Support OpenBSD in common interceptors.
Mar 3 2018, 7:13 AM
krytarowski requested changes to D44035: Support OpenBSD in common interceptors.
Mar 3 2018, 7:10 AM
krytarowski reopened D44035: Support OpenBSD in common interceptors.
Mar 3 2018, 7:10 AM
krytarowski added inline comments to D44035: Support OpenBSD in common interceptors.
Mar 3 2018, 7:10 AM
krytarowski added a comment to D44035: Support OpenBSD in common interceptors.
[63/93] Building CXX object projects/compiler-rt/lib/esan/CMakeFiles/clang_rt.esan-x86_64.dir/esan_interceptors.cpp.o
FAILED: projects/compiler-rt/lib/esan/CMakeFiles/clang_rt.esan-x86_64.dir/esan_interceptors.cpp.o 
/usr/bin/c++   -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Iprojects/compiler-rt/lib/esan -I/b/sanitizer-x86_64-linux-fuzzer/build/llvm/projects/compiler-rt/lib/esan -Iinclude -I/b/sanitizer-x86_64-linux-fuzzer/build/llvm/include -I/b/sanitizer-x86_64-linux-fuzzer/build/llvm/projects/compiler-rt/lib/esan/.. -fPIC -fvisibility-inlines-hidden -Werror=date-time -std=c++11 -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wno-maybe-uninitialized -Wdelete-non-virtual-dtor -Wno-comment -ffunction-sections -fdata-sections -Wall -std=c++11 -Wno-unused-parameter -O3 -DNDEBUG    -m64 -fno-lto -fPIC -fno-builtin -fno-exceptions -fomit-frame-pointer -funwind-tables -fno-stack-protector -fvisibility=hidden -fno-lto -O3 -g -Wno-variadic-macros -Wno-non-virtual-dtor -fno-rtti -MD -MT projects/compiler-rt/lib/esan/CMakeFiles/clang_rt.esan-x86_64.dir/esan_interceptors.cpp.o -MF projects/compiler-rt/lib/esan/CMakeFiles/clang_rt.esan-x86_64.dir/esan_interceptors.cpp.o.d -o projects/compiler-rt/lib/esan/CMakeFiles/clang_rt.esan-x86_64.dir/esan_interceptors.cpp.o -c /b/sanitizer-x86_64-linux-fuzzer/build/llvm/projects/compiler-rt/lib/esan/esan_interceptors.cpp
In file included from /b/sanitizer-x86_64-linux-fuzzer/build/llvm/projects/compiler-rt/lib/esan/esan_interceptors.cpp:178:0:
/b/sanitizer-x86_64-linux-fuzzer/build/llvm/projects/compiler-rt/lib/esan/../sanitizer_common/sanitizer_common_interceptors.inc:4445:0: warning: "INIT_PTHREAD_ATTR_GET_SCHED" redefined
 #define INIT_PTHREAD_ATTR_GET_SCHED
Mar 3 2018, 7:03 AM
krytarowski added a comment to D44068: OpenBSD sanitizer common, define RLIMIT_AS constant.

Knowing OpenBSD, their goal is no compatibility with others.

Mar 3 2018, 7:00 AM
krytarowski added a comment to D44035: Support OpenBSD in common interceptors.

Please don't submit untested patches, they should be at least build-tested.

Mar 3 2018, 6:53 AM
krytarowski added a comment to D44035: Support OpenBSD in common interceptors.

Reverted, broken syntax.

Mar 3 2018, 6:53 AM
krytarowski added inline comments to D44035: Support OpenBSD in common interceptors.
Mar 3 2018, 5:21 AM
krytarowski added inline comments to D43879: Cleanup in sanitizer_common_interceptors.inc.
Mar 3 2018, 5:14 AM · Restricted Project
krytarowski added a comment to D44035: Support OpenBSD in common interceptors.

Please improve the description. List supported interceptors and changes in existing interceptors.

Mar 3 2018, 5:08 AM
krytarowski added inline comments to D44068: OpenBSD sanitizer common, define RLIMIT_AS constant.
Mar 3 2018, 4:39 AM
krytarowski added inline comments to D44035: Support OpenBSD in common interceptors.
Mar 3 2018, 4:37 AM
krytarowski added a comment to D44035: Support OpenBSD in common interceptors.
--------------------------
|Index: lib/sanitizer_common/sanitizer_common_interceptors.inc
|===================================================================
|--- lib/sanitizer_common/sanitizer_common_interceptors.inc
|+++ lib/sanitizer_common/sanitizer_common_interceptors.inc
--------------------------
Patching file lib/sanitizer_common/sanitizer_common_interceptors.inc using Plan A...
Hunk #1 failed at 3590.
Hunk #2 succeeded at 4407.
Hunk #3 succeeded at 4423.
Hunk #4 succeeded at 4455.
Hunk #5 succeeded at 7174.
1 out of 5 hunks failed--saving rejects to lib/sanitizer_common/sanitizer_common_interceptors.inc.rej
done
Mar 3 2018, 4:20 AM
krytarowski retitled D44035: Support OpenBSD in common interceptors from OpenBSD UBsan support, having common INIT_PTHREAD_ATTR_GET and for non OpenBSD systems INIT_PTHREAD_ATTR_GET_SCHED macros to Support OpenBSD in common interceptors.
Mar 3 2018, 4:17 AM
krytarowski added a comment to D44035: Support OpenBSD in common interceptors.

The title and description does not match the diff.

Mar 3 2018, 4:09 AM
krytarowski added inline comments to D43909: OpenBSD UBsan support / common.
Mar 3 2018, 4:05 AM
krytarowski closed D43613: Msan, cmake configuration changes.

Hmm, this already landed as a part of D43080

Mar 3 2018, 4:02 AM
krytarowski added inline comments to D44035: Support OpenBSD in common interceptors.
Mar 3 2018, 3:57 AM

Mar 2 2018

krytarowski added a comment to D44056: [lldb] Fix "code unreachable" warning in HostThreadPosix::Cancel.

::pthread_cancel is available for NetBSD as well.

Mar 2 2018, 7:55 PM

Mar 1 2018

krytarowski added a comment to D43909: OpenBSD UBsan support / common.

Please try to partition this into 200-300 line patches.

Mar 1 2018, 11:39 PM
krytarowski added inline comments to D43894: OpenBSD UBsan support / ubsan part.
Mar 1 2018, 12:49 PM
krytarowski added inline comments to D43909: OpenBSD UBsan support / common.
Mar 1 2018, 5:27 AM
krytarowski added inline comments to D43909: OpenBSD UBsan support / common.
Mar 1 2018, 5:11 AM
krytarowski added inline comments to D43909: OpenBSD UBsan support / common.
Mar 1 2018, 5:04 AM
krytarowski added inline comments to D43909: OpenBSD UBsan support / common.
Mar 1 2018, 4:49 AM
krytarowski added inline comments to D43909: OpenBSD UBsan support / common.
Mar 1 2018, 4:39 AM

Feb 28 2018

krytarowski added a comment to D43909: OpenBSD UBsan support / common.

Assuming that OpenBSD is capable to run only a subset of functionality of UBSan (no unwinder, no 32-bit on 64-bit kernel etc), do we need all the code like sanitizer_platform_limits_openbsd?

Feb 28 2018, 11:37 PM
krytarowski added inline comments to D43894: OpenBSD UBsan support / ubsan part.
Feb 28 2018, 10:44 PM
krytarowski added inline comments to D43909: OpenBSD UBsan support / common.
Feb 28 2018, 10:40 PM
krytarowski created D43879: Cleanup in sanitizer_common_interceptors.inc.
Feb 28 2018, 10:03 AM · Restricted Project
krytarowski accepted D42702: Fix llvm-config --system-libs output on FreeBSD and NetBSD.

I would add an inline comment what's the purpose of this operation in CMake. Otherwise it looks good to me!

Feb 28 2018, 9:35 AM

Feb 27 2018

krytarowski added a comment to D42644: [asan] Intercept std::rethrow_exception indirectly..

This looks like broke ASan on NetBSD:

Feb 27 2018, 9:17 AM · Restricted Project

Feb 26 2018

krytarowski added a comment to D43539: Add new interceptors: getttyent(3) family.

I will add test name to CHECK in the test, and commit all three tests.

Feb 26 2018, 6:03 PM · Restricted Project
krytarowski added a comment to D43539: Add new interceptors: getttyent(3) family.

@vitalybuka I think you have reviewed an older snapshot. All the mentioned now issues are gone.

Feb 26 2018, 5:53 PM · Restricted Project
krytarowski updated the summary of D43543: Add new interceptors: getnetent(3) family.
Feb 26 2018, 5:54 AM · Restricted Project
krytarowski updated the summary of D43541: Add new interceptors: getprotoent(3) family.
Feb 26 2018, 5:54 AM · Restricted Project
krytarowski updated the summary of D43539: Add new interceptors: getttyent(3) family.
Feb 26 2018, 5:54 AM · Restricted Project
krytarowski updated the diff for D43543: Add new interceptors: getnetent(3) family.
  • apply patches from review
Feb 26 2018, 4:49 AM · Restricted Project
krytarowski updated the diff for D43541: Add new interceptors: getprotoent(3) family.
  • improve the patch
Feb 26 2018, 4:18 AM · Restricted Project
krytarowski updated subscribers of D42702: Fix llvm-config --system-libs output on FreeBSD and NetBSD.

I think that this should be a release blocker for 6.0.0. CC: @hans

Feb 26 2018, 4:06 AM
krytarowski updated the diff for D43541: Add new interceptors: getprotoent(3) family.
  • apply the remaining comments from review
Feb 26 2018, 2:58 AM · Restricted Project
krytarowski updated the diff for D43539: Add new interceptors: getttyent(3) family.
  • drop interceptors for setttyent(3) and endttyent(3)
Feb 26 2018, 1:40 AM · Restricted Project
krytarowski updated the diff for D43543: Add new interceptors: getnetent(3) family.
  • apply part of the comments from review
Feb 26 2018, 1:09 AM · Restricted Project
krytarowski updated the diff for D43541: Add new interceptors: getprotoent(3) family.
  • apply comments from review
  • improve the test
Feb 26 2018, 12:33 AM · Restricted Project

Feb 25 2018

krytarowski updated the diff for D43539: Add new interceptors: getttyent(3) family.
  • add missing changes to sanitizer_platform_limits_netbsd
  • fix a typo
Feb 25 2018, 11:22 PM · Restricted Project
krytarowski updated the diff for D43539: Add new interceptors: getttyent(3) family.

apply comments from review

Feb 25 2018, 10:57 PM · Restricted Project
krytarowski added inline comments to D43539: Add new interceptors: getttyent(3) family.
Feb 25 2018, 10:33 PM · Restricted Project
krytarowski added inline comments to D43539: Add new interceptors: getttyent(3) family.
Feb 25 2018, 2:13 PM · Restricted Project
krytarowski added a comment to D43539: Add new interceptors: getttyent(3) family.

Ping?

Feb 25 2018, 1:22 PM · Restricted Project

Feb 24 2018

krytarowski added a comment to D42702: Fix llvm-config --system-libs output on FreeBSD and NetBSD.
141 kamil@chieftec /public/llvm-build $ ./bin/llvm-config --link-static --system-libs                                                
-lz -lrt -lexecinfo -lterminfo -lpthread -lm
142 kamil@chieftec /public/llvm-build $ ./bin/llvm-config --system-libs               
-lz -lrt -lexecinfo -lterminfo -lpthread -lm
143 kamil@chieftec /public/llvm-build $ uname -rms
NetBSD 8.99.12 amd64
Feb 24 2018, 3:33 AM
krytarowski added a comment to D42702: Fix llvm-config --system-libs output on FreeBSD and NetBSD.

This looks good to me!

Feb 24 2018, 3:00 AM

Feb 23 2018

krytarowski added a comment to D42702: Fix llvm-config --system-libs output on FreeBSD and NetBSD.

This fixes it for me in the spirit of other library lookups (in that it doesn't bother with -L, but that could easily be added in). Despite Backtrace_LIBRARIES being plural I don't think it ever will be looking over FindBacktrace.cmake.

I have no clue about static linkage here.

https://people.freebsd.org/~bdrewery/patches/cmake-libexecinfo.diff

diff --git lib/Support/CMakeLists.txt lib/Support/CMakeLists.txt
index 5723f8fcf5b..dfbdd70701f 100644
--- lib/Support/CMakeLists.txt
+++ lib/Support/CMakeLists.txt
@@ -13,7 +13,9 @@ elseif( CMAKE_HOST_UNIX )
     set(system_libs ${system_libs} ${CMAKE_DL_LIBS})
   endif()
   if( HAVE_BACKTRACE )
-    set(system_libs ${system_libs} ${Backtrace_LIBRARIES})
+    get_filename_component(Backtrace_LIBFILE ${Backtrace_LIBRARIES} NAME_WE)
+    STRING(REGEX REPLACE "^lib" "" Backtrace_LIBFILE ${Backtrace_LIBFILE})
+    set(system_libs ${system_libs} ${Backtrace_LIBFILE})
   endif()
   if(LLVM_ENABLE_TERMINFO)
     if(HAVE_TERMINFO)
Feb 23 2018, 5:20 PM
krytarowski added a comment to D42020: Correct ctype(3) functions with NLS on NetBSD.

Hmm on the other hand.. these interceptors will be useful for NetBSD forks/descendants like FreeBSD (OpenBSD?) and perhaps other BSD descendants like SunOS (Solaris). I just don't enable them without prior-testing.

Feb 23 2018, 5:00 PM · Restricted Project
krytarowski added a comment to D42020: Correct ctype(3) functions with NLS on NetBSD.

I can move the patches there. How about D43543, D43541, D43539? Can I commit as it is and move them in one patch to a new file.

Feb 23 2018, 4:54 PM · Restricted Project
krytarowski added a comment to D42020: Correct ctype(3) functions with NLS on NetBSD.

ping?

Feb 23 2018, 4:20 PM · Restricted Project
krytarowski abandoned D43698: Plug errno in TCPSocket::Connect().

This is considered to be a local patch.

Feb 23 2018, 3:28 PM · Restricted Project
krytarowski added a comment to D43698: Plug errno in TCPSocket::Connect().

Here is an approach with save_errno, useful in libraries when we preserve errno for public functions in the API of a library as-is, and not leaking it from the internals to unrelated code.

Feb 23 2018, 3:17 PM · Restricted Project
krytarowski added a comment to D43698: Plug errno in TCPSocket::Connect().

This just helps debugging connectivity issues in other unrelated code-parts (I'm debugging why select(2) / recv(2) don't receive a packet of type qHostInfo).

Feb 23 2018, 3:10 PM · Restricted Project
krytarowski created D43698: Plug errno in TCPSocket::Connect().
Feb 23 2018, 2:49 PM · Restricted Project
krytarowski abandoned D43614: Define _PTHREADS for -pthread on NetBSD.

As discussed with Joerg, _PTHREADS is considered legacy and we can bear with lack of it and inconsistency with GCC.

Feb 23 2018, 5:47 AM · Restricted Project

Feb 22 2018

krytarowski added reviewers for D43613: Msan, cmake configuration changes: emaste, dim.

Naively looking at https://hardenedbsd.org/content/easy-feature-comparison PIE on FreeBSD might need more work.

Feb 22 2018, 3:38 PM
krytarowski created D43614: Define _PTHREADS for -pthread on NetBSD.
Feb 22 2018, 2:43 AM · Restricted Project

Feb 20 2018

krytarowski created D43543: Add new interceptors: getnetent(3) family.
Feb 20 2018, 7:30 PM · Restricted Project
krytarowski created D43541: Add new interceptors: getprotoent(3) family.
Feb 20 2018, 5:55 PM · Restricted Project
krytarowski created D43539: Add new interceptors: getttyent(3) family.
Feb 20 2018, 5:04 PM · Restricted Project
krytarowski added inline comments to D43482: Add new interceptor: fgetln(3).
Feb 20 2018, 7:51 AM · Restricted Project

Feb 19 2018

krytarowski added a comment to D43168: Don't use -ldl on BSD.

If I read the CMake's source code correctly, just including find_package(Threads) is enough to set OS specific flags.

https://github.com/Kitware/CMake/blob/9a509099f77ed32a0845e4e3fad7b8f1eb9be10b/Modules/FindThreads.cmake

Feb 19 2018, 9:47 PM
krytarowski added a comment to D43168: Don't use -ldl on BSD.

If I read the CMake's source code correctly, just including find_package(Threads) is enough to set OS specific flags.

Feb 19 2018, 9:44 PM
krytarowski added a comment to D43168: Don't use -ldl on BSD.

-pthreads defines additional OS specific flags like _REENTRANT or _PTHREADS and this is the form that should be used.

Feb 19 2018, 9:26 PM
krytarowski added a comment to D43490: Stop intercepting forkpty(3) and openpty(3) on NetBSD.

This also covers FreeBSD.

Feb 19 2018, 3:10 PM · Restricted Project
krytarowski created D43490: Stop intercepting forkpty(3) and openpty(3) on NetBSD.
Feb 19 2018, 3:10 PM · Restricted Project
krytarowski retitled D43482: Add new interceptor: fgetln(3) from Add new interceptor: fgetln(2) to Add new interceptor: fgetln(3).
Feb 19 2018, 2:51 PM · Restricted Project
krytarowski created D43485: Add new interceptor: strmode(3).
Feb 19 2018, 2:51 PM · Restricted Project
krytarowski created D43482: Add new interceptor: fgetln(3).
Feb 19 2018, 2:16 PM · Restricted Project
krytarowski updated the diff for D42020: Correct ctype(3) functions with NLS on NetBSD.
  • add test
  • split netbsd specific code to a new function
Feb 19 2018, 1:14 PM · Restricted Project

Feb 16 2018

krytarowski added inline comments to D43021: Recognize all NetBSD architectures in UBSan.
Feb 16 2018, 11:26 AM · Restricted Project