krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (168 w, 20 h)

Recent Activity

Sat, Nov 17

krytarowski accepted D54339: Fix threads detection on GNU/Hurd.
Sat, Nov 17, 8:07 AM
krytarowski added a comment to D54664: [tsan] Add __cxa_guard_acquire hooks to support cooperative scheduling.

Is this Linux-only?

Sat, Nov 17, 5:23 AM

Fri, Nov 16

krytarowski abandoned D33878: Handle NetBSD specific _Unwind_Ptr.

Committed non-controversial chunks of this. The rest is rescheduled for future in separate review.

Fri, Nov 16, 2:22 PM
krytarowski created D54650: Swap order of discovering of -ltinfo and -lterminfo.
Fri, Nov 16, 2:01 PM
krytarowski accepted D54641: [compiler-rt] [cmake] Fix detecting terminfo library.

Well, sure but I think changing the order should be done separately from this. I'm fixing a bug resulting from people deciding to customize code instead of keeping it in sync; so I'd rather not combine it with intentionally mis-syncing the code.

Fri, Nov 16, 1:39 PM
krytarowski added a comment to D54641: [compiler-rt] [cmake] Fix detecting terminfo library.

As I understand it -ltinfo vs -lterminfo is mixing native curses(3) and external ncurses(3) from pkgsrc, while we prefer to use entirely our native version for all LLVM projects.

Fri, Nov 16, 11:48 AM
krytarowski added a comment to D54641: [compiler-rt] [cmake] Fix detecting terminfo library.

Do not return -ltinfo from llvm-config --system-libs --link-static

under NetBSD. Bump PKGREVISION

Rust language 1.20.0 uses these options and Rust build system uses it
as '-l tinfo' and our wrapper does not handle this.

Fri, Nov 16, 11:48 AM
krytarowski added a comment to D54641: [compiler-rt] [cmake] Fix detecting terminfo library.

I have got a local patch in pkgsrc-wip/llvm-netbsd:

Fri, Nov 16, 11:40 AM

Thu, Nov 15

krytarowski updated the summary of D54530: Add new interceptor for mi_vector_hash(3).
Thu, Nov 15, 7:16 PM · Restricted Project
krytarowski updated the summary of D54247: Add interceptors for the fts(3) API family from NetBSD.
Thu, Nov 15, 7:15 PM · Restricted Project
krytarowski updated the summary of D54527: Add new interceptor for strtonum(3).
Thu, Nov 15, 7:14 PM · Restricted Project
krytarowski updated the summary of D54548: Add interceptor for the setvbuf(3) from NetBSD.
Thu, Nov 15, 7:14 PM · Restricted Project
krytarowski updated the summary of D54611: Add new interceptor for getmntinfo(3) from NetBSD.
Thu, Nov 15, 7:13 PM · Restricted Project
krytarowski updated the summary of D54594: Add new interceptors for vis(3) API in NetBSD.
Thu, Nov 15, 7:13 PM · Restricted Project
krytarowski created D54611: Add new interceptor for getmntinfo(3) from NetBSD.
Thu, Nov 15, 6:56 PM · Restricted Project
krytarowski updated the diff for D54594: Add new interceptors for vis(3) API in NetBSD.
  • add more tests
  • add missing rename
Thu, Nov 15, 5:46 PM · Restricted Project
krytarowski updated the summary of D54594: Add new interceptors for vis(3) API in NetBSD.
Thu, Nov 15, 5:45 PM · Restricted Project
krytarowski created D54594: Add new interceptors for vis(3) API in NetBSD.
Thu, Nov 15, 11:50 AM · Restricted Project
krytarowski created D54584: Add new interceptor for regex(3) in NetBSD.
Thu, Nov 15, 9:09 AM · Restricted Project
krytarowski added a comment to D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.

@hfinkel any comments on this? If not I recommend to land this patch as it is.

Thu, Nov 15, 7:01 AM
krytarowski added a comment to D54099: [Sanitizers] Disable SANITIZER_CAN_FAST_UNWIND on all SPARC targets.
In D54099#1296841, @ro wrote:

There is also sparc and sparc64 support in sanitizers on NetBSD... but I cannot say for now how well it works. For sure we run UBSan and ASan for both of them.

I still wonder how this works, though: I've just refreshed my patch for SPARC support in compiler-rt (https://reviews.llvm.org/D40900) and tried
again with patches on top to enable asan on 32-bit sparc in clang and the 32-bit asan tests in compiler-rt (trivial, but not submitted as pointless).

I immediately ran again into build failures of the compiler-rt asan tests:

fatal error: error in backend: Function "main": over-aligned dynamic alloca not supported.
clang-8: error: clang frontend command failed with exit code 70 (use -v to see invocation)

just the same as when I initially had submitted D40900. If you have a way around this, I'm all ears ;-)

I cannot reasonably try sparcv9 on Solaris, though, due to the particular address space layout used there.

However, as I mentioned since about a week an implementation of the TARGET_ASAN_SHADOW_OFFSET hook for sparc has landed in
gcc mainline, where asan works reasonably well.

ubsan should be no problem, admittedly.

Thu, Nov 15, 5:06 AM · Restricted Project

Wed, Nov 14

krytarowski created D54548: Add interceptor for the setvbuf(3) from NetBSD.
Wed, Nov 14, 3:11 PM · Restricted Project
krytarowski created D54530: Add new interceptor for mi_vector_hash(3).
Wed, Nov 14, 8:29 AM · Restricted Project
krytarowski created D54527: Add new interceptor for strtonum(3).
Wed, Nov 14, 7:54 AM · Restricted Project

Tue, Nov 13

krytarowski closed D54338: Fix threads build on GNU/Hurd.
Tue, Nov 13, 9:46 AM
krytarowski added a comment to D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin..

There is also start_deactivated in ASan.

Tue, Nov 13, 6:06 AM
krytarowski added inline comments to D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin..
Tue, Nov 13, 5:05 AM

Sat, Nov 10

krytarowski added inline comments to D54379: Add Hurd toolchain support to Clang.
Sat, Nov 10, 3:03 PM
krytarowski accepted D54338: Fix threads build on GNU/Hurd.
Sat, Nov 10, 2:59 PM
krytarowski added a comment to D54338: Fix threads build on GNU/Hurd.

It's not complete, there is remaining L24.

Sat, Nov 10, 1:53 PM
krytarowski added a comment to D54338: Fix threads build on GNU/Hurd.

Please replace defined(BSD).

Sat, Nov 10, 1:49 PM
krytarowski added a comment to D54338: Fix threads build on GNU/Hurd.

So that'd be it? I don't know if libcxx supports more than free/net/open bsd and apple ?

Sat, Nov 10, 4:04 AM

Fri, Nov 9

krytarowski updated subscribers of D40714: Correct atexit(3) support in MSan/NetBSD.

Thanks @mgorny for debugging on Linux.

Fri, Nov 9, 7:12 PM · Restricted Project
krytarowski updated the diff for D40714: Correct atexit(3) support in MSan/NetBSD.
  • fix Linux
Fri, Nov 9, 6:18 PM · Restricted Project
krytarowski added a comment to D54099: [Sanitizers] Disable SANITIZER_CAN_FAST_UNWIND on all SPARC targets.

There is also sparc and sparc64 support in sanitizers on NetBSD... but I cannot say for now how well it works. For sure we run UBSan and ASan for both of them.

Fri, Nov 9, 5:10 PM · Restricted Project
krytarowski added a comment to D54338: Fix threads build on GNU/Hurd.

Yes, please iterate over explicit BSDs. We don't support BSD4.4 or BSD/OS or such.

Fri, Nov 9, 2:20 PM

Wed, Nov 7

krytarowski added inline comments to D54076: Add interceptors for the sysctl(3) API family from NetBSD.
Wed, Nov 7, 5:54 PM · Restricted Project
krytarowski created D54247: Add interceptors for the fts(3) API family from NetBSD.
Wed, Nov 7, 5:31 PM · Restricted Project
krytarowski added a comment to D53975: Start adding the supporting code to perform out-of-process allocator enumeration..

They're not open source. The interface to them is at https://opensource.apple.com/source/Libc/Libc-498/include/malloc/malloc.h.

Wed, Nov 7, 4:13 PM
krytarowski updated the diff for D54076: Add interceptors for the sysctl(3) API family from NetBSD.
  • add more checks
Wed, Nov 7, 3:58 PM · Restricted Project
krytarowski updated the diff for D54076: Add interceptors for the sysctl(3) API family from NetBSD.
  • apply fixes from review
Wed, Nov 7, 3:46 PM · Restricted Project
krytarowski added inline comments to D54078: Implement getpeername(2) interceptor.
Wed, Nov 7, 1:21 PM · Restricted Project
krytarowski added a comment to D54221: Add setting to require hardware breakpoints..

On NetBSD one has to check PaX MPROTECT property of a traced process.

Wed, Nov 7, 1:17 PM · Restricted Project
krytarowski added a comment to D54078: Implement getpeername(2) interceptor.

ping

Wed, Nov 7, 5:14 AM · Restricted Project
krytarowski added a comment to D54051: Split remquol() from INIT_REMQUO.

ping

Wed, Nov 7, 5:14 AM · Restricted Project
krytarowski added a comment to D54076: Add interceptors for the sysctl(3) API family from NetBSD.

ping

Wed, Nov 7, 5:14 AM · Restricted Project
krytarowski added a comment to D54054: Split lgammal() from INIT_LGAMMAL.

Ping?

Wed, Nov 7, 5:06 AM · Restricted Project

Tue, Nov 6

krytarowski updated the summary of D54054: Split lgammal() from INIT_LGAMMAL.
Tue, Nov 6, 6:00 PM · Restricted Project
krytarowski accepted D54079: [OPENMP] Add Hurd support.
Tue, Nov 6, 3:35 PM
krytarowski added inline comments to D54079: [OPENMP] Add Hurd support.
Tue, Nov 6, 6:18 AM
krytarowski added inline comments to D54079: [OPENMP] Add Hurd support.
Tue, Nov 6, 6:15 AM
krytarowski created D54150: Adapt UBSan integer truncation tests to NetBSD.
Tue, Nov 6, 6:02 AM · Restricted Project
krytarowski added a comment to D49025: [XRay] basic mode PID and TID always fetch.

In this test parent_tid = 1, child_tid = 1 always and distinguishing this way child and parent is broken. Switching syscall_gettid() to behave like getpid() is not sufficient as the test has assumptions that thread is like pid.

Tue, Nov 6, 2:58 AM
krytarowski updated the summary of D54136: Prioritize the constructor call of __local_xray_dyninit().
Tue, Nov 6, 1:36 AM · Restricted Project

Mon, Nov 5

krytarowski added a comment to D54135: Add convenience method in FileSystem to check if a path/filespec is a directory..

Why? We already put a lot of effort into reusing code from LLVM.

Mon, Nov 5, 7:02 PM · Restricted Project
krytarowski retitled D54136: Prioritize the constructor call of __local_xray_dyninit() from Priority the constructor call of __local_xray_dyninit() to Prioritize the constructor call of __local_xray_dyninit().
Mon, Nov 5, 6:55 PM · Restricted Project
krytarowski created D54136: Prioritize the constructor call of __local_xray_dyninit().
Mon, Nov 5, 6:55 PM · Restricted Project
krytarowski added a comment to D53975: Start adding the supporting code to perform out-of-process allocator enumeration..

Interesting, are these tools open-source? I would be interested to port them to NetBSD.

Mon, Nov 5, 6:41 PM
krytarowski added a comment to D53975: Start adding the supporting code to perform out-of-process allocator enumeration..

Is this out of process only to enumarate? Is there an option to support this through debugging interfaces and analysis of a program?

Mon, Nov 5, 6:23 PM
krytarowski added a comment to D49025: [XRay] basic mode PID and TID always fetch.

This test seems to have a Linux assumption and I have concerns how to port it to NetBSD.

Mon, Nov 5, 6:08 PM
krytarowski abandoned D54081: Add new interceptor for atof(3).

The proper way to handle is to go for wrapping it with strtod(3), however it requires refactoring of existing sanitizers (msan, dfsan...).

Mon, Nov 5, 10:50 AM · Restricted Project
krytarowski added inline comments to D54081: Add new interceptor for atof(3).
Mon, Nov 5, 6:23 AM · Restricted Project
krytarowski accepted D54101: [Sanitizers] Solaris largefile fixes.
Mon, Nov 5, 6:09 AM · Restricted Project
krytarowski planned changes to D34018: Support __float128 on NetBSD libstdc++ x86/x86_64.

OK.

Mon, Nov 5, 5:57 AM

Sun, Nov 4

krytarowski requested review of D34018: Support __float128 on NetBSD libstdc++ x86/x86_64.

This change happened to be required in downstream usage.. knowing its limits can we merge it as it is?

Sun, Nov 4, 6:53 PM
krytarowski added inline comments to D33878: Handle NetBSD specific _Unwind_Ptr.
Sun, Nov 4, 7:54 AM
krytarowski requested review of D33878: Handle NetBSD specific _Unwind_Ptr.
Sun, Nov 4, 7:52 AM
krytarowski abandoned D42050: Intercept tzset in MSan on NetBSD.

I will abandon it for now, if it will make problems again I will show up with a new patch.

Sun, Nov 4, 7:33 AM · Restricted Project

Sat, Nov 3

krytarowski added a comment to D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.

@hfinkel I would still like to drop W|X support from MemoryBlock for everybody, restricting this class to swapping between RW and RX in JIT code. For those who need RWX allocations it's more convenient to add a dedicated allocator (and NetBSD can support it). It's just a matter of time when new features on security hardened OSes will break and lose feature parity.

Sat, Nov 3, 5:11 PM
krytarowski accepted D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.
Sat, Nov 3, 3:14 PM
krytarowski added inline comments to D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.
Sat, Nov 3, 3:07 PM
krytarowski added inline comments to D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.
Sat, Nov 3, 2:51 PM
krytarowski created D54081: Add new interceptor for atof(3).
Sat, Nov 3, 2:43 PM · Restricted Project
krytarowski added inline comments to D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled.
Sat, Nov 3, 2:38 PM
krytarowski added a reviewer for D54080: [unittest] Skip W+X MappedMemoryTests when MPROTECT is enabled: hfinkel.

+ hfinkel for JIT API reference.

Sat, Nov 3, 2:38 PM
krytarowski created D54078: Implement getpeername(2) interceptor.
Sat, Nov 3, 1:54 PM · Restricted Project
krytarowski created D54076: Add interceptors for the sysctl(3) API family from NetBSD.
Sat, Nov 3, 12:23 PM · Restricted Project
krytarowski added a comment to D52941: NativeProcessProtocol: Simplify breakpoint setting code.

This looks fine to me.

Sat, Nov 3, 8:07 AM

Fri, Nov 2

krytarowski requested review of D42050: Intercept tzset in MSan on NetBSD.
Fri, Nov 2, 3:19 PM · Restricted Project
krytarowski added a comment to D42050: Intercept tzset in MSan on NetBSD.

Ping?

Fri, Nov 2, 3:19 PM · Restricted Project
krytarowski created D54054: Split lgammal() from INIT_LGAMMAL.
Fri, Nov 2, 3:04 PM · Restricted Project
krytarowski created D54051: Split remquol() from INIT_REMQUO.
Fri, Nov 2, 2:44 PM · Restricted Project
krytarowski updated the diff for D54041: Split getpwent and fgetgrent functions in interceptors.

Remove unwanted SI_MAC.

Fri, Nov 2, 1:22 PM · Restricted Project
krytarowski created D54041: Split getpwent and fgetgrent functions in interceptors.
Fri, Nov 2, 11:12 AM · Restricted Project
krytarowski edited reviewers for D54030: Fix build on sparc64-linux-gnu., added: ro; removed: krytarowski.

Adding @ro for check whether it's fine for Solaris and SPARC.

Fri, Nov 2, 11:02 AM

Tue, Oct 30

krytarowski added a comment to D53863: Handle NetBSD alias for pthread_sigmask.

is this covered with existing test?

Tue, Oct 30, 11:50 AM · Restricted Project
krytarowski created D53863: Handle NetBSD alias for pthread_sigmask.
Tue, Oct 30, 1:31 AM · Restricted Project

Mon, Oct 29

krytarowski created D53806: Handle NetBSD symbol mangling for nanosleep and vfork.
Mon, Oct 29, 1:39 AM · Restricted Project

Oct 8 2018

krytarowski created D52994: Don't harcode -ldl test/sanitizer_common/TestCases.
Oct 8 2018, 10:47 AM · Restricted Project
krytarowski accepted D52941: NativeProcessProtocol: Simplify breakpoint setting code.

The NetBSD part looks fine. I will be out of the office soon as I will visit California for GSoC Mentor Summit and MeetBSDCa (until October 23rd).

Oct 8 2018, 2:13 AM

Oct 5 2018

krytarowski created D52955: Remove remnant code of using indirect syscall on NetBSD.
Oct 5 2018, 4:00 PM · Restricted Project

Oct 4 2018

krytarowski added inline comments to D52793: Introduce internal_sysctlbyname in place of sysctlbyname.
Oct 4 2018, 2:24 PM · Restricted Project

Oct 2 2018

krytarowski accepted D52719: Pull FixupBreakpointPCAsNeeded into base class.
Oct 2 2018, 11:27 AM
krytarowski created D52793: Introduce internal_sysctlbyname in place of sysctlbyname.
Oct 2 2018, 11:22 AM · Restricted Project

Oct 1 2018

krytarowski accepted D52717: [NFC] Fix `-Wcast-qual` warnings in Darwin `internal_sysctl(...)` implementation..
Oct 1 2018, 4:21 AM

Sep 30 2018

krytarowski added a comment to D52532: Pull GetSoftwareBreakpointPCOffset into base class.

I was wondering whether we want to normalize this inside the kernel and always advance the Program Counter.. but it's easier to manage it in userland.

I am generally in favour of keeping the kernel simple, particularly when ptrace is concerned. However, there is one difference in behaviour that annoys me. Right now, if an application itself inserts a trap into it's source code, on intel it will be easy to resume it from debugger simply by continuing. OTOH, on arm, the user will have to manually update the PC first. So I am not sure which is better here...

Sep 30 2018, 10:09 AM

Sep 29 2018

krytarowski updated the diff for D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.
Sep 29 2018, 2:02 AM · Restricted Project
krytarowski updated the diff for D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.
  • reduce code duplication with addition of helper macros
Sep 29 2018, 2:00 AM · Restricted Project

Sep 28 2018

krytarowski updated the diff for D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.
Sep 28 2018, 7:43 AM · Restricted Project
krytarowski updated the diff for D51419: Switch syscall(2)/__syscall(2) calls to libc calls on NetBSD.
  • add CHECK()
  • add forgotten TgKill()
Sep 28 2018, 7:41 AM · Restricted Project