krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (86 w, 1 d)

Recent Activity

Today

krytarowski added a comment to D32421: Fix segfault resulting from empty print prompt.

I cannot reproduce it locally.

Tue, Apr 25, 5:20 AM

Yesterday

krytarowski added a comment to D32271: Patch to Attach pid successfully from different dir.

I have plan to revisit corresponding files in NetBSD and switch from kvm(3) to sysctl(3). But this is lower priority than Process Plugin right now.

Thanks for the note. I wasn't aware that you had that planned, but I incorporated the improvements you made in NetBSD's Host.cpp (early returns etc.) in order to reduce diffs and facilitate shared effort on these bits at some point.

Mon, Apr 24, 5:07 PM
krytarowski added a comment to D32271: Patch to Attach pid successfully from different dir.

I have plan to revisit corresponding files in NetBSD and switch from kvm(3) to sysctl(3). But this is lower priority than Process Plugin right now.

Mon, Apr 24, 12:56 AM

Sat, Apr 22

krytarowski added a comment to D32120: Don't test setting sticky bits on files for (Free|Open)BSD.

I don't agree. It would mean that it's supposed to work on BSD4.4 and derivate systems like BSD/OS.

I think it would be useful to have a #define for modern BSDs though, as presumably DragonFly, bitrig, EdgeBSD etc. will need it set as well (although some/all may still include the #define inherited from their parent).

Sat, Apr 22, 11:51 AM
krytarowski added a comment to D32120: Don't test setting sticky bits on files for (Free|Open)BSD.
In D32120#734601, @dim wrote:

Also add NetBSD. At some point, we might want to have a global
LLVM_ON_BSD define to make these easier. :)

Sat, Apr 22, 7:59 AM
krytarowski added a comment to D32120: Don't test setting sticky bits on files for (Free|Open)BSD.

This is valid for NetBSD as well.

Sat, Apr 22, 6:59 AM

Fri, Apr 21

krytarowski updated the diff for D32149: Correct handling NetBSD core(5) files with threads.

Fix handling executable and shared library triple detection.

Fri, Apr 21, 8:17 PM · Restricted Project

Thu, Apr 20

krytarowski added inline comments to D32149: Correct handling NetBSD core(5) files with threads.
Thu, Apr 20, 5:47 AM · Restricted Project
krytarowski added inline comments to D32149: Correct handling NetBSD core(5) files with threads.
Thu, Apr 20, 4:48 AM · Restricted Project
krytarowski added a comment to D32149: Correct handling NetBSD core(5) files with threads.

A test would infinitely times more valuable then a demo script. What is the tiniest core file you can produce on NetBSD? (on linux we've gotten them down to about 20K) Then we could check that in and write a test for it...

Thu, Apr 20, 4:27 AM · Restricted Project

Wed, Apr 19

krytarowski added a comment to D32149: Correct handling NetBSD core(5) files with threads.

BSD script(1) is incompatible with the GNU one, so I prepared a quick port to Linux:

Wed, Apr 19, 5:02 PM · Restricted Project
krytarowski added inline comments to D31823: Update LLDB Host to support IPv6 over TCP.
Wed, Apr 19, 4:25 AM
krytarowski added a comment to D31823: Update LLDB Host to support IPv6 over TCP.

Fix from pkgsrc-wip to resurrect LLDB Standalone build in SVN r. 300654.

Wed, Apr 19, 4:23 AM

Tue, Apr 18

krytarowski closed D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support.
Tue, Apr 18, 6:06 AM · Restricted Project
krytarowski added inline comments to D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support.
Tue, Apr 18, 6:02 AM · Restricted Project

Mon, Apr 17

krytarowski created D32149: Correct handling NetBSD core(5) files with threads.
Mon, Apr 17, 6:43 PM · Restricted Project
krytarowski added a comment to D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM.

Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ years ago.

Mon, Apr 17, 7:01 AM

Sun, Apr 16

krytarowski abandoned D31825: Fix loading core(5) files from NetBSD 7.99.67.

I will fix the original problem differently. Thanks for help!

Sun, Apr 16, 5:30 PM · Restricted Project

Sat, Apr 15

krytarowski updated the summary of D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support.
Sat, Apr 15, 9:54 AM · Restricted Project
krytarowski updated the diff for D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support.

Add FPR support.

Sat, Apr 15, 9:32 AM · Restricted Project

Fri, Apr 14

krytarowski updated the summary of D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support.
Fri, Apr 14, 5:25 AM · Restricted Project
krytarowski created D32080: Introduce FPR and Debug Registers/NetBSD/amd64 support.
Fri, Apr 14, 5:24 AM · Restricted Project

Tue, Apr 11

krytarowski added a comment to D31969: [CMake] Support generating Config.h.

While there there are candidates like pipe2(2) in source/Host/posix/PipePosix.cpp.

Tue, Apr 11, 6:31 PM
krytarowski added inline comments to D31969: [CMake] Support generating Config.h.
Tue, Apr 11, 6:23 PM
krytarowski added a comment to D31825: Fix loading core(5) files from NetBSD 7.99.67.

I might need some guidance to address the asserts appropriately in finite time.

Tue, Apr 11, 6:12 AM · Restricted Project

Mon, Apr 10

krytarowski added a comment to D31877: Remove Plugins/Process/POSIX from include_directories.

Thank you for working on it!

Mon, Apr 10, 11:34 AM

Sat, Apr 8

krytarowski added a comment to D31825: Fix loading core(5) files from NetBSD 7.99.67.

Other BSDs work.

Sat, Apr 8, 3:54 PM · Restricted Project
krytarowski added a comment to D31825: Fix loading core(5) files from NetBSD 7.99.67.

For the reference, I uploaded FreeBSD/amd64 and OpenBSD/i386 core(5) files:

Sat, Apr 8, 3:54 PM · Restricted Project
krytarowski added a comment to D31825: Fix loading core(5) files from NetBSD 7.99.67.

Hmm still wrong.

Sat, Apr 8, 1:46 PM · Restricted Project

Fri, Apr 7

krytarowski updated the summary of D31825: Fix loading core(5) files from NetBSD 7.99.67.
Fri, Apr 7, 3:59 PM · Restricted Project
krytarowski added a comment to D31825: Fix loading core(5) files from NetBSD 7.99.67.

Example core(5) file:
http://netbsd.org/~kamil/lldb/top.core

Fri, Apr 7, 12:15 PM · Restricted Project
krytarowski updated the summary of D31825: Fix loading core(5) files from NetBSD 7.99.67.
Fri, Apr 7, 12:13 PM · Restricted Project
krytarowski created D31825: Fix loading core(5) files from NetBSD 7.99.67.
Fri, Apr 7, 12:13 PM · Restricted Project
krytarowski closed D31784: Correct environ parsing on NetBSD.
Fri, Apr 7, 9:58 AM · Restricted Project

Thu, Apr 6

krytarowski created D31784: Correct environ parsing on NetBSD.
Thu, Apr 6, 1:13 PM · Restricted Project

Thu, Mar 30

krytarowski added a comment to D31450: Battery of NetBSD support improvements.

Thanks! I noted that I introduced some bugs.. but I will fix them in future revisions. I will move on to threads now. FPR/watchpoints will be done later, on the cost on adding some code for cores and helping out with base system work.

Thu, Mar 30, 6:23 PM · Restricted Project
krytarowski closed D31450: Battery of NetBSD support improvements.
Thu, Mar 30, 1:37 PM · Restricted Project
krytarowski added a comment to D31450: Battery of NetBSD support improvements.

Thanks!

Thu, Mar 30, 12:47 PM · Restricted Project
krytarowski updated the diff for D31450: Battery of NetBSD support improvements.

Apply changes from review. No visible regressions in "check-lldb".

Thu, Mar 30, 12:32 PM · Restricted Project
krytarowski accepted D27143: Fix detection of backtrace() availability on FreeBSD.

Build for me:

Thu, Mar 30, 10:52 AM
krytarowski added a comment to D27143: Fix detection of backtrace() availability on FreeBSD.

Thanks, I'm going to test it.

Thu, Mar 30, 9:17 AM
krytarowski added a comment to D27143: Fix detection of backtrace() availability on FreeBSD.

https://github.com/Kitware/CMake/blob/master/Modules/FindBacktrace.cmake

Thu, Mar 30, 8:05 AM
krytarowski requested changes to D27143: Fix detection of backtrace() availability on FreeBSD.

Right, it's no LLDB....

Thu, Mar 30, 8:04 AM

Wed, Mar 29

krytarowski added inline comments to D31450: Battery of NetBSD support improvements.
Wed, Mar 29, 7:02 PM · Restricted Project
krytarowski closed D31461: Add NetBSD path for Debugging Information in Separate Files.
Wed, Mar 29, 1:04 PM · Restricted Project
krytarowski added a comment to D27143: Fix detection of backtrace() availability on FreeBSD.

Does NetBSD need it too?

Wed, Mar 29, 7:55 AM
krytarowski added inline comments to D31450: Battery of NetBSD support improvements.
Wed, Mar 29, 7:42 AM · Restricted Project
krytarowski added a comment to D31450: Battery of NetBSD support improvements.

I think I will start the threading segment with proper handling of core(5) files. It looks like the simplest start point.

Wed, Mar 29, 7:27 AM · Restricted Project
krytarowski added inline comments to D31450: Battery of NetBSD support improvements.
Wed, Mar 29, 7:24 AM · Restricted Project
krytarowski created D31461: Add NetBSD path for Debugging Information in Separate Files.
Wed, Mar 29, 7:09 AM · Restricted Project

Tue, Mar 28

krytarowski added a reviewer for D31450: Battery of NetBSD support improvements: jingham.

Adding Jim as a reviewer, since Pavel is mostly out of the keyboard for longer time.

Tue, Mar 28, 9:02 PM · Restricted Project
krytarowski added a comment to D31450: Battery of NetBSD support improvements.

Current core(5) file format is a subject to change (AUXV can be shortened)... I'm working on the final nits for the NetBSD-8 interfaces.

Tue, Mar 28, 8:27 PM · Restricted Project
krytarowski created D31450: Battery of NetBSD support improvements.
Tue, Mar 28, 8:22 PM · Restricted Project
krytarowski added a comment to D31374: Add support for tracing hello-world application on NetBSD.

This code is used as a base for further improvements, I'm going to commit it... debugging hello world still works.

Tue, Mar 28, 3:20 PM · Restricted Project
krytarowski updated the diff for D31374: Add support for tracing hello-world application on NetBSD.

Apply changes from review.

Tue, Mar 28, 3:16 PM · Restricted Project
krytarowski added a comment to D31374: Add support for tracing hello-world application on NetBSD.

I wasn't able to go into this too deeply, but here is what I have after a quick pass. I won't be able to review this thoroughly that soon, but I think it can go in after you take my comments into consideration.

Tue, Mar 28, 11:19 AM · Restricted Project

Sun, Mar 26

krytarowski added a comment to D31374: Add support for tracing hello-world application on NetBSD.

Right now I'm not sure how to optimize reading GPR. If possible I would reschedule it for later.

Sun, Mar 26, 9:28 AM · Restricted Project
krytarowski added inline comments to D31375: Add docs for libunwind.
Sun, Mar 26, 9:05 AM
krytarowski added a comment to D31374: Add support for tracing hello-world application on NetBSD.

On OpenBSD the register context used in core dumps uses the same layout as ptrace(2). That's not the case on all OSes, but I believe that is the case for NetBSD as well. Would it be possible to re-use the register context data structures defined in the source/Plugins/Process/Utility/ directory?

Sun, Mar 26, 9:02 AM · Restricted Project
krytarowski closed D31131: [LLDB] OpenBSD support.
Sun, Mar 26, 8:47 AM · Restricted Project
krytarowski added a comment to D31131: [LLDB] OpenBSD support.

Can somebody commit this diff for me?

Sun, Mar 26, 8:15 AM · Restricted Project
krytarowski created D31374: Add support for tracing hello-world application on NetBSD.
Sun, Mar 26, 7:23 AM · Restricted Project

Mar 24 2017

krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mar 24 2017, 7:54 AM · Restricted Project
krytarowski accepted D31131: [LLDB] OpenBSD support.

In general it looks good.

Mar 24 2017, 5:14 AM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mar 24 2017, 4:07 AM · Restricted Project

Mar 22 2017

krytarowski closed D31231: Reuse appropriate Launch and Attach on NetBSD.
Mar 22 2017, 8:10 AM · Restricted Project
krytarowski added a comment to D31231: Reuse appropriate Launch and Attach on NetBSD.

With x86_64 general purpose registers going before that.

Mar 22 2017, 4:06 AM · Restricted Project
krytarowski added a comment to D31231: Reuse appropriate Launch and Attach on NetBSD.

Next, I will work on a code to extend the NetBSD Process Plugin from a stub to a version that actually works.

Mar 22 2017, 3:59 AM · Restricted Project

Mar 21 2017

krytarowski created D31231: Reuse appropriate Launch and Attach on NetBSD.
Mar 21 2017, 7:13 PM · Restricted Project
krytarowski added a comment to D31199: Add "(compatible with the GNU linker)" to the -version output..

looks reasonable

Mar 21 2017, 11:32 AM
krytarowski closed D31192: Create instance of DynamicLoaderPOSIXDYLD on NetBSD.
Mar 21 2017, 10:51 AM · Restricted Project
krytarowski added a comment to D31192: Create instance of DynamicLoaderPOSIXDYLD on NetBSD.

This approach is easier for my to understand each change and make sure that it's actually needed and correct (or looking like a proper solution).
There are 2 similar changes left I don't fully understand and code interfering with the OpenBSD platform addition that I will hold on a while.

Mar 21 2017, 10:49 AM · Restricted Project
krytarowski closed D31138: Add stub for PluginProcessNetBSD.
Mar 21 2017, 10:42 AM · Restricted Project
krytarowski closed D31146: Enable AUXV and QPassSignals in gdb-remote for NetBSD.
Mar 21 2017, 10:40 AM · Restricted Project
krytarowski closed D31191: Enable ProcessPOSIXLog on NetBSD.
Mar 21 2017, 10:39 AM · Restricted Project
krytarowski closed D31132: Add NetBSD case in Entry::Type::ThreadID.
Mar 21 2017, 10:37 AM · Restricted Project
krytarowski created D31192: Create instance of DynamicLoaderPOSIXDYLD on NetBSD.
Mar 21 2017, 9:40 AM · Restricted Project
krytarowski created D31191: Enable ProcessPOSIXLog on NetBSD.
Mar 21 2017, 9:16 AM · Restricted Project
krytarowski updated the diff for D31138: Add stub for PluginProcessNetBSD.

Style fix.

Mar 21 2017, 8:31 AM · Restricted Project
krytarowski updated the diff for D31138: Add stub for PluginProcessNetBSD.

Cut down the unused functions from the Native Process NetBSD Plugin.

Mar 21 2017, 8:28 AM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mar 21 2017, 7:16 AM · Restricted Project
krytarowski added a comment to D31146: Enable AUXV and QPassSignals in gdb-remote for NetBSD.

I'm still evaluating whether to implement on the kernel side PT_SET_SIGPASS/PT_GET_SIGPASS. Some software like floating point can use it heavily.

Mar 21 2017, 5:18 AM · Restricted Project
krytarowski added a comment to D31138: Add stub for PluginProcessNetBSD.

I like the idea of adding boilerplate first, so that we can than better focus on the important stuff later. However, I think you've have gone a bit too far with it -- you introduce a lot of functions I am pretty sure will not be necessary for your case, or that should be handled differently (software single stepping stuff, handling of linux thread stopping, ...).

Could we trim this down to just the functions that are necessary to get this building (basically just virtual overrides -- no private functions or members)? Those can be always added along with the patch that implements them, and then we will be in a better position to review it.

Mar 21 2017, 5:16 AM · Restricted Project

Mar 20 2017

krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mar 20 2017, 4:03 PM · Restricted Project
krytarowski updated the summary of D31132: Add NetBSD case in Entry::Type::ThreadID.
Mar 20 2017, 11:58 AM · Restricted Project
krytarowski created D31146: Enable AUXV and QPassSignals in gdb-remote for NetBSD.
Mar 20 2017, 11:54 AM · Restricted Project
krytarowski added a comment to D31138: Add stub for PluginProcessNetBSD.

I have got a few local changes that conflict with D31131, this is why I will hold on them unless @kettenis does not intend to land his patch in the coming days.

Mar 20 2017, 10:37 AM · Restricted Project
krytarowski created D31138: Add stub for PluginProcessNetBSD.
Mar 20 2017, 10:21 AM · Restricted Project
krytarowski created D31132: Add NetBSD case in Entry::Type::ThreadID.
Mar 20 2017, 8:05 AM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mar 20 2017, 4:47 AM · Restricted Project

Mar 19 2017

krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mar 19 2017, 8:03 PM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mar 19 2017, 8:00 PM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mar 19 2017, 7:11 PM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mar 19 2017, 6:54 PM · Restricted Project
krytarowski added reviewers for D31131: [LLDB] OpenBSD support: labath, joerg, krytarowski.
Mar 19 2017, 6:46 PM · Restricted Project
krytarowski added a comment to D31131: [LLDB] OpenBSD support.

I got a substantial portion of Process Plugin to work on NetBSD, to coordinate the work feel free to join IRC #lldb at OFTC -- e.g. do not waste time on FreeBSD Process Plugin.

Mar 19 2017, 6:45 PM · Restricted Project

Mar 16 2017

krytarowski added inline comments to D30981: Remove HostThreadLinux/Free/NetBSD.
Mar 16 2017, 2:57 PM
krytarowski added a comment to D31031: Move GetAuxvData from Host to relevant process plugins.

Thank you for this.

Mar 16 2017, 11:35 AM
krytarowski accepted D30981: Remove HostThreadLinux/Free/NetBSD.

Thank you for your explanation. I will use approach similar to FreeBSD on NetBSD.

Mar 16 2017, 11:31 AM

Mar 15 2017

krytarowski added inline comments to D30981: Remove HostThreadLinux/Free/NetBSD.
Mar 15 2017, 11:41 AM