Page MenuHomePhabricator

krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (281 w, 1 d)

Recent Activity

Today

krytarowski added a comment to D94569: [libcxx] Wipe some more macros that do not belong in C++ forwarding headers.

These symbols are usually macros + libc calls.

Mon, Jan 18, 11:08 AM · Restricted Project

Wed, Jan 13

krytarowski added a comment to D94569: [libcxx] Wipe some more macros that do not belong in C++ forwarding headers.

NetBSD uses macros too, but undefines them inside the header for __cplusplus. The proposed patch looks fine. This is a common source of portability issues, the stdio macros.

Wed, Jan 13, 9:14 AM · Restricted Project

Tue, Jan 12

krytarowski accepted D94491: [llvm] [cmake] Remove obsolete /usr/local hack for *BSD.
Tue, Jan 12, 9:20 AM · Restricted Project

Mon, Dec 28

krytarowski added inline comments to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.
Mon, Dec 28, 3:42 PM · Restricted Project, Restricted Project
krytarowski added a comment to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.

Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.

Hurd and GNU/kFreeBSD are not supported. Even if they do, many defined(__GLIBC__) is inside a #if SANITIZER_LINUX, so they will work automatically.

Mon, Dec 28, 11:12 AM · Restricted Project, Restricted Project
krytarowski added a comment to D93848: [sanitizer] Define SANITIZER_GLIBC to refine SANITIZER_LINUX feature detection and support musl.

Well... technically speaking GLIBC is at least: GNU/Linux, GNU/FreeBSD and HURD.

Mon, Dec 28, 9:16 AM · Restricted Project, Restricted Project

Dec 15 2020

krytarowski accepted D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes.
Dec 15 2020, 9:57 AM · Restricted Project

Dec 10 2020

krytarowski added a comment to D85005: [libunwind] Support DW_CFA_remember/restore_state without heap allocation..

Please include stdlib.h for alloca, unless you target SunOS. alloca.h is unavailable on NetBSD.

Dec 10 2020, 4:29 AM · Restricted Project, Restricted Project

Dec 4 2020

krytarowski added a comment to D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching.

No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though?

Dec 4 2020, 12:51 PM · Restricted Project

Dec 1 2020

krytarowski added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

Ideally we should iterate over the startup process and investigate the state of the r_debug structure. Once it gets initialized, set the software brakpoint to r_brk and keep track of the dynamic loading and unloading of libraries. The tricky part is to detect the right moment to plug into r_brk, early enough in the startup process before calling constructors, loading the libraries etc and late enough to become initialized.

Dec 1 2020, 6:15 AM · Restricted Project
krytarowski added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

One thing that FreeBSD should do, is to upgrade to the protocol version 1 (stored in r_version), like Linux, NetBSD and OpenBSD.

It looks like Linux has always used r_version=1 (since 1995).

AFAICT we can just add r_ldbase and set version to 1.
See https://reviews.freebsd.org/D27429

Dec 1 2020, 3:27 AM · Restricted Project

Nov 30 2020

krytarowski added a comment to D92187: [lldb] [POSIX-DYLD] Add libraries from initial rendezvous brkpt hit.

I'm curious how gdb handles this, and asked @bsdjhb if he knows off hand.

Is there a brief description of how this works on Linux and/or NetBSD?

Nov 30 2020, 7:53 AM · Restricted Project

Nov 23 2020

krytarowski added a comment to D91847: [lldb] [debugserver] Add stN aliases for stmmN for compatibility.

I would mark stmmX as an alias to stX and keep stX as the default for all platforms. stmmX could be an alias for everybody for legacy reasons.

Nov 23 2020, 1:48 AM · Restricted Project
krytarowski accepted D91934: [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo.
Nov 23 2020, 12:16 AM · Restricted Project

Nov 19 2020

krytarowski resigned from D89652: [Sanitizers] DragonFlyBSD ground work to support sanitizers.
Nov 19 2020, 3:52 PM · Restricted Project
krytarowski accepted D91810: [lldb] Prevent 'process connect' from using local-only plugins.
Nov 19 2020, 3:29 PM · Restricted Project

Nov 11 2020

krytarowski accepted D91254: [lldb] [Process/Utility] Fix DR offsets for FreeBSD.
Nov 11 2020, 6:10 AM · Restricted Project

Nov 10 2020

krytarowski accepted D91167: [lldb] [Process/NetBSD] Copy the recent improvements from FreeBSD.
Nov 10 2020, 8:39 AM · Restricted Project

Nov 9 2020

krytarowski accepted D91090: [lldb] [Process/NetBSD] Correct DS/ES/FS/GS register sizes.
Nov 9 2020, 1:00 PM · Restricted Project

Nov 8 2020

krytarowski accepted D91026: [lldb] [Host/freebsd] Set Arg0 for 'platform process list -v'.
Nov 8 2020, 5:24 AM · Restricted Project

Nov 7 2020

krytarowski accepted D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP.
Nov 7 2020, 3:41 PM · Restricted Project
krytarowski added a comment to D91007: [lldb] [Process/FreeBSDRemote] Fix handling user-generated SIGTRAP.

I propose to filter all user induced signals at once and check & 0x10000 and SI_USER.

Nov 7 2020, 1:54 PM · Restricted Project

Nov 6 2020

krytarowski accepted D90938: [lldb] [Process/FreeBSDRemote] Handle exec() from inferior.

I wonder why NetBSD fails having the same event handling.

Nov 6 2020, 7:14 AM · Restricted Project
krytarowski added a comment to D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status.

Does the new plugin work with processes that are created with pdfork? The last time I tried this, it caused the old plugin to lock up the debugger entirely. Please can you ensure that there are tests that cover pdfork and cap_enter in the child? These are currently quite badly broken.

Nov 6 2020, 3:47 AM · Restricted Project

Nov 5 2020

krytarowski accepted D90863: [lldb] [Process/FreeBSDRemote] Remove thread name caching.
Nov 5 2020, 11:43 AM · Restricted Project
krytarowski accepted D90862: [lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD.
Nov 5 2020, 11:42 AM · Restricted Project

Nov 2 2020

krytarowski added a comment to D79713: [compiler-rt] [builtins] Port atomic.c to GCC.

It's relevant but I encountered issues to pass the review..

Nov 2 2020, 3:22 PM · Restricted Project
krytarowski accepted D90650: [lldb] [Plugins/FreeBSDRemote] Disable GetMemoryRegionInfo().
Nov 2 2020, 3:19 PM · Restricted Project
krytarowski accepted D90620: [lldb] [Process/FreeBSDRemote] Remove GetSharedLibraryInfoAddress override.
Nov 2 2020, 9:01 AM · Restricted Project

Oct 31 2020

krytarowski resigned from D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.
Oct 31 2020, 8:12 AM · Restricted Project
krytarowski accepted D90525: [lldb] [Process/FreeBSDRemote] Fix attaching via lldb-server.
Oct 31 2020, 8:12 AM · Restricted Project
krytarowski accepted D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName().
Oct 31 2020, 5:52 AM · Restricted Project

Oct 28 2020

krytarowski added inline comments to D90298: [lldb] [Process/FreeBSDRemote] Implement thread GetName().
Oct 28 2020, 5:25 AM · Restricted Project

Oct 26 2020

krytarowski accepted D90139: libcxx: Fix a few warnings.

Looks OK from the NetBSD point of view.

Oct 26 2020, 5:35 PM · Restricted Project

Oct 25 2020

krytarowski accepted D90128: [lldb] [Process/FreeBSDRemote] Fix #include for i386 compat.
Oct 25 2020, 6:45 PM · Restricted Project

Oct 24 2020

krytarowski accepted D90105: [lldb] [Process/NetBSD] Set xs_xstate_bv correctly when setting regs.
Oct 24 2020, 10:57 PM · Restricted Project

Oct 23 2020

krytarowski accepted D90034: [lldb] [Process/NetBSD] Use XStateRegSet for all FPU registers.
Oct 23 2020, 11:08 AM · Restricted Project

Oct 21 2020

krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Oct 21 2020, 10:47 AM
krytarowski added inline comments to D89874: [lldb] Split out NetBSD/x86 watchpoint impl for unification.
Oct 21 2020, 8:56 AM · Restricted Project
krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Oct 21 2020, 8:20 AM
krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Oct 21 2020, 6:44 AM

Oct 20 2020

krytarowski added inline comments to D89556: Avoid use of gets() in DOE-ProxyApps-C/Pathfinder.
Oct 20 2020, 2:57 PM
krytarowski requested changes to D89652: [Sanitizers] DragonFlyBSD ground work to support sanitizers.

Host a LLVM buildbot for DragonFly first, otherwise it will be even not ever build-tested.

Oct 20 2020, 5:20 AM · Restricted Project

Oct 19 2020

krytarowski added inline comments to D89640: [Sanitizers] Remove OpenBSD support.
Oct 19 2020, 1:24 PM · Restricted Project

Oct 18 2020

krytarowski added inline comments to D89640: [Sanitizers] Remove OpenBSD support.
Oct 18 2020, 6:53 AM · Restricted Project
krytarowski accepted D89640: [Sanitizers] Remove OpenBSD support.
Oct 18 2020, 6:46 AM · Restricted Project
krytarowski added a comment to D89640: [Sanitizers] Remove OpenBSD support.

Please leave builtins intact. ubsan might work, but removing it too is fine.

Oct 18 2020, 6:23 AM · Restricted Project

Oct 17 2020

krytarowski added a comment to D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.

Please, First remove unused + unusable code for already introduced OS. At most cutting it to ubsan.

Oct 17 2020, 1:25 PM · Restricted Project
krytarowski requested changes to D89631: [Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD.

This contains unrelated code to ubsan/dragonflybsd. While there can you remove unsupported code for other OSs you introduced? That was never operational?

Oct 17 2020, 1:19 PM · Restricted Project

Oct 15 2020

krytarowski accepted D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support.
Oct 15 2020, 4:57 AM · Restricted Project

Oct 14 2020

krytarowski accepted D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.
Oct 14 2020, 6:47 AM · Restricted Project

Oct 13 2020

krytarowski committed rGd4b040473291: [compiler-rt] [lldb] Mark syscall_acquire and syscall_release as USED (authored by krytarowski).
[compiler-rt] [lldb] Mark syscall_acquire and syscall_release as USED
Oct 13 2020, 6:57 PM
krytarowski added inline comments to D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE.
Oct 13 2020, 11:08 AM · Restricted Project

Oct 12 2020

krytarowski added a comment to D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL.

FWIW, PTHREAD_KILL is strongly discouraged on linux. But if the situation is different on freebsd, then fine.

Oct 12 2020, 3:33 AM · Restricted Project

Oct 10 2020

krytarowski added a reviewer for D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE: bsdjhb.

+ @bsdjhb John, could you have a look?

Oct 10 2020, 12:27 PM · Restricted Project
krytarowski resigned from D63473: Support -fclang-abi-compat=8.0 to keep old ABI behavior.
Oct 10 2020, 3:17 AM · Restricted Project
krytarowski accepted D89181: [lldb] [Process/FreeBSD] Mark methods override in RegisterContext*.
Oct 10 2020, 2:40 AM · Restricted Project
krytarowski accepted D89182: [lldb] [Process/FreeBSDRemote] Kill process via PT_KILL.
Oct 10 2020, 2:40 AM · Restricted Project

Oct 6 2020

krytarowski accepted D88796: [lldb] Initial version of FreeBSD remote process plugin.
Oct 6 2020, 1:07 PM · Restricted Project

Oct 5 2020

krytarowski added inline comments to D88796: [lldb] Initial version of FreeBSD remote process plugin.
Oct 5 2020, 7:47 AM · Restricted Project

Oct 4 2020

krytarowski added a comment to D88795: [lldb] [test/Register] Attempt to fix x86-fp-read.test on Darwin.

Can we rename the register names in the darwin plugin?

Oct 4 2020, 2:54 PM · Restricted Project
krytarowski added inline comments to D88796: [lldb] Initial version of FreeBSD remote process plugin.
Oct 4 2020, 9:53 AM · Restricted Project
krytarowski added inline comments to D88796: [lldb] Initial version of FreeBSD remote process plugin.
Oct 4 2020, 7:09 AM · Restricted Project

Oct 2 2020

krytarowski accepted D88682: [lldb] [Process/NetBSD] Fix crash on unsupported i386 regs.
Oct 2 2020, 11:15 AM · Restricted Project
krytarowski accepted D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers.
Oct 2 2020, 10:50 AM · Restricted Project
krytarowski added inline comments to D88681: [lldb] [Process/NetBSD] Fix reading FIP/FDP registers.
Oct 2 2020, 10:31 AM · Restricted Project
krytarowski added inline comments to D88682: [lldb] [Process/NetBSD] Fix crash on unsupported i386 regs.
Oct 2 2020, 10:30 AM · Restricted Project
krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

Confirmed to work.

Oct 2 2020, 8:24 AM · Restricted Project, Restricted Project
krytarowski accepted D76665: [asan] Stop instrumenting user-defined ELF sections.
Oct 2 2020, 8:23 AM · Restricted Project, Restricted Project
krytarowski committed rG2a9ce60de98e: [compiler-rt] [netbsd] Improve the portability of ThreadSelfTlsTcb (authored by krytarowski).
[compiler-rt] [netbsd] Improve the portability of ThreadSelfTlsTcb
Oct 2 2020, 7:33 AM

Sep 17 2020

krytarowski committed rG7b2dd58eb09d: [compiler-rt] [scudo] Fix typo in function attribute (authored by krytarowski).
[compiler-rt] [scudo] Fix typo in function attribute
Sep 17 2020, 7:59 AM
krytarowski committed rGe7de267910e9: [compiler-rt] [hwasan] Replace INLINE with inline (authored by krytarowski).
[compiler-rt] [hwasan] Replace INLINE with inline
Sep 17 2020, 7:47 AM
krytarowski committed rG72c5feeed8d8: [compiler-rt] [netbsd] Include <sys/dkbad.h> (authored by krytarowski).
[compiler-rt] [netbsd] Include <sys/dkbad.h>
Sep 17 2020, 7:36 AM
krytarowski committed rG9339f68f21fa: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT (authored by krytarowski).
[compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT
Sep 17 2020, 7:29 AM
krytarowski closed D87602: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT.
Sep 17 2020, 7:28 AM · Restricted Project
krytarowski committed rG85e578f53ad1: [compiler-rt] Replace INLINE with inline (authored by krytarowski).
[compiler-rt] Replace INLINE with inline
Sep 17 2020, 7:24 AM
krytarowski closed D87562: [compiler-rt] Replace INLINE with inline.
Sep 17 2020, 7:24 AM · Restricted Project
krytarowski committed rG69516ddd028e: [compiler-rt] Avoid pulling libatomic to sanitizer tests (authored by krytarowski).
[compiler-rt] Avoid pulling libatomic to sanitizer tests
Sep 17 2020, 7:04 AM
krytarowski closed D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.
Sep 17 2020, 7:04 AM · Restricted Project

Sep 16 2020

krytarowski added a comment to D87562: [compiler-rt] Replace INLINE with inline.

Can you please clang format it as well

Sep 16 2020, 2:25 PM · Restricted Project

Sep 14 2020

krytarowski added a comment to D87562: [compiler-rt] Replace INLINE with inline.

I prefer we use just "inline"

Sep 14 2020, 8:54 AM · Restricted Project
krytarowski updated the diff for D87562: [compiler-rt] Replace INLINE with inline.
Sep 14 2020, 4:51 AM · Restricted Project
krytarowski requested review of D87602: [compiler-rt] [tsan] [netbsd] Catch unsupported LONG_JMP_SP_ENV_SLOT.
Sep 14 2020, 1:44 AM · Restricted Project
krytarowski committed rG0008fb343704: [compiler-rt] [netbsd] Use internal_ptrace() instead of ptrace() (authored by krytarowski).
[compiler-rt] [netbsd] Use internal_ptrace() instead of ptrace()
Sep 14 2020, 1:12 AM

Sep 12 2020

krytarowski added a comment to D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.

std::atomic_is_lock_free or an reimplementation of it (without pulling C++ runtime), testing a type and asserting that in runtime or build time that it is lockfree.

Sep 12 2020, 4:28 PM · Restricted Project
krytarowski added a comment to D87562: [compiler-rt] Replace INLINE with inline.

I've verified that this symbol has unlikely any clashes with 3rd party software now. https://grep.app/search?q=ATTR_INLINE&case=true&words=true

Sep 12 2020, 2:08 PM · Restricted Project
krytarowski requested review of D87568: [compiler-rt] Avoid pulling libatomic to sanitizer tests.
Sep 12 2020, 1:47 PM · Restricted Project
krytarowski requested review of D87562: [compiler-rt] Replace INLINE with inline.
Sep 12 2020, 10:02 AM · Restricted Project

Sep 10 2020

krytarowski committed rG00460ae520e2: [compiler-rt] [netbsd] Regenerate syscall hooks (authored by krytarowski).
[compiler-rt] [netbsd] Regenerate syscall hooks
Sep 10 2020, 11:17 AM
krytarowski committed rGbba736e5036f: [compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk (authored by krytarowski).
[compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk
Sep 10 2020, 11:17 AM
krytarowski committed rGb85c085c846c: [compiler-rt] [netbsd] Improve code formatting (authored by krytarowski).
[compiler-rt] [netbsd] Improve code formatting
Sep 10 2020, 10:39 AM
krytarowski committed rGcb8cb28ed90a: [compiler-rt] [netbsd] Add fallback definitions for MKISCSI=no (authored by krytarowski).
[compiler-rt] [netbsd] Add fallback definitions for MKISCSI=no
Sep 10 2020, 10:39 AM
krytarowski committed rG52f42720b26a: [lldb] [netbsd] Avoid comparison of signed and unsigned integers (authored by krytarowski).
[lldb] [netbsd] Avoid comparison of signed and unsigned integers
Sep 10 2020, 6:49 AM
krytarowski committed rGf51e55e09eef: [compiler-rt] [netbsd] Reintroduce __sanitizer_protoent (authored by krytarowski).
[compiler-rt] [netbsd] Reintroduce __sanitizer_protoent
Sep 10 2020, 2:47 AM
krytarowski added inline comments to D82424: sanitizers: Add interceptors for getproto{ent,byname,bynumber}_r.
Sep 10 2020, 2:43 AM · Restricted Project

Sep 9 2020

krytarowski added a comment to D87120: [MemProf] Memory profiling runtime support.

These "linux" files will be ported to BSD so we might pick better names now.

Sep 9 2020, 9:20 AM · Restricted Project

Sep 8 2020

krytarowski added a comment to D85820: Use find_library for ncurses.

Please note that ncurses is not the only supported curses library. NetBSD uses its original BSD curses for LLVM projects.

Sep 8 2020, 3:35 AM · Restricted Project, Restricted Project, Restricted Project

Sep 5 2020

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.
In D76665#2140245, @kcc wrote:

Will adding attribute((no_sanitize("address"))) to your global solve the problem you are trying to solve?
(sorry for being too terse last time)

It does not work (last time I checked).

Does not work how?

Also GCC does the same thing of not instrumenting user defined sections.

Sep 5 2020, 12:57 PM · Restricted Project, Restricted Project

Aug 25 2020

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

Ping?

Aug 25 2020, 12:25 PM · Restricted Project, Restricted Project

Aug 6 2020

krytarowski added a comment to D76665: [asan] Stop instrumenting user-defined ELF sections.

Ping?

Aug 6 2020, 4:38 AM · Restricted Project, Restricted Project