krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.
User Since
Aug 30 2015, 11:51 AM (77 w, 6 d)

Recent Activity

Fri, Feb 24

krytarowski retitled D30374: Support NetBSD Thread ID in lldb-server tests from Support NetBSD Thread ID in lldb-server to Support NetBSD Thread ID in lldb-server tests.
Fri, Feb 24, 11:22 PM · Restricted Project
krytarowski created D30374: Support NetBSD Thread ID in lldb-server tests.
Fri, Feb 24, 11:11 PM · Restricted Project

Thu, Feb 23

krytarowski closed D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
Thu, Feb 23, 6:05 PM · Restricted Project
krytarowski closed D30288: Switch NetBSD from paccept(2) to accept4(2).
Thu, Feb 23, 6:03 PM · Restricted Project
krytarowski updated the diff for D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
  • remove unused function GetSharedRegisterInfoVector
  • fix DR_OFFSET
Thu, Feb 23, 4:47 PM · Restricted Project
krytarowski added inline comments to D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
Thu, Feb 23, 2:00 PM · Restricted Project
krytarowski created D30288: Switch NetBSD from paccept(2) to accept4(2).
Thu, Feb 23, 1:26 AM · Restricted Project
krytarowski retitled D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64 from Introduce support for Debug Registers RegisterContextNetBSD_x86_64 to Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
Thu, Feb 23, 12:55 AM · Restricted Project
krytarowski created D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
Thu, Feb 23, 12:38 AM · Restricted Project

Wed, Feb 22

krytarowski accepted D30250: Switch "posix" to the new log channel registration mechanism.

I had locally code registering NetBSD specific log channel and this patch is removing this needless code. Thank you for this work!

Wed, Feb 22, 12:03 PM
krytarowski added inline comments to D30234: Reformat inferior's main.cpp in lldb-server test.
Wed, Feb 22, 1:44 AM · Restricted Project

Mon, Feb 20

krytarowski added a comment to D27126: Merge Linux and FreeBSD arm register contexts.

This diff looks good and appreciated for other posix-like systems.

Mon, Feb 20, 9:17 PM

Thu, Feb 16

krytarowski added a comment to D30010: Improve the robustness of mmap.

It builds now. (NetBSD 7.99.59 amd64)

Thu, Feb 16, 4:36 PM
krytarowski added a comment to D30010: Improve the robustness of mmap.
In file included from /tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Path.cpp:1174:0:
/tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Unix/Path.inc: In function 'std::error_code llvm::sys::fs::is_local(int, bool&)':
/tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Unix/Path.inc:376:35: error: too many arguments to function 'bool llvm::sys::fs::is_local_impl(statvfs&)'
   return is_local_impl(Vfs, Result);
                                   ^
/tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Unix/Path.inc:346:13: note: declared here
 static bool is_local_impl(struct STATVFS &Vfs) {
             ^
/tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Unix/Path.inc:376:23: error: could not convert 'llvm::sys::fs::is_local_impl(Vfs)' from 'bool' to 'std::error_code'
   return is_local_impl(Vfs, Result);
                       ^
[ 26%] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/SearchForAddressOfSpecialSymbol.cpp.o
[ 26%] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Signals.cpp.o
--- lib/Support/CMakeFiles/LLVMSupport.dir/Path.cpp.o ---
*** [lib/Support/CMakeFiles/LLVMSupport.dir/Path.cpp.o] Error code 1
Thu, Feb 16, 4:16 PM
krytarowski added inline comments to D30010: Improve the robustness of mmap.
Thu, Feb 16, 3:58 PM
krytarowski added inline comments to D30010: Improve the robustness of mmap.
Thu, Feb 16, 3:45 PM

Mon, Feb 13

krytarowski added a comment to D29909: Break some more dependencies in lldbUtility.

git log --follow seems to understand. Is that sufficient to guarantee that it will be retained on the SVN side?

Mon, Feb 13, 3:12 PM

Tue, Feb 7

krytarowski accepted D29667: Synchronize PlatformFreeBSD with Linux.
Tue, Feb 7, 11:11 AM

Mon, Feb 6

krytarowski closed D29288: Switch std::call_once to llvm::call_once.
Mon, Feb 6, 10:06 AM · Restricted Project
krytarowski added inline comments to D29288: Switch std::call_once to llvm::call_once.
Mon, Feb 6, 9:02 AM · Restricted Project

Sun, Feb 5

krytarowski closed D29266: Synchronize PlatformNetBSD with Linux.
Sun, Feb 5, 1:43 PM · Restricted Project
krytarowski closed D29566: Revamp llvm::once_flag to be closer to std::once_flag.
Sun, Feb 5, 1:24 PM
krytarowski updated the diff for D29566: Revamp llvm::once_flag to be closer to std::once_flag.

Document autoinitialization purpose of llvm::once_flag.

Sun, Feb 5, 9:57 AM
krytarowski updated the diff for D29566: Revamp llvm::once_flag to be closer to std::once_flag.

Turn once_flag into struct.

Sun, Feb 5, 9:44 AM
krytarowski updated the diff for D29288: Switch std::call_once to llvm::call_once.

Revamp to new llvm::once_flag

Sun, Feb 5, 9:22 AM · Restricted Project
krytarowski retitled D29566: Revamp llvm::once_flag to be closer to std::once_flag from Revamp the llvm::once_flag to be closer to std::once_flag to Revamp llvm::once_flag to be closer to std::once_flag.
Sun, Feb 5, 8:54 AM
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

https://reviews.llvm.org/D29566 I filed a patch in LLVM.

Sun, Feb 5, 8:53 AM · Restricted Project
krytarowski created D29566: Revamp llvm::once_flag to be closer to std::once_flag.
Sun, Feb 5, 8:52 AM
krytarowski abandoned D29552: Make llvm::call_once more convenient to reuse out of LLVM.

I'm going to propose a reworked interface. Closer in interaction to std::call_once.

Sun, Feb 5, 7:45 AM

Sat, Feb 4

krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

Once someone could explain to me why SymbolFileDWARF::GetCachedSectionData cannot be switched mechanically to llvm::call_once, I would like to propose this revamped interface to llvm.

Sat, Feb 4, 7:54 PM · Restricted Project
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

Test results for the above patch for LLVM and LLDB with "mechanical" switch to llvm::call_once.

Sat, Feb 4, 7:42 PM · Restricted Project
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

I've tried to build the LLDB code with mechanically * replaced std::call_once -> llvm::call_once and std::once_flag -> llvm::once_flag:

Sat, Feb 4, 7:38 PM · Restricted Project
krytarowski added inline comments to D29288: Switch std::call_once to llvm::call_once.
Sat, Feb 4, 6:47 PM · Restricted Project
krytarowski added a comment to D29266: Synchronize PlatformNetBSD with Linux.

OK to land it? FreeBSD can reuse almost exact the same code. I'm not sure if it's compatible with their Process Plugin.

Sat, Feb 4, 6:20 PM · Restricted Project
krytarowski updated the diff for D29266: Synchronize PlatformNetBSD with Linux.

Catch up after r294114 - Clean up PlatformLinux code

Sat, Feb 4, 6:14 PM · Restricted Project
krytarowski added a comment to D29266: Synchronize PlatformNetBSD with Linux.

I'm syncing the code to get the changes from SVN revision 294114 "Clean up PlatformLinux code"

Sat, Feb 4, 5:50 PM · Restricted Project
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

Related https://reviews.llvm.org/D29552

Sat, Feb 4, 5:00 PM · Restricted Project
krytarowski created D29552: Make llvm::call_once more convenient to reuse out of LLVM.
Sat, Feb 4, 3:39 PM
krytarowski updated the diff for D29288: Switch std::call_once to llvm::call_once.

Typo.

Sat, Feb 4, 3:23 PM · Restricted Project
krytarowski updated the diff for D29288: Switch std::call_once to llvm::call_once.

Revamp patch after recent changes in LLVM.

Sat, Feb 4, 2:17 PM · Restricted Project
krytarowski updated the diff for D29266: Synchronize PlatformNetBSD with Linux.

Sync this patch with SVN 294071.

Sat, Feb 4, 1:05 PM · Restricted Project

Fri, Feb 3

krytarowski closed D29405: Install six.py conditionally.
Fri, Feb 3, 4:31 PM · Restricted Project
krytarowski updated the diff for D29405: Install six.py conditionally.

Pass option to --useSystemSix to finishSwigWrapperClasses.py

Fri, Feb 3, 12:13 PM · Restricted Project
krytarowski accepted D29496: Push down more common code into PlatformPOSIX.

Thank you for this patch.

Fri, Feb 3, 9:17 AM

Thu, Feb 2

krytarowski added a comment to D29266: Synchronize PlatformNetBSD with Linux.

I need to finish three patches:

  • llvm::call_once,
  • auxv reading,
  • six.py conflict removal

and I will join here.

Thu, Feb 2, 4:57 PM · Restricted Project
krytarowski added a comment to D29405: Install six.py conditionally.

I will try to reverse engineer it..

Thu, Feb 2, 1:31 PM · Restricted Project
krytarowski added a comment to D29405: Install six.py conditionally.

Unfortunately, this prevents six.py being copied into the build directory, so a non-installed lldb will still not work (if you don't have the system six.py).

It looks like you will have to pass this flag into finishSwigPythonLLDB.py and check the condition there.

Thu, Feb 2, 1:25 PM · Restricted Project
krytarowski added a comment to D29405: Install six.py conditionally.

@labath patch done.

Thu, Feb 2, 9:03 AM · Restricted Project
krytarowski retitled D29405: Install six.py conditionally from Install six.py copy into subdirectory lldb to Install six.py conditionally.
Thu, Feb 2, 9:00 AM · Restricted Project
krytarowski updated the diff for D29405: Install six.py conditionally.

LLDB_USE_SYSTEM_SIX approach

Thu, Feb 2, 8:57 AM · Restricted Project
krytarowski closed D29296: Make llvm::call_once more convenient to reuse out of LLVM.
Thu, Feb 2, 8:17 AM
krytarowski updated the diff for D29296: Make llvm::call_once more convenient to reuse out of LLVM.

Use ::lvm namespace.

Thu, Feb 2, 8:16 AM
krytarowski closed D29403: Fix multi-process-driver.cpp build on NetBSD.
Thu, Feb 2, 7:17 AM · Restricted Project

Wed, Feb 1

krytarowski updated the diff for D29296: Make llvm::call_once more convenient to reuse out of LLVM.

Break line to fit the 80-cols limit.

Wed, Feb 1, 3:32 PM
krytarowski accepted D29406: Unify PlatformPOSIX::ResolveExecutable.
Wed, Feb 1, 12:33 PM
krytarowski added a comment to D29406: Unify PlatformPOSIX::ResolveExecutable.

It looks good.

Wed, Feb 1, 11:12 AM
krytarowski added a comment to D29405: Install six.py conditionally.

It does not seem to work for me. I get this when I run ninja check-lldb in the build directory:

Traceback (most recent call last):
  File "/usr/local/google/home/labath/ll/llvm/tools/lldb/test/dotest.py", line 6, in <module>
    import lldbsuite.test
  File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/__init__.py", line 5, in <module>
    from . import dotest
  File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/dotest.py", line 36, in <module>
    from lldb import six
ImportError: No module named lldb

Any idea what could be the cause?

Wed, Feb 1, 11:10 AM · Restricted Project
krytarowski updated the summary of D29405: Install six.py conditionally.
Wed, Feb 1, 10:49 AM · Restricted Project
krytarowski added a comment to D29405: Install six.py conditionally.

Please help to test this patch for regressions, at the moment I don't have all the test suits passing and I might have miss something.

Wed, Feb 1, 10:47 AM · Restricted Project
krytarowski created D29405: Install six.py conditionally.
Wed, Feb 1, 10:45 AM · Restricted Project
krytarowski created D29403: Fix multi-process-driver.cpp build on NetBSD.
Wed, Feb 1, 10:19 AM · Restricted Project
krytarowski closed D29256: Do not pass non-POD type variables through variadic function.
Wed, Feb 1, 8:14 AM · Restricted Project
krytarowski updated the diff for D29256: Do not pass non-POD type variables through variadic function.

Replace SetErrorDescriptionn(errMsg); with SetErrorDescription(errMsg);

Wed, Feb 1, 8:10 AM · Restricted Project
krytarowski closed D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork.
Wed, Feb 1, 6:41 AM · Restricted Project

Tue, Jan 31

krytarowski updated the summary of D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork.
Tue, Jan 31, 6:18 PM · Restricted Project
krytarowski updated the diff for D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork.

virtual -> override

Tue, Jan 31, 6:17 PM · Restricted Project
krytarowski updated the diff for D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork.

Fix typo.

Tue, Jan 31, 5:47 PM · Restricted Project
krytarowski retitled D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork from Add ProcessLauncherNetBSD to spawn a tracee to Transform ProcessLauncherLinux to ProcessLauncherPosixFork.
Tue, Jan 31, 5:09 PM · Restricted Project
krytarowski updated the diff for D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork.

Transform ProcessLauncherLinux to ProcessLauncherPosixFork and attach to Linux and NetBSD.

Tue, Jan 31, 5:00 PM · Restricted Project
krytarowski added a comment to D29266: Synchronize PlatformNetBSD with Linux.

After looking at this closer, I don't think we will even need a separate class to achieve deduplication. The code is so heavily duplicated (see comments on the first three non-boilerplate functions, I did not look at the rest yet, but I expect the situation to be the same) already that we can just push the definitions down the existing class hierarchy and achieve massive savings that way. After we're done with that, I think we'll find that the PlatformLinux class will be so small that your current s/linux/netbsd/ approach will no longer be a problem.

If @clayborg agrees with this approach, I can help you prepare the ground for that.

Tue, Jan 31, 1:59 PM · Restricted Project
krytarowski added a comment to D29256: Do not pass non-POD type variables through variadic function.

@ki.stfu do you still agree with this patch?

Tue, Jan 31, 1:48 PM · Restricted Project
krytarowski added a comment to D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork.

This is also copying a lot of code only to make tiny changes to it. Please put the Linux process launcher into the posix folder (I suggest naming it ProcessLauncherPosixFork). Ifdef out the linux-specific parts (ASLR, personality) and you're done. :)

For bonus points, you can put the ASLR code into a separate function, and then ifdef-out only that - should make main code flow better.

Tue, Jan 31, 1:47 PM · Restricted Project
krytarowski added a comment to D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork.

This patch was already open in a discussion with @labath, I'm pushing it here to point the appropriate solution during review.

Tue, Jan 31, 1:44 PM · Restricted Project
krytarowski created D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork.
Tue, Jan 31, 1:30 PM · Restricted Project
krytarowski added a comment to D29266: Synchronize PlatformNetBSD with Linux.

diff -u source/Plugins/Platform/Linux/PlatformLinux.cpp source/Plugins/Platform/NetBSD/PlatformNetBSD.cpp

Tue, Jan 31, 7:59 AM · Restricted Project
krytarowski closed D29264: Add NetBSD support in Host::GetCurrentThreadID.
Tue, Jan 31, 5:49 AM · Restricted Project

Mon, Jan 30

krytarowski added a comment to D29296: Make llvm::call_once more convenient to reuse out of LLVM.

Related review: D29288

Mon, Jan 30, 12:26 PM
krytarowski created D29296: Make llvm::call_once more convenient to reuse out of LLVM.
Mon, Jan 30, 12:25 PM
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

Be very careful when using this, you can't change member variables that used to be std::once to be statics. We also don't need the llvm namespace to be included with "using namespace llvm;" in many of the files.

using namespace llvm; is currently required in order to get this functional:

What about just updating the macro in LLVM to make it not needed?

#define LLVM_DEFINE_ONCE_FLAG(flag) static llvm::once_flag flag = Uninitialized
Mon, Jan 30, 10:41 AM · Restricted Project
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.
namespace llvm {
  namespace sys {
    void MemoryFence();
Mon, Jan 30, 10:11 AM · Restricted Project
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

Be very careful when using this, you can't change member variables that used to be std::once to be statics. We also don't need the llvm namespace to be included with "using namespace llvm;" in many of the files.

Mon, Jan 30, 10:07 AM · Restricted Project
krytarowski updated the summary of D29288: Switch std::call_once to llvm::call_once.
Mon, Jan 30, 9:42 AM · Restricted Project
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

I can build and test this patch on NetBSD/amd64.

Mon, Jan 30, 9:42 AM · Restricted Project
krytarowski created D29288: Switch std::call_once to llvm::call_once.
Mon, Jan 30, 9:36 AM · Restricted Project
krytarowski added a comment to D29256: Do not pass non-POD type variables through variadic function.

Hmm, I'm not reproducing it right now either. It's a patch added a year ago. I've pinged Tobias.

Mon, Jan 30, 3:41 AM · Restricted Project
krytarowski updated the summary of D29256: Do not pass non-POD type variables through variadic function.
Mon, Jan 30, 2:42 AM · Restricted Project
krytarowski added a comment to D29256: Do not pass non-POD type variables through variadic function.

I don't know the point of this patch (probably it's something special for NetBSD? @emaste) but I'm okay with that.

Mon, Jan 30, 2:28 AM · Restricted Project

Sun, Jan 29

krytarowski created D29266: Synchronize PlatformNetBSD with Linux.
Sun, Jan 29, 3:16 PM · Restricted Project
krytarowski created D29264: Add NetBSD support in Host::GetCurrentThreadID.
Sun, Jan 29, 2:52 PM · Restricted Project

Sat, Jan 28

krytarowski retitled D29256: Do not pass non-POD type variables through variadic function from Do not pass non-trivial type variables through variadic function to Do not pass non-POD type variables through variadic function.
Sat, Jan 28, 4:48 PM · Restricted Project
krytarowski created D29256: Do not pass non-POD type variables through variadic function.
Sat, Jan 28, 4:16 PM · Restricted Project
krytarowski closed D29089: Switch HostInfoNetBSD::GetProgramFileSpec to sysctl(7).
Sat, Jan 28, 12:16 PM · Restricted Project
krytarowski closed D29091: Recognize Real-Time Signals on NetBSD.
Sat, Jan 28, 12:13 PM · Restricted Project

Jan 24 2017

krytarowski added a reviewer for D29091: Recognize Real-Time Signals on NetBSD: emaste.
Jan 24 2017, 10:54 AM · Restricted Project
krytarowski created D29091: Recognize Real-Time Signals on NetBSD.
Jan 24 2017, 10:54 AM · Restricted Project
krytarowski created D29089: Switch HostInfoNetBSD::GetProgramFileSpec to sysctl(7).
Jan 24 2017, 9:59 AM · Restricted Project

Oct 21 2016

krytarowski added a comment to D25756: FreeBSD ARM support for software single step..

I just scrolled the discussion so it's not really started. Thanks.

Oct 21 2016, 12:12 PM · Restricted Project
krytarowski added a comment to D25756: FreeBSD ARM support for software single step..

@emaste What's the status of remote debugging on FreeBSD?

Oct 21 2016, 11:57 AM · Restricted Project
krytarowski added a comment to D25756: FreeBSD ARM support for software single step..

NetBSD is still focused on amd64-only port.

Oct 21 2016, 11:49 AM · Restricted Project

Oct 20 2016

krytarowski added a comment to D25830: Search for llvm-config in LLDB_PATH_TO_LLVM_BUILD first.

I think it's possible to specify -DLLVM_CONFIG:PATH option, if that does the job.

Oct 20 2016, 1:12 PM