krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (111 w, 2 d)

Recent Activity

Fri, Oct 13

krytarowski updated subscribers of D38900: libunwind: document tested FreeBSD configs and sort OS list.

@joerg might have insight on ppc, sparc64, arm on NetBSD.

Fri, Oct 13, 12:41 PM

Wed, Oct 11

krytarowski added inline comments to D38829: Python: SetOutputFileHandle doesn't work with IOBase.
Wed, Oct 11, 4:21 PM

Tue, Oct 3

krytarowski added a comment to D37319: Add NetBSD support in tsan_test_util_posix.cc.

ping

Tue, Oct 3, 4:28 AM · Restricted Project

Wed, Sep 27

krytarowski planned changes to D32149: Correct handling NetBSD core(5) files with threads.

Suspended, I need to resurrect tracing of 1 thread and fix kernel bugs for multiple threads first.

Wed, Sep 27, 1:38 AM · Restricted Project

Thu, Sep 21

krytarowski added a comment to D38098: Removed platform-specific ifdefs from sanitizer_procmaps.h.

I will test this on NetBSD after Monday.

Thu, Sep 21, 1:04 AM

Sep 11 2017

krytarowski planned changes to D33878: Handle NetBSD specific _Unwind_Ptr.

Suspended till getting functional elementary support of LLDB/NetBSD aboard.

Sep 11 2017, 5:21 AM

Aug 30 2017

krytarowski created D37319: Add NetBSD support in tsan_test_util_posix.cc.
Aug 30 2017, 4:16 PM · Restricted Project
krytarowski closed D37244: Finalize ASAN/NetBSD.
Aug 30 2017, 4:06 PM · Restricted Project
krytarowski updated subscribers of D37244: Finalize ASAN/NetBSD.
Aug 30 2017, 3:55 PM · Restricted Project
krytarowski closed D37307: Add NetBSD support in lsan_interceptors.cc.
Aug 30 2017, 3:48 PM · Restricted Project
krytarowski added a comment to D37244: Finalize ASAN/NetBSD.

ping?

Aug 30 2017, 3:46 PM · Restricted Project
krytarowski closed D37304: Add preliminary NetBSD support in libfuzzer.
Aug 30 2017, 3:46 PM · Restricted Project
krytarowski added a comment to D37304: Add preliminary NetBSD support in libfuzzer.

Thank you for the reviews!

Aug 30 2017, 3:40 PM · Restricted Project
krytarowski updated the diff for D37304: Add preliminary NetBSD support in libfuzzer.
  • drop -lrt patch from tests
Aug 30 2017, 3:22 PM · Restricted Project
krytarowski added inline comments to D37304: Add preliminary NetBSD support in libfuzzer.
Aug 30 2017, 3:06 PM · Restricted Project
krytarowski added a comment to D37314: [CMake] Disable 64bit file position on old 32 bit Androids.

I would add in the commit description that this is Linux/Android specific. For the reference, 32bit systems like BSD ship with 64bit off_t always.

Aug 30 2017, 2:59 PM
krytarowski closed D37305: Add NetBSD support in tsan_interceptors.cc.
Aug 30 2017, 12:42 PM · Restricted Project
krytarowski closed D37306: Add NetBSD support in test/tsan/thread_name*.cc.
Aug 30 2017, 12:41 PM · Restricted Project
krytarowski created D37307: Add NetBSD support in lsan_interceptors.cc.
Aug 30 2017, 12:36 PM · Restricted Project
krytarowski updated the summary of D37306: Add NetBSD support in test/tsan/thread_name*.cc.
Aug 30 2017, 12:28 PM · Restricted Project
krytarowski created D37306: Add NetBSD support in test/tsan/thread_name*.cc.
Aug 30 2017, 12:27 PM · Restricted Project
krytarowski created D37305: Add NetBSD support in tsan_interceptors.cc.
Aug 30 2017, 12:22 PM · Restricted Project
krytarowski added a comment to D37305: Add NetBSD support in tsan_interceptors.cc.

I'm on vacation during September, I will keep pinging for this patch but not writing new code. I will be back to development in October.

Aug 30 2017, 12:22 PM · Restricted Project
krytarowski added a comment to D37304: Add preliminary NetBSD support in libfuzzer.

I'm on vacation during September, I will keep pinging for this patch but not writing new code. I will be back to development in October.

Aug 30 2017, 12:09 PM · Restricted Project
krytarowski created D37304: Add preliminary NetBSD support in libfuzzer.
Aug 30 2017, 11:58 AM · Restricted Project

Aug 29 2017

krytarowski added inline comments to D34851: [WebAssembly] Initial wasm linker implementation.
Aug 29 2017, 4:18 PM

Aug 28 2017

krytarowski created D37244: Finalize ASAN/NetBSD.
Aug 28 2017, 6:46 PM · Restricted Project
krytarowski closed D37149: Shorten filenames of tests (-with-calls to -wcalls).

I've committed it as r. 311966 with "calls" and removed comment.

Aug 28 2017, 6:06 PM · Restricted Project
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

After turning off PIE verification (Linux/FreeBSD specific?), I was getting random corruption and SIGSEGV.

Aug 28 2017, 5:57 PM · Restricted Project
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

I've checked that ShadowOffset 0 breaks ASAN.

Aug 28 2017, 5:55 PM · Restricted Project
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

Unless I'm looking wrongly Clang in SanitizerArgs.cpp, does not mandate PIE for TSAN.

Aug 28 2017, 4:47 PM · Restricted Project
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

Does NetBSD support non-PIE executables? Will they work with shadow at 0?

Aug 28 2017, 4:16 PM · Restricted Project
krytarowski added a comment to D37149: Shorten filenames of tests (-with-calls to -wcalls).

I will commit it as calls, thanks!

Aug 28 2017, 4:09 PM · Restricted Project
krytarowski closed D37234: Define NetBSD/amd64 ASAN Shadow Offset.
Aug 28 2017, 3:14 PM · Restricted Project
krytarowski added a comment to D37234: Define NetBSD/amd64 ASAN Shadow Offset.

I'm going to commit it as is, the offset can be optimized in future if needed.

Aug 28 2017, 3:12 PM · Restricted Project
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

It's just an address where a shadow-sized hole is most like to be found.
But there are other considerations. For example, 0x7FFF8000 is the highest (or close to highest) address that allows shorter instruction encoding on x86_64. Zero offset is typically not used (even though it is usually the fastest option) because it conflicts with MAP_32BIT.

Aug 28 2017, 2:57 PM · Restricted Project
krytarowski created D37234: Define NetBSD/amd64 ASAN Shadow Offset.
Aug 28 2017, 2:53 PM · Restricted Project
krytarowski added a comment to D37149: Shorten filenames of tests (-with-calls to -wcalls).

Any comments on it?

Aug 28 2017, 2:42 PM · Restricted Project
krytarowski closed D36587: Add NetBSD ASAN shadow mapping for x86-64.
Aug 28 2017, 2:42 PM · Restricted Project
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

I kindly ask for explanation of this shadow offset value. (My questions were on top, I see them hidden by Phabricator now)

Aug 28 2017, 2:41 PM · Restricted Project
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

ping x3

Aug 28 2017, 2:28 PM · Restricted Project
krytarowski closed D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.
Aug 28 2017, 2:04 PM · Restricted Project
krytarowski added a comment to D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.

@kcc removed that ifdef (file disappeared as empty diff)

Aug 28 2017, 1:33 PM · Restricted Project
krytarowski updated the diff for D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.
  • correct shmctl(2) interception on NetBSD
  • remove ifdef in generic code, define unknown values to -1
Aug 28 2017, 1:31 PM · Restricted Project
krytarowski added inline comments to D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.
Aug 28 2017, 1:11 PM · Restricted Project
krytarowski updated the diff for D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.

Fix the patch, it was accidentally partitioned.

Aug 28 2017, 1:01 PM · Restricted Project
krytarowski updated the diff for D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.

Rename in comments sanitizer_platform_limits_posix.* to sanitizer_platform_limits_netbsd.*

Aug 28 2017, 1:00 PM · Restricted Project
krytarowski updated the diff for D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.
struct_shm_info_sz;
extern int shmctl_ipc_stat;
extern int shmctl_ipc_info;
extern int shmctl_shm_info;
extern int shmctl_shm_stat;
Aug 28 2017, 12:56 PM · Restricted Project
krytarowski updated the diff for D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.
  • replace LP64 check with SANITIZER_WORDSIZE
  • restrict sanitizer_platform_limits_netbsd.h to NetBSD with the internal ifdef
Aug 28 2017, 12:46 PM · Restricted Project
krytarowski added inline comments to D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.
Aug 28 2017, 10:59 AM · Restricted Project

Aug 27 2017

krytarowski abandoned D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.
In D35554#853339, @kcc wrote:

This patch has too many #ifdefs.
#ifdefs cause maintenance nightmare.
Instead of #ifdefs, can you move the code to separate *netbsd*.[h,cpp] files?

Aug 27 2017, 5:39 AM · Restricted Project
krytarowski created D37193: Add NetBSD specific version of sanitizer_platform_limits_posix.
Aug 27 2017, 5:38 AM · Restricted Project

Aug 26 2017

krytarowski added a comment to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

I plan to go on vacations during September, if there are no more comments I will commit it as it is in the coming week.

Aug 26 2017, 7:07 AM · Restricted Project

Aug 25 2017

krytarowski created D37149: Shorten filenames of tests (-with-calls to -wcalls).
Aug 25 2017, 8:32 AM · Restricted Project

Aug 22 2017

krytarowski added reviewers for D36804: Add initial support to PowerPC64 little endian (POWER8): labath, clayborg.

+ Linux and general LLDB maintainers

Aug 22 2017, 12:03 PM
krytarowski added a comment to D36331: Add ARC backend.

Any comments or suggestions about Krzysztof's copyright notice question here? Are they OK in, or should the notices be taken out?

Aug 22 2017, 8:43 AM
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

ping x2

Aug 22 2017, 6:15 AM · Restricted Project
krytarowski added a comment to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

Ping x2

Aug 22 2017, 6:15 AM · Restricted Project

Aug 21 2017

krytarowski added a reviewer for D35554: Add NetBSD support in sanitizer_platform_limits_posix.*: fjricci.
Aug 21 2017, 12:34 PM · Restricted Project
krytarowski closed D36935: Enable libfuzzer on NetBSD/amd64.
Aug 21 2017, 12:13 PM · Restricted Project
krytarowski added a comment to D33878: Handle NetBSD specific _Unwind_Ptr.

Well, the libexecinfo one exists as fallback because gcc doesn't provide one.

Aug 21 2017, 10:21 AM
krytarowski added a comment to D33878: Handle NetBSD specific _Unwind_Ptr.

Kamil, which unwind.h are you using? The outdated copy in libexecinfo.h or the modern one used by libunwind? I see little reason to cater to the bugs in the former...

Aug 21 2017, 9:38 AM
krytarowski added a comment to D33878: Handle NetBSD specific _Unwind_Ptr.

https://github.com/NetBSD/src/blob/trunk/lib/libexecinfo/unwind.h here is the referenced header used by GCC.

Aug 21 2017, 9:37 AM

Aug 20 2017

krytarowski added a reviewer for D36935: Enable libfuzzer on NetBSD/amd64: george.karpenkov.
Aug 20 2017, 9:00 AM · Restricted Project
krytarowski created D36935: Enable libfuzzer on NetBSD/amd64.
Aug 20 2017, 8:56 AM · Restricted Project

Aug 19 2017

krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.
In D36908#846734, @kcc wrote:

Rule of thumb: never mix refactoring with functional changes (or porting to new platforms, etc) in a single change.

Aug 19 2017, 7:25 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.
In D36908#846732, @kcc wrote:

Any such change during a large refactoring is a burden, sorry.

Aug 19 2017, 7:11 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.
In D36908#846722, @kcc wrote:

Please amend this patch with support for NetBSD:

http://www.netbsd.org/~kamil/llvm/libfuzzer-netbsd.txt

Not everything is ready, like missing lsan... but it's good enough for start and improve in future.

Let's not overcomplicate the move to compiler-rt, it's pretty involved any way.
We would welcome support for any new platform in a separate patch once the dust settles (a week or two).
For any new supported platform will require a public build bot and a contact person.
Lacking that we can't promise to keep the port alive. (For further discussion, please start a new thread).

Aug 19 2017, 7:00 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.

Please amend this patch with support for NetBSD:

Aug 19 2017, 3:26 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.

I will move it here (from the mailing list):

Aug 19 2017, 2:43 PM
krytarowski added a comment to D36908: Moving libFuzzer to compiler-rt.

A side notice but wouldn't it be better to make libFuzzer a completely separate component (like openmp)? I've seen people take interest in it outside LLVM toolchain.

Aug 19 2017, 1:14 PM

Aug 18 2017

krytarowski added inline comments to D36908: Moving libFuzzer to compiler-rt.
Aug 18 2017, 7:21 PM
krytarowski added inline comments to D36908: Moving libFuzzer to compiler-rt.
Aug 18 2017, 6:19 PM
krytarowski added a comment to D36810: Minimal runtime for UBSan..

ubsan and suitable on production? I don't understand this phrasing, sounds to me like oxymoron.

Aug 18 2017, 11:00 AM

Aug 17 2017

krytarowski added reviewers for D36587: Add NetBSD ASAN shadow mapping for x86-64: eugenis, pcc.

Adding more reviewers to get feedback.

Aug 17 2017, 8:36 AM · Restricted Project

Aug 16 2017

krytarowski added a comment to D35667: [DragonEgg] Initial migration to GCC v8.x and LLVM v6.x.

What's your particular need for this project? If just for fan, this might not be worth to maintain.

There is ongoing effort to upstream Fortran support to LLVM.

For reference: https://github.com/flang-compiler/flang

Hi Leslie,
If you focused your efforts on trying to get flang integrated with top of trunk LLVM this would be incredibly helpful to the community. :D

Aug 16 2017, 2:52 AM

Aug 15 2017

krytarowski added a comment to D36265: Support lib changes to allow VFS implementation handling working dir locally..

It's not just Windows, but not even all unixes support openat. Minimum required version of various Unixes are:

DragonFly 2.3.
FreeBSD 8.0.
Linux 2.6.16
NetBSD 7.0.
OpenBSD 5.0.
OS X 10.10.

I don't know how old some of these are, but you should check first to make sure we don't support any versions of these unix variants with versions older than specified above. As for Windows, If we're going to use Nt functions, I would rather they be entirely separate functions. i.e. not done via an optional parameter to an existing function, but a completely new function.

Aug 15 2017, 2:15 PM
krytarowski added a comment to D36603: Enable profile on NetBSD.

I've compressed the whole directory (for which I had more issues) and uploaded:

Aug 15 2017, 9:01 AM · Restricted Project
krytarowski added a comment to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

ping

Aug 15 2017, 3:09 AM · Restricted Project
krytarowski added a comment to D36603: Enable profile on NetBSD.

I've reverted the commit on demand.

Aug 15 2017, 3:09 AM · Restricted Project

Aug 13 2017

krytarowski closed D36603: Enable profile on NetBSD.
Aug 13 2017, 1:19 PM · Restricted Project
krytarowski added a comment to D36603: Enable profile on NetBSD.
In D36603#839356, @vsk wrote:

I think it would be better to XFAIL the test from the onset so that people reading the source are aware of the issue. That way, if for any reason this can't make its way back on your priority list, the build will remain in good shape.

Aug 13 2017, 12:38 PM · Restricted Project

Aug 11 2017

krytarowski added a comment to D36603: Enable profile on NetBSD.
In D36603#839335, @vsk wrote:

What's causing the test failure? Do you plan on XFAIL'ing the test on NetBSD initially?

Aug 11 2017, 10:35 AM · Restricted Project

Aug 10 2017

krytarowski created D36603: Enable profile on NetBSD.
Aug 10 2017, 7:13 PM · Restricted Project
krytarowski added a comment to D36587: Add NetBSD ASAN shadow mapping for x86-64.

I don't really get why the shadow offset differs between systems, I copied it from FreeBSD.
Please help to optimize it.

Aug 10 2017, 12:43 PM · Restricted Project
krytarowski created D36587: Add NetBSD ASAN shadow mapping for x86-64.
Aug 10 2017, 12:33 PM · Restricted Project
krytarowski added a comment to D35554: Add NetBSD support in sanitizer_platform_limits_posix.*.

ASAN, UBSAN and SAFESTACK are already committed.

Aug 10 2017, 12:13 PM · Restricted Project
krytarowski closed D36490: Enable ASAN on NetBSD.
Aug 10 2017, 12:09 PM · Restricted Project
krytarowski closed D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64.
Aug 10 2017, 11:54 AM · Restricted Project
krytarowski closed D36488: Add NetBSD support in asan_linux.cc.
Aug 10 2017, 11:52 AM · Restricted Project
krytarowski added inline comments to D36490: Enable ASAN on NetBSD.
Aug 10 2017, 11:50 AM · Restricted Project
krytarowski added inline comments to D36488: Add NetBSD support in asan_linux.cc.
Aug 10 2017, 11:47 AM · Restricted Project
krytarowski added inline comments to D36490: Enable ASAN on NetBSD.
Aug 10 2017, 11:44 AM · Restricted Project
krytarowski closed D36542: Enable SafeStack on NetBSD.
Aug 10 2017, 11:41 AM · Restricted Project
krytarowski added inline comments to D36490: Enable ASAN on NetBSD.
Aug 10 2017, 11:40 AM · Restricted Project

Aug 9 2017

krytarowski added inline comments to D36484: Add NetBSD support in asan_symbolize.py.
Aug 9 2017, 6:26 PM · Restricted Project
krytarowski created D36542: Enable SafeStack on NetBSD.
Aug 9 2017, 12:28 PM · Restricted Project
krytarowski added inline comments to D36385: [asan] Refactor thread creation bookkeeping.
Aug 9 2017, 11:37 AM · Restricted Project
krytarowski updated the diff for D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64.

Fix lsan entry.
Add tests.

Aug 9 2017, 11:19 AM · Restricted Project
krytarowski retitled D36482: Enable bunch of sanitizers on NetBSD/X86 and X86_64 from Enable SanitizerKind::Vptr on NetBSD/X86 and X86_64 to Enable bunch of sanitizers on NetBSD/X86 and X86_64.
Aug 9 2017, 10:24 AM · Restricted Project