krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.
User Since
Aug 30 2015, 11:51 AM (81 w, 4 d)

Recent Activity

Yesterday

krytarowski closed D31231: Reuse appropriate Launch and Attach on NetBSD.
Wed, Mar 22, 8:10 AM · Restricted Project
krytarowski added a comment to D31231: Reuse appropriate Launch and Attach on NetBSD.

With x86_64 general purpose registers going before that.

Wed, Mar 22, 4:06 AM · Restricted Project
krytarowski added a comment to D31231: Reuse appropriate Launch and Attach on NetBSD.

Next, I will work on a code to extend the NetBSD Process Plugin from a stub to a version that actually works.

Wed, Mar 22, 3:59 AM · Restricted Project

Tue, Mar 21

krytarowski created D31231: Reuse appropriate Launch and Attach on NetBSD.
Tue, Mar 21, 7:13 PM · Restricted Project
krytarowski added a comment to D31199: Add "(compatible with the GNU linker)" to the -version output..

looks reasonable

Tue, Mar 21, 11:32 AM
krytarowski closed D31192: Create instance of DynamicLoaderPOSIXDYLD on NetBSD.
Tue, Mar 21, 10:51 AM · Restricted Project
krytarowski added a comment to D31192: Create instance of DynamicLoaderPOSIXDYLD on NetBSD.

This approach is easier for my to understand each change and make sure that it's actually needed and correct (or looking like a proper solution).
There are 2 similar changes left I don't fully understand and code interfering with the OpenBSD platform addition that I will hold on a while.

Tue, Mar 21, 10:49 AM · Restricted Project
krytarowski closed D31138: Add stub for PluginProcessNetBSD.
Tue, Mar 21, 10:42 AM · Restricted Project
krytarowski closed D31146: Enable AUXV and QPassSignals in gdb-remote for NetBSD.
Tue, Mar 21, 10:40 AM · Restricted Project
krytarowski closed D31191: Enable ProcessPOSIXLog on NetBSD.
Tue, Mar 21, 10:39 AM · Restricted Project
krytarowski closed D31132: Add NetBSD case in Entry::Type::ThreadID.
Tue, Mar 21, 10:37 AM · Restricted Project
krytarowski created D31192: Create instance of DynamicLoaderPOSIXDYLD on NetBSD.
Tue, Mar 21, 9:40 AM · Restricted Project
krytarowski created D31191: Enable ProcessPOSIXLog on NetBSD.
Tue, Mar 21, 9:16 AM · Restricted Project
krytarowski updated the diff for D31138: Add stub for PluginProcessNetBSD.

Style fix.

Tue, Mar 21, 8:31 AM · Restricted Project
krytarowski updated the diff for D31138: Add stub for PluginProcessNetBSD.

Cut down the unused functions from the Native Process NetBSD Plugin.

Tue, Mar 21, 8:28 AM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Tue, Mar 21, 7:16 AM · Restricted Project
krytarowski added a comment to D31146: Enable AUXV and QPassSignals in gdb-remote for NetBSD.

I'm still evaluating whether to implement on the kernel side PT_SET_SIGPASS/PT_GET_SIGPASS. Some software like floating point can use it heavily.

Tue, Mar 21, 5:18 AM · Restricted Project
krytarowski added a comment to D31138: Add stub for PluginProcessNetBSD.

I like the idea of adding boilerplate first, so that we can than better focus on the important stuff later. However, I think you've have gone a bit too far with it -- you introduce a lot of functions I am pretty sure will not be necessary for your case, or that should be handled differently (software single stepping stuff, handling of linux thread stopping, ...).

Could we trim this down to just the functions that are necessary to get this building (basically just virtual overrides -- no private functions or members)? Those can be always added along with the patch that implements them, and then we will be in a better position to review it.

Tue, Mar 21, 5:16 AM · Restricted Project

Mon, Mar 20

krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mon, Mar 20, 4:03 PM · Restricted Project
krytarowski updated the summary of D31132: Add NetBSD case in Entry::Type::ThreadID.
Mon, Mar 20, 11:58 AM · Restricted Project
krytarowski created D31146: Enable AUXV and QPassSignals in gdb-remote for NetBSD.
Mon, Mar 20, 11:54 AM · Restricted Project
krytarowski added a comment to D31138: Add stub for PluginProcessNetBSD.

I have got a few local changes that conflict with D31131, this is why I will hold on them unless @kettenis does not intend to land his patch in the coming days.

Mon, Mar 20, 10:37 AM · Restricted Project
krytarowski created D31138: Add stub for PluginProcessNetBSD.
Mon, Mar 20, 10:21 AM · Restricted Project
krytarowski created D31132: Add NetBSD case in Entry::Type::ThreadID.
Mon, Mar 20, 8:05 AM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Mon, Mar 20, 4:47 AM · Restricted Project

Sun, Mar 19

krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Sun, Mar 19, 8:03 PM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Sun, Mar 19, 8:00 PM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Sun, Mar 19, 7:11 PM · Restricted Project
krytarowski added inline comments to D31131: [LLDB] OpenBSD support.
Sun, Mar 19, 6:54 PM · Restricted Project
krytarowski added reviewers for D31131: [LLDB] OpenBSD support: labath, joerg, krytarowski.
Sun, Mar 19, 6:46 PM · Restricted Project
krytarowski added a comment to D31131: [LLDB] OpenBSD support.

I got a substantial portion of Process Plugin to work on NetBSD, to coordinate the work feel free to join IRC #lldb at OFTC -- e.g. do not waste time on FreeBSD Process Plugin.

Sun, Mar 19, 6:45 PM · Restricted Project

Thu, Mar 16

krytarowski added inline comments to D30981: Remove HostThreadLinux/Free/NetBSD.
Thu, Mar 16, 2:57 PM
krytarowski added a comment to D31031: Move GetAuxvData from Host to relevant process plugins.

Thank you for this.

Thu, Mar 16, 11:35 AM
krytarowski accepted D30981: Remove HostThreadLinux/Free/NetBSD.

Thank you for your explanation. I will use approach similar to FreeBSD on NetBSD.

Thu, Mar 16, 11:31 AM

Wed, Mar 15

krytarowski added inline comments to D30981: Remove HostThreadLinux/Free/NetBSD.
Wed, Mar 15, 11:41 AM
krytarowski added a comment to D30981: Remove HostThreadLinux/Free/NetBSD.

remove the NetBSD version (which was probably incorrect anyway, as it assumes the current process instead of the inferior.

Wed, Mar 15, 11:25 AM
krytarowski added a comment to D30942: Remove some ProcFileReader occurences.

For your interest. NetBSD will not use procfs for any operation.

Wed, Mar 15, 9:09 AM

Sat, Mar 4

krytarowski added a comment to D30526: [Support] Add functions to get and set thread name..

I will improve this code for NetBSD as we must not include <sys/user.h>. This header is long empty and it will be removed.

Sat, Mar 4, 9:51 AM

Mon, Feb 27

krytarowski closed D30374: Support NetBSD Thread ID in lldb-server tests.
Mon, Feb 27, 10:04 AM · Restricted Project

Fri, Feb 24

krytarowski retitled D30374: Support NetBSD Thread ID in lldb-server tests from Support NetBSD Thread ID in lldb-server to Support NetBSD Thread ID in lldb-server tests.
Fri, Feb 24, 11:22 PM · Restricted Project
krytarowski created D30374: Support NetBSD Thread ID in lldb-server tests.
Fri, Feb 24, 11:11 PM · Restricted Project

Thu, Feb 23

krytarowski closed D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
Thu, Feb 23, 6:05 PM · Restricted Project
krytarowski closed D30288: Switch NetBSD from paccept(2) to accept4(2).
Thu, Feb 23, 6:03 PM · Restricted Project
krytarowski updated the diff for D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
  • remove unused function GetSharedRegisterInfoVector
  • fix DR_OFFSET
Thu, Feb 23, 4:47 PM · Restricted Project
krytarowski added inline comments to D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
Thu, Feb 23, 2:00 PM · Restricted Project
krytarowski created D30288: Switch NetBSD from paccept(2) to accept4(2).
Thu, Feb 23, 1:26 AM · Restricted Project
krytarowski retitled D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64 from Introduce support for Debug Registers RegisterContextNetBSD_x86_64 to Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
Thu, Feb 23, 12:55 AM · Restricted Project
krytarowski created D30287: Introduce support for Debug Registers in RegisterContextNetBSD_x86_64.
Thu, Feb 23, 12:38 AM · Restricted Project

Wed, Feb 22

krytarowski accepted D30250: Switch "posix" to the new log channel registration mechanism.

I had locally code registering NetBSD specific log channel and this patch is removing this needless code. Thank you for this work!

Wed, Feb 22, 12:03 PM
krytarowski added inline comments to D30234: Reformat inferior's main.cpp in lldb-server test.
Wed, Feb 22, 1:44 AM · Restricted Project

Feb 20 2017

krytarowski added a comment to D27126: Merge Linux and FreeBSD arm register contexts.

This diff looks good and appreciated for other posix-like systems.

Feb 20 2017, 9:17 PM

Feb 16 2017

krytarowski added a comment to D30010: Improve the robustness of mmap.

It builds now. (NetBSD 7.99.59 amd64)

Feb 16 2017, 4:36 PM
krytarowski added a comment to D30010: Improve the robustness of mmap.
In file included from /tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Path.cpp:1174:0:
/tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Unix/Path.inc: In function 'std::error_code llvm::sys::fs::is_local(int, bool&)':
/tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Unix/Path.inc:376:35: error: too many arguments to function 'bool llvm::sys::fs::is_local_impl(statvfs&)'
   return is_local_impl(Vfs, Result);
                                   ^
/tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Unix/Path.inc:346:13: note: declared here
 static bool is_local_impl(struct STATVFS &Vfs) {
             ^
/tmp/pkgsrc-tmp/wip/llvm-git/work/llvm/lib/Support/Unix/Path.inc:376:23: error: could not convert 'llvm::sys::fs::is_local_impl(Vfs)' from 'bool' to 'std::error_code'
   return is_local_impl(Vfs, Result);
                       ^
[ 26%] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/SearchForAddressOfSpecialSymbol.cpp.o
[ 26%] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Signals.cpp.o
--- lib/Support/CMakeFiles/LLVMSupport.dir/Path.cpp.o ---
*** [lib/Support/CMakeFiles/LLVMSupport.dir/Path.cpp.o] Error code 1
Feb 16 2017, 4:16 PM
krytarowski added inline comments to D30010: Improve the robustness of mmap.
Feb 16 2017, 3:58 PM
krytarowski added inline comments to D30010: Improve the robustness of mmap.
Feb 16 2017, 3:45 PM

Feb 13 2017

krytarowski added a comment to D29909: Break some more dependencies in lldbUtility.

git log --follow seems to understand. Is that sufficient to guarantee that it will be retained on the SVN side?

Feb 13 2017, 3:12 PM

Feb 7 2017

krytarowski accepted D29667: Synchronize PlatformFreeBSD with Linux.
Feb 7 2017, 11:11 AM

Feb 6 2017

krytarowski closed D29288: Switch std::call_once to llvm::call_once.
Feb 6 2017, 10:06 AM · Restricted Project
krytarowski added inline comments to D29288: Switch std::call_once to llvm::call_once.
Feb 6 2017, 9:02 AM · Restricted Project

Feb 5 2017

krytarowski closed D29266: Synchronize PlatformNetBSD with Linux.
Feb 5 2017, 1:43 PM · Restricted Project
krytarowski closed D29566: Revamp llvm::once_flag to be closer to std::once_flag.
Feb 5 2017, 1:24 PM
krytarowski updated the diff for D29566: Revamp llvm::once_flag to be closer to std::once_flag.

Document autoinitialization purpose of llvm::once_flag.

Feb 5 2017, 9:57 AM
krytarowski updated the diff for D29566: Revamp llvm::once_flag to be closer to std::once_flag.

Turn once_flag into struct.

Feb 5 2017, 9:44 AM
krytarowski updated the diff for D29288: Switch std::call_once to llvm::call_once.

Revamp to new llvm::once_flag

Feb 5 2017, 9:22 AM · Restricted Project
krytarowski retitled D29566: Revamp llvm::once_flag to be closer to std::once_flag from Revamp the llvm::once_flag to be closer to std::once_flag to Revamp llvm::once_flag to be closer to std::once_flag.
Feb 5 2017, 8:54 AM
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

https://reviews.llvm.org/D29566 I filed a patch in LLVM.

Feb 5 2017, 8:53 AM · Restricted Project
krytarowski created D29566: Revamp llvm::once_flag to be closer to std::once_flag.
Feb 5 2017, 8:52 AM
krytarowski abandoned D29552: Make llvm::call_once more convenient to reuse out of LLVM.

I'm going to propose a reworked interface. Closer in interaction to std::call_once.

Feb 5 2017, 7:45 AM

Feb 4 2017

krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

Once someone could explain to me why SymbolFileDWARF::GetCachedSectionData cannot be switched mechanically to llvm::call_once, I would like to propose this revamped interface to llvm.

Feb 4 2017, 7:54 PM · Restricted Project
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

Test results for the above patch for LLVM and LLDB with "mechanical" switch to llvm::call_once.

Feb 4 2017, 7:42 PM · Restricted Project
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

I've tried to build the LLDB code with mechanically * replaced std::call_once -> llvm::call_once and std::once_flag -> llvm::once_flag:

Feb 4 2017, 7:38 PM · Restricted Project
krytarowski added inline comments to D29288: Switch std::call_once to llvm::call_once.
Feb 4 2017, 6:47 PM · Restricted Project
krytarowski added a comment to D29266: Synchronize PlatformNetBSD with Linux.

OK to land it? FreeBSD can reuse almost exact the same code. I'm not sure if it's compatible with their Process Plugin.

Feb 4 2017, 6:20 PM · Restricted Project
krytarowski updated the diff for D29266: Synchronize PlatformNetBSD with Linux.

Catch up after r294114 - Clean up PlatformLinux code

Feb 4 2017, 6:14 PM · Restricted Project
krytarowski added a comment to D29266: Synchronize PlatformNetBSD with Linux.

I'm syncing the code to get the changes from SVN revision 294114 "Clean up PlatformLinux code"

Feb 4 2017, 5:50 PM · Restricted Project
krytarowski added a comment to D29288: Switch std::call_once to llvm::call_once.

Related https://reviews.llvm.org/D29552

Feb 4 2017, 5:00 PM · Restricted Project
krytarowski created D29552: Make llvm::call_once more convenient to reuse out of LLVM.
Feb 4 2017, 3:39 PM
krytarowski updated the diff for D29288: Switch std::call_once to llvm::call_once.

Typo.

Feb 4 2017, 3:23 PM · Restricted Project
krytarowski updated the diff for D29288: Switch std::call_once to llvm::call_once.

Revamp patch after recent changes in LLVM.

Feb 4 2017, 2:17 PM · Restricted Project
krytarowski updated the diff for D29266: Synchronize PlatformNetBSD with Linux.

Sync this patch with SVN 294071.

Feb 4 2017, 1:05 PM · Restricted Project

Feb 3 2017

krytarowski closed D29405: Install six.py conditionally.
Feb 3 2017, 4:31 PM · Restricted Project
krytarowski updated the diff for D29405: Install six.py conditionally.

Pass option to --useSystemSix to finishSwigWrapperClasses.py

Feb 3 2017, 12:13 PM · Restricted Project
krytarowski accepted D29496: Push down more common code into PlatformPOSIX.

Thank you for this patch.

Feb 3 2017, 9:17 AM

Feb 2 2017

krytarowski added a comment to D29266: Synchronize PlatformNetBSD with Linux.

I need to finish three patches:

  • llvm::call_once,
  • auxv reading,
  • six.py conflict removal

and I will join here.

Feb 2 2017, 4:57 PM · Restricted Project
krytarowski added a comment to D29405: Install six.py conditionally.

I will try to reverse engineer it..

Feb 2 2017, 1:31 PM · Restricted Project
krytarowski added a comment to D29405: Install six.py conditionally.

Unfortunately, this prevents six.py being copied into the build directory, so a non-installed lldb will still not work (if you don't have the system six.py).

It looks like you will have to pass this flag into finishSwigPythonLLDB.py and check the condition there.

Feb 2 2017, 1:25 PM · Restricted Project
krytarowski added a comment to D29405: Install six.py conditionally.

@labath patch done.

Feb 2 2017, 9:03 AM · Restricted Project
krytarowski retitled D29405: Install six.py conditionally from Install six.py copy into subdirectory lldb to Install six.py conditionally.
Feb 2 2017, 9:00 AM · Restricted Project
krytarowski updated the diff for D29405: Install six.py conditionally.

LLDB_USE_SYSTEM_SIX approach

Feb 2 2017, 8:57 AM · Restricted Project
krytarowski closed D29296: Make llvm::call_once more convenient to reuse out of LLVM.
Feb 2 2017, 8:17 AM
krytarowski updated the diff for D29296: Make llvm::call_once more convenient to reuse out of LLVM.

Use ::lvm namespace.

Feb 2 2017, 8:16 AM
krytarowski closed D29403: Fix multi-process-driver.cpp build on NetBSD.
Feb 2 2017, 7:17 AM · Restricted Project

Feb 1 2017

krytarowski updated the diff for D29296: Make llvm::call_once more convenient to reuse out of LLVM.

Break line to fit the 80-cols limit.

Feb 1 2017, 3:32 PM
krytarowski accepted D29406: Unify PlatformPOSIX::ResolveExecutable.
Feb 1 2017, 12:33 PM
krytarowski added a comment to D29406: Unify PlatformPOSIX::ResolveExecutable.

It looks good.

Feb 1 2017, 11:12 AM
krytarowski added a comment to D29405: Install six.py conditionally.

It does not seem to work for me. I get this when I run ninja check-lldb in the build directory:

Traceback (most recent call last):
  File "/usr/local/google/home/labath/ll/llvm/tools/lldb/test/dotest.py", line 6, in <module>
    import lldbsuite.test
  File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/__init__.py", line 5, in <module>
    from . import dotest
  File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/dotest.py", line 36, in <module>
    from lldb import six
ImportError: No module named lldb

Any idea what could be the cause?

Feb 1 2017, 11:10 AM · Restricted Project
krytarowski updated the summary of D29405: Install six.py conditionally.
Feb 1 2017, 10:49 AM · Restricted Project
krytarowski added a comment to D29405: Install six.py conditionally.

Please help to test this patch for regressions, at the moment I don't have all the test suits passing and I might have miss something.

Feb 1 2017, 10:47 AM · Restricted Project
krytarowski created D29405: Install six.py conditionally.
Feb 1 2017, 10:45 AM · Restricted Project
krytarowski created D29403: Fix multi-process-driver.cpp build on NetBSD.
Feb 1 2017, 10:19 AM · Restricted Project