krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (129 w, 4 d)

Recent Activity

Today

krytarowski abandoned D43614: Define _PTHREADS for -pthread on NetBSD.

As discussed with Joerg, _PTHREADS is considered legacy and we can bear with lack of it and inconsistency with GCC.

Fri, Feb 23, 5:47 AM · Restricted Project

Yesterday

krytarowski added reviewers for D43613: Msan, cmake configuration changes: emaste, dim.

Naively looking at https://hardenedbsd.org/content/easy-feature-comparison PIE on FreeBSD might need more work.

Thu, Feb 22, 3:38 PM
krytarowski created D43614: Define _PTHREADS for -pthread on NetBSD.
Thu, Feb 22, 2:43 AM · Restricted Project

Tue, Feb 20

krytarowski created D43543: Add new interceptors: getnetent(3) family.
Tue, Feb 20, 7:30 PM · Restricted Project
krytarowski created D43541: Add new interceptors: getprotoent(3) family.
Tue, Feb 20, 5:55 PM · Restricted Project
krytarowski created D43539: Add new interceptors: getttyent(3) family.
Tue, Feb 20, 5:04 PM · Restricted Project
krytarowski added inline comments to D43482: Add new interceptor: fgetln(3).
Tue, Feb 20, 7:51 AM · Restricted Project

Mon, Feb 19

krytarowski added a comment to D43168: Don't use -ldl on BSD.

If I read the CMake's source code correctly, just including find_package(Threads) is enough to set OS specific flags.

https://github.com/Kitware/CMake/blob/9a509099f77ed32a0845e4e3fad7b8f1eb9be10b/Modules/FindThreads.cmake

Mon, Feb 19, 9:47 PM
krytarowski added a comment to D43168: Don't use -ldl on BSD.

If I read the CMake's source code correctly, just including find_package(Threads) is enough to set OS specific flags.

Mon, Feb 19, 9:44 PM
krytarowski added a comment to D43168: Don't use -ldl on BSD.

-pthreads defines additional OS specific flags like _REENTRANT or _PTHREADS and this is the form that should be used.

Mon, Feb 19, 9:26 PM
krytarowski added a comment to D43490: Stop intercepting forkpty(3) and openpty(3) on NetBSD.

This also covers FreeBSD.

Mon, Feb 19, 3:10 PM · Restricted Project
krytarowski created D43490: Stop intercepting forkpty(3) and openpty(3) on NetBSD.
Mon, Feb 19, 3:10 PM · Restricted Project
krytarowski retitled D43482: Add new interceptor: fgetln(3) from Add new interceptor: fgetln(2) to Add new interceptor: fgetln(3).
Mon, Feb 19, 2:51 PM · Restricted Project
krytarowski created D43485: Add new interceptor: strmode(3).
Mon, Feb 19, 2:51 PM · Restricted Project
krytarowski created D43482: Add new interceptor: fgetln(3).
Mon, Feb 19, 2:16 PM · Restricted Project
krytarowski updated the diff for D42020: Correct ctype(3) functions with NLS on NetBSD.
  • add test
  • split netbsd specific code to a new function
Mon, Feb 19, 1:14 PM · Restricted Project

Fri, Feb 16

krytarowski added inline comments to D43021: Recognize all NetBSD architectures in UBSan.
Fri, Feb 16, 11:26 AM · Restricted Project

Thu, Feb 15

krytarowski added a comment to D43370: Add initial XRay support for NetBSD.

LGTM -- though @mclow.lists had mentioned that there were breakages due to the original FreeBSD change ignoring Darwin/macOS builds?

Thu, Feb 15, 10:13 PM · Restricted Project
krytarowski retitled D43370: Add initial XRay support for NetBSD from Add XRay support for NetBSD to Add initial XRay support for NetBSD.
Thu, Feb 15, 9:47 PM · Restricted Project
krytarowski added a comment to D43370: Add initial XRay support for NetBSD.
Thu, Feb 15, 9:42 PM · Restricted Project
krytarowski created D43370: Add initial XRay support for NetBSD.
Thu, Feb 15, 9:34 PM · Restricted Project
krytarowski abandoned D41588: Add NetBSD syscall hooks in sanitizers.

Committed in two commits:

Thu, Feb 15, 7:27 PM · Restricted Project
krytarowski retitled D43021: Recognize all NetBSD architectures in UBSan from Recognize a buch of CPU/NetBSD ports of GetPcSpBp() to Recognize all NetBSD architectures in UBSan.
Thu, Feb 15, 6:02 PM · Restricted Project
krytarowski updated the diff for D43021: Recognize all NetBSD architectures in UBSan.
  • use _UC_MACHINE_FP() for all NetBSD architectures
  • cover all NetBSD architectures with the same code in GetPcSpBp()
  • remove check for CPU types in lib/ubsan/ubsan_platform.h
Thu, Feb 15, 6:01 PM · Restricted Project
krytarowski added inline comments to D42020: Correct ctype(3) functions with NLS on NetBSD.
Thu, Feb 15, 11:05 AM · Restricted Project
krytarowski added a comment to D42048: Add NetBSD syscall hooks skeleton in sanitizers.

I've decided after evaluations that I will commit NetBSD-only code with the bodies of syscalls without review. As the amounts of code are not really reviewable in reasonable timeframe (over 11k lines of diff). It would be a fulltime effort of few months, but right now nobody can keep reviewing it in this mode.

Thu, Feb 15, 7:20 AM · Restricted Project

Wed, Feb 14

krytarowski updated the diff for D41636: Teach sanitizer about NetBSD specific ioctl(2) calls.

Rename sanitizer_netbsd_interceptors_ioctl.inc to sanitizer_interceptors_ioctl_netbsd.inc
Handle one more ioctl(2) from new NetBSD HEAD: RF_ProgressInfo_t

Wed, Feb 14, 7:34 PM · Restricted Project
krytarowski updated the summary of D42048: Add NetBSD syscall hooks skeleton in sanitizers.
Wed, Feb 14, 6:33 PM · Restricted Project
krytarowski updated the diff for D42048: Add NetBSD syscall hooks skeleton in sanitizers.

Rename sanitizer_netbsd_syscalls.inc to sanitizer_syscalls_netbsd.inc

Wed, Feb 14, 6:33 PM · Restricted Project
krytarowski added inline comments to D41636: Teach sanitizer about NetBSD specific ioctl(2) calls.
Wed, Feb 14, 5:48 PM · Restricted Project
krytarowski added a comment to D42048: Add NetBSD syscall hooks skeleton in sanitizers.

@vitalybuka who could review this? I can land this code as is without a reviewer and ask for review for newer patches in the same topic.

Wed, Feb 14, 5:25 PM · Restricted Project

Tue, Feb 13

krytarowski added a comment to D42048: Add NetBSD syscall hooks skeleton in sanitizers.

ping? x6

Tue, Feb 13, 3:18 PM · Restricted Project
krytarowski added a comment to D42883: Prevent recursive MSan interceptors in strftime(3) like functions.

ping?

Tue, Feb 13, 3:18 PM · Restricted Project
krytarowski added a comment to D42884: Prevent recursive MSan interceptors in fgets(3).

ping?

Tue, Feb 13, 3:15 PM · Restricted Project
krytarowski added a comment to D42909: Add new interceptor: lstat(2).

Ping?

Tue, Feb 13, 3:13 PM · Restricted Project
krytarowski added a reviewer for D42909: Add new interceptor: lstat(2): eugenis.
Tue, Feb 13, 3:13 PM · Restricted Project

Mon, Feb 12

krytarowski added a comment to D43168: Don't use -ldl on BSD.

NetBSD's libc has stubs for threading functions (weak references), but it cannot work as long as there is no linking with -lpthread (with GCC syntax: -pthread).
The -lpthread form shouldn't be used as is in FreeBSD the threading function is called something like -lthr (in NetBSD it's called libpthread.{so,a}).
-lstdc++ on NetBSD is required to get linked with -lpthread in order to get related functions functional (without them, there is abort with a message).

Mon, Feb 12, 10:56 AM
krytarowski added a comment to D43168: Don't use -ldl on BSD.

For such options there are designed other options, like CMAKE_EXE_LINKER_FLAGS. target_link_libraries() should be used for libraries.

Mon, Feb 12, 9:52 AM

Sun, Feb 11

krytarowski planned changes to D42870: Correct recognition of NetBSD images.

I will be back to this once I will be done with debugging client-server connectivity issues (unrelated to this patch).

Sun, Feb 11, 12:09 PM
krytarowski added a comment to D43169: Include <sys/time.h> to get struct timeval definition.

Looks good.

Sun, Feb 11, 12:06 PM
krytarowski accepted D43168: Don't use -ldl on BSD.

Please update description.

Sun, Feb 11, 12:06 PM
krytarowski added a comment to D43168: Don't use -ldl on BSD.

I've tested this in a hello world application on NetBSD and a remote Linux shell and it worked for me.

Sun, Feb 11, 10:16 AM
krytarowski added a comment to D43168: Don't use -ldl on BSD.

Something along these lines should do the trick:

Sun, Feb 11, 10:11 AM
krytarowski added a comment to D43168: Don't use -ldl on BSD.

CMAKE_DL_LIBS allows us to fix it once for everybody and forever.

Sun, Feb 11, 7:29 AM
krytarowski added a comment to D43168: Don't use -ldl on BSD.

Can we use CMAKE_DL_LIBS?

Sun, Feb 11, 7:06 AM

Sat, Feb 10

krytarowski added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.

If we remove INTERCEPT_FUNCTION(atexit); does it work?

Sat, Feb 10, 3:53 PM · Restricted Project
krytarowski added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.

Thanks for testing!

Sat, Feb 10, 1:50 PM · Restricted Project
krytarowski planned changes to D40714: Correct atexit(3) support in MSan/NetBSD.

I see, with guessing I won't go far. I will reschedule it for later once I will get an access to a Linux host capable to build LLVM.

Sat, Feb 10, 1:25 PM · Restricted Project
krytarowski added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.

This patch without InterceptorScope interceptor_scope; works, and this patch with InterceptorScope interceptor_scope; doesn't work?

Sat, Feb 10, 1:06 PM · Restricted Project
krytarowski added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.

I set InterceptorScope interceptor_scope;, maybe it's enough.

Sat, Feb 10, 12:52 PM · Restricted Project
krytarowski updated the diff for D40714: Correct atexit(3) support in MSan/NetBSD.

Intercept atexit.

Sat, Feb 10, 12:49 PM · Restricted Project
krytarowski updated the diff for D40714: Correct atexit(3) support in MSan/NetBSD.
  • don't set REAL(atexit) to notreachable
Sat, Feb 10, 12:45 PM · Restricted Project
krytarowski added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.

Please test. Thank you in advance.

I had updated my compiler-rt tree before this update and it finally worked but with this diff it still failed (I see the new message "unreachable called" for each test). Would be good if a genuine Linux developer could confirm.

Sat, Feb 10, 10:36 AM · Restricted Project
krytarowski updated the diff for D40714: Correct atexit(3) support in MSan/NetBSD.
  • set REAL(atexit) in lib/msan/msan.cc
Sat, Feb 10, 10:36 AM · Restricted Project
krytarowski updated the diff for D40714: Correct atexit(3) support in MSan/NetBSD.
  • add InterceptorScope interceptor_scope; in __cxa_atexit
Sat, Feb 10, 10:22 AM · Restricted Project
krytarowski added a comment to D40714: Correct atexit(3) support in MSan/NetBSD.

Please test. Thank you in advance.

Sat, Feb 10, 10:14 AM · Restricted Project
krytarowski updated the diff for D40714: Correct atexit(3) support in MSan/NetBSD.
  • add interceptor_scope in atexit interceptor
  • correct ThreadSanitizer -> MemorySanitizer
Sat, Feb 10, 10:10 AM · Restricted Project
krytarowski updated the diff for D40714: Correct atexit(3) support in MSan/NetBSD.
  • disable atexit(3) interceptor
Sat, Feb 10, 9:58 AM · Restricted Project
krytarowski requested review of D41013: Fix test/msan/textdomain.cc on NetBSD.
Sat, Feb 10, 6:43 AM · Restricted Project
krytarowski closed D41013: Fix test/msan/textdomain.cc on NetBSD.
Sat, Feb 10, 6:43 AM · Restricted Project
krytarowski added a comment to D41013: Fix test/msan/textdomain.cc on NetBSD.
Author: kamil
Date: Sat Feb 10 06:36:55 2018
New Revision: 324810
Sat, Feb 10, 6:41 AM · Restricted Project

Fri, Feb 9

krytarowski added a comment to D41013: Fix test/msan/textdomain.cc on NetBSD.

Perhaps the proper solution is mark this test as UNSUPPORTED for BSDs and assume that -ltint library has been prebuilt with sanitizers.

Fri, Feb 9, 2:14 PM · Restricted Project

Wed, Feb 7

krytarowski added a comment to D43021: Recognize all NetBSD architectures in UBSan.

I've proposed this patch in the NetBSD source code:

Wed, Feb 7, 11:47 AM · Restricted Project
krytarowski added a comment to D43021: Recognize all NetBSD architectures in UBSan.

How about the CAN_SANITIZER_UB part?

Wed, Feb 7, 8:33 AM · Restricted Project
krytarowski added a comment to D43021: Recognize all NetBSD architectures in UBSan.

There is an option to to attempt to push _UC_MACHINE_BP to the sources of NetBSD for all ports.

Wed, Feb 7, 8:28 AM · Restricted Project
krytarowski added a comment to D42048: Add NetBSD syscall hooks skeleton in sanitizers.

ping x5

Wed, Feb 7, 8:02 AM · Restricted Project
krytarowski created D43021: Recognize all NetBSD architectures in UBSan.
Wed, Feb 7, 7:32 AM · Restricted Project
krytarowski added inline comments to D42963: Add initial ld.lld.1 man page.
Wed, Feb 7, 6:49 AM

Tue, Feb 6

krytarowski added inline comments to D42963: Add initial ld.lld.1 man page.
Tue, Feb 6, 9:47 AM

Mon, Feb 5

krytarowski closed D42912: Sync PlatformNetBSD.cpp with Linux.
Mon, Feb 5, 9:14 AM
krytarowski updated the summary of D42912: Sync PlatformNetBSD.cpp with Linux.
Mon, Feb 5, 8:56 AM
krytarowski created D42912: Sync PlatformNetBSD.cpp with Linux.
Mon, Feb 5, 8:56 AM
krytarowski created D42909: Add new interceptor: lstat(2).
Mon, Feb 5, 7:45 AM · Restricted Project
krytarowski closed D42868: Fix a crash in *NetBSD::Factory::Launch.
Mon, Feb 5, 5:19 AM

Sat, Feb 3

krytarowski created D42884: Prevent recursive MSan interceptors in fgets(3).
Sat, Feb 3, 10:12 AM · Restricted Project
krytarowski retitled D42883: Prevent recursive MSan interceptors in strftime(3) like functions from Prevent recirsuve MSan interceptors in strftime(3) like functions to Prevent recursive MSan interceptors in strftime(3) like functions.
Sat, Feb 3, 10:08 AM · Restricted Project
krytarowski created D42883: Prevent recursive MSan interceptors in strftime(3) like functions.
Sat, Feb 3, 10:05 AM · Restricted Project

Fri, Feb 2

krytarowski added a comment to D42870: Correct recognition of NetBSD images.

Is there a working example of this? I would clone an existing code for Linux or other supported OS and adapt it for NetBSD.

Fri, Feb 2, 3:32 PM
krytarowski added a comment to D42870: Correct recognition of NetBSD images.

What would the test do?

Fri, Feb 2, 3:09 PM
krytarowski updated the diff for D42868: Fix a crash in *NetBSD::Factory::Launch.
Fri, Feb 2, 2:55 PM
krytarowski updated the summary of D42868: Fix a crash in *NetBSD::Factory::Launch.
Fri, Feb 2, 2:54 PM
krytarowski added inline comments to D42868: Fix a crash in *NetBSD::Factory::Launch.
Fri, Feb 2, 2:35 PM
krytarowski added a comment to D42870: Correct recognition of NetBSD images.

Extracted from: D32149.

Fri, Feb 2, 2:26 PM
krytarowski created D42870: Correct recognition of NetBSD images.
Fri, Feb 2, 2:26 PM
krytarowski added a comment to D42868: Fix a crash in *NetBSD::Factory::Launch.
(gdb) r
Starting program: /public/llvm-build/bin/lldb-server g \*:1234 -- /usr/bin/look
[New process 15150]
Fri, Feb 2, 2:16 PM
krytarowski updated the summary of D42868: Fix a crash in *NetBSD::Factory::Launch.
Fri, Feb 2, 2:11 PM
krytarowski created D42868: Fix a crash in *NetBSD::Factory::Launch.
Fri, Feb 2, 2:11 PM
krytarowski added inline comments to D42053: Add new NetBSD interceptors: devname(3), devname_r(3).
Fri, Feb 2, 10:52 AM · Restricted Project
krytarowski added inline comments to D42053: Add new NetBSD interceptors: devname(3), devname_r(3).
Fri, Feb 2, 10:48 AM · Restricted Project
krytarowski updated the diff for D42053: Add new NetBSD interceptors: devname(3), devname_r(3).

correct tests

Fri, Feb 2, 10:44 AM · Restricted Project
krytarowski updated the diff for D42053: Add new NetBSD interceptors: devname(3), devname_r(3).
  • rebase to HEAD
  • add tests
Fri, Feb 2, 8:07 AM · Restricted Project

Thu, Feb 1

krytarowski added a comment to D42048: Add NetBSD syscall hooks skeleton in sanitizers.

Can we start upstreaming this one? I will keep pushing 1 syscall with 1 patch proposal with attached tests.

Thu, Feb 1, 4:28 PM · Restricted Project
krytarowski updated the diff for D42061: Add new interceptors: strlcpy(3) and strlcat(3).

Apply comments from review.
git-clang-format over tests.

Thu, Feb 1, 3:20 PM · Restricted Project
krytarowski added inline comments to D42061: Add new interceptors: strlcpy(3) and strlcat(3).
Thu, Feb 1, 3:12 PM · Restricted Project
krytarowski updated the diff for D42061: Add new interceptors: strlcpy(3) and strlcat(3).

Apply comments from review.

Thu, Feb 1, 3:10 PM · Restricted Project
krytarowski added inline comments to D42061: Add new interceptors: strlcpy(3) and strlcat(3).
Thu, Feb 1, 2:24 PM · Restricted Project
krytarowski added a comment to D42061: Add new interceptors: strlcpy(3) and strlcat(3).

Should be done.

Thu, Feb 1, 11:39 AM · Restricted Project
krytarowski added a comment to D42702: Fix llvm-config --system-libs output on FreeBSD and NetBSD.

I propose to stop using FindBacktrace.cmake and replace it with a manual check.

Thu, Feb 1, 11:39 AM
krytarowski updated the diff for D42061: Add new interceptors: strlcpy(3) and strlcat(3).
  • use COMMON_INTERCEPTOR_COPY_STRING().
  • use COMMON_INTERCEPTOR_READ_STRING()
Thu, Feb 1, 11:36 AM · Restricted Project
krytarowski added a comment to D42702: Fix llvm-config --system-libs output on FreeBSD and NetBSD.
$ llvm-config --link-static --system-libs
-lz -lrt -l/usr/lib/libexecinfo.so -lterminfo -lpthread -lm
Thu, Feb 1, 10:51 AM