Page MenuHomePhabricator

krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (215 w, 3 d)

Recent Activity

Tue, Sep 24

krytarowski committed rGb2077fdc3723: [tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM (authored by krytarowski).
[tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM
Tue, Sep 24, 4:24 AM

Mon, Sep 23

krytarowski added a comment to D67908: [tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM.

Interesting - I had tried to add has_feature for lsan to clang in the past and couldn’t get the change accepted. Nice to see it works now :)

Mon, Sep 23, 5:17 AM · Restricted Project
krytarowski updated subscribers of D67908: [tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM.

Once GCC will grow support for __SANITIZER_LEAK__ (already pending in review) there will be include as a separate patch support for LSan/GCC.

Mon, Sep 23, 5:02 AM · Restricted Project
krytarowski created D67908: [tblgen] Disable Leak detection for ASan/GCC and LSan/LLVM.
Mon, Sep 23, 5:02 AM · Restricted Project

Sat, Sep 21

Herald added a project to D52386: [Lexer] Add udefined_behavior_sanitizer feature: Restricted Project.

This is needed in the NetBSD kernel, more fine-grained checks would be acceptable too, but one global feature detection is what I need.

Sat, Sep 21, 4:03 AM · Restricted Project, Restricted Project
krytarowski accepted D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer).
Sat, Sep 21, 3:50 AM · Restricted Project
krytarowski committed rG1b58389428ed: Add __lsan::ScopedInterceptorDisabler for strerror(3) (authored by krytarowski).
Add __lsan::ScopedInterceptorDisabler for strerror(3)
Sat, Sep 21, 12:45 AM
krytarowski committed rG5fe1e55d3541: Avoid memory leak in ASan test (authored by krytarowski).
Avoid memory leak in ASan test
Sat, Sep 21, 12:43 AM
krytarowski committed rG882704755157: Stop tracking atexit/__cxa_atexit/pthread_atfork allocations in LSan/NetBSD (authored by krytarowski).
Stop tracking atexit/__cxa_atexit/pthread_atfork allocations in LSan/NetBSD
Sat, Sep 21, 12:31 AM

Fri, Sep 20

krytarowski added a comment to D67331: Stop tracking atexit/__cxa_atexit/pthread_atfork allocations in LSan/NetBSD.

With these patches included there are still ~3 failing tests and I will mark them as XFAIL for now.

Fri, Sep 20, 5:07 PM · Restricted Project, Restricted Project
krytarowski added a comment to D67331: Stop tracking atexit/__cxa_atexit/pthread_atfork allocations in LSan/NetBSD.

Tests?

Fri, Sep 20, 5:05 PM · Restricted Project, Restricted Project
krytarowski added a comment to D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer).

Looks good to me but I will leave the final decision to someone else.

Fri, Sep 20, 9:55 AM · Restricted Project

Tue, Sep 17

krytarowski added inline comments to D67337: Add __lsan::ScopedInterceptorDisabler for strerror(3).
Tue, Sep 17, 4:42 PM · Restricted Project, Restricted Project

Sep 16 2019

krytarowski added inline comments to D67331: Stop tracking atexit/__cxa_atexit/pthread_atfork allocations in LSan/NetBSD.
Sep 16 2019, 5:45 PM · Restricted Project, Restricted Project
krytarowski updated the diff for D67331: Stop tracking atexit/__cxa_atexit/pthread_atfork allocations in LSan/NetBSD.
  • apply changes from review
Sep 16 2019, 5:45 PM · Restricted Project, Restricted Project
krytarowski updated the diff for D67337: Add __lsan::ScopedInterceptorDisabler for strerror(3).
  • apply changes from review
Sep 16 2019, 5:40 PM · Restricted Project, Restricted Project

Sep 15 2019

krytarowski committed rGf7877dd4b637: Commit missing part of "Split many_tls_keys.cpp into two tests" (authored by krytarowski).
Commit missing part of "Split many_tls_keys.cpp into two tests"
Sep 15 2019, 2:06 PM

Sep 12 2019

krytarowski committed rG02519fc7a6f8: Add getauxval() compat for NetBSD (authored by krytarowski).
Add getauxval() compat for NetBSD
Sep 12 2019, 12:05 PM
krytarowski committed rGd2e0f207aa53: Split many_tls_keys.cpp into two tests (authored by krytarowski).
Split many_tls_keys.cpp into two tests
Sep 12 2019, 11:55 AM
krytarowski added inline comments to D67329: Add getauxval() compat for NetBSD.
Sep 12 2019, 11:36 AM · Restricted Project, Restricted Project

Sep 11 2019

krytarowski updated the diff for D67337: Add __lsan::ScopedInterceptorDisabler for strerror(3).
  • restrict __lsan::ScopedInterceptorDisabler to ASan and LSan
Sep 11 2019, 8:00 AM · Restricted Project, Restricted Project

Sep 10 2019

krytarowski created D67428: Split many_tls_keys.cpp into two tests.
Sep 10 2019, 6:23 PM · Restricted Project, Restricted Project
krytarowski committed rG8b83f50c034d: Remove xfail i386 NetBSD mark in vptr-non-unique-typeinfo.cpp (authored by krytarowski).
Remove xfail i386 NetBSD mark in vptr-non-unique-typeinfo.cpp
Sep 10 2019, 4:59 PM
krytarowski committed rG0910a03bc25e: Remove xfail NetBSD mark from ignored-interceptors-mmap.cpp (authored by krytarowski).
Remove xfail NetBSD mark from ignored-interceptors-mmap.cpp
Sep 10 2019, 4:43 PM

Sep 8 2019

krytarowski committed rGdd0c00b5f8b3: Enable LSan for NetBSD/i386 in test/asan/lit.cfg.py (authored by krytarowski).
Enable LSan for NetBSD/i386 in test/asan/lit.cfg.py
Sep 8 2019, 4:53 PM
krytarowski created D67337: Add __lsan::ScopedInterceptorDisabler for strerror(3).
Sep 8 2019, 4:38 PM · Restricted Project, Restricted Project
krytarowski committed rGdef6ca8b330f: Enable LSan tests for NetBSD/i386 (authored by krytarowski).
Enable LSan tests for NetBSD/i386
Sep 8 2019, 10:12 AM
krytarowski created D67331: Stop tracking atexit/__cxa_atexit/pthread_atfork allocations in LSan/NetBSD.
Sep 8 2019, 9:25 AM · Restricted Project, Restricted Project
krytarowski committed rG90d2be0163e8: Stop marking 5 ASan tests as failing on NetBSD/i386 (authored by krytarowski).
Stop marking 5 ASan tests as failing on NetBSD/i386
Sep 8 2019, 9:20 AM
krytarowski added a comment to D67330: Avoid memory leak in ASan test.
=================================================================
==371==ERROR: LeakSanitizer: detected memory leaks
Sep 8 2019, 9:11 AM · Restricted Project, Restricted Project
krytarowski committed rG14f1990921f7: Enable leak-detection for NetBSD/amd64 in test/asan (authored by krytarowski).
Enable leak-detection for NetBSD/amd64 in test/asan
Sep 8 2019, 8:54 AM
krytarowski created D67330: Avoid memory leak in ASan test.
Sep 8 2019, 8:50 AM · Restricted Project, Restricted Project
krytarowski created D67329: Add getauxval() compat for NetBSD.
Sep 8 2019, 8:36 AM · Restricted Project, Restricted Project
krytarowski committed rGc8afbf3d95d4: Do not intercept malloc_usable_size on NetBSD (authored by krytarowski).
Do not intercept malloc_usable_size on NetBSD
Sep 8 2019, 8:02 AM

Sep 3 2019

krytarowski added a comment to D66361: Improve behavior in the case of stack exhaustion..

Test disabled for NetBSD in r370801. If you're interested in investigating why this isn't working there, feel free, but this is only a best-effort mitigation for the case where things have already gone wrong, so there are limits to how much effort it makes sense to resolve this.

Does NetBSD set a hard stack rlimit of less than 8MB by any chance?

Sep 3 2019, 5:59 PM · Restricted Project
krytarowski added a comment to D66361: Improve behavior in the case of stack exhaustion..

This change broke on NetBSD.

Sep 3 2019, 10:28 AM · Restricted Project
krytarowski added a comment to D66566: [lldb] Replace std::once_flag with llvm::once_flag..

This breaks NetBSD as it shall be paired with llvm::call_once.

Sep 3 2019, 4:52 AM · Restricted Project, Restricted Project

Aug 7 2019

krytarowski committed rG42ae6fecd405: Sync ioctl(2) list with NetBSD 9.99.3 (authored by krytarowski).
Sync ioctl(2) list with NetBSD 9.99.3
Aug 7 2019, 7:22 PM
krytarowski committed rG9d161896a16c: Update generate_netbsd_ioctls.awk for NetBSD 9.99.3 (authored by krytarowski).
Update generate_netbsd_ioctls.awk for NetBSD 9.99.3
Aug 7 2019, 7:09 PM
krytarowski committed rG72c940417aa5: Restrict the NetBSD ASan TSD fallback to !ASAN_DYNAMIC (authored by krytarowski).
Restrict the NetBSD ASan TSD fallback to !ASAN_DYNAMIC
Aug 7 2019, 3:00 PM

Aug 4 2019

krytarowski added inline comments to D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP].
Aug 4 2019, 9:24 AM

Jul 30 2019

krytarowski added inline comments to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.
Jul 30 2019, 1:02 PM · Restricted Project, Restricted Project
krytarowski accepted D64488: [Driver] Support -fsanitize=function on Solaris/x86.
Jul 30 2019, 12:58 PM · Restricted Project, Restricted Project, Restricted Project
krytarowski added a comment to D64488: [Driver] Support -fsanitize=function on Solaris/x86.
In D64488#1606758, @ro wrote:

Something is broken between reviews. and my mailbox as I am not receiving any e-mails so pinging does not make any effect... no LLVM admin replied to my questions on this to validate whether my mail was blacklisted or similar. I have decided to change server of my mailbox and workaround it.

Maybe this is related to other reviews.llvm.org issues during the weekend where you couldn't update reviews with strange table full
errors?

Jul 30 2019, 12:57 PM · Restricted Project, Restricted Project, Restricted Project
krytarowski added a comment to D64488: [Driver] Support -fsanitize=function on Solaris/x86.

Something is broken between reviews. and my mailbox as I am not receiving any e-mails so pinging does not make any effect... no LLVM admin replied to my questions on this to validate whether my mail was blacklisted or similar. I have decided to change server of my mailbox and workaround it.

Jul 30 2019, 11:08 AM · Restricted Project, Restricted Project, Restricted Project

Jul 28 2019

krytarowski added inline comments to D65221: [Sanitizer][ASAN][MSAN] Fix infinite recursion on FreeBSD.
Jul 28 2019, 3:04 PM · Restricted Project, Restricted Project

Jul 13 2019

krytarowski added inline comments to D64647: <WIP> [lldb] [Process/NetBSD] Multithread support.
Jul 13 2019, 2:35 AM · Restricted Project
krytarowski added a comment to D64647: <WIP> [lldb] [Process/NetBSD] Multithread support.

Something that we do not cover here is that once a tracee reports a signal (like someone poked it with SIGUSR1) and we want to pass it over to the tracee, we will reset siginfo.

This scenario should be covered by a test and we should handle it properly..

The solution in NetBSD for passing over signals without changing siginfo, is to not calling PT_SET_SIGINFO as the default one will be kept by the kernel. Optionally pick old siginfo with PT_GET_SIGINFO and optionally change destination lwp.

How is 'properly'? Should we reject resuming with a signal when there's already another signal pending?

Jul 13 2019, 2:26 AM · Restricted Project

Jul 12 2019

krytarowski added a comment to D64647: <WIP> [lldb] [Process/NetBSD] Multithread support.

Something that we do not cover here is that once a tracee reports a signal (like someone poked it with SIGUSR1) and we want to pass it over to the tracee, we will reset siginfo.

Jul 12 2019, 12:57 PM · Restricted Project
krytarowski added inline comments to D64647: <WIP> [lldb] [Process/NetBSD] Multithread support.
Jul 12 2019, 12:51 PM · Restricted Project
krytarowski added a comment to D64647: <WIP> [lldb] [Process/NetBSD] Multithread support.

I think it looks OK. there are some nits that could be optimized in future or handled additionally.. but for now it should be fine.

Jul 12 2019, 10:44 AM · Restricted Project

Jul 11 2019

krytarowski added a comment to D64057: Add NetBSD LSan support.

I've landed this version as it is good enough to land LLVM-9.

Unfortunately many tests fail as they seem to be tuned for Linux/Darwin.

Please see:

https://reviews.llvm.org/D64057#1565937

@vitalybuka how to address these problems?

Can you show how the tests *fail*>
I.e. what is the diff between expected and actual output?

Jul 11 2019, 1:20 AM · Restricted Project

Jul 10 2019

krytarowski added a comment to D64057: Add NetBSD LSan support.

I've landed this version as it is good enough to land LLVM-9.

Jul 10 2019, 11:48 PM · Restricted Project
krytarowski committed rG983d7ddd0b27: Add NetBSD LSan support (authored by krytarowski).
Add NetBSD LSan support
Jul 10 2019, 11:23 PM
krytarowski updated the diff for D64057: Add NetBSD LSan support.
  • switch the protype of internal_ptrace() to the one matching NetBSD
  • move the stop-the-world implementation for NetBSD into a separate file
  • minor changes
Jul 10 2019, 1:52 AM · Restricted Project

Jul 8 2019

krytarowski added inline comments to D64057: Add NetBSD LSan support.
Jul 8 2019, 11:53 PM · Restricted Project

Jul 7 2019

krytarowski added a reviewer for D64057: Add NetBSD LSan support: joerg.
Jul 7 2019, 6:33 AM · Restricted Project
krytarowski added a comment to D64057: Add NetBSD LSan support.

Ping? There is planned LLVM branching soon and I would like to see this in LLVM 9.0.

Jul 7 2019, 6:33 AM · Restricted Project

Jul 3 2019

krytarowski added a comment to D64057: Add NetBSD LSan support.

Testing notification e-mails from phabricator.

Jul 3 2019, 2:47 PM · Restricted Project

Jul 2 2019

krytarowski added a comment to D56650: [lld] [ELF] Support customizing behavior on target triple.

Personally I am opposed to this change. The compiler driver (gcc,clang) has a set of arch/OS dependent defaults. It seems weird/redundant to add another sets of defaults on the linker side.

Jul 2 2019, 8:04 AM

Jul 1 2019

krytarowski accepted D63888: [llvm] [Support] Clean PrintStackTrace() ptr arithmetic up.
Jul 1 2019, 8:05 PM · Restricted Project
krytarowski added a comment to D64057: Add NetBSD LSan support.

This code in general works.. however the tests are not compatible with NetBSD.

Jul 1 2019, 7:34 PM · Restricted Project
krytarowski updated the diff for D64057: Add NetBSD LSan support.
  • Fixup style.
Jul 1 2019, 7:29 PM · Restricted Project
krytarowski created D64057: Add NetBSD LSan support.
Jul 1 2019, 7:21 PM · Restricted Project
krytarowski added a comment to D56650: [lld] [ELF] Support customizing behavior on target triple.

@ruiu ping?

Jul 1 2019, 8:45 AM
krytarowski accepted D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.
Jul 1 2019, 7:52 AM · Restricted Project
krytarowski added a comment to D63792: [lldb] [Process/NetBSD] Use global enable bits for watchpoints.

I would follow the same kernel behavior here as Linux, but that can be done independently.

Jul 1 2019, 7:51 AM · Restricted Project
krytarowski accepted D63791: [lldb] [Process/NetBSD] Fix segfault when handling watchpoint.
Jul 1 2019, 7:47 AM · Restricted Project
krytarowski accepted D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.
Jul 1 2019, 7:41 AM · Restricted Project

Jun 20 2019

krytarowski added inline comments to D63545: [lldb] [Process/NetBSD] Support reading YMM registers via PT_*XSTATE.
Jun 20 2019, 9:16 AM · Restricted Project

Jun 19 2019

krytarowski accepted D63554: [lldb] [Process/NetBSD] Remove unnecessary FPU presence checks for x86_64.
Jun 19 2019, 7:57 AM · Restricted Project

Jun 17 2019

krytarowski added a comment to D63380: [lldb] [test] Skip watchpoint tests on NetBSD if userdbregs is disabled.

This check should contain additional check for uid==root. If we are root we can read and write to DB registers.

Jun 17 2019, 5:15 AM · Restricted Project

Jun 13 2019

krytarowski added a comment to D62502: Implement xfer:libraries-svr4:read packet.

I would leave the NetBSD version as it is in this patch and let us to fix/test it later.

Jun 13 2019, 6:48 AM · Restricted Project, Restricted Project

Jun 10 2019

krytarowski added a comment to D62713: [MIR-Canon] Hardening propagateLocalCopies..

This change makes NetBSD buildbot flaky.

Jun 10 2019, 10:15 AM · Restricted Project
krytarowski added a comment to D62502: Implement xfer:libraries-svr4:read packet.

In general this code should be close to functional on NetBSD (if not already compatible).

Jun 10 2019, 8:16 AM · Restricted Project, Restricted Project

Jun 9 2019

krytarowski accepted D63054: [lldb] [Process/NetBSD] Fix error handling in register operations.
Jun 9 2019, 5:38 AM · Restricted Project

Jun 4 2019

krytarowski added a comment to D59744: Fix i386 ABI "__m64" type bug.

Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend any effort dealing with the ramifications of ABI breaks (as discussed in https://reviews.llvm.org/D60748) at present, I only fix the bug for Linux. If other system wants the fix, the only thing needed is to add a flag (like "IsLinuxABI" ) to enable it.

CC @mgorny and @joerg - do we want this for NetBSD?

Probably yes. FWICS, gcc uses %mm0 and %mm1 on NetBSD while clang doesn't.

Jun 4 2019, 4:46 PM · Restricted Project, Restricted Project
krytarowski updated subscribers of D59744: Fix i386 ABI "__m64" type bug.

Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend any effort dealing with the ramifications of ABI breaks (as discussed in https://reviews.llvm.org/D60748) at present, I only fix the bug for Linux. If other system wants the fix, the only thing needed is to add a flag (like "IsLinuxABI" ) to enable it.

Jun 4 2019, 6:41 AM · Restricted Project, Restricted Project
krytarowski added a comment to D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps..

This commit breaks the NetBSD buildbot node.

Jun 4 2019, 6:36 AM · Restricted Project, Restricted Project

Jun 3 2019

krytarowski added a comment to D62773: [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test.

If we want to reject opening directories we shall do it during open(2)/fopen(3).

Jun 3 2019, 8:04 AM · Restricted Project

Jun 2 2019

krytarowski added a comment to D59744: Fix i386 ABI "__m64" type bug.

sysv abi is not only for UNIX but most non-Windows ones (BSDs, HAIKU, ...).

Jun 2 2019, 1:50 AM · Restricted Project, Restricted Project

Jun 1 2019

krytarowski added a comment to D62773: [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test.

whereas others emit "is a directory

Jun 1 2019, 9:23 AM · Restricted Project
krytarowski accepted D62773: [llvm] [test] Remove non-portable EISDIR test from macho-disassemble-g-dsym.test.
Jun 1 2019, 8:57 AM · Restricted Project

May 29 2019

krytarowski added a comment to D62499: Create a generic handler for Xfer packets.

One time just before it's loaded (so lldb can check which modules are loaded) and another right after it's loaded (so lldb can check again which ones are loaded and calculate the difference).

There is on NetBSD and on a selection of other OSs: _rtld_debug_state integrated as a part of ELF dynamic loader.

Is there something like that on Android that could be reused?

Yes, there is, and it's being used now. The question here is what do we do *after* we hit the dynamic loader breakpoint...

May 29 2019, 1:26 PM · Restricted Project, Restricted Project
krytarowski updated subscribers of D60748: Fix i386 struct and union parameter alignment.
May 29 2019, 2:36 AM · Restricted Project
krytarowski added a comment to D62499: Create a generic handler for Xfer packets.

One time just before it's loaded (so lldb can check which modules are loaded) and another right after it's loaded (so lldb can check again which ones are loaded and calculate the difference).

May 29 2019, 12:49 AM · Restricted Project, Restricted Project

May 25 2019

krytarowski accepted D62446: [openmp] [test] Skip omp_taskwait test on NetBSD.
May 25 2019, 12:35 AM

May 22 2019

krytarowski resigned from D62005: [libunwind] [test] Fix inferring source paths.

It is probably fine.. but I will defer review to lit/libc++ maintainers.

May 22 2019, 3:16 PM · Restricted Project

May 7 2019

krytarowski committed rG5d3548b85239: Fix build on NetBSD 8.99.38 (authored by krytarowski).
Fix build on NetBSD 8.99.38
May 7 2019, 5:43 PM

Apr 30 2019

krytarowski accepted D61310: [lldb] [Process/NetBSD] Fix handling piod_len from PT_IO calls.
Apr 30 2019, 8:39 AM · Restricted Project
krytarowski requested changes to D61310: [lldb] [Process/NetBSD] Fix handling piod_len from PT_IO calls.

I think there is a bug thought in the code.

Apr 30 2019, 7:09 AM · Restricted Project
krytarowski accepted D61310: [lldb] [Process/NetBSD] Fix handling piod_len from PT_IO calls.
Apr 30 2019, 7:01 AM · Restricted Project

Apr 25 2019

krytarowski accepted D61085: [lldb] [lit] Remove unnecessary array use in XMM reading test.
Apr 25 2019, 8:53 AM · Restricted Project

Apr 23 2019

krytarowski accepted D61021: Fix typos: (re)?sor?uce -> (re)?source.
Apr 23 2019, 11:06 AM · Restricted Project

Apr 17 2019

krytarowski added a comment to D60728: [clang] [test] Add a (xfailing) test for PR41027.

What's the value in checking in this xfail'ed test without an actual fix for the problem?

Raise awareness about the problem.

I don't think that works. No one is reading through the test files of the repository.

Apr 17 2019, 10:34 AM · Restricted Project

Apr 16 2019

krytarowski added a comment to D60728: [clang] [test] Add a (xfailing) test for PR41027.

What's the value in checking in this xfail'ed test without an actual fix for the problem?

Apr 16 2019, 8:36 AM · Restricted Project
krytarowski added a reviewer for D60728: [clang] [test] Add a (xfailing) test for PR41027: void.

Adding @void, regression introduced with D55616.

Apr 16 2019, 6:24 AM · Restricted Project
krytarowski added a comment to D55616: Emit ASM input in a constant context.

@void hi, this broke assembly code on NetBSD for various archs and blocks upgrade of the toolchain.

Apr 16 2019, 6:23 AM · Restricted Project

Apr 5 2019

krytarowski accepted D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.
Apr 5 2019, 1:03 PM · Restricted Project

Apr 2 2019

krytarowski added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

I think depending on CMAKE_THREAD_LIBS_INIT is the way to go. If it is broken for some platform internally, such OS has more issues than building OpenMP.

Apr 2 2019, 6:09 AM · Restricted Project, Restricted Project