Page MenuHomePhabricator

krytarowski (Kamil Rytarowski)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 30 2015, 11:51 AM (189 w, 5 d)

Recent Activity

Wed, Apr 17

krytarowski added a comment to D60728: [clang] [test] Add a (xfailing) test for PR41027.

What's the value in checking in this xfail'ed test without an actual fix for the problem?

Raise awareness about the problem.

I don't think that works. No one is reading through the test files of the repository.

Wed, Apr 17, 10:34 AM

Tue, Apr 16

krytarowski added a comment to D60728: [clang] [test] Add a (xfailing) test for PR41027.

What's the value in checking in this xfail'ed test without an actual fix for the problem?

Tue, Apr 16, 8:36 AM
krytarowski added a reviewer for D60728: [clang] [test] Add a (xfailing) test for PR41027: void.

Adding @void, regression introduced with D55616.

Tue, Apr 16, 6:24 AM
krytarowski added a comment to D55616: Emit ASM input in a constant context.

@void hi, this broke assembly code on NetBSD for various archs and blocks upgrade of the toolchain.

Tue, Apr 16, 6:23 AM · Restricted Project

Fri, Apr 5

krytarowski accepted D60325: [lldb] [Process/NetBSD] Fix wrongly mapping mm* registers.
Fri, Apr 5, 1:03 PM · Restricted Project

Tue, Apr 2

krytarowski added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

I think depending on CMAKE_THREAD_LIBS_INIT is the way to go. If it is broken for some platform internally, such OS has more issues than building OpenMP.

Tue, Apr 2, 6:09 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D59451: Fix gettid warnings and one test on FreeBSD.
Tue, Apr 2, 12:38 AM · Restricted Project, Restricted Project

Sun, Mar 31

krytarowski added inline comments to D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps.
Sun, Mar 31, 5:09 AM · Restricted Project
krytarowski accepted D60034: [lldb] [Process/elf-core] Support aarch64 NetBSD core dumps.
Sun, Mar 31, 5:09 AM · Restricted Project

Mar 19 2019

krytarowski added a comment to D59130: [llvm][Support] Provide interface to set thread priorities.

We have observed regressions in UI responsiveness on Linux and Windows when clangd is doing background indexing at normal priority.

Mar 19 2019, 4:30 AM · Restricted Project

Mar 17 2019

krytarowski added a comment to D59451: Fix gettid warnings and one test on FreeBSD.
In D59451#1432542, @dim wrote:
it's not with libc++ and newer libstdc++.

Some OSs merged libpthread into libc and/or implemented it almost fully in the kernel. It's not the case on NetBSD and apparently FreeBSD.

In libc there are just stubs for libpthread to allow linking but without defined interfaces, unless someone will link with the POSIX threading library.

Indeed, at least on FreeBSD there is a desire to fold the full pthread interface into libc, but it's apparently not very easy to do. So for now we need -pthread or -lpthread during linking.

One other thing that could be done is to link libc++.so.1 with -lpthread, but that would make every consumer of libc++ depend on the threading libraries, even if they never use any of the std::thread functionality. At least in our system version of libc++, we've never linked it with the threading libraries, but maybe it's something we should consider. @emaste any thoughts?

Mar 17 2019, 1:47 PM · Restricted Project, Restricted Project
krytarowski added a comment to D59451: Fix gettid warnings and one test on FreeBSD.
it's not with libc++ and newer libstdc++.
Mar 17 2019, 6:09 AM · Restricted Project, Restricted Project
krytarowski added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

Hmm, looks like this used to be true (for example with libstdc++ from GCC 4.8 found in CentOS 7), but it's not with libc++ and newer libstdc++.

Mar 17 2019, 6:01 AM · Restricted Project, Restricted Project
krytarowski added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

So if a developer uses a feature from stdlib, they need to manually link libpthread?

Mar 17 2019, 5:53 AM · Restricted Project, Restricted Project
krytarowski added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

I'm not sure about OMP specifics, but in C++ threads we are allowed to use threading routines but in order to make them functional we must link final executable with libpthread.

Mar 17 2019, 4:40 AM · Restricted Project, Restricted Project

Mar 16 2019

krytarowski added a comment to D59451: Fix gettid warnings and one test on FreeBSD.
In D59451#1431917, @dim wrote:

If we want to depend on pthread, please go for canonical -pthread.

Hm, I copied this from several other tests, which use the same construct, so I don't see why this one should be different. (In fact pthread detection is a can of worms, many configure scripts go through extreme lengths to determine the exact magical incantation needed... but most of the time -lpthread works everywhere, except on Windows of course. :) )

Mar 16 2019, 7:53 AM · Restricted Project, Restricted Project
krytarowski added a comment to D59451: Fix gettid warnings and one test on FreeBSD.

If we want to depend on pthread, please go for canonical -pthread.

Mar 16 2019, 5:03 AM · Restricted Project, Restricted Project

Mar 15 2019

krytarowski added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 15 2019, 1:46 PM · Restricted Project
krytarowski added a comment to D59427: [lldb] [Reproducer] Move SBRegistry registration into declaring files.

It looks good to me, but maybe @JDevlieghere has a better idea how to optimize it.

Mar 15 2019, 1:23 PM · Restricted Project
krytarowski added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 15 2019, 1:21 PM · Restricted Project
krytarowski added inline comments to D58801: [Support] Implement is_local_impl with AIX mntctl.
Mar 15 2019, 12:38 PM · Restricted Project

Mar 12 2019

krytarowski accepted D59249: [llvm] [Support] mallctl() is in malloc.h on NetBSD.

Looks good, but I would hold on a little bit until the situation will stabilize. We might want to add additional scenario of jemalloc.h and MALLCTL interfaces in -ljemalloc. But either way this patch is an improvement.

Mar 12 2019, 1:57 PM · Restricted Project
krytarowski added a comment to D59130: [llvm][Support] Provide interface to set thread priorities.

I would port it to NetBSD... but I don't see use-case for it. I think kernel should be allowed to schedule priorities on its own without manual help.

Mar 12 2019, 11:14 AM · Restricted Project
krytarowski added inline comments to D59249: [llvm] [Support] mallctl() is in malloc.h on NetBSD.
Mar 12 2019, 10:32 AM · Restricted Project

Mar 10 2019

krytarowski accepted D59177: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable.
Mar 10 2019, 1:46 AM · Restricted Project, Restricted Project

Mar 9 2019

krytarowski added inline comments to D59177: [lldb] [test] Make 2lwp_process_SIGSEGV test more portable.
Mar 9 2019, 11:27 AM · Restricted Project, Restricted Project

Mar 8 2019

krytarowski added a comment to D59133: Remove esan..

LGTM, good job!

Regarding dfsan, I think it has users @pcc

Mar 8 2019, 11:08 AM · Restricted Project, Restricted Project
krytarowski added a comment to D59133: Remove esan..

How about DFSan and shadowcallstack?

I don't understand how that question is related to this change. What do you mean?

Mar 8 2019, 10:40 AM · Restricted Project, Restricted Project
krytarowski added a comment to D59133: Remove esan..

How about DFSan and shadowcallstack?

Mar 8 2019, 9:27 AM · Restricted Project, Restricted Project

Mar 7 2019

krytarowski added a comment to D32149: [lldb] [Process] Add proper support for NetBSD core files with threads.

Looks good to me.

Mar 7 2019, 1:04 AM · Restricted Project, Restricted Project

Mar 4 2019

krytarowski committed rG502ba11583b2: Revert duplicate check for DragonFly BSD (authored by krytarowski).
Revert duplicate check for DragonFly BSD
Mar 4 2019, 7:51 AM
krytarowski accepted D58907: Revert duplicate check for DragonFly BSD.
Mar 4 2019, 7:48 AM · Restricted Project
krytarowski committed rG0c5b6ede2ff1: Unbreak shared library linkage on DragonFlyBSD. (authored by krytarowski).
Unbreak shared library linkage on DragonFlyBSD.
Mar 4 2019, 6:37 AM
krytarowski accepted D35125: Unbreak shared library linkage on DragonFlyBSD..
Mar 4 2019, 6:21 AM · Restricted Project
krytarowski added a comment to D56647: [WIP] [ELF] Implement --copy-dt-needed-entries.

NetBSD patches GNU linker to behave in the original way. This behavior is mandated from lld as well in order to treat it as a drop-in replacement.

Mar 4 2019, 12:31 AM · Restricted Project

Mar 3 2019

Herald added a project to D56647: [WIP] [ELF] Implement --copy-dt-needed-entries: Restricted Project.

@ruiu ping?

Mar 3 2019, 11:02 AM · Restricted Project
krytarowski accepted D58527: [lldb] [test] Mark failing tests XFAIL on NetBSD.

Feel free to commit this and next without review.

Mar 3 2019, 6:58 AM · Restricted Project, Restricted Project

Mar 1 2019

krytarowski added a comment to D57463: Add a module pass for order file instrumentation.

The NetBSD buildbot is broken after this change.

Mar 1 2019, 1:55 AM · Restricted Project

Feb 24 2019

krytarowski accepted D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path.

This will make life much more easier now with this change.

Feb 24 2019, 10:24 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path.
Feb 24 2019, 8:21 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path.
Feb 24 2019, 3:38 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path.
Feb 24 2019, 3:29 AM · Restricted Project, Restricted Project

Feb 22 2019

krytarowski added a comment to D58505: [zorg] netbsd: Update project list, rename and move to toolchain category.

We need to use our current approach with factory... we are actively working on LLDB test targets and we will be attaching compiler-rt next.

Feb 22 2019, 12:28 PM · Restricted Project, Restricted Project

Feb 21 2019

krytarowski added inline comments to D58434: AddressSanitizer: 64-bit SPARC/Linux port.
Feb 21 2019, 7:03 PM · Restricted Project, Restricted Project
krytarowski added a comment to D58505: [zorg] netbsd: Update project list, rename and move to toolchain category.

Would it make sense to rename the builder? lldb-amd64-ninja-netbsd8 is just not true based on that list. IIRC there are other unified bots, that test a variety of projects?

Apparently Fuchsia has one, and puts it in 'toolchain' category. Maybe we should just name it 'amd64-ninja-netbsd8' or 'netbsd8-amd64-ninja'. Are you maybe aware if rename is something that can be done lightly in zorg, or does it require some extra work?

Feb 21 2019, 6:59 AM · Restricted Project, Restricted Project
krytarowski added a comment to D58505: [zorg] netbsd: Update project list, rename and move to toolchain category.

Would it make sense to rename the builder? lldb-amd64-ninja-netbsd8 is just not true based on that list. IIRC there are other unified bots, that test a variety of projects?

Feb 21 2019, 6:50 AM · Restricted Project, Restricted Project
krytarowski added a comment to D58505: [zorg] netbsd: Update project list, rename and move to toolchain category.

I would include compiler-rt in one go as we will enable its builds sooner than later.

Feb 21 2019, 6:33 AM · Restricted Project, Restricted Project
krytarowski added a comment to D58454: [OpenMP][OMPT] Fix locking testcases for 32 bit architectures.

This broke the NetBSD buildbot: http://lab.llvm.org:8011/builders/lldb-amd64-ninja-netbsd8/builds/19082

Feb 21 2019, 5:23 AM · Restricted Project, Restricted Project

Feb 19 2019

krytarowski added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Feb 19 2019, 6:46 PM · Restricted Project, Restricted Project
krytarowski added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Feb 19 2019, 2:47 AM · Restricted Project, Restricted Project
krytarowski added a comment to D58379: [compiler-rt] Intercept the bcmp() function..

<strings.h> should be included unconditionally.

Feb 19 2019, 1:44 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D58379: [compiler-rt] Intercept the bcmp() function..
Feb 19 2019, 1:38 AM · Restricted Project, Restricted Project
krytarowski added a comment to D58379: [compiler-rt] Intercept the bcmp() function..

Please enable the tests for NetBSD as well.

Feb 19 2019, 1:25 AM · Restricted Project, Restricted Project
krytarowski added a comment to D58379: [compiler-rt] Intercept the bcmp() function..

bcmp is BSD and it first appeard in 4.2BSD... it's not specific to GNU source but compat layer for BSD software.

Feb 19 2019, 1:18 AM · Restricted Project, Restricted Project

Feb 18 2019

krytarowski added inline comments to D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images.
Feb 18 2019, 10:54 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images.
Feb 18 2019, 10:26 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D42870: [lldb] [ObjectFile/ELF] Correct recognition of NetBSD images.
Feb 18 2019, 10:25 AM · Restricted Project, Restricted Project

Feb 15 2019

krytarowski added a comment to D58230: [lldb] [MainLoop] Add kevent() EINTR handling.

@mgorny let's go through tech-kern@ and later checking FreeBSD/Darwin/OpenBSD. I think it's worth to clarify this in the documentation.

Feb 15 2019, 12:09 AM · Restricted Project, Restricted Project

Feb 14 2019

krytarowski added a comment to D58230: [lldb] [MainLoop] Add kevent() EINTR handling.

For EINTR we shall use llvm::sys::RetryAfterSignal

kevent() man page indicates:

All changes contained in the changelist are applied before any pending events are read from the queue.

Also:

[EINTR] A signal was delivered before the timeout expired and before any events were placed on the kqueue for return.

So while it's not stated explicitly, I think in_events is always consumed, even if EINTR is returned. In which case, llvm::sys::RetryAfterSignal would be wrong whenever in_events is not empty.

Feb 14 2019, 3:07 PM · Restricted Project, Restricted Project
krytarowski accepted D58227: [lldb] [MainLoop] Remove redundant termination clause (NFCI).
Feb 14 2019, 10:29 AM · Restricted Project, Restricted Project
krytarowski added a comment to D58227: [lldb] [MainLoop] Remove redundant termination clause (NFCI).

It looks good to me.

Feb 14 2019, 7:34 AM · Restricted Project, Restricted Project
krytarowski accepted D58223: [lldb] [unittests] XFAIL two unittests failing on NetBSD.
Feb 14 2019, 7:28 AM · Restricted Project
Herald added a project to D42206: If kevent() is interrupted by signal (or is being debugged) and we get EINTR, retry: Restricted Project.

'attaching a debugger produces an observable side-effect (EINTR) in the debugged process is considered a bug by the linux kernel folks'

Feb 14 2019, 7:23 AM · Restricted Project, Restricted Project
krytarowski added a comment to D58230: [lldb] [MainLoop] Add kevent() EINTR handling.

For EINTR we shall use llvm::sys::RetryAfterSignal

Feb 14 2019, 7:17 AM · Restricted Project, Restricted Project

Feb 12 2019

krytarowski accepted D58131: [lldb] [unittest] Avoid mixing '127.0.0.1' and 'localhost'.

Short term this looks fine.

Feb 12 2019, 9:23 AM · Restricted Project, Restricted Project

Feb 9 2019

krytarowski committed rG61113341f714: Mark another test as flaky (authored by krytarowski).
Mark another test as flaky
Feb 9 2019, 10:40 AM

Feb 8 2019

krytarowski added a comment to D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly.

But to what purpose? I think it's better to use consistent macros to refer to the same scenario.

Feb 8 2019, 12:01 PM · Restricted Project
krytarowski added a comment to D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly.

Ok, I see that _WIN32 actually redefines sigset_t, so I've added a separate branch for it.

Feb 8 2019, 11:44 AM · Restricted Project
krytarowski added a comment to D57912: [lldb] [unittests] Disable MainLoopTest::DetectsEOF on NetBSD.

@labath our short-term goal is to enable execution of LLDB tests on the NetBSD buildbot. We are stuck temporarily with an older release of NetBSD on the machine for some time (1-2 months) so we need to live with it for now. No need to make it better than sufficient as of now.

Feb 8 2019, 11:03 AM · Restricted Project, Restricted Project
krytarowski added inline comments to D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly.
Feb 8 2019, 11:00 AM · Restricted Project
krytarowski added a comment to D57959: [lldb] [MainLoop] Initialize empty sigset_t correctly.

I think that sigemptyset(2) is unsupported on Windows.

Feb 8 2019, 11:00 AM · Restricted Project

Feb 7 2019

krytarowski accepted D57907: lldb: Fix compilation on OpenBSD.
Feb 7 2019, 7:45 PM · Restricted Project, Restricted Project
krytarowski accepted D57912: [lldb] [unittests] Disable MainLoopTest::DetectsEOF on NetBSD.
Feb 7 2019, 1:33 PM · Restricted Project, Restricted Project

Feb 5 2019

krytarowski committed rG3349bd662aad: Update the ioctl(2) list in sanitizers with NetBSD 8.99.34 (authored by krytarowski).
Update the ioctl(2) list in sanitizers with NetBSD 8.99.34
Feb 5 2019, 2:23 PM

Feb 3 2019

krytarowski updated subscribers of D57592: Replace uses of %T with %t in from previous frontend test differential .
Feb 3 2019, 4:29 AM · Restricted Project, Restricted Project
krytarowski added a comment to D57592: Replace uses of %T with %t in from previous frontend test differential .

The NetBSD buildbot breaks in these tests now:

Feb 3 2019, 4:29 AM · Restricted Project, Restricted Project

Feb 2 2019

krytarowski added a reverting change for D44035: Support OpenBSD in common interceptors: rG980d0f891928: Revert D44035.
Feb 2 2019, 5:43 AM

Feb 1 2019

krytarowski added a comment to D57455: [libunwind] Provide inline placement new definition.

The NetBSD buildbot is affected and red for some time now.

Feb 1 2019, 12:35 PM · Restricted Project

Jan 30 2019

krytarowski added a comment to D56650: [lld] [ELF] Support customizing behavior on target triple.

chandlerc added a comment.

There was a long discussion between two NetBSD maintainers about this (both already in the reviewers list of this patch). I'm not sure if there is an existing thread that would be better to follow up on as opposed to starting a fresh thread.

Jan 30 2019, 3:18 PM
krytarowski added a comment to D56650: [lld] [ELF] Support customizing behavior on target triple.

If you still need to patch GNU ld, it doesn't seems like this patch makes things easier for you. (But even if this would make it easier for you, this patch's approach is not okay by design though.)

Jan 30 2019, 12:34 PM
krytarowski added a comment to D56650: [lld] [ELF] Support customizing behavior on target triple.

If we pass flags from clang, we sacrifice:

Jan 30 2019, 12:09 PM
krytarowski added a reviewer for D56650: [lld] [ELF] Support customizing behavior on target triple: christos.
Jan 30 2019, 9:28 AM
krytarowski added a comment to D56650: [lld] [ELF] Support customizing behavior on target triple.

@rui we need some resolution here. We have stronger feelings from the community to customize the linker directly based on detected triple.

Jan 30 2019, 7:06 AM

Jan 29 2019

krytarowski added a comment to D57412: [scudo] Initial standalone skeleton check-in.

I have got a scudo support patch for NetBSD locally.. but the original tests are havily prepared against GNU malloc. This makes me uncertain whether scudo really works. Are there plans to make the tests more generic?

That should be the case for the unit-tests. The new way things are done will clearly separate the C/C++ wrappers.
I can add you on the standalone check-ins for you to chime in on the direction we are headed to.
All the development efforts so far has targeted Linux/Android/Fuchsia, and I unfortunately have no BSD knowledge, but we are definitely open to contributions.
Initial check-ins will be Linux specific though since it's my workstation and that's what I am testing things against.

I wouldn't pursue work on your side on the current non-standalone Scudo, as the standalone version will be better (more performant, smaller memory footprint, etc) on all fronts.

Jan 29 2019, 2:22 PM · Restricted Project, Restricted Project
krytarowski added a comment to D57412: [scudo] Initial standalone skeleton check-in.

I have got a scudo support patch for NetBSD locally.. but the original tests are havily prepared against GNU malloc. This makes me uncertain whether scudo really works. Are there plans to make the tests more generic?

Jan 29 2019, 12:54 PM · Restricted Project, Restricted Project

Jan 27 2019

krytarowski added a comment to D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes.

How do you resolve paths? Linker cache with registry of libraries?

DT_NEEDED aren't treated as paths, they are used as object names (keys); dynamic linker passes those to the loader service which is responsible for resolving them and returning back the corresponding memory objects.

Jan 27 2019, 2:05 PM
krytarowski added a comment to D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes.

+ vitalybuka

Can we fix it for everybody? It's certainly not restricted to NetBSD.

As a point of reference, we use shared runtimes on Fuchsia but we don't use rpath so this is not something we want for every system.

Jan 27 2019, 1:38 PM
krytarowski added a reviewer for D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes: vitalybuka.

Can we fix it for everybody? It's certainly not restricted to NetBSD.

Jan 27 2019, 1:03 PM

Jan 24 2019

krytarowski accepted D57193: [lldb] [Process/NetBSD] Add missing linkage to -lutil.
Jan 24 2019, 2:18 PM
krytarowski added inline comments to D57179: Enhance support for NetBSD in SafeStack.
Jan 24 2019, 1:39 PM · Restricted Project
krytarowski added inline comments to D57179: Enhance support for NetBSD in SafeStack.
Jan 24 2019, 1:14 PM · Restricted Project
krytarowski added a comment to D57181: Fix XRayTest link on FreeBSD (and likely NetBSD too).

NetBSD is affected in the same way.

Jan 24 2019, 12:53 PM
krytarowski created D57179: Enhance support for NetBSD in SafeStack.
Jan 24 2019, 12:16 PM · Restricted Project

Jan 21 2019

krytarowski added a comment to D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.

I'd really prefer to keep the argv[0] code as is. I'm not sure what that test case is supposed to do, but it seems quite questionable as "check" is not a valid language frontend nor a version suffix. It should not work.

Jan 21 2019, 2:03 AM · Restricted Project

Jan 20 2019

krytarowski accepted D56976: [clang] [test] Pass -ccc-install-dir in mac compilation db test.
Jan 20 2019, 5:51 AM
krytarowski accepted D56975: [Support] Reimplement getMainExecutable() using sysctl on NetBSD.
Jan 20 2019, 5:17 AM · Restricted Project

Jan 18 2019

krytarowski accepted D56937: [safestack] Add ThreadId type as uint64_t.
Jan 18 2019, 2:35 PM
krytarowski added inline comments to D56937: [safestack] Add ThreadId type as uint64_t.
Jan 18 2019, 2:22 PM

Jan 17 2019

krytarowski added inline comments to D56886: [safestack] Remove dependency of SafeStack on sanitizer_common.
Jan 17 2019, 9:07 PM

Jan 15 2019

krytarowski added inline comments to rL351189: [Sanitizer] Intercept sl_add api on FreeBSD/NetBSD.
Jan 15 2019, 4:12 AM