- User Since
- Aug 30 2015, 11:51 AM (207 w, 5 d)
Wed, Aug 7
Sun, Aug 4
Tue, Jul 30
Something is broken between reviews. and my mailbox as I am not receiving any e-mails so pinging does not make any effect... no LLVM admin replied to my questions on this to validate whether my mail was blacklisted or similar. I have decided to change server of my mailbox and workaround it.
Sun, Jul 28
Jul 13 2019
Jul 12 2019
Something that we do not cover here is that once a tracee reports a signal (like someone poked it with SIGUSR1) and we want to pass it over to the tracee, we will reset siginfo.
I think it looks OK. there are some nits that could be optimized in future or handled additionally.. but for now it should be fine.
Jul 11 2019
Jul 10 2019
I've landed this version as it is good enough to land LLVM-9.
- switch the protype of internal_ptrace() to the one matching NetBSD
- move the stop-the-world implementation for NetBSD into a separate file
- minor changes
Jul 8 2019
Jul 7 2019
Ping? There is planned LLVM branching soon and I would like to see this in LLVM 9.0.
Jul 3 2019
Testing notification e-mails from phabricator.
Jul 2 2019
Personally I am opposed to this change. The compiler driver (gcc,clang) has a set of arch/OS dependent defaults. It seems weird/redundant to add another sets of defaults on the linker side.
Jul 1 2019
This code in general works.. however the tests are not compatible with NetBSD.
- Fixup style.
I would follow the same kernel behavior here as Linux, but that can be done independently.
Jun 20 2019
Jun 19 2019
Jun 17 2019
This check should contain additional check for uid==root. If we are root we can read and write to DB registers.
Jun 13 2019
I would leave the NetBSD version as it is in this patch and let us to fix/test it later.
Jun 10 2019
This change makes NetBSD buildbot flaky.
In general this code should be close to functional on NetBSD (if not already compatible).
Jun 9 2019
Jun 4 2019
This commit breaks the NetBSD buildbot node.
Jun 3 2019
If we want to reject opening directories we shall do it during open(2)/fopen(3).
Jun 2 2019
sysv abi is not only for UNIX but most non-Windows ones (BSDs, HAIKU, ...).
Jun 1 2019
whereas others emit "is a directory
May 29 2019
One time just before it's loaded (so lldb can check which modules are loaded) and another right after it's loaded (so lldb can check again which ones are loaded and calculate the difference).
May 25 2019
May 22 2019
It is probably fine.. but I will defer review to lit/libc++ maintainers.
May 7 2019
Apr 30 2019
I think there is a bug thought in the code.
Apr 25 2019
Apr 23 2019
Apr 17 2019
Apr 16 2019
@void hi, this broke assembly code on NetBSD for various archs and blocks upgrade of the toolchain.
Apr 5 2019
Apr 2 2019
I think depending on CMAKE_THREAD_LIBS_INIT is the way to go. If it is broken for some platform internally, such OS has more issues than building OpenMP.
Mar 31 2019
Mar 19 2019
We have observed regressions in UI responsiveness on Linux and Windows when clangd is doing background indexing at normal priority.
Mar 17 2019
it's not with libc++ and newer libstdc++.
Hmm, looks like this used to be true (for example with libstdc++ from GCC 4.8 found in CentOS 7), but it's not with libc++ and newer libstdc++.
I'm not sure about OMP specifics, but in C++ threads we are allowed to use threading routines but in order to make them functional we must link final executable with libpthread.
Mar 16 2019
If we want to depend on pthread, please go for canonical -pthread.
Mar 15 2019
It looks good to me, but maybe @JDevlieghere has a better idea how to optimize it.
Mar 12 2019
Looks good, but I would hold on a little bit until the situation will stabilize. We might want to add additional scenario of jemalloc.h and MALLCTL interfaces in -ljemalloc. But either way this patch is an improvement.
I would port it to NetBSD... but I don't see use-case for it. I think kernel should be allowed to schedule priorities on its own without manual help.
Mar 10 2019
Mar 9 2019
Mar 8 2019
How about DFSan and shadowcallstack?
Mar 7 2019
Looks good to me.
Mar 4 2019
NetBSD patches GNU linker to behave in the original way. This behavior is mandated from lld as well in order to treat it as a drop-in replacement.
Mar 3 2019
Feel free to commit this and next without review.
Mar 1 2019
The NetBSD buildbot is broken after this change.
Feb 24 2019
This will make life much more easier now with this change.
Feb 22 2019
We need to use our current approach with factory... we are actively working on LLDB test targets and we will be attaching compiler-rt next.