- User Since
- Aug 30 2015, 11:51 AM (215 w, 3 d)
Tue, Sep 24
Mon, Sep 23
Once GCC will grow support for __SANITIZER_LEAK__ (already pending in review) there will be include as a separate patch support for LSan/GCC.
Sat, Sep 21
This is needed in the NetBSD kernel, more fine-grained checks would be acceptable too, but one global feature detection is what I need.
Fri, Sep 20
With these patches included there are still ~3 failing tests and I will mark them as XFAIL for now.
Looks good to me but I will leave the final decision to someone else.
Tue, Sep 17
Sep 16 2019
- apply changes from review
- apply changes from review
Sep 15 2019
Sep 12 2019
Sep 11 2019
- restrict __lsan::ScopedInterceptorDisabler to ASan and LSan
Sep 10 2019
Sep 8 2019
================================================================= ==371==ERROR: LeakSanitizer: detected memory leaks
Sep 3 2019
This change broke on NetBSD.
This breaks NetBSD as it shall be paired with llvm::call_once.
Aug 7 2019
Aug 4 2019
Jul 30 2019
Something is broken between reviews. and my mailbox as I am not receiving any e-mails so pinging does not make any effect... no LLVM admin replied to my questions on this to validate whether my mail was blacklisted or similar. I have decided to change server of my mailbox and workaround it.
Jul 28 2019
Jul 13 2019
Jul 12 2019
Something that we do not cover here is that once a tracee reports a signal (like someone poked it with SIGUSR1) and we want to pass it over to the tracee, we will reset siginfo.
I think it looks OK. there are some nits that could be optimized in future or handled additionally.. but for now it should be fine.
Jul 11 2019
Jul 10 2019
I've landed this version as it is good enough to land LLVM-9.
- switch the protype of internal_ptrace() to the one matching NetBSD
- move the stop-the-world implementation for NetBSD into a separate file
- minor changes
Jul 8 2019
Jul 7 2019
Ping? There is planned LLVM branching soon and I would like to see this in LLVM 9.0.
Jul 3 2019
Testing notification e-mails from phabricator.
Jul 2 2019
Personally I am opposed to this change. The compiler driver (gcc,clang) has a set of arch/OS dependent defaults. It seems weird/redundant to add another sets of defaults on the linker side.
Jul 1 2019
This code in general works.. however the tests are not compatible with NetBSD.
- Fixup style.
I would follow the same kernel behavior here as Linux, but that can be done independently.
Jun 20 2019
Jun 19 2019
Jun 17 2019
This check should contain additional check for uid==root. If we are root we can read and write to DB registers.
Jun 13 2019
I would leave the NetBSD version as it is in this patch and let us to fix/test it later.
Jun 10 2019
This change makes NetBSD buildbot flaky.
In general this code should be close to functional on NetBSD (if not already compatible).
Jun 9 2019
Jun 4 2019
This commit breaks the NetBSD buildbot node.
Jun 3 2019
If we want to reject opening directories we shall do it during open(2)/fopen(3).
Jun 2 2019
sysv abi is not only for UNIX but most non-Windows ones (BSDs, HAIKU, ...).
Jun 1 2019
whereas others emit "is a directory
May 29 2019
One time just before it's loaded (so lldb can check which modules are loaded) and another right after it's loaded (so lldb can check again which ones are loaded and calculate the difference).
May 25 2019
May 22 2019
It is probably fine.. but I will defer review to lit/libc++ maintainers.
May 7 2019
Apr 30 2019
I think there is a bug thought in the code.
Apr 25 2019
Apr 23 2019
Apr 17 2019
Apr 16 2019
@void hi, this broke assembly code on NetBSD for various archs and blocks upgrade of the toolchain.
Apr 5 2019
Apr 2 2019
I think depending on CMAKE_THREAD_LIBS_INIT is the way to go. If it is broken for some platform internally, such OS has more issues than building OpenMP.