Details
- Reviewers
jdoerfert kkwli0 RaviNarayanaswamy hfinkel
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Nit: Maybe we should mention complex support on nvptx devices.
The rest looks good to me. Others might want to add stuff but we can merge this right away (IMHO)
Ok, will add.
The rest looks good to me. Others might want to add stuff
That was the intention.
but we can merge this right away (IMHO)
It is up to Hans if he has some time. But I think I covered almost all new features (+ complex for NVPTX), so after the update it can be merged with 11.x release.
default(firstprivate) was added in https://reviews.llvm.org/rG78443666bc18a6957d279a0f58319c8a3e57771a
Yest, it was before clang 11 was branched, so need to add to the list of the changes.
but we can merge this right away (IMHO)
It is up to Hans if he has some time. But I think I covered almost all new features (+ complex for NVPTX), so after the update it can be merged with 11.x release.
It's fine by me if you want to wait a day or two for more comments, or go ahead and merge directly.
Hi Hans, can you commit it yourself? I have some technical issues and not able to commit it. And I don't know when it is going to be resolved. :(