Page MenuHomePhabricator

[OpenMP] Support nested OpenMP context selectors (declare variant)
ClosedPublic

Authored by jdoerfert on Aug 12 2020, 11:30 PM.

Details

Summary

Due to omp begin/end declare variant, OpenMP context selectors can be
nested. This patch adds initial support for this so we can use it for
target math variants. We should improve the detection of "equivalent"
scores and user conditions, we should also revisit the data structures
of the OMPTraitInfo object, however, both are not pressing issues right
now.

Diff Detail

Event Timeline

jdoerfert created this revision.Aug 12 2020, 11:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2020, 11:30 PM
jdoerfert requested review of this revision.Aug 12 2020, 11:30 PM
jdoerfert updated this revision to Diff 285386.Aug 13 2020, 8:41 AM

Minor tweaks

JonChesterfield accepted this revision.Aug 13 2020, 8:31 PM

Thanks! Probably good to implement this just at the time math headers needs it as that gives us a real world example of the change working.

This revision is now accepted and ready to land.Aug 13 2020, 8:31 PM
This revision was landed with ongoing or failed builds.Wed, Sep 16, 11:40 AM
This revision was automatically updated to reflect the committed changes.