This is an archive of the discontinued LLVM Phabricator instance.

[AST] Keep FP options in trailing storage of CallExpr
ClosedPublic

Authored by sepavloff on Jul 22 2020, 9:59 AM.

Details

Summary

This change allow a CallExpr to have optional FPOptionsOverride object,
stored in trailing storage. The implementaion is made similar to the way
used in BinaryOperator.

Diff Detail

Event Timeline

sepavloff created this revision.Jul 22 2020, 9:59 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: martong. · View Herald Transcript
riccibruno added inline comments.
clang/test/AST/ast-dump-fpfeatures.cpp
2

Can you also test the serialization by round-tripping through a PCH (see the other AST dump tests for an example)?

Extended test with PCH read

sepavloff marked an inline comment as done.Jul 23 2020, 12:23 AM
rjmccall accepted this revision.Jul 23 2020, 2:46 PM

LGTM.

This revision is now accepted and ready to land.Jul 23 2020, 2:46 PM
This revision was automatically updated to reflect the committed changes.