Page MenuHomePhabricator

sepavloff (Serge Pavlov)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2013, 7:26 AM (393 w, 4 d)

Recent Activity

Yesterday

sepavloff committed rGf91b9c0f9858: Run test on particular target only (authored by sepavloff).
Run test on particular target only
Sat, Sep 26, 6:27 AM
sepavloff committed rG6314f412a83d: [FPEnv] Evaluate constant expressions under non-default rounding modes (authored by sepavloff).
[FPEnv] Evaluate constant expressions under non-default rounding modes
Sat, Sep 26, 4:57 AM
sepavloff closed D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.
Sat, Sep 26, 4:57 AM · Restricted Project

Fri, Sep 25

sepavloff added inline comments to D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress.
Fri, Sep 25, 1:40 AM · Restricted Project

Thu, Sep 24

sepavloff added inline comments to D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.
Thu, Sep 24, 10:42 PM · Restricted Project
sepavloff updated the diff for D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.

Added diagnostic message

Thu, Sep 24, 10:41 PM · Restricted Project
sepavloff committed rG590cc068c160: Use different name for auto variable (authored by sepavloff).
Use different name for auto variable
Thu, Sep 24, 3:33 AM
sepavloff added inline comments to D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.
Thu, Sep 24, 2:04 AM · Restricted Project
sepavloff updated the diff for D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.

Updated patch

Thu, Sep 24, 1:59 AM · Restricted Project

Mon, Sep 21

sepavloff added a comment to D82525: [FPEnv] Intrinsics for access to FP control modes.

Ping.

Mon, Sep 21, 7:55 AM · Restricted Project

Fri, Sep 18

sepavloff added inline comments to D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.
Fri, Sep 18, 10:54 AM · Restricted Project
sepavloff updated the diff for D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.

Updated patch

Fri, Sep 18, 10:41 AM · Restricted Project
sepavloff committed rG8a86261c511e: [FPEnv] Use typed accessors in FPOptions (authored by sepavloff).
[FPEnv] Use typed accessors in FPOptions
Fri, Sep 18, 12:18 AM
sepavloff closed D87812: [FPEnv] Use typed accessors in FPOptions.
Fri, Sep 18, 12:17 AM · Restricted Project, Restricted Project

Thu, Sep 17

sepavloff requested review of D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes.
Thu, Sep 17, 3:25 AM · Restricted Project

Wed, Sep 16

sepavloff requested review of D87812: [FPEnv] Use typed accessors in FPOptions.
Wed, Sep 16, 8:11 PM · Restricted Project, Restricted Project

Tue, Sep 15

sepavloff added a reviewer for D78902: [Driver] Add output file to properties of Command: jyknight.

This change is similar to D82782.

Tue, Sep 15, 10:56 PM · Restricted Project
sepavloff added reviewers for D78899: [Driver] Add callback to Command execution: yaxunl, aganea, MaskRay.
Tue, Sep 15, 10:52 PM · Restricted Project
sepavloff updated the diff for D78899: [Driver] Add callback to Command execution.

Rebased patch

Tue, Sep 15, 10:47 PM · Restricted Project
sepavloff abandoned D77545: Represent FP options in AST by special Expression node.

FPOptions is now stored in AST objects.

Tue, Sep 15, 8:13 AM · Restricted Project
sepavloff abandoned D76599: Represent FP options in AST by special Statement node.

FPOptions is now stored in AST objects.

Tue, Sep 15, 8:13 AM · Restricted Project
sepavloff updated the summary of D78902: [Driver] Add output file to properties of Command.
Tue, Sep 15, 6:55 AM · Restricted Project
sepavloff updated the diff for D78902: [Driver] Add output file to properties of Command.

Rebase and ping

Tue, Sep 15, 6:50 AM · Restricted Project

Mon, Sep 14

sepavloff added a comment to D69272: Enable '#pragma STDC FENV_ACCESS' in frontend.

I am working on a task to ensure that clang is doing floating point constant folding correctly.

Mon, Sep 14, 9:02 AM · Restricted Project
sepavloff updated the diff for D81833: [X86][FPEnv] Lowering of {get,set,reset}_fpenv.

Intrinsics now do not use pointers

Mon, Sep 14, 12:40 AM · Restricted Project
sepavloff updated the diff for D71742: Added intrinsics for access to FP environment.

Intrinsics now does not use pointers

Mon, Sep 14, 12:35 AM · Restricted Project

Sun, Sep 13

sepavloff added a comment to D87528: Enable '#pragma STDC FENV_ACCESS' in frontend cf. D69272 - Work in Progress.

@sepavloff Is it OK if I continue work on this item? Not sure about the protocol when continuing someone else's patch.

Sun, Sep 13, 11:05 PM · Restricted Project
sepavloff committed rGf1cd6593da3a: [AST][FPEnv] Keep FP options in trailing storage of CastExpr (authored by sepavloff).
[AST][FPEnv] Keep FP options in trailing storage of CastExpr
Sun, Sep 13, 10:57 PM

Sat, Sep 12

sepavloff added a reverting change for rG6c8041aa0ffe: [AST][FPEnv] Keep FP options in trailing storage of CastExpr: rGde044f756286: Revert "[AST][FPEnv] Keep FP options in trailing storage of CastExpr".
Sat, Sep 12, 3:35 AM
sepavloff committed rGde044f756286: Revert "[AST][FPEnv] Keep FP options in trailing storage of CastExpr" (authored by sepavloff).
Revert "[AST][FPEnv] Keep FP options in trailing storage of CastExpr"
Sat, Sep 12, 3:35 AM
sepavloff added a reverting change for D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr: rGde044f756286: Revert "[AST][FPEnv] Keep FP options in trailing storage of CastExpr".
Sat, Sep 12, 3:35 AM · Restricted Project
sepavloff committed rG9c651c231f31: Missing change from previous commit (authored by sepavloff).
Missing change from previous commit
Sat, Sep 12, 1:11 AM
sepavloff committed rG6c8041aa0ffe: [AST][FPEnv] Keep FP options in trailing storage of CastExpr (authored by sepavloff).
[AST][FPEnv] Keep FP options in trailing storage of CastExpr
Sat, Sep 12, 12:32 AM
sepavloff closed D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.
Sat, Sep 12, 12:32 AM · Restricted Project

Tue, Sep 8

sepavloff added a comment to D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.

This change allow a CallExpr to have optional FPOptionsOverride object,

Should this be CastExpr instead?

Tue, Sep 8, 8:13 AM · Restricted Project
sepavloff updated the summary of D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.
Tue, Sep 8, 8:08 AM · Restricted Project
sepavloff updated the diff for D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.

Updated patch

Tue, Sep 8, 8:04 AM · Restricted Project

Mon, Sep 7

sepavloff added a comment to D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.

Any feedback?

Mon, Sep 7, 9:49 AM · Restricted Project

Fri, Sep 4

sepavloff committed rGa633da5391b0: [FPEnv] Partially implement #pragma STDC FENV_ROUND (authored by sepavloff).
[FPEnv] Partially implement #pragma STDC FENV_ROUND
Fri, Sep 4, 2:48 AM
sepavloff closed D86921: [FPEnv] Partially implement #pragma STDC FENV_ROUND.
Fri, Sep 4, 2:48 AM · Restricted Project

Thu, Sep 3

sepavloff updated the diff for D78902: [Driver] Add output file to properties of Command.

Rebased patch

Thu, Sep 3, 5:35 AM · Restricted Project

Wed, Sep 2

sepavloff updated the diff for D83036: [X86][FPEnv] Lowering of {get,set,reset}_fpmode.

Rebased patch

Wed, Sep 2, 1:51 AM · Restricted Project
sepavloff updated the diff for D82525: [FPEnv] Intrinsics for access to FP control modes.

Get rid of clang-tidy warnings

Wed, Sep 2, 12:15 AM · Restricted Project

Tue, Sep 1

sepavloff updated the diff for D82525: [FPEnv] Intrinsics for access to FP control modes.

Rebased patch

Tue, Sep 1, 8:49 AM · Restricted Project
sepavloff requested review of D86921: [FPEnv] Partially implement #pragma STDC FENV_ROUND.
Tue, Sep 1, 2:50 AM · Restricted Project

Mon, Aug 31

sepavloff added inline comments to D85031: [builtins] Unify the softfloat division implementation.
Mon, Aug 31, 7:58 AM · Restricted Project
sepavloff accepted D85032: [builtins] Make divXf3 handle denormal results.

LGTM.

Mon, Aug 31, 3:43 AM · Restricted Project
sepavloff added a comment to D85031: [builtins] Unify the softfloat division implementation.

The new comments are much better, thank you!
I think this version may be committed.

Mon, Aug 31, 3:37 AM · Restricted Project

Aug 26 2020

sepavloff accepted D85031: [builtins] Unify the softfloat division implementation.

I don't fully understand the magic of fixing possible overflow, I hope you made enough investigation and testing to be sure it works as expected.
Please wait a couple of days before commit, so that other reviewers could make their notes.

Aug 26 2020, 6:41 AM · Restricted Project

Aug 25 2020

sepavloff accepted D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls.

LGTM.

Aug 25 2020, 3:41 AM · Restricted Project

Aug 24 2020

sepavloff added a comment to D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.
In D85960#2218798, @kpn wrote:

You mentioned in D85920 a need to merge this review with that review. I don't think that's needed. This code here is farther along. It does everything that D85920 does and has necessary pieces implemented as well.

Aug 24 2020, 9:30 AM · Restricted Project

Aug 20 2020

sepavloff added inline comments to D85031: [builtins] Unify the softfloat division implementation.
Aug 20 2020, 10:09 PM · Restricted Project
sepavloff added a comment to D78899: [Driver] Add callback to Command execution.

Ping.

Aug 20 2020, 10:11 AM · Restricted Project
sepavloff added a comment to D78902: [Driver] Add output file to properties of Command.

Ping.

Aug 20 2020, 10:11 AM · Restricted Project
sepavloff added inline comments to D85031: [builtins] Unify the softfloat division implementation.
Aug 20 2020, 9:17 AM · Restricted Project

Aug 18 2020

sepavloff added a comment to D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls.

@sepavloff

Thank you for the test cases. Looks like it is worth completely rewriting the three tests as table-driven tests

Aug 18 2020, 10:37 PM · Restricted Project

Aug 17 2020

sepavloff added inline comments to D84932: [builtins] Add more test cases for __div[sdt]f3 LibCalls.
Aug 17 2020, 11:01 PM · Restricted Project

Aug 14 2020

sepavloff added a comment to D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.

Similar patch is here: https://reviews.llvm.org/D85920.

Aug 14 2020, 2:29 AM · Restricted Project
sepavloff added a comment to D85920: [FPEnv][AST] WIP!!! For casts, keep FP options in trailing storage of CastExpr.

Unfortunately I also prepared similar patch: https://reviews.llvm.org/D85960.
I didn't look into your patch in details yet, but I think they are close, as the implementation looks straightforward.
We need to merge our patches.

Aug 14 2020, 2:29 AM · Restricted Project
sepavloff requested review of D85960: [AST][FPEnv] Keep FP options in trailing storage of CastExpr.
Aug 14 2020, 2:17 AM · Restricted Project

Aug 12 2020

sepavloff updated the diff for D74730: [FPEnv][X86] Implement lowering of llvm.set.rounding.

Clang-formatted the patch

Aug 12 2020, 9:38 AM · Restricted Project
sepavloff updated the diff for D74730: [FPEnv][X86] Implement lowering of llvm.set.rounding.

Rebased and used update_llc_test_checks.py script

Aug 12 2020, 9:33 AM · Restricted Project
sepavloff updated the diff for D74729: [FPEnv] Intrinsic for setting rounding mode.

Rebased patch

Aug 12 2020, 9:30 AM · Restricted Project
sepavloff updated the diff for D83036: [X86][FPEnv] Lowering of {get,set,reset}_fpmode.

Rebased and used update_llc_test_checks.py script

Aug 12 2020, 7:33 AM · Restricted Project
sepavloff updated the diff for D82525: [FPEnv] Intrinsics for access to FP control modes.

Rebased patch

Aug 12 2020, 7:30 AM · Restricted Project

Aug 3 2020

sepavloff added a comment to D82525: [FPEnv] Intrinsics for access to FP control modes.

Ping.

Aug 3 2020, 5:10 AM · Restricted Project
sepavloff added a comment to D78902: [Driver] Add output file to properties of Command.

Ping.

Aug 3 2020, 4:29 AM · Restricted Project

Jul 30 2020

sepavloff updated the diff for D83036: [X86][FPEnv] Lowering of {get,set,reset}_fpmode.

Rebased patch

Jul 30 2020, 1:41 AM · Restricted Project
sepavloff updated the diff for D82525: [FPEnv] Intrinsics for access to FP control modes.

Rebased patch

Jul 30 2020, 1:37 AM · Restricted Project

Jul 29 2020

sepavloff committed rG032ed39defc7: [Support] Class to facilitate file locking (authored by sepavloff).
[Support] Class to facilitate file locking
Jul 29 2020, 11:43 PM
sepavloff closed D79066: [Support] Class to facilitate file locking.
Jul 29 2020, 11:43 PM · Restricted Project

Jul 28 2020

sepavloff committed rG536736995bf5: [Support] Add file lock/unlock functions (authored by sepavloff).
[Support] Add file lock/unlock functions
Jul 28 2020, 2:45 AM
sepavloff closed D78896: [Support] Add file lock/unlock functions.
Jul 28 2020, 2:45 AM · Restricted Project
sepavloff accepted D84159: GlobalISel: Handle llvm.roundeven.

The patch looks good to me, however I am not experienced in GlobalISel. Someone more familiar with it should look at this patch.

Jul 28 2020, 12:04 AM · Restricted Project

Jul 27 2020

sepavloff accepted D84592: [X86] Add custom lowering for llvm.roundeven with sse4.1..

LGTM.

Jul 27 2020, 11:55 PM · Restricted Project
sepavloff added inline comments to D84592: [X86] Add custom lowering for llvm.roundeven with sse4.1..
Jul 27 2020, 9:45 PM · Restricted Project
sepavloff added a comment to D78896: [Support] Add file lock/unlock functions.

As I noted on April 30, I'm OK with the Windows portions of this. I didn't explicitly "Accept" because I didn't want to pre-empt the concerns of the other reviewers.

I see that @MaskRay is still marked as requesting revisions.

Jul 27 2020, 11:03 AM · Restricted Project
sepavloff added inline comments to D84159: GlobalISel: Handle llvm.roundeven.
Jul 27 2020, 9:17 AM · Restricted Project
sepavloff updated the diff for D78899: [Driver] Add callback to Command execution.

Rebased patch

Jul 27 2020, 2:28 AM · Restricted Project
sepavloff added a reviewer for D78896: [Support] Add file lock/unlock functions: amccarth.

@amccarth Could you please review Windows part of this patch? Thank you.

Jul 27 2020, 1:00 AM · Restricted Project
sepavloff added a comment to D78902: [Driver] Add output file to properties of Command.

Adding output files property is a prerequisite for D78903 (Add option -fproc-stat-report). Despite large size of the patch, the change is very simple: it only adds new state variable OutputFilenames initialized by the new parameter to the constructor of Command.

Jul 27 2020, 12:57 AM · Restricted Project

Jul 26 2020

sepavloff updated the diff for D78902: [Driver] Add output file to properties of Command.

Rebased patch

Jul 26 2020, 11:47 PM · Restricted Project
sepavloff updated the diff for D74730: [FPEnv][X86] Implement lowering of llvm.set.rounding.

Rebased patch

Jul 26 2020, 10:11 PM · Restricted Project
sepavloff updated the diff for D74729: [FPEnv] Intrinsic for setting rounding mode.

Rebased patch

Jul 26 2020, 10:06 PM · Restricted Project

Jul 23 2020

sepavloff committed rG70e7aa4a4ed3: [AST][FPEnv] Keep FP options in trailing storage of CallExpr (authored by sepavloff).
[AST][FPEnv] Keep FP options in trailing storage of CallExpr
Jul 23 2020, 10:06 PM
sepavloff closed D84343: [AST] Keep FP options in trailing storage of CallExpr.
Jul 23 2020, 10:05 PM · Restricted Project
sepavloff added inline comments to D84159: GlobalISel: Handle llvm.roundeven.
Jul 23 2020, 6:40 AM · Restricted Project
sepavloff updated the diff for D84343: [AST] Keep FP options in trailing storage of CallExpr.

Extended test with PCH read

Jul 23 2020, 12:22 AM · Restricted Project

Jul 22 2020

sepavloff committed rGdab898f9ab62: [Windows] Fix limit on command line size (authored by sepavloff).
[Windows] Fix limit on command line size
Jul 22 2020, 10:27 PM
sepavloff closed D83772: [Windows] Fix limit on command line size.
Jul 22 2020, 10:26 PM · Restricted Project, Restricted Project
Herald added a project to D84343: [AST] Keep FP options in trailing storage of CallExpr: Restricted Project.
Jul 22 2020, 9:59 AM · Restricted Project

Jul 21 2020

sepavloff added reviewers for D83772: [Windows] Fix limit on command line size: k8stone, max-kudr.

@k8stone @max-kudr Could you please review the changes for LLDB?

Jul 21 2020, 11:31 PM · Restricted Project, Restricted Project
sepavloff updated the diff for D83772: [Windows] Fix limit on command line size.

Added changes for LLDB

Jul 21 2020, 11:28 PM · Restricted Project, Restricted Project
sepavloff reopened D83772: [Windows] Fix limit on command line size.
Jul 21 2020, 11:27 PM · Restricted Project, Restricted Project
sepavloff committed rGac0edc55887b: Revert "[Windows] Fix limit on command line size" (authored by sepavloff).
Revert "[Windows] Fix limit on command line size"
Jul 21 2020, 11:01 AM
sepavloff added a reverting change for rGd4020ef7c474: [Windows] Fix limit on command line size: rGac0edc55887b: Revert "[Windows] Fix limit on command line size".
Jul 21 2020, 11:01 AM
sepavloff committed rGd4020ef7c474: [Windows] Fix limit on command line size (authored by sepavloff).
[Windows] Fix limit on command line size
Jul 21 2020, 3:34 AM
sepavloff closed D83772: [Windows] Fix limit on command line size.
Jul 21 2020, 3:34 AM · Restricted Project, Restricted Project
sepavloff committed rG21cd7b72a3d4: Use typedef to represent storage type in FPOption and FPOptionsOverride (authored by sepavloff).
Use typedef to represent storage type in FPOption and FPOptionsOverride
Jul 21 2020, 12:37 AM
sepavloff closed D84147: Use typedef to represent storage type in FPOption and FPOptionsOverride.
Jul 21 2020, 12:37 AM · Restricted Project