Page MenuHomePhabricator

[ELF][AArch64] Rename --force-bti to -z force-bti and --pac-plt to -z pac-plt
ClosedPublic

Authored by MaskRay on Dec 10 2019, 10:17 PM.

Details

Summary

The original design used --foo but the upstream complained that ELF only
options should be -z foo. See https://sourceware.org/ml/binutils/2019-04/msg00151.html
https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=8bf6d176b0a442a8091d338d4af971591d19922c
made the rename.

Our --force-bti and --pac-plt implement the same functionality, so it
seems wise to be consistent with GNU ld.

Diff Detail

Event Timeline

MaskRay created this revision.Dec 10 2019, 10:17 PM
grimar added a comment.EditedDec 11 2019, 12:58 AM

I'd add to the link to the description https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=8bf6d176b0a442a8091d338d4af971591d19922c

It looks like they also just removed the option and added a new -z option, like this patch does. To this LG to me, but lets wait for other opinions too.

peter.smith accepted this revision.Dec 11 2019, 1:50 AM

Looks good to me.

To my knowledge there is only a small amount of people using this option doing early software work in preparation for the hardware. I think that as long as I warn them this is coming then this should be fine.

This revision is now accepted and ready to land.Dec 11 2019, 1:50 AM
MaskRay updated this revision to Diff 233391.Dec 11 2019, 9:24 AM
MaskRay edited the summary of this revision. (Show Details)

Add more information about the rename and our rationale to switch

This revision was automatically updated to reflect the committed changes.