The code generation is exactly the same as it was.
But note that the special handling of untied tasks is still handled by emitUntiedSwitch in clang.
Paths
| Differential D69828
[OpenMP] Lower taskwait using OpenMP IR Builder ClosedPublic Authored by rogfer01 on Nov 4 2019, 3:18 PM.
Details Summary The code generation is exactly the same as it was. But note that the special handling of untied tasks is still handled by emitUntiedSwitch in clang.
Diff Detail Event TimelineComment Actions
FWIW, calling getThreadID(getIdent(SrcLocStr)) is the right thing to do here. We do use a cache in that method and at the end of the optimization pipeline, after inlining, etc. we can replace/merge omp_get_thread_id, __kmpc_global_thread_num, and global_tid arguments as a separate (more powerful) step.
rogfer01 marked an inline comment as done. Comment ActionsChangeLog:
Comment Actions
FWIW, We will just clean up in a later pass (under review). We have to do that anyway, adding some smarts here is barely worth it and I also removed similar logic from my patches. This revision is now accepted and ready to land.Nov 26 2019, 8:10 PM Comment Actions
Sure. I actually forgot to update the summary because you already mentioned this IIRC.
rogfer01 retitled this revision from [WIP][OpenMP] Lower taskwait using OpenMP IR Builder to [OpenMP] Lower taskwait using OpenMP IR Builder.Nov 27 2019, 3:17 AM Comment Actions ChangeLog:
rogfer01 added a child revision: D70799: [OpenMP] Lower taskyield using OpenMP IR Builder.Dec 12 2019, 1:21 AM Closed by commit rGa82f35e17621: [OpenMP] Lower taskwait using OpenMP IR Builder (authored by rogfer01). · Explain WhyFeb 14 2020, 1:56 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 233531 clang/lib/CodeGen/CGOpenMPRuntime.cpp
clang/test/OpenMP/task_codegen.cpp
clang/test/OpenMP/taskwait_codegen.cpp
llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h
llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
|
This is to preserve exactly the same behaviour as before.