Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D158590

[RISCV] Fix assertion of getShuffleCost
ClosedPublic
Actions

Authored by wangpc on Aug 23 2023, 2:56 AM.

Details

Reviewers
luke
ABataev
craig.topper
reames
Commits
rG9a82bda9dedf: [RISCV] Fix assertion of getShuffleCost
Summary

This assertion is introduced by D157425.

We should calculate the cost iff Mask is not empty.

Fixes 64901

Diff Detail

Event Timeline

wangpc created this revision.Aug 23 2023, 2:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 2:56 AM
Herald added subscribers: jobnoorman, sunshaoce, VincentWu and 28 others. · View Herald Transcript
wangpc requested review of this revision.Aug 23 2023, 2:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 2:56 AM
Herald added subscribers: llvm-commits, eopXD, MaskRay. · View Herald Transcript
wangpc edited the summary of this revision. (Show Details)Aug 23 2023, 3:25 AM
Harbormaster completed remote builds in B254288: Diff 552641.Aug 23 2023, 3:26 AM
ABataev added inline comments.Aug 23 2023, 4:15 AM
llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
364

!Mask.empty()

wangpc updated this revision to Diff 552661.Aug 23 2023, 4:54 AM

Address comment.

ABataev accepted this revision.Aug 23 2023, 4:55 AM

LG

This revision is now accepted and ready to land.Aug 23 2023, 4:55 AM
wangpc updated this revision to Diff 552664.Aug 23 2023, 5:09 AM

move test to reductions.ll.

This revision was landed with ongoing or failed builds.Aug 23 2023, 5:12 AM
Closed by commit rG9a82bda9dedf: [RISCV] Fix assertion of getShuffleCost (authored by wangpc). · Explain Why
This revision was automatically updated to reflect the committed changes.
wangpc added a commit: rG9a82bda9dedf: [RISCV] Fix assertion of getShuffleCost.
Harbormaster completed remote builds in B254305: Diff 552664.Aug 23 2023, 5:46 AM

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
2 lines
test/
Transforms/
SLPVectorizer/
RISCV/
93 lines

Diff 552665

View Options

llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp

Loading...
View Options

llvm/test/Transforms/SLPVectorizer/RISCV/reductions.ll

Loading...