This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Fix vfwcvt/vfncvt pseudos w/ rounding mode lowering
ClosedPublic

Authored by luke on Jun 30 2023, 9:49 AM.

Details

Summary

Some signed opcodes were being lowered to their unsigned counterparts and
vice-versa.

Diff Detail

Event Timeline

luke created this revision.Jun 30 2023, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2023, 9:49 AM
luke requested review of this revision.Jun 30 2023, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 30 2023, 9:49 AM
luke added a comment.Jun 30 2023, 9:53 AM

Looks like a miscompile (and the culprit is me), should this be backported?

craig.topper accepted this revision.Jun 30 2023, 10:23 AM

LGTM. I support backporting.

This revision is now accepted and ready to land.Jun 30 2023, 10:23 AM
This revision was automatically updated to reflect the committed changes.