Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D151434

[RISCV] Generalise shouldExtendTypeInLibcall logic to apply to all <XLEN floats on soft ABIs
ClosedPublic
Actions

Authored by asb on May 25 2023, 5:39 AM.

Details

Reviewers
craig.topper
reames
kito-cheng
jrtc27
Commits
rGc4efcd6970e2: [RISCV] Generalise shouldExtendTypeInLibcall logic to apply to all <XLEN floats…
Summary

This results in improved codegen for half/bf16 libcalls on soft ABIs

Adds a RISCVSubtarget helper method for determining if a soft FP ABI is being targeted (future bf16 related patches make use of this).

Diff Detail

Event Timeline

asb created this revision.May 25 2023, 5:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 5:39 AM
Herald added subscribers: jobnoorman, luke, wingo and 27 others. · View Herald Transcript
asb requested review of this revision.May 25 2023, 5:39 AM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 5:39 AM
Herald added subscribers: • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B234476: Diff 525559.May 25 2023, 6:29 AM
asb updated this revision to Diff 526187.May 26 2023, 2:00 PM
asb edited the summary of this revision. (Show Details)

Rebase, add a helper method for determining if we're targeting a soft FP ABI.

asb added a child revision: D151563: [SelectionDAG] Implement soft FP legalisation for bf16 FP_EXTEND and BF16_TO_FP.May 26 2023, 2:00 PM
Harbormaster completed remote builds in B234960: Diff 526187.May 26 2023, 2:38 PM
asb mentioned this in rG061e368fe213: [SelectionDAG] Implement soft FP legalisation for bf16 FP_EXTEND and BF16_TO_FP.May 29 2023, 2:34 AM
asb updated this revision to Diff 526453.May 29 2023, 10:08 AM
asb edited the summary of this revision. (Show Details)

Rebase on top of D151563

asb removed a child revision: D151563: [SelectionDAG] Implement soft FP legalisation for bf16 FP_EXTEND and BF16_TO_FP.May 29 2023, 10:08 AM
Harbormaster completed remote builds in B235164: Diff 526453.May 29 2023, 11:02 AM
asb added a child revision: D151663: [RISCV] Implement support for bf16 truncate/extend on hard FP targets.May 29 2023, 1:39 PM
kito-cheng accepted this revision.May 29 2023, 7:08 PM

LGTM :)

This revision is now accepted and ready to land.May 29 2023, 7:08 PM
Closed by commit rGc4efcd6970e2: [RISCV] Generalise shouldExtendTypeInLibcall logic to apply to all <XLEN floats… (authored by asb). · Explain WhyMay 30 2023, 3:04 AM
This revision was automatically updated to reflect the committed changes.
asb added a commit: rGc4efcd6970e2: [RISCV] Generalise shouldExtendTypeInLibcall logic to apply to all <XLEN floats….

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
6 lines
5 lines
test/
CodeGen/
RISCV/
3 lines
14 lines

Diff 526453

View Options

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Loading...
View Options

llvm/lib/Target/RISCV/RISCVSubtarget.h

Loading...
View Options

llvm/test/CodeGen/RISCV/bfloat.ll

Loading...
View Options

llvm/test/CodeGen/RISCV/half-convert.ll

Loading...