Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D147004

[RISCV] Add helper function for RVV intrinsics in getTgtMemIntrinsic. NFC
ClosedPublic
Actions

Authored by craig.topper on Mar 27 2023, 3:00 PM.

Details

Reviewers
reames
luke
asb
kito-cheng
Commits
rG98798a5a900e: [RISCV] Add helper function for RVV intrinsics in getTgtMemIntrinsic. NFC
Summary

Preparation for adding the other RVV load/store intrinsics we use
for the C API.

Diff Detail

Event Timeline

craig.topper created this revision.Mar 27 2023, 3:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2023, 3:00 PM
Herald added subscribers: jobnoorman, VincentWu, vkmr and 26 others. · View Herald Transcript
craig.topper requested review of this revision.Mar 27 2023, 3:00 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 27 2023, 3:00 PM
Herald added subscribers: • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
craig.topper planned changes to this revision.Mar 27 2023, 3:27 PM
craig.topper updated this revision to Diff 508820.Mar 27 2023, 3:37 PM

Autodetect struct types so we don't need IsSegment.
Use MemTy for Align.

Harbormaster completed remote builds in B222126: Diff 508820.Mar 27 2023, 4:36 PM
kito-cheng accepted this revision.Mar 28 2023, 6:24 PM

LGTM

This revision is now accepted and ready to land.Mar 28 2023, 6:24 PM
craig.topper updated this revision to Diff 509219.Mar 28 2023, 11:12 PM

Fold return true into the helper`.

craig.topper added a child revision: D147119: [RISCV] Add vector load/store intrinsics to getTgtMemIntrinsic..Mar 29 2023, 12:48 AM
Harbormaster completed remote builds in B222413: Diff 509219.Mar 29 2023, 4:05 AM
asb accepted this revision.Mar 29 2023, 9:45 AM

LGTM.

Closed by commit rG98798a5a900e: [RISCV] Add helper function for RVV intrinsics in getTgtMemIntrinsic. NFC (authored by craig.topper). · Explain WhyMar 29 2023, 3:34 PM
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rG98798a5a900e: [RISCV] Add helper function for RVV intrinsics in getTgtMemIntrinsic. NFC.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
77 lines

Diff 509488

View Options

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Loading...