Page MenuHomePhabricator
Differential D146119

[llvm-readobj][AMDGPU] Bypass MD verification for PAL
ClosedPublic
Actions

Authored by Pierre-vh on Mar 15 2023, 2:53 AM.

Details

Reviewers
arsenm
kzhuravl
jhenderson
dstuttard
foad
tpr
Commits
rG415956fe7ef2: [llvm-readobj][AMDGPU] Bypass MD verification for PAL
Summary

Small split change from D146023.

Migrate elf-notes to v4 and fix llvm-readobj to work with PAL metadata.

Diff Detail

Event Timeline

Pierre-vh created this revision.Mar 15 2023, 2:53 AM
Herald added a reviewer: jhenderson. · View Herald TranscriptMar 15 2023, 2:53 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: kosarev, kerbowa, tpr and 3 others. · View Herald Transcript
Pierre-vh requested review of this revision.Mar 15 2023, 2:53 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2023, 2:53 AM
Herald added subscribers: llvm-commits, MaskRay, wdng. · View Herald Transcript
Pierre-vh mentioned this in D146023: [AMDGPU] Remove Code Object V2.Mar 15 2023, 2:54 AM
Pierre-vh added a child revision: D146023: [AMDGPU] Remove Code Object V2.Mar 15 2023, 2:54 AM
Harbormaster completed remote builds in B219578: Diff 505412.Mar 15 2023, 4:15 AM
arsenm added inline comments.Mar 15 2023, 6:41 AM
llvm/tools/llvm-readobj/ELFDumper.cpp
5519

Why, I don't understand?

5522

Why isn't this on only under an assert?

5522

Nevermind, this isn't codegen

jhenderson added a comment.Mar 16 2023, 1:23 AM

One nit from me. Somebody who understands AMDGPU will need to do a proper review though.

llvm/tools/llvm-readobj/ELFDumper.cpp
5520
Pierre-vh updated this revision to Diff 505795.Mar 16 2023, 6:37 AM
Pierre-vh marked 4 inline comments as done.

Comment

llvm/tools/llvm-readobj/ELFDumper.cpp
5519

It's only designed for AMDHSA, it looks for keys that have amdhsa (e.g. amdhsa.version) and fails when it doesn't find them

Harbormaster completed remote builds in B219859: Diff 505795.Mar 16 2023, 7:36 AM
arsenm added reviewers: dstuttard, foad, tpr.Mar 17 2023, 12:16 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptMar 17 2023, 12:16 PM
Pierre-vh updated this revision to Diff 508504.Mar 27 2023, 12:34 AM

Rebase (ping?)

Harbormaster completed remote builds in B221900: Diff 508504.Mar 27 2023, 1:36 AM
Pierre-vh added a comment.Apr 17 2023, 3:25 AM

Ping

foad added inline comments.Apr 17 2023, 3:42 AM
llvm/tools/llvm-readobj/ELFDumper.cpp
5521

Since this is AMDHSA stuff, could you check for the presence of "amdhsa." instead of the absence of "amdpal."?

Pierre-vh updated this revision to Diff 514161.Apr 17 2023, 4:45 AM
Pierre-vh marked an inline comment as done.

Change check

Harbormaster completed remote builds in B226051: Diff 514161.Apr 17 2023, 5:22 AM
Pierre-vh added a comment.Tue, May 2, 12:11 AM

Ping

kzhuravl accepted this revision.Tue, May 2, 7:00 AM

looks good

This revision is now accepted and ready to land.Tue, May 2, 7:00 AM
Closed by commit rG415956fe7ef2: [llvm-readobj][AMDGPU] Bypass MD verification for PAL (authored by Pierre-vh). · Explain WhyTue, May 2, 11:45 PM
This revision was automatically updated to reflect the committed changes.
Pierre-vh added a commit: rG415956fe7ef2: [llvm-readobj][AMDGPU] Bypass MD verification for PAL.

Revision Contents
Changeset List

PathSize
llvm/
test/
CodeGen/
AMDGPU/
62 lines
tools/
llvm-readobj/
12 lines

Diff 518983

View Options

llvm/test/CodeGen/AMDGPU/elf-notes.ll

Loading...
View Options

llvm/tools/llvm-readobj/ELFDumper.cpp

Loading...