This is an archive of the discontinued LLVM Phabricator instance.

[clang] Remove legacy -m(no)-code-object-v3 options
ClosedPublic

Authored by Pierre-vh on Mar 9 2023, 1:05 AM.

Details

Summary

Code object V2 and V3 have been deprecated for a long time.
They're now scheduled to be removed completely from LLVM in the coming weeks/months.

There is no reason to support those legacy options anymore as they've
also been deprecated for a long time.

Diff Detail

Event Timeline

Pierre-vh created this revision.Mar 9 2023, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 1:05 AM
Pierre-vh requested review of this revision.Mar 9 2023, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 1:05 AM
Pierre-vh added a reviewer: Restricted Project.Mar 9 2023, 1:05 AM
artem.tamazov added a subscriber: artem.tamazov.

No objections from MIOpen side.

This revision is now accepted and ready to land.Mar 9 2023, 7:02 AM
yaxunl requested changes to this revision.Mar 9 2023, 7:40 AM

Did you go through the deprecation process for this option? We need to send a documentation team first so that it is announced to the users. Then in the next release we can deprecate it.

This revision now requires changes to proceed.Mar 9 2023, 7:40 AM

Did you go through the deprecation process for this option? We need to send a documentation team first so that it is announced to the users. Then in the next release we can deprecate it.

Yes, it went through deprecation process. V2 has been deprecated in full for more than a year now.

yaxunl accepted this revision.Mar 9 2023, 9:32 AM

LGTM. Thanks.

This revision is now accepted and ready to land.Mar 9 2023, 9:32 AM

I'll wait a couple of more days and then land, if no one has any objections.
As said before this has been deprecated for a long time, and clang was already warning on use of those options. Removal has been pending for a while :)

This revision was automatically updated to reflect the committed changes.

These changes need a release note. Given that this has been deprecated, is there documentation that should have been removed as well?

In D145671#4223655, @c wrote:

These changes need a release note. Given that this has been deprecated, is there documentation that should have been removed as well?

I can't find anything in the docs about code-object-v3 so I don't think there's any documentation left. For the release note, I opened a diff: D146945

In D145671#4223655, @c wrote:

These changes need a release note. Given that this has been deprecated, is there documentation that should have been removed as well?

I can't find anything in the docs about code-object-v3 so I don't think there's any documentation left. For the release note, I opened a diff: D146945

Thank you!

clang/lib/Driver/ToolChains/CommonArgs.cpp