Page MenuHomePhabricator

dstuttard (David Stuttard)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 25 2017, 7:29 AM (320 w, 5 d)

Recent Activity

Today

dstuttard added a comment to D144503: [ADT] Allow `llvm::enumerate` to enumerate over multiple ranges.

I note from an earlier comment that updating VS2022 with latest patches solved this issue for @srj
But is the issue similar for the minimum required version of MSVC (currently Visual Studio 2019 / v16.0 )??

It passed across all windows buildbots, which includes VS 2019. Example: https://lab.llvm.org/buildbot/#/builders/13/builds/33254

Mon, Mar 20, 10:39 AM · Restricted Project, Restricted Project, Restricted Project
dstuttard added a comment to D144503: [ADT] Allow `llvm::enumerate` to enumerate over multiple ranges.

also seeing similar error in downstream windows build of llvm.

There is also a similar breakage in InstrInfoEmitter.cpp:

C:\build_bot\worker\llvm-17-x86-32-windows\llvm-project\llvm\utils\TableGen\InstrInfoEmitter.cpp(120): error C2440: 'initializing': cannot convert from 'size_t' to '_This'
        with
        [
            _This=llvm::Record *const &
        ]
Mon, Mar 20, 10:10 AM · Restricted Project, Restricted Project, Restricted Project

Feb 13 2023

dstuttard committed rGc4f7cc867299: [Coroutines] Modify CoroFrame materializable into a callback (authored by dstuttard).
[Coroutines] Modify CoroFrame materializable into a callback
Feb 13 2023, 3:07 AM · Restricted Project, Restricted Project
dstuttard closed D142621: [Couroutines] Modify CoroFrame materializable into a callback.
Feb 13 2023, 3:07 AM · Restricted Project, Restricted Project
dstuttard committed rG3e51af9b5b3a: [Coroutines] Improve rematerialization stage (authored by dstuttard).
[Coroutines] Improve rematerialization stage
Feb 13 2023, 3:07 AM · Restricted Project, Restricted Project
dstuttard closed D142620: [Coroutines] Improve rematerialization stage.
Feb 13 2023, 3:06 AM · Restricted Project, Restricted Project
dstuttard committed rG35106ad1009f: [Coroutines] Presubmit test for more coro remats (authored by dstuttard).
[Coroutines] Presubmit test for more coro remats
Feb 13 2023, 3:06 AM · Restricted Project, Restricted Project
dstuttard closed D142619: [Coroutines] Presubmit test for more coro remats.
Feb 13 2023, 3:06 AM · Restricted Project, Restricted Project

Feb 10 2023

dstuttard updated the diff for D142621: [Couroutines] Modify CoroFrame materializable into a callback.

Fix up ASSERT_TRUE to pass messages correctly

Feb 10 2023, 5:10 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142621: [Couroutines] Modify CoroFrame materializable into a callback.

Thanks for the speedy review Jannik
Changes made

Feb 10 2023, 4:42 AM · Restricted Project, Restricted Project
dstuttard added a comment to D142621: [Couroutines] Modify CoroFrame materializable into a callback.

Got it. But it is still not good to modify the upstream due the requirement from the downstream. (I know this happens in llvm occasionally. But it is still not good, right?)

I think it may better for you to contribute the other materialization options you mentioned. Or you can try to add a unittest if you don't want to contribute the downstream extension to public for any reason . Otherwise, even all people here get in consensus. It is possible that other developers found the coding here is redundant and optimize it with a NFC patch directly. (This happens a lot in llvm)

Feb 10 2023, 3:44 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142621: [Couroutines] Modify CoroFrame materializable into a callback.

Add unit test demonstrating use of extra rematerialization callback

Feb 10 2023, 3:42 AM · Restricted Project, Restricted Project

Feb 9 2023

dstuttard added a comment to D142621: [Couroutines] Modify CoroFrame materializable into a callback.

While this is innocent and no harmful, I prefer to land this after we found a usage for this someday. It wouldn't be a problem to do such a NFC change any times.

We have a use-case for this change for one of our backends.

Feb 9 2023, 8:42 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142621: [Couroutines] Modify CoroFrame materializable into a callback.

Address review commit (sorry Jannik - missed it before)

Feb 9 2023, 5:13 AM · Restricted Project, Restricted Project
dstuttard added a comment to D142621: [Couroutines] Modify CoroFrame materializable into a callback.

While this is innocent and no harmful, I prefer to land this after we found a usage for this someday. It wouldn't be a problem to do such a NFC change any times.

Feb 9 2023, 4:51 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142621: [Couroutines] Modify CoroFrame materializable into a callback.

Rebase on fixed version

Feb 9 2023, 4:49 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142620: [Coroutines] Improve rematerialization stage.

clang-format change

Feb 9 2023, 4:45 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142620: [Coroutines] Improve rematerialization stage.

Removed assert that was incorrect (and causing build-bot pre-checkin failures)

Feb 9 2023, 4:42 AM · Restricted Project, Restricted Project

Feb 7 2023

dstuttard added inline comments to D142620: [Coroutines] Improve rematerialization stage.
Feb 7 2023, 8:45 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142621: [Couroutines] Modify CoroFrame materializable into a callback.

Rebased

Feb 7 2023, 8:45 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142620: [Coroutines] Improve rematerialization stage.

More changes based on feedback

Feb 7 2023, 8:44 AM · Restricted Project, Restricted Project

Feb 6 2023

dstuttard added a comment to D142620: [Coroutines] Improve rematerialization stage.

Thanks for the feedback - see the comments and the udpated patch(es)

Feb 6 2023, 10:40 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142621: [Couroutines] Modify CoroFrame materializable into a callback.

Addressing reviewer comments

Feb 6 2023, 10:39 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D142620: [Coroutines] Improve rematerialization stage.

Addressing reviewer comment

Feb 6 2023, 10:39 AM · Restricted Project, Restricted Project

Jan 26 2023

dstuttard added reviewers for D142621: [Couroutines] Modify CoroFrame materializable into a callback: sebastian-ne, jsilvanus, ChuanqiXu.
Jan 26 2023, 5:48 AM · Restricted Project, Restricted Project
dstuttard added reviewers for D142620: [Coroutines] Improve rematerialization stage: sebastian-ne, jsilvanus, ChuanqiXu.
Jan 26 2023, 5:47 AM · Restricted Project, Restricted Project
dstuttard requested review of D142621: [Couroutines] Modify CoroFrame materializable into a callback.
Jan 26 2023, 5:42 AM · Restricted Project, Restricted Project
dstuttard requested review of D142620: [Coroutines] Improve rematerialization stage.
Jan 26 2023, 5:41 AM · Restricted Project, Restricted Project
dstuttard requested review of D142619: [Coroutines] Presubmit test for more coro remats.
Jan 26 2023, 5:40 AM · Restricted Project, Restricted Project
dstuttard accepted D142537: [AMDGPU] sendmsg(MSG_ORDERED_PS_DONE) is not supported on GFX11.

LGTM

Jan 26 2023, 12:45 AM · Restricted Project, Restricted Project

Jan 10 2023

dstuttard added a comment to D141379: [AMDGPU] Temporarily disable FeatureBackOffBarrier for GFX11.

Well, this LGTM, but probably need some feedback from others.

Jan 10 2023, 7:18 AM · Restricted Project, Restricted Project

Nov 30 2022

dstuttard committed rG62498962e42d: ConstantFolding: Guard use of getFunction (authored by dstuttard).
ConstantFolding: Guard use of getFunction
Nov 30 2022, 6:13 AM · Restricted Project, Restricted Project
dstuttard closed D138642: ConstantFolding: Guard use of getFunction.
Nov 30 2022, 6:13 AM · Restricted Project, Restricted Project

Nov 28 2022

dstuttard committed rG7940888c5987: [AMDGPU] Intrinsic to expose s_wait_event for export ready (authored by dstuttard).
[AMDGPU] Intrinsic to expose s_wait_event for export ready
Nov 28 2022, 3:28 AM · Restricted Project, Restricted Project, Restricted Project
dstuttard closed D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready.
Nov 28 2022, 3:28 AM · Restricted Project, Restricted Project, Restricted Project

Nov 24 2022

dstuttard added a reviewer for D138642: ConstantFolding: Guard use of getFunction: arsenm.

Managed to get arc diff to work!

Nov 24 2022, 1:28 AM · Restricted Project, Restricted Project
dstuttard requested review of D138642: ConstantFolding: Guard use of getFunction.
Nov 24 2022, 1:27 AM · Restricted Project, Restricted Project

Nov 23 2022

dstuttard updated the diff for D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready.

Updated - adding test for builtin

Nov 23 2022, 2:05 AM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2022

dstuttard added inline comments to D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready.
Nov 21 2022, 1:34 AM · Restricted Project, Restricted Project, Restricted Project
dstuttard updated the diff for D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready.

Address review comments

Nov 21 2022, 1:28 AM · Restricted Project, Restricted Project, Restricted Project

Nov 17 2022

dstuttard updated the diff for D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready.

Updating based on review comments

Nov 17 2022, 8:53 AM · Restricted Project, Restricted Project, Restricted Project
dstuttard added inline comments to D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready.
Nov 17 2022, 8:51 AM · Restricted Project, Restricted Project, Restricted Project
dstuttard added a reviewer for D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready: foad.
Nov 17 2022, 7:52 AM · Restricted Project, Restricted Project, Restricted Project
dstuttard requested review of D138216: [AMDGPU] Intrinsic to expose s_wait_event for export ready.
Nov 17 2022, 7:51 AM · Restricted Project, Restricted Project, Restricted Project

Nov 4 2022

dstuttard accepted D137408: [StructurizeCFG][DebugInfo] Avoid use-after-free.

This fixes the issue I was observing. Thanks.

Nov 4 2022, 4:45 AM · Restricted Project, Restricted Project, Restricted Project

Oct 18 2022

dstuttard added a comment to rGa4b010034f57: [llvm-config] Make tests more resiliant.

Thanks (sorry I missed it on the original comments)

Oct 18 2022, 9:22 AM · Restricted Project, Restricted Project
dstuttard added a comment to rGa4b010034f57: [llvm-config] Make tests more resiliant.

Is something required for system-libs.windows.test too?

Oct 18 2022, 8:36 AM · Restricted Project, Restricted Project
dstuttard added a comment to D135110: [NFC] [HLSL] Move common metadata to LLVMFrontend.

I think that the reason we don't see the same failure for e.g. OpenACC is that there's a unittest/Frontend that requires OpenACC - if I comment out that subdir in the unittests/CMakeLists.txt it fails llvm-config test in the same way for OpenACC. Similarly, if I add FrontendHLSL as an LLVM_LINK_COMPONENT in unittests/Frontend/CMakeLists.txt (even though it isn't), the static lib is generated and llvm-lit llvm-config test passes.

Oct 18 2022, 3:16 AM · Restricted Project, Restricted Project, Restricted Project

Oct 5 2022

dstuttard committed rGd1d7d2235ced: [AggressiveInstCombine] Fix cases where non-opaque pointers are used (authored by dstuttard).
[AggressiveInstCombine] Fix cases where non-opaque pointers are used
Oct 5 2022, 5:44 AM · Restricted Project, Restricted Project
dstuttard closed D135249: [AggressiveInstCombine] Fix cases where non-opaque pointers are used.
Oct 5 2022, 5:44 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D135249: [AggressiveInstCombine] Fix cases where non-opaque pointers are used.

Include address space AS in the pointerto call

Oct 5 2022, 5:32 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D135249: [AggressiveInstCombine] Fix cases where non-opaque pointers are used.

Updated for review requests

Oct 5 2022, 4:10 AM · Restricted Project, Restricted Project
dstuttard added a comment to D135249: [AggressiveInstCombine] Fix cases where non-opaque pointers are used.

Thanks - removed the test and made the changes.

Oct 5 2022, 4:04 AM · Restricted Project, Restricted Project
dstuttard added reviewers for D135249: [AggressiveInstCombine] Fix cases where non-opaque pointers are used: bipmis, dmgreen, Kai.
Oct 5 2022, 2:07 AM · Restricted Project, Restricted Project
dstuttard added inline comments to D127392: [AggressiveInstCombine] Combine consecutive loads which are being merged to form a wider load..
Oct 5 2022, 2:06 AM · Restricted Project, Restricted Project
dstuttard requested review of D135249: [AggressiveInstCombine] Fix cases where non-opaque pointers are used.
Oct 5 2022, 2:05 AM · Restricted Project, Restricted Project

Aug 11 2022

dstuttard committed rG1d1cc05539e2: AMDGPU: mbcnt allow for non-zero src1 for known-bits (authored by dstuttard).
AMDGPU: mbcnt allow for non-zero src1 for known-bits
Aug 11 2022, 5:26 AM · Restricted Project, Restricted Project
dstuttard closed D131478: AMDGPU: mbcnt allow for non-zero src1 for known-bits.
Aug 11 2022, 5:26 AM · Restricted Project, Restricted Project

Aug 9 2022

dstuttard added reviewers for D131478: AMDGPU: mbcnt allow for non-zero src1 for known-bits: arsenm, rampitec.
Aug 9 2022, 3:08 AM · Restricted Project, Restricted Project
dstuttard requested review of D131478: AMDGPU: mbcnt allow for non-zero src1 for known-bits.
Aug 9 2022, 3:06 AM · Restricted Project, Restricted Project

Jul 26 2022

dstuttard accepted D130555: [CMake] Fix add_subdirectory llvm builds.

LGTM

Jul 26 2022, 2:23 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 25 2022

dstuttard committed rGb14d7bf75079: AMDGPU: Turn off force init 16 input SGPRS for pal (authored by dstuttard).
AMDGPU: Turn off force init 16 input SGPRS for pal
Jul 25 2022, 2:55 AM · Restricted Project, Restricted Project
dstuttard closed D129566: AMDGPU: Turn off force init 16 input SGPRS for pal.
Jul 25 2022, 2:55 AM · Restricted Project, Restricted Project

Jul 15 2022

dstuttard updated the diff for D129566: AMDGPU: Turn off force init 16 input SGPRS for pal.

Added a test

Jul 15 2022, 5:37 AM · Restricted Project, Restricted Project

Jul 13 2022

dstuttard updated the diff for D129566: AMDGPU: Turn off force init 16 input SGPRS for pal.

Updated with review suggestions

Jul 13 2022, 9:10 AM · Restricted Project, Restricted Project
dstuttard added a comment to D129566: AMDGPU: Turn off force init 16 input SGPRS for pal.

I wasn't sure whether Mesa would also have issues - I was going to follow that up, so thanks for the info.
I'll update as you suggest to !IsShader

Jul 13 2022, 5:11 AM · Restricted Project, Restricted Project

Jul 12 2022

dstuttard added a comment to D129566: AMDGPU: Turn off force init 16 input SGPRS for pal.

Additionally, not everything marked as inreg actually contributes to the NumUserSGPRs - so the knowledge about which arguments are and aren't would need to be added to the backend.

Jul 12 2022, 10:54 AM · Restricted Project, Restricted Project
dstuttard added a comment to D129566: AMDGPU: Turn off force init 16 input SGPRS for pal.

I don't see why PAL would get special treatment here. I think the problem is we don't really try to account for the formal arguments in the user SGPR count. A better fix would be to track that accurately

Jul 12 2022, 9:38 AM · Restricted Project, Restricted Project
dstuttard added reviewers for D129566: AMDGPU: Turn off force init 16 input SGPRS for pal: arsenm, foad.
Jul 12 2022, 8:17 AM · Restricted Project, Restricted Project
dstuttard requested review of D129566: AMDGPU: Turn off force init 16 input SGPRS for pal.
Jul 12 2022, 8:16 AM · Restricted Project, Restricted Project

Jun 16 2022

dstuttard committed rG77851cc1cfb9: [AMDGPU] Change use null for dead sdst to be gfx1030+ (authored by dstuttard).
[AMDGPU] Change use null for dead sdst to be gfx1030+
Jun 16 2022, 2:45 AM · Restricted Project, Restricted Project
dstuttard closed D127869: [AMDGPU] Change use null for dead sdst to be gfx1030+.
Jun 16 2022, 2:45 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D127869: [AMDGPU] Change use null for dead sdst to be gfx1030+.

Adding check lines back into mad_u64_u32.ll

Jun 16 2022, 2:35 AM · Restricted Project, Restricted Project
dstuttard updated the diff for D127869: [AMDGPU] Change use null for dead sdst to be gfx1030+.

Updated tests to include 1030 specific run lines

Jun 16 2022, 1:19 AM · Restricted Project, Restricted Project
dstuttard added inline comments to D127869: [AMDGPU] Change use null for dead sdst to be gfx1030+.
Jun 16 2022, 1:19 AM · Restricted Project, Restricted Project

Jun 15 2022

dstuttard updated the diff for D127869: [AMDGPU] Change use null for dead sdst to be gfx1030+.

Add test updates

Jun 15 2022, 9:21 AM · Restricted Project, Restricted Project
dstuttard added a comment to D127869: [AMDGPU] Change use null for dead sdst to be gfx1030+.

Forgot to update the tests. Stand by.

Jun 15 2022, 8:56 AM · Restricted Project, Restricted Project
dstuttard added reviewers for D127869: [AMDGPU] Change use null for dead sdst to be gfx1030+: rampitec, foad.
Jun 15 2022, 8:53 AM · Restricted Project, Restricted Project
dstuttard requested review of D127869: [AMDGPU] Change use null for dead sdst to be gfx1030+.
Jun 15 2022, 8:52 AM · Restricted Project, Restricted Project

Jun 13 2022

dstuttard added a comment to D127635: [AMDGPU] Work around GFX11 flat scratch SVS swizzling bug.

Well spotted. The problem is that it's difficult or impossible to persuade globalisel to use the svs addressing mode in the first place, because it assumes that frame offsets are divergent so doesn't put them in an sgpr for us. See AMDGPURegisterBankInfo.cpp:

Jun 13 2022, 6:36 AM · Restricted Project, Restricted Project
dstuttard added a comment to D127635: [AMDGPU] Work around GFX11 flat scratch SVS swizzling bug.

I note that this includes global isel changes - but none of the tests are testing it?

Jun 13 2022, 5:47 AM · Restricted Project, Restricted Project

Jun 7 2022

dstuttard added a comment to D127195: [CodeEmitter] Fix encoding wide instructions on big-endian hosts.

This looks reasonable to me, but I think we need someone else to confirm too.

Jun 7 2022, 8:41 AM · Restricted Project, Restricted Project

May 19 2022

dstuttard accepted D125976: [AMDGPU] Allow multiple uses of the same literal in SOP2/SOPC.

LGTM

May 19 2022, 8:30 AM · Restricted Project, Restricted Project

Mar 29 2022

dstuttard added inline comments to D122653: [AMDGPU] Document the intended semantics of llvm.amdgcn.s.buffer.load.
Mar 29 2022, 6:38 AM · Restricted Project, Restricted Project

Mar 15 2022

dstuttard updated the diff for D121691: [AMDGPU] Fix kill flag state for replaced operands.

Pushed an earlier commit by mistake

Mar 15 2022, 6:12 AM · Restricted Project, Restricted Project
dstuttard added reviewers for D121691: [AMDGPU] Fix kill flag state for replaced operands: rampitec, cdevadas.
Mar 15 2022, 6:06 AM · Restricted Project, Restricted Project
dstuttard added a comment to D121691: [AMDGPU] Fix kill flag state for replaced operands.

Picked this issue up in some testing - seems a logical fix.
I have a reproducer, but even the cut-down isn't that clean - do you think this requires a test?

Mar 15 2022, 6:05 AM · Restricted Project, Restricted Project
dstuttard requested review of D121691: [AMDGPU] Fix kill flag state for replaced operands.
Mar 15 2022, 6:01 AM · Restricted Project, Restricted Project

Dec 2 2021

dstuttard committed rG0e8590f06599: [AMDGPU] Add support for in-order bvh in waitcnt pass (authored by dstuttard).
[AMDGPU] Add support for in-order bvh in waitcnt pass
Dec 2 2021, 6:27 AM
dstuttard closed D114794: [AMDGPU] Add support for in-order bvh in waitcnt pass.
Dec 2 2021, 6:26 AM · Restricted Project
dstuttard committed rG17a3385c3538: [AMDGPU] Test for in-order waitcnt insertion for bvh instructions (authored by dstuttard).
[AMDGPU] Test for in-order waitcnt insertion for bvh instructions
Dec 2 2021, 6:26 AM
dstuttard closed D114792: [AMDGPU] Test for in-order waitcnt insertion for bvh instructions.
Dec 2 2021, 6:26 AM · Restricted Project

Nov 30 2021

dstuttard updated the diff for D114794: [AMDGPU] Add support for in-order bvh in waitcnt pass.

Spelling mistake (and rebase for test changes)

Nov 30 2021, 6:24 AM · Restricted Project
dstuttard updated the diff for D114792: [AMDGPU] Test for in-order waitcnt insertion for bvh instructions.

Updating test in light of review suggestions

Nov 30 2021, 6:22 AM · Restricted Project
dstuttard added inline comments to D114794: [AMDGPU] Add support for in-order bvh in waitcnt pass.
Nov 30 2021, 6:08 AM · Restricted Project
dstuttard added inline comments to D114792: [AMDGPU] Test for in-order waitcnt insertion for bvh instructions.
Nov 30 2021, 6:08 AM · Restricted Project
dstuttard added reviewers for D114794: [AMDGPU] Add support for in-order bvh in waitcnt pass: foad, rampitec.
Nov 30 2021, 6:05 AM · Restricted Project
dstuttard updated the diff for D114792: [AMDGPU] Test for in-order waitcnt insertion for bvh instructions.

Updating with link to change for which this is a pre-commit

Nov 30 2021, 6:03 AM · Restricted Project
dstuttard requested review of D114794: [AMDGPU] Add support for in-order bvh in waitcnt pass.
Nov 30 2021, 6:00 AM · Restricted Project
dstuttard added reviewers for D114792: [AMDGPU] Test for in-order waitcnt insertion for bvh instructions: foad, rampitec.

Pre-commit test

Nov 30 2021, 5:58 AM · Restricted Project