Page MenuHomePhabricator

dstuttard (David Stuttard)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 25 2017, 7:29 AM (155 w, 5 d)

Recent Activity

Dec 17 2019

dstuttard accepted D70975: [SDAG] remove use restriction in isNegatibleForFree() when called from getNegatedExpression().

Confirmed that this fix also solves my original problem per D70595

Dec 17 2019, 3:47 AM · Restricted Project

Dec 10 2019

dstuttard abandoned D70595: [TargetLowering] Allow constants with multiple uses.

Alternative fix D70975 works.

Dec 10 2019, 2:05 AM · Restricted Project
dstuttard accepted D70975: [SDAG] remove use restriction in isNegatibleForFree() when called from getNegatedExpression().

This fixes the issue I encountered for the original fix in D70595

Dec 10 2019, 2:05 AM · Restricted Project
dstuttard added a comment to D70595: [TargetLowering] Allow constants with multiple uses.

@dstuttard does D70975 cover the original problem motivating this patch?

Dec 10 2019, 2:05 AM · Restricted Project

Dec 4 2019

dstuttard committed rG46db60683422: AMDGPU: Avoid folding 2 constant operands into an SALU operation (authored by dstuttard).
AMDGPU: Avoid folding 2 constant operands into an SALU operation
Dec 4 2019, 2:44 AM
dstuttard closed D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.
Dec 4 2019, 2:44 AM · Restricted Project

Dec 3 2019

dstuttard added inline comments to D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.
Dec 3 2019, 3:27 AM · Restricted Project
dstuttard updated the diff for D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.

Made suggested changes

Dec 3 2019, 3:27 AM · Restricted Project

Dec 2 2019

dstuttard added reviewers for D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation: arsenm, foad.

I would have preferred to have put this check into isImmOperandLegal in SIInstrInfo.cpp - but that produced lots of lit regressions. Looks like commute operations use this function even when they are swapping rather than replacing the operand (which breaks).

Dec 2 2019, 5:16 AM · Restricted Project
dstuttard updated the diff for D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.

Formatting

Dec 2 2019, 5:07 AM · Restricted Project
dstuttard created D70896: AMDGPU: Avoid folding 2 constant operands into an SALU operation.
Dec 2 2019, 5:06 AM · Restricted Project
dstuttard added a reviewer for D70781: AMDGPU: Fix handling of infinite loops in fragment shaders: critson.
Dec 2 2019, 1:56 AM · Restricted Project

Nov 28 2019

dstuttard committed rG943d8326dd35: AMDGPU: Fix lit test checks with dag option (authored by dstuttard).
AMDGPU: Fix lit test checks with dag option
Nov 28 2019, 2:06 AM
dstuttard closed D70531: AMDGPU: Fix lit test checks with dag option.
Nov 28 2019, 2:06 AM · Restricted Project

Nov 27 2019

dstuttard updated the diff for D70595: [TargetLowering] Allow constants with multiple uses.

Changed the implementation slightly.
Now the isNegatibleForFree includes a bool for allowing multi-use
constants. This is only set to true for calls from getNegatedExpression so it
only allows for the situation where a constant becomes multi-use during
getNegatedExpression recursive evaluation.

Nov 27 2019, 7:22 AM · Restricted Project

Nov 26 2019

dstuttard added a comment to D70531: AMDGPU: Fix lit test checks with dag option.

Matt - are you happy for this to proceed?

Nov 26 2019, 9:01 AM · Restricted Project
dstuttard updated the diff for D70595: [TargetLowering] Allow constants with multiple uses.

Added test updates for failing lit tests.

Nov 26 2019, 9:01 AM · Restricted Project

Nov 22 2019

dstuttard added inline comments to D70531: AMDGPU: Fix lit test checks with dag option.
Nov 22 2019, 7:09 AM · Restricted Project
dstuttard added a comment to D70595: [TargetLowering] Allow constants with multiple uses.

I'd like to see more of the regressions on other targets (x86 in particular) - in many cases this will cause a lot of extra constant pool entries.

Nov 22 2019, 5:56 AM · Restricted Project
dstuttard added a comment to D70595: [TargetLowering] Allow constants with multiple uses.

I've got some failures as a result of this change in X86 (haven't tried the other backends). I guess that the failures are probably due to the fneg propagation working better for constants - but I haven't investigated yet. There will need to be more test changes as a result of this change.
My question is - does the change look reasonable? If so I'll take a look at the lit regressions for other backends.

Nov 22 2019, 5:10 AM · Restricted Project
dstuttard updated the diff for D70595: [TargetLowering] Allow constants with multiple uses.

Included wrong version of the test initially

Nov 22 2019, 4:25 AM · Restricted Project
dstuttard added a reviewer for D70595: [TargetLowering] Allow constants with multiple uses: RKSimon.

Added @RKSimon to review as the last major modifier of the code here.

Nov 22 2019, 4:25 AM · Restricted Project
dstuttard added inline comments to D70595: [TargetLowering] Allow constants with multiple uses.
Nov 22 2019, 4:25 AM · Restricted Project
dstuttard created D70595: [TargetLowering] Allow constants with multiple uses.
Nov 22 2019, 4:07 AM · Restricted Project
dstuttard updated the diff for D70531: AMDGPU: Fix lit test checks with dag option.

Replace COUNT-n with n DAG versions (DAG-COUNT-n doesn't work)

Nov 22 2019, 3:29 AM · Restricted Project
dstuttard added inline comments to D70531: AMDGPU: Fix lit test checks with dag option.
Nov 22 2019, 2:42 AM · Restricted Project

Nov 21 2019

dstuttard added a reviewer for D70531: AMDGPU: Fix lit test checks with dag option: rampitec.
Nov 21 2019, 3:41 AM · Restricted Project
dstuttard created D70531: AMDGPU: Fix lit test checks with dag option.
Nov 21 2019, 3:41 AM · Restricted Project

Oct 25 2019

dstuttard added a comment to D69430: Disallow dpp combining for dpp instructions without Src2 operand (when Src2 is required).

Maybe put [AMDGPU] into the subject line of the commit message

Oct 25 2019, 5:04 AM · Restricted Project
dstuttard accepted D69430: Disallow dpp combining for dpp instructions without Src2 operand (when Src2 is required).

LGTM

Oct 25 2019, 4:58 AM · Restricted Project

Oct 16 2019

dstuttard committed rG2d6a2303f83d: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands (authored by dstuttard).
[AMDGPU] Fix-up cases where writelane has 2 SGPR operands
Oct 16 2019, 7:40 AM
dstuttard closed D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.
Oct 16 2019, 7:40 AM · Restricted Project
dstuttard committed rL375004: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.
[AMDGPU] Fix-up cases where writelane has 2 SGPR operands
Oct 16 2019, 7:40 AM

Oct 7 2019

dstuttard added a comment to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

ping

Oct 7 2019, 12:41 AM · Restricted Project

Sep 30 2019

dstuttard added a comment to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

Matt - are you now happy for me to submit this? (It is tagged as approved, but since you've made some extra comments I'm waiting for you to agree with the latest changes).

Sep 30 2019, 12:49 AM · Restricted Project

Sep 23 2019

dstuttard added a comment to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

Made suggested changes - is this more in line with what you were thinking Matt?

Sep 23 2019, 1:59 AM · Restricted Project
dstuttard updated the diff for D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

Updates in light of review comments

Sep 23 2019, 1:59 AM · Restricted Project

Sep 19 2019

dstuttard added inline comments to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.
Sep 19 2019, 10:18 AM · Restricted Project
dstuttard updated the diff for D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

Made some changes based on review

Sep 19 2019, 10:12 AM · Restricted Project

Sep 18 2019

dstuttard updated the diff for D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

GFX10 support has gone in since this change was approved - gfx10 allows 2 sgprs
on the constant bus. Implementation updated to allow for this.

Sep 18 2019, 7:49 AM · Restricted Project

Sep 4 2019

dstuttard committed rL370873: Request commit access for dstuttard.
Request commit access for dstuttard
Sep 4 2019, 3:52 AM

Jul 29 2019

dstuttard committed rG20235ef3e751: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions (authored by dstuttard).
[AMDGPU] Enable v4f16 and above for v_pk_fma instructions
Jul 29 2019, 8:16 AM
dstuttard committed rL367206: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.
[AMDGPU] Enable v4f16 and above for v_pk_fma instructions
Jul 29 2019, 8:16 AM
dstuttard closed D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.
Jul 29 2019, 8:16 AM · Restricted Project

Jul 26 2019

dstuttard updated the diff for D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.

Managed to get the fmac test to keep using fmac
Also updated the test to use non-anonymous values

Jul 26 2019, 9:41 AM · Restricted Project
dstuttard updated the diff for D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.

Changed test to use fma intrinsic

Jul 26 2019, 7:21 AM · Restricted Project
dstuttard added a reviewer for D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions: rampitec.

+Stas to comment on the v_fmac_f16 test change.
Is it acceptable to change the result to look for v_pk_fma_f16 rather than 2 v_fmac_f16 instructions? If not, any suggestions on how to get the compiler to generate 2 x fmac instead?

Jul 26 2019, 5:13 AM · Restricted Project
dstuttard added reviewers for D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions: arsenm, piotr.
Jul 26 2019, 3:39 AM · Restricted Project
dstuttard created D65325: [AMDGPU] Enable v4f16 and above for v_pk_fma instructions.
Jul 26 2019, 3:38 AM · Restricted Project

Jul 17 2019

dstuttard abandoned D63639: [AMDGPU] Prevent backend override of WGP when using PAL.

I might revisit this one - setting cumode seems messy to enable driver control of the WGP setting, but seems the most pragmatic at the moment.

Jul 17 2019, 1:31 AM · Restricted Project
dstuttard added inline comments to D63639: [AMDGPU] Prevent backend override of WGP when using PAL.
Jul 17 2019, 1:31 AM · Restricted Project

Jul 15 2019

dstuttard added a comment to D63639: [AMDGPU] Prevent backend override of WGP when using PAL.

ping

Jul 15 2019, 1:21 AM · Restricted Project

Jun 21 2019

dstuttard added inline comments to D63639: [AMDGPU] Prevent backend override of WGP when using PAL.
Jun 21 2019, 7:10 AM · Restricted Project
dstuttard added reviewers for D63639: [AMDGPU] Prevent backend override of WGP when using PAL: tpr, rampitec.
Jun 21 2019, 2:38 AM · Restricted Project
dstuttard created D63639: [AMDGPU] Prevent backend override of WGP when using PAL.
Jun 21 2019, 2:36 AM · Restricted Project

May 9 2019

dstuttard committed rG411488b11edf: [CodeGenPrepare] Limit recursion depth for collectBitParts (authored by dstuttard).
[CodeGenPrepare] Limit recursion depth for collectBitParts
May 9 2019, 8:00 AM
dstuttard committed rL360347: [CodeGenPrepare] Limit recursion depth for collectBitParts.
[CodeGenPrepare] Limit recursion depth for collectBitParts
May 9 2019, 8:00 AM
dstuttard closed D61728: [CodeGenPrepare] Limit recursion depth for collectBitParts.
May 9 2019, 7:59 AM · Restricted Project
dstuttard created D61728: [CodeGenPrepare] Limit recursion depth for collectBitParts.
May 9 2019, 5:53 AM · Restricted Project
dstuttard added a reviewer for D61728: [CodeGenPrepare] Limit recursion depth for collectBitParts: jmolloy.
May 9 2019, 5:53 AM · Restricted Project

Apr 23 2019

dstuttard accepted D60999: AMDGPU: Fix LCSSA phi lowering in SILowerI1Copies.

LGTM

Apr 23 2019, 4:20 AM · Restricted Project

Mar 20 2019

dstuttard committed rGfc2a74734574: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel (authored by dstuttard).
[AMDGPU] Allow MIMG with no uses in adjustWritemask in isel
Mar 20 2019, 2:29 AM
dstuttard committed rL356540: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel.
[AMDGPU] Allow MIMG with no uses in adjustWritemask in isel
Mar 20 2019, 2:29 AM
dstuttard closed D58964: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel.
Mar 20 2019, 2:29 AM · Restricted Project

Mar 18 2019

dstuttard added a comment to D58964: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel.

ping

Mar 18 2019, 3:24 AM · Restricted Project

Mar 12 2019

dstuttard committed rG20ea21c6ede8: [AMDGPU] Add support for immediate operand for S_ENDPGM (authored by dstuttard).
[AMDGPU] Add support for immediate operand for S_ENDPGM
Mar 12 2019, 2:52 AM
dstuttard committed rL355902: [AMDGPU] Add support for immediate operand for S_ENDPGM.
[AMDGPU] Add support for immediate operand for S_ENDPGM
Mar 12 2019, 2:52 AM
dstuttard closed D59213: [AMDGPU] Add support for immediate operand for S_ENDPGM.
Mar 12 2019, 2:52 AM · Restricted Project

Mar 11 2019

dstuttard added reviewers for D59213: [AMDGPU] Add support for immediate operand for S_ENDPGM: rampitec, arsenm.
Mar 11 2019, 8:48 AM · Restricted Project
dstuttard created D59213: [AMDGPU] Add support for immediate operand for S_ENDPGM.
Mar 11 2019, 8:45 AM · Restricted Project

Mar 7 2019

dstuttard added inline comments to D58964: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel.
Mar 7 2019, 7:31 AM · Restricted Project
dstuttard updated the diff for D58964: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel.

Modified test in line with review comments

Mar 7 2019, 7:31 AM · Restricted Project

Mar 6 2019

dstuttard added inline comments to D58964: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel.
Mar 6 2019, 4:53 AM · Restricted Project

Mar 5 2019

dstuttard added reviewers for D58964: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel: nhaehnle, tpr.
Mar 5 2019, 6:42 AM · Restricted Project
dstuttard created D58964: [AMDGPU] Allow MIMG with no uses in adjustWritemask in isel.
Mar 5 2019, 6:42 AM · Restricted Project
dstuttard added inline comments to D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..
Mar 5 2019, 5:39 AM · Restricted Project, Restricted Project
dstuttard committed rG81eec58a0d55: [AMDGPU] Omit KILL instructions from hazard recognizer (authored by dstuttard).
[AMDGPU] Omit KILL instructions from hazard recognizer
Mar 5 2019, 2:25 AM
dstuttard committed rL355384: [AMDGPU] Omit KILL instructions from hazard recognizer.
[AMDGPU] Omit KILL instructions from hazard recognizer
Mar 5 2019, 2:24 AM
dstuttard closed D58898: [AMDGPU] Omit KILL instructions from hazard recognizer.
Mar 5 2019, 2:24 AM · Restricted Project

Mar 4 2019

dstuttard added a reviewer for D58898: [AMDGPU] Omit KILL instructions from hazard recognizer: arsenm.
Mar 4 2019, 6:32 AM · Restricted Project
dstuttard added reviewers for D58898: [AMDGPU] Omit KILL instructions from hazard recognizer: nhaehnle, sheredom.
Mar 4 2019, 6:30 AM · Restricted Project
dstuttard created D58898: [AMDGPU] Omit KILL instructions from hazard recognizer.
Mar 4 2019, 6:29 AM · Restricted Project

Feb 11 2019

dstuttard accepted D57737: [AMDGPU] Fix DPP sequence in atomic optimizer..

Not really an area I'm 100% sure about - but looks ok to me. One of the other reviewers will have to sign off too.
Minor niggle on the comment (if my understanding is correct).

Feb 11 2019, 2:37 AM · Restricted Project, Restricted Project

Feb 4 2019

dstuttard accepted D57681: [InstCombine] Cleanup the TFE/LWE check in AMDGPU SimplifyDemanded.

LGTM

Feb 4 2019, 5:14 AM · Restricted Project

Jan 14 2019

dstuttard committed rL351054: [AMDGPU] Add support for TFE/LWE in image intrinsics. 2nd try.
[AMDGPU] Add support for TFE/LWE in image intrinsics. 2nd try
Jan 14 2019, 3:59 AM

Dec 11 2018

dstuttard added a comment to D51925: [AMDGPU] Fix issue for zext of f16 to i32.

ping

Dec 11 2018, 8:35 AM
dstuttard added a comment to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

ping

Dec 11 2018, 8:35 AM · Restricted Project
dstuttard accepted D55267: [AMDGPU] Set metadata access for explicit section.

LGTM - but probably need approval from one of the other reviewers as well

Dec 11 2018, 1:14 AM

Nov 29 2018

dstuttard committed rL347911: Revert r347871 "Fix: Add support for TFE/LWE in image intrinsic".
Revert r347871 "Fix: Add support for TFE/LWE in image intrinsic"
Nov 29 2018, 12:17 PM
dstuttard committed rL347876: Fix: Add support for TFE/LWE in image intrinsic.
Fix: Add support for TFE/LWE in image intrinsic
Nov 29 2018, 7:59 AM
dstuttard committed rL347871: Add support for TFE/LWE in image intrinsics.
Add support for TFE/LWE in image intrinsics
Nov 29 2018, 7:24 AM
dstuttard closed D48826: [AMDGPU] Add support for TFE/LWE in image intrinsics.
Nov 29 2018, 7:24 AM

Nov 28 2018

dstuttard added a comment to D51925: [AMDGPU] Fix issue for zext of f16 to i32.

ping

What happens if you just drop the optimization entirely?

Nov 28 2018, 3:28 AM

Nov 27 2018

dstuttard added a comment to D51932: [AMDGPU] Fix-up cases where writelane has 2 SGPR operands.

ping

Nov 27 2018, 7:20 AM · Restricted Project
dstuttard added a comment to D51925: [AMDGPU] Fix issue for zext of f16 to i32.

ping

Nov 27 2018, 7:20 AM
dstuttard added a comment to D48826: [AMDGPU] Add support for TFE/LWE in image intrinsics.

ping

Nov 27 2018, 7:19 AM

Nov 19 2018

dstuttard committed rL347221: [AMDGPU] Derive GCNSubtarget from MF to get overridden target features.
[AMDGPU] Derive GCNSubtarget from MF to get overridden target features
Nov 19 2018, 7:47 AM
dstuttard closed D54301: [AMDGPU] Derive GCNSubtarget from MF to get overridden target features.
Nov 19 2018, 7:47 AM
dstuttard updated the diff for D48826: [AMDGPU] Add support for TFE/LWE in image intrinsics.

Thanks for the review - made all the suggested changes

Nov 19 2018, 7:35 AM
dstuttard added inline comments to D48826: [AMDGPU] Add support for TFE/LWE in image intrinsics.
Nov 19 2018, 7:35 AM