User Details
- User Since
- Jan 25 2017, 7:29 AM (277 w, 5 d)
Thu, May 19
LGTM
Mar 29 2022
Mar 15 2022
Pushed an earlier commit by mistake
Picked this issue up in some testing - seems a logical fix.
I have a reproducer, but even the cut-down isn't that clean - do you think this requires a test?
Dec 2 2021
Nov 30 2021
Spelling mistake (and rebase for test changes)
Updating test in light of review suggestions
Updating with link to change for which this is a pre-commit
Pre-commit test
Oct 19 2021
Commited as cf65271e462f0626157a06f2f3a9615b4987c24e
Oct 18 2021
Oct 12 2021
Interesting to see that quite a few of the test changes are clustering the loads, but not ending up with a clause (correctly).
Nice result otherwise though.
Oct 8 2021
Address review comments
Oct 7 2021
Sep 28 2021
Sep 27 2021
Sep 23 2021
ping?
This change has caused some problems for us - resolve doesn't respect the use of subst on windows which we've been using to avoid long file path problems. This is a particular issue for the llvm-lit tests.
Sep 21 2021
Rebase and address some of the review comments
Aug 17 2021
Aug 16 2021
We ran across this issue a while back for graphics, but I'd forgotten to upstream it.
Jul 20 2021
Thanks Stas - LGTM
Jul 14 2021
I'm revisiting this - (sorry for the lengthy hiatus)
Jul 9 2021
Do you think that I should add any other reviewers?
Jul 5 2021
Pre-committed test and rebased on top
Updated existing test based on feedback
Jun 21 2021
Adding mul_uint24-amdgcn.ll gfx9 variant
Jun 18 2021
Add test
Jun 17 2021
Updating for review comments.
Jun 16 2021
Some modifications based on review feedback
May 28 2021
Thanks for reviews.
Made suggested changes.
Wasn't sure about the new HasSMulHi - any thoughts?
May 18 2021
May 14 2021
May 13 2021
Updates based on review comments
Moved part of this change into D102231 (required for that change).
Moved change from D102066 required for this change (which will be committed first)
I've got a case where we see this issue as well.
May 12 2021
Made suggested changes
May 11 2021
Fixed sense of NoG16 argument passed in from asmparser and disassembler
See new patch with globalisel implementation
Addressed review comments
Added support for global-isel. Note: global-isel produces less optimal code
presently. Will require some additional work to add extra combines
This is a combination of the 2 previous patches - both asmparser and disassembler. I've also unified the code from SIInstrInfo.cpp into a single function since the code was duplicated 3 times before.
I've combined this with other changes into D102231 which was easier than trying to update this one
I've combined this with some other changes into D102231 - easier than trying to separate all the various bits
a16 and g16 no longer linked
May 7 2021
Yes, thanks. Already reverted.