This is an archive of the discontinued LLVM Phabricator instance.

[clang][RISCV][test] Add test coverage for _Float16 ABI lowering
ClosedPublic

Authored by asb on Mar 1 2023, 7:27 AM.

Details

Summary

I believe that by the psABI, any test case where a FPR would be used for a float, it should also be used if you replaced that float with a _Float16. This doesn't hold true for the special cases in the FP calling convention involving structs. This patch doesn't attempt to fix that, simply to add coverage.

I've also directly committed some other patches that expand our coverage for _Float16 behaviour.

Diff Detail

Event Timeline

asb created this revision.Mar 1 2023, 7:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 7:27 AM
asb requested review of this revision.Mar 1 2023, 7:27 AM
kito-cheng accepted this revision.Mar 3 2023, 1:50 AM
This revision is now accepted and ready to land.Mar 3 2023, 1:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 15 2023, 11:01 AM
Herald added a subscriber: jobnoorman. · View Herald Transcript