[clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs
ClosedPublic
Actions

Authored by asb on Wed, Mar 1, 8:45 AM.

Details

Reviewers

kito-cheng
jrtc27
reames
craig.topper

Commits

rG938deaad8ac9: [clang][RISCV] Fix ABI lowering for _Float16 for FP ABIs

Summary

For trivial cases (_Float16 as a standalone argument), it was previously correctly lowered to half. But the logic for catching cases involving structs was gated off, as at the time that logic was written the ABI for half was unclear.

This patch fixes that and adds a release note.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

asb created this revision.Wed, Mar 1, 8:45 AM

Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 1, 8:45 AM

Herald added subscribers: luke, wingo, pmatos and 26 others. · View Herald Transcript

asb requested review of this revision.Wed, Mar 1, 8:45 AM

Herald added a project: Restricted Project. · View Herald TranscriptWed, Mar 1, 8:45 AM

Herald added subscribers: pcwang-thead, eopXD, MaskRay. · View Herald Transcript

Harbormaster completed remote builds in B216732: Diff 501528.Wed, Mar 1, 8:46 AM

asb added a parent revision: D145070: [clang][RISCV][test] Add test coverage for _Float16 ABI lowering.Wed, Mar 1, 8:46 AM

LGTM, just a nit :)

clang/test/CodeGen/RISCV/riscv64-abi.c
1909	This seems removed accidentally, I saw `clang/test/CodeGen/RISCV/riscv32-abi.c` still keep.

asb mentioned this in rGa7e13d6f1b49: [clang][RISCV][test] Add test coverage for _Float16 ABI lowering.Wed, Mar 15, 11:01 AM

Rebase.

Herald added a subscriber: jobnoorman. · View Herald TranscriptWed, Mar 15, 11:21 AM

asb added inline comments.Wed, Mar 15, 11:32 AM

clang/test/CodeGen/RISCV/riscv64-abi.c
1909	update_cc_test_checks.py is actually correct to remove this. `void f_struct_float16_int8_insufficient_fprs` happens to have different output for lp64f vs lp64d (it has floats and doubles in its arguments).