RV32E was recently ratified so we should update the version as our MC-layer support is complete.
Details
Details
Diff Detail
Diff Detail
Unit Tests
Unit Tests
Time | Test | |
---|---|---|
60,050 ms | x64 debian > libFuzzer.libFuzzer::minimize_crash.test |
Event Timeline
Comment Actions
Although a trivial change in terms of lines edited, I suggested Job posted this separately from the existing D143570 review on the basis that it might trigger unrelated concerns.
I think it makes sense to go ahead and bump this version. The strict error checking in tools is being addressed, and given how limited our RVE support is in LLVM (no codegen supported), I'd be surprised if there are any downstream users right now. The reason D143570 triggers this is that technically RV64E 1.9 didn't exist, so it seems cleaner to move to the ratified version number.
This LGTM, but I'm of course waiting for a bit in case there are other viewpoints.
Comment Actions
This patch is triggering a unit test failure in my Release+Asserts build with all targets enabled:
FAIL: LLVM-Unit :: Support/./SupportTests/7/42 (1 of 1326) ******************** TEST 'LLVM-Unit :: Support/./SupportTests/7/42' FAILED ******************** Script(shard): -- GTEST_OUTPUT=json:/home/jayfoad2/llvm-release/unittests/Support/./SupportTests-LLVM-Unit-3022784-7-42.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=42 GTEST_SHARD_INDEX=7 /home/jayfoad2/llvm-release/unittests/Support/./SupportTests -- Script: -- /home/jayfoad2/llvm-release/unittests/Support/./SupportTests --gtest_filter=ParseArchString.AcceptsSupportedBaseISAsAndSetsXLenAndFLen -- /home/jayfoad2/git/llvm-project/llvm/unittests/Support/RISCVISAInfoTest.cpp:144: Failure Value of: ExtsRV32E.at("e") == (RISCVExtensionInfo{1, 9}) Actual: false Expected: true /home/jayfoad2/git/llvm-project/llvm/unittests/Support/RISCVISAInfoTest.cpp:144 Value of: ExtsRV32E.at("e") == (RISCVExtensionInfo{1, 9}) Actual: false Expected: true ******************** ******************** Failed Tests (1): LLVM-Unit :: Support/./SupportTests/ParseArchString/AcceptsSupportedBaseISAsAndSetsXLenAndFLen