This is an archive of the discontinued LLVM Phabricator instance.

Bump RV32E version to 2.0

Authored by jobnoorman on Feb 20 2023, 5:16 AM.



RV32E was recently ratified so we should update the version as our MC-layer support is complete.

Diff Detail

Event Timeline

jobnoorman created this revision.Feb 20 2023, 5:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2023, 5:16 AM
jobnoorman requested review of this revision.Feb 20 2023, 5:16 AM
asb added a comment.Feb 20 2023, 5:26 AM

Although a trivial change in terms of lines edited, I suggested Job posted this separately from the existing D143570 review on the basis that it might trigger unrelated concerns.

I think it makes sense to go ahead and bump this version. The strict error checking in tools is being addressed, and given how limited our RVE support is in LLVM (no codegen supported), I'd be surprised if there are any downstream users right now. The reason D143570 triggers this is that technically RV64E 1.9 didn't exist, so it seems cleaner to move to the ratified version number.

This LGTM, but I'm of course waiting for a bit in case there are other viewpoints.

This revision is now accepted and ready to land.Mar 8 2023, 9:53 PM
This revision was landed with ongoing or failed builds.Mar 23 2023, 3:12 AM
Closed by commit rGd25751779baa: Bump RV32E version to 2.0 (authored by jobnoorman, committed by kito-cheng). · Explain Why
This revision was automatically updated to reflect the committed changes.
foad added a subscriber: foad.Mar 23 2023, 4:30 AM

This patch is triggering a unit test failure in my Release+Asserts build with all targets enabled:

FAIL: LLVM-Unit :: Support/./SupportTests/7/42 (1 of 1326)
******************** TEST 'LLVM-Unit :: Support/./SupportTests/7/42' FAILED ********************
GTEST_OUTPUT=json:/home/jayfoad2/llvm-release/unittests/Support/./SupportTests-LLVM-Unit-3022784-7-42.json GTEST_SHUFFLE=0 GTEST_TOTAL_SHARDS=42 GTEST_SHARD_INDEX=7 /home/jayfoad2/llvm-release/unittests/Support/./SupportTests

/home/jayfoad2/llvm-release/unittests/Support/./SupportTests --gtest_filter=ParseArchString.AcceptsSupportedBaseISAsAndSetsXLenAndFLen
/home/jayfoad2/git/llvm-project/llvm/unittests/Support/RISCVISAInfoTest.cpp:144: Failure
Value of:"e") == (RISCVExtensionInfo{1, 9})
  Actual: false
Expected: true

Value of:"e") == (RISCVExtensionInfo{1, 9})
  Actual: false
Expected: true

Failed Tests (1):
  LLVM-Unit :: Support/./SupportTests/ParseArchString/AcceptsSupportedBaseISAsAndSetsXLenAndFLen
foad added a comment.Mar 23 2023, 4:31 AM

Oh, I see a fix has already been committed. Thanks.