This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][COST] Add half type support for the cost model of sqrt/fabs
ClosedPublic

Authored by Miss_Grape on Aug 29 2022, 7:44 PM.

Details

Summary
  1. Refactor for costs of sqrt/fabs
  2. Add half type support for the cost model of sqrt/fabs

Diff Detail

Event Timeline

Miss_Grape created this revision.Aug 29 2022, 7:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2022, 7:44 PM
Miss_Grape requested review of this revision.Aug 29 2022, 7:44 PM
reames requested changes to this revision.Aug 30 2022, 7:35 AM

Please update the review description to describe actual change. In this case, I think you're adding half support.

llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
836

Unrelated change. Feel free to simply land a change which swaps the order here, but please remove it from this diff.

This revision now requires changes to proceed.Aug 30 2022, 7:35 AM
Miss_Grape retitled this revision from [RISCV][COST] Add cost model for sqrt/fabs to [RISCV][COST] Add half type support for the cost model of sqrt/fabs.Aug 30 2022, 6:11 PM
Miss_Grape edited the summary of this revision. (Show Details)
Miss_Grape marked an inline comment as done.
reames resigned from this revision.Aug 31 2022, 2:26 PM
Miss_Grape edited reviewers, added: craig.topper, benshi001; removed: reames.Aug 31 2022, 5:44 PM
craig.topper added inline comments.Dec 9 2022, 6:06 PM
llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
852

ST->hasVInstructionF16() is only true if hasVInstructions() is true so this || doesn't do anything.

adress the comment

Miss_Grape marked an inline comment as done.Dec 11 2022, 7:28 PM
This revision is now accepted and ready to land.Jan 3 2023, 8:29 PM