Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Miss_Grape (LiqinWeng)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 21 2021, 6:53 PM (110 w, 2 d)

Recent Activity

Oct 3 2023

Herald added a project to D32422: LoopVectorizer: let target prefer scalar addressing computations (+ minor improvements in SystemZTTI): Restricted Project.

What test suite did you use to demonstrate performance?

Oct 3 2023, 12:31 AM · Restricted Project

Sep 10 2023

Miss_Grape added a comment to D159494: [VP] IR expansion for maxnum/minnum.

Please can you add the i686 test coverage seperately as a pre-commit?

done

Sep 10 2023, 7:22 PM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D159494: [VP] IR expansion for maxnum/minnum.

address the comment

Sep 10 2023, 7:21 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to D159491: [VP] IR expansion for zext/sext/trunc/fptosi/fptosi/sitofp/uitofp/fptrunc/fpext.

(style) Remove the braces around each case statment - we should only need those if we have a local variable

Sep 10 2023, 7:12 PM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D159491: [VP] IR expansion for zext/sext/trunc/fptosi/fptosi/sitofp/uitofp/fptrunc/fpext.
Sep 10 2023, 7:11 PM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D159491: [VP] IR expansion for zext/sext/trunc/fptosi/fptosi/sitofp/uitofp/fptrunc/fpext.

Adrress the comment

Sep 10 2023, 7:09 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to D159495: [VP] IR expansion for abs/smax/smin/umax/umin.

Please make sure you generate your diffs with context git diff -U9999 HEAD etc.

Sep 10 2023, 7:04 PM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D159495: [VP] IR expansion for abs/smax/smin/umax/umin.
Sep 10 2023, 7:01 PM · Restricted Project, Restricted Project
Miss_Grape requested review of D159495: [VP] IR expansion for abs/smax/smin/umax/umin.
Sep 10 2023, 5:37 AM · Restricted Project, Restricted Project
Miss_Grape requested review of D159494: [VP] IR expansion for maxnum/minnum.
Sep 10 2023, 4:39 AM · Restricted Project, Restricted Project
Miss_Grape retitled D159493: [VP] more functional Intrinsic to definitions from [VP] to [VP] more functional Intrinsic to definitions.
Sep 10 2023, 3:46 AM · Restricted Project, Restricted Project
Miss_Grape requested review of D159493: [VP] more functional Intrinsic to definitions.
Sep 10 2023, 3:45 AM · Restricted Project, Restricted Project

Sep 9 2023

Miss_Grape requested review of D159491: [VP] IR expansion for zext/sext/trunc/fptosi/fptosi/sitofp/uitofp/fptrunc/fpext.
Sep 9 2023, 3:10 AM · Restricted Project, Restricted Project

Sep 7 2023

Miss_Grape updated the diff for D159478: [VP] IR expansion for inttoptr/ptrtoint.

Add 686 test

Sep 7 2023, 6:44 AM · Restricted Project, Restricted Project
Miss_Grape added inline comments to D159478: [VP] IR expansion for inttoptr/ptrtoint.
Sep 7 2023, 6:01 AM · Restricted Project, Restricted Project
Miss_Grape requested review of D159478: [VP] IR expansion for inttoptr/ptrtoint.
Sep 7 2023, 2:38 AM · Restricted Project, Restricted Project

Apr 12 2023

Miss_Grape added a reviewer for D129173: [RISCV] Remove debug location to spill/reload instructions: asb.
Apr 12 2023, 11:33 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to D129173: [RISCV] Remove debug location to spill/reload instructions.

My suggestion,

  1. improve your commit info, something like
Spill/reload instructions are artificially generated by the compiler and
have no relation to the original source code. So the best thing to do is
not attach any debug location to them (instead of just taking the next
debug location we find on following instructions).

Refered to https://reviews.llvm.org/rG3e081703c349dd00b8ef6991c2d15964915dd8f4
  1. add some tests as you did in your another review request.
Apr 12 2023, 11:32 PM · Restricted Project, Restricted Project
Miss_Grape added a reviewer for D129173: [RISCV] Remove debug location to spill/reload instructions: jrtc27.
Apr 12 2023, 11:29 PM · Restricted Project, Restricted Project

Apr 11 2023

Miss_Grape updated the summary of D129173: [RISCV] Remove debug location to spill/reload instructions.
Apr 11 2023, 5:46 PM · Restricted Project, Restricted Project
Miss_Grape reclaimed D129173: [RISCV] Remove debug location to spill/reload instructions.
Apr 11 2023, 5:41 PM · Restricted Project, Restricted Project
Miss_Grape abandoned D128806: [RISCV] Fix wrong position of prologue_end.
Apr 11 2023, 5:41 PM · Restricted Project, Restricted Project

Apr 9 2023

Miss_Grape accepted D147877: [AVR] Reject invalid LDD instruction with explicit error.
Apr 9 2023, 7:06 PM · Restricted Project, Restricted Project

Apr 6 2023

Miss_Grape committed rGdd39f9b41837: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is… (authored by Miss_Grape).
[MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is…
Apr 6 2023, 6:14 AM · Restricted Project, Restricted Project
Miss_Grape closed D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.
Apr 6 2023, 6:13 AM · Restricted Project, Restricted Project

Apr 5 2023

Miss_Grape accepted D141264: [AVR] Fix incorrect expansion of pseudo instructions LPMWRdZ/ELPMWRdZ.
Apr 5 2023, 11:40 PM · Restricted Project, Restricted Project

Jan 26 2023

Miss_Grape added a comment to D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.

The actual comment was not addressed:

The commit description still doesn't describe the details of what it is doing and why, only confuses the reader. The code before this commit *was folding trunc(ext)"! This commit does *not* add that. It does, however, *fix* a case that was mishandled. Please find the appropriate way to express that.

address the comments

Jan 26 2023, 8:33 PM · Restricted Project, Restricted Project
Miss_Grape updated the summary of D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.
Jan 26 2023, 8:33 PM · Restricted Project, Restricted Project
Miss_Grape updated the summary of D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.
Jan 26 2023, 8:32 PM · Restricted Project, Restricted Project
Miss_Grape retitled D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci from [MLIR][Arith] Fold trunci with ext to [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.
Jan 26 2023, 8:28 PM · Restricted Project, Restricted Project

Jan 12 2023

Miss_Grape accepted D141598: [clang] Redefine some AVR specific macros.
Jan 12 2023, 7:23 PM · Restricted Project, Restricted Project
Miss_Grape accepted D141589: [AVR] Fix a bug in AsmPrinter when printing inline-asm operands.
Jan 12 2023, 7:00 PM · Restricted Project, Restricted Project

Jan 10 2023

Miss_Grape added a comment to D141210: [AVR] Do not select unimplemented pseudo instructions.
Jan 10 2023, 12:09 AM · Restricted Project, Restricted Project
Miss_Grape accepted D141210: [AVR] Do not select unimplemented pseudo instructions.
Jan 10 2023, 12:07 AM · Restricted Project, Restricted Project

Jan 8 2023

Miss_Grape committed rG1f8746cc8004: [RISCV][CostModel] Add half type support for the cost model of sqrt/fabs (authored by Miss_Grape).
[RISCV][CostModel] Add half type support for the cost model of sqrt/fabs
Jan 8 2023, 9:00 PM · Restricted Project, Restricted Project
Miss_Grape closed D132908: [RISCV][COST] Add half type support for the cost model of sqrt/fabs.
Jan 8 2023, 9:00 PM · Restricted Project, Restricted Project
Miss_Grape committed rGf3408739da33: [RISCV][CostModel] Add cost model for integer abs (authored by Miss_Grape).
[RISCV][CostModel] Add cost model for integer abs
Jan 8 2023, 7:47 PM · Restricted Project, Restricted Project
Miss_Grape closed D132999: [RISCV][CostModel] Add cost model for integer abs.
Jan 8 2023, 7:47 PM · Restricted Project, Restricted Project

Jan 4 2023

Miss_Grape abandoned D126440: [RISCV] Return an invalid cost for memory ops with unsupported types.
Jan 4 2023, 6:15 PM · Restricted Project, Restricted Project

Jan 3 2023

Miss_Grape added a comment to D132908: [RISCV][COST] Add half type support for the cost model of sqrt/fabs.

ping

Jan 3 2023, 6:37 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to D132999: [RISCV][CostModel] Add cost model for integer abs.

ping

Jan 3 2023, 5:51 PM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.

address the comment

Jan 3 2023, 3:50 AM · Restricted Project, Restricted Project
Miss_Grape retitled D140552: [MLIR][Tensor] Canonicalize expand/collapse_shape of splat to splat from [MLIR][Tensor] Fold ReshapeOp splat to splat with ReshapeOp type. to [MLIR][Tensor] Canonicalize expand/collapse_shape splat to splat with expand/collapse_shape type.
Jan 3 2023, 3:01 AM · Restricted Project, Restricted Project

Dec 29 2022

Miss_Grape updated the diff for D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.

address the comment

Dec 29 2022, 8:08 PM · Restricted Project, Restricted Project
Miss_Grape committed rGf8f4fc11d1b9: [MLIR][Arith][NFC] Use the interface of 'getElementTypeOrSelf' to get the… (authored by Miss_Grape).
[MLIR][Arith][NFC] Use the interface of 'getElementTypeOrSelf' to get the…
Dec 29 2022, 7:58 PM · Restricted Project, Restricted Project
Miss_Grape closed D140608: [MLIR][Arith][NFC] Use the interface of 'getElementTypeOrSelf' to get the resType.
Dec 29 2022, 7:58 PM · Restricted Project, Restricted Project
Miss_Grape updated the summary of D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.
Dec 29 2022, 7:46 PM · Restricted Project, Restricted Project
Miss_Grape retitled D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci from [MLIR][Arith] Canonicalize trunci with ext to [MLIR][Arith] Fold trunci with ext.
Dec 29 2022, 7:33 PM · Restricted Project, Restricted Project
Miss_Grape abandoned D139770: [MLIR][LLVM][NFC] Use tblgen to automatically generate build functions.
Dec 29 2022, 7:00 PM · Restricted Project, Restricted Project
Miss_Grape added a reviewer for D140552: [MLIR][Tensor] Canonicalize expand/collapse_shape of splat to splat: ftynse.
Dec 29 2022, 6:42 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to D140552: [MLIR][Tensor] Canonicalize expand/collapse_shape of splat to splat.

ping

Dec 29 2022, 6:41 PM · Restricted Project, Restricted Project

Dec 23 2022

Miss_Grape committed rG50e6c306b1cb: [MLIR][Arith] Remove unused assertions (authored by Miss_Grape).
[MLIR][Arith] Remove unused assertions
Dec 23 2022, 12:03 AM · Restricted Project, Restricted Project
Miss_Grape closed D140610: [MLIR][Arith] Remove unused assertions.
Dec 23 2022, 12:02 AM · Restricted Project, Restricted Project

Dec 22 2022

Miss_Grape requested review of D140610: [MLIR][Arith] Remove unused assertions.
Dec 22 2022, 11:06 PM · Restricted Project, Restricted Project
Miss_Grape requested review of D140608: [MLIR][Arith][NFC] Use the interface of 'getElementTypeOrSelf' to get the resType.
Dec 22 2022, 10:53 PM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.
Dec 22 2022, 9:52 PM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.
Dec 22 2022, 9:41 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to D132908: [RISCV][COST] Add half type support for the cost model of sqrt/fabs.

ping

Dec 22 2022, 8:44 PM · Restricted Project, Restricted Project
Miss_Grape committed rG00fd6958fb00: [MLIR][Arith] Canonicalize xor with ext (authored by Miss_Grape).
[MLIR][Arith] Canonicalize xor with ext
Dec 22 2022, 8:44 PM · Restricted Project, Restricted Project
Miss_Grape closed D139307: [MLIR][Arith] Canonicalize xor with ext.
Dec 22 2022, 8:43 PM · Restricted Project, Restricted Project
Miss_Grape requested review of D140604: [MLIR][Arith] Fold trunci with ext if the bit width of the input type of ext is greater than the bit width of the result type of trunci.
Dec 22 2022, 8:32 PM · Restricted Project, Restricted Project
Miss_Grape requested review of D140552: [MLIR][Tensor] Canonicalize expand/collapse_shape of splat to splat.
Dec 22 2022, 6:48 AM · Restricted Project, Restricted Project

Dec 20 2022

Miss_Grape added a comment to D139307: [MLIR][Arith] Canonicalize xor with ext.

ping

Dec 20 2022, 7:20 PM · Restricted Project, Restricted Project
Miss_Grape accepted D139908: [clang] Do not extend i8 return values to i16 on AVR..
Dec 20 2022, 2:35 AM · Restricted Project, Restricted Project
Miss_Grape added a comment to D139908: [clang] Do not extend i8 return values to i16 on AVR..

LGTM

Dec 20 2022, 2:34 AM · Restricted Project, Restricted Project

Dec 11 2022

Miss_Grape updated the diff for D132908: [RISCV][COST] Add half type support for the cost model of sqrt/fabs.

adress the comment

Dec 11 2022, 7:28 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to D139770: [MLIR][LLVM][NFC] Use tblgen to automatically generate build functions.

This moves the builder's C++ code from C++ to tablegen we normally try to keep C++ code in ODS files for minimum. If you want this generated you could implement the infer result type interface on this op and then you'd not need to define any custom builder AFAICS.

Dec 11 2022, 6:08 PM · Restricted Project, Restricted Project

Dec 10 2022

Miss_Grape retitled D139770: [MLIR][LLVM][NFC] Use tblgen to automatically generate build functions from [MLIP][LLVM][NFC] Use tblgen to automatically generate build functions to [MLIR][LLVM][NFC] Use tblgen to automatically generate build functions.
Dec 10 2022, 2:17 AM · Restricted Project, Restricted Project
Miss_Grape requested review of D139770: [MLIR][LLVM][NFC] Use tblgen to automatically generate build functions.
Dec 10 2022, 2:16 AM · Restricted Project, Restricted Project

Dec 9 2022

Miss_Grape added a comment to D132908: [RISCV][COST] Add half type support for the cost model of sqrt/fabs.

ping

Dec 9 2022, 6:01 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to D139307: [MLIR][Arith] Canonicalize xor with ext.

ping

Dec 9 2022, 5:57 PM · Restricted Project, Restricted Project

Dec 8 2022

Miss_Grape committed rG6efb45f5ab37: [AARCH64][CostModel] Modified the cost of mask vector load/store (authored by Miss_Grape).
[AARCH64][CostModel] Modified the cost of mask vector load/store
Dec 8 2022, 10:19 PM · Restricted Project, Restricted Project
Miss_Grape closed D134413: [AARCH64][CostModel] Modified the cost of mask vector load/store .
Dec 8 2022, 10:19 PM · Restricted Project, Restricted Project

Dec 6 2022

Miss_Grape committed rGcfd73186db4b: [RISCV][CostModel] Add a test for reverse shuffles cost on RISCV, NFC (authored by Miss_Grape).
[RISCV][CostModel] Add a test for reverse shuffles cost on RISCV, NFC
Dec 6 2022, 6:17 PM · Restricted Project, Restricted Project
Miss_Grape closed D134519: [RISCV][CostModel] Add a test for reverse shuffles cost on RISCV, NFC.
Dec 6 2022, 6:17 PM · Restricted Project, Restricted Project
Miss_Grape committed rGd38c9e68b6a3: [MLIR][Arith] Add Canonicalize test for trunci (authored by Miss_Grape).
[MLIR][Arith] Add Canonicalize test for trunci
Dec 6 2022, 6:07 PM · Restricted Project, Restricted Project
Miss_Grape closed D139399: [MLIR][Arith] Add test for trunci.
Dec 6 2022, 6:07 PM · Restricted Project, Restricted Project
Miss_Grape requested review of D139399: [MLIR][Arith] Add test for trunci.
Dec 6 2022, 12:34 AM · Restricted Project, Restricted Project

Dec 5 2022

Miss_Grape requested review of D139307: [MLIR][Arith] Canonicalize xor with ext.
Dec 5 2022, 4:16 AM · Restricted Project, Restricted Project

Sep 28 2022

Miss_Grape added a comment to rGeba84971aeef: Revert "[AARCH64][CostModel] Modified the cost of mask vector load/store".

I am so sorry! Now I have fixed the failed test case, pls review it! https://reviews.llvm.org/D134413

Sep 28 2022, 7:02 PM · Restricted Project, Restricted Project
Miss_Grape added a reviewer for D134413: [AARCH64][CostModel] Modified the cost of mask vector load/store : fhahn.
Sep 28 2022, 7:00 PM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D134413: [AARCH64][CostModel] Modified the cost of mask vector load/store .

Fixed failed test cases

Sep 28 2022, 6:59 PM · Restricted Project, Restricted Project
Miss_Grape reopened D134413: [AARCH64][CostModel] Modified the cost of mask vector load/store .
Sep 28 2022, 6:51 PM · Restricted Project, Restricted Project
Miss_Grape added a comment to rGeba84971aeef: Revert "[AARCH64][CostModel] Modified the cost of mask vector load/store".

thanks for helping me revert it!But I'm a little curious, why the submitted patch doesn't trigger the wrong case??

Sep 28 2022, 6:43 PM · Restricted Project, Restricted Project
Miss_Grape committed rG1c62af3e23ca: [AARCH64][CostModel] Modified the cost of mask vector load/store (authored by Miss_Grape).
[AARCH64][CostModel] Modified the cost of mask vector load/store
Sep 28 2022, 4:41 AM · Restricted Project, Restricted Project
Miss_Grape closed D134413: [AARCH64][CostModel] Modified the cost of mask vector load/store .
Sep 28 2022, 4:41 AM · Restricted Project, Restricted Project
Miss_Grape added a comment to D134519: [RISCV][CostModel] Add a test for reverse shuffles cost on RISCV, NFC.

ping

Sep 28 2022, 4:39 AM · Restricted Project, Restricted Project
Miss_Grape committed rG0516ad870675: [RISCV] Add and update reverse mask tests, NFC (authored by Miss_Grape).
[RISCV] Add and update reverse mask tests, NFC
Sep 28 2022, 3:45 AM · Restricted Project, Restricted Project

Sep 27 2022

Miss_Grape added a reviewer for D134519: [RISCV][CostModel] Add a test for reverse shuffles cost on RISCV, NFC: benshi001.
Sep 27 2022, 2:20 AM · Restricted Project, Restricted Project

Sep 23 2022

Miss_Grape added a comment to D134413: [AARCH64][CostModel] Modified the cost of mask vector load/store .

I think the change seems sensible because the cost of a NEON load is probably similar to the cost of a SVE masked load on CPUs with SVE. However, I am curious to learn about the problem you're hitting. Are you looking at a specific benchmark or loop where the cost is too high to vectorise with SVE? Or is the cost preventing additional interleaving in the vectoriser?

Sep 23 2022, 1:22 AM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D134520: [RISCV] Add and update reverse mask tests, NFC.
Sep 23 2022, 12:59 AM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D134520: [RISCV] Add and update reverse mask tests, NFC.
Sep 23 2022, 12:44 AM · Restricted Project, Restricted Project
Miss_Grape retitled D134519: [RISCV][CostModel] Add a test for reverse shuffles cost on RISCV, NFC from [RISCV][CostModel][NFC] Add a test for reverse shuffles cost on RISCV, NFC to [RISCV][CostModel] Add a test for reverse shuffles cost on RISCV, NFC.
Sep 23 2022, 12:33 AM · Restricted Project, Restricted Project
Miss_Grape requested review of D134520: [RISCV] Add and update reverse mask tests, NFC.
Sep 23 2022, 12:27 AM · Restricted Project, Restricted Project
Miss_Grape requested review of D134519: [RISCV][CostModel] Add a test for reverse shuffles cost on RISCV, NFC.
Sep 23 2022, 12:01 AM · Restricted Project, Restricted Project

Sep 22 2022

Miss_Grape added a comment to D132908: [RISCV][COST] Add half type support for the cost model of sqrt/fabs.

ping

Sep 22 2022, 11:57 PM · Restricted Project, Restricted Project
Miss_Grape requested review of D134413: [AARCH64][CostModel] Modified the cost of mask vector load/store .
Sep 22 2022, 12:05 AM · Restricted Project, Restricted Project

Sep 20 2022

Miss_Grape added a comment to D132999: [RISCV][CostModel] Add cost model for integer abs.

ping

Sep 20 2022, 8:06 PM · Restricted Project, Restricted Project

Sep 15 2022

Miss_Grape added a reviewer for D132908: [RISCV][COST] Add half type support for the cost model of sqrt/fabs: reames.
Sep 15 2022, 8:42 PM · Restricted Project, Restricted Project
Miss_Grape updated the diff for D132999: [RISCV][CostModel] Add cost model for integer abs.
Sep 15 2022, 8:35 PM · Restricted Project, Restricted Project