This is an archive of the discontinued LLVM Phabricator instance.

Fix formatting in release notes
ClosedPublic

Authored by aaronpuchert on Aug 27 2022, 9:29 AM.

Details

Summary

Code needs double backticks, while single backticks produce italics.
Lists need to be fully indented and have blank lines around them.
Links are written "text <url>_".

We use links instead of :manpage:, because the latter is meant
more for man pages cross-referencing each other.

Diff Detail

Event Timeline

aaronpuchert created this revision.Aug 27 2022, 9:29 AM
aaronpuchert requested review of this revision.Aug 27 2022, 9:29 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 27 2022, 9:29 AM

This is for release/15.x.

Use links instead :manpage:, which is meant for man pages cross-referencing each other.

aaronpuchert edited the summary of this revision. (Show Details)Aug 27 2022, 9:53 AM
thieta accepted this revision.Aug 28 2022, 11:25 PM

Thanks for doing this pass! Much appreciated. As long as you tried to build the docs after you changes and it passes without any warnings or errors I am happy for you to commit this directly to release/15.x - just let me know if you do it so I can sync the repos.

This revision is now accepted and ready to land.Aug 28 2022, 11:25 PM
aaron.ballman accepted this revision.Aug 29 2022, 5:20 AM

LGTM! I did not test building the docs, but the changes all look correct based on my experience with RST.

The documentation build (docs-{llvm,clang}-{html,man}) is fine after this, in fact it fixes:

Warning, treated as error:
[...]/build/tools/clang/docs/ReleaseNotes.rst:632:Bullet list ends without a blank line; unexpected unindent.

by adding some indentation.

Thanks for the reviews!