Page MenuHomePhabricator

thieta (Tobias Hieta)
Team Lead - Build and Integration at Plex.tv

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2019, 11:34 AM (4 w, 6 d)

Recent Activity

Thu, Oct 31

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Thanks everyone! It was a great learning experience getting this patch in and learning more about building/testing LLVM!

Thu, Oct 31, 5:08 AM · Restricted Project

Wed, Oct 30

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Can someone please commit this for me if everyone is happy with it now?

Wed, Oct 30, 12:29 PM · Restricted Project
thieta updated the diff for D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Updated the tests with @jhenderson comments.

Wed, Oct 30, 3:27 AM · Restricted Project
thieta added inline comments to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.
Wed, Oct 30, 2:59 AM · Restricted Project
thieta updated the diff for D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Fixed all outstanding comments with documentation, test cases and linking to the correct upstream bug.

Wed, Oct 30, 2:21 AM · Restricted Project
thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

So chatted with Sledge. Their authoritative input on this matter is that we do need to carry a workaround. I think this patch is good to go once Sledge has an official bug id and the comment is updated with that piece of information.

<Sledge> it's going to take quite a while for that fix to filter through to users, particularly for Ubuntu and Debian LTS users :-/

Wed, Oct 30, 1:08 AM · Restricted Project

Mon, Oct 28

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

I totally defer to you guys on if this is something you want to accept or not. We are now patching our own toolchain with this patch to not create bad binaries. If I where to make a case for accepting this patch it would be something like:

Mon, Oct 28, 2:45 AM · Restricted Project

Thu, Oct 24

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

@rupprecht - Thanks! I have addressed the comments and uploaded a new rev. Hope I did it correctly. I don't have commit access - if you could commit it for me it would be great. I might have other patches in the future (looking at you MingW driver) but I'll cross that bridge then.

Thu, Oct 24, 8:15 PM · Restricted Project
thieta updated the diff for D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

This revision should address all the comments in the previous revision. Comments are updated, testing --strip-all-gnu and documentation changes. Let me know if you have additional comments.

Thu, Oct 24, 8:13 PM · Restricted Project

Oct 21 2019

thieta added inline comments to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.
Oct 21 2019, 8:59 PM · Restricted Project
thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Thanks everyone for the feedback. I was meeting up with our QA team this week and they said that they seen the issue with these binaries on a much larger array of devices than I initially thought. This is not a bug in upstream GLIBC - this is a bug in debian/ubuntu versions that patch glibc to specifically check for SHT_ARM_ATTRIBUTES. We tested with all debian based NAS devices we had and saw the same issue. We even tested with raspbian on raspberry pi and this also contains the issue.

Oct 21 2019, 5:21 AM · Restricted Project

Oct 18 2019

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Seems like a hack, no? What about using --keep-section when you need it? You say its not strictly needed on modern systems and the problem is with the dlopen implementation of these older libcs, and not llvm-objcopy, so I would be hesitant to add something like this especially given we have a solution with --keep-section

Oct 18 2019, 12:59 PM · Restricted Project
Herald added a reviewer for D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files: alexshap.
Oct 18 2019, 11:44 AM · Restricted Project