Page MenuHomePhabricator

thieta (Tobias Hieta)
LLVM developer at Ubisoft Montreal

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2019, 11:34 AM (178 w, 6 d)

Recent Activity

Thu, Feb 23

thieta added a reverting change for rG368b6832de33: [Clang] Implement fix for DR2628: rG3b6c88331bcd: Revert "[Clang] Implement fix for DR2628".
Thu, Feb 23, 7:08 AM · Restricted Project, Restricted Project
thieta committed rG3b6c88331bcd: Revert "[Clang] Implement fix for DR2628" (authored by thieta).
Revert "[Clang] Implement fix for DR2628"
Thu, Feb 23, 7:08 AM · Restricted Project, Restricted Project
thieta added a reverting change for D134145: [Clang] Implement fix for DR2628: rG3b6c88331bcd: Revert "[Clang] Implement fix for DR2628".
Thu, Feb 23, 7:08 AM · Restricted Project, Restricted Project

Feb 21 2023

thieta accepted D144509: [CMake] Bumps minimum version to 3.20.0..
Feb 21 2023, 12:47 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Feb 17 2023

thieta added a comment to D143702: [NFC] Convert openmp/runtime/tools/summarizeStats.py to python 3 syntax.

Are you good with this now @serge-sans-paille ?

Feb 17 2023, 12:40 AM · Restricted Project, Restricted Project

Feb 15 2023

thieta added a comment to D143468: [CMake] Remove custom ccache CMake logic.

@jrtc27 raises a good point - we have discussed deprecating the option but made it a hard error. Should we instead make it a soft error for now and a hard error later on?

Feb 15 2023, 1:40 AM · Restricted Project, Restricted Project, Restricted Project

Feb 14 2023

thieta added a comment to D143702: [NFC] Convert openmp/runtime/tools/summarizeStats.py to python 3 syntax.

Thanks for the review - removed those lists(). Wonder why 2to3 is so aggressive with inserting them? anyway - it seems to parse fine afterwards. but since I don't know the files this should be executed on it's hard for me to test the functionallity.

Feb 14 2023, 12:08 AM · Restricted Project, Restricted Project
thieta updated the diff for D143702: [NFC] Convert openmp/runtime/tools/summarizeStats.py to python 3 syntax.

Removed unecessary lists

Feb 14 2023, 12:07 AM · Restricted Project, Restricted Project

Feb 13 2023

thieta added a comment to D143468: [CMake] Remove custom ccache CMake logic.

My motivation was that people asked to add support for new cache programs (sscache and more). And now that this is supported in upstream CMake in a nice way I think our build system is way too big and complicated to duplicate functionality that's already in upstream CMake. It's more switches to keep testing and update.

Feb 13 2023, 10:27 AM · Restricted Project, Restricted Project, Restricted Project
thieta accepted D143926: [BOLT] Use CMAKE_*_COMPILER_LAUNCHER.

Thanks!

Feb 13 2023, 9:04 AM · Restricted Project
thieta committed rGb8c2ba138ef6: [NFC] Fix using-declspec.cpp test with non-C++17 compilers (authored by thieta).
[NFC] Fix using-declspec.cpp test with non-C++17 compilers
Feb 13 2023, 7:59 AM · Restricted Project, Restricted Project
thieta added a comment to D143632: [clang] Handle __declspec() attributes in using.

Thanks for the review and the explanations! I fixed your nits and landed this.

Feb 13 2023, 6:43 AM · Restricted Project, Restricted Project
thieta committed rG877859a09bda: [clang] Handle __declspec() attributes in using (authored by thieta).
[clang] Handle __declspec() attributes in using
Feb 13 2023, 6:43 AM · Restricted Project, Restricted Project
thieta closed D143632: [clang] Handle __declspec() attributes in using.
Feb 13 2023, 6:43 AM · Restricted Project, Restricted Project
thieta added a comment to D143632: [clang] Handle __declspec() attributes in using.

Thanks for your comments - feel free to comment on the release note, I was struggling with describing the fix well for a short release note paragraph.

Feb 13 2023, 3:09 AM · Restricted Project, Restricted Project
thieta updated the diff for D143632: [clang] Handle __declspec() attributes in using.
  • Expand on tests
  • Fix crash when Attrs was null
  • Added release note
Feb 13 2023, 3:01 AM · Restricted Project, Restricted Project
thieta accepted D143881: Use compiler_launcher for cpp20 and clangd builders.

Thanks!

Feb 13 2023, 12:14 AM · Restricted Project

Feb 12 2023

thieta added a comment to D143468: [CMake] Remove custom ccache CMake logic.

Basically every bot broke with this change, so I reverted it for now and posted to discourse: https://discourse.llvm.org/t/llvm-ccache-build-is-deprecated/68431

Feb 12 2023, 11:58 PM · Restricted Project, Restricted Project, Restricted Project
thieta committed rGfff762d674c3: Revert "[CMake] Remove custom ccache CMake logic" (authored by thieta).
Revert "[CMake] Remove custom ccache CMake logic"
Feb 12 2023, 11:57 PM · Restricted Project, Restricted Project, Restricted Project
thieta added a reverting change for rG0fad18c44a14: [CMake] Remove custom ccache CMake logic: rGfff762d674c3: Revert "[CMake] Remove custom ccache CMake logic".
Feb 12 2023, 11:57 PM · Restricted Project, Restricted Project, Restricted Project
thieta added a reverting change for D143468: [CMake] Remove custom ccache CMake logic: rGfff762d674c3: Revert "[CMake] Remove custom ccache CMake logic".
Feb 12 2023, 11:57 PM · Restricted Project, Restricted Project, Restricted Project
thieta committed rG0fad18c44a14: [CMake] Remove custom ccache CMake logic (authored by thieta).
[CMake] Remove custom ccache CMake logic
Feb 12 2023, 11:43 PM · Restricted Project, Restricted Project, Restricted Project
thieta closed D143468: [CMake] Remove custom ccache CMake logic.
Feb 12 2023, 11:42 PM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D143468: [CMake] Remove custom ccache CMake logic.

Ping.

Feb 12 2023, 12:02 PM · Restricted Project, Restricted Project, Restricted Project
thieta requested review of D143852: [docs] Add Python coding standard to documentation.
Feb 12 2023, 12:01 PM · Restricted Project, Restricted Project

Feb 10 2023

thieta added inline comments to D143703: [NFC][polly] Convert some python scripts to Python 3 syntax.
Feb 10 2023, 9:51 AM · Restricted Project, Restricted Project
thieta added a comment to D143557: [CMake][compiler-rt] Support clang-cl in CompilerRTMockLLVMCMakeConfig.

This seems reasonable and fine to me.
Though I'd feel better if someone familiar with MSVC/Windows gave approval.

Feb 10 2023, 5:43 AM · Restricted Project, Restricted Project
thieta committed rG8470430107d0: [NFC][compiler-rt] Shorten comment (authored by thieta).
[NFC][compiler-rt] Shorten comment
Feb 10 2023, 5:43 AM · Restricted Project, Restricted Project
thieta committed rG1e658ad1728e: [Workflow] Add Release Repo sync script (authored by thieta).
[Workflow] Add Release Repo sync script
Feb 10 2023, 5:41 AM · Restricted Project, Restricted Project
thieta closed D142726: [Workflow] Add Release Repo sync script.
Feb 10 2023, 5:41 AM · Restricted Project, Restricted Project
thieta added a comment to D142726: [Workflow] Add Release Repo sync script.

Thanks for your review @kwk - I'll merge this now and start working on the action trigger.

Feb 10 2023, 5:41 AM · Restricted Project, Restricted Project
thieta updated the diff for D142726: [Workflow] Add Release Repo sync script.

Expanded and fixed comments

Feb 10 2023, 5:40 AM · Restricted Project, Restricted Project
thieta committed rG8ccde9368f94: [CMake][compiler-rt] Support clang-cl in CompilerRTMockLLVMCMakeConfig (authored by thieta).
[CMake][compiler-rt] Support clang-cl in CompilerRTMockLLVMCMakeConfig
Feb 10 2023, 5:33 AM · Restricted Project, Restricted Project
thieta closed D143557: [CMake][compiler-rt] Support clang-cl in CompilerRTMockLLVMCMakeConfig.
Feb 10 2023, 5:33 AM · Restricted Project, Restricted Project
thieta committed rG57edc61093d9: [NFC] convert compiler-rt/lib/dfsan/scripts/build-libc-list.py to python3 syntax (authored by thieta).
[NFC] convert compiler-rt/lib/dfsan/scripts/build-libc-list.py to python3 syntax
Feb 10 2023, 1:21 AM · Restricted Project, Restricted Project
thieta closed D143701: [NFC] convert compiler-rt/lib/dfsan/scripts/build-libc-list.py to python3 syntax.
Feb 10 2023, 1:21 AM · Restricted Project, Restricted Project

Feb 9 2023

thieta requested review of D143703: [NFC][polly] Convert some python scripts to Python 3 syntax.
Feb 9 2023, 11:38 PM · Restricted Project, Restricted Project
thieta requested review of D143702: [NFC] Convert openmp/runtime/tools/summarizeStats.py to python 3 syntax.
Feb 9 2023, 11:37 PM · Restricted Project, Restricted Project
thieta requested review of D143701: [NFC] convert compiler-rt/lib/dfsan/scripts/build-libc-list.py to python3 syntax.
Feb 9 2023, 11:35 PM · Restricted Project, Restricted Project
thieta updated the diff for D142726: [Workflow] Add Release Repo sync script.

Fix comment

Feb 9 2023, 5:02 AM · Restricted Project, Restricted Project
thieta added a comment to D142726: [Workflow] Add Release Repo sync script.

Thanks for your suggestions. I have pushed a new diff with the fixes.

Feb 9 2023, 4:50 AM · Restricted Project, Restricted Project
thieta updated the diff for D142726: [Workflow] Add Release Repo sync script.

Incorporated feedback

Feb 9 2023, 4:50 AM · Restricted Project, Restricted Project
thieta resigned from D129142: [LLD][ELF] Drop duplicates from rpath.

clearing my queue

Feb 9 2023, 4:41 AM · Restricted Project, Restricted Project, lld
thieta added inline comments to D139298: WIP: Add error handling to demangle API.
Feb 9 2023, 2:38 AM · Restricted Project, Restricted Project
thieta added a comment to D139298: WIP: Add error handling to demangle API.

Hi - I finally got around to picking this one up again. This is rebased, passing all tests and now we pass the std::error_code directly to the API and changed all the callers to itaniumDemangle() and changed most of the places to actually check the error_code instead of the return const char*.

Feb 9 2023, 2:35 AM · Restricted Project, Restricted Project
thieta updated the diff for D139298: WIP: Add error handling to demangle API.

rebased and implemented some of the suggestions.

Feb 9 2023, 2:32 AM · Restricted Project, Restricted Project
thieta resigned from D137043: [clang] add implicit include for Linux/gnu compatibility.
Feb 9 2023, 2:10 AM · Restricted Project, Restricted Project
thieta added a comment to D138254: [llvm] Fix the build on OpenBSD by removing LLVM_VERSION_SUFFIX from created shared library names.

@brad is this something you still need for OpenBSD?

Feb 9 2023, 2:08 AM · Restricted Project, Restricted Project, Restricted Project
thieta resigned from D127938: Update Windows packaging script..

Clear my queue.

Feb 9 2023, 2:07 AM · Restricted Project, Restricted Project
thieta requested review of D143632: [clang] Handle __declspec() attributes in using.
Feb 9 2023, 2:01 AM · Restricted Project, Restricted Project

Feb 8 2023

thieta added a reviewer for D143557: [CMake][compiler-rt] Support clang-cl in CompilerRTMockLLVMCMakeConfig: hans.
Feb 8 2023, 9:55 AM · Restricted Project, Restricted Project
thieta committed rG3ecaf27c0d05: [lit] Pass LLVM_PROFILE_FILE environment (authored by thieta).
[lit] Pass LLVM_PROFILE_FILE environment
Feb 8 2023, 1:14 AM · Restricted Project, Restricted Project
thieta added a comment to D143556: [lit] Pass LLVM_PROFILE_FILE environment.

Thanks!

Feb 8 2023, 1:14 AM · Restricted Project, Restricted Project
thieta closed D143556: [lit] Pass LLVM_PROFILE_FILE environment.
Feb 8 2023, 1:14 AM · Restricted Project, Restricted Project
thieta requested review of D143557: [CMake][compiler-rt] Support clang-cl in CompilerRTMockLLVMCMakeConfig.
Feb 8 2023, 12:30 AM · Restricted Project, Restricted Project
thieta requested review of D143556: [lit] Pass LLVM_PROFILE_FILE environment.
Feb 8 2023, 12:23 AM · Restricted Project, Restricted Project

Feb 7 2023

thieta added a comment to D142726: [Workflow] Add Release Repo sync script.

@thieta I hope my comments make some sense.

Feb 7 2023, 11:46 PM · Restricted Project, Restricted Project
thieta updated the diff for D142726: [Workflow] Add Release Repo sync script.
  • Generate remote and branch names
  • Make terminology a lot clearer
  • Make cleanup optional
Feb 7 2023, 11:44 PM · Restricted Project, Restricted Project
thieta added a comment to D143535: github: Add manual workflow to build and upload release binaries.

Thanks for working on this! I have a bunch of comments :)

Feb 7 2023, 11:22 PM · Restricted Project, Restricted Project
thieta committed rG78fb02107ae5: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found (authored by thieta).
[compiler-rt][macOS]: Disable iOS support if iOS SDK is not found
Feb 7 2023, 11:13 PM · Restricted Project, Restricted Project
thieta closed D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.
Feb 7 2023, 11:12 PM · Restricted Project, Restricted Project
thieta retitled D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found from [compiler-rt][macOS]: Fix building compiler-rt without iOS related SDKs to [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.
Feb 7 2023, 1:05 PM · Restricted Project, Restricted Project
thieta added inline comments to D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.
Feb 7 2023, 1:04 PM · Restricted Project, Restricted Project
thieta updated the diff for D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.

Added warning when the iOS sdk is not found.
Reworded the commit message to reflect the current state of the patch

Feb 7 2023, 1:04 PM · Restricted Project, Restricted Project
thieta updated the diff for D143468: [CMake] Remove custom ccache CMake logic.

Add a warning when you try to pass LLVM_CCACHE_BUILD=ON to CMake

Feb 7 2023, 12:55 PM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D143295: [bazel] Move bazel configuration to a Python script.

Python is already a hard requirement for many things in the LLVM ecosystem, so I don't think that is an argument. Other than that I don't know enough about Bazel to know if this is good or not.

Feb 7 2023, 8:50 AM · Restricted Project, Restricted Project
thieta added a comment to D143468: [CMake] Remove custom ccache CMake logic.

Happy to do a deprecation warning or error.

Feb 7 2023, 2:09 AM · Restricted Project, Restricted Project, Restricted Project

Feb 6 2023

thieta added a comment to D142726: [Workflow] Add Release Repo sync script.

ping on this @tstellar / @kwk

Feb 6 2023, 11:58 PM · Restricted Project, Restricted Project
thieta added a comment to D143468: [CMake] Remove custom ccache CMake logic.

We could add deprecation warning for this something like:

Feb 6 2023, 11:40 PM · Restricted Project, Restricted Project, Restricted Project
thieta requested review of D143468: [CMake] Remove custom ccache CMake logic.
Feb 6 2023, 11:38 PM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.

I fixed the obvious errors and re-testing it and it seems to behave correctly now. Sorry for the noise.

Feb 6 2023, 11:23 PM · Restricted Project, Restricted Project
thieta updated the diff for D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.

Addressed comments

Feb 6 2023, 11:22 PM · Restricted Project, Restricted Project
thieta added a comment to D143295: [bazel] Move bazel configuration to a Python script.

I have been using "black" to do python formatting in other places. Maybe we should make that part of the LLVM dev guide. But I think it's better if we make formatting changes separately from the functional changes.

Feb 6 2023, 10:46 PM · Restricted Project, Restricted Project
thieta added a comment to D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.

Whoops. Bad copy and paste job. I first made it into a macro and did it for all three SDKs and then realised watchos and tvos is off by default and don't need that probing. Then I probably messed it up when removing the macro. Pretty sure I tested it in this form though ... hmm. Anyway I agree with your comments and will address and retest it tomorrow.

Feb 6 2023, 12:48 PM · Restricted Project, Restricted Project
thieta added a comment to D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.

A long time later, I finally got time to test this since it was marked as necessary to fix before 16.x release.

Feb 6 2023, 5:16 AM · Restricted Project, Restricted Project
thieta updated the diff for D133273: [compiler-rt][macOS]: Disable iOS support if iOS SDK is not found.

Addressed comments

Feb 6 2023, 5:14 AM · Restricted Project, Restricted Project

Feb 2 2023

thieta accepted D143199: [LLVM][Runtimes] Hide unused CMake variable messages for runtimes builds.

I think this is fine. This warning is not very useful when used in this way.

Feb 2 2023, 10:31 AM · Restricted Project, Restricted Project

Feb 1 2023

thieta accepted D142825: [llvm][NFC] Use move instead of copy.

Seems fine to me. Have you tried clang-format locally since the CI job seems broken?

Feb 1 2023, 8:28 AM · Restricted Project, Restricted Project

Jan 27 2023

thieta requested review of D142726: [Workflow] Add Release Repo sync script.
Jan 27 2023, 7:49 AM · Restricted Project, Restricted Project
thieta accepted D142719: workflows: Bump python version on Windows to try to fix lldb failure.

I thought the required version is much less than 3.10? Why is this helping / failing?

There is some problem with the environment in the Windows builders where CMake always wants to select the x86 version of the python libraries instead of the x86_64 version. Setting the python-version to the highest supported version on the Windows builders seems to fix this.

Jan 27 2023, 6:53 AM · Restricted Project, Restricted Project
thieta accepted D142598: Workflows: Fix version-check.py script for when there is no RC tag yet.
Jan 27 2023, 6:40 AM · Restricted Project, Restricted Project
thieta accepted D142720: libclc: Set CMAKE_CXX_STANDARD to 17 to match llvm.

we really should centralize the C++ standard variable in top-level cmake or llvm.

Jan 27 2023, 6:39 AM · Restricted Project, Restricted Project
thieta added a comment to D142719: workflows: Bump python version on Windows to try to fix lldb failure.

I thought the required version is much less than 3.10? Why is this helping / failing?

Jan 27 2023, 6:39 AM · Restricted Project, Restricted Project
thieta accepted D142718: libclc: Fix building against an llvm build directory.

Took me a while to see the difference between the new and old line. Good spot.

Jan 27 2023, 6:38 AM · Restricted Project, Restricted Project
thieta accepted D142716: workflows: Fix libclc tests.
Jan 27 2023, 6:37 AM · Restricted Project, Restricted Project

Jan 17 2023

thieta added a comment to D141751: test-release.sh: Only build native target for stage 1 and stage 2.

I haven't tried the change - but the errors here makes sense. I bet those objects have references to the other targets and they will differ when we disable anything but Native. If we want to keep these checks we probably need to build all targets for phase 2 or filter the list of objects to compare.

Jan 17 2023, 11:31 AM · Restricted Project, Restricted Project
thieta accepted D141919: [Release] Produce mlir tarball.

Makes sense to me. We probably should add bolt in there as well since it's enabled by default now, cc @Amir

Jan 17 2023, 4:17 AM · Restricted Project, Restricted Project

Jan 13 2023

thieta accepted D141751: test-release.sh: Only build native target for stage 1 and stage 2.

Good change!

Jan 13 2023, 11:40 PM · Restricted Project, Restricted Project
thieta accepted D141552: test-release.sh: Only build clang for stage1 and stage2.

Good plan. Let's merge this and we can do another with lld later.

Jan 13 2023, 9:55 AM · Restricted Project, Restricted Project

Jan 12 2023

thieta added a comment to D141552: test-release.sh: Only build clang for stage1 and stage2.

I think we should include lld as well - now that LLD can produce production binaries on all platforms I think it makes sense to prefer that over system linker.

Jan 12 2023, 7:12 AM · Restricted Project, Restricted Project

Jan 8 2023

thieta accepted D136392: [Bazel] Use `LLVM_VERSION` from `llvm/CMakeLists.txt`.

Thanks for making this change. I think the changes to the bump script looks fine if no processing is needed in the future.

Jan 8 2023, 4:49 AM · Restricted Project, Restricted Project

Jan 2 2023

thieta accepted D139184: [LLD][Windows]Feature "checksum" for Windows PE.

Looks like it's ready to go to me. Maybe take a look at the comments inline in the review and mark them as done or reply to them, there were some questions in there that I couldn't see any replies to.

Jan 2 2023, 12:24 AM · Restricted Project, Restricted Project

Dec 29 2022

thieta added inline comments to D140555: [lld][COFF]llvm-readobj COFFDumper print PEHeader CheckSum.
Dec 29 2022, 2:25 AM · Restricted Project, Restricted Project, lld

Dec 21 2022

thieta accepted D140333: [lld][COFF] Fix lld-link crash when several .obj files built with /Zi refer to a .pdb file that failed to load.

Oh sorry for the late reply. I think removing the getter makes sense as well - it worked better when we had the earlier revision that copied string out of the Error etc.

Dec 21 2022, 12:45 PM · Restricted Project, lld, Restricted Project

Dec 19 2022

thieta added a reviewer for D140333: [lld][COFF] Fix lld-link crash when several .obj files built with /Zi refer to a .pdb file that failed to load: aganea.
Dec 19 2022, 12:17 PM · Restricted Project, lld, Restricted Project

Dec 9 2022

thieta added a comment to D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged.

It still looks odd to me, but since the rest of the file has comments like that I am fine with it. But I think we should figure out if they are like that because some tool is parsing them or if it's just legacy.

Dec 9 2022, 1:25 PM · Restricted Project, Restricted Project

Dec 8 2022

thieta added inline comments to D139632: [clang-cl] Ignore #pragma managed / #pragma unmanaged.
Dec 8 2022, 8:18 AM · Restricted Project, Restricted Project

Dec 6 2022

thieta added a comment to D138254: [llvm] Fix the build on OpenBSD by removing LLVM_VERSION_SUFFIX from created shared library names.

If this fixes OpenBSD it looks fine I think. But I wonder if we shouldn't just do this if we are on OpenBSD, changing the SOVERSION has been fraught with problems before since people have scripts that expect certain layouts.

Dec 6 2022, 8:40 AM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D138747: [Support] On Windows 11, fix an affinity mask issue on large core count machines.

Is there any point in adding any tests here that can be useful? Probably not since we are working with the Windows API right? I don't have much to comment on, but it seems reasonable if it solves the problem.

Dec 6 2022, 8:36 AM · Restricted Project, Restricted Project
thieta added a comment to D137724: [CMake] Warn when the version is older than 3.20.0..

I think this is ready to land @Mordante or is there anything else missing?

Dec 6 2022, 8:32 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project