User Details
- User Since
- Oct 18 2019, 11:34 AM (205 w, 20 h)
Wed, Sep 20
Fri, Sep 1
Aug 21 2023
Looks fine to me, I have no experience with AIX but I don't see a problem with this fix.
Aug 19 2023
Hmm. This level of performance hit is not great - it means I will probably have to carry an internal patch to disable if we don't expose a compile time define or option.
Aug 10 2023
Aug 7 2023
LGTM, I would change P to nullptr, unless there is a good reason to check the symbol there.
Aug 3 2023
Aug 2 2023
Jul 29 2023
Jul 25 2023
Jul 18 2023
ACK. When I branch - do I need to do anything in main or just leave it? I wish we could employ this model everywhere I guess :)
Jul 14 2023
Thanks for doing this!
Clarify release note even further
Add example to release notes
- Split the relative patch to this diff https://reviews.llvm.org/D155268
- Added some comments in both Clang and LLD
- Fixed some code style.
- Removed stray changes.
Jul 13 2023
C/R fixes
Switch to prepend paths
This seems to work fine now and have tests. Next up would be to add some dependent-lib statements in various places. Please review this and let me know if there is something else that should be fixed here.
Added tests and rebased
Removed the early exit to behave similar to ld.lld, fixed the tests so they work with this behavior and then I tested all on linux and windows and it seems to work correctly! I think this is good to land.
Jul 12 2023
Yes, I can do that, but I rather wait for @balazske to also approve this.
Jul 11 2023
Looks fine to me.
Jun 15 2023
Thanks for reminding me - I have posted a summary in discourse: https://discourse.llvm.org/t/improve-autolinking-of-compiler-rt-and-libc-on-windows-with-lld-link/71392
Jun 1 2023
Thanks!!
May 26 2023
I implemented a much nicer and easier method to just find the following three paths:
Implemented much simpler method
May 25 2023
rebase
Thanks for doing this! Going to assume you ran the tests and it worked :)
Looks fine to me. But I am unsure if we need to have the toolchain file checked into LLVM. Wouldn't that be up to the person cross-compiling? Going to be hard to assume stuff there?
Can we land this now? It's the one outstanding diff for closing out this reformat.
rebase
Rebase
May 24 2023
Regarding the target handling, what's your opinion on introducing a new option (for example /target:) with the default value being the host target (that is the same behavior that's used by Clang)?
May 23 2023
Hi everyone, and thanks for your input. My goal with this patch is to let lld-link find the rest of the files from the toolchain without teaching every build system in the world extra logic. I have thought about the different ways to handle this, and this one seemed the least complicated, to be honest. If we wanted to directly re-use the clang driver logic with clang -link or similar - we would have to teach the build systems to call clang instead of lld-link, we would have to teach it to pass --target to that, or we would have to parse the machine information out of the object files in clang as well (non-starter I think).
Oh make sure you run black to check for formatting changes. We don't have the CI hooked up yet.
Nice QoL fix here! Thanks!
Hi! This is the first draft of what we discussed at EuroLLVM - to let LLD find the runtime and lib dir to integrate sanitizers easier and libc++ on Windows.
May 22 2023
Rebase
rebase
Rebase
May 19 2023
Rebase