Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

thieta (Tobias Hieta)
LLVM developer at Ubisoft Montreal

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2019, 11:34 AM (205 w, 20 h)

Recent Activity

Wed, Sep 20

thieta added a reverting change for rGda94bf0d5611: [Workflow] Add new code format helper. (#66684): rGfe5c18564174: Revert "[Workflow] Add new code format helper. (#66684)".
Wed, Sep 20, 1:01 AM · Restricted Project, Restricted Project
thieta committed rGfe5c18564174: Revert "[Workflow] Add new code format helper. (#66684)" (authored by thieta).
Revert "[Workflow] Add new code format helper. (#66684)"
Wed, Sep 20, 1:01 AM · Restricted Project, Restricted Project

Fri, Sep 1

thieta committed rG1148cfac51f2: [workflow] Allow creation of PRs in the docs subdir (authored by thieta).
[workflow] Allow creation of PRs in the docs subdir
Fri, Sep 1, 3:32 AM · Restricted Project

Aug 21 2023

thieta accepted D157884: [AIX] Limit `extract_symbols.py`'s Pools Size to 8.

Looks fine to me, I have no experience with AIX but I don't see a problem with this fix.

Aug 21 2023, 1:52 AM · Restricted Project, Restricted Project

Aug 19 2023

thieta added a comment to D155579: [Windows] Avoid using FileIndex for unique IDs.

Hmm. This level of performance hit is not great - it means I will probably have to carry an internal patch to disable if we don't expose a compile time define or option.

Aug 19 2023, 7:14 AM · Restricted Project, Restricted Project

Aug 10 2023

thieta committed rG28226e5a1be0: [Workflow] Run the repository sync script from GH. (authored by thieta).
[Workflow] Run the repository sync script from GH.
Aug 10 2023, 12:02 AM · Restricted Project, Restricted Project
thieta closed D156873: [Workflow] Run the repository sync script from GH..
Aug 10 2023, 12:02 AM · Restricted Project, Restricted Project
thieta updated the diff for D156873: [Workflow] Run the repository sync script from GH..
Aug 10 2023, 12:01 AM · Restricted Project, Restricted Project

Aug 7 2023

thieta added inline comments to D156873: [Workflow] Run the repository sync script from GH..
Aug 7 2023, 1:30 PM · Restricted Project, Restricted Project
thieta accepted D157241: [llvm-rc] Resolve the executable path if not present in Argv[0].

LGTM, I would change P to nullptr, unless there is a good reason to check the symbol there.

Aug 7 2023, 12:23 AM · Restricted Project, Restricted Project
thieta updated the summary of D157254: [Utils] Bump python dependencies in llvm/utils/git.
Aug 7 2023, 12:16 AM · Restricted Project, Restricted Project
thieta requested review of D157254: [Utils] Bump python dependencies in llvm/utils/git.
Aug 7 2023, 12:15 AM · Restricted Project, Restricted Project

Aug 3 2023

thieta committed rW515a4c071134: LLVM 17 schedule (authored by thieta).
LLVM 17 schedule
Aug 3 2023, 1:04 PM · Restricted Project
thieta added inline comments to D156873: [Workflow] Run the repository sync script from GH..
Aug 3 2023, 5:59 AM · Restricted Project, Restricted Project
thieta committed rW0dd79d1d8499: LLVM 17 schedule (authored by thieta).
LLVM 17 schedule
Aug 3 2023, 12:57 AM · Restricted Project

Aug 2 2023

thieta updated the summary of D156873: [Workflow] Run the repository sync script from GH..
Aug 2 2023, 3:39 AM · Restricted Project, Restricted Project
thieta requested review of D156873: [Workflow] Run the repository sync script from GH..
Aug 2 2023, 3:38 AM · Restricted Project, Restricted Project

Jul 29 2023

thieta accepted D156595: Workflows: Allow pull requests for .github directory.
Jul 29 2023, 7:08 AM · Restricted Project, Restricted Project

Jul 25 2023

thieta committed rGab720289ca8f: Bump trunk version to 18.0.0git (authored by thieta).
Bump trunk version to 18.0.0git
Jul 25 2023, 4:59 AM · Restricted Project, Restricted Project, Restricted Project
thieta committed rG4706251a3186: Clear release notes for 18.x (authored by thieta).
Clear release notes for 18.x
Jul 25 2023, 4:59 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

Jul 18 2023

thieta added a comment to D155024: [libc++] Encode the version in the ReleaseNotes file.

ACK. When I branch - do I need to do anything in main or just leave it? I wish we could employ this model everywhere I guess :)

Jul 18 2023, 11:20 AM · Restricted Project, Restricted Project
thieta added a comment to D155579: [Windows] Avoid using FileIndex for unique IDs.

@thieta IIRC you had a usecase where you scan through large numbers of files with LLVM code somewhere. Are you able to take this for a spin to make sure it doesn't affect the performance of your usecase too much?

Jul 18 2023, 5:00 AM · Restricted Project, Restricted Project

Jul 14 2023

thieta committed rGaf744f0b84e2: [LLD][COFF] Add LLVM toolchain library paths by default. (authored by thieta).
[LLD][COFF] Add LLVM toolchain library paths by default.
Jul 14 2023, 5:38 AM · Restricted Project, Restricted Project
thieta closed D151188: [LLD][COFF] Add LLVM toolchain library paths by default..
Jul 14 2023, 5:38 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D151188: [LLD][COFF] Add LLVM toolchain library paths by default..
Jul 14 2023, 3:15 AM · Restricted Project, Restricted Project, Restricted Project
thieta committed rGb6c2f100c23b: [lld][COFF] Find libraries with relative paths. (authored by thieta).
[lld][COFF] Find libraries with relative paths.
Jul 14 2023, 3:10 AM · Restricted Project
thieta closed D155268: [lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk.
Jul 14 2023, 3:10 AM · Restricted Project, Restricted Project
thieta added a comment to D155273: [clang-format] Add TypeNames option to disambiguate types/objects.

Thanks for doing this!

Jul 14 2023, 2:33 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D155268: [lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk.

Clarify release note even further

Jul 14 2023, 2:31 AM · Restricted Project, Restricted Project
thieta retitled D155268: [lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk from [lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk to [lld][COFF] Find libraries with relative paths..
Jul 14 2023, 2:22 AM · Restricted Project, Restricted Project
thieta updated the diff for D155268: [lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk.

Add example to release notes

Jul 14 2023, 2:22 AM · Restricted Project, Restricted Project
thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..
  • Split the relative patch to this diff https://reviews.llvm.org/D155268
  • Added some comments in both Clang and LLD
  • Fixed some code style.
  • Removed stray changes.
Jul 14 2023, 12:53 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D151188: [LLD][COFF] Add LLVM toolchain library paths by default..
Jul 14 2023, 12:51 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D151188: [LLD][COFF] Add LLVM toolchain library paths by default..
Jul 14 2023, 12:49 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D151188: [LLD][COFF] Add LLVM toolchain library paths by default..
Jul 14 2023, 12:48 AM · Restricted Project, Restricted Project, Restricted Project
thieta retitled D155268: [lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk from [lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk to [lld][COFF] Find libraries with relative paths.
Jul 14 2023, 12:44 AM · Restricted Project, Restricted Project
thieta requested review of D155268: [lld][COFF] Find libraries with relative paths. r=hans,maskray,mstorsjo,phosek,rnk.
Jul 14 2023, 12:43 AM · Restricted Project, Restricted Project

Jul 13 2023

thieta updated the diff for D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

C/R fixes

Jul 13 2023, 7:58 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

Switch to prepend paths

Jul 13 2023, 3:30 AM · Restricted Project, Restricted Project, Restricted Project
thieta added inline comments to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..
Jul 13 2023, 2:01 AM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

This seems to work fine now and have tests. Next up would be to add some dependent-lib statements in various places. Please review this and let me know if there is something else that should be fixed here.

Jul 13 2023, 1:59 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

Added tests and rebased

Jul 13 2023, 1:57 AM · Restricted Project, Restricted Project, Restricted Project
thieta committed rG33f93425dd1b: [lld][COFF] Add -print-search-paths for debugging. (authored by thieta).
[lld][COFF] Add -print-search-paths for debugging.
Jul 13 2023, 1:54 AM · Restricted Project
thieta closed D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 13 2023, 1:53 AM · Restricted Project, Restricted Project
thieta added a comment to D155047: [lld][COFF] Add -print-search-paths for debugging..

Removed the early exit to behave similar to ld.lld, fixed the tests so they work with this behavior and then I tested all on linux and windows and it seems to work correctly! I think this is good to land.

Jul 13 2023, 12:50 AM · Restricted Project, Restricted Project
thieta updated the diff for D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 13 2023, 12:49 AM · Restricted Project, Restricted Project
thieta updated the diff for D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 13 2023, 12:13 AM · Restricted Project, Restricted Project

Jul 12 2023

thieta added inline comments to D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 12 2023, 12:01 PM · Restricted Project, Restricted Project
thieta added a comment to D155047: [lld][COFF] Add -print-search-paths for debugging..

By the way, do we have a github issue tracking the whole https://discourse.llvm.org/t/improve-autolinking-of-compiler-rt-and-libc-on-windows-with-lld-link/71392/ situation? If so it would be nice to reference it in the commit.

Jul 12 2023, 6:45 AM · Restricted Project, Restricted Project
thieta added inline comments to D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 12 2023, 5:47 AM · Restricted Project, Restricted Project
thieta updated the diff for D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 12 2023, 5:46 AM · Restricted Project, Restricted Project
thieta added inline comments to D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 12 2023, 3:41 AM · Restricted Project, Restricted Project
thieta added a comment to D155047: [lld][COFF] Add -print-search-paths for debugging..

Seems handy to me. We could also add this kind of info to the /verbose output, but having a separate option is probably more convenient.

Jul 12 2023, 3:40 AM · Restricted Project, Restricted Project
thieta updated the diff for D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 12 2023, 3:22 AM · Restricted Project, Restricted Project
thieta added a comment to D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block.

Yes, I can do that, but I rather wait for @balazske to also approve this.

Jul 12 2023, 12:29 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the summary of D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 12 2023, 12:27 AM · Restricted Project, Restricted Project
thieta requested review of D155047: [lld][COFF] Add -print-search-paths for debugging..
Jul 12 2023, 12:25 AM · Restricted Project, Restricted Project

Jul 11 2023

thieta accepted D154983: [clang-extdef-mapping] register necessary targest for ms-style asm block.

Looks fine to me.

Jul 11 2023, 11:08 AM · Restricted Project, Restricted Project, Restricted Project

Jun 15 2023

thieta added a comment to D144734: [libcxx] Enable support for static and debug Windows runtimes.

Thanks for reminding me - I have posted a summary in discourse: https://discourse.llvm.org/t/improve-autolinking-of-compiler-rt-and-libc-on-windows-with-lld-link/71392

Jun 15 2023, 4:46 AM · Restricted Project, Restricted Project

Jun 1 2023

thieta accepted D151914: [NFC][Py Reformat] Reformat python files in llvm-test-suite.

Thanks!!

Jun 1 2023, 11:58 AM · Restricted Project

May 26 2023

thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

I implemented a much nicer and easier method to just find the following three paths:

May 26 2023, 6:20 AM · Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

Implemented much simpler method

May 26 2023, 6:16 AM · Restricted Project, Restricted Project, Restricted Project

May 25 2023

thieta committed rGe46aa6d3b6b8: [NFC][Py Reformat] Reformat version-check.py in .github dir (authored by thieta).
[NFC][Py Reformat] Reformat version-check.py in .github dir
May 25 2023, 11:11 PM · Restricted Project
thieta committed rGaf2c93650a78: [NFC] Add mlir python reformat SHA to .git-blame-ignore-revs (authored by thieta).
[NFC] Add mlir python reformat SHA to .git-blame-ignore-revs
May 25 2023, 11:06 PM · Restricted Project
thieta committed rGf9008e6366c2: [NFC][Py Reformat] Reformat python files in mlir subdir (authored by thieta).
[NFC][Py Reformat] Reformat python files in mlir subdir
May 25 2023, 11:06 PM · Restricted Project, Restricted Project
thieta closed D150782: [NFC][Py Reformat] Reformat python files in mlir subdir.
May 25 2023, 11:06 PM · Restricted Project, Restricted Project
thieta updated the diff for D150782: [NFC][Py Reformat] Reformat python files in mlir subdir.

rebase

May 25 2023, 11:05 PM · Restricted Project, Restricted Project
thieta added a comment to D151460: [NFC][Py Reformat] Reformat python files in lldb.

Can you add this commit hash to the .git-blame-ignore-revs file so it doesn't show up in the git history

May 25 2023, 9:21 AM · Restricted Project, Restricted Project
thieta accepted D151460: [NFC][Py Reformat] Reformat python files in lldb.

Thanks for doing this! Going to assume you ran the tests and it worked :)

May 25 2023, 9:02 AM · Restricted Project, Restricted Project
thieta added a comment to D151385: test-release.sh: Add support for cross-compiling.

Looks fine to me. But I am unsure if we need to have the toolchain file checked into LLVM. Wouldn't that be up to the person cross-compiling? Going to be hard to assume stuff there?

I wanted to add cross-compile support so that we could build 'official' binaries using GitHub actions for other arches besides x86_64. For this scenario, I think it makes sense to have the toolchain file somewhere in tree, so that it is easy to reproduce the builds. This specific file works with a container image that I created with all the necessary cross-libs, which I would also like to put in tree somewhere.

May 25 2023, 6:28 AM · Restricted Project, Restricted Project
thieta added inline comments to D151385: test-release.sh: Add support for cross-compiling.
May 25 2023, 5:47 AM · Restricted Project, Restricted Project
thieta added a comment to D151385: test-release.sh: Add support for cross-compiling.

Looks fine to me. But I am unsure if we need to have the toolchain file checked into LLVM. Wouldn't that be up to the person cross-compiling? Going to be hard to assume stuff there?

May 25 2023, 5:37 AM · Restricted Project, Restricted Project
thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

I think we should aim for this to work out of the box:

May 25 2023, 4:33 AM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D150782: [NFC][Py Reformat] Reformat python files in mlir subdir.

Can we land this now? It's the one outstanding diff for closing out this reformat.

May 25 2023, 2:20 AM · Restricted Project, Restricted Project
thieta updated the diff for D150782: [NFC][Py Reformat] Reformat python files in mlir subdir.

rebase

May 25 2023, 2:19 AM · Restricted Project, Restricted Project
thieta committed rG89242ed6a28b: [NFC] Add more python reformat SHA to .git-blame-ignore-revs (authored by thieta).
[NFC] Add more python reformat SHA to .git-blame-ignore-revs
May 25 2023, 2:17 AM · Restricted Project
thieta committed rGf98ee40f4b5d: [NFC][Py Reformat] Reformat python files in the rest of the dirs (authored by thieta).
[NFC][Py Reformat] Reformat python files in the rest of the dirs
May 25 2023, 2:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
thieta closed D150784: [NFC][Py Reformat] Reformat python files in the rest of the dirs.
May 25 2023, 2:17 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
thieta committed rG35ea4e2dbf32: [NFC] Add libcxx python reformat SHA to .git-blame-ignore-revs (authored by thieta).
[NFC] Add libcxx python reformat SHA to .git-blame-ignore-revs
May 25 2023, 2:16 AM · Restricted Project
thieta committed rG7bfaa0f09d05: [NFC][Py Reformat] Reformat python files in libcxx/libcxxabi (authored by thieta).
[NFC][Py Reformat] Reformat python files in libcxx/libcxxabi
May 25 2023, 2:16 AM · Restricted Project, Restricted Project
thieta closed D150763: [NFC][Py Reformat] Reformat python files in libcxx/libcxxabi.
May 25 2023, 2:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D150763: [NFC][Py Reformat] Reformat python files in libcxx/libcxxabi.

Rebase

May 25 2023, 2:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 24 2023

thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

Regarding the target handling, what's your opinion on introducing a new option (for example /target:) with the default value being the host target (that is the same behavior that's used by Clang)?

May 24 2023, 4:19 AM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

The target handling, which seems to be the tricky part, is only needed for LLVM_ENABLE_PER_TARGET_RUNTIME_DIR builds, right? And as far as I know that's not used on Windows, so maybe it's not needed?

May 24 2023, 3:02 AM · Restricted Project, Restricted Project, Restricted Project
thieta added inline comments to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..
May 24 2023, 2:07 AM · Restricted Project, Restricted Project, Restricted Project

May 23 2023

thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

Hi everyone, and thanks for your input. My goal with this patch is to let lld-link find the rest of the files from the toolchain without teaching every build system in the world extra logic. I have thought about the different ways to handle this, and this one seemed the least complicated, to be honest. If we wanted to directly re-use the clang driver logic with clang -link or similar - we would have to teach the build systems to call clang instead of lld-link, we would have to teach it to pass --target to that, or we would have to parse the machine information out of the object files in clang as well (non-starter I think).

May 23 2023, 11:28 PM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

I also only looked briefly, but it seems like this assumes LLVM_ENABLE_PER_TARGET_RUNTIME_DIR builds? I think that's still off by default on Windows, so maybe it would be enough to start with supporting the non-per-target-runtime-dir case, or we should aim to support both cases.

May 23 2023, 6:25 AM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

I believe this is closely related to what D150981 does too - please have a look at that if it helps something here.

May 23 2023, 1:41 AM · Restricted Project, Restricted Project, Restricted Project
thieta added a comment to D151191: [llvm][github] Allow github links in /cherry-pick actions.

Oh make sure you run black to check for formatting changes. We don't have the CI hooked up yet.

May 23 2023, 1:35 AM · Restricted Project, Restricted Project
thieta accepted D151191: [llvm][github] Allow github links in /cherry-pick actions.

Nice QoL fix here! Thanks!

May 23 2023, 1:35 AM · Restricted Project, Restricted Project
thieta added a comment to D151188: [LLD][COFF] Add LLVM toolchain library paths by default..

Hi! This is the first draft of what we discussed at EuroLLVM - to let LLD find the runtime and lib dir to integrate sanitizers easier and libc++ on Windows.

May 23 2023, 1:15 AM · Restricted Project, Restricted Project, Restricted Project
thieta requested review of D151188: [LLD][COFF] Add LLVM toolchain library paths by default..
May 23 2023, 1:06 AM · Restricted Project, Restricted Project, Restricted Project

May 22 2023

thieta updated the diff for D150782: [NFC][Py Reformat] Reformat python files in mlir subdir.

Rebase

May 22 2023, 11:42 PM · Restricted Project, Restricted Project
thieta updated the diff for D150763: [NFC][Py Reformat] Reformat python files in libcxx/libcxxabi.

rebase

May 22 2023, 11:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thieta added inline comments to D150763: [NFC][Py Reformat] Reformat python files in libcxx/libcxxabi.
May 22 2023, 11:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thieta updated the diff for D150784: [NFC][Py Reformat] Reformat python files in the rest of the dirs.

Rebase

May 22 2023, 11:33 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
thieta committed rG51b216916b11: [NFC] Add clang python reformat SHA to .git-blame-ignore-revs (authored by thieta).
[NFC] Add clang python reformat SHA to .git-blame-ignore-revs
May 22 2023, 11:31 PM · Restricted Project
thieta committed rGdd3c26a045c0: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra (authored by thieta).
[NFC][Py Reformat] Reformat python files in clang and clang-tools-extra
May 22 2023, 11:30 PM · Restricted Project, Restricted Project, Restricted Project
thieta closed D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra.
May 22 2023, 11:30 PM · Restricted Project, Restricted Project, Restricted Project

May 19 2023

thieta updated the diff for D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra.

Rebase

May 19 2023, 12:40 AM · Restricted Project, Restricted Project, Restricted Project