Page MenuHomePhabricator

thieta (Tobias Hieta)
Team Lead - Build and Integration at Plex.tv

Projects

User does not belong to any projects.

User Details

User Since
Oct 18 2019, 11:34 AM (48 w, 2 d)

Recent Activity

Jun 8 2020

thieta added a comment to D80492: Avoid linking libdl unless needed.

@lebedev.ri fix for your issue posted here: https://reviews.llvm.org/D81385

Jun 8 2020, 6:31 AM · Restricted Project
thieta created D81385: Fix libdl linking for libclang in standalone mode.
Jun 8 2020, 6:31 AM · Restricted Project

Jun 3 2020

thieta added a comment to D80492: Avoid linking libdl unless needed.

Thanks - I'll look into a fix.

Jun 3 2020, 9:25 PM · Restricted Project

May 28 2020

thieta added a comment to D80492: Avoid linking libdl unless needed.

@mstorsjo mind landing this for me as well?

May 28 2020, 5:57 AM · Restricted Project

May 24 2020

thieta updated the diff for D80493: [CMake]: Properly handle the LTO cache arguments for MinGW.

Updated with parenthesis - feel free to commit if it looks good to you. Same as before Tobias Hieta tobias@hieta.se.

May 24 2020, 1:51 PM · Restricted Project
thieta added inline comments to D80493: [CMake]: Properly handle the LTO cache arguments for MinGW.
May 24 2020, 12:48 PM · Restricted Project
thieta added a comment to D80493: [CMake]: Properly handle the LTO cache arguments for MinGW.

Well, wasn't it the case that lto mingw builds were broken to begin with? So either nobody did it, or they already patched around it (and will need to adjust their patch)?

May 24 2020, 12:48 PM · Restricted Project
thieta created D80493: [CMake]: Properly handle the LTO cache arguments for MinGW.
May 24 2020, 10:08 AM · Restricted Project
thieta created D80492: Avoid linking libdl unless needed.
May 24 2020, 10:08 AM · Restricted Project
thieta abandoned D80425: Fix LLVM/Clang builds with mingw toolchain.
May 24 2020, 9:36 AM · Restricted Project, Restricted Project
thieta added a comment to D80425: Fix LLVM/Clang builds with mingw toolchain.

Sounds good - I'll close this one and open three new ones.

May 24 2020, 9:36 AM · Restricted Project, Restricted Project
thieta added a comment to D80425: Fix LLVM/Clang builds with mingw toolchain.

I am planning to revise this one now that we have thinlto-cache-dir option landed here are my plans:

May 24 2020, 6:23 AM · Restricted Project, Restricted Project
thieta added a comment to D80438: [LLD/MinGW]: Expose --thinlto-cache-dir.

"Tobias Hieta <tobias@hieta.se>" thanks!

May 24 2020, 12:29 AM · Restricted Project, lld
thieta added a comment to D80425: Fix LLVM/Clang builds with mingw toolchain.
May 24 2020, 12:29 AM · Restricted Project, Restricted Project

May 23 2020

thieta added a comment to D80438: [LLD/MinGW]: Expose --thinlto-cache-dir.

Could you commit this for me Martin? I don't have access yet.

May 23 2020, 1:47 PM · Restricted Project, lld
thieta added a comment to D80425: Fix LLVM/Clang builds with mingw toolchain.
May 23 2020, 1:47 PM · Restricted Project, Restricted Project
thieta updated the diff for D80438: [LLD/MinGW]: Expose --thinlto-cache-dir.
May 23 2020, 6:19 AM · Restricted Project, lld

May 22 2020

thieta created D80438: [LLD/MinGW]: Expose --thinlto-cache-dir.
May 22 2020, 6:56 AM · Restricted Project, lld
thieta added inline comments to D80425: Fix LLVM/Clang builds with mingw toolchain.
May 22 2020, 6:23 AM · Restricted Project, Restricted Project
thieta created D80425: Fix LLVM/Clang builds with mingw toolchain.
May 22 2020, 2:25 AM · Restricted Project, Restricted Project

Apr 18 2020

thieta added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

Thanks guys - I don't have commit access. So could anyone of you commit this? Please use my email address tobias@hieta.se if you commit as another author.

Apr 18 2020, 6:28 AM · Restricted Project, lld

Apr 17 2020

thieta added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

@psmith This worked! All patches is now passing with the latest diff. I did a quick rebase as well - no conflicts.

Apr 17 2020, 2:04 PM · Restricted Project, lld
thieta updated the diff for D77330: Consider increasing the default ARM32 max page size to 64k..

This applies the latest patch from @psmith which means that all the tests now passes! 🎉

Apr 17 2020, 2:04 PM · Restricted Project, lld

Apr 16 2020

thieta retitled D77330: Consider increasing the default ARM32 max page size to 64k. from Consider increasing the default ARM32 page size to 64k. to Consider increasing the default ARM32 max page size to 64k..
Apr 16 2020, 2:49 AM · Restricted Project, lld
thieta updated the diff for D77330: Consider increasing the default ARM32 max page size to 64k..

I have applied @psmith changes to arm-branch-rangethunk.s and reworked arm-branch.s to work with the changes above.

Apr 16 2020, 2:49 AM · Restricted Project, lld
thieta added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

we are now only down to two failing tests:

Apr 16 2020, 2:49 AM · Restricted Project, lld

Apr 15 2020

thieta added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

Oh I see that there are some files I forgot to update the comments to have /// - I'll revisit them later this week.

Apr 15 2020, 8:11 AM · Restricted Project, lld
thieta updated the diff for D77330: Consider increasing the default ARM32 max page size to 64k..

This adjusts the comments as suggested by @psmith and addresses all the tests except the following three:

Apr 15 2020, 8:11 AM · Restricted Project, lld

Apr 12 2020

thieta added inline comments to D77330: Consider increasing the default ARM32 max page size to 64k..
Apr 12 2020, 6:23 AM · Restricted Project, lld
thieta added inline comments to D77330: Consider increasing the default ARM32 max page size to 64k..
Apr 12 2020, 5:51 AM · Restricted Project, lld

Apr 9 2020

thieta added inline comments to D77330: Consider increasing the default ARM32 max page size to 64k..
Apr 9 2020, 1:20 PM · Restricted Project, lld
thieta updated the diff for D77330: Consider increasing the default ARM32 max page size to 64k..

I have started working on the tests - I have 17 left to do - but since the diff is going to be big I thought I wanted to upload this for now and start collecting feedback to make sure I am doing the right things here.

Apr 9 2020, 1:18 PM · Restricted Project, lld

Apr 8 2020

thieta accepted D77746: [Driver] Default arm-linux-androideabi to -z max-page-size=4096.

Thanks for handling this!

Apr 8 2020, 11:57 AM · Restricted Project

Apr 7 2020

thieta added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

A small ping here.

Apr 7 2020, 8:07 AM · Restricted Project, lld

Apr 3 2020

thieta added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

So it sounds like I could go ahead and start changing the tests to match this? I can get to it during the weekend I hope. I anyone have a huge objection to this getting merged - let me know asap.

Apr 3 2020, 10:42 PM · Restricted Project, lld
thieta added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

@srhines Thanks for your reply! Would it be enough for you guys to expand this block in clang https://github.com/llvm/llvm-project/blob/master/clang/lib/Driver/ToolChains/Linux.cpp#L256 for Android's usage? Or would a change in lld make more sense?

Apr 3 2020, 6:24 AM · Restricted Project, lld
thieta added a comment to D77330: Consider increasing the default ARM32 max page size to 64k..

Hello Nick,

Apr 3 2020, 12:30 AM · Restricted Project, lld

Apr 2 2020

thieta created D77330: Consider increasing the default ARM32 max page size to 64k..
Apr 2 2020, 12:28 PM · Restricted Project, lld

Oct 31 2019

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Thanks everyone! It was a great learning experience getting this patch in and learning more about building/testing LLVM!

Oct 31 2019, 5:08 AM · Restricted Project

Oct 30 2019

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Can someone please commit this for me if everyone is happy with it now?

Oct 30 2019, 12:29 PM · Restricted Project
thieta updated the diff for D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Updated the tests with @jhenderson comments.

Oct 30 2019, 3:27 AM · Restricted Project
thieta added inline comments to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.
Oct 30 2019, 2:59 AM · Restricted Project
thieta updated the diff for D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Fixed all outstanding comments with documentation, test cases and linking to the correct upstream bug.

Oct 30 2019, 2:21 AM · Restricted Project
thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

So chatted with Sledge. Their authoritative input on this matter is that we do need to carry a workaround. I think this patch is good to go once Sledge has an official bug id and the comment is updated with that piece of information.

<Sledge> it's going to take quite a while for that fix to filter through to users, particularly for Ubuntu and Debian LTS users :-/

Oct 30 2019, 1:08 AM · Restricted Project

Oct 28 2019

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

I totally defer to you guys on if this is something you want to accept or not. We are now patching our own toolchain with this patch to not create bad binaries. If I where to make a case for accepting this patch it would be something like:

Oct 28 2019, 2:45 AM · Restricted Project

Oct 24 2019

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

@rupprecht - Thanks! I have addressed the comments and uploaded a new rev. Hope I did it correctly. I don't have commit access - if you could commit it for me it would be great. I might have other patches in the future (looking at you MingW driver) but I'll cross that bridge then.

Oct 24 2019, 8:15 PM · Restricted Project
thieta updated the diff for D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

This revision should address all the comments in the previous revision. Comments are updated, testing --strip-all-gnu and documentation changes. Let me know if you have additional comments.

Oct 24 2019, 8:13 PM · Restricted Project

Oct 21 2019

thieta added inline comments to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.
Oct 21 2019, 8:59 PM · Restricted Project
thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Thanks everyone for the feedback. I was meeting up with our QA team this week and they said that they seen the issue with these binaries on a much larger array of devices than I initially thought. This is not a bug in upstream GLIBC - this is a bug in debian/ubuntu versions that patch glibc to specifically check for SHT_ARM_ATTRIBUTES. We tested with all debian based NAS devices we had and saw the same issue. We even tested with raspbian on raspberry pi and this also contains the issue.

Oct 21 2019, 5:21 AM · Restricted Project

Oct 18 2019

thieta added a comment to D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files.

Seems like a hack, no? What about using --keep-section when you need it? You say its not strictly needed on modern systems and the problem is with the dlopen implementation of these older libcs, and not llvm-objcopy, so I would be hesitant to add something like this especially given we have a solution with [[ https://llvm.org/docs/CommandGuide/llvm-objcopy.html#cmdoption-llvm-objcopy-keep-section | --keep-section ]]

Oct 18 2019, 12:59 PM · Restricted Project
Herald added a reviewer for D69188: [llvm-objcopy] Preserve .ARM.attributes section when stripping files: alexshap.
Oct 18 2019, 11:44 AM · Restricted Project