This is an archive of the discontinued LLVM Phabricator instance.

[CostModel] Add CostKind argument to getShuffleCost
ClosedPublic

Authored by RKSimon on Aug 20 2022, 3:50 AM.

Details

Summary

Defaults to TCK_RecipThroughput - as most explicit calls were assuming TCK_RecipThroughput (vectorizers) or was just doing a before-vs-after comparison (vectorcombiner). Calls via getInstructionCost were just dropping the CostKind, so again there should be no change at this time - but it will make it easier for us to better account for size/latency shuffle costs in inline/unroll passes in the future.

Diff Detail

Event Timeline

RKSimon created this revision.Aug 20 2022, 3:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2022, 3:50 AM
RKSimon requested review of this revision.Aug 20 2022, 3:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 20 2022, 3:50 AM
This revision is now accepted and ready to land.Aug 20 2022, 4:15 AM
dmgreen accepted this revision.Aug 20 2022, 11:31 AM

Sounds good to me.

This revision was landed with ongoing or failed builds.Aug 21 2022, 2:57 AM
This revision was automatically updated to reflect the committed changes.