Switch variadic operand and result segment size attributes to use the
dense i32 array. Dense integer arrays were introduced primarily to
represent index lists. They are a better fit for segment sizes than
dense elements attrs.
Depends on D131738
Paths
| Differential D131702
[mlir] Switch segment size attributes to DenseI32ArrayAttr ClosedPublic Authored by Mogball on Aug 11 2022, 10:59 AM.
Details Summary Switch variadic operand and result segment size attributes to use the Depends on D131738
Diff Detail
Event TimelineHerald added subscribers: stephenneuendorffer, nicolasvasilache, jdoerfert, jholewinski. · View Herald Transcript
Mogball marked an inline comment as done. This revision is now accepted and ready to land.Aug 11 2022, 4:25 PM This revision was landed with ongoing or failed builds.Aug 11 2022, 5:56 PM Closed by commit rG30171e76f0e5: [mlir] Switch segment size attributes to DenseI32ArrayAttr (authored by Mogball). · Explain Why This revision was automatically updated to reflect the committed changes. Comment Actions Repro: ~/llvm-project/build$ PYTHONPATH=$PWD/tools/mlir/python_packages/mlir_core:$PYTHONPATH python3 ../mlir/test/python/dialects/ods_helpers.py | FileCheck ../mlir/test/python/dialects/ods_helpers.py There is no quick fix forward as DenseI*ArrayAttr doesn't seem to be exposed to either C API or Python. I will revert for now. ftynse added a reverting change: rGe8e718fa4b85: Revert "[mlir] Switch segment size attributes to DenseI32ArrayAttr".Aug 12 2022, 1:23 AM
Revision Contents
Diff 452044 flang/include/flang/Optimizer/Dialect/FIROps.td
flang/lib/Lower/OpenACC.cpp
flang/lib/Optimizer/Dialect/FIROps.cpp
flang/test/Fir/convert-to-llvm-openmp-and-fir.fir
flang/test/Fir/convert-to-llvm.fir
mlir/docs/PatternRewriter.md
mlir/include/mlir/Dialect/ControlFlow/IR/ControlFlowOps.td
mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
mlir/include/mlir/Dialect/MemRef/IR/MemRefOps.td
mlir/include/mlir/Dialect/PDLInterp/IR/PDLInterpOps.td
mlir/include/mlir/IR/ValueRange.h
mlir/lib/Dialect/Async/IR/Async.cpp
mlir/lib/Dialect/Bufferization/IR/BufferizationOps.cpp
mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp
mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp
mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
mlir/lib/Dialect/OpenACC/IR/OpenACC.cpp
mlir/lib/Dialect/SCF/IR/SCF.cpp
mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
mlir/lib/Dialect/Vector/IR/VectorOps.cpp
mlir/lib/IR/Operation.cpp
mlir/lib/IR/OperationSupport.cpp
mlir/lib/Rewrite/ByteCode.cpp
mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp
mlir/test/Conversion/OpenMPToLLVM/convert-to-llvmir.mlir
mlir/test/Dialect/GPU/invalid.mlir
mlir/test/Dialect/Linalg/named-ops.mlir
mlir/test/Dialect/OpenMP/invalid.mlir
mlir/test/Dialect/OpenMP/ops.mlir
mlir/test/Dialect/PDL/invalid.mlir
mlir/test/Dialect/PDLInterp/invalid.mlir
mlir/test/Dialect/SCF/invalid.mlir
mlir/test/Dialect/SPIRV/IR/control-flow-ops.mlir
mlir/test/IR/parser.mlir
mlir/test/IR/traits.mlir
mlir/test/Rewrite/pdl-bytecode.mlir
mlir/test/Target/LLVMIR/openmp-llvm.mlir
mlir/test/Transforms/canonicalize-block-merge.mlir
mlir/test/Transforms/sccp.mlir
mlir/test/lib/Dialect/Test/TestOps.td
mlir/test/python/dialects/linalg/ops.py
mlir/test/python/dialects/ods_helpers.py
mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
mlir/tools/mlir-tblgen/OpFormatGen.cpp
|
Now the discussion on the generic syntax for this becomes more important: it feels unfortunate to introduce this widely if we are planning to change it.