Page MenuHomePhabricator

ThomasRaoux (Thomas Raoux)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 29 2019, 2:32 PM (76 w, 5 d)

Recent Activity

Yesterday

ThomasRaoux committed rGfd2083d73c2d: [mlir] Fixing potential build break in my previous commit (authored by ThomasRaoux).
[mlir] Fixing potential build break in my previous commit
Fri, Jan 15, 5:38 PM
ThomasRaoux committed rG3afbfb4145be: [mlir][NFC] Move helper substWithMin into Affine utils (authored by ThomasRaoux).
[mlir][NFC] Move helper substWithMin into Affine utils
Fri, Jan 15, 5:14 PM
ThomasRaoux closed D94826: [mlir][NFC] Move helper substWithMin into Affine utils.
Fri, Jan 15, 5:14 PM · Restricted Project
ThomasRaoux added a comment to D94843: [mlir][affine] Fix crash when composing affine_expr with symbol multiplying dim.

I had another patch that would skip converting symbols to dimension when it is multiplied/divided by another dimension however this prevented the transformation in the original version of symbolic_semi_affine. Please let me know if you think there is a better solution as I'm not super familiar with affine expressions.

Fri, Jan 15, 3:59 PM · Restricted Project
ThomasRaoux requested review of D94843: [mlir][affine] Fix crash when composing affine_expr with symbol multiplying dim.
Fri, Jan 15, 3:57 PM · Restricted Project
ThomasRaoux requested review of D94826: [mlir][NFC] Move helper substWithMin into Affine utils.
Fri, Jan 15, 2:07 PM · Restricted Project

Mon, Jan 11

ThomasRaoux accepted D94441: [mlir][vector] verify memref of vector memory ops.
Mon, Jan 11, 12:43 PM · Restricted Project
ThomasRaoux committed rGc1ae378205db: [mlir][vector] Add side-effect information to different load/store ops (authored by ThomasRaoux).
[mlir][vector] Add side-effect information to different load/store ops
Mon, Jan 11, 12:34 PM
ThomasRaoux closed D94434: [mlir][vector] Add side-effect information to different load/store ops.
Mon, Jan 11, 12:34 PM · Restricted Project
ThomasRaoux added inline comments to D94434: [mlir][vector] Add side-effect information to different load/store ops.
Mon, Jan 11, 12:10 PM · Restricted Project
ThomasRaoux updated the diff for D94434: [mlir][vector] Add side-effect information to different load/store ops.

removed DefaultResource

Mon, Jan 11, 12:09 PM · Restricted Project
ThomasRaoux added inline comments to D94434: [mlir][vector] Add side-effect information to different load/store ops.
Mon, Jan 11, 10:49 AM · Restricted Project
ThomasRaoux updated the diff for D94434: [mlir][vector] Add side-effect information to different load/store ops.

rename test function

Mon, Jan 11, 10:49 AM · Restricted Project
ThomasRaoux requested review of D94434: [mlir][vector] Add side-effect information to different load/store ops.
Mon, Jan 11, 10:38 AM · Restricted Project
ThomasRaoux committed rG3d693bd0bd77: [mlir][vector] Add memory effects to transfer_read transfer_write ops (authored by ThomasRaoux).
[mlir][vector] Add memory effects to transfer_read transfer_write ops
Mon, Jan 11, 9:26 AM
ThomasRaoux closed D94318: [mlir][vector] Add memory effects to transfer_read transfer_write ops.
Mon, Jan 11, 9:25 AM · Restricted Project

Fri, Jan 8

ThomasRaoux accepted D94278: [mlir][vector] generalized masked l/s and compressed l/s with indices.
Fri, Jan 8, 11:48 AM · Restricted Project
ThomasRaoux added inline comments to D94278: [mlir][vector] generalized masked l/s and compressed l/s with indices.
Fri, Jan 8, 11:33 AM · Restricted Project
ThomasRaoux updated the diff for D94318: [mlir][vector] Add memory effects to transfer_read transfer_write ops.

Address review comments.

Fri, Jan 8, 11:13 AM · Restricted Project
ThomasRaoux added a comment to D94318: [mlir][vector] Add memory effects to transfer_read transfer_write ops.

do we need similar extensions for the other load/store flavors (masked load/store, gather/scatter, compress/expand)?
[if so, please let's wait until my CL is in to avoid conflicts, since I have been making some mods to those ops]

Fri, Jan 8, 11:12 AM · Restricted Project
ThomasRaoux requested review of D94318: [mlir][vector] Add memory effects to transfer_read transfer_write ops.
Fri, Jan 8, 9:53 AM · Restricted Project

Wed, Jan 6

ThomasRaoux committed rG080943f7525f: [mlir][vector] Support transfer op on tensor optimizations (authored by ThomasRaoux).
[mlir][vector] Support transfer op on tensor optimizations
Wed, Jan 6, 3:09 PM
ThomasRaoux closed D94148: [mlir][vector] Support transfer op on tensor optimizations.
Wed, Jan 6, 3:09 PM · Restricted Project
ThomasRaoux committed rGefd05040e13e: [mlir] Add hoisting transformation for transfer ops on tensor (authored by ThomasRaoux).
[mlir] Add hoisting transformation for transfer ops on tensor
Wed, Jan 6, 2:24 PM
ThomasRaoux closed D94115: [mlir] Add hoisting transformation for transfer ops on tensor.
Wed, Jan 6, 2:24 PM · Restricted Project
ThomasRaoux committed rGf9190c868137: [mlir][vector] Support unrolling for transfer ops using tensors (authored by ThomasRaoux).
[mlir][vector] Support unrolling for transfer ops using tensors
Wed, Jan 6, 1:54 PM
ThomasRaoux closed D93904: [mlir][vector] Support unrolling for transfer ops using tensors.
Wed, Jan 6, 1:54 PM · Restricted Project
ThomasRaoux added inline comments to D94115: [mlir] Add hoisting transformation for transfer ops on tensor.
Wed, Jan 6, 11:28 AM · Restricted Project
ThomasRaoux updated the diff for D94115: [mlir] Add hoisting transformation for transfer ops on tensor.

Address review feedback.

Wed, Jan 6, 11:24 AM · Restricted Project
ThomasRaoux added inline comments to D93904: [mlir][vector] Support unrolling for transfer ops using tensors.
Wed, Jan 6, 10:38 AM · Restricted Project
ThomasRaoux updated the diff for D93904: [mlir][vector] Support unrolling for transfer ops using tensors.

Address review comment

Wed, Jan 6, 10:36 AM · Restricted Project
ThomasRaoux added inline comments to D94148: [mlir][vector] Support transfer op on tensor optimizations.
Wed, Jan 6, 9:41 AM · Restricted Project
ThomasRaoux updated the diff for D94148: [mlir][vector] Support transfer op on tensor optimizations.

Fix bug caught in review and add extra test. Address more review feedback.

Wed, Jan 6, 9:38 AM · Restricted Project

Tue, Jan 5

ThomasRaoux requested review of D94148: [mlir][vector] Support transfer op on tensor optimizations.
Tue, Jan 5, 7:28 PM · Restricted Project
ThomasRaoux updated the diff for D94115: [mlir] Add hoisting transformation for transfer ops on tensor.
Tue, Jan 5, 7:19 PM · Restricted Project
ThomasRaoux requested review of D94115: [mlir] Add hoisting transformation for transfer ops on tensor.
Tue, Jan 5, 1:12 PM · Restricted Project

Tue, Dec 29

ThomasRaoux requested review of D93904: [mlir][vector] Support unrolling for transfer ops using tensors.
Tue, Dec 29, 10:05 AM · Restricted Project
ThomasRaoux committed rGcf216670a0bd: [mlir][linalg] Add vectorization for linalg on tensor ops (authored by ThomasRaoux).
[mlir][linalg] Add vectorization for linalg on tensor ops
Tue, Dec 29, 9:03 AM
ThomasRaoux closed D93890: [mlir][linalg] Add vectorization for linalg on tensor ops.
Tue, Dec 29, 9:03 AM · Restricted Project
ThomasRaoux updated the diff for D93890: [mlir][linalg] Add vectorization for linalg on tensor ops.

Change function name to extractVectorTypeFromShapedValue.

Tue, Dec 29, 12:43 AM · Restricted Project
ThomasRaoux requested review of D93890: [mlir][linalg] Add vectorization for linalg on tensor ops.
Tue, Dec 29, 12:30 AM · Restricted Project

Sat, Dec 26

ThomasRaoux added a comment to D93120: [mlir][vector] Add more vector Ops canonicalization.

@ThomasRaoux, not on a directly related note, but this file VectorOps.cpp is taking nearly 12-15s to build on a fast workstation -- directly increasing build times / critical path towards mlir-opt and other targets for everyone. It'd be great to consider refactoring among next steps.

Sat, Dec 26, 9:48 PM · Restricted Project

Wed, Dec 23

ThomasRaoux committed rG74186880ba99: [mlir][vector] Add more vector Ops canonicalization (authored by ThomasRaoux).
[mlir][vector] Add more vector Ops canonicalization
Wed, Dec 23, 11:25 AM
ThomasRaoux closed D93120: [mlir][vector] Add more vector Ops canonicalization.
Wed, Dec 23, 11:25 AM · Restricted Project

Tue, Dec 22

ThomasRaoux added a comment to D93120: [mlir][vector] Add more vector Ops canonicalization.

Thanks Aart and Mahesh

Tue, Dec 22, 4:33 PM · Restricted Project
ThomasRaoux updated the diff for D93120: [mlir][vector] Add more vector Ops canonicalization.

Address more review comments.

Tue, Dec 22, 4:32 PM · Restricted Project
ThomasRaoux added inline comments to D93120: [mlir][vector] Add more vector Ops canonicalization.
Tue, Dec 22, 10:35 AM · Restricted Project
ThomasRaoux updated the diff for D93120: [mlir][vector] Add more vector Ops canonicalization.

Address review comments.

Tue, Dec 22, 10:34 AM · Restricted Project

Mon, Dec 21

ThomasRaoux committed rG7c7b55b98513: [mlir][vector] Extend vector unroll to all element-wise ops (authored by ThomasRaoux).
[mlir][vector] Extend vector unroll to all element-wise ops
Mon, Dec 21, 1:32 PM
ThomasRaoux closed D93121: [mlir][vector] Extend vector unroll to all element-wise ops.
Mon, Dec 21, 1:32 PM · Restricted Project
ThomasRaoux added a comment to D93121: [mlir][vector] Extend vector unroll to all element-wise ops.

Thanks, Aart.

Mon, Dec 21, 1:00 PM · Restricted Project
ThomasRaoux added a comment to D93120: [mlir][vector] Add more vector Ops canonicalization.

ping, if anybody is around :)

Mon, Dec 21, 9:34 AM · Restricted Project
ThomasRaoux added a comment to D93121: [mlir][vector] Extend vector unroll to all element-wise ops.

ping, if anybody is around :)

Mon, Dec 21, 9:34 AM · Restricted Project
ThomasRaoux accepted D93535: [mlir][spirv] De-template serialization.
Mon, Dec 21, 9:20 AM · Restricted Project
ThomasRaoux accepted D93504: [mlir][spirv] De-template deserialization.
Mon, Dec 21, 9:17 AM · Restricted Project
ThomasRaoux accepted D93489: [mlir][spirv] NFC: rename SPIR-V conversion files for consistency.
Mon, Dec 21, 9:13 AM · Restricted Project
ThomasRaoux accepted D93488: [mlir][spirv] Create a pass for testing SCFToSPIRV patterns.
Mon, Dec 21, 9:09 AM · Restricted Project
ThomasRaoux accepted D93468: [mlir][spirv] Convert functions returning one value.
Mon, Dec 21, 9:01 AM · Restricted Project
ThomasRaoux committed rG26c8f9081b6b: [mlir[[vector] Extend Transfer read/write ops to support tensor types. (authored by ThomasRaoux).
[mlir[[vector] Extend Transfer read/write ops to support tensor types.
Mon, Dec 21, 8:56 AM
ThomasRaoux closed D93500: [mlir[[vector] Extend Transfer read/write ops to support tensor types..
Mon, Dec 21, 8:55 AM · Restricted Project

Sun, Dec 20

ThomasRaoux added inline comments to D93500: [mlir[[vector] Extend Transfer read/write ops to support tensor types..
Sun, Dec 20, 11:55 PM · Restricted Project
ThomasRaoux updated the diff for D93500: [mlir[[vector] Extend Transfer read/write ops to support tensor types..

Add review comments.

Sun, Dec 20, 11:53 PM · Restricted Project

Dec 17 2020

ThomasRaoux requested review of D93500: [mlir[[vector] Extend Transfer read/write ops to support tensor types..
Dec 17 2020, 4:37 PM · Restricted Project

Dec 14 2020

ThomasRaoux committed rG8955e9f6b75d: [mlir][linalg] Fix bug in elementwise vectorization (authored by ThomasRaoux).
[mlir][linalg] Fix bug in elementwise vectorization
Dec 14 2020, 10:47 AM
ThomasRaoux closed D93118: [mlir][linalg] Fix bug in elementwise vectorization.
Dec 14 2020, 10:47 AM · Restricted Project

Dec 11 2020

ThomasRaoux requested review of D93121: [mlir][vector] Extend vector unroll to all element-wise ops.
Dec 11 2020, 7:19 AM · Restricted Project
ThomasRaoux updated the diff for D93120: [mlir][vector] Add more vector Ops canonicalization.
Dec 11 2020, 7:13 AM · Restricted Project
ThomasRaoux requested review of D93120: [mlir][vector] Add more vector Ops canonicalization.
Dec 11 2020, 7:11 AM · Restricted Project
ThomasRaoux requested review of D93118: [mlir][linalg] Fix bug in elementwise vectorization.
Dec 11 2020, 7:07 AM · Restricted Project

Dec 4 2020

ThomasRaoux committed rG3e3e276d22ca: [mlir][vector][NFC] Change UnrollVectorPattern to not be statically dependent… (authored by ThomasRaoux).
[mlir][vector][NFC] Change UnrollVectorPattern to not be statically dependent…
Dec 4 2020, 9:54 AM
ThomasRaoux closed D92635: [mlir][vector][NFC] Change UnrollVectorPattern to not be statically dependent on an op type.
Dec 4 2020, 9:54 AM · Restricted Project
ThomasRaoux updated the diff for D92635: [mlir][vector][NFC] Change UnrollVectorPattern to not be statically dependent on an op type.
Dec 4 2020, 9:53 AM · Restricted Project
ThomasRaoux added inline comments to D92635: [mlir][vector][NFC] Change UnrollVectorPattern to not be statically dependent on an op type.
Dec 4 2020, 9:49 AM · Restricted Project
ThomasRaoux updated the diff for D92635: [mlir][vector][NFC] Change UnrollVectorPattern to not be statically dependent on an op type.

Address review comments.

Dec 4 2020, 9:47 AM · Restricted Project

Dec 3 2020

ThomasRaoux requested review of D92635: [mlir][vector][NFC] Change UnrollVectorPattern to not be statically dependent on an op type.
Dec 3 2020, 11:51 PM · Restricted Project
ThomasRaoux committed rGc503dc1b8a52: [mlir][linalg] Add vectorization for element-wise linalg ops (authored by ThomasRaoux).
[mlir][linalg] Add vectorization for element-wise linalg ops
Dec 3 2020, 3:32 PM
ThomasRaoux closed D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.
Dec 3 2020, 3:32 PM · Restricted Project
ThomasRaoux added a comment to D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.

Thanks a lot for your work! This will be really useful :)

I'd also like to share the credit that you kindly gave to me with fedelebron@ and agrue@.

Dec 3 2020, 3:08 PM · Restricted Project
ThomasRaoux updated the diff for D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.

Add comment and spell out vector types in test.

Dec 3 2020, 3:03 PM · Restricted Project
ThomasRaoux added inline comments to D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.
Dec 3 2020, 2:44 PM · Restricted Project
ThomasRaoux updated the diff for D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.

Fix typo

Dec 3 2020, 2:43 PM · Restricted Project
ThomasRaoux updated the diff for D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.
Dec 3 2020, 2:39 PM · Restricted Project
ThomasRaoux updated the diff for D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.

Adding todo to relax indexing map restrictions.

Dec 3 2020, 2:33 PM · Restricted Project
ThomasRaoux added inline comments to D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.
Dec 3 2020, 2:26 PM · Restricted Project
ThomasRaoux updated the diff for D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.

Use ElementwiseMappable.

Dec 3 2020, 2:17 PM · Restricted Project
ThomasRaoux added inline comments to D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.
Dec 3 2020, 11:43 AM · Restricted Project
ThomasRaoux updated the diff for D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.

Address review comments.

Dec 3 2020, 11:42 AM · Restricted Project

Dec 2 2020

ThomasRaoux updated the diff for D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.
Dec 2 2020, 9:37 PM · Restricted Project
ThomasRaoux requested review of D92540: [mlir][linalg] Add vectorization for element-wise linalg ops.
Dec 2 2020, 9:12 PM · Restricted Project

Nov 20 2020

ThomasRaoux committed rG369c51a74b53: [mlir][vector] Add transfer_op LoadToStore forwarding and deadStore… (authored by ThomasRaoux).
[mlir][vector] Add transfer_op LoadToStore forwarding and deadStore…
Nov 20 2020, 12:02 PM
ThomasRaoux closed D91321: [mlir][vector] Add transfer_op LoadToStore forwarding and deadStore optimizations.
Nov 20 2020, 12:02 PM · Restricted Project
ThomasRaoux added a comment to D91321: [mlir][vector] Add transfer_op LoadToStore forwarding and deadStore optimizations.

Thanks Aart.

Nov 20 2020, 11:31 AM · Restricted Project
ThomasRaoux updated the diff for D91321: [mlir][vector] Add transfer_op LoadToStore forwarding and deadStore optimizations.
Nov 20 2020, 11:30 AM · Restricted Project

Nov 19 2020

ThomasRaoux added inline comments to D91321: [mlir][vector] Add transfer_op LoadToStore forwarding and deadStore optimizations.
Nov 19 2020, 11:37 AM · Restricted Project
ThomasRaoux updated the diff for D91321: [mlir][vector] Add transfer_op LoadToStore forwarding and deadStore optimizations.

Address review comments

Nov 19 2020, 11:35 AM · Restricted Project

Nov 16 2020

ThomasRaoux added inline comments to D91321: [mlir][vector] Add transfer_op LoadToStore forwarding and deadStore optimizations.
Nov 16 2020, 11:00 AM · Restricted Project
ThomasRaoux updated the diff for D91321: [mlir][vector] Add transfer_op LoadToStore forwarding and deadStore optimizations.

Address review comments.

Nov 16 2020, 10:56 AM · Restricted Project

Nov 13 2020

ThomasRaoux committed rG6ad31c0f4a61: [mlir][vector] Support N-D vector in InsertMap/ExtractMap op (authored by ThomasRaoux).
[mlir][vector] Support N-D vector in InsertMap/ExtractMap op
Nov 13 2020, 12:41 PM
ThomasRaoux closed D90995: [mlir][vector] Support N-D vector in InsertMap/ExtractMap op.
Nov 13 2020, 12:40 PM · Restricted Project

Nov 12 2020

ThomasRaoux added inline comments to D90995: [mlir][vector] Support N-D vector in InsertMap/ExtractMap op.
Nov 12 2020, 10:30 AM · Restricted Project