-
merge-concepts-cxx-modules.cpp -
merge-concepts-redefinition-error.cpp
| | Event TimelineHerald added a project: Restricted Project. Herald added a project: Restricted Project. This revision is now accepted and ready to land. This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Path | Size |
---|
| | | | | | | 2 lines | | | | 2 lines | | | | | | 1 line | | | | 55 lines | | | | 46 lines | | 57 lines | | 65 lines |
Commit | Tree | Parents | Author | Summary | Date |
---|
3b5224f1a4f5 | e65787e88d27 | 0b27461e3ea2 | Ilya Biryukov | Update diagnostics per Richard's suggestions, add tests | Jul 22 2022, 9:56 AM | 0b27461e3ea2 | 2515aeb33160 | e0fb540968a6 | Ilya Biryukov | wip | Jul 21 2022, 9:33 AM | e0fb540968a6 | c2431e0ed8f3 | 93253e7d3c2f | Ilya Biryukov | Always call PushToScopeChains, since we do not call makeMergedDefinitionVisible… (Show More…) | Jul 6 2022, 10:45 AM | 93253e7d3c2f | 3f41b1a7957b | 6f59284e8f65 | Ilya Biryukov | use isReachable, do not call makeMergedDefinitionVisible | Jul 6 2022, 10:01 AM | 6f59284e8f65 | bb36351b9717 | ef9895c6d3bb | Ilya Biryukov | Add test for C++20 modules, rewrite original test with split-file | Jul 6 2022, 9:49 AM | ef9895c6d3bb | e141dda1c382 | ec098d948a27 | Ilya Biryukov | remove leftover test from previous version | Jun 30 2022, 11:30 AM | ec098d948a27 | 6f7c361cdee8 | eab13fac1355 | Ilya Biryukov | Update code to match how typedefs behave | Jun 30 2022, 11:24 AM | eab13fac1355 | 26517ba6f902 | a4b6c283e1b0 | Ilya Biryukov | [Sema] Merge C++20 concept definitions from different modules in same TU (Show More…) | Jun 30 2022, 7:16 AM |
|
Not sure if reporting the redefinition if isSameEntity returns false is the right approach here.
This leads to errors on definitions of something like:
The alternative is the "ambiguous reference" error on the use of the concept. I will check what happens for variables and typedefs in that case and follow the same pattern.