This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add cost model for reverse shuffle
ClosedPublic

Authored by reames on Jun 6 2022, 11:54 AM.

Details

Summary

The majority of the cost appears to be forming the indices vector.

This is my first costing patch, so please check for all the silly mistakes.

Diff Detail

Event Timeline

reames created this revision.Jun 6 2022, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 11:54 AM
reames requested review of this revision.Jun 6 2022, 11:54 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 11:54 AM
reames updated this revision to Diff 434566.Jun 6 2022, 12:48 PM

Had missed a test update, now included.

FYI, there was already another patch for this D125856, but it has some other things in it and I don't believe the number.

craig.topper added inline comments.Jun 7 2022, 9:21 AM
llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
197

rli -> srli?

FYI, there was already another patch for this D125856, but it has some other things in it and I don't believe the number.

As you note, that change has an assortment of things scattered in it. This one is deliberately minimal. That one can be rebased or abandoned as needed.

llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
197

Yep, typo. Will fix.

reames updated this revision to Diff 434957.Jun 7 2022, 2:28 PM

Fix comment

This revision is now accepted and ready to land.Jun 8 2022, 10:13 PM
This revision was landed with ongoing or failed builds.Jun 9 2022, 7:22 AM
This revision was automatically updated to reflect the committed changes.