Page MenuHomePhabricator
Differential D122213

[RISCV] Enable MachineOutliner by default under -Oz for RISCV
ClosedPublic
Actions

Authored by pcwang-thead on Mar 22 2022, 1:19 AM.

Details

Reviewers
lewis-revill
asb
jrtc27
craig.topper
luismarques
Commits
rG4ff5e8184c66: [RISCV] Enable MachineOutliner by default under -Oz for RISCV
Summary

Enable default outlining when the function has the minsize attribute.

addr-label.ll crashed after enabling this, so a barrier is added before
instruction selection as a workaround.

Diff Detail

Event Timeline

pcwang-thead created this revision.Mar 22 2022, 1:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 1:19 AM
Herald added subscribers: • s, VincentWu, luke957 and 27 others. · View Herald Transcript
pcwang-thead requested review of this revision.Mar 22 2022, 1:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2022, 1:19 AM
Herald added subscribers: llvm-commits, eopXD, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B155573: Diff 417207.Mar 22 2022, 2:11 AM
luismarques added a comment.Mar 28 2022, 7:43 AM

It's probably a good idea to separate the fixes from the change to the default enable.

pcwang-thead updated this revision to Diff 418784.Mar 28 2022, 10:07 PM

Separate patches.

Herald added a subscriber: sunshaoce. · View Herald TranscriptMar 28 2022, 10:07 PM
pcwang-thead edited the summary of this revision. (Show Details)Mar 28 2022, 10:16 PM
pcwang-thead added a comment.Mar 28 2022, 10:31 PM
In D122213#3411452, @luismarques wrote:

It's probably a good idea to separate the fixes from the change to the default enable.

I have separated this patch into three patches:

Harbormaster completed remote builds in B156691: Diff 418784.Mar 29 2022, 9:54 PM
pcwang-thead added a comment.Apr 5 2022, 7:58 PM

Ping.

pcwang-thead added a comment.Apr 27 2022, 10:56 PM

Ping. Is there any problem I should take care of?

luismarques accepted this revision.May 3 2022, 4:07 AM

LGTM. Thanks.

This revision is now accepted and ready to land.May 3 2022, 4:07 AM
This revision was landed with ongoing or failed builds.May 6 2022, 2:38 AM
Closed by commit rG4ff5e8184c66: [RISCV] Enable MachineOutliner by default under -Oz for RISCV (authored by pcwang-thead). · Explain Why
This revision was automatically updated to reflect the committed changes.
pcwang-thead added a commit: rG4ff5e8184c66: [RISCV] Enable MachineOutliner by default under -Oz for RISCV.

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
1 line
2 lines
5 lines
13 lines
test/
CodeGen/
RISCV/
5 lines

Diff 418784

View Options

llvm/lib/Target/RISCV/CMakeLists.txt

Loading...
View Options

llvm/lib/Target/RISCV/RISCVInstrInfo.h

Loading...
View Options

llvm/lib/Target/RISCV/RISCVInstrInfo.cpp

Loading...
View Options

llvm/lib/Target/RISCV/RISCVTargetMachine.cpp

Loading...
View Options

llvm/test/CodeGen/RISCV/O3-pipeline.ll

Loading...