This commit moves FuncOp out of the builtin dialect, and into the Func
dialect. This move has been planned in some capacity from the moment
we made FuncOp an operation (years ago). This commit handles the
functional aspects of the move, but various aspects are left untouched
to ease migration: func::FuncOp is re-exported into mlir to reduce
the actual API churn, the assembly format still accepts the unqualified
func. These temporary measures will remain for a little while to
simplify migration before being removed.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Can you rebase this patch?
mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp | ||
---|---|---|
26 | Oh that was just unused? This isn't related to this patch though right? |
Comment Actions
Note: there is still a few reference to mlir::FuncOp in the tree: most notably in the toy example:
mlir/examples/toy/Ch5/mlir/LowerToAffineLoops.cpp: auto func = rewriter.create<mlir::FuncOp>(op.getLoc(), op.getName(), mlir/examples/toy/Ch5/toyc.cpp: mlir::OpPassManager &optPM = pm.nest<mlir::FuncOp>(); mlir/examples/toy/Ch6/mlir/LowerToAffineLoops.cpp: auto func = rewriter.create<mlir::FuncOp>(op.getLoc(), op.getName(), mlir/examples/toy/Ch6/toyc.cpp: mlir::OpPassManager &optPM = pm.nest<mlir::FuncOp>(); mlir/examples/toy/Ch7/mlir/LowerToAffineLoops.cpp: auto func = rewriter.create<mlir::FuncOp>(op.getLoc(), op.getName(), mlir/examples/toy/Ch7/toyc.cpp: mlir::OpPassManager &optPM = pm.nest<mlir::FuncOp>(); mlir/lib/Dialect/Linalg/Transforms/HoistPadding.cpp: AsmState state(padOp->getParentOfType<mlir::FuncOp>()); mlir/test/lib/Dialect/Test/TestOps.td: let builders = [OpBuilder<(ins "::mlir::FuncOp":$function)>];
Comment Actions
Yeah, thanks. I haven't gotten around to actually updating the in-tree references, this commit was just the minimal set to get
everything to build after the move.
mlir/test/lib/Dialect/Affine/TestAffineDataCopy.cpp | ||
---|---|---|
26 | Yep, also good point (will remove in an NFC patch before landing this). |
Oh that was just unused? This isn't related to this patch though right?