This is an archive of the discontinued LLVM Phabricator instance.

[mlir:FunctionOpInterface] Rename the "type" attribute to "function_type"
ClosedPublic

Authored by rriddle on Mar 15 2022, 5:41 PM.

Details

Summary

This removes any potential confusion with the getType accessors
which correspond to SSA results of an operation, and makes it
clear what the intent is (i.e. to represent the type of the function).

Depends on D121267

Diff Detail

Event Timeline

rriddle created this revision.Mar 15 2022, 5:41 PM
Herald added a reviewer: ftynse. · View Herald Transcript
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a reviewer: sjarus. · View Herald Transcript
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
rriddle requested review of this revision.Mar 15 2022, 5:41 PM
mehdi_amini accepted this revision.Mar 15 2022, 6:10 PM

Nice! Thanks :)

This revision is now accepted and ready to land.Mar 15 2022, 6:10 PM