Page MenuHomePhabricator

thopre (Thomas Preud'homme)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 10:31 AM (147 w, 3 d)

Recent Activity

Tue, Sep 15

thopre added inline comments to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
Tue, Sep 15, 7:03 AM · Restricted Project

Fri, Sep 11

thopre updated the diff for D87235: Test default compare in global status page.

Fix testcase to fail without D69056 and pass with

Fri, Sep 11, 9:06 AM

Thu, Sep 10

thopre planned changes to D87235: Test default compare in global status page.

Forgot to test without the change and realized today the test still passes so it's not testing the change.

Thu, Sep 10, 2:43 AM

Mon, Sep 7

Herald added a reviewer for D85422: Prevent page crash when using default comparer on Global Status page: gkistanova.

Actually, could you try adding a testcase? There's a test for global_status in tests/server/ui/V4Pages.py

Mon, Sep 7, 7:17 AM
thopre requested review of D87235: Test default compare in global status page.
Mon, Sep 7, 7:17 AM
thopre closed D82543: [LNT][docs] Fixed docs consistency.

Landed as 53229320df0e57a7b779a3dcded72fc9e6d44e01

Mon, Sep 7, 1:19 AM
thopre closed D83620: Forwarding test size param to CMake.

Landed as 554f0722ae0daaab3abb7fd2205a9f00ce787cf0

Mon, Sep 7, 1:19 AM

Sat, Sep 5

thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Merge handleErrors in handleAllErrors below

Sat, Sep 5, 12:37 PM · Restricted Project

Thu, Sep 3

thopre added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Code mostly looks fine now, but there are still plenty of test failures being reported by the pre-merge bot. What's the situation with those currently?

Thu, Sep 3, 3:42 PM · Restricted Project

Sun, Aug 30

thopre committed rG998709b7d553: [FileCheck] Add precision to format specifier (authored by thopre).
[FileCheck] Add precision to format specifier
Sun, Aug 30, 11:41 AM
thopre closed D81667: [FileCheck] Add precision to format specifier.
Sun, Aug 30, 11:40 AM · Restricted Project

Fri, Aug 28

thopre added inline comments to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
Fri, Aug 28, 1:55 PM · Restricted Project
thopre added a comment to D81667: [FileCheck] Add precision to format specifier.

LGTM, but best wait for someone else to confirm too.

Fri, Aug 28, 4:03 AM · Restricted Project
thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Address review comments

Fri, Aug 28, 3:30 AM · Restricted Project

Tue, Aug 25

thopre committed rG70b39506a1a6: [FileCheck][docs] Fix word errors (authored by YangZhihui).
[FileCheck][docs] Fix word errors
Tue, Aug 25, 1:54 AM
thopre added a comment to D86504: Fix word errors .

Landed as 70b39506a1a68f16e4d59f998c6a099f98363964

Tue, Aug 25, 1:54 AM · Restricted Project
thopre closed D86504: Fix word errors .
Tue, Aug 25, 1:54 AM · Restricted Project
thopre added a comment to D86504: Fix word errors .

Thanks , but I don't have commit access

Tue, Aug 25, 1:44 AM · Restricted Project
thopre accepted D86504: Fix word errors .

LGTM. I believe this sort of fix can use post-commit review (i.e. can be committed straight away).

Tue, Aug 25, 1:28 AM · Restricted Project

Mon, Aug 24

thopre committed rG2c9131665d00: Test all CHECK-NOT in a block even if one fails (authored by thopre).
Test all CHECK-NOT in a block even if one fails
Mon, Aug 24, 7:45 AM
thopre closed D86315: Test all CHECK-NOT in a block even if one fails.
Mon, Aug 24, 7:45 AM · Restricted Project
thopre updated the diff for D86315: Test all CHECK-NOT in a block even if one fails.

Rebase to see if CI is now green.

Mon, Aug 24, 6:33 AM · Restricted Project
thopre added inline comments to D86315: Test all CHECK-NOT in a block even if one fails.
Mon, Aug 24, 3:16 AM · Restricted Project
thopre updated the diff for D86315: Test all CHECK-NOT in a block even if one fails.

Address review comments

Mon, Aug 24, 3:16 AM · Restricted Project

Sun, Aug 23

thopre updated the summary of D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
Sun, Aug 23, 2:45 AM · Restricted Project
thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
  • Address comments
  • Restructure
Sun, Aug 23, 2:45 AM · Restricted Project
thopre updated the diff for D86315: Test all CHECK-NOT in a block even if one fails.

Add testcase

Sun, Aug 23, 2:37 AM · Restricted Project

Aug 21 2020

thopre added a comment to D86344: [FileCheck] Move FileCheck implementation out of LLVMSupport into its own library.

A big thank you, it'll speed up incremental debug build considerably. LGTM but I'm not too well versed in the CMake aspects of making a LLVM libraries so I'll let someone else approve this change.

Aug 21 2020, 5:25 AM · Restricted Project

Aug 20 2020

thopre requested review of D86315: Test all CHECK-NOT in a block even if one fails.
Aug 20 2020, 1:12 PM · Restricted Project
thopre added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

There seems to be a number of failures like due to pattern like (taken from clang/test/CodeGen/debug-info-extern-call.c):

DECLS-FOR-EXTERN-NOT: !DICompileUnit({{.*}}retainedTypes: ![[RETTYPES:[0-9]+]]
DECLS-FOR-EXTERN-NOT: ![[RETTYPES]] = !{

I think FileCheck should forbid variable definition in a CHECK-NOT pattern. Granted with this patch we'll catch all the uses of variables defined in CHECK-NOT but we won't catch if they are not used.

I have no idea what that is even trying to do. A definition within a CHECK-NOT doesn't make sense - either the pattern will match, enabling the capture of the variable, and FileCheck to fail (because of a positive CHECK-NOT match), or it will not match, meaning the variable can't be used. In other words, I think forbidding variable definitions in CHECK-NOT makes sense. It's probably worth bringing this up on llvm-dev and cfe-dev though, to give people a head's up/ask for opinions. There may be a way this actually is useful, but if so, I don't know it.

Aug 20 2020, 6:47 AM · Restricted Project
thopre added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

There seems to be a number of failures like due to pattern like (taken from clang/test/CodeGen/debug-info-extern-call.c):

Aug 20 2020, 4:54 AM · Restricted Project
thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
  • Address review comments
  • rename PrintNoMatch to printNoMatch to satisfy clang-tidy
Aug 20 2020, 2:22 AM · Restricted Project
thopre added inline comments to D81667: [FileCheck] Add precision to format specifier.
Aug 20 2020, 1:35 AM · Restricted Project
thopre updated the diff for D81667: [FileCheck] Add precision to format specifier.

Better demonstrate precision in documentation

Aug 20 2020, 1:35 AM · Restricted Project
thopre added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

FYI: I've only looked at a couple of the testsuite failures and they are all genuine use of undefined variable. There's 59 of them in total.

Aug 20 2020, 1:31 AM · Restricted Project

Aug 19 2020

thopre planned changes to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
Aug 19 2020, 3:46 PM · Restricted Project
thopre retitled D81667: [FileCheck] Add precision to format specifier from [RFC, FileCheck] Add precision to format specifier to [FileCheck] Add precision to format specifier.
Aug 19 2020, 8:49 AM · Restricted Project
thopre requested review of D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
Aug 19 2020, 8:48 AM · Restricted Project

Aug 13 2020

thopre added inline comments to D81667: [FileCheck] Add precision to format specifier.
Aug 13 2020, 6:41 AM · Restricted Project
thopre updated the diff for D81667: [FileCheck] Add precision to format specifier.

Address all remaining review comments

Aug 13 2020, 6:41 AM · Restricted Project

Aug 11 2020

thopre added inline comments to D81667: [FileCheck] Add precision to format specifier.
Aug 11 2020, 4:23 AM · Restricted Project
thopre updated the diff for D81667: [FileCheck] Add precision to format specifier.

Add review comments

Aug 11 2020, 4:22 AM · Restricted Project
thopre added inline comments to D81667: [FileCheck] Add precision to format specifier.
Aug 11 2020, 3:40 AM · Restricted Project
thopre updated the diff for D81667: [FileCheck] Add precision to format specifier.

Address more review comments

Aug 11 2020, 3:39 AM · Restricted Project
thopre added inline comments to D81667: [FileCheck] Add precision to format specifier.
Aug 11 2020, 3:23 AM · Restricted Project
thopre updated the diff for D81667: [FileCheck] Add precision to format specifier.

Address most comments

Aug 11 2020, 3:23 AM · Restricted Project

Aug 9 2020

thopre updated the diff for D81667: [FileCheck] Add precision to format specifier.

Add example of precision in documentation

Aug 9 2020, 1:44 PM · Restricted Project

Aug 8 2020

thopre updated the diff for D81667: [FileCheck] Add precision to format specifier.

Finish implementation based on consensus reached on questions raised by the proof of concept version.

Aug 8 2020, 3:39 PM · Restricted Project

Aug 7 2020

thopre committed rG6dc863cd858f: [clang, test, Darwin] Fix tests expecting Darwin target (authored by thopre).
[clang, test, Darwin] Fix tests expecting Darwin target
Aug 7 2020, 1:21 AM
thopre closed D85367: [clang, test, Darwin] Fix tests expecting Darwin target.
Aug 7 2020, 1:21 AM · Restricted Project

Aug 6 2020

thopre added a comment to D85434: BPF: add a SimplifyCFG IR pass during generic Scalar/IPO optimization.

FYI, I've had the following linker error on an incremental error which disappear if I revert this commit:

Aug 6 2020, 3:36 PM · Restricted Project
thopre closed D85425: Generate relative URLs instead of absolute urls for weburls..

Landed as 61eaf8a9eccf4edbef18f55593d1095254ed3ff5. Selected repository is incorrect so this did not close automatically.

Aug 6 2020, 1:59 PM
thopre accepted D85425: Generate relative URLs instead of absolute urls for weburls..

I can reproduce the issue on the public LNT instance: go to https://lnt.llvm.org/db_default/v4/nts/137175 and click on MultiSource/Benchmarks/PAQ8p/paq8p in the run-over-run Change details and see the URL change to http.

Aug 6 2020, 5:28 AM
thopre requested changes to D85422: Prevent page crash when using default comparer on Global Status page.

Actually, could you try adding a testcase? There's a test for global_status in tests/server/ui/V4Pages.py

Aug 6 2020, 4:33 AM
thopre accepted D85422: Prevent page crash when using default comparer on Global Status page.

I can reproduce the issue and the patch LGTM. Thanks!

Aug 6 2020, 4:29 AM

Aug 5 2020

thopre updated subscribers of D85367: [clang, test, Darwin] Fix tests expecting Darwin target.
Aug 5 2020, 3:19 PM · Restricted Project
thopre requested review of D85367: [clang, test, Darwin] Fix tests expecting Darwin target.
Aug 5 2020, 3:16 PM · Restricted Project
thopre added a comment to D68061: [docs] Document pattern of using CHECK-SAME to skip irrelevant lines.

@rupprecht if you are still motivated to land this after so long, the only thing I see missing is to update the example from CHECK-SAME: 1{{$}} to CHECK-SAME: {{ 1$}} and then it LGTM. If not, there seems to be enough interest that someone else can land it?

Aug 5 2020, 3:06 AM · Restricted Project
thopre committed rG4963ca4658b0: [docs] Document pattern of using CHECK-SAME to skip irrelevant lines (authored by rupprecht).
[docs] Document pattern of using CHECK-SAME to skip irrelevant lines
Aug 5 2020, 3:04 AM
thopre closed D68061: [docs] Document pattern of using CHECK-SAME to skip irrelevant lines.
Aug 5 2020, 3:04 AM · Restricted Project

Jul 28 2020

thopre added inline comments to D83650: [FileCheck] Extend -dump-input with substitutions.
Jul 28 2020, 2:52 PM · Restricted Project
thopre accepted D83650: [FileCheck] Extend -dump-input with substitutions.

LGTM with the fixed FIXME.

Jul 28 2020, 1:19 PM · Restricted Project
thopre added inline comments to D83650: [FileCheck] Extend -dump-input with substitutions.
Jul 28 2020, 1:19 PM · Restricted Project

Jul 14 2020

thopre accepted D83651: [FileCheck] Report captured variables.

Removed an unused parameter from printVariableDefs.

Made unit testing of getStringValue stricter.

Added unit test for printVariableDefs. This is just a basic API test and doesn't check every aspect, such as sorting. More thorough testing appears in the FileCheck utility tests. Should we replicate all that here too? What's the general rule?

Jul 14 2020, 1:06 PM · Restricted Project
thopre added a comment to D83651: [FileCheck] Report captured variables.

Extend unit tests for changes to NumericVariable.

@thopre Is that what you meant? I didn't see a way to make this specific to @LINE.

Jul 14 2020, 7:51 AM · Restricted Project
thopre added a comment to D83651: [FileCheck] Report captured variables.

Could you add an example where getStringValue() returns None?

Sorry, I meant in the testcases. Maybe something with @LINE since you mention it.

Ah, you mean the unittests, right? I keep forgetting about those for FileCheck.

Jul 14 2020, 7:47 AM · Restricted Project
thopre added a comment to D83651: [FileCheck] Report captured variables.

Could you add an example where getStringValue() returns None?

Jul 14 2020, 7:13 AM · Restricted Project
thopre accepted D83682: [FileCheck] Add docs for --allow-empty.

LGTM too

Jul 14 2020, 7:10 AM · Restricted Project
thopre added a comment to D83682: [FileCheck] Add docs for --allow-empty.

https://lists.llvm.org/pipermail/llvm-dev/2020-July/143344.html discusses --allow-empty, but I still don't get why we need --allow-empty.

I think the idea is to prevent unexpected empty output from occurring in cases when --allow-empty is not specified. In a case where all a user cares about is that some string doesn't appear in the output, that might help make the test more robust (because they expect some output, just not what they specified), although honestly I'm not convinced, hence my proposal in the mailing list to change it to --expect-empty.

Jul 14 2020, 1:25 AM · Restricted Project
thopre added a comment to D83682: [FileCheck] Add docs for --allow-empty.

https://lists.llvm.org/pipermail/llvm-dev/2020-July/143344.html discusses --allow-empty, but I still don't get why we need --allow-empty.

Jul 14 2020, 1:22 AM · Restricted Project
thopre added a comment to D83651: [FileCheck] Report captured variables.

Could you add an example where getStringValue() returns None?

Jul 14 2020, 1:11 AM · Restricted Project
thopre added inline comments to rG6c67ee0f5832: [MC] Fix PR45805: infinite recursion in assembler.
Jul 14 2020, 12:58 AM

Jul 13 2020

thopre added inline comments to rG6c67ee0f5832: [MC] Fix PR45805: infinite recursion in assembler.
Jul 13 2020, 2:11 AM
thopre added inline comments to D83651: [FileCheck] Report captured variables.
Jul 13 2020, 2:09 AM · Restricted Project
thopre accepted D83620: Forwarding test size param to CMake.

LGTM, thanks

Jul 13 2020, 1:38 AM

Jun 30 2020

thopre accepted D82543: [LNT][docs] Fixed docs consistency.

LGTM once you've updated the description to mention you've removed shell sign only when there's no output.

Jun 30 2020, 9:14 AM

Jun 26 2020

thopre accepted D82658: [FileCheck][NFC] Clean up RUN style in verbose.txt test.

LGTM

Jun 26 2020, 8:10 AM · Restricted Project
thopre accepted D82601: [FileCheck] Permit multiple -v or -vv.

LGTM, thanks. Strange to have the pipe at the end but if that's the agreed upon practice so be it.

Jun 26 2020, 8:10 AM · Restricted Project
thopre added a comment to D82601: [FileCheck] Permit multiple -v or -vv.

LGTM with James' suggestion

Jun 26 2020, 7:03 AM · Restricted Project
thopre added a comment to D82543: [LNT][docs] Fixed docs consistency.

Yes, there are more than 20 cases of using command without a prompt sign. It's much more than the ones that used. Do you suppose it's better to convert them all?

Jun 26 2020, 7:03 AM

Jun 25 2020

thopre added a comment to D82543: [LNT][docs] Fixed docs consistency.
  • [LNT][docs] docs consistency fix
Jun 25 2020, 11:20 AM
thopre added inline comments to D82543: [LNT][docs] Fixed docs consistency.
Jun 25 2020, 9:40 AM
thopre committed rG6c67ee0f5832: [MC] Fix PR45805: infinite recursion in assembler (authored by thopre).
[MC] Fix PR45805: infinite recursion in assembler
Jun 25 2020, 8:01 AM
thopre closed D79570: [MC] Fix PR45805: infinite recursion in assembler.
Jun 25 2020, 8:01 AM · Restricted Project
thopre updated the diff for D79570: [MC] Fix PR45805: infinite recursion in assembler.

Address review comment

Jun 25 2020, 8:00 AM · Restricted Project

Jun 24 2020

thopre added a comment to D79570: [MC] Fix PR45805: infinite recursion in assembler.

Ping? Can anyone with MC experience review this? Am I missing someone as reviewer?

I'll try to get to this today.

Ping @echristo ?

Jun 24 2020, 10:47 AM · Restricted Project

Jun 23 2020

thopre committed rG8ca7d2a1ee96: [unittest, ADT] Add unit tests for itostr & utostr (authored by thopre).
[unittest, ADT] Add unit tests for itostr & utostr
Jun 23 2020, 6:54 AM
thopre closed D82300: [unittest, ADT] Add unit tests for itostr & utostr.
Jun 23 2020, 6:54 AM · Restricted Project
thopre updated the diff for D82300: [unittest, ADT] Add unit tests for itostr & utostr.

Use std::to_string to test API for big values

Jun 23 2020, 6:21 AM · Restricted Project
thopre added inline comments to D82300: [unittest, ADT] Add unit tests for itostr & utostr.
Jun 23 2020, 6:21 AM · Restricted Project

Jun 22 2020

thopre added inline comments to D82300: [unittest, ADT] Add unit tests for itostr & utostr.
Jun 22 2020, 7:30 AM · Restricted Project
thopre created D82300: [unittest, ADT] Add unit tests for itostr & utostr.
Jun 22 2020, 7:30 AM · Restricted Project
thopre added a comment to D82200: [ADT] Fix itostr handling of min int64_t value.

Shouldn't there be some unit testing for this? It seems like a better testing method than relying on an UBSan build bot failure that might not manifest again in the future if some other testing were changed.

Jun 22 2020, 6:24 AM · Restricted Project

Jun 19 2020

thopre committed rGf3e8f9617365: [ADT] Fix itostr handling of min int64_t value (authored by thopre).
[ADT] Fix itostr handling of min int64_t value
Jun 19 2020, 10:54 AM
thopre committed rG416be2255e62: Reland [FileCheck, unittest] Improve readability of ExpressionFormat (authored by thopre).
Reland [FileCheck, unittest] Improve readability of ExpressionFormat
Jun 19 2020, 10:54 AM
thopre closed D82200: [ADT] Fix itostr handling of min int64_t value.
Jun 19 2020, 10:53 AM · Restricted Project
thopre created D82200: [ADT] Fix itostr handling of min int64_t value.
Jun 19 2020, 8:38 AM · Restricted Project
thopre committed rGa3adfb400ef7: Revert "[FileCheck, unittest] Improve readability of ExpressionFormat" (authored by thopre).
Revert "[FileCheck, unittest] Improve readability of ExpressionFormat"
Jun 19 2020, 8:08 AM
thopre added a reverting change for rGcd2553de77f2: [FileCheck, unittest] Improve readability of ExpressionFormat: rGa3adfb400ef7: Revert "[FileCheck, unittest] Improve readability of ExpressionFormat".
Jun 19 2020, 8:07 AM
thopre committed rGcd2553de77f2: [FileCheck, unittest] Improve readability of ExpressionFormat (authored by thopre).
[FileCheck, unittest] Improve readability of ExpressionFormat
Jun 19 2020, 7:00 AM