- User Since
- Nov 22 2017, 10:31 AM (147 w, 3 d)
Tue, Sep 15
Fri, Sep 11
Fix testcase to fail without D69056 and pass with
Thu, Sep 10
Forgot to test without the change and realized today the test still passes so it's not testing the change.
Mon, Sep 7
Landed as 53229320df0e57a7b779a3dcded72fc9e6d44e01
Landed as 554f0722ae0daaab3abb7fd2205a9f00ce787cf0
Sat, Sep 5
Merge handleErrors in handleAllErrors below
Thu, Sep 3
Sun, Aug 30
Fri, Aug 28
Address review comments
Tue, Aug 25
Landed as 70b39506a1a68f16e4d59f998c6a099f98363964
LGTM. I believe this sort of fix can use post-commit review (i.e. can be committed straight away).
Mon, Aug 24
Rebase to see if CI is now green.
Address review comments
Sun, Aug 23
- Address comments
Aug 21 2020
A big thank you, it'll speed up incremental debug build considerably. LGTM but I'm not too well versed in the CMake aspects of making a LLVM libraries so I'll let someone else approve this change.
Aug 20 2020
There seems to be a number of failures like due to pattern like (taken from clang/test/CodeGen/debug-info-extern-call.c):
- Address review comments
- rename PrintNoMatch to printNoMatch to satisfy clang-tidy
Better demonstrate precision in documentation
FYI: I've only looked at a couple of the testsuite failures and they are all genuine use of undefined variable. There's 59 of them in total.
Aug 19 2020
Aug 13 2020
Address all remaining review comments
Aug 11 2020
Add review comments
Address more review comments
Address most comments
Aug 9 2020
Add example of precision in documentation
Aug 8 2020
Finish implementation based on consensus reached on questions raised by the proof of concept version.
Aug 7 2020
Aug 6 2020
FYI, I've had the following linker error on an incremental error which disappear if I revert this commit:
Landed as 61eaf8a9eccf4edbef18f55593d1095254ed3ff5. Selected repository is incorrect so this did not close automatically.
I can reproduce the issue on the public LNT instance: go to https://lnt.llvm.org/db_default/v4/nts/137175 and click on MultiSource/Benchmarks/PAQ8p/paq8p in the run-over-run Change details and see the URL change to http.
Actually, could you try adding a testcase? There's a test for global_status in tests/server/ui/V4Pages.py
I can reproduce the issue and the patch LGTM. Thanks!
Aug 5 2020
Jul 28 2020
LGTM with the fixed FIXME.
Jul 14 2020
Could you add an example where getStringValue() returns None?
Jul 13 2020
Jun 30 2020
LGTM once you've updated the description to mention you've removed shell sign only when there's no output.
Jun 26 2020
LGTM, thanks. Strange to have the pipe at the end but if that's the agreed upon practice so be it.
LGTM with James' suggestion
Jun 25 2020
Address review comment
Jun 24 2020
Jun 23 2020
Use std::to_string to test API for big values