Page MenuHomePhabricator

thopre (Thomas Preud'homme)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 10:31 AM (240 w, 5 d)

Recent Activity

May 25 2022

thopre committed rG8e757c6b500d: Fix conversion error to Expected (authored by thopre).
Fix conversion error to Expected
May 25 2022, 12:51 PM · Restricted Project
thopre closed D126402: Fix conversion error to Expected.
May 25 2022, 12:51 PM · Restricted Project, Restricted Project
thopre added a comment to D126402: Fix conversion error to Expected.

thank you!

I'm surprised the compiler didn't do this automatically

May 25 2022, 12:51 PM · Restricted Project, Restricted Project
thopre requested review of D126402: Fix conversion error to Expected.
May 25 2022, 11:41 AM · Restricted Project, Restricted Project

May 18 2022

thopre committed rG8c975eac3434: Assert on polymorphic pointer intrinsic param (authored by thopre).
Assert on polymorphic pointer intrinsic param
May 18 2022, 6:36 AM · Restricted Project, Restricted Project
thopre closed D125764: Assert on polymorphic pointer intrinsic param.
May 18 2022, 6:36 AM · Restricted Project, Restricted Project
thopre added a comment to D125764: Assert on polymorphic pointer intrinsic param.

Thanks for the explanation, I get it now. It would probably be better to enforce this directly in tablegen, but this seems like a reasonable starting point.

May 18 2022, 6:34 AM · Restricted Project, Restricted Project
thopre added a comment to D125764: Assert on polymorphic pointer intrinsic param.

Could you please share an example of a problematic intrinsic signature?

def int_colossus_ststep :
  Intrinsic<
    [LLVMPointerType<llvm_any_ty>],
    [llvm_any_ty,
     LLVMPointerType<LLVMMatchType<0>>,
     llvm_i32_ty],
    [IntrWriteMem, IntrArgMemOnly]>;

Okay, I don't think I really understand the issue you're fixing then. This kind of intrinsic declaration should work with opaque pointers. The LLVMMatchType<0> predicate inside LLVMPointerType<> should just be ignored, which is what the current code is doing (right?)

It looks like we also have some in-tree intrinsics that are using this pattern, such as int_riscv_vlm.

May 18 2022, 3:47 AM · Restricted Project, Restricted Project
thopre committed rG7e65ffaa8bb6: [test, x86] Fix spurious x86-target-features.c failure (authored by thopre).
[test, x86] Fix spurious x86-target-features.c failure
May 18 2022, 1:27 AM · Restricted Project, Restricted Project
thopre closed D125084: [test, x86] Fix spurious x86-target-features.c failure.
May 18 2022, 1:27 AM · Restricted Project, Restricted Project
thopre added inline comments to D125604: [FileCheck] Catch missspelled directives..
May 18 2022, 1:26 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 17 2022

thopre added a comment to D125764: Assert on polymorphic pointer intrinsic param.

Could you please share an example of a problematic intrinsic signature?

May 17 2022, 8:24 AM · Restricted Project, Restricted Project
thopre added inline comments to D125604: [FileCheck] Catch missspelled directives..
May 17 2022, 7:41 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
thopre updated the diff for D125084: [test, x86] Fix spurious x86-target-features.c failure.

Be more conservative in what we reject

May 17 2022, 6:38 AM · Restricted Project, Restricted Project
thopre updated the diff for D125764: Assert on polymorphic pointer intrinsic param.

Exclude match arguments

May 17 2022, 6:36 AM · Restricted Project, Restricted Project
thopre planned changes to D125764: Assert on polymorphic pointer intrinsic param.

Genuine test failure on CodeGenOpenCL/builtins-fp-atomics-gfx1030.cl

May 17 2022, 5:21 AM · Restricted Project, Restricted Project
thopre added a comment to D125084: [test, x86] Fix spurious x86-target-features.c failure.

Ping?

May 17 2022, 4:04 AM · Restricted Project, Restricted Project
thopre requested review of D125764: Assert on polymorphic pointer intrinsic param.
May 17 2022, 4:03 AM · Restricted Project, Restricted Project

May 16 2022

thopre added inline comments to D125604: [FileCheck] Catch missspelled directives..
May 16 2022, 4:25 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project

May 6 2022

thopre accepted D124663: LNT: Only use text segment when isSO.

LGTM with the suggested codestyle changes

May 6 2022, 2:54 AM · Restricted Project, Restricted Project
thopre requested review of D125084: [test, x86] Fix spurious x86-target-features.c failure.
May 6 2022, 1:53 AM · Restricted Project, Restricted Project

May 5 2022

thopre committed rG68dee83923c4: [MachinePipeliner] Fix unscheduled instruction (authored by thopre).
[MachinePipeliner] Fix unscheduled instruction
May 5 2022, 8:02 AM · Restricted Project, Restricted Project
thopre closed D124267: [MachinePipeliner] Fix unscheduled instruction.
May 5 2022, 8:01 AM · Restricted Project, Restricted Project
thopre updated the diff for D124267: [MachinePipeliner] Fix unscheduled instruction.
  • Rebase
  • remove changes to ignoreDependence, it should be done in a separate commit
May 5 2022, 4:29 AM · Restricted Project, Restricted Project

Apr 27 2022

thopre added inline comments to D122672: [CodeGen][ARM] Enable Swing Module Scheduling for ARM.
Apr 27 2022, 12:52 PM · Restricted Project, Restricted Project
thopre updated the diff for D124267: [MachinePipeliner] Fix unscheduled instruction.
  • Replace isArtificial check by isBoundaryNode
  • Remove call to ignoreDependence in computePath for predecessors
  • remove no longer needed changes to PowerPC tests
Apr 27 2022, 8:07 AM · Restricted Project, Restricted Project
thopre added inline comments to D122672: [CodeGen][ARM] Enable Swing Module Scheduling for ARM.
Apr 27 2022, 3:36 AM · Restricted Project, Restricted Project

Apr 25 2022

thopre added inline comments to D124267: [MachinePipeliner] Fix unscheduled instruction.
Apr 25 2022, 4:52 AM · Restricted Project, Restricted Project

Apr 22 2022

thopre added inline comments to D124267: [MachinePipeliner] Fix unscheduled instruction.
Apr 22 2022, 2:50 PM · Restricted Project, Restricted Project
thopre added a reviewer for D124267: [MachinePipeliner] Fix unscheduled instruction: jsji.

Adding @jsji to review the changes to PowerPC testcases. I've checked the MIR after the pipeliner for sms-phi-3.ll and the loop still gets pipelined (which makes sense since the modified code executes after the decision to pipeline is made) but the code gets simplified by later pass. Are you happy with the change?

Apr 22 2022, 11:39 AM · Restricted Project, Restricted Project
thopre updated the diff for D124267: [MachinePipeliner] Fix unscheduled instruction.

Adjust PowerPC testcases

Apr 22 2022, 11:35 AM · Restricted Project, Restricted Project
thopre retitled D124267: [MachinePipeliner] Fix unscheduled instruction from Fix assert failure when building poplibs to [MachinePipeliner] Fix unscheduled instruction.
Apr 22 2022, 10:33 AM · Restricted Project, Restricted Project
thopre requested review of D124267: [MachinePipeliner] Fix unscheduled instruction.
Apr 22 2022, 8:10 AM · Restricted Project, Restricted Project

Apr 21 2022

thopre added a comment to D112025: Intrinsic for checking floating point class.

LGTM but I'd prefer someone else to approve.

Apr 21 2022, 2:05 AM · Restricted Project, Restricted Project

Apr 20 2022

thopre accepted D124088: perf: Fix profile reading to correctly take segments into account..

LGTM with the following description change: very subtle bug horrible bug -> very subtle *but* horrible bug

Apr 20 2022, 6:32 AM · Restricted Project, Restricted Project
thopre added inline comments to D112025: Intrinsic for checking floating point class.
Apr 20 2022, 4:35 AM · Restricted Project, Restricted Project

Apr 6 2022

thopre committed rLNT8b2fbaf32118: Make the version check PEP440-compliant (authored by jroelofs).
Make the version check PEP440-compliant
Apr 6 2022, 1:44 PM · Restricted Project
thopre closed D123227: Make the version check PEP440-compliant.
Apr 6 2022, 1:44 PM · Restricted Project
thopre added a comment to D123227: Make the version check PEP440-compliant.
Apr 6 2022, 1:42 PM · Restricted Project
thopre added a comment to D123227: Make the version check PEP440-compliant.

Seems I don't have permissions on the repo to commit this.

Apr 6 2022, 1:29 PM · Restricted Project
thopre added a comment to D123227: Make the version check PEP440-compliant.

This showed up in one of our buildbots:

++ lnt check-no-errors lnt-submission.json
lib/python3.8/site-packages/pkg_resources/__init__.py:122: PkgResourcesDeprecationWarning: LNT 0.4.2.dev0 is an invalid version and will not be supported in a future release
  warnings.warn(
++ echo @@@@@@@
@@@@@@@
Apr 6 2022, 11:47 AM · Restricted Project
thopre added a comment to D123227: Make the version check PEP440-compliant.

Is the change about handling cases where the project name is something that would not be valid for parse_version? Could you detail the commit message a little bit to explain what is currently not compliant?

Apr 6 2022, 11:29 AM · Restricted Project

Apr 4 2022

thopre committed rG449ef2fcc667: [Pipeliner] Fix comment typo (authored by thopre).
[Pipeliner] Fix comment typo
Apr 4 2022, 8:10 AM · Restricted Project, Restricted Project

Apr 1 2022

thopre added a comment to D121266: [mlir] Move the Builtin FuncOp to the Func dialect.

Note: there is still a few reference to mlir::FuncOp in the tree: most notably in the toy example:

Apr 1 2022, 1:29 PM · Restricted Project, Restricted Project, Restricted Project

Mar 29 2022

thopre committed rGf1d8e46258c6: Clarify invariants of software pipelining hooks (authored by thopre).
Clarify invariants of software pipelining hooks
Mar 29 2022, 3:44 AM · Restricted Project, Restricted Project
thopre closed D122642: Clarify invariants of software pipelining hooks.
Mar 29 2022, 3:44 AM · Restricted Project, Restricted Project
thopre requested review of D122642: Clarify invariants of software pipelining hooks.
Mar 29 2022, 3:04 AM · Restricted Project, Restricted Project

Mar 15 2022

thopre committed rLNT4e21895ba20a: Fix flake8 failures (authored by thopre).
Fix flake8 failures
Mar 15 2022, 10:07 AM · Restricted Project
thopre closed D121679: Fix flake8 failures.
Mar 15 2022, 10:07 AM · Restricted Project
thopre committed rLNT0e3a5f745de6: [LNT] Remove Python2 support (authored by thopre).
[LNT] Remove Python2 support
Mar 15 2022, 10:03 AM · Restricted Project
thopre closed D69056: [LNT] Remove Python2 support.
Mar 15 2022, 10:03 AM · Restricted Project
thopre updated the diff for D69056: [LNT] Remove Python2 support.

Rebase

Mar 15 2022, 2:51 AM · Restricted Project
thopre requested review of D121679: Fix flake8 failures.
Mar 15 2022, 2:47 AM · Restricted Project
thopre added a comment to D69056: [LNT] Remove Python2 support.

I think this would be safe to land now. Are you still interested in landing it?

Mar 15 2022, 2:25 AM · Restricted Project

Mar 9 2022

thopre committed rG67c14d5c694d: [MachinePipeliner] Fix isPseduo typo. (authored by thopre).
[MachinePipeliner] Fix isPseduo typo.
Mar 9 2022, 7:27 AM · Restricted Project

Feb 23 2022

thopre committed rG40f908195807: [LAA] Add missing newline in debug print (authored by thopre).
[LAA] Add missing newline in debug print
Feb 23 2022, 5:25 AM

Jan 19 2022

thopre accepted D115702: [LNT] Fix profile assigning to tests.
Jan 19 2022, 1:51 AM · Restricted Project

Jan 18 2022

thopre added inline comments to D115702: [LNT] Fix profile assigning to tests.
Jan 18 2022, 7:59 AM · Restricted Project

Jan 17 2022

thopre added a comment to D117445: [lit] Expose clang search_env string as a use_clang argument.

What's the reason for not using CLANG instead of BOLT_CLANG_EXE?

I'm a bit worried about an interference with other project tests (ie when bolt and clang are enabled and tests for both are invoked). But I agree it's unlikely to be an issue in practice.

Jan 17 2022, 3:12 PM · Restricted Project
thopre added inline comments to D115702: [LNT] Fix profile assigning to tests.
Jan 17 2022, 2:29 AM · Restricted Project
thopre added a comment to D117445: [lit] Expose clang search_env string as a use_clang argument.

What's the reason for not using CLANG instead of BOLT_CLANG_EXE?

Jan 17 2022, 2:21 AM · Restricted Project

Jan 12 2022

thopre accepted D117117: [FileCheck] Allow literal '['s before "[[var...]]".
Jan 12 2022, 1:50 PM · Restricted Project
thopre added a comment to D117117: [FileCheck] Allow literal '['s before "[[var...]]".

Could you add a new testcase somewhere in llvm/test/FileCheck? Thanks!

Jan 12 2022, 7:50 AM · Restricted Project

Jan 11 2022

thopre accepted D117008: [LNT] Fixed the time extraction from MMAP and MMAP2 events using the Layout.

LGTM, thanks!

Jan 11 2022, 4:02 AM · Restricted Project
thopre accepted D117007: [LNT] NFC. Improvements to cPerf.

LGTM

Jan 11 2022, 3:55 AM · Restricted Project

Dec 14 2021

thopre accepted D115701: [LNT] Fix sidebar.

So this is to be compatible with sphinx 2.0? LGTM

Dec 14 2021, 6:42 AM · Restricted Project
thopre accepted D115700: [LNT] Fix the global_status page.

LGTM

Dec 14 2021, 6:39 AM · Restricted Project
thopre accepted D115703: [LNT] Fixed cPerf tests.

LGTM

Dec 14 2021, 6:34 AM · Restricted Project
thopre added a comment to D115703: [LNT] Fixed cPerf tests.

On what system isn't the SIGBUS caught?

Dec 14 2021, 2:02 AM · Restricted Project
thopre added a comment to D115700: [LNT] Fix the global_status page.

LGTM otherwise

Dec 14 2021, 2:01 AM · Restricted Project

Dec 10 2021

thopre added a comment to D60392: FileCheck [12/12]: Support use of var defined on same line.

Regarding the CHECK-ASSERT suggestion, do we need it? I was under the impression one of the earlier patches added a syntax like [[#VAR2, VAR1 + 3:]] or something to that effect, which achieves the same thing, right? Maybe I'm missing something though.

Dec 10 2021, 1:58 AM · Restricted Project

Dec 9 2021

thopre added a comment to D60392: FileCheck [12/12]: Support use of var defined on same line.

Hi Joel,

Dec 9 2021, 2:06 AM · Restricted Project

Nov 26 2021

thopre updated subscribers of D114641: [LNT] Remove `nm` dependency, used `objdump –t` instead.

Adding Tamar to get an Arm person to review this.

Nov 26 2021, 9:20 AM · Restricted Project

Nov 25 2021

thopre accepted D114584: [LNT] Fixed JS error caused by selecting the function with missing counters on the profile page.

LGTM, thanks!

Nov 25 2021, 5:13 AM · Restricted Project

Nov 17 2021

thopre added a comment to D112268: [LegalizeTypes][RISCV][PowerPC] Expand CTLZ/CTTZ/CTPOP instead of promoting if they'll be expanded later..

Hi @craig.topper ,

This caused a regression for us for i16 cttz with is_undef_zero true because cttz is expanded to a sequence using ctpop which loses the fact that any output is ok for the 0 case.

t17: i16 = sub t9, Constant:i16<1>
t19: i16 = xor t9, Constant:i16<-1>
t20: i16 = and t19, t17
t21: i16 = ctpop t20

So when this gets promoted, a mask is inserted to not have the result of ctpop change when t9 is 0.

t15: i32 = extract_vector_elt t2, Constant:i32<0>
t25: i32 = xor t15, Constant:i32<-1>
t23: i32 = sub t15, Constant:i32<1>
t26: i32 = and t25, t23
t28: i32 = and t26, Constant:i32<65535>
t29: i32 = ctpop t28

Prior to this patch, we'd get:

t19: i32 = sub t15, Constant:i32<1>
t21: i32 = xor t15, Constant:i32<-1>
t22: i32 = and t21, t19
t23: i32 = ctpop t22

I thought about inserting some llvm.assume saying the value is non zero when expanding but those work at IR level. Any pointer on how to solve this? Best regards.

I take it i32 ctpop is legal for your target or the i16 ctpop would have gotten expanded too?

Correct.

I just pushed d78fdf111dda26307e88d16f5f5d1411f3bd7e61 can you let me know if that fixes the issue?

Nov 17 2021, 3:36 PM · Restricted Project
thopre added a comment to D112268: [LegalizeTypes][RISCV][PowerPC] Expand CTLZ/CTTZ/CTPOP instead of promoting if they'll be expanded later..

Hi @craig.topper ,

This caused a regression for us for i16 cttz with is_undef_zero true because cttz is expanded to a sequence using ctpop which loses the fact that any output is ok for the 0 case.

t17: i16 = sub t9, Constant:i16<1>
t19: i16 = xor t9, Constant:i16<-1>
t20: i16 = and t19, t17
t21: i16 = ctpop t20

So when this gets promoted, a mask is inserted to not have the result of ctpop change when t9 is 0.

t15: i32 = extract_vector_elt t2, Constant:i32<0>
t25: i32 = xor t15, Constant:i32<-1>
t23: i32 = sub t15, Constant:i32<1>
t26: i32 = and t25, t23
t28: i32 = and t26, Constant:i32<65535>
t29: i32 = ctpop t28

Prior to this patch, we'd get:

t19: i32 = sub t15, Constant:i32<1>
t21: i32 = xor t15, Constant:i32<-1>
t22: i32 = and t21, t19
t23: i32 = ctpop t22

I thought about inserting some llvm.assume saying the value is non zero when expanding but those work at IR level. Any pointer on how to solve this? Best regards.

I take it i32 ctpop is legal for your target or the i16 ctpop would have gotten expanded too?

Nov 17 2021, 3:27 PM · Restricted Project
thopre accepted D114098: Use BinaryCacheRoot calling IsSharedObject() .

LGTM

Nov 17 2021, 8:53 AM · Restricted Project
thopre added a comment to D112268: [LegalizeTypes][RISCV][PowerPC] Expand CTLZ/CTTZ/CTPOP instead of promoting if they'll be expanded later..

This caused a regression for us for i16 cttz with is_undef_zero true because cttz is expanded to a sequence using ctpop which loses the fact that any output is ok for the 0 case.

Nov 17 2021, 7:59 AM · Restricted Project

Nov 16 2021

thopre added inline comments to D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf).
Nov 16 2021, 8:01 AM · Restricted Project

Nov 15 2021

thopre accepted D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf).

LGTM

Nov 15 2021, 7:28 AM · Restricted Project

Nov 13 2021

thopre accepted D113648: Respect pgoff and rely on it for all types of binaries.

LGTM

Nov 13 2021, 2:20 PM · Restricted Project

Nov 12 2021

thopre added inline comments to D113648: Respect pgoff and rely on it for all types of binaries.
Nov 12 2021, 5:28 AM · Restricted Project

Nov 9 2021

thopre committed rLNT0a7b38c68330: Allow setting auth_token at 1st container startup (authored by thopre).
Allow setting auth_token at 1st container startup
Nov 9 2021, 3:13 PM
thopre closed D113470: Allow setting auth_token at 1st container startup.
Nov 9 2021, 3:13 PM
thopre added a comment to D113470: Allow setting auth_token at 1st container startup.

Yes this works fine and doesn't interfere with our approach.

We took a different route here in that we COPY the lnt.cfg from outside the container into it to /etc/lnt-new.cfg and then restore it after the create command
but before the exec.

We do this since there are other settings we want to preserve, such as mail server settings etc.

Sounds like create-config should be modified to honor an existing config file so that you could just use a ADD in your Dockerfile

Yeah, I think that's the best long term approach, but doesn't need to block your change here though.

Nov 9 2021, 3:25 AM
thopre added a comment to D113470: Allow setting auth_token at 1st container startup.

Yes this works fine and doesn't interfere with our approach.

We took a different route here in that we COPY the lnt.cfg from outside the container into it to /etc/lnt-new.cfg and then restore it after the create command
but before the exec.

We do this since there are other settings we want to preserve, such as mail server settings etc.

Nov 9 2021, 3:09 AM
thopre requested review of D113470: Allow setting auth_token at 1st container startup.
Nov 9 2021, 1:59 AM

Nov 8 2021

thopre added inline comments to D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf).
Nov 8 2021, 1:53 AM · Restricted Project

Nov 3 2021

thopre added inline comments to D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf).
Nov 3 2021, 8:29 AM · Restricted Project

Oct 29 2021

thopre accepted D112782: [LNT] Fixed possible crash or junk data in cPerf.

LGTM

Oct 29 2021, 2:27 AM · Restricted Project

Oct 28 2021

thopre committed rLNT28b6eb35d301: Disable mypy cache (authored by thopre).
Disable mypy cache
Oct 28 2021, 7:35 AM
thopre closed D95033: Disable mypy cache.
Oct 28 2021, 7:35 AM
thopre added a comment to D111289: [LNT] Refactored the Graph page to use the library plotly instead of jQuery.flot.

Updated patch after landing https://reviews.llvm.org/D112607 and https://reviews.llvm.org/D112525

P.S.: dear reviewers, please do not commit this patch without mentioning me as an author, because it may raise some legal questions from my company )

Oct 28 2021, 6:37 AM · Restricted Project
thopre committed rLNT9a0d67c5a79d: [LNT] Refactored plot_parameters (authored by kpdev42).
[LNT] Refactored plot_parameters
Oct 28 2021, 5:49 AM
thopre added a comment to D112607: [LNT] Refactored plot_parameters.

LGTM with the proposed changes. I'll land it for you with them.

Please check, thank you

Oct 28 2021, 4:56 AM · Restricted Project
thopre committed rLNT005394764e2c: [LNT] Refactored plot_parameters (authored by thopre).
[LNT] Refactored plot_parameters
Oct 28 2021, 2:39 AM
thopre closed D112607: [LNT] Refactored plot_parameters.
Oct 28 2021, 2:39 AM · Restricted Project
thopre accepted D112607: [LNT] Refactored plot_parameters.

LGTM with the proposed changes. I'll land it for you with them.

Oct 28 2021, 2:39 AM · Restricted Project
thopre added inline comments to D112607: [LNT] Refactored plot_parameters.
Oct 28 2021, 2:38 AM · Restricted Project
thopre added inline comments to D112607: [LNT] Refactored plot_parameters.
Oct 28 2021, 2:20 AM · Restricted Project