Page MenuHomePhabricator

thopre (Thomas Preud'homme)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 10:31 AM (77 w, 3 d)

Recent Activity

Fri, May 17

thopre added a comment to D60386: FileCheck [6/12]: Introduce numeric variable definition.

There's still some inconsistency in the terminology, as clearly evidenced by the name and description of the IsNumExpr member of FileCheckPatternSubstitution. That class used to be where we'd find variables (now called pattern variables); but it has had numeric expressions crammed into it, except the comment wants to call it a substitution, and so we have "pattern" and "substitution" and "expression" all competing for clarity.

I'm uncertain what to suggest. It may be that "pattern variable" was not a great name, and instead it should be "string variable" to contrast more naturally with "numeric variable." And then substitutions are just substitutions, which can be either a string substitution or a numeric substitution, with the numeric substitution implicitly using a numeric expression. Following this idea, FileCheckPatternSubstitution would be renamed FileCheckSubstitution and the references to "numeric expression" within the class don't change. I don't know that I'd go so far as to have String and Numeric subclasses of FileCheckSubstitution, the abstraction of a Substitution might not really support that. But the naming can surely be improved.

Fri, May 17, 2:02 AM · Restricted Project

Wed, May 15

thopre committed rG5c15dbafb9da: [FileCheck] Fix sphinx error: Make input be gas block (authored by thopre).
[FileCheck] Fix sphinx error: Make input be gas block
Wed, May 15, 8:19 AM
thopre committed rL360781: [FileCheck] Fix sphinx error: Make input be gas block.
[FileCheck] Fix sphinx error: Make input be gas block
Wed, May 15, 8:18 AM
thopre closed D61893: [FileCheck] Fix sphinx error: make input be gas block.
Wed, May 15, 8:18 AM · Restricted Project
thopre retitled D61893: [FileCheck] Fix sphinx error: make input be gas block from [FileCheck] Fix sphinx error: make input be text block to [FileCheck] Fix sphinx error: make input be gas block.
Wed, May 15, 6:47 AM · Restricted Project
thopre updated the diff for D61893: [FileCheck] Fix sphinx error: make input be gas block.

Use gas block instead of text

Wed, May 15, 6:47 AM · Restricted Project
thopre updated the diff for D60386: FileCheck [6/12]: Introduce numeric variable definition.

Address review comments, in particular:

Wed, May 15, 4:46 AM · Restricted Project
thopre added inline comments to D60386: FileCheck [6/12]: Introduce numeric variable definition.
Wed, May 15, 4:46 AM · Restricted Project

Tue, May 14

thopre added inline comments to D60386: FileCheck [6/12]: Introduce numeric variable definition.
Tue, May 14, 10:40 AM · Restricted Project
thopre updated the diff for D60386: FileCheck [6/12]: Introduce numeric variable definition.
  • Address review comments
  • Add final point for all comments in numeric-expression.txt
Tue, May 14, 10:40 AM · Restricted Project
thopre added inline comments to D61893: [FileCheck] Fix sphinx error: make input be gas block.
Tue, May 14, 7:13 AM · Restricted Project
thopre added a comment to D61893: [FileCheck] Fix sphinx error: make input be gas block.

I'm not sure I follow what this achieves. https://llvm.org/docs/CommandGuide/FileCheck.html looks okay to me.... I see the build bot failure. Can you point at documentation that indicates what the problem is?

Tue, May 14, 6:44 AM · Restricted Project
thopre created D61893: [FileCheck] Fix sphinx error: make input be gas block.
Tue, May 14, 6:08 AM · Restricted Project
thopre retitled D61893: [FileCheck] Fix sphinx error: make input be gas block from Make input be text block to [FileCheck] Fix sphinx error: make input be text block.
Tue, May 14, 6:08 AM · Restricted Project
thopre committed rG7b4ecdd3c2c6: Reinstate "FileCheck [5/12]: Introduce regular numeric variables" (authored by thopre).
Reinstate "FileCheck [5/12]: Introduce regular numeric variables"
Tue, May 14, 4:58 AM
thopre committed rL360665: Reinstate "FileCheck [5/12]: Introduce regular numeric variables".
Reinstate "FileCheck [5/12]: Introduce regular numeric variables"
Tue, May 14, 4:58 AM
thopre closed D60385: FileCheck [5/12]: Introduce regular numeric variables.
Tue, May 14, 4:57 AM · Restricted Project
thopre added a comment to D60385: FileCheck [5/12]: Introduce regular numeric variables.

Unfortunately, the /new link for me isn't working for this. Could you point out what has changed since your previous version?

Tue, May 14, 4:38 AM · Restricted Project
thopre updated the diff for D60392: FileCheck [12/12]: Support use of var defined on same line.

Rebase on top of latest changes

Tue, May 14, 4:10 AM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase on top of latest changes

Tue, May 14, 4:10 AM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase on top of latest changes

Tue, May 14, 4:03 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Rebase on top of latest changes

Tue, May 14, 4:00 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Rebase on top of latest changes

Tue, May 14, 3:53 AM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Rebase on top of latest changes

Tue, May 14, 3:44 AM · Restricted Project
thopre added inline comments to D60386: FileCheck [6/12]: Introduce numeric variable definition.
Tue, May 14, 3:34 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.

Undo latest submission

Tue, May 14, 3:34 AM · Restricted Project
thopre updated the diff for D60386: FileCheck [6/12]: Introduce numeric variable definition.
  • Address Paul's review comments
  • Rename numeric expression subsitution for numeric substitution to clearly distinguish numeric expression (the part that gets evaluated) from the whole #<something> that gets substituted (which might include a numeric variable definition)
  • Rename ParsePattern into parsePattern since it is modified
Tue, May 14, 3:34 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.
  • Address Paul's review comments
  • Rename numeric expression subsitution for numeric substitution to clearly distinguish numeric expression (the part that gets evaluated) from the whole #<something> that gets substituted (which might include a numeric variable definition).
  • Rename ParsePattern into parsePattern since it is modified
Tue, May 14, 3:21 AM · Restricted Project
thopre requested review of D60385: FileCheck [5/12]: Introduce regular numeric variables.
Tue, May 14, 3:08 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.

Really submit fix for list in FileCheck.rst

Tue, May 14, 3:07 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.

Fix list in FileCheck.rst

Tue, May 14, 2:31 AM · Restricted Project
thopre reopened D60385: FileCheck [5/12]: Introduce regular numeric variables.

Reopen to easily review changes to fix FileCheck.rst build failure

Tue, May 14, 2:31 AM · Restricted Project
thopre committed rG004393681c25: Revert "FileCheck [5/12]: Introduce regular numeric variables" (authored by thopre).
Revert "FileCheck [5/12]: Introduce regular numeric variables"
Tue, May 14, 1:41 AM
thopre committed rL360653: Revert "FileCheck [5/12]: Introduce regular numeric variables".
Revert "FileCheck [5/12]: Introduce regular numeric variables"
Tue, May 14, 1:40 AM

Mon, May 13

thopre added a comment to D60385: FileCheck [5/12]: Introduce regular numeric variables.

Okay, LGTM, but make sure @probinson is happy at least.

He wrote "I am pretty happy with this now, maybe give the other people who have been participating a day or so to chime in again" earlier so will commit this now. Thanks everyone who has tirelessly reviewed this patch! It's good to get the first big patch adding support for numeric expression landing.

FYI I've noticed the sphinx error in [1] and am investigated it. I changed laptop recently and sphinx build was not enabled on the new one which is why I missed it. Am doing a build now with sphinx enabled and will send a patch as soon as I can reproduce the issue.

[1] http://lab.llvm.org:8011/builders/llvm-sphinx-docs/builds/31133/steps/docs-llvm-html/logs/stdio

Mon, May 13, 9:10 AM · Restricted Project
thopre added a comment to D60385: FileCheck [5/12]: Introduce regular numeric variables.

Okay, LGTM, but make sure @probinson is happy at least.

He wrote "I am pretty happy with this now, maybe give the other people who have been participating a day or so to chime in again" earlier so will commit this now. Thanks everyone who has tirelessly reviewed this patch! It's good to get the first big patch adding support for numeric expression landing.

Mon, May 13, 6:18 AM · Restricted Project
thopre committed rGe47362c1ec1e: FileCheck [5/12]: Introduce regular numeric variables (authored by thopre).
FileCheck [5/12]: Introduce regular numeric variables
Mon, May 13, 5:40 AM
thopre committed rL360578: FileCheck [5/12]: Introduce regular numeric variables.
FileCheck [5/12]: Introduce regular numeric variables
Mon, May 13, 5:37 AM
thopre closed D60385: FileCheck [5/12]: Introduce regular numeric variables.
Mon, May 13, 5:36 AM · Restricted Project
thopre added a comment to D60385: FileCheck [5/12]: Introduce regular numeric variables.

Okay, LGTM, but make sure @probinson is happy at least.

Mon, May 13, 4:30 AM · Restricted Project
thopre updated the diff for D60392: FileCheck [12/12]: Support use of var defined on same line.

Rebase on top of latest changes

Mon, May 13, 4:01 AM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase on top of latest changes

Mon, May 13, 4:01 AM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase on top of latest changes

Mon, May 13, 4:01 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Rebase on top of latest changes

Mon, May 13, 4:01 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Rebase on top of latest changes

Mon, May 13, 4:01 AM · Restricted Project
thopre updated the diff for D60386: FileCheck [6/12]: Introduce numeric variable definition.

Rebase on top of latest changes

Mon, May 13, 4:01 AM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Rebase on top of latest changes

Mon, May 13, 4:01 AM · Restricted Project
thopre added inline comments to D60385: FileCheck [5/12]: Introduce regular numeric variables.
Mon, May 13, 3:44 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.

Address outstanding review comments

Mon, May 13, 3:44 AM · Restricted Project

Sat, May 11

thopre updated the diff for D60392: FileCheck [12/12]: Support use of var defined on same line.

Rebase on top of latest changes

Sat, May 11, 7:18 AM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase on top of latest changes

Sat, May 11, 7:17 AM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase on top of latest changes

Sat, May 11, 7:17 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Rebase on top of latest changes

Sat, May 11, 7:17 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Rebase on top of latest changes

Sat, May 11, 7:17 AM · Restricted Project
thopre updated the diff for D60386: FileCheck [6/12]: Introduce numeric variable definition.

Rebase on top of latest changes

Sat, May 11, 7:17 AM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Rebase on top of latest changes

Sat, May 11, 7:17 AM · Restricted Project
thopre added inline comments to D60385: FileCheck [5/12]: Introduce regular numeric variables.
Sat, May 11, 12:32 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.

Address outstanding comments

Sat, May 11, 12:08 AM · Restricted Project

Thu, May 9

thopre updated the diff for D60392: FileCheck [12/12]: Support use of var defined on same line.

Rebase on top of latest changes

Thu, May 9, 4:57 PM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase on top of latest changes

Thu, May 9, 4:55 PM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase on top of latest changes

Thu, May 9, 4:53 PM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Rebase on top of latest changes

Thu, May 9, 4:53 PM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Rebase on top of latest changes

Thu, May 9, 4:51 PM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Rebase on top of latest changes

Thu, May 9, 4:51 PM · Restricted Project
thopre updated the diff for D60386: FileCheck [6/12]: Introduce numeric variable definition.

Rebase on top of latest changes

Thu, May 9, 4:50 PM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.

Fix codestyle

Thu, May 9, 4:49 PM · Restricted Project
thopre added inline comments to D60385: FileCheck [5/12]: Introduce regular numeric variables.
Thu, May 9, 10:09 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.

Address all outstanding comments

Thu, May 9, 10:08 AM · Restricted Project
thopre added inline comments to D60385: FileCheck [5/12]: Introduce regular numeric variables.
Thu, May 9, 6:25 AM · Restricted Project

Wed, May 8

thopre committed rGe17a0d3e6489: [FileCheck, NFC] Split defines.txt in two (authored by thopre).
[FileCheck, NFC] Split defines.txt in two
Wed, May 8, 2:46 PM
thopre committed rG4a8ef1128b50: [FileCheck] Fix code style of method comments (authored by thopre).
[FileCheck] Fix code style of method comments
Wed, May 8, 2:46 PM
thopre committed rL360289: [FileCheck, NFC] Split defines.txt in two.
[FileCheck, NFC] Split defines.txt in two
Wed, May 8, 2:46 PM
thopre closed D61679: [FileCheck, NFC] Split defines.txt in two.
Wed, May 8, 2:45 PM · Restricted Project
thopre committed rL360288: [FileCheck] Fix code style of method comments.
[FileCheck] Fix code style of method comments
Wed, May 8, 2:45 PM
thopre closed D61445: [FileCheck] Fix code style of method comments.
Wed, May 8, 2:45 PM · Restricted Project
thopre updated the diff for D61445: [FileCheck] Fix code style of method comments.

Use 3rd person for all verbs in ReadCheckFile comment

Wed, May 8, 1:35 PM · Restricted Project
thopre updated the diff for D61445: [FileCheck] Fix code style of method comments.
  • Document parameters not mentioned in \p when others in the same function are mentioned
  • Only use \returns for the return value
Wed, May 8, 11:11 AM · Restricted Project
thopre requested review of D61445: [FileCheck] Fix code style of method comments.

Marking this patch as needing review to double check whether comment update in last version is intelligible and grammatically correct english

Wed, May 8, 9:33 AM · Restricted Project
thopre updated the diff for D61679: [FileCheck, NFC] Split defines.txt in two.

Fix typo in comment

Wed, May 8, 9:30 AM · Restricted Project
thopre added a comment to D61679: [FileCheck, NFC] Split defines.txt in two.

Aha. The new versions add the word "pattern" to some of the diagnostics, in pattern-defines-diagnostics.txt. That would be the functional change belonging to D60385, which means that test should not pass with an unmodified FileCheck? Please verify.

I am sure this feels like I'm being very picky, but carefully dividing up functional and non-functional reviews makes the reviewer's life much simpler.

Wed, May 8, 9:30 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.

Include update to pattern-defines-diagnostics.txt

Wed, May 8, 9:27 AM · Restricted Project
thopre updated the diff for D61679: [FileCheck, NFC] Split defines.txt in two.

Fix splitting of NFC part of defines.txt change

Wed, May 8, 9:22 AM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase on top of latest changes

Wed, May 8, 6:55 AM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase on top of latest changes

Wed, May 8, 6:55 AM · Restricted Project
thopre updated the diff for D60392: FileCheck [12/12]: Support use of var defined on same line.

Rebase on top of latest changes

Wed, May 8, 6:55 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Rebase on top of latest changes

Wed, May 8, 6:55 AM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Rebase on top of latest changes

Wed, May 8, 6:55 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Rebase on top of latest changes

Wed, May 8, 6:55 AM · Restricted Project
thopre updated the diff for D60386: FileCheck [6/12]: Introduce numeric variable definition.

Rebase on top of latest changes

Wed, May 8, 6:55 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.

Split changes to defines.txt into a separate patch

Wed, May 8, 6:55 AM · Restricted Project
thopre added a comment to D60385: FileCheck [5/12]: Introduce regular numeric variables.

I still can't tell what the functional difference is, in pattern-defines.txt. Everything else looks fine.

There is none, pattern-defines + pattern-defines-diagnostics = old defines.txt + some new comments, as per James' comments.

If there's no functional difference, it should be separated into its own NFC patch.

Wed, May 8, 6:50 AM · Restricted Project
thopre added a child revision for D61679: [FileCheck, NFC] Split defines.txt in two: D60385: FileCheck [5/12]: Introduce regular numeric variables.
Wed, May 8, 6:49 AM · Restricted Project
thopre added a parent revision for D60385: FileCheck [5/12]: Introduce regular numeric variables: D61679: [FileCheck, NFC] Split defines.txt in two.
Wed, May 8, 6:49 AM · Restricted Project
thopre created D61679: [FileCheck, NFC] Split defines.txt in two.
Wed, May 8, 6:49 AM · Restricted Project
thopre updated the diff for D60385: FileCheck [5/12]: Introduce regular numeric variables.
  • use llvm_make_unique in makeNumExpr and makeNumericVariable
  • remove semicolon prefix in tests except for comments
  • Use -- for FileCheck long options
Wed, May 8, 3:33 AM · Restricted Project

Tue, May 7

thopre updated the diff for D60392: FileCheck [12/12]: Support use of var defined on same line.

Rebase on top of latest changes

Tue, May 7, 3:33 PM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase on top of latest changes.

Tue, May 7, 3:33 PM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase on top of latest changes

Tue, May 7, 3:33 PM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Rebase on top of latest changes

Tue, May 7, 3:30 PM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Rebase on top of latest changes

Tue, May 7, 3:29 PM · Restricted Project