Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

thopre (Thomas Preud'homme)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 10:31 AM (305 w, 4 d)

Recent Activity

Aug 7 2023

thopre committed rGb743c19360a6: [FileCheck] Turn errors into assert in valueFromStringRepr() (authored by thopre).
[FileCheck] Turn errors into assert in valueFromStringRepr()
Aug 7 2023, 1:28 PM · Restricted Project, Restricted Project
thopre closed D154431: [FileCheck] Turn errors into assert in valueFromStringRepr().
Aug 7 2023, 1:28 PM · Restricted Project, Restricted Project
thopre committed rGe15e969a4fac: [FileCheck, 4/4] NFC: Stop using ExpressionValue (authored by thopre).
[FileCheck, 4/4] NFC: Stop using ExpressionValue
Aug 7 2023, 9:36 AM · Restricted Project, Restricted Project
thopre closed D154430: [FileCheck, 4/4] NFC: Stop using ExpressionValue.
Aug 7 2023, 9:36 AM · Restricted Project, Restricted Project
thopre committed rG0726cb004718: [FileCheck, 3/4] Allow AP value for numeric expressions (authored by thopre).
[FileCheck, 3/4] Allow AP value for numeric expressions
Aug 7 2023, 6:49 AM · Restricted Project, Restricted Project
thopre closed D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.
Aug 7 2023, 6:49 AM · Restricted Project, Restricted Project
thopre retitled D150880: [FileCheck, 3/4] Allow AP value for numeric expressions from [RFC, FileCheck, 3/4] Allow AP value for numeric expressions to [FileCheck, 3/4] Allow AP value for numeric expressions.
Aug 7 2023, 6:48 AM · Restricted Project, Restricted Project

Aug 4 2023

thopre added a comment to D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.

Ping?

Aug 4 2023, 3:28 AM · Restricted Project, Restricted Project

Jul 27 2023

thopre added a comment to D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.

Ping?

Jul 27 2023, 5:19 AM · Restricted Project, Restricted Project

Jul 4 2023

thopre added inline comments to D154430: [FileCheck, 4/4] NFC: Stop using ExpressionValue.
Jul 4 2023, 2:15 PM · Restricted Project, Restricted Project
thopre updated the diff for D154430: [FileCheck, 4/4] NFC: Stop using ExpressionValue.

Address review comments

Jul 4 2023, 2:15 PM · Restricted Project, Restricted Project
thopre added inline comments to D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.
Jul 4 2023, 2:07 PM · Restricted Project, Restricted Project
thopre updated the diff for D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.

Address review comments

Jul 4 2023, 2:01 PM · Restricted Project, Restricted Project
thopre committed rGfc0d1c05a04b: [FileCheck, 2/4] NFC: Switch to APInt getter for ExpressionValue (authored by thopre).
[FileCheck, 2/4] NFC: Switch to APInt getter for ExpressionValue
Jul 4 2023, 1:42 PM · Restricted Project, Restricted Project
thopre closed D154429: [FileCheck, 2/4] NFC: Switch to APInt getter for ExpressionValue.
Jul 4 2023, 1:42 PM · Restricted Project, Restricted Project
thopre committed rGcf57fcfa0256: [FileCheck, 1/4] NFC: Switch ExpressionValue to APInt (authored by thopre).
[FileCheck, 1/4] NFC: Switch ExpressionValue to APInt
Jul 4 2023, 1:39 PM · Restricted Project, Restricted Project
thopre closed D154428: [FileCheck, 1/4] NFC: Switch ExpressionValue to APInt.
Jul 4 2023, 1:39 PM · Restricted Project, Restricted Project
thopre added inline comments to D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.
Jul 4 2023, 7:51 AM · Restricted Project, Restricted Project
thopre updated the diff for D154431: [FileCheck] Turn errors into assert in valueFromStringRepr().

Simplify signature since it does not throw any error

Jul 4 2023, 7:47 AM · Restricted Project, Restricted Project
thopre requested review of D154431: [FileCheck] Turn errors into assert in valueFromStringRepr().
Jul 4 2023, 4:09 AM · Restricted Project, Restricted Project
thopre requested review of D154430: [FileCheck, 4/4] NFC: Stop using ExpressionValue.
Jul 4 2023, 4:09 AM · Restricted Project, Restricted Project
thopre retitled D150880: [FileCheck, 3/4] Allow AP value for numeric expressions from [RFC, FileCheck] Allow AP value for numeric expressions to [RFC, FileCheck, 3/4] Allow AP value for numeric expressions.
Jul 4 2023, 4:07 AM · Restricted Project, Restricted Project
thopre retitled D154429: [FileCheck, 2/4] NFC: Switch to APInt getter for ExpressionValue from NFC: Switch to APInt getter for ExpressionValue to [FileCheck, 2/4] NFC: Switch to APInt getter for ExpressionValue.
Jul 4 2023, 4:06 AM · Restricted Project, Restricted Project
thopre retitled D154428: [FileCheck, 1/4] NFC: Switch ExpressionValue to APInt from NFC: Switch ExpressionValue to APInt to [FileCheck, 1/4] NFC: Switch ExpressionValue to APInt.
Jul 4 2023, 4:05 AM · Restricted Project, Restricted Project
thopre requested review of D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.
Jul 4 2023, 4:05 AM · Restricted Project, Restricted Project
thopre added inline comments to D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.
Jul 4 2023, 4:04 AM · Restricted Project, Restricted Project
thopre updated the diff for D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.
  • Split APInt change into separate patches and only keep changes to support arbitrary precision
  • use [[maybe_unused]] instead of (void)
Jul 4 2023, 4:03 AM · Restricted Project, Restricted Project
thopre requested review of D154429: [FileCheck, 2/4] NFC: Switch to APInt getter for ExpressionValue.
Jul 4 2023, 4:01 AM · Restricted Project, Restricted Project
thopre requested review of D154428: [FileCheck, 1/4] NFC: Switch ExpressionValue to APInt.
Jul 4 2023, 4:00 AM · Restricted Project, Restricted Project

Jun 27 2023

thopre added a comment to D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.

Overall LGTM but as this is a rather large diff I may have missed something.

Jun 27 2023, 5:19 AM · Restricted Project, Restricted Project

Jun 26 2023

thopre added a comment to D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.

Ping?

Jun 26 2023, 2:35 AM · Restricted Project, Restricted Project

Jun 15 2023

thopre added a comment to D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.

Ping?

Jun 15 2023, 11:25 AM · Restricted Project, Restricted Project

May 31 2023

thopre retitled D150880: [FileCheck, 3/4] Allow AP value for numeric expressions from [RFC] Allow AP value for numeric expressions to [RFC, FileCheck] Allow AP value for numeric expressions.
May 31 2023, 3:00 AM · Restricted Project, Restricted Project
thopre added a comment to D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.

Ping?

May 31 2023, 2:41 AM · Restricted Project, Restricted Project

May 23 2023

thopre committed rGdd00421c6071: Add StringRef::consumeInteger(APInt) (authored by thopre).
Add StringRef::consumeInteger(APInt)
May 23 2023, 6:02 AM · Restricted Project, Restricted Project
thopre closed D150878: Add StringRef::consumeInteger(APInt).
May 23 2023, 6:01 AM · Restricted Project, Restricted Project
thopre committed rG13eb298d5c3c: Turn unreachable error into assert (authored by thopre).
Turn unreachable error into assert
May 23 2023, 5:52 AM · Restricted Project, Restricted Project
thopre closed D150797: Turn unreachable error into assert.
May 23 2023, 5:52 AM · Restricted Project, Restricted Project
thopre added a comment to D150878: Add StringRef::consumeInteger(APInt).

Do you need someone to commit this for you? (if so, what name & email address would you like to be used to attribute the work?)

May 23 2023, 5:30 AM · Restricted Project, Restricted Project

May 22 2023

thopre retitled D150880: [FileCheck, 3/4] Allow AP value for numeric expressions from Allow AP value for numeric expressions to [RFC] Allow AP value for numeric expressions.
May 22 2023, 9:03 AM · Restricted Project, Restricted Project
thopre added inline comments to D150797: Turn unreachable error into assert.
May 22 2023, 9:02 AM · Restricted Project, Restricted Project
thopre added a comment to D150878: Add StringRef::consumeInteger(APInt).

Remove <64 bit APInt consumeInteger tests

May 22 2023, 8:54 AM · Restricted Project, Restricted Project
thopre updated the diff for D150878: Add StringRef::consumeInteger(APInt).

Remove <64 bit APInt consumeInteger tests

May 22 2023, 8:51 AM · Restricted Project, Restricted Project

May 19 2023

thopre added a comment to D150879: Add control of hex casing in APInt::toString.

I would suggest a silly microoptimization:

static const char BothDigits[] = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789abcdefghijklmnopqrstuvwxyz";
const char *Digits = BothDigits+(UpperCase ? 0 : 36);

Avoids looking up two different GOT entries.

May 19 2023, 6:25 AM · Restricted Project, Restricted Project
thopre committed rGa17083403fa1: Add control of hex casing in APInt::toString (authored by thopre).
Add control of hex casing in APInt::toString
May 19 2023, 6:21 AM · Restricted Project, Restricted Project
thopre closed D150879: Add control of hex casing in APInt::toString.
May 19 2023, 6:21 AM · Restricted Project, Restricted Project
thopre added inline comments to D150797: Turn unreachable error into assert.
May 19 2023, 5:55 AM · Restricted Project, Restricted Project

May 18 2023

thopre requested review of D150880: [FileCheck, 3/4] Allow AP value for numeric expressions.
May 18 2023, 9:17 AM · Restricted Project, Restricted Project
thopre requested review of D150879: Add control of hex casing in APInt::toString.
May 18 2023, 9:13 AM · Restricted Project, Restricted Project
thopre requested review of D150878: Add StringRef::consumeInteger(APInt).
May 18 2023, 9:12 AM · Restricted Project, Restricted Project
thopre added a comment to D150797: Turn unreachable error into assert.

Given that there are unit tests, this code is in the library's public-facing API. Does removing the error check cause problems if users happen to be leveraging the FileCheck library in some manner?

May 18 2023, 1:15 AM · Restricted Project, Restricted Project

May 17 2023

thopre requested review of D150797: Turn unreachable error into assert.
May 17 2023, 9:16 AM · Restricted Project, Restricted Project

May 12 2023

thopre added inline comments to D150457: [mlir][linalg] Add a test for linalg.matmul --> vector.outerproduct.
May 12 2023, 2:18 PM · Restricted Project, Restricted Project
thopre updated subscribers of D150457: [mlir][linalg] Add a test for linalg.matmul --> vector.outerproduct.
May 12 2023, 12:46 PM · Restricted Project, Restricted Project

Mar 15 2023

thopre abandoned D143295: [bazel] Move bazel configuration to a Python script.

As mentioned, I went for a change in how tensorflow uses a local LLVM repo instead: https://github.com/tensorflow/tensorflow/commit/64a1638818af21c33280287a95ea88ea62ea9237

Mar 15 2023, 2:00 PM · Restricted Project, Restricted Project

Feb 20 2023

thopre planned changes to D143295: [bazel] Move bazel configuration to a Python script.

I supposed llvm_configure is the only public entry for users.

Feb 20 2023, 8:39 AM · Restricted Project, Restricted Project

Feb 7 2023

thopre added a comment to D143295: [bazel] Move bazel configuration to a Python script.

I'll have to agree with @chapuni though, Bazel has exceptional support for bash scripts etc, anything that could be expressed in starlark with genrules and bash scripts seems much better to me than python. E.g. overlaying/moving files is like 10x faster in bash than it is in python.

Also, removing the python dependency would potentially make the build much more portable. I don't think this commit would be the right place to do this and I understand that pytorch/tensorflow devs may prefer using python in general.

However, I think the current functionality of the script is not something where python is actually needed. I'm not sure where else we'd need python for the LLVM build, but I'd say that requiring a rather large python dependency in every CI image is not very economical when we already have starlark and bash.

Feb 7 2023, 1:53 PM · Restricted Project, Restricted Project
thopre added a comment to D143295: [bazel] Move bazel configuration to a Python script.

Excuse me, I am not a fan of it.
Could you remain vars.bzl stuff, unless python would have interest to vars?

I am planning for vars.bzl to give configurations to build rules (and repository rules).

Feb 7 2023, 7:29 AM · Restricted Project, Restricted Project
thopre updated the diff for D143295: [bazel] Move bazel configuration to a Python script.
  • Address black's linting errors
  • Call overlay code in overlay_directories directly instead of using a subprocess
Feb 7 2023, 5:09 AM · Restricted Project, Restricted Project

Feb 3 2023

thopre requested review of D143295: [bazel] Move bazel configuration to a Python script.
Feb 3 2023, 2:06 PM · Restricted Project, Restricted Project

Jan 27 2023

thopre committed rGbfedf169f426: [MLIR] Fix tensor shapes in Toy chapter 1 (authored by thopre).
[MLIR] Fix tensor shapes in Toy chapter 1
Jan 27 2023, 2:09 AM · Restricted Project, Restricted Project
thopre closed D142622: [MLIR] Fix tensor shapes in Toy chapter 1.
Jan 27 2023, 2:09 AM · Restricted Project, Restricted Project

Jan 26 2023

thopre abandoned D60392: FileCheck [12/12]: Support use of var defined on same line.
Jan 26 2023, 5:59 AM · Restricted Project, Restricted Project
thopre retitled D142622: [MLIR] Fix tensor shapes in Toy chapter 1 from Fix tensor shapes in Toy chapter 1 to [MLIR] Fix tensor shapes in Toy chapter 1.
Jan 26 2023, 5:54 AM · Restricted Project, Restricted Project
thopre requested review of D142622: [MLIR] Fix tensor shapes in Toy chapter 1.
Jan 26 2023, 5:51 AM · Restricted Project, Restricted Project

Dec 15 2022

thopre added inline comments to D136463: [SWP] Recognize mem carried dep with different base.
Dec 15 2022, 2:03 PM · Restricted Project, Restricted Project
thopre requested review of D140168: Do not mark non-phi loop var def as loop-carried dep.
Dec 15 2022, 2:02 PM · Restricted Project, Restricted Project

Dec 5 2022

thopre added a comment to D139355: [Flang] Restore Flang cmake configuration data.

Oops sorry, I'm not sure how it happened. I thought I copy/pasted new code only.

Dec 5 2022, 1:29 PM · Restricted Project, Restricted Project

Nov 25 2022

thopre committed rGecfa2d3d9943: Add version to all LLVM cmake package (authored by thopre).
Add version to all LLVM cmake package
Nov 25 2022, 1:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thopre closed D138274: Add version to all LLVM cmake package.
Nov 25 2022, 1:58 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thopre requested review of D138274: Add version to all LLVM cmake package.
Nov 25 2022, 4:31 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thopre updated the diff for D138274: Add version to all LLVM cmake package.

Use LLVM_VERSION as a CMake variable and LLVM_VERSION_* as substitutions

Nov 25 2022, 4:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thopre reopened D138274: Add version to all LLVM cmake package.
Nov 25 2022, 4:30 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thopre added a reverting change for rGad485b71b511: Add version to all LLVM cmake package: rGb62c8d396f7d: Revert: Add version to all LLVM cmake package.
Nov 25 2022, 2:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thopre committed rGb62c8d396f7d: Revert: Add version to all LLVM cmake package (authored by thopre).
Revert: Add version to all LLVM cmake package
Nov 25 2022, 2:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thopre added a reverting change for D138274: Add version to all LLVM cmake package: rGb62c8d396f7d: Revert: Add version to all LLVM cmake package.
Nov 25 2022, 2:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 20 2022

thopre committed rGad485b71b511: Add version to all LLVM cmake package (authored by thopre).
Add version to all LLVM cmake package
Nov 20 2022, 1:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
thopre closed D138274: Add version to all LLVM cmake package.
Nov 20 2022, 1:10 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 19 2022

thopre added a comment to D138274: Add version to all LLVM cmake package.

I thought we had this already. The amount of boiler plate required repeated in each component is depressing, but I wouldn't be surprised if it's really needed

Nov 19 2022, 3:38 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 18 2022

thopre requested review of D138274: Add version to all LLVM cmake package.
Nov 18 2022, 2:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 8 2022

thopre committed rGf3a86a23c10d: [Test] Fix driverkit-path.c with lib64 dir (authored by thopre).
[Test] Fix driverkit-path.c with lib64 dir
Nov 8 2022, 1:55 AM · Restricted Project, Restricted Project
thopre closed D137484: [Test] Fix driverkit-path.c with lib64 dir.
Nov 8 2022, 1:54 AM · Restricted Project, Restricted Project

Nov 7 2022

thopre committed rGc8be35293c82: [SWP] Recognize mem carried dep with different base (authored by thopre).
[SWP] Recognize mem carried dep with different base
Nov 7 2022, 1:54 AM · Restricted Project, Restricted Project
thopre closed D136463: [SWP] Recognize mem carried dep with different base.
Nov 7 2022, 1:53 AM · Restricted Project, Restricted Project

Nov 5 2022

thopre requested review of D137484: [Test] Fix driverkit-path.c with lib64 dir.
Nov 5 2022, 3:10 AM · Restricted Project, Restricted Project

Oct 31 2022

thopre added inline comments to D136463: [SWP] Recognize mem carried dep with different base.
Oct 31 2022, 5:33 AM · Restricted Project, Restricted Project
thopre updated the diff for D136463: [SWP] Recognize mem carried dep with different base.

Rewrite CHECK lines

Oct 31 2022, 5:33 AM · Restricted Project, Restricted Project

Oct 24 2022

thopre added inline comments to D136463: [SWP] Recognize mem carried dep with different base.
Oct 24 2022, 9:32 AM · Restricted Project, Restricted Project
thopre updated the diff for D136463: [SWP] Recognize mem carried dep with different base.

Modify tests as per suggestion and checked it shows a difference with and without diff

Oct 24 2022, 9:31 AM · Restricted Project, Restricted Project

Oct 21 2022

thopre added inline comments to D136463: [SWP] Recognize mem carried dep with different base.
Oct 21 2022, 9:47 AM · Restricted Project, Restricted Project
thopre updated the diff for D136463: [SWP] Recognize mem carried dep with different base.

Remove IR block in test

Oct 21 2022, 9:41 AM · Restricted Project, Restricted Project
thopre added a reviewer for D136463: [SWP] Recognize mem carried dep with different base: JanekvO.
Oct 21 2022, 9:37 AM · Restricted Project, Restricted Project
thopre requested review of D136463: [SWP] Recognize mem carried dep with different base.
Oct 21 2022, 9:26 AM · Restricted Project, Restricted Project

Oct 14 2022

thopre committed rG6370bc2435a8: Add f16 nearbyint support. (authored by Leonc).
Add f16 nearbyint support.
Oct 14 2022, 12:06 AM · Restricted Project, Restricted Project
thopre closed D135124: Add f16 nearbyint support..
Oct 14 2022, 12:06 AM · Restricted Project, Restricted Project

Oct 13 2022

thopre committed rG98852a0f3d47: Precommit for SWDEV-353076: Add check directives to existing tests. (authored by Leonc).
Precommit for SWDEV-353076: Add check directives to existing tests.
Oct 13 2022, 12:03 AM · Restricted Project, Restricted Project
thopre closed D135788: Precommit for SWDEV-353076: Add check directives to existing tests..
Oct 13 2022, 12:03 AM · Restricted Project, Restricted Project

Aug 6 2022

thopre committed rG6a275cd53cc9: Transform illegal intrinsics to V_ILLEGAL (authored by Leonc).
Transform illegal intrinsics to V_ILLEGAL
Aug 6 2022, 12:59 AM · Restricted Project, Restricted Project
thopre closed D123693: Transform illegal intrinsics to V_ILLEGAL.
Aug 6 2022, 12:59 AM · Restricted Project, Restricted Project

Jul 26 2022

thopre accepted D130570: [Lit] Sort previously failed tests early.

LGTM, thanks!

Jul 26 2022, 7:37 AM · Restricted Project, Restricted Project