Page MenuHomePhabricator

thopre (Thomas Preud'homme)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 10:31 AM (86 w, 4 d)

Recent Activity

Thu, Jul 18

thopre added a comment to D64923: [FileCheck]] Canonicalize caret location testing.

Readability is to some extent in the eye of the reader, so I've restrained myself to one suggestion. Otherwise this review is up to James.

Thu, Jul 18, 1:32 PM · Restricted Project
thopre added a comment to D64923: [FileCheck]] Canonicalize caret location testing.

I've reintroduced the {{$}} in end of lines because it is clear the intent was to test the whole lines in existing tests.

Thu, Jul 18, 8:35 AM · Restricted Project
thopre updated the summary of D64923: [FileCheck]] Canonicalize caret location testing.
Thu, Jul 18, 8:34 AM · Restricted Project
thopre updated the diff for D64923: [FileCheck]] Canonicalize caret location testing.

Address review comment

Thu, Jul 18, 8:33 AM · Restricted Project
thopre added a parent revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D64923: [FileCheck]] Canonicalize caret location testing.
Thu, Jul 18, 7:35 AM · Restricted Project
thopre added a child revision for D64923: [FileCheck]] Canonicalize caret location testing: D64921: [FileCheck] Use ASSERT for fatal unit tests.
Thu, Jul 18, 7:35 AM · Restricted Project
thopre edited child revisions for D60388: FileCheck [8/12]: Define numeric var from expr, added: 1; removed: 1.
Thu, Jul 18, 7:34 AM · Restricted Project
thopre removed a parent revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D60388: FileCheck [8/12]: Define numeric var from expr.
Thu, Jul 18, 7:34 AM · Restricted Project
thopre created D64923: [FileCheck]] Canonicalize caret location testing.
Thu, Jul 18, 7:34 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Address remaining review comments

Thu, Jul 18, 7:34 AM · Restricted Project
thopre added a parent revision for D60389: FileCheck [9/12]: Add support for matching formats: D64921: [FileCheck] Use ASSERT for fatal unit tests.
Thu, Jul 18, 6:47 AM · Restricted Project
thopre edited child revisions for D60388: FileCheck [8/12]: Define numeric var from expr, added: 1; removed: 1.
Thu, Jul 18, 6:47 AM · Restricted Project
thopre removed a parent revision for D60389: FileCheck [9/12]: Add support for matching formats: D60388: FileCheck [8/12]: Define numeric var from expr.
Thu, Jul 18, 6:47 AM · Restricted Project
thopre added a parent revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D60388: FileCheck [8/12]: Define numeric var from expr.
Thu, Jul 18, 6:47 AM · Restricted Project
thopre added a child revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D60389: FileCheck [9/12]: Add support for matching formats.
Thu, Jul 18, 6:47 AM · Restricted Project
thopre created D64921: [FileCheck] Use ASSERT for fatal unit tests.
Thu, Jul 18, 6:44 AM · Restricted Project
thopre committed rG70494494c1e3: [FileCheck] Fix numeric variable redefinition (authored by thopre).
[FileCheck] Fix numeric variable redefinition
Thu, Jul 18, 6:40 AM
thopre committed rL366434: [FileCheck] Fix numeric variable redefinition.
[FileCheck] Fix numeric variable redefinition
Thu, Jul 18, 6:38 AM
thopre closed D64882: [FileCheck] Fix numeric variable redefinition.
Thu, Jul 18, 6:38 AM · Restricted Project
thopre added a comment to D64882: [FileCheck] Fix numeric variable redefinition.

LGTM.

I think I'll add unit tests as well.

Thu, Jul 18, 4:51 AM · Restricted Project
thopre added a comment to D64882: [FileCheck] Fix numeric variable redefinition.

LGTM.

Thu, Jul 18, 3:58 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Fix more review comments

Thu, Jul 18, 3:30 AM · Restricted Project
thopre removed a child revision for D64639: [FileCheck] Store line numbers as optional values: D60388: FileCheck [8/12]: Define numeric var from expr.
Thu, Jul 18, 3:15 AM · Restricted Project
thopre added a child revision for D64882: [FileCheck] Fix numeric variable redefinition: D60388: FileCheck [8/12]: Define numeric var from expr.
Thu, Jul 18, 3:15 AM · Restricted Project
thopre edited parent revisions for D60388: FileCheck [8/12]: Define numeric var from expr, added: 1; removed: 1.
Thu, Jul 18, 3:15 AM · Restricted Project
thopre added inline comments to D60388: FileCheck [8/12]: Define numeric var from expr.
Thu, Jul 18, 3:15 AM · Restricted Project
thopre added a child revision for D64639: [FileCheck] Store line numbers as optional values: D64882: [FileCheck] Fix numeric variable redefinition.
Thu, Jul 18, 3:15 AM · Restricted Project
thopre added a parent revision for D64882: [FileCheck] Fix numeric variable redefinition: D64639: [FileCheck] Store line numbers as optional values.
Thu, Jul 18, 3:15 AM · Restricted Project
thopre added inline comments to D60388: FileCheck [8/12]: Define numeric var from expr.
Thu, Jul 18, 3:09 AM · Restricted Project
thopre retitled D64882: [FileCheck] Fix numeric variable redefinition from [FileCheck] Fix @LINE substitution in error msg to [FileCheck] Fix numeric variable redefinition.
Thu, Jul 18, 3:09 AM · Restricted Project
thopre updated the diff for D64882: [FileCheck] Fix numeric variable redefinition.

Pursue different approach

Thu, Jul 18, 3:07 AM · Restricted Project
thopre added a comment to D64882: [FileCheck] Fix numeric variable redefinition.

I am wondering why we don't just have setValue call clearValue first in all cases?

Thu, Jul 18, 2:19 AM · Restricted Project

Wed, Jul 17

thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.
  • Address review comments
  • rebase on top of @LINE substitution fix
Wed, Jul 17, 2:08 PM · Restricted Project
thopre created D64882: [FileCheck] Fix numeric variable redefinition.
Wed, Jul 17, 2:00 PM · Restricted Project

Tue, Jul 16

thopre added inline comments to D60388: FileCheck [8/12]: Define numeric var from expr.
Tue, Jul 16, 4:28 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Address review comments

Tue, Jul 16, 4:28 AM · Restricted Project
thopre added inline comments to D60388: FileCheck [8/12]: Define numeric var from expr.
Tue, Jul 16, 3:49 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Address review comments

Tue, Jul 16, 3:49 AM · Restricted Project

Mon, Jul 15

thopre committed rG99f2a108707e: [FileCheck] Store line numbers as optional values (authored by thopre).
[FileCheck] Store line numbers as optional values
Mon, Jul 15, 12:07 PM
thopre committed rL366109: [FileCheck] Store line numbers as optional values.
[FileCheck] Store line numbers as optional values
Mon, Jul 15, 12:06 PM
thopre closed D64639: [FileCheck] Store line numbers as optional values.
Mon, Jul 15, 12:06 PM · Restricted Project
thopre added inline comments to D64639: [FileCheck] Store line numbers as optional values.
Mon, Jul 15, 5:48 AM · Restricted Project
thopre updated the diff for D64639: [FileCheck] Store line numbers as optional values.

Address review comment

Mon, Jul 15, 5:48 AM · Restricted Project

Sat, Jul 13

thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Add more unit tests

Sat, Jul 13, 4:12 PM · Restricted Project
thopre committed rG2a7f52046029: FileCheck [7/12]: Arbitrary long numeric expressions (authored by thopre).
FileCheck [7/12]: Arbitrary long numeric expressions
Sat, Jul 13, 6:29 AM
thopre committed rL366001: FileCheck [7/12]: Arbitrary long numeric expressions.
FileCheck [7/12]: Arbitrary long numeric expressions
Sat, Jul 13, 6:28 AM
thopre closed D60387: FileCheck [7/12]: Arbitrary long numeric expressions.
Sat, Jul 13, 6:28 AM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Return structure in parseVariable as a temporary

Sat, Jul 13, 1:14 AM · Restricted Project

Fri, Jul 12

thopre added inline comments to D60387: FileCheck [7/12]: Arbitrary long numeric expressions.
Fri, Jul 12, 8:11 AM · Restricted Project
thopre added inline comments to D60387: FileCheck [7/12]: Arbitrary long numeric expressions.
Fri, Jul 12, 8:05 AM · Restricted Project
thopre added a parent revision for D64639: [FileCheck] Store line numbers as optional values: D60387: FileCheck [7/12]: Arbitrary long numeric expressions.
Fri, Jul 12, 8:01 AM · Restricted Project
thopre edited parent revisions for D60388: FileCheck [8/12]: Define numeric var from expr, added: 1; removed: 1.
Fri, Jul 12, 8:01 AM · Restricted Project
thopre added a child revision for D60387: FileCheck [7/12]: Arbitrary long numeric expressions: D64639: [FileCheck] Store line numbers as optional values.
Fri, Jul 12, 8:01 AM · Restricted Project
thopre removed a child revision for D60387: FileCheck [7/12]: Arbitrary long numeric expressions: D60388: FileCheck [8/12]: Define numeric var from expr.
Fri, Jul 12, 8:01 AM · Restricted Project
thopre added a child revision for D64639: [FileCheck] Store line numbers as optional values: D60388: FileCheck [8/12]: Define numeric var from expr.
Fri, Jul 12, 8:01 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.

Rebase on top of latest changes in patch series

Fri, Jul 12, 8:01 AM · Restricted Project
thopre created D64639: [FileCheck] Store line numbers as optional values.
Fri, Jul 12, 8:01 AM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Return a VariableProperties structure in parseVariable

Fri, Jul 12, 7:39 AM · Restricted Project
thopre added inline comments to D60387: FileCheck [7/12]: Arbitrary long numeric expressions.
Fri, Jul 12, 4:00 AM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Address review comments

Fri, Jul 12, 4:00 AM · Restricted Project

Thu, Jul 11

thopre added inline comments to D60388: FileCheck [8/12]: Define numeric var from expr.
Thu, Jul 11, 9:12 AM · Restricted Project
thopre updated the diff for D60388: FileCheck [8/12]: Define numeric var from expr.
  • Rebase on latest changes in the patch series
  • Address most comments
Thu, Jul 11, 9:12 AM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Address review comments

Thu, Jul 11, 8:54 AM · Restricted Project
thopre added inline comments to D60387: FileCheck [7/12]: Arbitrary long numeric expressions.
Thu, Jul 11, 8:53 AM · Restricted Project

Wed, Jul 10

thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Run clang-format-diff

Wed, Jul 10, 9:04 AM · Restricted Project
thopre added inline comments to D60387: FileCheck [7/12]: Arbitrary long numeric expressions.
Wed, Jul 10, 9:00 AM · Restricted Project
thopre updated the diff for D60387: FileCheck [7/12]: Arbitrary long numeric expressions.

Address review comments.

Wed, Jul 10, 9:00 AM · Restricted Project
thopre committed rGf64b7f63828c: [FileCheck] Use bool operator to test Expected (authored by thopre).
[FileCheck] Use bool operator to test Expected
Wed, Jul 10, 8:32 AM
thopre committed rL365644: [FileCheck] Use bool operator to test Expected.
[FileCheck] Use bool operator to test Expected
Wed, Jul 10, 8:31 AM
thopre added a comment to D64231: [FileCheck] Simplify numeric variable interface.

I was under the impression that an assertion in the public interface of a library API was not a great idea.

Wed, Jul 10, 6:00 AM · Restricted Project
thopre abandoned D64230: [FileCheck] Record numeric variable availability.
Wed, Jul 10, 5:51 AM · Restricted Project
thopre committed rG2bf04f25ff0d: [FileCheck] Simplify numeric variable interface (authored by thopre).
[FileCheck] Simplify numeric variable interface
Wed, Jul 10, 5:50 AM
thopre committed rGf6ea43b8b302: [FileCheck] Fix @LINE value after match failure (authored by thopre).
[FileCheck] Fix @LINE value after match failure
Wed, Jul 10, 5:50 AM
thopre committed rL365625: [FileCheck] Simplify numeric variable interface.
[FileCheck] Simplify numeric variable interface
Wed, Jul 10, 5:50 AM
thopre closed D64231: [FileCheck] Simplify numeric variable interface.
Wed, Jul 10, 5:50 AM · Restricted Project
thopre committed rL365624: [FileCheck] Fix @LINE value after match failure.
[FileCheck] Fix @LINE value after match failure
Wed, Jul 10, 5:49 AM
thopre closed D64449: [FileCheck] Fix @LINE value after match failure.
Wed, Jul 10, 5:49 AM · Restricted Project
thopre edited parent revisions for D64231: [FileCheck] Simplify numeric variable interface, added: 1; removed: 1.
Wed, Jul 10, 2:36 AM · Restricted Project
thopre reopened D64231: [FileCheck] Simplify numeric variable interface.
Wed, Jul 10, 2:36 AM · Restricted Project
thopre removed a child revision for D64229: [FileCheck] Share variable instance among uses: D64231: [FileCheck] Simplify numeric variable interface.
Wed, Jul 10, 2:36 AM · Restricted Project
thopre added a child revision for D64449: [FileCheck] Fix @LINE value after match failure: D64231: [FileCheck] Simplify numeric variable interface.
Wed, Jul 10, 2:36 AM · Restricted Project
thopre added a child revision for D64229: [FileCheck] Share variable instance among uses: D64449: [FileCheck] Fix @LINE value after match failure.
Wed, Jul 10, 2:36 AM · Restricted Project
thopre added a parent revision for D64449: [FileCheck] Fix @LINE value after match failure: D64229: [FileCheck] Share variable instance among uses.
Wed, Jul 10, 2:36 AM · Restricted Project

Tue, Jul 9

thopre created D64449: [FileCheck] Fix @LINE value after match failure.
Tue, Jul 9, 2:41 PM · Restricted Project

Fri, Jul 5

thopre committed rG096600a4b073: [FileCheck] Simplify numeric variable interface (authored by thopre).
[FileCheck] Simplify numeric variable interface
Fri, Jul 5, 2:52 PM
thopre edited parent revisions for D64230: [FileCheck] Record numeric variable availability, added: 1; removed: 1.
Fri, Jul 5, 2:52 PM · Restricted Project
thopre removed a child revision for D64229: [FileCheck] Share variable instance among uses: D64230: [FileCheck] Record numeric variable availability.
Fri, Jul 5, 2:52 PM · Restricted Project
thopre added a child revision for D64231: [FileCheck] Simplify numeric variable interface: D64230: [FileCheck] Record numeric variable availability.
Fri, Jul 5, 2:52 PM · Restricted Project
thopre removed a child revision for D64230: [FileCheck] Record numeric variable availability: D64231: [FileCheck] Simplify numeric variable interface.
Fri, Jul 5, 2:52 PM · Restricted Project
thopre edited parent revisions for D64231: [FileCheck] Simplify numeric variable interface, added: 1; removed: 1.
Fri, Jul 5, 2:52 PM · Restricted Project
thopre added a child revision for D64229: [FileCheck] Share variable instance among uses: D64231: [FileCheck] Simplify numeric variable interface.
Fri, Jul 5, 2:52 PM · Restricted Project
thopre committed rL365249: [FileCheck] Simplify numeric variable interface.
[FileCheck] Simplify numeric variable interface
Fri, Jul 5, 2:50 PM
thopre closed D64231: [FileCheck] Simplify numeric variable interface.
Fri, Jul 5, 2:50 PM · Restricted Project
thopre committed rG56f6308b2d80: [FileCheck] Share variable instance among uses (authored by thopre).
[FileCheck] Share variable instance among uses
Fri, Jul 5, 9:29 AM
thopre committed rGfe7ac170a797: [FileCheck] Don't diagnose undef vars at parse time (authored by thopre).
[FileCheck] Don't diagnose undef vars at parse time
Fri, Jul 5, 9:26 AM
thopre committed rL365220: [FileCheck] Share variable instance among uses.
[FileCheck] Share variable instance among uses
Fri, Jul 5, 9:25 AM
thopre closed D64229: [FileCheck] Share variable instance among uses.
Fri, Jul 5, 9:25 AM · Restricted Project
thopre committed rL365219: [FileCheck] Don't diagnose undef vars at parse time.
[FileCheck] Don't diagnose undef vars at parse time
Fri, Jul 5, 9:25 AM
thopre closed D64228: [FileCheck] Don't diagnose undef vars at parse time.
Fri, Jul 5, 9:25 AM · Restricted Project
thopre added inline comments to D64230: [FileCheck] Record numeric variable availability.
Fri, Jul 5, 8:11 AM · Restricted Project