Page MenuHomePhabricator

thopre (Thomas Preud'homme)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 10:31 AM (60 w, 4 d)

Recent Activity

Wed, Jan 16

thopre created D56789: Allow CHECK-SAME, NEXT and EMPTY after CHECK-DAG.
Wed, Jan 16, 9:05 AM

Mon, Jan 14

thopre committed rL351042: Fix defines.txt.
Fix defines.txt
Mon, Jan 14, 2:14 AM
thopre committed rL351039: Detect incorrect FileCheck variable CLI definition.
Detect incorrect FileCheck variable CLI definition
Mon, Jan 14, 1:33 AM
thopre closed D55940: Detect incorrect FileCheck variable CLI definition.
Mon, Jan 14, 1:33 AM
thopre committed rL351038: Add support for prefix-only CLI options.
Add support for prefix-only CLI options
Mon, Jan 14, 1:33 AM
thopre closed D56549: Add support for prefix-only CLI options.
Mon, Jan 14, 1:33 AM

Sat, Jan 12

thopre updated the summary of D55940: Detect incorrect FileCheck variable CLI definition.
Sat, Jan 12, 5:01 AM
thopre updated the summary of D56549: Add support for prefix-only CLI options.
Sat, Jan 12, 4:44 AM

Fri, Jan 11

thopre updated the summary of D55940: Detect incorrect FileCheck variable CLI definition.
Fri, Jan 11, 5:13 AM

Thu, Jan 10

thopre updated the diff for D56549: Add support for prefix-only CLI options.

Clarify what happens in LookupOption when failing to match an option.

Thu, Jan 10, 8:24 AM
thopre updated the diff for D56549: Add support for prefix-only CLI options.

Fix comment in LookupOption for AlwaysPrefix early bail out

Thu, Jan 10, 8:19 AM
thopre added a child revision for D56549: Add support for prefix-only CLI options: D55940: Detect incorrect FileCheck variable CLI definition.
Thu, Jan 10, 7:49 AM
thopre added a parent revision for D55940: Detect incorrect FileCheck variable CLI definition: D56549: Add support for prefix-only CLI options.
Thu, Jan 10, 7:49 AM
thopre updated the diff for D55940: Detect incorrect FileCheck variable CLI definition.

Take CommandLine option code into a separate patch

Thu, Jan 10, 7:49 AM
thopre created D56549: Add support for prefix-only CLI options.
Thu, Jan 10, 7:46 AM
thopre updated the summary of D55940: Detect incorrect FileCheck variable CLI definition.
Thu, Jan 10, 2:54 AM
thopre added inline comments to D55940: Detect incorrect FileCheck variable CLI definition.
Thu, Jan 10, 2:54 AM
thopre updated the diff for D55940: Detect incorrect FileCheck variable CLI definition.
  • Forbid AlwaysPrefix option to look for their value in following argument
  • Add unit tests for changes to CommandLine
Thu, Jan 10, 2:53 AM

Sat, Dec 29

thopre updated the diff for D55940: Detect incorrect FileCheck variable CLI definition.

Add AlwaysPrefix option formatting flag and define FileCheck's -D option with it.
Add detection of missing variable name.

Sat, Dec 29, 3:37 PM

Dec 21 2018

thopre added a comment to D55940: Detect incorrect FileCheck variable CLI definition.

This will permit -DVALUE= (with no value) is that a supported usage?

I think it should be. You could have a string that sometimes appears and sometimes is excluded entirely.

It also permits -D=10 which I daresay doesn't mean anything.

Agreed.

Dec 21 2018, 3:12 AM
thopre added inline comments to D49084: FileCheck: Add support for numeric variables and expressions.
Dec 21 2018, 2:09 AM

Dec 20 2018

thopre updated the diff for D49084: FileCheck: Add support for numeric variables and expressions.

Document how to set numeric variable with -D option

Dec 20 2018, 4:08 PM
thopre added reviewers for D49084: FileCheck: Add support for numeric variables and expressions: jdenny, probinson, grimar, arichardson, rnk.
Dec 20 2018, 10:03 AM
thopre added a parent revision for D49084: FileCheck: Add support for numeric variables and expressions: D55940: Detect incorrect FileCheck variable CLI definition.
Dec 20 2018, 9:58 AM
thopre added a child revision for D55940: Detect incorrect FileCheck variable CLI definition: D49084: FileCheck: Add support for numeric variables and expressions.
Dec 20 2018, 9:58 AM
thopre retitled D49084: FileCheck: Add support for numeric variables and expressions from FileCheck: Add support for variable expressions to FileCheck: Add support for numeric variables and expressions.
Dec 20 2018, 9:54 AM
thopre updated the diff for D49084: FileCheck: Add support for numeric variables and expressions.

FileCheck: Add support for numeric variables and expressions

Dec 20 2018, 9:51 AM
thopre created D55940: Detect incorrect FileCheck variable CLI definition.
Dec 20 2018, 9:43 AM

Dec 12 2018

thopre accepted D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info.

LGTM. Thanks!

Dec 12 2018, 2:12 AM · Restricted Project

Dec 11 2018

thopre added a comment to D49084: FileCheck: Add support for numeric variables and expressions.
In D49084#1203189, @rnk wrote:

FWIW I had a use case for this recently, and found it hadn't landed. Is there anything blocking that you need help with?

Dec 11 2018, 10:23 AM
thopre added inline comments to D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info.
Dec 11 2018, 5:16 AM · Restricted Project

Dec 10 2018

thopre added inline comments to D55428: [Docs] Expand -fstack-protector and -fstack-protector-all info.
Dec 10 2018, 3:50 AM · Restricted Project

Aug 14 2018

thopre added a comment to D50594: [analyzer] [NFC] Introduce separate targets for testing the analyzer: check-clang-analyzer and check-clang-analyzer-z3.

Hi George,

Aug 14 2018, 1:10 AM

Aug 8 2018

thopre closed D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Aug 8 2018, 2:42 AM
thopre committed rL339225: Support inline asm with multiple 64bit output in 32bit GPR.
Support inline asm with multiple 64bit output in 32bit GPR
Aug 8 2018, 2:36 AM
thopre closed D45437: Support inline asm with multiple 64bit output in 32bit GPR.
Aug 8 2018, 2:36 AM

Aug 7 2018

thopre updated the diff for D45437: Support inline asm with multiple 64bit output in 32bit GPR.
  • Change test for isSized() into assert
  • Add test for multiple return values with matching input
  • Rewrite hardfloat tests to return a struct to make register used predictable and not dependent on register allocator
Aug 7 2018, 6:43 AM
thopre added inline comments to D45437: Support inline asm with multiple 64bit output in 32bit GPR.
Aug 7 2018, 6:41 AM

Aug 3 2018

thopre added a comment to D45437: Support inline asm with multiple 64bit output in 32bit GPR.

Ping? This fix the bug reported in https://reviews.llvm.org/rL337903

Aug 3 2018, 7:41 AM
thopre added a comment to rL337903: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

It appears that this patch crashes llvm under some circumstances.

Reproduction:

test.cc:

float asmfunc(int a, int b) {
  float read_value;
  asm("" : "=r"(read_value), "=r"(a));
  return read_value;
}
int B_X;
void kFCNorm(int a, float b) {
  B_X = asmfunc(a, B_X) * b;
}
$ clang -S -O3 test.cc -o - `
...
clang-7: <redacted>/repo/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4489: llvm::SDValue llvm::SelectionDAG::getNode(unsigned int, const llvm::SDLoc &, llvm::EVT, llvm::SDValue, llvm::SDValue, const llvm::SDNodeFlags): Assertion `VT.isFloatingPoint() && "This operator only applies to FP types!"' failed.

I can reproduce, thanks. I'll see if I can find a fix today and if not will revert it and its follow-up patch.

Aug 3 2018, 7:40 AM
thopre closed D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

Fixed in trunk

Aug 3 2018, 2:24 AM
thopre added a comment to rL337903: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

It appears that this patch crashes llvm under some circumstances.

Reproduction:

test.cc:

float asmfunc(int a, int b) {
  float read_value;
  asm("" : "=r"(read_value), "=r"(a));
  return read_value;
}
int B_X;
void kFCNorm(int a, float b) {
  B_X = asmfunc(a, B_X) * b;
}
$ clang -S -O3 test.cc -o - `
...
clang-7: <redacted>/repo/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:4489: llvm::SDValue llvm::SelectionDAG::getNode(unsigned int, const llvm::SDLoc &, llvm::EVT, llvm::SDValue, llvm::SDValue, const llvm::SDNodeFlags): Assertion `VT.isFloatingPoint() && "This operator only applies to FP types!"' failed.
Aug 3 2018, 2:24 AM
thopre added an edge to rL338269: Reapply "Fix crash on inline asm with 64bit matching input in 32bit GPR": D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Aug 3 2018, 2:20 AM
thopre added an edge to rL338206: Fix crash on inline asm with 64bit matching input in 32bit GPR: D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Aug 3 2018, 2:20 AM
thopre added 2 commit(s) for D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR: rL338269: Reapply "Fix crash on inline asm with 64bit matching input in 32bit GPR", rL338206: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Aug 3 2018, 2:20 AM
thopre added 1 commit(s) for D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR: rL337903: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.
Aug 3 2018, 2:19 AM
thopre added an edge to rL337903: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR: D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.
Aug 3 2018, 2:19 AM

Jul 30 2018

thopre committed rL338269: Reapply "Fix crash on inline asm with 64bit matching input in 32bit GPR".
Reapply "Fix crash on inline asm with 64bit matching input in 32bit GPR"
Jul 30 2018, 9:49 AM
thopre committed rL338268: Fix uninitialized read in ARM's PrintAsmOperand.
Fix uninitialized read in ARM's PrintAsmOperand
Jul 30 2018, 9:46 AM
thopre closed D49984: Fix uninitialized read in ARM's PrintAsmOperand.
Jul 30 2018, 9:46 AM
thopre updated the diff for D45437: Support inline asm with multiple 64bit output in 32bit GPR.

Rebase and rename testcase for consistency

Jul 30 2018, 9:09 AM
thopre added a child revision for D49984: Fix uninitialized read in ARM's PrintAsmOperand: D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Jul 30 2018, 8:59 AM
thopre added a parent revision for D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR: D49984: Fix uninitialized read in ARM's PrintAsmOperand.
Jul 30 2018, 8:59 AM
thopre added inline comments to D49778: Fix "Q" and "R" inline assembly template modifiers for big-endian Arm.
Jul 30 2018, 7:48 AM
thopre added inline comments to D49984: Fix uninitialized read in ARM's PrintAsmOperand.
Jul 30 2018, 7:41 AM
thopre added a comment to D49778: Fix "Q" and "R" inline assembly template modifiers for big-endian Arm.

Hi Jackson, can you reupload the patch with more context line? Something like git diff -U99999 (arc diff does it automatically). Thanks.

Jul 30 2018, 7:38 AM
thopre created D49984: Fix uninitialized read in ARM's PrintAsmOperand.
Jul 30 2018, 6:55 AM

Jul 28 2018

thopre committed rL338206: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Fix crash on inline asm with 64bit matching input in 32bit GPR
Jul 28 2018, 2:34 PM

Jul 27 2018

thopre updated the diff for D45437: Support inline asm with multiple 64bit output in 32bit GPR.

Rebase on latest version of previous patch in stack

Jul 27 2018, 3:27 PM
thopre added inline comments to D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Jul 27 2018, 3:11 PM
thopre updated the diff for D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.

Fix logic for input matching a register constraint for a specific register and add tests for it. I've verified that the code for this logic is executed by those new testcases and that the testcase failed without the fix.

Jul 27 2018, 3:08 PM

Jul 26 2018

thopre accepted D49786: Enable some pointer authentication instructions for aarch64 v8a targets.

LGTM now.

Jul 26 2018, 5:33 AM
thopre added inline comments to D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Jul 26 2018, 3:06 AM

Jul 25 2018

thopre added inline comments to D49786: Enable some pointer authentication instructions for aarch64 v8a targets.
Jul 25 2018, 8:38 AM
thopre updated subscribers of D49684: [libFuzzer] Handle unstable edges by disregarding unstable edges.

Hi Kyungtak,

Jul 25 2018, 8:16 AM
thopre added a comment to D49525: [libFuzzer] Handle unstable edges by using minimum hit counts.

Kevin, looks like test is not fully deterministic :(

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/5509

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/5509/steps/ninja%20check%202/logs/FAIL%3A%20libFuzzer%3A%3A%20handle_unstable_minunstable.test

This is the first testbot failure I've seen so far, so am not reverting the change yet, but please take a look into why the test might be failing sometimes.

Jul 25 2018, 8:13 AM
thopre committed rL337903: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.
Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR
Jul 25 2018, 4:11 AM

Jul 24 2018

thopre updated the diff for D45437: Support inline asm with multiple 64bit output in 32bit GPR.

Rename testcase and test both soft and hard float ABI

Jul 24 2018, 4:09 AM
thopre updated the diff for D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.

Rename testcase and test both soft and hard float ABI

Jul 24 2018, 4:07 AM
thopre updated the diff for D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

Rename testcase and test both soft and hard float ABI

Jul 24 2018, 3:53 AM

Jul 19 2018

thopre added a comment to D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

Hi Eli,

Jul 19 2018, 8:55 AM

Jul 17 2018

thopre added inline comments to D49328: [FileCheck] Provide an option for FileCheck to dump original input to stderr on failure.
Jul 17 2018, 2:29 AM

Jul 16 2018

thopre added inline comments to D49364: [ARM] Add support for spilling high registers in Thumb1.
Jul 16 2018, 9:46 AM

Jul 12 2018

thopre added a comment to D49084: FileCheck: Add support for numeric variables and expressions.

Maybe this should be a new class of "numeric variables" with distinct syntax, e.g., [[#VAR]] or something, with an implicit regex of [[:digit:]]+ instead of making the test-writer use a valid regex.

I'm not sure I'm following you. Do you mean using a different syntax when (i) defining numeric variable or (ii) when using numeric expression?
I also do not understand how this would prevent the test-writer from having to use a valid regex. Could you give an example of the problem you see?

Jul 12 2018, 5:00 AM

Jul 11 2018

thopre added a comment to D49084: FileCheck: Add support for numeric variables and expressions.

Maybe this should be a new class of "numeric variables" with distinct syntax, e.g., [[#VAR]] or something, with an implicit regex of [[:digit:]]+ instead of making the test-writer use a valid regex.

Jul 11 2018, 8:38 AM
thopre added a comment to D49084: FileCheck: Add support for numeric variables and expressions.

Thanks all for the valuable comments. It seems clear that more discussion is needed on the syntax before doing any code change. I'll think about it and post a proposal to the ML.

Jul 11 2018, 6:01 AM

Jul 9 2018

thopre created D49084: FileCheck: Add support for numeric variables and expressions.
Jul 9 2018, 9:37 AM

Jul 4 2018

thopre added a comment to D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

Could you separate the "add support for matching input" part into a separate patch? I'm having trouble following what exactly you're trying to do.

Done. Sorry for the delay, was in extended leave away from computer.

Jul 4 2018, 10:01 AM

Jun 21 2018

thopre updated the diff for D45437: Support inline asm with multiple 64bit output in 32bit GPR.

Rebase

Jun 21 2018, 8:05 AM
thopre added a comment to D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

Could you separate the "add support for matching input" part into a separate patch? I'm having trouble following what exactly you're trying to do.

Jun 21 2018, 8:03 AM
thopre removed a parent revision for D45437: Support inline asm with multiple 64bit output in 32bit GPR: D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.
Jun 21 2018, 8:02 AM
thopre removed a child revision for D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR: D45437: Support inline asm with multiple 64bit output in 32bit GPR.
Jun 21 2018, 8:02 AM
thopre added a parent revision for D45437: Support inline asm with multiple 64bit output in 32bit GPR: D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Jun 21 2018, 8:02 AM
thopre added a child revision for D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR: D45437: Support inline asm with multiple 64bit output in 32bit GPR.
Jun 21 2018, 8:02 AM
thopre added a parent revision for D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR: D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.
Jun 21 2018, 8:01 AM
thopre added a child revision for D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR: D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Jun 21 2018, 8:01 AM
thopre created D48434: Fix crash on inline asm with 64bit matching input in 32bit GPR.
Jun 21 2018, 8:00 AM
thopre updated the summary of D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.
Jun 21 2018, 7:58 AM
thopre updated the diff for D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

Split the matching input handling into a separate patch.

Jun 21 2018, 7:50 AM

Apr 24 2018

thopre accepted D45965: [Targets] Implement getConstraintRegister for ARM and AArch64.

As I said, LGTM. Please wait a few days (say next Monday) in case anyone else has any objection.

Apr 24 2018, 7:07 AM
thopre added a comment to D45965: [Targets] Implement getConstraintRegister for ARM and AArch64.

FWIW LGTM.

Apr 24 2018, 6:54 AM
thopre added inline comments to D45965: [Targets] Implement getConstraintRegister for ARM and AArch64.
Apr 24 2018, 6:53 AM

Apr 23 2018

thopre added inline comments to D45965: [Targets] Implement getConstraintRegister for ARM and AArch64.
Apr 23 2018, 9:28 AM

Apr 17 2018

thopre added a comment to D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

Ping?

Apr 17 2018, 5:45 AM
thopre added a comment to D45437: Support inline asm with multiple 64bit output in 32bit GPR.

Ping?

Apr 17 2018, 5:45 AM

Apr 9 2018

thopre created D45437: Support inline asm with multiple 64bit output in 32bit GPR.
Apr 9 2018, 5:38 AM
thopre added a parent revision for D45437: Support inline asm with multiple 64bit output in 32bit GPR: D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.
Apr 9 2018, 5:38 AM
thopre added a child revision for D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR: D45437: Support inline asm with multiple 64bit output in 32bit GPR.
Apr 9 2018, 5:38 AM

Apr 6 2018

thopre updated the diff for D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.

Fix code style issue

Apr 6 2018, 8:48 AM
thopre created D45376: Fix PR34170: Crash on inline asm with 64bit output in 32bit GPR.
Apr 6 2018, 8:48 AM