User Details
- User Since
- Nov 22 2017, 10:31 AM (240 w, 5 d)
May 25 2022
May 18 2022
May 17 2022
Be more conservative in what we reject
Exclude match arguments
Genuine test failure on CodeGenOpenCL/builtins-fp-atomics-gfx1030.cl
Ping?
May 16 2022
May 6 2022
LGTM with the suggested codestyle changes
May 5 2022
- Rebase
- remove changes to ignoreDependence, it should be done in a separate commit
Apr 27 2022
- Replace isArtificial check by isBoundaryNode
- Remove call to ignoreDependence in computePath for predecessors
- remove no longer needed changes to PowerPC tests
Apr 25 2022
Apr 22 2022
Adding @jsji to review the changes to PowerPC testcases. I've checked the MIR after the pipeliner for sms-phi-3.ll and the loop still gets pipelined (which makes sense since the modified code executes after the decision to pipeline is made) but the code gets simplified by later pass. Are you happy with the change?
Adjust PowerPC testcases
Apr 21 2022
LGTM but I'd prefer someone else to approve.
Apr 20 2022
LGTM with the following description change: very subtle bug horrible bug -> very subtle *but* horrible bug
Apr 6 2022
Is the change about handling cases where the project name is something that would not be valid for parse_version? Could you detail the commit message a little bit to explain what is currently not compliant?
Apr 4 2022
Apr 1 2022
Note: there is still a few reference to mlir::FuncOp in the tree: most notably in the toy example:
Mar 29 2022
Mar 15 2022
Rebase
Mar 9 2022
Feb 23 2022
Jan 19 2022
Jan 18 2022
Jan 17 2022
What's the reason for not using CLANG instead of BOLT_CLANG_EXE?
Jan 12 2022
Could you add a new testcase somewhere in llvm/test/FileCheck? Thanks!
Jan 11 2022
LGTM, thanks!
LGTM
Dec 14 2021
So this is to be compatible with sphinx 2.0? LGTM
LGTM
On what system isn't the SIGBUS caught?
LGTM otherwise
Dec 10 2021
Dec 9 2021
Hi Joel,
Nov 26 2021
Adding Tamar to get an Arm person to review this.
Nov 25 2021
LGTM, thanks!
Nov 17 2021
LGTM
This caused a regression for us for i16 cttz with is_undef_zero true because cttz is expanded to a sequence using ctpop which loses the fact that any output is ok for the 0 case.
Nov 16 2021
Nov 15 2021
LGTM
Nov 13 2021
LGTM
Nov 12 2021
Nov 9 2021
Nov 8 2021
Nov 3 2021
Oct 29 2021
LGTM
Oct 28 2021
LGTM with the proposed changes. I'll land it for you with them.