Committed as 10f1592ecb34bdbf2d7c62736aaf987df2fdd511

In D68779#1811800, @thopre wrote:

Ping @cmatthews ?

• Address unit tests review comments
• fix casing of first letter in an error message

Introduce StringMatcher.empty()

In D72517#1823830, @evgeny777 wrote:

I think that adding extra flag to GlobPattern::create was better idea. Just set it to false by default, so that GlobPattern will still act as glob matcher for all other users:

static static Expected<GlobPattern> create(StringRef Pat, bool IgnoreMetaChars = false);

Than add extra constructor to StringMatcher to which you'll pass GlobPattern and use it from InputSectionDescription constructor.

In D72517#1814982, @MaskRay wrote:

allows to fix a failure in ELF/linkerscript/filename-spec.s when the path contain a @ which the lexer consider as a special characters and thus break up a filename containing it.

Which one?

• Make exact match at StringMatcher level
• Add possibility to add new pattern to a StringMatcher

Ping @cmatthews ?

Need to add unit tests

Need to add unit tests

Rebase

Complete unit testing of changes in the patch

Is everybody happy with the constness changes to the ExpressionFormat operators and the new unit tests?

In D68054#1806142, @nlguillemot wrote:

In D68054#1801066, @thopre wrote:

How about the following commit message:

(...)

I would suggest an amendment to this part:

To force developers to be mindful of this aspect, an assert is added to match() to check
that the regex is valid and an new idiom is created as follows for
cases where the pattern is known to be valid:

As-is, this patch doesn't assert inside match(), since this makes the API more backwards compatible. The wording of the commit message should be updated to match this.

It was originally a bit tricky to track down and update all users of the API, but the monorepo makes that a lot easier. If we brought back the older version of the commit that *did* assert inside match(), and we updated all affected users of the API (eg: clang) before committing, I wouldn't be opposed.

My apologies but I still think there's changes needed on this patch. I had changed the status earlier but I presume updating the patch did reset the status to "needs review". I haven't covered all the API changes in the unittests and I'd like to address the comment from Paul about the lack of clarity of which variables have implicit format conflict. I'm happy to deal with the latter in a separate patch if people are eager to have this change (I'm personally looking forward to it being committed as well) but I want to at least finish the unit testing.

Use EXPECT_THAT_ERROR when testing for an error in unittest

Do not rename FileCheckPatternContext

Rebase

Rebase

Address latest round of review comments

Rebase

Add example showing literals are always parsed as decimal

Rebase

Rebase

Address most review comments

How about the following commit message:

In rGddd0bb8dba2a367c6aa8a25e98915509847745ce#866804, @nemanjai wrote:

I committed https://reviews.llvm.org/rGba5a00167bf30df5d544fdbe9fd28ce1a8341b89 to fix the bots. Please review that patch. If the fix is not quite as desired, please update it but I wanted to make sure to commit it to get the bots back to green.

In D71408#1787959, @jdenny wrote:

This breaks the lit test suite. llvm/utils/lit/tests/shtest-format.py needs to be updated for the removed tests.

Remove REQUIRES-ANY lit directive

Committed as e3f5ef6decd5a6eaa96b0286aa8798e951b0c640

Committed as d52e617d81aa62182f45d5d8e1f153f7c0c43a42

Committed as d9a8050d19ee28dd3c2ab07d23a1382dd35b43e6

Restrict ordering of options further according to what the code does.

Check that CMAKE_C(XX)?_COMPILER come first on cmake invocation

Rebase

Need to add unit tests

Address comment and rebase

Uploading the current status of this patch. I know there are still issues (in particular add more unittests), and I'll address them.

Uploading the current status of this patch. I know there are still issues (in particular add more unittests), and I'll address them.

Address most comments, rebase.

Committed as c57e3b02d4344ada87ecd63139a58a15b2b3dbaa

Rebase later in patch series

Committed as d935e954283fac46ac47e9b0e87fd6ecab6ce64d

Rebase earlier in patch series

@cmatthews Are you happy with this patch as it is? Changes proposed will require Python 3.1 which is covered by D71085 to require Python 2.7 or 3.6+ once all Python 3 patches are in. As to the unusual import Matthias explain it is to avoid adding unnecessary python module requirements for users of the LNT client only.

Committed as a99f86119a7c5efbe3af20511ba0bd4f9fa24355