Page MenuHomePhabricator

thopre (Thomas Preud'homme)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 10:31 AM (112 w, 2 d)

Recent Activity

Yesterday

thopre added a comment to D68779: [LNT][NFC] Fix global import in function.

Committed as 10f1592ecb34bdbf2d7c62736aaf987df2fdd511

Fri, Jan 17, 11:11 AM
thopre closed D68779: [LNT][NFC] Fix global import in function.
Fri, Jan 17, 11:11 AM
thopre added a comment to D68779: [LNT][NFC] Fix global import in function.

Ping @cmatthews ?

Fri, Jan 17, 5:13 AM
thopre added a child revision for D72914: [FileCheck] Strengthen error checks in unit tests: D60389: FileCheck [9/12]: Add support for matching formats.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre edited parent revisions for D60389: FileCheck [9/12]: Add support for matching formats, added: 1; removed: 1.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre removed a child revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D60389: FileCheck [9/12]: Add support for matching formats.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre added a parent revision for D72914: [FileCheck] Strengthen error checks in unit tests: D72913: [FileCheck] Make Match unittest more flexible.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre added a child revision for D72912: [FileCheck] Clean and improve unit tests: D72913: [FileCheck] Make Match unittest more flexible.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre added a parent revision for D72913: [FileCheck] Make Match unittest more flexible: D72912: [FileCheck] Clean and improve unit tests.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre added a parent revision for D72912: [FileCheck] Clean and improve unit tests: D64921: [FileCheck] Use ASSERT for fatal unit tests.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre added a child revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D72912: [FileCheck] Clean and improve unit tests.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre added a child revision for D72913: [FileCheck] Make Match unittest more flexible: D72914: [FileCheck] Strengthen error checks in unit tests.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre created D72914: [FileCheck] Strengthen error checks in unit tests.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.
  • Address unit tests review comments
  • fix casing of first letter in an error message
Fri, Jan 17, 3:57 AM · Restricted Project
thopre created D72913: [FileCheck] Make Match unittest more flexible.
Fri, Jan 17, 3:57 AM · Restricted Project
thopre created D72912: [FileCheck] Clean and improve unit tests.
Fri, Jan 17, 3:51 AM · Restricted Project

Thu, Jan 16

thopre updated the diff for D72517: [lld/ELF] PR44498: Support input filename in double quote.

Introduce StringMatcher.empty()

Thu, Jan 16, 3:24 PM · Restricted Project
thopre added a comment to D72517: [lld/ELF] PR44498: Support input filename in double quote.

I think that adding extra flag to GlobPattern::create was better idea. Just set it to false by default, so that GlobPattern will still act as glob matcher for all other users:

static static Expected<GlobPattern> create(StringRef Pat, bool IgnoreMetaChars = false);

Than add extra constructor to StringMatcher to which you'll pass GlobPattern and use it from InputSectionDescription constructor.

Thu, Jan 16, 3:13 PM · Restricted Project

Tue, Jan 14

thopre added a comment to D72517: [lld/ELF] PR44498: Support input filename in double quote.
allows to fix a failure in ELF/linkerscript/filename-spec.s when the path contain a @ which the lexer consider as a special characters and thus break up a filename containing it.

Which one?

Tue, Jan 14, 11:02 AM · Restricted Project
thopre updated the summary of D72517: [lld/ELF] PR44498: Support input filename in double quote.
Tue, Jan 14, 10:51 AM · Restricted Project
thopre updated the diff for D72517: [lld/ELF] PR44498: Support input filename in double quote.
  • Make exact match at StringMatcher level
  • Add possibility to add new pattern to a StringMatcher
Tue, Jan 14, 10:51 AM · Restricted Project

Fri, Jan 10

thopre created D72517: [lld/ELF] PR44498: Support input filename in double quote.
Fri, Jan 10, 9:13 AM · Restricted Project
thopre retitled D72517: [lld/ELF] PR44498: Support input filename in double quote from [lld/ELF] Support input filename in double quote to [lld/ELF] PR44498: Support input filename in double quote.
Fri, Jan 10, 9:13 AM · Restricted Project
thopre added inline comments to D60386: FileCheck [6/12]: Introduce numeric variable definition.
Fri, Jan 10, 2:35 AM · Restricted Project

Thu, Jan 9

thopre added inline comments to D60386: FileCheck [6/12]: Introduce numeric variable definition.
Thu, Jan 9, 6:56 AM · Restricted Project
thopre added a comment to D68779: [LNT][NFC] Fix global import in function.

Ping @cmatthews ?

Thu, Jan 9, 5:01 AM

Wed, Jan 8

thopre planned changes to D60391: FileCheck [11/12]: Add matching constraint specification.

Need to add unit tests

Wed, Jan 8, 7:31 AM · Restricted Project
thopre planned changes to D60390: FileCheck [10/12]: Add support for signed numeric values.

Need to add unit tests

Wed, Jan 8, 7:31 AM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase

Wed, Jan 8, 7:31 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Wed, Jan 8, 7:03 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Complete unit testing of changes in the patch

Wed, Jan 8, 7:02 AM · Restricted Project
thopre requested review of D60389: FileCheck [9/12]: Add support for matching formats.

Is everybody happy with the constness changes to the ExpressionFormat operators and the new unit tests?

Wed, Jan 8, 7:02 AM · Restricted Project

Mon, Jan 6

thopre committed rGd8fd92eaaa34: [FileCheck] Remove FileCheck prefix in API (authored by thopre).
[FileCheck] Remove FileCheck prefix in API
Mon, Jan 6, 2:35 PM
thopre closed D72186: [FileCheck] Remove FileCheck prefix in API.
Mon, Jan 6, 2:35 PM · Restricted Project
thopre added a comment to D68054: Regex: Add static convenience functions for "match" and "sub".

How about the following commit message:

(...)

I would suggest an amendment to this part:

To force developers to be mindful of this aspect, an assert is added to match() to check
that the regex is valid and an new idiom is created as follows for
cases where the pattern is known to be valid:

As-is, this patch doesn't assert inside match(), since this makes the API more backwards compatible. The wording of the commit message should be updated to match this.

It was originally a bit tricky to track down and update all users of the API, but the monorepo makes that a lot easier. If we brought back the older version of the commit that *did* assert inside match(), and we updated all affected users of the API (eg: clang) before committing, I wouldn't be opposed.

Mon, Jan 6, 1:11 PM · Restricted Project
thopre planned changes to D60389: FileCheck [9/12]: Add support for matching formats.

My apologies but I still think there's changes needed on this patch. I had changed the status earlier but I presume updating the patch did reset the status to "needs review". I haven't covered all the API changes in the unittests and I'd like to address the comment from Paul about the lack of clarity of which variables have implicit format conflict. I'm happy to deal with the latter in a separate patch if people are eager to have this change (I'm personally looking forward to it being committed as well) but I want to at least finish the unit testing.

Mon, Jan 6, 7:11 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Use EXPECT_THAT_ERROR when testing for an error in unittest

Mon, Jan 6, 5:41 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Mon, Jan 6, 5:41 AM · Restricted Project
thopre updated the diff for D72186: [FileCheck] Remove FileCheck prefix in API.

Do not rename FileCheckPatternContext

Mon, Jan 6, 3:21 AM · Restricted Project

Fri, Jan 3

thopre created D72186: [FileCheck] Remove FileCheck prefix in API.
Fri, Jan 3, 3:09 PM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase

Fri, Jan 3, 1:49 PM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase

Fri, Jan 3, 12:51 PM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Fri, Jan 3, 12:42 PM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Address latest round of review comments

Fri, Jan 3, 12:42 PM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase

Fri, Jan 3, 11:50 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Add example showing literals are always parsed as decimal

Fri, Jan 3, 11:50 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Fri, Jan 3, 11:50 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Fri, Jan 3, 6:37 AM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase

Fri, Jan 3, 6:16 AM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase

Fri, Jan 3, 6:16 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Address most review comments

Fri, Jan 3, 6:16 AM · Restricted Project

Thu, Jan 2

thopre added a comment to D68054: Regex: Add static convenience functions for "match" and "sub".

How about the following commit message:

Thu, Jan 2, 4:27 AM · Restricted Project

Dec 18 2019

thopre added a comment to rGddd0bb8dba2a: [lit] Remove lit's REQUIRES-ANY directive.

I committed https://reviews.llvm.org/rGba5a00167bf30df5d544fdbe9fd28ce1a8341b89 to fix the bots. Please review that patch. If the fix is not quite as desired, please update it but I wanted to make sure to commit it to get the bots back to green.

Dec 18 2019, 1:47 AM

Dec 17 2019

thopre updated subscribers of D71408: [lit] Remove lit's REQUIRES-ANY directive.

This breaks the lit test suite. llvm/utils/lit/tests/shtest-format.py needs to be updated for the removed tests.

Dec 17 2019, 1:46 PM · Restricted Project, Restricted Project, Restricted Project
thopre committed rGddd0bb8dba2a: [lit] Remove lit's REQUIRES-ANY directive (authored by thopre).
[lit] Remove lit's REQUIRES-ANY directive
Dec 17 2019, 2:42 AM
thopre closed D71408: [lit] Remove lit's REQUIRES-ANY directive.
Dec 17 2019, 2:41 AM · Restricted Project, Restricted Project, Restricted Project

Dec 12 2019

thopre retitled D71408: [lit] Remove lit's REQUIRES-ANY directive from [lit] Document lit's REQUIRES-ANY to [lit] Remove lit's REQUIRES-ANY directive.
Dec 12 2019, 4:40 PM · Restricted Project, Restricted Project, Restricted Project
thopre updated the diff for D71408: [lit] Remove lit's REQUIRES-ANY directive.

Remove REQUIRES-ANY lit directive

Dec 12 2019, 4:40 PM · Restricted Project, Restricted Project, Restricted Project
thopre closed D69053: [LNT] Switch docker image to Python 3.
Dec 12 2019, 6:16 AM
thopre added a comment to D71085: [LNT] Declare support for Python 3.6+.

Committed as e3f5ef6decd5a6eaa96b0286aa8798e951b0c640

Dec 12 2019, 6:04 AM
thopre closed D68863: [LNT] Python 3 support: don't assume order of cmake args.
Dec 12 2019, 6:04 AM
thopre added a comment to D68863: [LNT] Python 3 support: don't assume order of cmake args.

Committed as d52e617d81aa62182f45d5d8e1f153f7c0c43a42

Dec 12 2019, 6:04 AM
thopre closed D71085: [LNT] Declare support for Python 3.6+.
Dec 12 2019, 6:04 AM
thopre added a comment to D69052: [LNT] Python 3 support: enable testing for Python 3.

Committed as d9a8050d19ee28dd3c2ab07d23a1382dd35b43e6

Dec 12 2019, 6:04 AM
thopre closed D69052: [LNT] Python 3 support: enable testing for Python 3.
Dec 12 2019, 6:04 AM
thopre created D71408: [lit] Remove lit's REQUIRES-ANY directive.
Dec 12 2019, 3:48 AM · Restricted Project, Restricted Project, Restricted Project
thopre added inline comments to D68863: [LNT] Python 3 support: don't assume order of cmake args.
Dec 12 2019, 3:04 AM
thopre updated the summary of D68863: [LNT] Python 3 support: don't assume order of cmake args.
Dec 12 2019, 3:04 AM
thopre updated the diff for D68863: [LNT] Python 3 support: don't assume order of cmake args.

Restrict ordering of options further according to what the code does.

Dec 12 2019, 3:03 AM

Dec 11 2019

thopre added inline comments to D68863: [LNT] Python 3 support: don't assume order of cmake args.
Dec 11 2019, 9:24 AM
thopre updated the diff for D68863: [LNT] Python 3 support: don't assume order of cmake args.

Check that CMAKE_C(XX)?_COMPILER come first on cmake invocation

Dec 11 2019, 9:24 AM
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase

Dec 11 2019, 6:17 AM · Restricted Project
thopre planned changes to D60391: FileCheck [11/12]: Add matching constraint specification.

Need to add unit tests

Dec 11 2019, 6:17 AM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Address comment and rebase

Dec 11 2019, 6:08 AM · Restricted Project
thopre planned changes to D60390: FileCheck [10/12]: Add support for signed numeric values.

Uploading the current status of this patch. I know there are still issues (in particular add more unittests), and I'll address them.

Dec 11 2019, 6:08 AM · Restricted Project
thopre planned changes to D60389: FileCheck [9/12]: Add support for matching formats.

Uploading the current status of this patch. I know there are still issues (in particular add more unittests), and I'll address them.

Dec 11 2019, 4:48 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Address most comments, rebase.

Dec 11 2019, 4:48 AM · Restricted Project

Dec 10 2019

thopre added a comment to D68798: [LNT] Python 3 support: fix printing of exceptions.

Committed as c57e3b02d4344ada87ecd63139a58a15b2b3dbaa

Dec 10 2019, 4:30 AM
thopre closed D68798: [LNT] Python 3 support: fix printing of exceptions.
Dec 10 2019, 4:30 AM
thopre removed a parent revision for D68798: [LNT] Python 3 support: fix printing of exceptions: D68779: [LNT][NFC] Fix global import in function.
Dec 10 2019, 4:21 AM
thopre removed a child revision for D68779: [LNT][NFC] Fix global import in function: D68798: [LNT] Python 3 support: fix printing of exceptions.
Dec 10 2019, 4:21 AM
thopre updated the diff for D68779: [LNT][NFC] Fix global import in function.

Rebase later in patch series

Dec 10 2019, 4:21 AM
thopre added a comment to D67823: [LNT] Python 3 support: use Python 3 module names.

Committed as d935e954283fac46ac47e9b0e87fd6ecab6ce64d

Dec 10 2019, 4:12 AM
thopre closed D67823: [LNT] Python 3 support: use Python 3 module names.
Dec 10 2019, 4:12 AM
thopre removed a child revision for D68799: [LNT] Fix sql index name collision: D68779: [LNT][NFC] Fix global import in function.
Dec 10 2019, 4:04 AM
thopre edited parent revisions for D68779: [LNT][NFC] Fix global import in function, added: 1; removed: 1.
Dec 10 2019, 4:04 AM
thopre added a child revision for D67823: [LNT] Python 3 support: use Python 3 module names: D68779: [LNT][NFC] Fix global import in function.
Dec 10 2019, 4:04 AM
thopre edited parent revisions for D68798: [LNT] Python 3 support: fix printing of exceptions, added: 1; removed: 1.
Dec 10 2019, 4:03 AM
thopre removed a child revision for D67823: [LNT] Python 3 support: use Python 3 module names: D68798: [LNT] Python 3 support: fix printing of exceptions.
Dec 10 2019, 4:03 AM
thopre added a child revision for D68779: [LNT][NFC] Fix global import in function: D68798: [LNT] Python 3 support: fix printing of exceptions.
Dec 10 2019, 4:03 AM
thopre edited parent revisions for D67823: [LNT] Python 3 support: use Python 3 module names, added: 1; removed: 1.
Dec 10 2019, 4:03 AM
thopre added a child revision for D68799: [LNT] Fix sql index name collision: D67823: [LNT] Python 3 support: use Python 3 module names.
Dec 10 2019, 4:03 AM
thopre removed a child revision for D68779: [LNT][NFC] Fix global import in function: D67823: [LNT] Python 3 support: use Python 3 module names.
Dec 10 2019, 4:03 AM
thopre updated the diff for D67823: [LNT] Python 3 support: use Python 3 module names.

Rebase earlier in patch series

Dec 10 2019, 4:03 AM

Dec 9 2019

thopre added a parent revision for D68798: [LNT] Python 3 support: fix printing of exceptions: D67823: [LNT] Python 3 support: use Python 3 module names.
Dec 9 2019, 6:22 AM
thopre added a child revision for D67823: [LNT] Python 3 support: use Python 3 module names: D68798: [LNT] Python 3 support: fix printing of exceptions.
Dec 9 2019, 6:22 AM
thopre added a comment to D68779: [LNT][NFC] Fix global import in function.

@cmatthews Are you happy with this patch as it is? Changes proposed will require Python 3.1 which is covered by D71085 to require Python 2.7 or 3.6+ once all Python 3 patches are in. As to the unusual import Matthias explain it is to avoid adding unnecessary python module requirements for users of the LNT client only.

Dec 9 2019, 6:03 AM
thopre added a comment to D68799: [LNT] Fix sql index name collision.

Committed as a99f86119a7c5efbe3af20511ba0bd4f9fa24355

Dec 9 2019, 5:58 AM
thopre closed D68799: [LNT] Fix sql index name collision.
Dec 9 2019, 5:58 AM