Page MenuHomePhabricator

thopre (Thomas Preud'homme)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 10:31 AM (123 w, 6 d)

Recent Activity

Fri, Apr 3

thopre added a comment to D77383: [FileCheck] Allow parenthesized expressions.

Should there be some tests under llvm/test/FileCheck as well? Perhaps in numeric-expressions.txt?

Fri, Apr 3, 6:56 AM · Restricted Project

Wed, Apr 1

thopre added a comment to D77227: [RFC][FileCheck] Require colon immediately after CHECK directives.

I agree we don't want these diagnostics to examine FileCheck prefixes within RUN lines. I was just observing that the rule as I formulated it above would be sufficient for that purpose, so we wouldn't need a separate constraint for RUN lines.

Ah, so I misunderstood what you meant by "the above rule" sorry about that! If we require a comment marker to precede the directive, then we're good (until some clever language decides to use '=' as their comment delimiter).

Wed, Apr 1, 4:20 PM · Restricted Project

Fri, Mar 27

thopre committed rG6eb345af5a1b: [lld test] Tighten ELF/pre_init_fini_array.s test (authored by thopre).
[lld test] Tighten ELF/pre_init_fini_array.s test
Fri, Mar 27, 2:54 PM
thopre closed D76852: [lld test] Tighten ELF/pre_init_fini_array.s test.
Fri, Mar 27, 2:54 PM · Restricted Project
thopre updated the diff for D76852: [lld test] Tighten ELF/pre_init_fini_array.s test.

Address last set of comments

Fri, Mar 27, 2:52 PM · Restricted Project
thopre updated the diff for D76852: [lld test] Tighten ELF/pre_init_fini_array.s test.

Use readelf instead of readobj

Fri, Mar 27, 7:40 AM · Restricted Project

Thu, Mar 26

thopre abandoned D75631: [llvm-objdump] Fix reliability of call target disassembling.

Test change looks good (address lookup rather than by name), but it makes the objdump change completely irrelevant to this now, so I'd revert the objdump change.

Thu, Mar 26, 9:45 AM · Restricted Project
thopre updated the diff for D76852: [lld test] Tighten ELF/pre_init_fini_array.s test.

Incorporate DISASM improvements from D75631

Thu, Mar 26, 9:45 AM · Restricted Project
thopre added inline comments to D75631: [llvm-objdump] Fix reliability of call target disassembling.
Thu, Mar 26, 8:06 AM · Restricted Project
thopre created D76852: [lld test] Tighten ELF/pre_init_fini_array.s test.
Thu, Mar 26, 8:06 AM · Restricted Project
thopre added inline comments to D75631: [llvm-objdump] Fix reliability of call target disassembling.
Thu, Mar 26, 7:33 AM · Restricted Project
thopre updated the summary of D75631: [llvm-objdump] Fix reliability of call target disassembling.
Thu, Mar 26, 7:33 AM · Restricted Project
thopre updated the diff for D75631: [llvm-objdump] Fix reliability of call target disassembling.

Cross-check address of call targets in lld/test/ELF/pre_init_fini_array.s against section address with --syms

Thu, Mar 26, 7:33 AM · Restricted Project

Wed, Mar 25

thopre added inline comments to D75631: [llvm-objdump] Fix reliability of call target disassembling.
Wed, Mar 25, 10:16 AM · Restricted Project
thopre updated the diff for D75631: [llvm-objdump] Fix reliability of call target disassembling.

Remove assert

Wed, Mar 25, 9:09 AM · Restricted Project
thopre added a comment to D75631: [llvm-objdump] Fix reliability of call target disassembling.

This still needed after D76739?

Wed, Mar 25, 9:09 AM · Restricted Project
thopre accepted D76739: [llvm-objdump] Replace array_pod_sort with llvm::stable_sort.

LGTM. This is what I think is causing tools/llvm-objdump/X86/disassemble-functions.test to fail in some settings (see my comment https://reviews.llvm.org/D75631#1940245)

Wed, Mar 25, 6:59 AM · Restricted Project

Tue, Mar 24

thopre added a reviewer for D75631: [llvm-objdump] Fix reliability of call target disassembling: davidb.
Tue, Mar 24, 3:50 PM · Restricted Project
thopre added inline comments to D75631: [llvm-objdump] Fix reliability of call target disassembling.
Tue, Mar 24, 3:45 PM · Restricted Project
thopre retitled D75631: [llvm-objdump] Fix reliability of call target disassembling from [test] Fix reliability of disassemble-functions.test to [llvm-objdump] Fix reliability of call target disassembling.
Tue, Mar 24, 3:43 PM · Restricted Project
thopre updated the diff for D75631: [llvm-objdump] Fix reliability of call target disassembling.

Fix source of variability in test

Tue, Mar 24, 3:43 PM · Restricted Project
thopre added a comment to D75631: [llvm-objdump] Fix reliability of call target disassembling.

The change looks good to me regardless, but i'd like to understand the issue causing the variability in behaviour before giving formal approval, as non-determinism like this is bad, and might indicate something like an unitialised variable somewhere or some other bug.

I will also be nervous to approve this change, without understanding how the test fails.

Agreed.

-eric

Tue, Mar 24, 3:42 PM · Restricted Project

Mar 6 2020

thopre added a comment to D75631: [llvm-objdump] Fix reliability of call target disassembling.

@MaskRay just made a change to some disassembly output (see D75713). I'm not sure if it's going to impact this change or not, but you should check. Also, could you clarify what you mean by "sometimes disassembled" please? Why does it change?

Mar 6 2020, 8:13 AM · Restricted Project
thopre updated the diff for D75631: [llvm-objdump] Fix reliability of call target disassembling.

Rebase and adapt after D75713

Mar 6 2020, 8:13 AM · Restricted Project

Mar 5 2020

thopre added inline comments to D68061: [docs] Document pattern of using CHECK-SAME to skip irrelevant lines.
Mar 5 2020, 8:13 AM · Restricted Project
thopre added a comment to D68061: [docs] Document pattern of using CHECK-SAME to skip irrelevant lines.

Ping?

Mar 5 2020, 2:46 AM · Restricted Project

Mar 4 2020

thopre created D75631: [llvm-objdump] Fix reliability of call target disassembling.
Mar 4 2020, 11:47 AM · Restricted Project

Jan 29 2020

thopre added a comment to D73611: [LNT] Update git URL in Dockerfile.

Committed as 23294fb9ca142f9982dcfac1044b589de0baf481

Jan 29 2020, 2:03 AM
thopre closed D73611: [LNT] Update git URL in Dockerfile.
Jan 29 2020, 1:57 AM
thopre created D73611: [LNT] Update git URL in Dockerfile.
Jan 29 2020, 1:44 AM

Jan 24 2020

thopre committed rG8e96697c7df6: FileCheck [9/12]: Add support for matching formats (authored by thopre).
FileCheck [9/12]: Add support for matching formats
Jan 24 2020, 6:23 AM
thopre closed D60389: FileCheck [9/12]: Add support for matching formats.
Jan 24 2020, 6:22 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.
  • Fix typo in doc
  • remove sneaky literal for LineNumber in unit test
Jan 24 2020, 6:22 AM · Restricted Project

Jan 23 2020

thopre committed rGf1ad192915f6: [FileCheck] Strengthen error checks in unit tests (authored by thopre).
[FileCheck] Strengthen error checks in unit tests
Jan 23 2020, 3:36 AM
thopre closed D72914: [FileCheck] Strengthen error checks in unit tests.
Jan 23 2020, 3:36 AM · Restricted Project

Jan 22 2020

thopre committed rGc42fe24754f4: [lld/ELF] PR44498: Support input filename in double quote (authored by thopre).
[lld/ELF] PR44498: Support input filename in double quote
Jan 22 2020, 4:08 AM
thopre closed D72517: [lld/ELF] PR44498: Support input filename in double quote.
Jan 22 2020, 4:07 AM · Restricted Project

Jan 21 2020

thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Address unit tests review comments

Jan 21 2020, 11:37 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Jan 21 2020, 11:37 AM · Restricted Project
thopre added inline comments to D72914: [FileCheck] Strengthen error checks in unit tests.
Jan 21 2020, 10:39 AM · Restricted Project
thopre updated the diff for D72914: [FileCheck] Strengthen error checks in unit tests.

Address all review comments but the location information

Jan 21 2020, 10:29 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Jan 21 2020, 2:02 AM · Restricted Project

Jan 20 2020

thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Address all review comments

Jan 20 2020, 3:41 PM · Restricted Project
thopre updated the diff for D72914: [FileCheck] Strengthen error checks in unit tests.

Add still missing error checks...

Jan 20 2020, 3:32 PM · Restricted Project
thopre updated the diff for D72914: [FileCheck] Strengthen error checks in unit tests.

Add missing error checks

Jan 20 2020, 3:14 PM · Restricted Project
thopre added inline comments to D72914: [FileCheck] Strengthen error checks in unit tests.
Jan 20 2020, 9:58 AM · Restricted Project
thopre updated the diff for D72914: [FileCheck] Strengthen error checks in unit tests.

Address all review comments but the substring match when expecting errors

Jan 20 2020, 9:58 AM · Restricted Project
thopre committed rGa81e0442bdb1: [FileCheck] Make Match unittest more flexible (authored by thopre).
[FileCheck] Make Match unittest more flexible
Jan 20 2020, 8:23 AM
thopre closed D72913: [FileCheck] Make Match unittest more flexible.
Jan 20 2020, 8:23 AM · Restricted Project
thopre committed rGabd0ab389ee3: [FileCheck] Clean and improve unit tests (authored by thopre).
[FileCheck] Clean and improve unit tests
Jan 20 2020, 7:59 AM
thopre closed D72912: [FileCheck] Clean and improve unit tests.
Jan 20 2020, 7:58 AM · Restricted Project
thopre updated the diff for D72913: [FileCheck] Make Match unittest more flexible.

Address review comments

Jan 20 2020, 5:49 AM · Restricted Project
thopre added inline comments to D72912: [FileCheck] Clean and improve unit tests.
Jan 20 2020, 4:17 AM · Restricted Project
thopre updated the diff for D72912: [FileCheck] Clean and improve unit tests.

Address review comments

Jan 20 2020, 4:17 AM · Restricted Project

Jan 17 2020

thopre added a comment to D68779: [LNT][NFC] Fix global import in function.

Committed as 10f1592ecb34bdbf2d7c62736aaf987df2fdd511

Jan 17 2020, 11:11 AM
thopre closed D68779: [LNT][NFC] Fix global import in function.
Jan 17 2020, 11:11 AM
thopre added a comment to D68779: [LNT][NFC] Fix global import in function.

Ping @cmatthews ?

Jan 17 2020, 5:13 AM
thopre added a child revision for D72914: [FileCheck] Strengthen error checks in unit tests: D60389: FileCheck [9/12]: Add support for matching formats.
Jan 17 2020, 3:57 AM · Restricted Project
thopre edited parent revisions for D60389: FileCheck [9/12]: Add support for matching formats, added: 1; removed: 1.
Jan 17 2020, 3:57 AM · Restricted Project
thopre removed a child revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D60389: FileCheck [9/12]: Add support for matching formats.
Jan 17 2020, 3:57 AM · Restricted Project
thopre added a parent revision for D72914: [FileCheck] Strengthen error checks in unit tests: D72913: [FileCheck] Make Match unittest more flexible.
Jan 17 2020, 3:57 AM · Restricted Project
thopre added a child revision for D72912: [FileCheck] Clean and improve unit tests: D72913: [FileCheck] Make Match unittest more flexible.
Jan 17 2020, 3:57 AM · Restricted Project
thopre added a parent revision for D72913: [FileCheck] Make Match unittest more flexible: D72912: [FileCheck] Clean and improve unit tests.
Jan 17 2020, 3:57 AM · Restricted Project
thopre added a parent revision for D72912: [FileCheck] Clean and improve unit tests: D64921: [FileCheck] Use ASSERT for fatal unit tests.
Jan 17 2020, 3:57 AM · Restricted Project
thopre added a child revision for D64921: [FileCheck] Use ASSERT for fatal unit tests: D72912: [FileCheck] Clean and improve unit tests.
Jan 17 2020, 3:57 AM · Restricted Project
thopre added a child revision for D72913: [FileCheck] Make Match unittest more flexible: D72914: [FileCheck] Strengthen error checks in unit tests.
Jan 17 2020, 3:57 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Jan 17 2020, 3:57 AM · Restricted Project
thopre created D72914: [FileCheck] Strengthen error checks in unit tests.
Jan 17 2020, 3:57 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.
  • Address unit tests review comments
  • fix casing of first letter in an error message
Jan 17 2020, 3:57 AM · Restricted Project
thopre created D72913: [FileCheck] Make Match unittest more flexible.
Jan 17 2020, 3:57 AM · Restricted Project
thopre created D72912: [FileCheck] Clean and improve unit tests.
Jan 17 2020, 3:51 AM · Restricted Project

Jan 16 2020

thopre updated the diff for D72517: [lld/ELF] PR44498: Support input filename in double quote.

Introduce StringMatcher.empty()

Jan 16 2020, 3:24 PM · Restricted Project
thopre added a comment to D72517: [lld/ELF] PR44498: Support input filename in double quote.

I think that adding extra flag to GlobPattern::create was better idea. Just set it to false by default, so that GlobPattern will still act as glob matcher for all other users:

static static Expected<GlobPattern> create(StringRef Pat, bool IgnoreMetaChars = false);

Than add extra constructor to StringMatcher to which you'll pass GlobPattern and use it from InputSectionDescription constructor.

Jan 16 2020, 3:13 PM · Restricted Project

Jan 14 2020

thopre added a comment to D72517: [lld/ELF] PR44498: Support input filename in double quote.
allows to fix a failure in ELF/linkerscript/filename-spec.s when the path contain a @ which the lexer consider as a special characters and thus break up a filename containing it.

Which one?

Jan 14 2020, 11:02 AM · Restricted Project
thopre updated the summary of D72517: [lld/ELF] PR44498: Support input filename in double quote.
Jan 14 2020, 10:51 AM · Restricted Project
thopre updated the diff for D72517: [lld/ELF] PR44498: Support input filename in double quote.
  • Make exact match at StringMatcher level
  • Add possibility to add new pattern to a StringMatcher
Jan 14 2020, 10:51 AM · Restricted Project

Jan 10 2020

thopre created D72517: [lld/ELF] PR44498: Support input filename in double quote.
Jan 10 2020, 9:13 AM · Restricted Project
thopre retitled D72517: [lld/ELF] PR44498: Support input filename in double quote from [lld/ELF] Support input filename in double quote to [lld/ELF] PR44498: Support input filename in double quote.
Jan 10 2020, 9:13 AM · Restricted Project
thopre added inline comments to D60386: FileCheck [6/12]: Introduce numeric variable definition.
Jan 10 2020, 2:35 AM · Restricted Project

Jan 9 2020

thopre added inline comments to D60386: FileCheck [6/12]: Introduce numeric variable definition.
Jan 9 2020, 6:56 AM · Restricted Project
thopre added a comment to D68779: [LNT][NFC] Fix global import in function.

Ping @cmatthews ?

Jan 9 2020, 5:01 AM

Jan 8 2020

thopre planned changes to D60391: FileCheck [11/12]: Add matching constraint specification.

Need to add unit tests

Jan 8 2020, 7:31 AM · Restricted Project
thopre planned changes to D60390: FileCheck [10/12]: Add support for signed numeric values.

Need to add unit tests

Jan 8 2020, 7:31 AM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase

Jan 8 2020, 7:31 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Jan 8 2020, 7:03 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Complete unit testing of changes in the patch

Jan 8 2020, 7:02 AM · Restricted Project
thopre requested review of D60389: FileCheck [9/12]: Add support for matching formats.

Is everybody happy with the constness changes to the ExpressionFormat operators and the new unit tests?

Jan 8 2020, 7:02 AM · Restricted Project

Jan 6 2020

thopre committed rGd8fd92eaaa34: [FileCheck] Remove FileCheck prefix in API (authored by thopre).
[FileCheck] Remove FileCheck prefix in API
Jan 6 2020, 2:35 PM
thopre closed D72186: [FileCheck] Remove FileCheck prefix in API.
Jan 6 2020, 2:35 PM · Restricted Project
thopre added a comment to D68054: Regex: Add static convenience functions for "match" and "sub".

How about the following commit message:

(...)

I would suggest an amendment to this part:

To force developers to be mindful of this aspect, an assert is added to match() to check
that the regex is valid and an new idiom is created as follows for
cases where the pattern is known to be valid:

As-is, this patch doesn't assert inside match(), since this makes the API more backwards compatible. The wording of the commit message should be updated to match this.

It was originally a bit tricky to track down and update all users of the API, but the monorepo makes that a lot easier. If we brought back the older version of the commit that *did* assert inside match(), and we updated all affected users of the API (eg: clang) before committing, I wouldn't be opposed.

Jan 6 2020, 1:11 PM · Restricted Project
thopre planned changes to D60389: FileCheck [9/12]: Add support for matching formats.

My apologies but I still think there's changes needed on this patch. I had changed the status earlier but I presume updating the patch did reset the status to "needs review". I haven't covered all the API changes in the unittests and I'd like to address the comment from Paul about the lack of clarity of which variables have implicit format conflict. I'm happy to deal with the latter in a separate patch if people are eager to have this change (I'm personally looking forward to it being committed as well) but I want to at least finish the unit testing.

Jan 6 2020, 7:11 AM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Use EXPECT_THAT_ERROR when testing for an error in unittest

Jan 6 2020, 5:41 AM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Jan 6 2020, 5:41 AM · Restricted Project
thopre updated the diff for D72186: [FileCheck] Remove FileCheck prefix in API.

Do not rename FileCheckPatternContext

Jan 6 2020, 3:21 AM · Restricted Project

Jan 3 2020

thopre created D72186: [FileCheck] Remove FileCheck prefix in API.
Jan 3 2020, 3:09 PM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase

Jan 3 2020, 1:49 PM · Restricted Project
thopre updated the diff for D60390: FileCheck [10/12]: Add support for signed numeric values.

Rebase

Jan 3 2020, 12:51 PM · Restricted Project
thopre added inline comments to D60389: FileCheck [9/12]: Add support for matching formats.
Jan 3 2020, 12:42 PM · Restricted Project
thopre updated the diff for D60389: FileCheck [9/12]: Add support for matching formats.

Address latest round of review comments

Jan 3 2020, 12:42 PM · Restricted Project
thopre updated the diff for D60391: FileCheck [11/12]: Add matching constraint specification.

Rebase

Jan 3 2020, 11:50 AM · Restricted Project