Page MenuHomePhabricator

thopre (Thomas Preud'homme)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 22 2017, 10:31 AM (186 w, 1 d)

Recent Activity

Today

walli99 awarded rLNT0b2c5df7a25c: Fix unexpected space around keyword/param equals a Heartbreak token.
Thu, Jun 17, 1:41 AM

Fri, Jun 11

thopre added a comment to D104099: [NewPM] Remove SpeculateAroundPHIs pass.

+1 for this change but being a downstream target only I prefer to let someone else approve this.

Fri, Jun 11, 5:56 AM · Restricted Project, Restricted Project

Fri, Jun 4

thopre committed rGd7e0948242b8: [test] Fix accidental match in parent_recurse_depth.s (authored by thopre).
[test] Fix accidental match in parent_recurse_depth.s
Fri, Jun 4, 3:23 AM
thopre closed D103676: [test] Fix accidental match in parent_recurse_depth.s.
Fri, Jun 4, 3:23 AM · Restricted Project
thopre added a comment to D103250: [llvm-dwarfdump][test] Add missing dedicated tests for some options.

I've created https://reviews.llvm.org/D103676

Fri, Jun 4, 2:00 AM · Restricted Project
thopre requested review of D103676: [test] Fix accidental match in parent_recurse_depth.s.
Fri, Jun 4, 2:00 AM · Restricted Project
thopre added a comment to D103250: [llvm-dwarfdump][test] Add missing dedicated tests for some options.

The test is a bit fragile as it fails if "main" is somewhere in the path of the object file created, which is likely with the development branch being called main (I personally use 1 git worktree per branch) or with the use of the term "mainline". How about the following change to consume the file name?

Fri, Jun 4, 1:53 AM · Restricted Project

Thu, Jun 3

thopre committed rG3d2c9069dcaf: [lit] Fix testing of standalone clang and lld builds (authored by jhenderson).
[lit] Fix testing of standalone clang and lld builds
Thu, Jun 3, 5:57 AM
thopre closed D103156: [lit] Fix testing of standalone clang and lld builds.
Thu, Jun 3, 5:57 AM · Restricted Project
thopre added inline comments to D102973: [ELF] Suppress GRP_COMDAT deduplication if the signature symbol is STB_LOCAL.
Thu, Jun 3, 4:27 AM · Restricted Project

Fri, May 28

Herald added a project to D37467: Add a new pass to speculate around PHI nodes with constant (integer) operands when profitable.: Restricted Project.

This pass does not seem to account for the extra branch instruction (1 for exiting the loop, 1 for looping back Vs 1 single branch when there's no critical edge) nor does it account for critical edge preventing the use of hardware loop instruction. The example that causes us trouble is:

Fri, May 28, 8:45 AM · Restricted Project
thopre accepted D103156: [lit] Fix testing of standalone clang and lld builds.

New change LGTM, provided @kwk confirms it works for him.

Fri, May 28, 4:35 AM · Restricted Project

Thu, May 27

thopre accepted D103156: [lit] Fix testing of standalone clang and lld builds.

LGTM

Thu, May 27, 1:42 AM · Restricted Project

Mon, May 24

thopre added inline comments to D102973: [ELF] Suppress GRP_COMDAT deduplication if the signature symbol is STB_LOCAL.
Mon, May 24, 2:29 AM · Restricted Project

Thu, May 20

thopre accepted D102694: [lit][gtest] Support SKIPPED tests.

LGTM then

Thu, May 20, 4:47 AM · Restricted Project, Restricted Project
thopre added inline comments to D102694: [lit][gtest] Support SKIPPED tests.
Thu, May 20, 2:01 AM · Restricted Project, Restricted Project

May 18 2021

thopre added a comment to D102630: [lit] Stop using PATH to lookup clang/lld/lldb unless requested.

@thopre - as an aside: It'd be helpful if you could include some text in the text box when marking something "approved" through phabricator. There's a bug/limitation that approvals without text don't produce email to the mailing list - so it looks like a patch hasn't been reviewed yet (or has been committed without review).

May 18 2021, 1:53 AM · Restricted Project, Restricted Project

May 17 2021

thopre accepted D102630: [lit] Stop using PATH to lookup clang/lld/lldb unless requested.
May 17 2021, 7:48 AM · Restricted Project, Restricted Project
thopre accepted D101982: [debuginfo-tests] Fix environment variable used to specify LLDB.

Still LGTM

May 17 2021, 3:11 AM · Restricted Project
thopre accepted D101997: [lld] Add a feature for each lld variant when use_lld is called.

LGTM

May 17 2021, 3:03 AM · Restricted Project

May 7 2021

thopre accepted D101997: [lld] Add a feature for each lld variant when use_lld is called.
May 7 2021, 1:45 AM · Restricted Project

May 6 2021

thopre added inline comments to D101997: [lld] Add a feature for each lld variant when use_lld is called.
May 6 2021, 8:39 AM · Restricted Project
thopre added inline comments to D101995: [lit] Allow specification of LLD variant paths via environment variable.
May 6 2021, 8:37 AM · Restricted Project
thopre accepted D101995: [lit] Allow specification of LLD variant paths via environment variable.
May 6 2021, 8:36 AM · Restricted Project
thopre accepted D101982: [debuginfo-tests] Fix environment variable used to specify LLDB.

Should we add a test for that?

We could add a lit test for the additional pass-through variables, if you think there's value in it (I don't think the other variables in the list are tested however), but I don't think we can test the lit.cfg.py change. To test that, we'd need to have a lit tests within the debuginfo-tests directory which spawns lit itself, with certain variables specified, and show that the right tools are used. I don't think this is practical. I've manually confirmed that the expected tools are used when the variables are set.

May 6 2021, 3:08 AM · Restricted Project
thopre added a comment to D101982: [debuginfo-tests] Fix environment variable used to specify LLDB.

Should we add a test for that?

May 6 2021, 2:34 AM · Restricted Project

May 5 2021

thopre accepted D101896: [lit] Report tool path from use_llvm_tool if found via env variable.

LGTM, thanks!

May 5 2021, 5:43 AM · Restricted Project
thopre added inline comments to D101896: [lit] Report tool path from use_llvm_tool if found via env variable.
May 5 2021, 4:57 AM · Restricted Project

Apr 27 2021

thopre added inline comments to D100226: [funcattrs] Add the maximal set of implied attributes to definitions.
Apr 27 2021, 6:59 AM · Restricted Project, Restricted Project
thopre added inline comments to D100226: [funcattrs] Add the maximal set of implied attributes to definitions.
Apr 27 2021, 6:50 AM · Restricted Project, Restricted Project

Apr 23 2021

thopre committed rG2fdedf905a6b: [doc] Clarify constrained fcmps behavior (authored by thopre).
[doc] Clarify constrained fcmps behavior
Apr 23 2021, 3:55 AM
thopre closed D101053: [doc] Clarify constrained fcmps behavior.
Apr 23 2021, 3:55 AM · Restricted Project

Apr 22 2021

thopre added a comment to D101053: [doc] Clarify constrained fcmps behavior.

The statement is now correct, but it's still not completely clear to me why it is necessary. All floating-point intrinsics may still produce a result in addition to raising an exception (if they do), so the definition of the result is always independent of the question what -if any- exceptions are raised. Why does this need to be called out here specifically?

Apr 22 2021, 2:33 PM · Restricted Project
thopre updated the diff for D101053: [doc] Clarify constrained fcmps behavior.

Fix clarification

Apr 22 2021, 7:06 AM · Restricted Project
thopre added a comment to D101053: [doc] Clarify constrained fcmps behavior.

I don't believe this change is correct. Note that even if an exception is raised, the instruction may still have a result (if exceptions are configured to only set a flag bit and not actually trap). This result will still be different for ordered vs. unordered comparisons.

Apr 22 2021, 6:01 AM · Restricted Project
thopre requested review of D101053: [doc] Clarify constrained fcmps behavior.
Apr 22 2021, 5:21 AM · Restricted Project

Apr 20 2021

thopre committed rGfd941036bf24: Fix PR46880: Fail CHECK-NOT with undefined variable (authored by thopre).
Fix PR46880: Fail CHECK-NOT with undefined variable
Apr 20 2021, 6:42 AM
thopre closed D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.
Apr 20 2021, 6:42 AM · Restricted Project
thopre committed rGd618c6e8ceb7: [lit, test] Fix test cancellation feature detection (authored by thopre).
[lit, test] Fix test cancellation feature detection
Apr 20 2021, 4:09 AM
thopre closed D99728: [lit, test] Fix test cancellation feature detection.
Apr 20 2021, 4:09 AM · Restricted Project
thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Rebase

Apr 20 2021, 4:08 AM · Restricted Project
thopre committed rG8cee150e9ac4: [C++, test] Fix typo in NSS* vars (authored by thopre).
[C++, test] Fix typo in NSS* vars
Apr 20 2021, 4:07 AM
thopre closed D99839: [C++, test] Fix typo in NSS* vars.
Apr 20 2021, 4:07 AM · Restricted Project
thopre updated the summary of D99839: [C++, test] Fix typo in NSS* vars.
Apr 20 2021, 4:06 AM · Restricted Project
thopre added inline comments to D99839: [C++, test] Fix typo in NSS* vars.
Apr 20 2021, 4:00 AM · Restricted Project
thopre updated the diff for D99839: [C++, test] Fix typo in NSS* vars.

Remove NSS2 variable since _Z8tnosplitIiEiv uses the same attribute as _Z3foov

Apr 20 2021, 4:00 AM · Restricted Project
thopre added inline comments to D99839: [C++, test] Fix typo in NSS* vars.
Apr 20 2021, 3:03 AM · Restricted Project
thopre added inline comments to D99728: [lit, test] Fix test cancellation feature detection.
Apr 20 2021, 1:40 AM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Remove debuging code now that test pass on Windows as well.

Apr 20 2021, 1:39 AM · Restricted Project
thopre added inline comments to D99839: [C++, test] Fix typo in NSS* vars.
Apr 20 2021, 1:37 AM · Restricted Project

Apr 19 2021

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

use sys.executable to find Python executable

Apr 19 2021, 8:21 AM · Restricted Project
thopre added inline comments to D99728: [lit, test] Fix test cancellation feature detection.
Apr 19 2021, 8:01 AM · Restricted Project
thopre added a comment to D99839: [C++, test] Fix typo in NSS* vars.

Ping?

Apr 19 2021, 2:47 AM · Restricted Project
thopre added reviewers for D99839: [C++, test] Fix typo in NSS* vars: ChuanqiXu, MaskRay, nmcintosh.
Apr 19 2021, 2:47 AM · Restricted Project

Apr 15 2021

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Print not found file's filename

Apr 15 2021, 1:09 PM · Restricted Project

Apr 14 2021

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Fix joining

Apr 14 2021, 2:06 PM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Use slash as path separator

Apr 14 2021, 1:12 PM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.
  • Use exception to see file
Apr 14 2021, 1:39 AM · Restricted Project

Apr 13 2021

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Add print statement

Apr 13 2021, 2:34 PM · Restricted Project

Apr 12 2021

thopre added a comment to D60392: FileCheck [12/12]: Support use of var defined on same line.

Status update: I've started manually rebasing this patch on top of latest FileCheck. Hopefully I'll update this diff in about 2 weeks. Sorry for the delay.

Apr 12 2021, 2:08 AM · Restricted Project

Apr 10 2021

thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Fix comment

Apr 10 2021, 1:47 PM · Restricted Project

Apr 9 2021

thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Rebase

Apr 9 2021, 7:07 AM · Restricted Project
thopre added a comment to D99839: [C++, test] Fix typo in NSS* vars.

Ping?

Apr 9 2021, 4:59 AM · Restricted Project
thopre committed rG0494b6b6769f: [PowerPC, test] Fix use of undef FileCheck var (authored by thopre).
[PowerPC, test] Fix use of undef FileCheck var
Apr 9 2021, 4:55 AM
thopre closed D99881: [PowerPC, test] Fix use of undef FileCheck var.
Apr 9 2021, 4:55 AM · Restricted Project
thopre committed rGbb69173ae5d1: [PowerPC, test] Fix use of undef FileCheck var (authored by thopre).
[PowerPC, test] Fix use of undef FileCheck var
Apr 9 2021, 4:54 AM
thopre closed D99870: [PowerPC, test] Fix use of undef FileCheck var.
Apr 9 2021, 4:54 AM · Restricted Project
thopre committed rG494ba60bb71e: [PowerPC, test] Fix use of undef FileCheck var (authored by thopre).
[PowerPC, test] Fix use of undef FileCheck var
Apr 9 2021, 4:10 AM
thopre closed D99868: [PowerPC, test] Fix use of undef FileCheck var.
Apr 9 2021, 4:09 AM · Restricted Project
thopre added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Thanks for all that work on the other tests! Still LGTM.

Apr 9 2021, 2:07 AM · Restricted Project
thopre committed rG623475248a9d: [test, LoopVectorize] Fix use of var defined in CHECK-NOT (authored by thopre).
[test, LoopVectorize] Fix use of var defined in CHECK-NOT
Apr 9 2021, 2:02 AM
thopre closed D99582: [test, LoopVectorize] Fix use of var defined in CHECK-NOT.
Apr 9 2021, 2:02 AM · Restricted Project

Apr 8 2021

thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Call script with python3 to not rely on it being executable

Apr 8 2021, 2:01 PM · Restricted Project
thopre committed rG5ca168b03211: [FileCheck, test] Rename checkWildcardRegexCharMatchFailure (authored by thopre).
[FileCheck, test] Rename checkWildcardRegexCharMatchFailure
Apr 8 2021, 1:58 PM
thopre closed D98343: [FileCheck, test] Rename checkWildcardRegexCharMatchFailure.
Apr 8 2021, 1:57 PM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Do rely on script being executable but not on Python 3.6 being in PATH, only Python3

Apr 8 2021, 3:56 AM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Do not rely on testing script being executable

Apr 8 2021, 3:54 AM · Restricted Project
thopre added a comment to D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

@jdenny I have no more changes to make to this patch and the CI is now green. Are you ok with the patch?

Apr 8 2021, 3:41 AM · Restricted Project
thopre updated the diff for D98343: [FileCheck, test] Rename checkWildcardRegexCharMatchFailure.

Rename function instead

Apr 8 2021, 3:39 AM · Restricted Project
thopre updated the diff for D99728: [lit, test] Fix test cancellation feature detection.

Simplify logic

Apr 8 2021, 3:27 AM · Restricted Project
thopre updated the diff for D86222: Fix PR46880: Fail CHECK-NOT with undefined variable.

Rebase

Apr 8 2021, 1:45 AM · Restricted Project
thopre committed rG04419628e011: [AMDGPU, test] Fix use of undef FileCheck var (authored by thopre).
[AMDGPU, test] Fix use of undef FileCheck var
Apr 8 2021, 1:43 AM
thopre closed D99865: [AMDGPU, test] Fix use of undef FileCheck var.
Apr 8 2021, 1:43 AM · Restricted Project

Apr 7 2021

thopre retitled D99865: [AMDGPU, test] Fix use of undef FileCheck var from [RFC, AMDGPU, test] Fix use of undef FileCheck var to [AMDGPU, test] Fix use of undef FileCheck var.
Apr 7 2021, 3:28 PM · Restricted Project
thopre updated the diff for D99865: [AMDGPU, test] Fix use of undef FileCheck var.

Remove directives instead

Apr 7 2021, 3:28 PM · Restricted Project
thopre added a comment to D99865: [AMDGPU, test] Fix use of undef FileCheck var.

It's really hard to write checks for R600, but it's in maintenance mode. The comment doesn't really make sense to me. I doubt this check was ever really correct or stable. You can't really write this test stably and expect specific things in T registers at a specific time. I guess just go with this is it passes?

Apr 7 2021, 2:51 PM · Restricted Project
thopre updated the summary of D99868: [PowerPC, test] Fix use of undef FileCheck var.
Apr 7 2021, 3:53 AM · Restricted Project
thopre committed rG73a7d451a2ca: [PowerPC, test] Fix use of undef FileCheck var (authored by thopre).
[PowerPC, test] Fix use of undef FileCheck var
Apr 7 2021, 1:45 AM
thopre closed D99880: [PowerPC, test] Fix use of undef FileCheck var.
Apr 7 2021, 1:45 AM · Restricted Project
thopre committed rGe018698bec36: [clang, test] Fix use of undef FileCheck var (authored by thopre).
[clang, test] Fix use of undef FileCheck var
Apr 7 2021, 1:44 AM
thopre closed D99898: [clang, test] Fix use of undef FileCheck var.
Apr 7 2021, 1:44 AM · Restricted Project
thopre committed rGb62c62c51973: [Coroutines, test] Fix use of var defined in CHECK-NOT (authored by thopre).
[Coroutines, test] Fix use of var defined in CHECK-NOT
Apr 7 2021, 1:43 AM
thopre closed D99856: [Coroutines, test] Fix use of var defined in CHECK-NOT.
Apr 7 2021, 1:43 AM · Restricted Project

Apr 6 2021

thopre committed rG3ba246719b7c: [test, AArch64] Fix use of var defined in CHECK-NOT (authored by thopre).
[test, AArch64] Fix use of var defined in CHECK-NOT
Apr 6 2021, 1:15 PM
thopre closed D99866: [test, AArch64] Fix use of var defined in CHECK-NOT.
Apr 6 2021, 1:15 PM · Restricted Project
thopre updated the diff for D99898: [clang, test] Fix use of undef FileCheck var.

Rename NUW_RN for CHECK-YES to NUW

Apr 6 2021, 1:12 PM · Restricted Project
thopre committed rG1d9d7f6a2c0f: [MLIR, test] Fix use of undef FileCheck var (authored by thopre).
[MLIR, test] Fix use of undef FileCheck var
Apr 6 2021, 12:08 PM
thopre closed D99957: [MLIR, test] Fix use of undef FileCheck var.
Apr 6 2021, 12:08 PM · Restricted Project
thopre added inline comments to D99866: [test, AArch64] Fix use of var defined in CHECK-NOT.
Apr 6 2021, 12:07 PM · Restricted Project
thopre updated the summary of D99898: [clang, test] Fix use of undef FileCheck var.
Apr 6 2021, 12:04 PM · Restricted Project