Page MenuHomePhabricator

[Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes
Needs ReviewPublic

Authored by ldionne on Mar 7 2022, 11:35 AM.

Details

Summary

This is a follow-up for https://reviews.llvm.org/D120160 that addresses some of the post-merge feedback.

Diff Detail

Event Timeline

egorzhdan created this revision.Mar 7 2022, 11:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2022, 11:35 AM
Herald added a subscriber: dang. · View Herald Transcript
egorzhdan requested review of this revision.Mar 7 2022, 11:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2022, 11:35 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ldionne commandeered this revision.Thu, Jun 30, 7:13 AM
ldionne edited reviewers, added: egorzhdan; removed: ldionne.

Thanks a lot for the fixes @egorzhdan! I think this looks pretty good. Since LLVM 15 is coming up and we'd like to have this in its final state for libc++ purposes, I'll commandeer this to make a couple adjustments and I'll merge this after seeking more feedback on the overall design. Thanks for doing all the work!

Thanks @egorzhdan for working on this, I seem to have overlooked this item in the review queue.
SGMT, but it seems the libc++ CI hasn't been triggered with this change. Maybe change one file in libc++ to give the CI a spin?

clang/docs/ClangCommandLineReference.rst
278

I'm not happy with the word "should", I don't want to decide what users should or should not do. Several of these experimental features are perfectly usable. If you can rebuild your entire software stack ABI and API stability might be less of an issue. (The lack of polish of some features might be a reason not to use them.)

clang/include/clang/Driver/Options.td
1167

Likewise regarding should.