Page MenuHomePhabricator
People abrachet

abrachet (Alex Brachet)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2019, 3:50 PM (200 w, 3 d)

Recent Activity
View All

Today

abrachet accepted D146343: [libc] Make string tests compatible with the Fuchsia build.
Mon, Mar 20, 8:42 AM · Restricted Project, Restricted Project

Thu, Mar 16

abrachet added a comment to D141222: [libc++] Use __verbose_abort instead of std::abort in __throw_ functions.
In D141222#4197878, @jgorbe wrote:

There's a comment next to the __libcpp_verbose_abort definition that says

// This function should never be called directly from the code -- it should only be called through
// the _LIBCPP_VERBOSE_ABORT macro.

Does this apply here? For context, we have a libc-free project that uses variant and optional and this change pulls in vfprintf. We'd like to just provide our own _LIBCPP_VERBOSE_ABORT, or build with -D_LIBCPP_HAS_NO_VERBOSE_ABORT_IN_LIBRARY but it doesn't look like we can do that if the code calls __libcpp_verbose_abort directly.

Thu, Mar 16, 4:28 PM · Restricted Project, Restricted Project

Mon, Mar 13

abrachet committed rGdf405dbfd316: [Driver] Make -X default for baremetal riscv (authored by abrachet).
[Driver] Make -X default for baremetal riscv
Mon, Mar 13, 10:18 PM · Restricted Project, Restricted Project
abrachet added a comment to D145725: [Driver] Make -X default for baremetal riscv.

Both comments addressed in commit

Mon, Mar 13, 10:18 PM · Restricted Project, Restricted Project
abrachet closed D145725: [Driver] Make -X default for baremetal riscv.
Mon, Mar 13, 10:18 PM · Restricted Project, Restricted Project

Sun, Mar 12

abrachet added a comment to D145771: [LICM] Support logical AND/OR when hoisting min/max.
In D145771#4187966, @mkazantsev wrote:

@abrachet if you can reproduce it in your env, could you please run it with -mllvm -print-before=sccp -mllvm -print-module-scope? The crash is obviously happening in a completely different pass, and it must be an existing bug. I see not enough ground for revert.

Sun, Mar 12, 10:11 PM · Restricted Project, Restricted Project

Fri, Mar 10

abrachet added a comment to D143726: [LICM] Simplify (X < A && X < B) into (X < MIN(A, B)) if MIN(A, B) is loop-invariant.

See assertion failures on this patch. https://storage.googleapis.com/fuchsia-artifacts/builds/8787007186219892481/build-debug/clang-crashreports/adler32-5bb726.c and https://storage.googleapis.com/fuchsia-artifacts/builds/8787007186219892481/build-debug/clang-crashreports/adler32-5bb726.sh for the reproducer. I tested locally and the failure goes away after reverting this change. Please take a look or revert if the fix will take a while.

Fri, Mar 10, 11:15 AM · Restricted Project, Restricted Project
abrachet added a comment to D145771: [LICM] Support logical AND/OR when hoisting min/max.

This patch is causing assertion failures. See reproducer https://storage.googleapis.com/fuchsia-artifacts/builds/8787011276367081201/sanitizer_libc-53f165.tar.gz, I checked and reverting made the issue go away. Would you mind taking a look or reverting if the fix will take a while?

clang-cl: /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:46: ConstantRange getConstantRange(const ValueLatticeElement &, Type *, bool): Assertion `Ty->isIntOrIntVectorTy() && "Should be int or int vector"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.      Program arguments: ./bin/clang-cl -cc1 -triple x86_64-pc-windows-msvc19.20.0 -emit-obj -mincremental-linker-compatible -disable-free -clear-ast-before-backend -main-file-name sanitizer_libc.cpp -mrelocation-model pic -pic-level 2 -mframe-pointer=none -relaxed-aliasing -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -mllvm -x86-asm-syntax=intel -tune-cpu generic -mllvm -treat-scalable-fixed-error-as-warning -D_MT -flto-visibility-public-std --dependent-lib=libcmt --dependent-lib=oldnames --show-includes -sys-header-deps -fno-rtti-data -fms-volatile -fdiagnostics-format msvc -gno-column-info -gcodeview -debug-info-kind=constructor -ffunction-sections -fdata-sections -fcoverage-compilation-dir=/opt/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-pc-windows-msvc-bins -D HAVE_RPC_XDR_H=0 -D UNICODE -D _CRT_NONSTDC_NO_DEPRECATE -D _CRT_NONSTDC_NO_WARNINGS -D _CRT_SECURE_NO_DEPRECATE -D _CRT_SECURE_NO_WARNINGS -D _GLIBCXX_ASSERTIONS -D _LIBCPP_ENABLE_ASSERTIONS -D _SCL_SECURE_NO_DEPRECATE -D _SCL_SECURE_NO_WARNINGS -D _UNICODE -D __STDC_CONSTANT_MACROS -D __STDC_FORMAT_MACROS -D __STDC_LIMIT_MACROS -O2 -Wno-unused-parameter -WCL4 -Wno-unused-parameter -Wthread-safety -Wthread-safety-reference -Wthread-safety-beta -Wno-gnu -Wno-variadic-macros -Wno-c99-extensions -Wno-format -Wframe-larger-than=570 -Wglobal-constructors -fdeprecated-macro -fdebug-compilation-dir=/opt/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-pc-windows-msvc-bins -ferror-limit 19 -fno-builtin -fno-use-cxa-atexit -fms-extensions -fms-compatibility -fms-compatibility-version=19.20 -std=c++17 -fno-threadsafe-statics -finline-hint-functions -vectorize-loops -vectorize-slp -faddrsig -object-file-name=/opt/s/w/ir/x/w/staging/llvm_build/runtimes/runtimes-x86_64-pc-windows-msvc-bins/compiler-rt/lib/sanitizer_common/CMakeFiles/RTSanitizerCommon.x86_64.dir/sanitizer_libc.cpp.obj -x c++ sanitizer_libc-53f165.cpp
1.      <eof> parser at end of file
2.      Optimizer
 #0 0x000055cf4353d4dd llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Support/Unix/Signals.inc:602:11
 #1 0x000055cf4353d96b PrintStackTraceSignalHandler(void*) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Support/Unix/Signals.inc:676:1
 #2 0x000055cf4353be96 llvm::sys::RunSignalHandlers() /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Support/Signals.cpp:104:5
 #3 0x000055cf4353df45 SignalHandler(int) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Support/Unix/Signals.inc:413:1
 #4 0x00007fa1f8af0f90 (/lib/x86_64-linux-gnu/libc.so.6+0x3bf90)
 #5 0x00007fa1f8b3fccc (/lib/x86_64-linux-gnu/libc.so.6+0x8accc)
 #6 0x00007fa1f8af0ef2 raise (/lib/x86_64-linux-gnu/libc.so.6+0x3bef2)
 #7 0x00007fa1f8adb472 abort (/lib/x86_64-linux-gnu/libc.so.6+0x26472)
 #8 0x00007fa1f8adb395 (/lib/x86_64-linux-gnu/libc.so.6+0x26395)
 #9 0x00007fa1f8ae9df2 (/lib/x86_64-linux-gnu/libc.so.6+0x34df2)
#10 0x000055cf420e7d30 getConstantRange(llvm::ValueLatticeElement const&, llvm::Type*, bool) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:47:7
#11 0x000055cf420ea330 llvm::SCCPInstVisitor::handleCallResult(llvm::CallBase&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:1666:18
#12 0x000055cf420e9b11 llvm::SCCPInstVisitor::visitCallBase(llvm::CallBase&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:1503:3
#13 0x000055cf420ff8ad llvm::SCCPInstVisitor::visitCallInst(llvm::CallInst&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:615:55
#14 0x000055cf420ff66d llvm::InstVisitor<llvm::SCCPInstVisitor, void>::visitIntrinsicInst(llvm::IntrinsicInst&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/InstVisitor.h:219:53
#15 0x000055cf420ff563 llvm::InstVisitor<llvm::SCCPInstVisitor, void>::delegateCallInst(llvm::CallInst&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/InstVisitor.h:287:36
#16 0x000055cf420eea4d llvm::InstVisitor<llvm::SCCPInstVisitor, void>::visitCall(llvm::CallInst&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/Instruction.def:209:1
#17 0x000055cf420f3ea9 llvm::InstVisitor<llvm::SCCPInstVisitor, void>::visit(llvm::Instruction&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/Instruction.def:209:1
#18 0x000055cf420f36ab llvm::SCCPInstVisitor::operandChangedState(llvm::Instruction*) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:515:3
#19 0x000055cf420edae0 llvm::SCCPInstVisitor::markUsersAsChanged(llvm::Value*) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:535:7
#20 0x000055cf420eaea3 llvm::SCCPInstVisitor::solve() /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:1708:5
#21 0x000055cf420eb70d llvm::SCCPSolver::solve() /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Utils/SCCPSolver.cpp:1888:46
#22 0x000055cf41ce2e96 runSCCP(llvm::Function&, llvm::DataLayout const&, llvm::TargetLibraryInfo const*, llvm::DomTreeUpdater&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Scalar/SCCP.cpp:85:5
#23 0x000055cf41ce2c70 llvm::SCCPPass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/Scalar/SCCP.cpp:131:7
#24 0x000055cf3f82e214 llvm::detail::PassModel<llvm::Function, llvm::SCCPPass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManagerInternal.h:89:17
#25 0x000055cf4304a2f7 llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManager.h:521:33
#26 0x000055cf3ab61a74 llvm::detail::PassModel<llvm::Function, llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManagerInternal.h:89:17
#27 0x000055cf4221af6d llvm::CGSCCToFunctionPassAdaptor::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Analysis/CGSCCPassManager.cpp:541:38
#28 0x000055cf3f83cbf4 llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::CGSCCToFunctionPassAdaptor, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManagerInternal.h:89:17
#29 0x000055cf422191e6 llvm::PassManager<llvm::LazyCallGraph::SCC, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Analysis/CGSCCPassManager.cpp:89:9
#30 0x000055cf3f7fb054 llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::PassManager<llvm::LazyCallGraph::SCC, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManagerInternal.h:89:17
#31 0x000055cf42219fb6 llvm::DevirtSCCRepeatedPass::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Analysis/CGSCCPassManager.cpp:411:9
#32 0x000055cf3f83e494 llvm::detail::PassModel<llvm::LazyCallGraph::SCC, llvm::DevirtSCCRepeatedPass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&>::run(llvm::LazyCallGraph::SCC&, llvm::AnalysisManager<llvm::LazyCallGraph::SCC, llvm::LazyCallGraph&>&, llvm::LazyCallGraph&, llvm::CGSCCUpdateResult&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManagerInternal.h:89:17
#33 0x000055cf42219afb llvm::ModuleToPostOrderCGSCCPassAdaptor::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Analysis/CGSCCPassManager.cpp:279:18
#34 0x000055cf3f7fb584 llvm::detail::PassModel<llvm::Module, llvm::ModuleToPostOrderCGSCCPassAdaptor, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManagerInternal.h:89:17
#35 0x000055cf43049617 llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManager.h:521:33
#36 0x000055cf404d51b8 llvm::ModuleInlinerWrapperPass::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/lib/Transforms/IPO/Inliner.cpp:1172:3
#37 0x000055cf3f8082d4 llvm::detail::PassModel<llvm::Module, llvm::ModuleInlinerWrapperPass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManagerInternal.h:89:17
#38 0x000055cf43049617 llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) /usr/local/google/home/abrachet/Developer/llvm-project/llvm/include/llvm/IR/PassManager.h:521:33
#39 0x000055cf3ab42b3b (anonymous namespace)::EmitAssemblyHelper::RunOptimizationPipeline(clang::BackendAction, std::__2::unique_ptr<llvm::raw_pwrite_stream, std::__2::default_delete<llvm::raw_pwrite_stream>>&, std::__2::unique_ptr<llvm::ToolOutputFile, std::__2::default_delete<llvm::ToolOutputFile>>&) /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/CodeGen/BackendUtil.cpp:1042:5
#40 0x000055cf3ab3de4f (anonymous namespace)::EmitAssemblyHelper::EmitAssembly(clang::BackendAction, std::__2::unique_ptr<llvm::raw_pwrite_stream, std::__2::default_delete<llvm::raw_pwrite_stream>>) /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/CodeGen/BackendUtil.cpp:1099:3
#41 0x000055cf3ab3d374 clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, llvm::IntrusiveRefCntPtr<llvm::vfs::FileSystem>, std::__2::unique_ptr<llvm::raw_pwrite_stream, std::__2::default_delete<llvm::raw_pwrite_stream>>) /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/CodeGen/BackendUtil.cpp:1265:17
#42 0x000055cf3b029c6a clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/CodeGen/CodeGenAction.cpp:383:7
#43 0x000055cf3ceec103 clang::ParseAST(clang::Sema&, bool, bool) /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/Parse/ParseAST.cpp:182:12
#44 0x000055cf3ae46e16 clang::ASTFrontendAction::ExecuteAction() /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/Frontend/FrontendAction.cpp:1170:1
#45 0x000055cf3b0254c4 clang::CodeGenAction::ExecuteAction() /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/CodeGen/CodeGenAction.cpp:1173:5
#46 0x000055cf3ae4685c clang::FrontendAction::Execute() /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/Frontend/FrontendAction.cpp:1062:7
#47 0x000055cf3ad71108 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/Frontend/CompilerInstance.cpp:1049:23
#48 0x000055cf3b015207 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) /usr/local/google/home/abrachet/Developer/llvm-project/clang/lib/FrontendTool/ExecuteCompilerInvocation.cpp:264:8
#49 0x000055cf39c7e281 cc1_main(llvm::ArrayRef<char const*>, char const*, void*) /usr/local/google/home/abrachet/Developer/llvm-project/clang/tools/driver/cc1_main.cpp:251:13
#50 0x000055cf39c73382 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&, llvm::ToolContext const&) /usr/local/google/home/abrachet/Developer/llvm-project/clang/tools/driver/driver.cpp:363:5
#51 0x000055cf39c72107 clang_main(int, char**, llvm::ToolContext const&) /usr/local/google/home/abrachet/Developer/llvm-project/clang/tools/driver/driver.cpp:441:5
#52 0x000055cf39f46e03 findTool(int, char**, char const*) /usr/local/google/home/abrachet/Developer/llvm-project/build/tools/llvm-driver/LLVMDriverTools.def:6:1
#53 0x000055cf39f469f9 main /usr/local/google/home/abrachet/Developer/llvm-project/llvm/tools/llvm-driver/llvm-driver.cpp:83:35
#54 0x00007fa1f8adc18a (/lib/x86_64-linux-gnu/libc.so.6+0x2718a)
#55 0x00007fa1f8adc245 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x27245)
#56 0x000055cf39bd9069 _start (./bin/clang-cl+0x5480069)
Fri, Mar 10, 9:30 AM · Restricted Project, Restricted Project

Thu, Mar 9

abrachet requested review of D145725: [Driver] Make -X default for baremetal riscv.
Thu, Mar 9, 1:01 PM · Restricted Project, Restricted Project
abrachet abandoned D145635: [ELF] Make --discard-locals default on riscv.
Thu, Mar 9, 12:02 PM · Restricted Project

Wed, Mar 8

abrachet updated the diff for D145635: [ELF] Make --discard-locals default on riscv.
Wed, Mar 8, 6:22 PM · Restricted Project
abrachet updated the diff for D145635: [ELF] Make --discard-locals default on riscv.
Wed, Mar 8, 6:20 PM · Restricted Project
abrachet requested review of D145635: [ELF] Make --discard-locals default on riscv.
Wed, Mar 8, 6:10 PM · Restricted Project
abrachet added inline comments to D145594: [libc] Add fenv_t and signal macros in riscv.
Wed, Mar 8, 9:55 AM · Restricted Project, Restricted Project
abrachet added a comment to D145560: [libc] Add riscv64 fenv implementation and enable the fenv.h functions..

This needs an fenv_t type in the public headers

Wed, Mar 8, 8:26 AM · Restricted Project, Restricted Project

Tue, Mar 7

abrachet committed rGd05093a7cf1f: [libc] Fix integer conversion error in test (authored by abrachet).
[libc] Fix integer conversion error in test
Tue, Mar 7, 9:50 AM · Restricted Project, Restricted Project

Fri, Mar 3

abrachet committed rG96ff21243eba: [libc] Fix strspn (authored by abrachet).
[libc] Fix strspn
Fri, Mar 3, 11:52 AM · Restricted Project, Restricted Project
abrachet committed rG92d3c3294ac4: [llvm-driver] Allow llvm driver binary to be called anything (authored by abrachet).
[llvm-driver] Allow llvm driver binary to be called anything
Fri, Mar 3, 11:45 AM · Restricted Project, Restricted Project

Wed, Mar 1

abrachet added inline comments to D144995: [libc] Fix strcspn.
Wed, Mar 1, 10:58 AM · Restricted Project, Restricted Project
abrachet committed rGc891ef6ca014: [libc] Fix strcspn (authored by abrachet).
[libc] Fix strcspn
Wed, Mar 1, 10:58 AM · Restricted Project, Restricted Project
abrachet closed D144995: [libc] Fix strcspn.
Wed, Mar 1, 10:58 AM · Restricted Project, Restricted Project
abrachet committed rG21fc42b2d594: [GWP-ASan][Fuchsia] Use more modern zxtest testing macros (authored by abrachet).
[GWP-ASan][Fuchsia] Use more modern zxtest testing macros
Wed, Mar 1, 10:54 AM · Restricted Project, Restricted Project
abrachet committed rGb27f657f89c6: [GWP-ASan] Stop using type aliases for ::testing:: types (authored by abrachet).
[GWP-ASan] Stop using type aliases for ::testing:: types
Wed, Mar 1, 10:53 AM · Restricted Project, Restricted Project

Tue, Feb 28

abrachet requested review of D144996: [libc] Add strcspn fuzz test.
Tue, Feb 28, 11:42 AM · Restricted Project
abrachet requested review of D144995: [libc] Fix strcspn.
Tue, Feb 28, 11:41 AM · Restricted Project, Restricted Project
abrachet committed rGf94fb2674805: [X86] Add DwarfRegNums for segment registers (authored by abrachet).
[X86] Add DwarfRegNums for segment registers
Tue, Feb 28, 9:10 AM · Restricted Project, Restricted Project
abrachet closed D144900: [X86] Add DwarfRegNums for segment registers.
Tue, Feb 28, 9:10 AM · Restricted Project, Restricted Project

Mon, Feb 27

abrachet added inline comments to D144900: [X86] Add DwarfRegNums for segment registers.
Mon, Feb 27, 12:34 PM · Restricted Project, Restricted Project
abrachet updated the diff for D144900: [X86] Add DwarfRegNums for segment registers.
Mon, Feb 27, 12:34 PM · Restricted Project, Restricted Project
abrachet requested review of D144900: [X86] Add DwarfRegNums for segment registers.
Mon, Feb 27, 11:20 AM · Restricted Project, Restricted Project

Sun, Feb 19

abrachet committed rGa489e11439e3: [Fuchsia] Use cleaner method of adding driver binary (authored by abrachet).
[Fuchsia] Use cleaner method of adding driver binary
Sun, Feb 19, 7:57 PM · Restricted Project, Restricted Project
abrachet committed rG6bb86689af7e: [Fuchsia] Fix driver build on Windows (authored by abrachet).
[Fuchsia] Fix driver build on Windows
Sun, Feb 19, 7:34 PM · Restricted Project, Restricted Project
abrachet committed rG55ab77d279a1: Reland "[Fuchsia] Enable llvm-driver build". (authored by abrachet).
Reland "[Fuchsia] Enable llvm-driver build".
Sun, Feb 19, 6:00 PM · Restricted Project, Restricted Project
abrachet committed rGa98cafd1d0f1: [CMake] Fix driver build on MacOS (authored by abrachet).
[CMake] Fix driver build on MacOS
Sun, Feb 19, 3:42 PM · Restricted Project, Restricted Project

Feb 17 2023

abrachet added a reverting change for rG4eadd19cc423: [Fuchsia] Enable llvm-driver build: rGc0f3ac1d0015: Revert "[Fuchsia] Enable llvm-driver build".
Feb 17 2023, 1:31 PM · Restricted Project, Restricted Project
abrachet committed rGc0f3ac1d0015: Revert "[Fuchsia] Enable llvm-driver build" (authored by abrachet).
Revert "[Fuchsia] Enable llvm-driver build"
Feb 17 2023, 1:31 PM · Restricted Project, Restricted Project
abrachet added a reverting change for D144287: [Fuchsia] Enable llvm-driver build: rGc0f3ac1d0015: Revert "[Fuchsia] Enable llvm-driver build".
Feb 17 2023, 1:30 PM · Restricted Project, Restricted Project
abrachet added inline comments to D144287: [Fuchsia] Enable llvm-driver build.
Feb 17 2023, 1:03 PM · Restricted Project, Restricted Project
abrachet committed rG4eadd19cc423: [Fuchsia] Enable llvm-driver build (authored by abrachet).
[Fuchsia] Enable llvm-driver build
Feb 17 2023, 1:03 PM · Restricted Project, Restricted Project
abrachet closed D144287: [Fuchsia] Enable llvm-driver build.
Feb 17 2023, 1:02 PM · Restricted Project, Restricted Project
abrachet requested review of D144287: [Fuchsia] Enable llvm-driver build.
Feb 17 2023, 11:22 AM · Restricted Project, Restricted Project

Feb 16 2023

abrachet committed rGd9a04d1d5453: [libc] Support running tests for Pigweed (authored by abrachet).
[libc] Support running tests for Pigweed
Feb 16 2023, 8:39 AM · Restricted Project, Restricted Project
abrachet closed D144146: [libc] Support running tests for Pigweed.
Feb 16 2023, 8:39 AM · Restricted Project, Restricted Project

Feb 15 2023

abrachet requested review of D144146: [libc] Support running tests for Pigweed.
Feb 15 2023, 4:40 PM · Restricted Project, Restricted Project

Feb 14 2023

abrachet committed rG87046744e6a8: [Driver] Allow test to use lld-link.exe not just lld-link (authored by abrachet).
[Driver] Allow test to use lld-link.exe not just lld-link
Feb 14 2023, 3:55 PM · Restricted Project, Restricted Project

Feb 13 2023

abrachet committed rGdf5beebc98bb: [Driver] Add --vfsoverlay flag (authored by abrachet).
[Driver] Add --vfsoverlay flag
Feb 13 2023, 9:26 AM · Restricted Project, Restricted Project
abrachet closed D141808: [Driver] Add --vfsoverlay flag.
Feb 13 2023, 9:25 AM · Restricted Project, Restricted Project

Feb 10 2023

abrachet committed rG043550e33509: [Driver] Stop stack use after free (authored by abrachet).
[Driver] Stop stack use after free
Feb 10 2023, 2:42 PM · Restricted Project, Restricted Project
abrachet committed rG3e57aa304f15: [llvm-driver] Reinvoke clang as described by llvm driver extra args (authored by abrachet).
[llvm-driver] Reinvoke clang as described by llvm driver extra args
Feb 10 2023, 11:43 AM · Restricted Project, Restricted Project, Restricted Project
abrachet committed rG1f173a0653e7: [llvm-driver] Pass extra arguments to tools (authored by abrachet).
[llvm-driver] Pass extra arguments to tools
Feb 10 2023, 11:42 AM · Restricted Project, Restricted Project, Restricted Project
abrachet closed D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args.
Feb 10 2023, 11:42 AM · Restricted Project, Restricted Project, Restricted Project
abrachet closed D137799: [llvm-driver] Pass extra arguments to tools.
Feb 10 2023, 11:42 AM · Restricted Project, Restricted Project, Restricted Project

Feb 8 2023

abrachet accepted D143556: [lit] Pass LLVM_PROFILE_FILE environment.
Feb 8 2023, 1:13 AM · Restricted Project, Restricted Project

Feb 1 2023

abrachet accepted D143092: [Driver][Fuchsia] Support --emit-static-lib in Fuchsia driver.
Feb 1 2023, 10:33 AM · Restricted Project, Restricted Project

Jan 31 2023

abrachet committed rGc53eff55e5b0: [llvm-ifs] Add support for --target=riscv (authored by abrachet).
[llvm-ifs] Add support for --target=riscv
Jan 31 2023, 9:32 AM · Restricted Project, Restricted Project

Jan 30 2023

abrachet committed rG6d9b0759c24e: [MC] Allow .pushsection between .cfi_startproc/.cfi_endproc (authored by abrachet).
[MC] Allow .pushsection between .cfi_startproc/.cfi_endproc
Jan 30 2023, 11:28 AM · Restricted Project, Restricted Project
abrachet closed D141893: [MC] Allow .pushsection between .cfi_startproc/.cfi_endproc.
Jan 30 2023, 11:28 AM · Restricted Project, Restricted Project
abrachet updated the diff for D141893: [MC] Allow .pushsection between .cfi_startproc/.cfi_endproc.
Jan 30 2023, 11:26 AM · Restricted Project, Restricted Project

Jan 26 2023

abrachet added inline comments to D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args.
Jan 26 2023, 6:26 PM · Restricted Project, Restricted Project, Restricted Project
abrachet updated the diff for D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args.
Jan 26 2023, 6:24 PM · Restricted Project, Restricted Project, Restricted Project
abrachet committed rG7aa27081e43f: [CMake] Remove libLTO from Fuchsia toolchain (authored by abrachet).
[CMake] Remove libLTO from Fuchsia toolchain
Jan 26 2023, 10:19 AM · Restricted Project, Restricted Project
abrachet closed D142649: [CMake] Remove libLTO from Fuchsia toolchain.
Jan 26 2023, 10:19 AM · Restricted Project, Restricted Project
abrachet requested review of D142649: [CMake] Remove libLTO from Fuchsia toolchain.
Jan 26 2023, 9:31 AM · Restricted Project, Restricted Project

Jan 25 2023

abrachet committed rG741021de3236: [libc] Implement strcasestr (authored by abrachet).
[libc] Implement strcasestr
Jan 25 2023, 9:59 AM · Restricted Project, Restricted Project
abrachet closed D142518: [libc] Implement strcasestr.
Jan 25 2023, 9:58 AM · Restricted Project, Restricted Project
abrachet committed rGc623a6865fde: [libc] Fix warning in ExecuteFunctionUnix.cpp (authored by abrachet).
[libc] Fix warning in ExecuteFunctionUnix.cpp
Jan 25 2023, 8:52 AM · Restricted Project, Restricted Project
abrachet committed rGeebb2e31b438: [libc] Templatize strstr (authored by abrachet).
[libc] Templatize strstr
Jan 25 2023, 8:43 AM · Restricted Project, Restricted Project
abrachet closed D142517: [libc] Templatize strstr.
Jan 25 2023, 8:43 AM · Restricted Project, Restricted Project

Jan 24 2023

abrachet updated subscribers of D142517: [libc] Templatize strstr.
Jan 24 2023, 4:28 PM · Restricted Project, Restricted Project
abrachet updated subscribers of D142518: [libc] Implement strcasestr.
Jan 24 2023, 4:28 PM · Restricted Project, Restricted Project
abrachet requested review of D142518: [libc] Implement strcasestr.
Jan 24 2023, 4:27 PM · Restricted Project, Restricted Project
abrachet requested review of D142517: [libc] Templatize strstr.
Jan 24 2023, 4:27 PM · Restricted Project, Restricted Project

Jan 20 2023

abrachet added inline comments to D142154: [libc][NFC] Replace static inline and inline annotations with LIBC_INLINE..
Jan 20 2023, 3:02 PM · Restricted Project, Restricted Project

Jan 19 2023

abrachet committed rG67bd3c58c0c7: [X86] Add register definitions for cfi directives (authored by abrachet).
[X86] Add register definitions for cfi directives
Jan 19 2023, 6:11 AM · Restricted Project, Restricted Project
abrachet closed D141879: [X86] Add register definitions for cfi directives.
Jan 19 2023, 6:11 AM · Restricted Project, Restricted Project
abrachet updated the diff for D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args.

Use correct diff

Jan 19 2023, 6:08 AM · Restricted Project, Restricted Project, Restricted Project
abrachet updated the diff for D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args.
Jan 19 2023, 6:06 AM · Restricted Project, Restricted Project, Restricted Project

Jan 18 2023

abrachet updated the diff for D137800: [llvm-driver] Reinvoke clang as described by llvm driver extra args.

Support -canoncial-prefixes

Jan 18 2023, 11:53 AM · Restricted Project, Restricted Project, Restricted Project

Jan 17 2023

abrachet updated the diff for D141893: [MC] Allow .pushsection between .cfi_startproc/.cfi_endproc.
Jan 17 2023, 12:15 PM · Restricted Project, Restricted Project
abrachet committed rG6be602f79cbf: [scudo] Fix -Wsign-compare warning (authored by abrachet).
[scudo] Fix -Wsign-compare warning
Jan 17 2023, 9:03 AM · Restricted Project, Restricted Project
abrachet updated the diff for D141808: [Driver] Add --vfsoverlay flag.
Jan 17 2023, 8:36 AM · Restricted Project, Restricted Project
abrachet updated the diff for D141893: [MC] Allow .pushsection between .cfi_startproc/.cfi_endproc.
Jan 17 2023, 8:31 AM · Restricted Project, Restricted Project

Jan 16 2023

abrachet requested review of D141893: [MC] Allow .pushsection between .cfi_startproc/.cfi_endproc.
Jan 16 2023, 10:33 PM · Restricted Project, Restricted Project
abrachet added inline comments to D141879: [X86] Add register definitions for cfi directives.
Jan 16 2023, 5:46 PM · Restricted Project, Restricted Project
abrachet updated the diff for D141879: [X86] Add register definitions for cfi directives.
Jan 16 2023, 5:46 PM · Restricted Project, Restricted Project
abrachet requested review of D141879: [X86] Add register definitions for cfi directives.
Jan 16 2023, 4:40 PM · Restricted Project, Restricted Project

Jan 15 2023

abrachet requested review of D141808: [Driver] Add --vfsoverlay flag.
Jan 15 2023, 3:33 PM · Restricted Project, Restricted Project

Jan 13 2023

abrachet added a comment to D140039: [LSAN] More LSAN interface tweaking..

Hmm, the update I did to lsan_common_fuchsia.cpp is fine for clang_rt.lsan, but unfortunately it breaks clang_rt.asan. I'm pretty sure adding lsan_thread.cpp to LSAN_COMMON_SOURCES is wrong, but it isn't even tenable because then clang_rt.asan gets multiple definition errors between lsan_thread.cpp and asan_thread.cpp. I'm wondering what the best way to go about this is? In lsan we want to use GetLsanThreadRegistryLocked but in asan we want GetAsanThreadRegistryLocked instead. Though this seems erroneous. Do folks have any other suggestions?

Jan 13 2023, 11:26 AM · Restricted Project, Restricted Project
abrachet added a reverting change for rG0c60ec699fc1: [clang-scan-deps] Migrate to OptTable: rG521554a7eeea: Revert "[clang-scan-deps] Migrate to OptTable".
Jan 13 2023, 10:18 AM · Restricted Project, Restricted Project, Restricted Project
abrachet committed rG521554a7eeea: Revert "[clang-scan-deps] Migrate to OptTable" (authored by abrachet).
Revert "[clang-scan-deps] Migrate to OptTable"
Jan 13 2023, 10:18 AM · Restricted Project, Restricted Project, Restricted Project
abrachet added a reverting change for D139949: [clang-scan-deps] Migrate to OptTable: rG521554a7eeea: Revert "[clang-scan-deps] Migrate to OptTable".
Jan 13 2023, 10:18 AM · Restricted Project, Restricted Project, Restricted Project
abrachet added inline comments to D139949: [clang-scan-deps] Migrate to OptTable.
Jan 13 2023, 10:12 AM · Restricted Project, Restricted Project, Restricted Project
abrachet committed rG0c60ec699fc1: [clang-scan-deps] Migrate to OptTable (authored by abrachet).
[clang-scan-deps] Migrate to OptTable
Jan 13 2023, 10:12 AM · Restricted Project, Restricted Project, Restricted Project
abrachet closed D139949: [clang-scan-deps] Migrate to OptTable.
Jan 13 2023, 10:12 AM · Restricted Project, Restricted Project, Restricted Project

Jan 12 2023

abrachet added a comment to D140039: [LSAN] More LSAN interface tweaking..
In D140039#4049719, @thakis wrote:

Looks like this doesn't build on Windows: http://45.33.8.238/win/73274/step_4.txt

Please take a look and revert for now if it takes a while to fix.

Jan 12 2023, 5:28 PM · Restricted Project, Restricted Project
abrachet committed rGf001e50f955c: [lsan] Fix build for Fuchsia after D140039 (authored by abrachet).
[lsan] Fix build for Fuchsia after D140039
Jan 12 2023, 4:48 PM · Restricted Project, Restricted Project

Jan 11 2023

abrachet committed rGdf87e62cbd4b: [GWP-ASan] Fix 6413872 (authored by abrachet).
[GWP-ASan] Fix 6413872
Jan 11 2023, 3:44 PM · Restricted Project, Restricted Project
abrachet committed rG64138725e4cf: [GWP-ASan] Fix test to work with Fuchsia's zxtest (authored by abrachet).
[GWP-ASan] Fix test to work with Fuchsia's zxtest
Jan 11 2023, 3:17 PM · Restricted Project, Restricted Project

Jan 10 2023

abrachet committed rGe9d571d3b682: [libc] Implement str{,n}casecmp (authored by abrachet).
[libc] Implement str{,n}casecmp
Jan 10 2023, 9:39 PM · Restricted Project, Restricted Project
abrachet closed D141236: [libc] Implement str{,n}casecmp.
Jan 10 2023, 9:39 PM · Restricted Project, Restricted Project