Page MenuHomePhabricator

abrachet (Alex Brachet)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2019, 3:50 PM (158 w, 1 d)

Recent Activity

Today

abrachet accepted D126582: [scudo] Clean up Zircon header file uses.
Fri, May 27, 7:17 PM · Restricted Project, Restricted Project
abrachet added a reverting change for rG684c08010876: [Clang] Extend -gen-reproducer flag: rG4dc3893eeb47: Revert "[Clang] Extend -gen-reproducer flag".
Fri, May 27, 10:04 AM · Restricted Project, Restricted Project
abrachet committed rG4dc3893eeb47: Revert "[Clang] Extend -gen-reproducer flag" (authored by abrachet).
Revert "[Clang] Extend -gen-reproducer flag"
Fri, May 27, 10:04 AM · Restricted Project, Restricted Project
abrachet added a reverting change for D120201: [Clang] Extend -gen-reproducer flag: rG4dc3893eeb47: Revert "[Clang] Extend -gen-reproducer flag".
Fri, May 27, 10:04 AM · Restricted Project, Restricted Project
abrachet added inline comments to D120201: [Clang] Extend -gen-reproducer flag.
Fri, May 27, 8:51 AM · Restricted Project, Restricted Project
abrachet committed rG684c08010876: [Clang] Extend -gen-reproducer flag (authored by abrachet).
[Clang] Extend -gen-reproducer flag
Fri, May 27, 8:50 AM · Restricted Project, Restricted Project
abrachet closed D120201: [Clang] Extend -gen-reproducer flag.
Fri, May 27, 8:50 AM · Restricted Project, Restricted Project
abrachet requested review of D126548: [InstrProf] Stop exporting lprofDirMode.
Fri, May 27, 8:05 AM · Restricted Project

Yesterday

abrachet added inline comments to D126499: [scudo] Ensure pointer is not null.
Thu, May 26, 2:37 PM · Restricted Project
abrachet requested review of D126499: [scudo] Ensure pointer is not null.
Thu, May 26, 2:02 PM · Restricted Project

Wed, May 25

abrachet added inline comments to D120201: [Clang] Extend -gen-reproducer flag.
Wed, May 25, 10:59 AM · Restricted Project, Restricted Project
abrachet updated the diff for D120201: [Clang] Extend -gen-reproducer flag.
Wed, May 25, 10:59 AM · Restricted Project, Restricted Project
abrachet added a comment to D125800: [COFF] Add vfsoverlay flag.

This seems reasonable to me, but surely this is not the complete list of places where we must use the VFS?

Wed, May 25, 9:35 AM · Restricted Project
abrachet updated the diff for D125800: [COFF] Add vfsoverlay flag.

Fix test on windows

Wed, May 25, 9:33 AM · Restricted Project

Tue, May 24

abrachet added inline comments to D126329: [libc] Add global stdout and stderr objects..
Tue, May 24, 5:30 PM · Restricted Project, Restricted Project
abrachet added a comment to D120201: [Clang] Extend -gen-reproducer flag.

This patch no longer depends on D122335 which created the reproducer as a tar file. Now this will just emit the crash reproduction information as usual, but under other circumstances given the value of -femit-reproducer.

Thanks, I think the current functionality makes sense to me, and the patch seems very focused now.

My only high-level comment is that it seems this overlaps with the existing -gen-reproducer flag and FORCE_CLANG_DIAGNOSTICS_CRASH environment variable. Could the new functionality be implemented as new arguments to the existing flag/variable?

Tue, May 24, 4:35 PM · Restricted Project, Restricted Project
abrachet updated the diff for D120201: [Clang] Extend -gen-reproducer flag.
Tue, May 24, 4:34 PM · Restricted Project, Restricted Project

Mon, May 23

abrachet committed rG8725dc5e2f73: [libc][docs] Use same formatting for headers in source_layout (authored by abrachet).
[libc][docs] Use same formatting for headers in source_layout
Mon, May 23, 2:48 PM · Restricted Project, Restricted Project
abrachet closed D126211: [libc][docs] Use same formatting for headers in source_layout.
Mon, May 23, 2:48 PM · Restricted Project, Restricted Project
abrachet requested review of D126211: [libc][docs] Use same formatting for headers in source_layout.
Mon, May 23, 8:14 AM · Restricted Project, Restricted Project
abrachet abandoned D122335: [clang] Emit crash reproduction as a single tar file.
Mon, May 23, 8:04 AM · Restricted Project
abrachet updated the diff for D120201: [Clang] Extend -gen-reproducer flag.

This patch no longer depends on D122335 which created the reproducer as a tar file. Now this will just emit the crash reproduction information as usual, but under other circumstances given the value of -femit-reproducer.

Mon, May 23, 8:03 AM · Restricted Project, Restricted Project

Sat, May 21

abrachet added a comment to rGdf46fb40557a: Test C DR conformance (part one of many).
Sat, May 21, 1:13 PM · Restricted Project, Restricted Project
abrachet added a comment to rGdf46fb40557a: Test C DR conformance (part one of many).

We are seeing test failures see for example https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8813529725139260241/overview https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b8813529727054945089/overview https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8813529725592813073/overview

Sat, May 21, 1:11 PM · Restricted Project, Restricted Project

Fri, May 20

abrachet committed rG190b0f42cf55: [lld-macho] Stop crash when emitting personalities with -dead_strip (authored by abrachet).
[lld-macho] Stop crash when emitting personalities with -dead_strip
Fri, May 20, 2:41 PM · Restricted Project
abrachet closed D126072: [lld-macho] Stop crash when emitting personalities with -dead_strip.
Fri, May 20, 2:41 PM · Restricted Project, Restricted Project, Restricted Project
abrachet updated the diff for D126072: [lld-macho] Stop crash when emitting personalities with -dead_strip.
Fri, May 20, 2:38 PM · Restricted Project, Restricted Project, Restricted Project
abrachet added inline comments to D126072: [lld-macho] Stop crash when emitting personalities with -dead_strip.
Fri, May 20, 2:35 PM · Restricted Project, Restricted Project, Restricted Project
abrachet updated the diff for D126072: [lld-macho] Stop crash when emitting personalities with -dead_strip.

Make a test that tests some functionality.

Fri, May 20, 2:35 PM · Restricted Project, Restricted Project, Restricted Project
abrachet committed rG480dcdc8975d: [ifs] Switch to using OptTable (authored by abrachet).
[ifs] Switch to using OptTable
Fri, May 20, 8:29 AM · Restricted Project, Restricted Project
abrachet closed D125658: [ifs] Switch to using OptTable.
Fri, May 20, 8:29 AM · Restricted Project, Restricted Project
abrachet requested review of D126072: [lld-macho] Stop crash when emitting personalities with -dead_strip.
Fri, May 20, 8:12 AM · Restricted Project, Restricted Project, Restricted Project

Thu, May 19

abrachet committed rGc3856cb7398e: [bazel][libc] Fix bazel build (authored by abrachet).
[bazel][libc] Fix bazel build
Thu, May 19, 3:59 PM · Restricted Project
abrachet closed D126028: [bazel][libc] Fix bazel build.
Thu, May 19, 3:59 PM · Restricted Project, Restricted Project
abrachet updated the diff for D126028: [bazel][libc] Fix bazel build.
Thu, May 19, 3:51 PM · Restricted Project, Restricted Project
abrachet requested review of D126028: [bazel][libc] Fix bazel build.
Thu, May 19, 3:44 PM · Restricted Project, Restricted Project
abrachet committed rGb1183305f882: [libc] Add strlcat (authored by abrachet).
[libc] Add strlcat
Thu, May 19, 2:49 PM · Restricted Project, Restricted Project
abrachet closed D125978: [libc] Add strlcat.
Thu, May 19, 2:48 PM · Restricted Project, Restricted Project
abrachet updated the diff for D125978: [libc] Add strlcat.
Thu, May 19, 2:46 PM · Restricted Project, Restricted Project
abrachet added inline comments to D125978: [libc] Add strlcat.
Thu, May 19, 12:07 PM · Restricted Project, Restricted Project
abrachet requested review of D125978: [libc] Add strlcat.
Thu, May 19, 8:08 AM · Restricted Project, Restricted Project

Wed, May 18

abrachet committed rG6adbcd2b102e: [libc] Add String to bsd headers (authored by abrachet).
[libc] Add String to bsd headers
Wed, May 18, 11:01 AM · Restricted Project, Restricted Project
abrachet committed rGfc2c8b2371d7: [libc] Add strlcpy (authored by abrachet).
[libc] Add strlcpy
Wed, May 18, 10:46 AM · Restricted Project, Restricted Project
abrachet closed D125806: [libc] Add strlcpy.
Wed, May 18, 10:45 AM · Restricted Project, Restricted Project
abrachet accepted D125908: [CMake][Fuchsia] Build runtimes as universal libraries on OS X.
Wed, May 18, 10:30 AM · Restricted Project, Restricted Project

Tue, May 17

abrachet updated the diff for D125806: [libc] Add strlcpy.
Tue, May 17, 5:20 PM · Restricted Project, Restricted Project
abrachet added a comment to D125658: [ifs] Switch to using OptTable.

I've added @MaskRay as he's done a number of cl::opt -> OptTable transitions in other tools.

One thing I haven't done yet is ensure that all old options are still present in the new tool. A task for later (or someone else).

Tue, May 17, 11:39 AM · Restricted Project, Restricted Project
abrachet updated the diff for D125658: [ifs] Switch to using OptTable.
Tue, May 17, 11:27 AM · Restricted Project, Restricted Project
abrachet requested review of D125806: [libc] Add strlcpy.
Tue, May 17, 9:31 AM · Restricted Project, Restricted Project
abrachet requested review of D125800: [COFF] Add vfsoverlay flag.
Tue, May 17, 8:31 AM · Restricted Project

Sun, May 15

abrachet requested review of D125658: [ifs] Switch to using OptTable.
Sun, May 15, 8:56 PM · Restricted Project, Restricted Project

Sat, May 14

abrachet committed rGa74d9e74e5f9: [ifs] Add --strip-size flag (authored by abrachet).
[ifs] Add --strip-size flag
Sat, May 14, 11:51 AM · Restricted Project, Restricted Project
abrachet updated the diff for D124792: [ifs] Add --strip-size flag.

Fix unittests

Sat, May 14, 11:49 AM · Restricted Project, Restricted Project
abrachet added a reverting change for rGb6b0fd6a940b: [ifs] Add --strip-size flag: rG1f6126084764: Revert "[ifs] Add --strip-size flag".
Sat, May 14, 10:34 AM · Restricted Project, Restricted Project
abrachet committed rG1f6126084764: Revert "[ifs] Add --strip-size flag" (authored by abrachet).
Revert "[ifs] Add --strip-size flag"
Sat, May 14, 10:34 AM · Restricted Project, Restricted Project
abrachet added a reverting change for D124792: [ifs] Add --strip-size flag: rG1f6126084764: Revert "[ifs] Add --strip-size flag".
Sat, May 14, 10:34 AM · Restricted Project, Restricted Project
abrachet committed rGb6b0fd6a940b: [ifs] Add --strip-size flag (authored by abrachet).
[ifs] Add --strip-size flag
Sat, May 14, 10:26 AM · Restricted Project, Restricted Project
abrachet closed D124792: [ifs] Add --strip-size flag.
Sat, May 14, 10:26 AM · Restricted Project, Restricted Project

Fri, May 13

abrachet updated the diff for D124792: [ifs] Add --strip-size flag.
Fri, May 13, 11:41 AM · Restricted Project, Restricted Project

Tue, May 10

abrachet added inline comments to D124792: [ifs] Add --strip-size flag.
Tue, May 10, 6:56 PM · Restricted Project, Restricted Project
abrachet updated the diff for D124792: [ifs] Add --strip-size flag.
Tue, May 10, 6:51 PM · Restricted Project, Restricted Project

Wed, May 4

abrachet added a comment to D124901: [libc][NFC] Instantiate templates with less verbosity.

in the premerge checks it looks like several tests are failing with this patch, could you look into that?

Wed, May 4, 2:06 PM · Restricted Project
abrachet updated the diff for D124901: [libc][NFC] Instantiate templates with less verbosity.

Fix build at O3

Wed, May 4, 2:05 PM · Restricted Project

Tue, May 3

abrachet requested review of D124901: [libc][NFC] Instantiate templates with less verbosity.
Tue, May 3, 9:21 PM · Restricted Project
abrachet added a comment to D124792: [ifs] Add --strip-size flag.

I'd like to see an llvm-ifs Command Guide document wtitten sooner rather than later, since all llvm tools should have one. Please look at doing this soon.

Tue, May 3, 9:23 AM · Restricted Project, Restricted Project
abrachet added a reviewer for D124792: [ifs] Add --strip-size flag: jhenderson.
Tue, May 3, 9:23 AM · Restricted Project, Restricted Project
abrachet updated the diff for D124792: [ifs] Add --strip-size flag.
Tue, May 3, 9:21 AM · Restricted Project, Restricted Project

Mon, May 2

abrachet requested review of D124792: [ifs] Add --strip-size flag.
Mon, May 2, 11:25 AM · Restricted Project, Restricted Project
abrachet committed rG7aaad7b18322: [ifs] Fix bug where exclude only excluded when outputting ifs files (authored by abrachet).
[ifs] Fix bug where exclude only excluded when outputting ifs files
Mon, May 2, 10:49 AM · Restricted Project, Restricted Project
abrachet closed D124781: [ifs] Fix bug where exclude only excluded when outputting ifs files.
Mon, May 2, 10:49 AM · Restricted Project, Restricted Project
abrachet abandoned D123010: [asan] Emit .size directive for global object size before redzone.

Hi folks wanted to update here why this was breaking.

Mon, May 2, 10:22 AM · Restricted Project, Restricted Project
abrachet requested review of D124781: [ifs] Fix bug where exclude only excluded when outputting ifs files.
Mon, May 2, 10:05 AM · Restricted Project, Restricted Project

Thu, Apr 28

abrachet added a comment to D120201: [Clang] Extend -gen-reproducer flag.

D122335 was a requested feature for emitting reproducers as a single tar file, but it seems to have stalled. What do folks think about moving forward with this patch without emitting the reproducer as a tar file?

Thu, Apr 28, 2:34 PM · Restricted Project, Restricted Project

Apr 26 2022

abrachet accepted D124468: [libc] Minor test signedness fixes.
Apr 26 2022, 10:41 AM · Restricted Project, Restricted Project

Apr 25 2022

abrachet added a comment to D124411: [ELF] Add --vfs[overlay|replace] flags to change library search behavior.

My gut feeling is that the options are poorly specified and I am unsure why we suddenly need new mechanisms like this in the linker.

Apr 25 2022, 8:07 PM · Restricted Project
abrachet requested review of D124411: [ELF] Add --vfs[overlay|replace] flags to change library search behavior.
Apr 25 2022, 12:29 PM · Restricted Project

Apr 21 2022

abrachet committed rG365c3e85bced: [docs] Fix underline (authored by abrachet).
[docs] Fix underline
Apr 21 2022, 2:06 PM · Restricted Project, Restricted Project
abrachet committed rG78a784bea443: [asan] Emit .size directive for global object size before redzone (authored by abrachet).
[asan] Emit .size directive for global object size before redzone
Apr 21 2022, 1:47 PM · Restricted Project, Restricted Project
abrachet closed D123010: [asan] Emit .size directive for global object size before redzone.
Apr 21 2022, 1:47 PM · Restricted Project, Restricted Project
abrachet committed rGd8c1d37ba37d: [fuchsia] Don't include duplicate profiling symbols for Fuchsia (authored by tmandry).
[fuchsia] Don't include duplicate profiling symbols for Fuchsia
Apr 21 2022, 8:45 AM · Restricted Project, Restricted Project
abrachet closed D124136: [fuchsia] Don't include duplicate profiling symbols for Fuchsia.
Apr 21 2022, 8:44 AM · Restricted Project, Restricted Project

Apr 19 2022

abrachet accepted D124053: [CMake][Fuchsia] Include find-all-symbols in the distribution.
Apr 19 2022, 4:57 PM · Restricted Project, Restricted Project

Apr 18 2022

abrachet abandoned D123906: [CMake][Fuchsia] Include fewer targets in stage 1 build.

This won't work for the cross-compilation case where the stage 1 compiler is used to build stage 2 runtimes (since stage 2 compiler is cross-compiled and cannot be used on the host). We would need some other mechanism to handle that use case.

Apr 18 2022, 2:41 PM · Restricted Project
abrachet added a comment to D122335: [clang] Emit crash reproduction as a single tar file.

Ping :)

Apr 18 2022, 9:18 AM · Restricted Project
abrachet abandoned D76676: [libc] Unblock SIGABRT before raising in abort.
Apr 18 2022, 8:49 AM · Restricted Project
abrachet abandoned D85407: [libc][NFC] Fix build when using UBSan.
Apr 18 2022, 8:48 AM · Restricted Project
abrachet abandoned D64568: [NFC] Update header files to inclue language tags like -*- C++ -*-.
Apr 18 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project
abrachet abandoned D116679: [libc] Allow regex in entrypoint list.
Apr 18 2022, 8:47 AM · Restricted Project
abrachet abandoned D121769: [libc][test] Wait on child processes in all cases.
Apr 18 2022, 8:46 AM · Restricted Project
abrachet updated the diff for D123010: [asan] Emit .size directive for global object size before redzone.

Remove assert

Apr 18 2022, 8:42 AM · Restricted Project, Restricted Project

Apr 16 2022

abrachet requested review of D123906: [CMake][Fuchsia] Include fewer targets in stage 1 build.
Apr 16 2022, 5:01 PM · Restricted Project

Apr 14 2022

abrachet updated the diff for D123010: [asan] Emit .size directive for global object size before redzone.
Apr 14 2022, 10:47 AM · Restricted Project, Restricted Project
abrachet added inline comments to D123010: [asan] Emit .size directive for global object size before redzone.
Apr 14 2022, 10:29 AM · Restricted Project, Restricted Project
abrachet updated the diff for D123010: [asan] Emit .size directive for global object size before redzone.
Apr 14 2022, 10:29 AM · Restricted Project, Restricted Project
abrachet updated the diff for D123010: [asan] Emit .size directive for global object size before redzone.

Verify !explicit_size on GlobalValues

Apr 14 2022, 9:59 AM · Restricted Project, Restricted Project

Apr 13 2022

abrachet added a comment to D121560: [clang][Opt] Add NoArgUnusedWith to not warn for unused redundant options.

If you need a -static-libstdc++ not subject to unused argument warning, --start-no-unused-arguments and D53238 (-static=c++stdlib) may be better choices.

Apr 13 2022, 9:38 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 10 2022

abrachet added inline comments to D123010: [asan] Emit .size directive for global object size before redzone.
Apr 10 2022, 10:24 PM · Restricted Project, Restricted Project
abrachet updated the diff for D123010: [asan] Emit .size directive for global object size before redzone.

Address comments

Apr 10 2022, 10:20 PM · Restricted Project, Restricted Project

Apr 8 2022

abrachet updated the diff for D123010: [asan] Emit .size directive for global object size before redzone.

Update docs and commit message

Apr 8 2022, 10:33 AM · Restricted Project, Restricted Project
abrachet added a comment to D122335: [clang] Emit crash reproduction as a single tar file.

Ping :)

Apr 8 2022, 8:36 AM · Restricted Project