Page MenuHomePhabricator

var-const (Konstantin Varlamov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2021, 1:52 PM (13 w, 6 d)

Recent Activity

Thu, Jan 13

var-const committed rGb6d87773feef: [libc++] LWG3171: implement operator<< for filesystem::directory_entry. (authored by var-const).
[libc++] LWG3171: implement operator<< for filesystem::directory_entry.
Thu, Jan 13, 8:44 PM
var-const closed D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..
Thu, Jan 13, 8:44 PM · Restricted Project
var-const added inline comments to D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..
Thu, Jan 13, 7:21 PM · Restricted Project
var-const updated the diff for D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..
  • change GitHub links to LLVM links;
  • make the directory_entry used in tests const.
Thu, Jan 13, 7:19 PM · Restricted Project

Wed, Jan 12

var-const added inline comments to D117044: [libc++] [ranges] Implement ranges::cdata.
Wed, Jan 12, 7:11 PM · Restricted Project
var-const committed rGb9bc3c107c6c: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`. (authored by var-const).
[libc++][ranges] Implement `construct_at` and `destroy{,_at}`.
Wed, Jan 12, 4:02 PM
var-const closed D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..
Wed, Jan 12, 4:01 PM · Restricted Project
var-const updated the diff for D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..

Replace the use of concepts in the construct_at test with SFINAE. While
construct_at requires C++20, older compiler versions might not implement
concepts in that mode.

Wed, Jan 12, 2:33 PM · Restricted Project
var-const added a reverting change for rG9e634b35ff51: [libc++] Temporarily disable the in_out_result test on Fuchsia.: rG57092f87b233: Revert "[libc++] Temporarily disable the in_out_result test on Fuchsia.".
Wed, Jan 12, 1:11 PM
var-const committed rG57092f87b233: Revert "[libc++] Temporarily disable the in_out_result test on Fuchsia." (authored by var-const).
Revert "[libc++] Temporarily disable the in_out_result test on Fuchsia."
Wed, Jan 12, 1:11 PM
var-const added a comment to rG9e634b35ff51: [libc++] Temporarily disable the in_out_result test on Fuchsia..

I think this change should be reverted, we aren't yet running libc++ tests on Fuchsia so this change doesn't take any effect.

Wed, Jan 12, 1:52 AM
var-const added a comment to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Hopefully fixed by commit fe958b140ab37acf316f5b98318e75ba2119d5a2.

Wed, Jan 12, 1:51 AM · Restricted Project
var-const committed rGfe958b140ab3: [libc++] Quick fix to remove a narrowing conversion from the in_out_result test. (authored by var-const).
[libc++] Quick fix to remove a narrowing conversion from the in_out_result test.
Wed, Jan 12, 1:50 AM
var-const closed D117089: [libc++] Quick fix to remove a narrowing conversion from the in_out_result test..
Wed, Jan 12, 1:50 AM · Restricted Project

Tue, Jan 11

var-const added a comment to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

@vvereschaka @uabelho I'll submit a quick fix today after https://reviews.llvm.org/D117089 passes CI.

Tue, Jan 11, 10:32 PM · Restricted Project
var-const requested review of D117089: [libc++] Quick fix to remove a narrowing conversion from the in_out_result test..
Tue, Jan 11, 10:29 PM · Restricted Project
var-const added a comment to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

@vvereschaka, @uabelho Thanks for the error messages! I'll prepare a fix ASAP.

Tue, Jan 11, 9:52 PM · Restricted Project
var-const accepted D117043: [libc++] [ranges] Fix a missing auto(x) cast in ranges::data..
Tue, Jan 11, 7:32 PM · Restricted Project, Restricted Project
var-const accepted D117044: [libc++] [ranges] Implement ranges::cdata.

LGTM (modulo the one agreed-upon style nitpick).

Tue, Jan 11, 7:19 PM · Restricted Project
var-const updated the diff for D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..

Fix CI (part 3).

Tue, Jan 11, 7:10 PM · Restricted Project
var-const added a comment to D117044: [libc++] [ranges] Implement ranges::cdata.

Can you also update docs/Status/RangesPaper.csv?

Tue, Jan 11, 3:54 PM · Restricted Project
var-const added inline comments to D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..
Tue, Jan 11, 3:32 PM · Restricted Project
var-const updated the diff for D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..

Fix the test.

Tue, Jan 11, 3:31 PM · Restricted Project
var-const updated the diff for D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..

Fix CI.

Tue, Jan 11, 3:27 PM · Restricted Project
var-const added a comment to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

@gulfem The test should be disabled on Fuchsia by commit 9e634b35ff51d0eb2b38013111491e88bdbae388.

Tue, Jan 11, 3:08 PM · Restricted Project
var-const committed rG9e634b35ff51: [libc++] Temporarily disable the in_out_result test on Fuchsia. (authored by var-const).
[libc++] Temporarily disable the in_out_result test on Fuchsia.
Tue, Jan 11, 3:06 PM
var-const added a comment to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Would you mind reverting it unless the issue can be fixed quickly?

Tue, Jan 11, 2:48 PM · Restricted Project
var-const added a comment to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

This patch seems to break the Fuchsia builds.

Failed Tests (1):
  libc++ :: std/algorithms/algorithms.results/in_out_result.pass.cpp

https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8825352420796900577/+/u/clang/test/stdout

This is the link to the cmake commands:
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8825352420796900577/+/u/clang/configure/execution_details

Tue, Jan 11, 2:47 PM · Restricted Project
var-const retitled D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry. from [libc++] Implement operator<< for filesystem::directory_entry. to [libc++] LWG3171: implement operator<< for filesystem::directory_entry..
Tue, Jan 11, 9:24 AM · Restricted Project
var-const added inline comments to D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..
Tue, Jan 11, 9:17 AM · Restricted Project
var-const updated the diff for D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..

Address feedback

Tue, Jan 11, 9:17 AM · Restricted Project
var-const updated the diff for D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..

Fix CI.

Tue, Jan 11, 9:14 AM · Restricted Project
var-const updated the diff for D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..

Fix CI.

Tue, Jan 11, 1:19 AM · Restricted Project

Mon, Jan 10

var-const updated the diff for D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..

Rebase

Mon, Jan 10, 11:13 PM · Restricted Project
var-const committed rG8d23b7420c92: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{… (authored by var-const).
[libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{…
Mon, Jan 10, 10:50 PM
var-const closed D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..
Mon, Jan 10, 10:50 PM · Restricted Project
var-const added a comment to D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..

Please mention [LWG3171] in the commit subject line, and update Cxx2bIssues.csv. Otherwise, seems reasonable to me % comments.

Mon, Jan 10, 9:59 PM · Restricted Project
var-const updated the diff for D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..

Address feedback.

Mon, Jan 10, 9:59 PM · Restricted Project
var-const added inline comments to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..
Mon, Jan 10, 9:18 PM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Address feedback.

Mon, Jan 10, 9:17 PM · Restricted Project

Fri, Jan 7

var-const accepted D116569: [libc++] [ranges] Add namespace __cpo to ranges::{advance,next,prev}..

LGTM.

Fri, Jan 7, 11:01 PM · Restricted Project
var-const added a comment to D116569: [libc++] [ranges] Add namespace __cpo to ranges::{advance,next,prev}..

@var-const: is this now good to go, as far as you're concerned?

Fri, Jan 7, 3:22 AM · Restricted Project

Tue, Jan 4

var-const added inline comments to D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..
Tue, Jan 4, 8:39 PM · Restricted Project
var-const requested review of D116642: [libc++] LWG3171: implement operator<< for filesystem::directory_entry..
Tue, Jan 4, 8:32 PM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Fix CI on Windows.

Tue, Jan 4, 8:05 PM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Fix CI.

Tue, Jan 4, 1:23 PM · Restricted Project
var-const added inline comments to D116569: [libc++] [ranges] Add namespace __cpo to ranges::{advance,next,prev}..
Tue, Jan 4, 1:18 PM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Rebase on main.

Tue, Jan 4, 9:48 AM · Restricted Project
var-const added a comment to D116570: [libc++] Eliminate the `__function_like` helper..

(quoting comments from the previous discussion in the other patch)

Tue, Jan 4, 9:42 AM · Restricted Project
var-const requested changes to D116569: [libc++] [ranges] Add namespace __cpo to ranges::{advance,next,prev}..

The main intention of the patch very much LGTM, but some formatting nitpicks. Please let me know if I'm missing something.

Tue, Jan 4, 9:20 AM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Fix CI.

Tue, Jan 4, 9:12 AM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Run libcxx-generate-files.

Tue, Jan 4, 12:22 AM · Restricted Project

Sun, Jan 2

var-const added inline comments to D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..
Sun, Jan 2, 11:02 PM · Restricted Project
var-const updated the diff for D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..
  • rebase on main and fix the commit history;
  • add a TODO to test array support in construct_at.
Sun, Jan 2, 11:01 PM · Restricted Project
var-const added inline comments to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..
Sun, Jan 2, 10:32 PM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..
  • Use a different branch which is correctly based on main. The previous branch's history was unfortunately broken;
  • address feedback.
Sun, Jan 2, 10:31 PM · Restricted Project

Wed, Dec 22

var-const accepted D116198: [libc++] [test] [NFC] Flatten the directory structure a bit.
Wed, Dec 22, 5:47 PM · Restricted Project

Tue, Dec 21

var-const added inline comments to D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..
Tue, Dec 21, 8:12 PM · Restricted Project
var-const updated the diff for D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..

Address feedback.

Tue, Dec 21, 8:12 PM · Restricted Project

Mon, Dec 20

var-const updated the diff for D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..

Use the actual revision number on status pages.

Mon, Dec 20, 9:08 PM · Restricted Project
var-const requested review of D116078: [libc++][ranges] Implement `construct_at` and `destroy{,_at}`..
Mon, Dec 20, 9:06 PM · Restricted Project

Dec 20 2021

var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Rebase on main.

Dec 20 2021, 5:45 PM · Restricted Project
var-const added inline comments to D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..
Dec 20 2021, 5:09 PM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..
  • add tests for in_out_result;
  • add tests for conversions;
  • address feedback.
Dec 20 2021, 5:05 PM · Restricted Project
var-const updated subscribers of D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..
Dec 20 2021, 12:32 PM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Update status docs.

Dec 20 2021, 12:32 PM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Small fixes.

Dec 20 2021, 12:27 PM · Restricted Project
var-const updated the diff for D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..

Fix C++03 mode.

Dec 20 2021, 2:23 AM · Restricted Project
var-const requested review of D116023: [libc++][ranges] Implement `uninitialized_copy{,_n}` and `uninitialized_move{,_n}`..
Dec 20 2021, 2:21 AM · Restricted Project
var-const committed rG754ea6fd4d52: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and… (authored by var-const).
[libc++][ranges] Implement `uninitialized_value_construct{,_n}` and…
Dec 20 2021, 12:25 AM
var-const closed D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..
Dec 20 2021, 12:24 AM · Restricted Project

Dec 19 2021

var-const updated the diff for D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..

Make destroy_at strictly conforming in C++17, rebase on main.

Dec 19 2021, 9:05 PM · Restricted Project

Dec 16 2021

var-const updated the diff for D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..

Fix CI.

Dec 16 2021, 8:45 PM · Restricted Project
var-const updated the diff for D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..

Fix CI, fix and update the status page.

Dec 16 2021, 6:54 PM · Restricted Project
var-const updated the diff for D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..

Fix the CI (don't use C++14 and C++17 features in C++11 mode)

Dec 16 2021, 2:53 PM · Restricted Project
var-const committed rGf195fd915ebd: [libc++][ranges][NFC] Remove extraneous cleanup checks. (authored by var-const).
[libc++][ranges][NFC] Remove extraneous cleanup checks.
Dec 16 2021, 2:48 PM
var-const closed D115839: [libc++][ranges][NFC] Remove extraneous cleanup checks..
Dec 16 2021, 2:48 PM · Restricted Project

Dec 15 2021

var-const updated the diff for D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..

Fix compilation

Dec 15 2021, 8:15 PM · Restricted Project
var-const added a comment to D115588: [libcxx][test] Verify customization point object properties.

I may slightly prefer having the helper and just use it each test, but don't feel strongly. Arguably, for a "new" (not-yet-implemented CPO like the ones commented out here), it's just as easy to forget to call test_cpo (or whatever we call the helper function template). For the existing, but not-yet-implemented CPOs, this one file approach at least is a gentle TODO for "uncomment me when it's implemented". But, you need to know about the file in the first place from git-grepping around.

Thoughts @Quuxplusone @var-const or others?

Dec 15 2021, 7:36 PM · Restricted Project
var-const requested review of D115839: [libc++][ranges][NFC] Remove extraneous cleanup checks..
Dec 15 2021, 7:21 PM · Restricted Project
var-const added inline comments to D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..
Dec 15 2021, 6:52 PM · Restricted Project
var-const updated the diff for D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..

Run clang-format on newly-added files.

Dec 15 2021, 6:51 PM · Restricted Project
var-const updated the diff for D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..
  • address feedback;
  • run libcxx-generate-files;
  • rebase on main.
Dec 15 2021, 6:44 PM · Restricted Project

Dec 14 2021

var-const updated the diff for D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..

Address feedback, rebase on main.

Dec 14 2021, 5:00 PM · Restricted Project
var-const updated subscribers of D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..
Dec 14 2021, 4:59 PM · Restricted Project
var-const added inline comments to D115730: [libc++] Add a helper class to write code with the strong exception guarantee.
Dec 14 2021, 4:10 PM · Restricted Project
var-const committed rG3f630cff65fc: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}. (authored by var-const).
[libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}.
Dec 14 2021, 2:12 PM
var-const closed D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}..
Dec 14 2021, 2:12 PM · Restricted Project
var-const added inline comments to D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}..
Dec 14 2021, 11:30 AM · Restricted Project
var-const updated the diff for D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}..

Address feedback, try to fix the CI.

Dec 14 2021, 11:29 AM · Restricted Project
var-const added inline comments to D115730: [libc++] Add a helper class to write code with the strong exception guarantee.
Dec 14 2021, 10:53 AM · Restricted Project

Dec 13 2021

var-const added inline comments to D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}..
Dec 13 2021, 9:20 PM · Restricted Project
var-const updated the diff for D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}..

Review feedback

Dec 13 2021, 9:20 PM · Restricted Project
var-const added inline comments to D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}..
Dec 13 2021, 12:57 PM · Restricted Project
var-const updated the summary of D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}..
Dec 13 2021, 12:56 PM · Restricted Project
var-const updated the diff for D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}..

Review feedback

Dec 13 2021, 12:55 PM · Restricted Project
var-const added a comment to D115588: [libcxx][test] Verify customization point object properties.

Generally LGTM, but consider adding the new tests either to existing test files or to a single new test file devoted to verifying customization points.

Dec 13 2021, 10:39 AM · Restricted Project
var-const requested review of D115626: [libc++][ranges] Implement `uninitialized_value_construct{,_n}` and `uninitialized_fill{,_n}`..
Dec 13 2021, 4:03 AM · Restricted Project

Dec 12 2021

var-const updated the diff for D115315: [libc++][ranges] Implement ranges::uninitialized_default_construct{,_n}..

Fix CI (?) and rebase on main.

Dec 12 2021, 12:40 AM · Restricted Project
var-const committed rG805488358a8c: [libc++][ranges] Add subsumption tests to `[special.mem.concepts]`. (authored by var-const).
[libc++][ranges] Add subsumption tests to `[special.mem.concepts]`.
Dec 12 2021, 12:38 AM