• change GitHub links to LLVM links;
• make the directory_entry used in tests const.

Replace the use of concepts in the construct_at test with SFINAE. While
construct_at requires C++20, older compiler versions might not implement
concepts in that mode.

In rG9e634b35ff51d0eb2b38013111491e88bdbae388#1050254, @phosek wrote:

I think this change should be reverted, we aren't yet running libc++ tests on Fuchsia so this change doesn't take any effect.

Hopefully fixed by commit fe958b140ab37acf316f5b98318e75ba2119d5a2.

@vvereschaka @uabelho I'll submit a quick fix today after https://reviews.llvm.org/D117089 passes CI.

@vvereschaka, @uabelho Thanks for the error messages! I'll prepare a fix ASAP.

LGTM (modulo the one agreed-upon style nitpick).

Fix CI (part 3).

Can you also update docs/Status/RangesPaper.csv?

Fix the test.

Fix CI.

@gulfem The test should be disabled on Fuchsia by commit 9e634b35ff51d0eb2b38013111491e88bdbae388.

In D116023#3235538, @gulfem wrote:

Would you mind reverting it unless the issue can be fixed quickly?

In D116023#3234931, @gulfem wrote:

This patch seems to break the Fuchsia builds.

Failed Tests (1):
  libc++ :: std/algorithms/algorithms.results/in_out_result.pass.cpp

https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8825352420796900577/+/u/clang/test/stdout

This is the link to the cmake commands:
https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8825352420796900577/+/u/clang/configure/execution_details

Address feedback

Fix CI.

Fix CI.

Rebase

In D116642#3225747, @Quuxplusone wrote:

Please mention [LWG3171] in the commit subject line, and update Cxx2bIssues.csv. Otherwise, seems reasonable to me % comments.

Address feedback.

Address feedback.

LGTM.

In D116569#3225533, @Quuxplusone wrote:

@var-const: is this now good to go, as far as you're concerned?

Fix CI on Windows.

Fix CI.

Rebase on main.

(quoting comments from the previous discussion in the other patch)

The main intention of the patch very much LGTM, but some formatting nitpicks. Please let me know if I'm missing something.

Fix CI.

Run libcxx-generate-files.

• rebase on main and fix the commit history;
• add a TODO to test array support in construct_at.

• Use a different branch which is correctly based on main. The previous branch's history was unfortunately broken;
• address feedback.

Address feedback.

Use the actual revision number on status pages.

Rebase on main.

• add tests for in_out_result;
• add tests for conversions;
• address feedback.

Update status docs.

Small fixes.

Fix C++03 mode.

Make destroy_at strictly conforming in C++17, rebase on main.

Fix CI.

Fix CI, fix and update the status page.

Fix the CI (don't use C++14 and C++17 features in C++11 mode)

Fix compilation

I may slightly prefer having the helper and just use it each test, but don't feel strongly. Arguably, for a "new" (not-yet-implemented CPO like the ones commented out here), it's just as easy to forget to call test_cpo (or whatever we call the helper function template). For the existing, but not-yet-implemented CPOs, this one file approach at least is a gentle TODO for "uncomment me when it's implemented". But, you need to know about the file in the first place from git-grepping around.

Thoughts @Quuxplusone @var-const or others?

Run clang-format on newly-added files.

• address feedback;
• run libcxx-generate-files;
• rebase on main.

Address feedback, rebase on main.

Address feedback, try to fix the CI.

Review feedback

Review feedback

Generally LGTM, but consider adding the new tests either to existing test files or to a single new test file devoted to verifying customization points.

Fix CI (?) and rebase on main.