Page MenuHomePhabricator

var-const (Konstantin Varlamov)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 14 2021, 1:52 PM (68 w, 4 d)

Recent Activity

Thu, Feb 2

var-const requested review of D143245: [libc++] In tests, use `abort` to terminate upon an error..
Thu, Feb 2, 11:58 PM · Restricted Project, Restricted Project
var-const committed rG78f17b2a98e9: [libc++][format] Fix a missing include in tests. (authored by var-const).
[libc++][format] Fix a missing include in tests.
Thu, Feb 2, 11:57 PM · Restricted Project, Restricted Project
var-const committed rGd1e066dd8bf0: [libc++] Make some tests in `math_nodiscard_extensions` Clang-only. (authored by varconst <varconsteq@gmail.com>).
[libc++] Make some tests in `math_nodiscard_extensions` Clang-only.
Thu, Feb 2, 11:31 PM · Restricted Project, Restricted Project
var-const closed D143033: [libc++] Make some tests in `math_nodiscard_extensions` Clang-only..
Thu, Feb 2, 11:30 PM · Restricted Project, Restricted Project
var-const updated the diff for D143033: [libc++] Make some tests in `math_nodiscard_extensions` Clang-only..

Address feedback

Thu, Feb 2, 11:30 AM · Restricted Project, Restricted Project
var-const retitled D143033: [libc++] Make some tests in `math_nodiscard_extensions` Clang-only. from [libc++] Disable some tests in `math_nodiscard_extensions`. to [libc++] Make some tests in `math_nodiscard_extensions` Clang-only..
Thu, Feb 2, 10:28 AM · Restricted Project, Restricted Project
var-const updated the diff for D143033: [libc++] Make some tests in `math_nodiscard_extensions` Clang-only..

Address feedback

Thu, Feb 2, 10:27 AM · Restricted Project, Restricted Project

Wed, Feb 1

var-const added a comment to D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

@alexfh @asbirlea @rupprecht Thank you for calling this out. Added notes about potential breakages of existing code to the release notes in https://github.com/llvm/llvm-project/commit/abda3e523ade7377b03a25dc2b6192dbe855c567

Wed, Feb 1, 3:55 PM · Restricted Project, Restricted Project
var-const closed D142873: [libc++][NFC] Update the libc++ release notes for LLVM 16..

Looks like Phabricator doesn't automatically close this review for some reason (probably it only monitors commits to main?), but this has been merged to release/16.x (https://github.com/llvm/llvm-project/commit/abda3e523ade7377b03a25dc2b6192dbe855c567). Closing manually.

Wed, Feb 1, 3:53 PM · Restricted Project, Restricted Project
var-const added a comment to D143033: [libc++] Make some tests in `math_nodiscard_extensions` Clang-only..

No, this also applies to the non-__builtin_ versions. The math functions are declared at about line 1200 (currently).

Wed, Feb 1, 11:48 AM · Restricted Project, Restricted Project
var-const added a comment to D140824: [libc++] Forward ranges::sort to instantiations in the dylib.

@philnik Thank you for the clean-up!

Wed, Feb 1, 11:29 AM · Restricted Project, Restricted Project

Tue, Jan 31

var-const added a comment to D143033: [libc++] Make some tests in `math_nodiscard_extensions` Clang-only..

It's not exactly documentation, but you can look at clang/include/clang/Basic/Builtins.def to see what attributes are applied to builtins and what builtins there are.

Tue, Jan 31, 11:12 PM · Restricted Project, Restricted Project
var-const added a comment to D143033: [libc++] Make some tests in `math_nodiscard_extensions` Clang-only..

These are marked [[gnu::const]] through clang though. That's why these are regex matchers, not simple text versions.

Tue, Jan 31, 4:54 PM · Restricted Project, Restricted Project
var-const requested review of D143033: [libc++] Make some tests in `math_nodiscard_extensions` Clang-only..
Tue, Jan 31, 4:48 PM · Restricted Project, Restricted Project
var-const updated the diff for D142951: [libc++][ranges] Fix incorrect integer typedef in `elements_view` test..

Feedback

Tue, Jan 31, 3:28 PM · Restricted Project, Restricted Project
var-const updated subscribers of D142873: [libc++][NFC] Update the libc++ release notes for LLVM 16..

@tstellar We would like to merge this patch into the releases/16.x branch. It's a minor change to update the libc++ release notes for the LLVM 16 release, and it can't be merged into main because main has already switched to release notes for the 17 release. Please let me know if it's okay for me to go ahead and merge it. This patch has been approved by @ldionne. Thanks!

Tue, Jan 31, 3:12 PM · Restricted Project, Restricted Project

Mon, Jan 30

var-const requested review of D142951: [libc++][ranges] Fix incorrect integer typedef in `elements_view` test..
Mon, Jan 30, 7:47 PM · Restricted Project, Restricted Project
var-const published D142873: [libc++][NFC] Update the libc++ release notes for LLVM 16. for review.
Mon, Jan 30, 12:51 AM · Restricted Project, Restricted Project
var-const committed rGc2b3986e39bc: [libc++][ranges] Temporarily mark `ranges::join_view` as experimental. (authored by varconst <varconsteq@gmail.com>).
[libc++][ranges] Temporarily mark `ranges::join_view` as experimental.
Mon, Jan 30, 12:36 AM · Restricted Project, Restricted Project
var-const closed D142520: [libc++][ranges] Temporarily mark `ranges::join_view` as experimental..
Mon, Jan 30, 12:36 AM · Restricted Project, Restricted Project
var-const abandoned D130695: [libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`.
Mon, Jan 30, 12:33 AM · Restricted Project, Restricted Project
var-const committed rGfdb709be7b50: [libc++] Fix some missed `return 0` statements in test `main` functions. (authored by var-const).
[libc++] Fix some missed `return 0` statements in test `main` functions.
Mon, Jan 30, 12:31 AM · Restricted Project, Restricted Project

Fri, Jan 27

var-const updated the diff for D142520: [libc++][ranges] Temporarily mark `ranges::join_view` as experimental..

Remove release notes from this patch.

Fri, Jan 27, 4:57 PM · Restricted Project, Restricted Project

Thu, Jan 26

var-const updated subscribers of D142521: [libc++][ranges][NFC] Move iterator classes out of `lazy_split_view` and `zip_view`..

There is a GCC failure on the CI that exposed two interesting issues:

Thu, Jan 26, 8:10 PM · Restricted Project, Restricted Project
var-const added a comment to D142520: [libc++][ranges] Temporarily mark `ranges::join_view` as experimental..

@ldionne Hmm, how do I reconcile the change to release notes with https://github.com/llvm/llvm-project/commit/603c286334b07f568d39f6706c848f576914f323 that bumped the version to 17 and removed the 16's notes?

Thu, Jan 26, 12:11 AM · Restricted Project, Restricted Project
var-const updated the diff for D142520: [libc++][ranges] Temporarily mark `ranges::join_view` as experimental..

Address feedback and rebase

Thu, Jan 26, 12:10 AM · Restricted Project, Restricted Project
var-const updated the diff for D142520: [libc++][ranges] Temporarily mark `ranges::join_view` as experimental..

Address feedback.

Thu, Jan 26, 12:05 AM · Restricted Project, Restricted Project

Wed, Jan 25

var-const abandoned D142497: [libc++][ranges][NFC] Update Ranges status and release notes..

I'm going to abandon this revision in favor of D142494 and D142520. Sorry about the confusion. The end result will look similar to this revision (for the release notes).

Wed, Jan 25, 2:07 PM · Restricted Project, Restricted Project

Tue, Jan 24

var-const requested review of D142521: [libc++][ranges][NFC] Move iterator classes out of `lazy_split_view` and `zip_view`..
Tue, Jan 24, 6:24 PM · Restricted Project, Restricted Project
var-const requested review of D142520: [libc++][ranges] Temporarily mark `ranges::join_view` as experimental..
Tue, Jan 24, 5:20 PM · Restricted Project, Restricted Project
var-const added a comment to D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Heads-up that we're seeing crashes due to the recommit of this change.
msan reports "use-of-uninitialized-value" in multiple places, where input is clearly initialized.

Tue, Jan 24, 2:16 PM · Restricted Project, Restricted Project
var-const accepted D142494: [libc++][NFC] update Release Notes and Range Status for the completion of C++20 ranges.

LGTM (I'll let @ldionne do the final approval).

Tue, Jan 24, 2:08 PM · Restricted Project, Restricted Project
var-const requested review of D142497: [libc++][ranges][NFC] Update Ranges status and release notes..
Tue, Jan 24, 12:18 PM · Restricted Project, Restricted Project

Mon, Jan 23

var-const accepted D142063: [libc++][ranges] implement `std::ranges::split_view` (targeting llvm 16).

Thanks a lot for working on this! LGTM with just a few comments.

Mon, Jan 23, 1:16 PM · Restricted Project, Restricted Project

Sat, Jan 21

var-const accepted D142276: [libc++] Rename take_while_view::__sentinel to __take_while_view_sentinel.

Thanks!

Sat, Jan 21, 7:50 PM · Restricted Project, Restricted Project

Fri, Jan 20

var-const accepted D142063: [libc++][ranges] implement `std::ranges::split_view` (targeting llvm 16).

Addressed comments look good, I'll hold off final approval until the test coverage is finished. Thanks!

Fri, Jan 20, 2:25 PM · Restricted Project, Restricted Project

Thu, Jan 19

var-const added a comment to D142063: [libc++][ranges] implement `std::ranges::split_view` (targeting llvm 16).

Looking great so far, thank you for working on this!

Thu, Jan 19, 5:36 PM · Restricted Project, Restricted Project

Wed, Jan 18

var-const added inline comments to rGd94b069a89ec: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version….
Wed, Jan 18, 11:52 AM · Restricted Project, Restricted Project

Tue, Jan 17

var-const committed rGd94b069a89ec: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version… (authored by var-const).
[libc++][ranges] Mark completed Ranges papers and issues as done, bump version…
Tue, Jan 17, 10:55 PM · Restricted Project, Restricted Project
var-const closed D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro.
Tue, Jan 17, 10:55 PM · Restricted Project, Restricted Project
var-const updated the diff for D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro.

Address feedback

Tue, Jan 17, 10:54 PM · Restricted Project, Restricted Project
var-const updated subscribers of D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro.
Tue, Jan 17, 10:54 PM · Restricted Project, Restricted Project

Fri, Jan 13

var-const committed rG5629d492df38: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`" (authored by varconst <varconsteq@gmail.com>).
Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`"
Fri, Jan 13, 4:58 PM · Restricted Project, Restricted Project
var-const added a reverting change for rGa6e1080b87db: Revert "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`": rG5629d492df38: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".
Fri, Jan 13, 4:58 PM · Restricted Project, Restricted Project
var-const closed D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".
Fri, Jan 13, 4:57 PM · Restricted Project, Restricted Project
var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Rebase

Fri, Jan 13, 1:51 PM · Restricted Project, Restricted Project

Thu, Jan 12

var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Fix the CI.

Thu, Jan 12, 7:07 PM · Restricted Project, Restricted Project

Wed, Jan 11

var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Try to fix the GCC crashes on the CI.

Wed, Jan 11, 12:08 PM · Restricted Project, Restricted Project

Tue, Jan 10

var-const added inline comments to D141456: [libc++][ranges] Fix incorrect integer type in `view_interface` tests..
Tue, Jan 10, 8:38 PM · Restricted Project, Restricted Project
var-const requested review of D141456: [libc++][ranges] Fix incorrect integer type in `view_interface` tests..
Tue, Jan 10, 8:37 PM · Restricted Project, Restricted Project
var-const accepted D140728: [libc++] Rename transform_view::{__iterator, __sentinel} to __transform_view_{iterator, sentinel}.
Tue, Jan 10, 8:01 PM · Restricted Project, Restricted Project
var-const accepted D141454: [libc++] Move iota_view::iterator and sentinel out of iota_view.
Tue, Jan 10, 7:43 PM · Restricted Project, Restricted Project
var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Rebase

Tue, Jan 10, 3:05 PM · Restricted Project, Restricted Project
var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Rebase

Tue, Jan 10, 11:01 AM · Restricted Project, Restricted Project

Mon, Jan 9

var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Fix CI.

Mon, Jan 9, 10:52 PM · Restricted Project, Restricted Project
var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Fix CI.

Mon, Jan 9, 6:21 PM · Restricted Project, Restricted Project
var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Fix CI and rebase.

Mon, Jan 9, 6:06 PM · Restricted Project, Restricted Project
var-const accepted D140920: [libc++] Fix ranges::uninitialized_move{, _n} for move-only types.

Thanks!

Mon, Jan 9, 3:39 PM · Restricted Project, Restricted Project
var-const accepted D137637: [libc++] Implement P2446R2 (views::as_rvalue).

LGTM (with just a couple of minor comments). I'll leave final approval to @ldionne since he had comments as well.

Mon, Jan 9, 3:29 PM · Restricted Project, Restricted Project

Dec 17 2022

var-const added inline comments to D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".
Dec 17 2022, 5:42 PM · Restricted Project, Restricted Project
var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Mark GCC as unsupported to fix the CI.

Dec 17 2022, 5:13 PM · Restricted Project, Restricted Project
var-const added inline comments to D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".
Dec 17 2022, 5:12 PM · Restricted Project, Restricted Project
var-const added inline comments to D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".
Dec 17 2022, 4:08 PM · Restricted Project, Restricted Project
var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Address feedback

Dec 17 2022, 4:06 PM · Restricted Project, Restricted Project
var-const retitled D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`" from Revert "Revert "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`"" to Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".
Dec 17 2022, 1:55 PM · Restricted Project, Restricted Project

Dec 16 2022

var-const accepted D136268: [libc++][ranges] implement `std::views::elements_view`.
Dec 16 2022, 2:22 PM · Restricted Project, Restricted Project, Restricted Project

Dec 15 2022

var-const added inline comments to D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro.
Dec 15 2022, 8:36 PM · Restricted Project, Restricted Project
var-const updated the diff for D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro.

Address feedback.

Dec 15 2022, 8:35 PM · Restricted Project, Restricted Project
var-const retitled D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro from [libc++][ranges] Mark completed Ranges papers and issues as done, finish implementing P2325. to [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro.
Dec 15 2022, 8:34 PM · Restricted Project, Restricted Project

Dec 14 2022

var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Link to the GitHub issue about volatile pointers.

Dec 14 2022, 1:13 AM · Restricted Project, Restricted Project
var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Address feedback.

Dec 14 2022, 1:12 AM · Restricted Project, Restricted Project

Dec 12 2022

var-const added inline comments to D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro.
Dec 12 2022, 6:40 PM · Restricted Project, Restricted Project
var-const added a comment to D136268: [libc++][ranges] implement `std::views::elements_view`.

@huixie90 I did the follow-up to mark papers and issues as done: https://reviews.llvm.org/D139900. Many of those are finished by this patch. If you'd like, feel free to update this patch to mark more papers (I think everything except P2325 is completed by this patch). But otherwise, feel free to submit as-is (except my comment about release notes, although we can do that in a follow-up as well if you'd like).

Dec 12 2022, 5:37 PM · Restricted Project, Restricted Project, Restricted Project
var-const added inline comments to D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro.
Dec 12 2022, 5:31 PM · Restricted Project, Restricted Project
var-const requested review of D139900: [libc++][ranges] Mark completed Ranges papers and issues as done, bump version macro.
Dec 12 2022, 5:27 PM · Restricted Project, Restricted Project
var-const added inline comments to D136268: [libc++][ranges] implement `std::views::elements_view`.
Dec 12 2022, 5:25 PM · Restricted Project, Restricted Project, Restricted Project
var-const accepted D136268: [libc++][ranges] implement `std::views::elements_view`.

Thanks a lot for working on this! Once this lands, we will only have split_view between our current state and a full C++20 implementation of Ranges.

Dec 12 2022, 12:41 PM · Restricted Project, Restricted Project, Restricted Project

Dec 9 2022

var-const added inline comments to D136268: [libc++][ranges] implement `std::views::elements_view`.
Dec 9 2022, 7:44 PM · Restricted Project, Restricted Project, Restricted Project
var-const added inline comments to D136268: [libc++][ranges] implement `std::views::elements_view`.
Dec 9 2022, 7:39 PM · Restricted Project, Restricted Project, Restricted Project
var-const committed rG21ca9c8d2879: [libc++][ranges][NFC] Update Ranges status. (authored by var-const).
[libc++][ranges][NFC] Update Ranges status.
Dec 9 2022, 7:33 PM · Restricted Project, Restricted Project

Dec 8 2022

var-const added inline comments to D131395: [libc++] Implement `lexicographical_compare_three_way`.
Dec 8 2022, 10:46 PM · Restricted Project, Restricted Project
var-const added a comment to D131395: [libc++] Implement `lexicographical_compare_three_way`.

Edit: never mind my original comment, I got incorrect results. Update below:

Dec 8 2022, 10:02 PM · Restricted Project, Restricted Project
var-const added a comment to D131395: [libc++] Implement `lexicographical_compare_three_way`.

@avogelsgesang I tried out the benchmarks, and it looks like you were probably accidentally running the benchmarks on the debug version of the build (unfortunately, it's a very easy mistake to make since it's the default). Using the debug build, I get timings very similar to what you saw earlier:

-----------------------------------------------------------------------------------------------------------------------
Benchmark                                                                             Time             CPU   Iterations
-----------------------------------------------------------------------------------------------------------------------
BM_lexicographical_compare_three_way<IntPtr>/1                                     25.7 ns         25.7 ns     27179505
BM_lexicographical_compare_three_way<IntPtr>/4                                     64.1 ns         64.0 ns     10934595
BM_lexicographical_compare_three_way<IntPtr>/16                                     316 ns          249 ns      2924673
BM_lexicographical_compare_three_way<IntPtr>/64                                     880 ns          864 ns       820595
BM_lexicographical_compare_three_way<IntPtr>/256                                   3328 ns         3324 ns       211011
BM_lexicographical_compare_three_way<IntPtr>/1024                                 13151 ns        13145 ns        53256
BM_lexicographical_compare_three_way<IntPtr>/4096                                 52541 ns        52531 ns        13321
BM_lexicographical_compare_three_way<IntPtr>/16384                               210420 ns       210398 ns         3342
BM_lexicographical_compare_three_way<IntPtr>/65536                               847864 ns       847372 ns          825
BM_lexicographical_compare_three_way<IntPtr>/262144                             3394918 ns      3393657 ns          207
BM_lexicographical_compare_three_way<IntPtr>/1048576                           13569716 ns     13563941 ns           51
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/1             37.7 ns         37.7 ns     18632581
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/4             85.6 ns         85.6 ns      8158698
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/16             286 ns          285 ns      2474206
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/64            1036 ns         1035 ns       676002
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/256           4018 ns         4017 ns       167247
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/1024         16138 ns        15993 ns        43945
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/4096         63604 ns        63602 ns        10994
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/16384       255664 ns       255574 ns         2749
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/65536      1025497 ns      1025498 ns          683
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/262144     4113879 ns      4111688 ns          170
BM_lexicographical_compare_three_way<random_access_iterator<IntPtr>>/1048576   16455950 ns     16454558 ns           43
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/1               29.5 ns         29.5 ns     23748940
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/4               99.7 ns         99.7 ns      6798031
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/16               300 ns          300 ns      2339940
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/64              1116 ns         1115 ns       632037
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/256             4347 ns         4344 ns       161197
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/1024           17271 ns        17270 ns        40467
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/4096           68959 ns        68958 ns        10135
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/16384         276437 ns       276348 ns         2533
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/65536        1111640 ns      1111475 ns          629
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/262144       4451482 ns      4450650 ns          157
BM_lexicographical_compare_three_way<cpp17_input_iterator<IntPtr>>/1048576     17807151 ns     17807154 ns           39

With a similar observation where random_access_iterator<int*> is consistently slower than int* (which makes sense in an unoptimized build).

Dec 8 2022, 4:41 PM · Restricted Project, Restricted Project

Dec 7 2022

var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Fix the CI.

Dec 7 2022, 1:27 AM · Restricted Project, Restricted Project
var-const added inline comments to D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".
Dec 7 2022, 1:27 AM · Restricted Project, Restricted Project
var-const added inline comments to D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".
Dec 7 2022, 1:13 AM · Restricted Project, Restricted Project
var-const updated the diff for D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".

Address feedback, further expand testing.

Dec 7 2022, 1:12 AM · Restricted Project, Restricted Project

Dec 5 2022

var-const published D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`" for review.
Dec 5 2022, 9:20 PM · Restricted Project, Restricted Project

Dec 2 2022

var-const added a reverting change for rGa6e1080b87db: Revert "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`": D139235: Reapply "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`".
Dec 2 2022, 3:26 PM · Restricted Project, Restricted Project
var-const added inline comments to D137476: [libc++] Add utilites for instantiating functions with multiple types.
Dec 2 2022, 3:24 PM · Restricted Project, Restricted Project
var-const added inline comments to D137476: [libc++] Add utilites for instantiating functions with multiple types.
Dec 2 2022, 3:17 PM · Restricted Project, Restricted Project
var-const added a comment to D137476: [libc++] Add utilites for instantiating functions with multiple types.

@philnik Sorry about the delay! I think I like the general direction. I do share some of the concerns re. complexity raised in the review -- there's definitely a tradeoff there -- but I also feel that verbosity and duplication are the biggest bane of our test suite. Especially with some of the simplifications made, this looks really nice and IMO doesn't add that much complexity compared to the amount of error-prone boilerplate that it removes. I haven't looked at this in detail, but the general idea LGTM.

Dec 2 2022, 3:14 PM · Restricted Project, Restricted Project
var-const requested changes to D137637: [libc++] Implement P2446R2 (views::as_rvalue).
Dec 2 2022, 3:03 PM · Restricted Project, Restricted Project
var-const added inline comments to D137637: [libc++] Implement P2446R2 (views::as_rvalue).
Dec 2 2022, 3:03 PM · Restricted Project, Restricted Project

Nov 30 2022

var-const added inline comments to D131395: [libc++] Implement `lexicographical_compare_three_way`.
Nov 30 2022, 11:34 AM · Restricted Project, Restricted Project
var-const requested changes to D131395: [libc++] Implement `lexicographical_compare_three_way`.

Thanks a lot for the updated benchmarks! I really appreciate the effort you put into this.

Nov 30 2022, 1:43 AM · Restricted Project, Restricted Project

Nov 29 2022

var-const added a comment to D138601: [libc++] Fix memory leaks when throwing inside std::vector constructors.

@philnik Thanks a lot for fixing this! Just to double-check -- you have considered reintroducing the base class for the purpose of providing exception safety and decided that using transactions is better, right? (I presume it is, since you would probably need to move quite a few details related to memory management back into the base class for this to work)

Nov 29 2022, 12:20 PM · Restricted Project, Restricted Project

Nov 28 2022

var-const added a comment to D136268: [libc++][ranges] implement `std::views::elements_view`.

Sorry about the very slow review. Looks good with just a few nits/comments.

Nov 28 2022, 5:56 PM · Restricted Project, Restricted Project, Restricted Project

Nov 19 2022

var-const added a reverting change for rGa6e1080b87db: Revert "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`": D138367: Revert "Revert "[libc++][ranges]Refactor `copy{,_backward}` and `move{,_backward}`"".
Nov 19 2022, 4:18 PM · Restricted Project, Restricted Project

Nov 17 2022

var-const committed rGf51c91532e24: [libc++][NFC] Add a missing include in pre-C++14 language modes. (authored by var-const).
[libc++][NFC] Add a missing include in pre-C++14 language modes.
Nov 17 2022, 5:16 PM · Restricted Project, Restricted Project