Page MenuHomePhabricator

zoecarver (Zoe Carver)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2019, 10:13 PM (124 w, 6 d)

Email: zoe@zoecarver.com
Username: zoecarver (slack, IRC, github, stackoverflow)

I mostly work on libc++. Feel free to contact me above.

Recent Activity

Today

zoecarver updated the diff for D102809: [libcxx][ranges] Add `ranges::iter_swap`..

Add a modulemap entry.

Mon, Jun 21, 4:31 PM · Restricted Project
zoecarver updated the diff for D102037: [libcxx][views] Add drop_view..

Apply a few remaining review comments.

Mon, Jun 21, 3:54 PM · Restricted Project
zoecarver added inline comments to D102037: [libcxx][views] Add drop_view..
Mon, Jun 21, 3:50 PM · Restricted Project
zoecarver updated the diff for D102037: [libcxx][views] Add drop_view..
  • Split up tests.
  • Use std::optional as a non-propagating cache (and add a test).
Mon, Jun 21, 3:43 PM · Restricted Project
zoecarver updated the diff for D102809: [libcxx][ranges] Add `ranges::iter_swap`..

Rebase.

Mon, Jun 21, 12:41 PM · Restricted Project
zoecarver committed rG075f2370c7fa: [libcxx][ranges] Add `indirectly_movable` and `indirectly_movable_storable`. (authored by zoecarver).
[libcxx][ranges] Add `indirectly_movable` and `indirectly_movable_storable`.
Mon, Jun 21, 12:40 PM
zoecarver closed D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..
Mon, Jun 21, 12:40 PM · Restricted Project
zoecarver updated the diff for D102809: [libcxx][ranges] Add `ranges::iter_swap`..

Rebase off main.

Mon, Jun 21, 11:40 AM · Restricted Project
zoecarver updated the diff for D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..

Rebase. Add some more comments.

Mon, Jun 21, 11:38 AM · Restricted Project
zoecarver updated the diff for D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..

Remove PointerToWithValueType and update PointerTo.

Mon, Jun 21, 10:01 AM · Restricted Project
zoecarver updated the diff for D102809: [libcxx][ranges] Add `ranges::iter_swap`..

Fix based on Louis' review comments.

Mon, Jun 21, 9:56 AM · Restricted Project
zoecarver updated the diff for D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..

Change static assert and add a comment.

Mon, Jun 21, 9:41 AM · Restricted Project
zoecarver added a comment to D102121: [libcxx][ranges] adds _`non-propagating-cache`_.

Other than my nit, this looks good to me.

Mon, Jun 21, 8:43 AM · Restricted Project

Tue, Jun 15

zoecarver updated the diff for D102809: [libcxx][ranges] Add `ranges::iter_swap`..

Rebase. Apply Louis' comments.

Tue, Jun 15, 6:27 AM · Restricted Project
zoecarver added inline comments to D102809: [libcxx][ranges] Add `ranges::iter_swap`..
Tue, Jun 15, 6:19 AM · Restricted Project
zoecarver added a comment to D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..

@ldionne sorry, I just realized that I had some comments responding to various suggestions you made that never got submitted. Anyway, that's why I marked a few things as done but didn't actually do them.

Tue, Jun 15, 6:11 AM · Restricted Project

Mon, Jun 14

zoecarver updated the diff for D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..

Apply Louis' suggestions.

Mon, Jun 14, 2:27 PM · Restricted Project
zoecarver updated the diff for D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..

Fix merge conflict.

Mon, Jun 14, 1:11 PM · Restricted Project
zoecarver requested review of D104262: [libcxx][ranges] Add contiguous_range..
Mon, Jun 14, 1:09 PM · Restricted Project
zoecarver updated the diff for D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..

Fix two conformance tests.

Mon, Jun 14, 12:20 PM · Restricted Project
zoecarver accepted D104175: [libcxx][iwyu] ensures we IWYU as prep for modules.

No opinion on what patch the operator change goes in. Thanks for explaining the rational.

Mon, Jun 14, 10:50 AM · Restricted Project
zoecarver updated the diff for D102809: [libcxx][ranges] Add `ranges::iter_swap`..

Apply Arthur's suggested changes.

Mon, Jun 14, 8:01 AM · Restricted Project
zoecarver added a comment to D102809: [libcxx][ranges] Add `ranges::iter_swap`..

@ldionne this is ready for review.

Mon, Jun 14, 8:00 AM · Restricted Project
zoecarver added inline comments to D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..
Mon, Jun 14, 7:45 AM · Restricted Project
zoecarver committed rGc820b494d6e1: [libcxx][ranges] Implement views::all. (authored by zoecarver).
[libcxx][ranges] Implement views::all.
Mon, Jun 14, 7:41 AM
zoecarver closed D102028: [libcxx][ranges] Implement views::all..
Mon, Jun 14, 7:41 AM · Restricted Project
zoecarver updated the diff for D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..
  • Move tests into their own files.
  • Rebase.
Mon, Jun 14, 7:37 AM · Restricted Project
zoecarver added a comment to D102639: [libcxx][ranges] Add `indirectly_­movable` and `indirectly_movable_storable`..

@ldionne applying your comments now...

Mon, Jun 14, 6:38 AM · Restricted Project
zoecarver updated the diff for D102028: [libcxx][ranges] Implement views::all..
  • Rebase and fix header includes.
  • Remove default template param.
  • ViewImpl -> View.
Mon, Jun 14, 6:16 AM · Restricted Project

Fri, Jun 11

zoecarver updated the diff for D102028: [libcxx][ranges] Implement views::all..

Rebase. This is just to get the CI going, I'll apply your comments shortly, Arthur.

Fri, Jun 11, 11:07 AM · Restricted Project
zoecarver committed rG7eba4856c702: [libcxx][ranges] Add class ref_view. (authored by zoecarver).
[libcxx][ranges] Add class ref_view.
Fri, Jun 11, 11:04 AM
zoecarver closed D102020: [libcxx][ranges] Add class ref_view..
Fri, Jun 11, 11:04 AM · Restricted Project
zoecarver added a comment to D102028: [libcxx][ranges] Implement views::all..

@Quuxplusone friendly ping. I'm going to rebase this shortly. After the tests pass I'm planning to land it.

Fri, Jun 11, 9:36 AM · Restricted Project
zoecarver committed rG9106047ee3dd: [libcxx][ranges] Add range.subrange. (authored by zoecarver).
[libcxx][ranges] Add range.subrange.
Fri, Jun 11, 9:35 AM
zoecarver closed D102006: [libcxx][ranges] Add range.subrange..
Fri, Jun 11, 9:34 AM · Restricted Project
zoecarver updated the diff for D102020: [libcxx][ranges] Add class ref_view..

Add ref_view.h to the cmake lists after it was removed during rebase (and not caught locally due to caching).

Fri, Jun 11, 9:26 AM · Restricted Project

Thu, Jun 10

zoecarver updated the diff for D102020: [libcxx][ranges] Add class ref_view..

Rebase.

Thu, Jun 10, 6:04 PM · Restricted Project
zoecarver updated the diff for D102006: [libcxx][ranges] Add range.subrange..

Rebase.

Thu, Jun 10, 5:58 PM · Restricted Project
zoecarver updated the diff for D102020: [libcxx][ranges] Add class ref_view..
  • Fix indenting.
  • Remove white space
  • Remove no-longer-needed operator==s.
Thu, Jun 10, 2:15 PM · Restricted Project
zoecarver accepted D102468: [libcxx][ranges] removes default_initializable from weakly_incrementable and view.

Let's land this to unblock the other patches.

Thu, Jun 10, 12:55 PM · Restricted Project
zoecarver updated the diff for D102020: [libcxx][ranges] Add class ref_view..

Remove added empty file.

Thu, Jun 10, 12:48 PM · Restricted Project
zoecarver updated the diff for D102020: [libcxx][ranges] Add class ref_view..

Apply Louis' feedback.

Thu, Jun 10, 12:47 PM · Restricted Project
zoecarver added a comment to D102006: [libcxx][ranges] Add range.subrange..

The above update:

  • Split tests into multiple files.
  • Rebased onto D102468 and applied changes from Barry's paper.
Thu, Jun 10, 12:24 PM · Restricted Project
zoecarver updated the diff for D102006: [libcxx][ranges] Add range.subrange..

Apply review comments.

Thu, Jun 10, 12:23 PM · Restricted Project

Wed, Jun 9

zoecarver accepted D103295: [libcxx][docs] updates the ranges status paper.

Assuming you apply my inline comments, this lgtm as well.

Wed, Jun 9, 8:56 AM · Restricted Project

Mon, Jun 7

zoecarver requested review of D103840: [libcxx][ranges][nfc] Factor out common logic in the copy algorithms..
Mon, Jun 7, 1:55 PM · Restricted Project

Fri, Jun 4

zoecarver updated the diff for D102809: [libcxx][ranges] Add `ranges::iter_swap`..

Update based on review.

Fri, Jun 4, 3:27 PM · Restricted Project
zoecarver added inline comments to D102809: [libcxx][ranges] Add `ranges::iter_swap`..
Fri, Jun 4, 3:26 PM · Restricted Project
zoecarver updated the diff for D102028: [libcxx][ranges] Implement views::all..

Add noexcept tests.

Fri, Jun 4, 2:23 PM · Restricted Project
zoecarver updated the diff for D102020: [libcxx][ranges] Add class ref_view..
  • Diff off correct commit.
  • EmptyInvocable -> EmptyIsInvocable
Fri, Jun 4, 1:39 PM · Restricted Project
zoecarver updated the diff for D102020: [libcxx][ranges] Add class ref_view..

Apply review comments.

Fri, Jun 4, 12:42 PM · Restricted Project
zoecarver added a comment to D102020: [libcxx][ranges] Add class ref_view..

Okay, I think that's everything.

Fri, Jun 4, 12:41 PM · Restricted Project
zoecarver updated the diff for D102006: [libcxx][ranges] Add range.subrange..

Apply review comments.

Fri, Jun 4, 11:42 AM · Restricted Project
zoecarver added inline comments to D102006: [libcxx][ranges] Add range.subrange..
Fri, Jun 4, 11:10 AM · Restricted Project
zoecarver added inline comments to D102006: [libcxx][ranges] Add range.subrange..
Fri, Jun 4, 11:08 AM · Restricted Project
zoecarver committed rG89599e8b201a: [libcxx][ranges] Add concepts in range.utility.helpers. (authored by zoecarver).
[libcxx][ranges] Add concepts in range.utility.helpers.
Fri, Jun 4, 9:56 AM
zoecarver closed D103493: [libcxx][ranges] Add concepts in range.utility.helpers..
Fri, Jun 4, 9:56 AM · Restricted Project
zoecarver added a comment to D103493: [libcxx][ranges] Add concepts in range.utility.helpers..

I'm going to do the rename and land.

Fri, Jun 4, 9:52 AM · Restricted Project
zoecarver committed rGd31a2e7554ea: [libcxx][ranges] Add `ranges::empty_view`. (authored by zoecarver).
[libcxx][ranges] Add `ranges::empty_view`.
Fri, Jun 4, 9:39 AM
zoecarver closed D103208: [libcxx][ranges] Add `ranges::empty_view`..
Fri, Jun 4, 9:39 AM · Restricted Project
zoecarver committed rG7ed7d4ccb899: [libcxx][gardening] Move all algorithms into their own headers. (authored by zoecarver).
[libcxx][gardening] Move all algorithms into their own headers.
Fri, Jun 4, 9:37 AM
zoecarver closed D103583: [libcxx][gardening] Move all algorithms into their own headers..
Fri, Jun 4, 9:37 AM · Restricted Project

Thu, Jun 3

zoecarver added inline comments to D103208: [libcxx][ranges] Add `ranges::empty_view`..
Thu, Jun 3, 1:57 PM · Restricted Project
zoecarver updated the diff for D103208: [libcxx][ranges] Add `ranges::empty_view`..
  • Rebase
  • Remove comment
  • Add conformance tests
Thu, Jun 3, 1:57 PM · Restricted Project
zoecarver updated the diff for D103583: [libcxx][gardening] Move all algorithms into their own headers..

Fix another include issue that I didn't catch thanks to ninja caching.

Thu, Jun 3, 12:54 PM · Restricted Project
zoecarver updated the diff for D103583: [libcxx][gardening] Move all algorithms into their own headers..

Add back half_positive.h which got removed on accident (and I didn't catch it because cmake cached it in the build directoyr).

Thu, Jun 3, 11:49 AM · Restricted Project
zoecarver updated the diff for D103583: [libcxx][gardening] Move all algorithms into their own headers..

Rebase.

Thu, Jun 3, 11:30 AM · Restricted Project
zoecarver updated the diff for D103583: [libcxx][gardening] Move all algorithms into their own headers..
  • Remove two unrealted files
Thu, Jun 3, 11:14 AM · Restricted Project
zoecarver updated the diff for D103583: [libcxx][gardening] Move all algorithms into their own headers..
  • Re-alphabatize and add a few missing modules to the module map
  • __search.h -> search.h
Thu, Jun 3, 11:13 AM · Restricted Project
zoecarver added inline comments to D103583: [libcxx][gardening] Move all algorithms into their own headers..
Thu, Jun 3, 10:58 AM · Restricted Project
zoecarver updated the diff for D103583: [libcxx][gardening] Move all algorithms into their own headers..
  • Modularize
Thu, Jun 3, 10:55 AM · Restricted Project

Wed, Jun 2

zoecarver updated the diff for D103583: [libcxx][gardening] Move all algorithms into their own headers..

Remove two unrelated files.

Wed, Jun 2, 6:22 PM · Restricted Project
zoecarver added a comment to D103583: [libcxx][gardening] Move all algorithms into their own headers..

Note: this change includes D103330. I just subsumed that patch because I need to use some things form it and update it a bit. I think it's easiest to just take this one rather than trying to deal with merge conflicts and updates to that one.

Wed, Jun 2, 6:22 PM · Restricted Project
zoecarver requested review of D103583: [libcxx][gardening] Move all algorithms into their own headers..
Wed, Jun 2, 6:18 PM · Restricted Project
zoecarver added inline comments to D102006: [libcxx][ranges] Add range.subrange..
Wed, Jun 2, 2:02 PM · Restricted Project
zoecarver updated the diff for D103493: [libcxx][ranges] Add concepts in range.utility.helpers..
  • Fix versioning.
  • Use test::sentinel_wrapper.
Wed, Jun 2, 1:34 PM · Restricted Project
zoecarver added inline comments to D103493: [libcxx][ranges] Add concepts in range.utility.helpers..
Wed, Jun 2, 9:15 AM · Restricted Project

Tue, Jun 1

zoecarver added a comment to D102020: [libcxx][ranges] Add class ref_view..

@Quuxplusone friendly ping.

Tue, Jun 1, 4:33 PM · Restricted Project
zoecarver updated the diff for D102006: [libcxx][ranges] Add range.subrange..

Note: I'm going to land this when the tests pass.

Tue, Jun 1, 4:32 PM · Restricted Project
zoecarver added a comment to D102006: [libcxx][ranges] Add range.subrange..

Sorry for the slow reply. Thanks @Mordante.

Tue, Jun 1, 4:27 PM · Restricted Project
zoecarver updated the diff for D103493: [libcxx][ranges] Add concepts in range.utility.helpers..

Address review comments.

Tue, Jun 1, 4:20 PM · Restricted Project
zoecarver added inline comments to D103493: [libcxx][ranges] Add concepts in range.utility.helpers..
Tue, Jun 1, 4:19 PM · Restricted Project
zoecarver added inline comments to D103493: [libcxx][ranges] Add concepts in range.utility.helpers..
Tue, Jun 1, 4:01 PM · Restricted Project
zoecarver added inline comments to D103478: [libc++][compare] Implement three_way_comparable[_with] concepts.
Tue, Jun 1, 3:07 PM · Restricted Project
zoecarver requested review of D103493: [libcxx][ranges] Add concepts in range.utility.helpers..
Tue, Jun 1, 2:55 PM · Restricted Project
zoecarver committed rG065cf3f9d703: [libcxx][ranges] Add `default_sentinel` and `default_sentinel_t`. (authored by zoecarver).
[libcxx][ranges] Add `default_sentinel` and `default_sentinel_t`.
Tue, Jun 1, 2:07 PM
zoecarver closed D103487: [libcxx][ranges] Add `default_sentinel` and `default_sentinel_t`..
Tue, Jun 1, 2:07 PM · Restricted Project
zoecarver added inline comments to D103487: [libcxx][ranges] Add `default_sentinel` and `default_sentinel_t`..
Tue, Jun 1, 1:40 PM · Restricted Project
zoecarver requested review of D103487: [libcxx][ranges] Add `default_sentinel` and `default_sentinel_t`..
Tue, Jun 1, 12:56 PM · Restricted Project
zoecarver committed rG5671ff20d92b: [libcxx] Implement view.interface. (authored by zoecarver).
[libcxx] Implement view.interface.
Tue, Jun 1, 12:35 PM
zoecarver closed D101737: [libcxx] Implement view.interface..
Tue, Jun 1, 12:35 PM · Restricted Project
zoecarver updated the diff for D101737: [libcxx] Implement view.interface..
  • Rebase.
  • -- -> prev (again).
Tue, Jun 1, 11:03 AM · Restricted Project
zoecarver updated the diff for D101737: [libcxx] Implement view.interface..

Apply review comments.

Tue, Jun 1, 11:01 AM · Restricted Project
zoecarver added inline comments to D101737: [libcxx] Implement view.interface..
Tue, Jun 1, 11:00 AM · Restricted Project
zoecarver abandoned D102657: [libcxx][ranges] Update `{front_,back_,}insert_iterator` for C++20..
Tue, Jun 1, 9:18 AM · Restricted Project

Fri, May 28

zoecarver added inline comments to D103341: [libcxx][nfc] Cleanup cpp20_input_iterator..
Fri, May 28, 1:59 PM · Restricted Project
zoecarver requested review of D103341: [libcxx][nfc] Cleanup cpp20_input_iterator..
Fri, May 28, 1:58 PM · Restricted Project
zoecarver updated the diff for D103335: [libcxx][ranges] Adds `common_iterator`..

Update the status document.

Fri, May 28, 12:23 PM · Restricted Project
zoecarver updated the diff for D103335: [libcxx][ranges] Adds `common_iterator`..

Remove unneeded comment.

Fri, May 28, 12:20 PM · Restricted Project
zoecarver added inline comments to D103335: [libcxx][ranges] Adds `common_iterator`..
Fri, May 28, 12:20 PM · Restricted Project