Page MenuHomePhabricator

zoecarver (Zoe Carver)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 28 2019, 10:13 PM (50 w, 6 d)

Email: zoe@zoecarver.com
Username: zoecarver (slack, IRC, github, stackoverflow)

I mostly work on libc++. Feel free to contact me above.

Recent Activity

Fri, Jan 17

zoecarver added a comment to D67900: [libc++] Use builtin type traits whenever possible.

Ping. I'd like to get this approved before I rebase off master again. Any other review comments?

Fri, Jan 17, 1:26 PM · Restricted Project

Tue, Jan 14

zoecarver added a comment to D66177: Update shared_ptr's constructor.

@ldionne ping.

Tue, Jan 14, 7:42 PM · Restricted Project

Fri, Jan 10

zoecarver added inline comments to D68480: Implementation of C++20's P1135R6 for libcxx.
Fri, Jan 10, 2:54 PM

Thu, Jan 9

zoecarver added a comment to D65041: Change requirements on linear_congruential_engine.

Ping :)

Thu, Jan 9, 1:04 PM
zoecarver added a comment to D68480: Implementation of C++20's P1135R6 for libcxx.

Thank you for all the work you've put into this patch. Here are a few more comments. Still working through all this code :)

Thu, Jan 9, 11:29 AM

Dec 16 2019

zoecarver added a comment to D66839: Fix stack address builtin for negative numbers.

@Jim Thanks, I'll move it.

Dec 16 2019, 8:08 PM · Restricted Project

Dec 9 2019

zoecarver added inline comments to D62454: SFINAE on pair/tuple assignment operators 2729.
Dec 9 2019, 9:15 PM
zoecarver updated the diff for D62928: Constrain function assignment operator (2574).

Address @ldionne comments

Dec 9 2019, 9:06 PM · Restricted Project

Dec 8 2019

zoecarver added a comment to D60368: Add bind_front function (P0356R5).

@EricWF any more comments on this?

Dec 8 2019, 11:12 AM
zoecarver added a comment to D61771: Comparing Unordered Containers (P0809).

Ping. This is a NFC.

Dec 8 2019, 11:12 AM
zoecarver added a comment to D67052: Add reference type transformation builtins.

@EricWF ping.

Dec 8 2019, 11:12 AM · Restricted Project, Restricted Project
zoecarver added a comment to D67900: [libc++] Use builtin type traits whenever possible.

Ping @ldionne any other comments?

Dec 8 2019, 11:12 AM · Restricted Project
zoecarver added a comment to D67086: Implement syncstream (p0053).

Ping @mclow.lists can you take another look at this?

Dec 8 2019, 11:04 AM · Restricted Project

Nov 22 2019

zoecarver added a comment to D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf.

Wow, this is great!

Nov 22 2019, 11:01 PM · Restricted Project

Nov 20 2019

zoecarver updated the diff for D66177: Update shared_ptr's constructor.
  • Move try-catch outside of __allocate_shared
Nov 20 2019, 1:56 PM · Restricted Project

Nov 7 2019

zoecarver added a comment to D69981: [www] More HTTPS and outdated link fixes..

This LGTM, thanks!

Nov 7 2019, 6:27 PM · Restricted Project, Restricted Project
zoecarver added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Let's use this patch. Both so that you can get something committed and because it has the feature test macros. Feel free to pull anything you want from my implementation.

Nov 7 2019, 8:27 AM · Restricted Project
zoecarver abandoned D66103: implement std::to_array (P0325R3).

Abandoning in favor of D69882.

Nov 7 2019, 8:27 AM · Restricted Project

Nov 6 2019

zoecarver added a comment to D69882: [libc++] [P0325] Implement to_array from LFTS with updates..

Thanks for the patch @curdeius! It looks great.

Nov 6 2019, 8:54 AM · Restricted Project

Oct 28 2019

zoecarver committed rGa062856bcf4f: [NFC] Comment endif to test commit access (authored by zoecarver).
[NFC] Comment endif to test commit access
Oct 28 2019, 9:19 AM
zoecarver updated the diff for D60491: Fix fpos requirements & cleanup.
  • fix review comments
Oct 28 2019, 8:34 AM · Restricted Project
zoecarver added a comment to D60491: Fix fpos requirements & cleanup.

Yes, some of the tests are duplicated (subtraction, addition, comparison, etc.) but, I think it is nice to have it match the order of the table in the standard. Say the word and I'll remove the duplication, though.

Oct 28 2019, 8:31 AM · Restricted Project
zoecarver added a comment to D66615: This patch resolves issue 2724..

Ping :)

Oct 28 2019, 8:11 AM · Restricted Project
zoecarver added inline comments to D67086: Implement syncstream (p0053).
Oct 28 2019, 8:10 AM · Restricted Project

Oct 24 2019

zoecarver updated the diff for D69344: [libcxx] Add move constructor to compressed pair.
  • use = default in move and copy constructors
Oct 24 2019, 9:34 AM · Restricted Project
zoecarver added a comment to D69344: [libcxx] Add move constructor to compressed pair.

You need to default it in both bases and in the compressed pair itself.

Oct 24 2019, 9:34 AM · Restricted Project
zoecarver added a comment to D69344: [libcxx] Add move constructor to compressed pair.

I would have also expected = default to work but, it doesn't seem to. I think because __compressed_pair inherits from both its elements instead of storing them as members.

Oct 24 2019, 8:12 AM · Restricted Project
zoecarver added a comment to D69344: [libcxx] Add move constructor to compressed pair.

I should have made it clear, my bad, this fixes the move constructor in C++03 mode.

Oct 24 2019, 7:37 AM · Restricted Project

Oct 23 2019

zoecarver added a comment to D69363: [www] Change URLs to HTTPS..

Thanks for updating all these links! LGTM :)

Oct 23 2019, 9:10 PM · Restricted Project, Restricted Project
zoecarver added a comment to D69363: [www] Change URLs to HTTPS..

GitHub PRs can't come soon enough :) There was a round table meeting about that earlier today which I am anxious to hear about.

Oct 23 2019, 8:11 PM · Restricted Project, Restricted Project
zoecarver added inline comments to D67900: [libc++] Use builtin type traits whenever possible.
Oct 23 2019, 6:48 PM · Restricted Project
zoecarver updated the diff for D67900: [libc++] Use builtin type traits whenever possible.
  • update based on review
Oct 23 2019, 6:48 PM · Restricted Project
zoecarver updated the diff for D67900: [libc++] Use builtin type traits whenever possible.
  • fix the`std::s_same` test
Oct 23 2019, 6:36 PM · Restricted Project
zoecarver updated the diff for D62274: shared_ptr deleter requirements (2802).

Don't mark 2875 as complete. That would requires some of my other patches so, I'll fix that issue down the road.

Oct 23 2019, 9:46 AM · Restricted Project
zoecarver added inline comments to D62274: shared_ptr deleter requirements (2802).
Oct 23 2019, 9:46 AM · Restricted Project
zoecarver updated the diff for D62274: shared_ptr deleter requirements (2802).

I rewrote this patch so that it doesn't require my (some, now obsolete) other patches. This patch does now rely on the fix from D69344 for C++03 move-constructibility. Also, I updated the tests.

Oct 23 2019, 9:39 AM · Restricted Project
zoecarver updated the diff for D69344: [libcxx] Add move constructor to compressed pair.
  • remove unnecessary template
Oct 23 2019, 9:28 AM · Restricted Project
zoecarver created D69344: [libcxx] Add move constructor to compressed pair.
Oct 23 2019, 9:28 AM · Restricted Project

Oct 22 2019

zoecarver added inline comments to D66177: Update shared_ptr's constructor.
Oct 22 2019, 4:04 PM · Restricted Project
zoecarver added inline comments to D66177: Update shared_ptr's constructor.
Oct 22 2019, 4:04 PM · Restricted Project
zoecarver added inline comments to D66177: Update shared_ptr's constructor.
Oct 22 2019, 3:54 PM · Restricted Project
zoecarver added a comment to D66177: Update shared_ptr's constructor.

Ping. Thanks for reviewing the other patches, this is the last in the series.

Oct 22 2019, 8:28 AM · Restricted Project
zoecarver closed D68805: [libcxx] Remove shared_ptr::make_shared.

Resolved by rL375504.

Oct 22 2019, 8:21 AM · Restricted Project
zoecarver committed rG40c47680eb2a: [libcxx] Remove shared_ptr::make_shared (authored by zoecarver).
[libcxx] Remove shared_ptr::make_shared
Oct 22 2019, 8:19 AM
zoecarver committed rL375504: [libcxx] Remove shared_ptr::make_shared.
[libcxx] Remove shared_ptr::make_shared
Oct 22 2019, 8:18 AM

Oct 21 2019

zoecarver added a comment to D68805: [libcxx] Remove shared_ptr::make_shared.

I'll commit this in the morning.

Oct 21 2019, 6:59 PM · Restricted Project

Oct 20 2019

zoecarver added inline comments to D67900: [libc++] Use builtin type traits whenever possible.
Oct 20 2019, 8:42 PM · Restricted Project
zoecarver added inline comments to D67900: [libc++] Use builtin type traits whenever possible.
Oct 20 2019, 8:33 PM · Restricted Project
zoecarver committed rL375368: added username zoecarver.
added username zoecarver
Oct 20 2019, 11:53 AM
zoecarver added a comment to D66610: [libc++] ECMAScript IdentityEscape is ambiguous (2584).

Friendly ping :)

Oct 20 2019, 10:49 AM · Restricted Project
zoecarver updated the diff for D68805: [libcxx] Remove shared_ptr::make_shared.
  • rename __create_with_cntrl_block to __create_with_control_block.
  • pull __ptr argument into a variable so that the arguments can be evaluated from right to left without a segfault.
Oct 20 2019, 10:41 AM · Restricted Project
zoecarver updated the diff for D67900: [libc++] Use builtin type traits whenever possible.
  • Merge branch 'master' into use-builtin-type-traits
  • fix: overload resolution issue
  • fix: C++03 mode issue
Oct 20 2019, 10:31 AM · Restricted Project
Herald added a reviewer for D67052: Add reference type transformation builtins: mclow.lists.

Friendly ping. Other than type mangling, does anything need to be fixed?

Oct 20 2019, 10:31 AM · Restricted Project, Restricted Project
zoecarver added inline comments to D68480: Implementation of C++20's P1135R6 for libcxx.
Oct 20 2019, 9:45 AM
zoecarver added inline comments to D68805: [libcxx] Remove shared_ptr::make_shared.
Oct 20 2019, 9:08 AM · Restricted Project

Oct 16 2019

zoecarver created D69062: Resolve LWG issue 2426.
Oct 16 2019, 11:33 AM · Restricted Project, Restricted Project
zoecarver added a comment to D68805: [libcxx] Remove shared_ptr::make_shared.

@ldionne, yes. I suspect this is the patch that will cause a SEGFAULT. It could also be a similar part of the patch where I remove std::shared_ptr::allocate_shared, though. If it does cause a SEGFAULT we will know exactly where the issue is and it will be easier to debug.

Oct 16 2019, 8:45 AM · Restricted Project
zoecarver added a comment to D67675: [libc++] Remove C++03 variadics in shared_ptr.

Thanks for fixing the status of this, @ldionne :)

Oct 16 2019, 8:08 AM · Restricted Project
zoecarver added a comment to D68000: [libc++] Remove C++03 variadics in shared_ptr (v2).

Yes, it was. Sorry about that. I think there was a delay with the email and then I forgot.

Oct 16 2019, 8:08 AM · Restricted Project

Oct 10 2019

zoecarver added a comment to D68837: [libc++][P0202] Marked algorithms copy/copy_n/copy_if/copy_backward constexpr..

__libcpp_is_constant_evaluated returns false in C++03 mode but, it still won't work as a template argument. Putting #ifs around it will probably work, though.

Oct 10 2019, 9:56 PM · Restricted Project
zoecarver updated the summary of D68805: [libcxx] Remove shared_ptr::make_shared.
Oct 10 2019, 9:08 AM · Restricted Project
zoecarver created D68805: [libcxx] Remove shared_ptr::make_shared.
Oct 10 2019, 8:59 AM · Restricted Project

Oct 8 2019

zoecarver added inline comments to D67900: [libc++] Use builtin type traits whenever possible.
Oct 8 2019, 10:26 AM · Restricted Project

Oct 7 2019

zoecarver committed rGa9d43b55c7d2: [libc++] Remove C++03 variadics in shared_ptr (v2) (authored by zoecarver).
[libc++] Remove C++03 variadics in shared_ptr (v2)
Oct 7 2019, 10:21 PM
zoecarver committed rL373971: [libc++] Remove C++03 variadics in shared_ptr (v2).
[libc++] Remove C++03 variadics in shared_ptr (v2)
Oct 7 2019, 10:21 PM
zoecarver added inline comments to D68480: Implementation of C++20's P1135R6 for libcxx.
Oct 7 2019, 4:18 PM
zoecarver added inline comments to D67900: [libc++] Use builtin type traits whenever possible.
Oct 7 2019, 1:29 PM · Restricted Project

Oct 5 2019

zoecarver added a comment to D68480: Implementation of C++20's P1135R6 for libcxx.

Here are some comments. More to come. A few things that I noticed more broadly:

Oct 5 2019, 12:15 PM
zoecarver added a comment to D68000: [libc++] Remove C++03 variadics in shared_ptr (v2).

@ldionne friendly ping :) this should be an easy change.

Oct 5 2019, 10:02 AM · Restricted Project
zoecarver updated the diff for D67900: [libc++] Use builtin type traits whenever possible.
  • remove array rank builtin (because it does not work properly)
Oct 5 2019, 10:00 AM · Restricted Project

Sep 26 2019

zoecarver added a comment to D61170: Use std::move in numeric algorithms.

Ping @mclow.lists

Sep 26 2019, 8:13 PM
zoecarver added a reviewer for D61170: Use std::move in numeric algorithms: ldionne.
Sep 26 2019, 8:13 PM

Sep 25 2019

zoecarver updated the diff for D67086: Implement syncstream (p0053).

Add std::lock_guards to prevent races on the map. I ran with TSAN and got no warnings. I also increased the number of times I run the larger thread tests and now get no errors.

Sep 25 2019, 6:30 PM · Restricted Project
zoecarver added inline comments to D65161: [libc++] Implement LWG 2510.
Sep 25 2019, 2:18 PM · Restricted Project, Restricted Project

Sep 24 2019

zoecarver created D68000: [libc++] Remove C++03 variadics in shared_ptr (v2).
Sep 24 2019, 5:23 PM · Restricted Project
zoecarver added a comment to D67675: [libc++] Remove C++03 variadics in shared_ptr.

Resolved by r372780 (can't close for some reason).

Sep 24 2019, 2:30 PM · Restricted Project
zoecarver committed rG4278a9e6b502: [libc++] Remove C++03 variadics in shared_ptr (authored by zoecarver).
[libc++] Remove C++03 variadics in shared_ptr
Sep 24 2019, 1:59 PM
zoecarver committed rL372780: [libc++] Remove C++03 variadics in shared_ptr.
[libc++] Remove C++03 variadics in shared_ptr
Sep 24 2019, 1:54 PM
zoecarver added a comment to D67675: [libc++] Remove C++03 variadics in shared_ptr.

Yes, tests pass.

Sep 24 2019, 1:49 PM · Restricted Project
zoecarver added a comment to D65161: [libc++] Implement LWG 2510.

LGTM.

Sep 24 2019, 1:30 PM · Restricted Project, Restricted Project

Sep 23 2019

zoecarver updated the diff for D67900: [libc++] Use builtin type traits whenever possible.
  • Enable use of builtins once fixed in clang
Sep 23 2019, 11:15 AM · Restricted Project
zoecarver closed D67899: Fix __is_fundamental to accept nullptr_t.

Resolved by rL372624.

Sep 23 2019, 9:07 AM · Restricted Project
zoecarver committed rGa9f926c8b2f6: Fix __is_fundamental to accept nullptr_t (authored by zoecarver).
Fix __is_fundamental to accept nullptr_t
Sep 23 2019, 9:03 AM
zoecarver committed rL372624: Fix __is_fundamental to accept nullptr_t.
Fix __is_fundamental to accept nullptr_t
Sep 23 2019, 9:03 AM
zoecarver closed D67897: Fix __is_signed builtin.

Resolved by rL372621.

Sep 23 2019, 8:48 AM · Restricted Project
zoecarver committed rG511dbd83d63c: Fix __is_signed builtin (authored by zoecarver).
Fix __is_signed builtin
Sep 23 2019, 8:44 AM
zoecarver committed rL372621: Fix __is_signed builtin.
Fix __is_signed builtin
Sep 23 2019, 8:39 AM
zoecarver added inline comments to D67897: Fix __is_signed builtin.
Sep 23 2019, 8:14 AM · Restricted Project

Sep 22 2019

zoecarver updated the diff for D67897: Fix __is_signed builtin.
  • fix behavior when passed an enumeration type
Sep 22 2019, 9:21 PM · Restricted Project
zoecarver created D67900: [libc++] Use builtin type traits whenever possible.
Sep 22 2019, 8:36 PM · Restricted Project
zoecarver updated the diff for D67897: Fix __is_signed builtin.
  • fix docs
Sep 22 2019, 8:21 PM · Restricted Project
zoecarver added a comment to D67897: Fix __is_signed builtin.

(Can I interest you in fixing the misbehaviour for enumeration types too?)

Sep 22 2019, 8:21 PM · Restricted Project
zoecarver created D67899: Fix __is_fundamental to accept nullptr_t.
Sep 22 2019, 8:19 PM · Restricted Project
zoecarver added a comment to D67897: Fix __is_signed builtin.

But std::is_signed_v<float> needs to yield false. Isn't it cleaner to leave the compiler builtin matching the library type-trait, so that the library doesn't have to check for integral types separately?

Sep 22 2019, 4:53 PM · Restricted Project
zoecarver created D67897: Fix __is_signed builtin.
Sep 22 2019, 4:26 PM · Restricted Project

Sep 20 2019

zoecarver updated the diff for D67675: [libc++] Remove C++03 variadics in shared_ptr.
  • merge c++03 tests with other tests and always enable
Sep 20 2019, 9:10 AM · Restricted Project
zoecarver added inline comments to D67052: Add reference type transformation builtins.
Sep 20 2019, 6:29 AM · Restricted Project, Restricted Project
zoecarver updated the diff for D67052: Add reference type transformation builtins.
  • address review comments
  • fix warnings in build
Sep 20 2019, 6:25 AM · Restricted Project, Restricted Project

Sep 19 2019

zoecarver added inline comments to D67052: Add reference type transformation builtins.
Sep 19 2019, 6:58 PM · Restricted Project, Restricted Project
zoecarver added inline comments to D67052: Add reference type transformation builtins.
Sep 19 2019, 2:53 PM · Restricted Project, Restricted Project