User Details
- User Since
- May 15 2021, 8:44 AM (53 w, 5 d)
Today
- Remove unnecessary trailing /
- Add -SAME in tests
Yesterday
LGTM!
Tue, May 24
I'm not super familiar with concepts but this LGTM, thanks!
Fri, May 20
Looks like index-concepts.cpp is failing on Windows, @arphaman could you please take a look?
Fri, May 13
Thu, May 12
Remove static analyzer changes
Mar 22 2022
LGTM
Mar 21 2022
Fix clang-format warnings
Mar 18 2022
Mar 17 2022
- Fix off-by-one error in fix-it generation logic: the last SubjectMatchRule
(SubjectMatchRule_variable_not_is_parameter) was not handled properly
- Add a test for this
Mar 15 2022
Thanks for the review @aaron.ballman!
Merge two test files into one to speed up testing
Mar 14 2022
- Only allow one attribute syntax style per directive
- Adjust documentation
- Add a release note
Rename a lambda to improve readability
Mar 11 2022
Mar 9 2022
Remove unused include
Mar 7 2022
Apologies for landing this too quickly! I'll adjust this logic in a separate patch: https://reviews.llvm.org/D121141
Mar 1 2022
Feb 22 2022
Feb 18 2022
Feb 17 2022
- Add unit-tests to verify that DriverKit version defaults to 19
- Use DriverKit 20 as a minimum available version on arm & add a test for it
Feb 15 2022
Thank you @dgoldman, this approach looks good to me.
I don't have anything to add other than what @sammccall has already commented.
Feb 2 2022
LGTM!
Feb 1 2022
Thanks @aaron.ballman for your feedback. I will probably abandon this change until we have a more compelling reason to apply attributes to types via pragmas.
Jan 25 2022
Fix clang-format warnings in the added code
Jan 24 2022
Jan 21 2022
Jan 17 2022
LGTM!
Jan 12 2022
Add a test for a diagnostic without VersionMap & fix clang-format warning
Jan 11 2022
Jan 10 2022
Fix clang-format warning
Diagnose mismatches between class property of a class and a class property of its superclass.
Jan 7 2022
Thank you @aaron.ballman, I will try to get this patch into the next 13.0.x release.
Remove accidental change
Jan 5 2022
Fix lint warning
Add a test to verify that iOS_tvOS mapping is parsed correctly.