Page MenuHomePhabricator

egorzhdan (Egor Zhdan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2021, 8:44 AM (53 w, 5 d)

Recent Activity

Today

egorzhdan updated the diff for D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.
  • Remove unnecessary trailing /
  • Add -SAME in tests
Thu, May 26, 5:50 AM · Restricted Project, Restricted Project

Yesterday

egorzhdan added inline comments to D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.
Wed, May 25, 3:51 PM · Restricted Project, Restricted Project
egorzhdan accepted D126332: [clang] Fix the begin location of concepts specialization expression.

LGTM!

Wed, May 25, 11:04 AM · Restricted Project, Restricted Project

Tue, May 24

egorzhdan accepted D126031: [libclang] add supporting for indexing/visiting C++ concepts.

I'm not super familiar with concepts but this LGTM, thanks!

Tue, May 24, 9:00 AM · Restricted Project, Restricted Project
egorzhdan added reviewers for D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux: arphaman, MaskRay.
Tue, May 24, 4:15 AM · Restricted Project, Restricted Project
egorzhdan requested review of D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.
Tue, May 24, 4:14 AM · Restricted Project, Restricted Project

Fri, May 20

egorzhdan added a comment to D126031: [libclang] add supporting for indexing/visiting C++ concepts.

Looks like index-concepts.cpp is failing on Windows, @arphaman could you please take a look?

Fri, May 20, 9:43 AM · Restricted Project, Restricted Project

Fri, May 13

egorzhdan committed rGaf845d7e437a: [Clang] Fix DriverKit tests on Linux (authored by egorzhdan).
[Clang] Fix DriverKit tests on Linux
Fri, May 13, 2:10 PM · Restricted Project, Restricted Project
egorzhdan committed rG2f04e703bff3: [Clang] Add DriverKit support (authored by egorzhdan).
[Clang] Add DriverKit support
Fri, May 13, 12:35 PM · Restricted Project, Restricted Project
egorzhdan closed D121911: [Clang] Add DriverKit support.
Fri, May 13, 12:35 PM · Restricted Project, Restricted Project

Thu, May 12

egorzhdan updated the diff for D121911: [Clang] Add DriverKit support.

Remove static analyzer changes

Thu, May 12, 11:06 AM · Restricted Project, Restricted Project

Mar 22 2022

egorzhdan accepted D122232: [clang][NFC] Refactor logic for picking standard library on Apple.

LGTM

Mar 22 2022, 8:58 AM · Restricted Project, Restricted Project

Mar 21 2022

egorzhdan updated the diff for D121911: [Clang] Add DriverKit support.

Fix clang-format warnings

Mar 21 2022, 7:07 AM · Restricted Project, Restricted Project

Mar 18 2022

egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.

The commit message got a bit mutilated: 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6

Just FYI in case you didn't notice. In that case, update your commit workflow to make sure this doesn't happen next time :)

Mar 18 2022, 5:48 AM · Restricted Project, Restricted Project
egorzhdan committed rG33a9eac6aaa4: [Clang] Support multiple attributes in a single pragma (authored by egorzhdan).
[Clang] Support multiple attributes in a single pragma
Mar 18 2022, 5:21 AM · Restricted Project
egorzhdan closed D121283: [Clang] Support multiple attributes in a single pragma.
Mar 18 2022, 5:20 AM · Restricted Project, Restricted Project

Mar 17 2022

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.
  • Fix off-by-one error in fix-it generation logic: the last SubjectMatchRule

(SubjectMatchRule_variable_not_is_parameter) was not handled properly

  • Add a test for this
Mar 17 2022, 12:21 PM · Restricted Project, Restricted Project
egorzhdan requested review of D121911: [Clang] Add DriverKit support.
Mar 17 2022, 6:49 AM · Restricted Project, Restricted Project

Mar 15 2022

egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.

Thanks for the review @aaron.ballman!

Mar 15 2022, 11:47 AM · Restricted Project, Restricted Project
egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.

Merge two test files into one to speed up testing

Mar 15 2022, 11:46 AM · Restricted Project, Restricted Project

Mar 14 2022

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.
  • Only allow one attribute syntax style per directive
  • Adjust documentation
  • Add a release note
Mar 14 2022, 1:25 PM · Restricted Project, Restricted Project
egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.

As a thought experiment, would it make sense to lift the restriction on the number of attributes allowed in a pragma, but not allow multiple attribute specifiers?

Mar 14 2022, 12:58 PM · Restricted Project, Restricted Project
egorzhdan committed rG6ca2f1938f96: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array… (authored by egorzhdan).
[Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array…
Mar 14 2022, 5:48 AM · Restricted Project
egorzhdan closed D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.
Mar 14 2022, 5:47 AM · Restricted Project, Restricted Project
egorzhdan updated the diff for D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.

Rename a lambda to improve readability

Mar 14 2022, 5:11 AM · Restricted Project, Restricted Project

Mar 11 2022

egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.

why do we support multiple attribute *specifiers* in the same pragma? I would not expect to be able to mix attribute styles in the same pragma given that all of the individual styles allow you to specify multiple attributes within a single specifier

Mar 11 2022, 11:32 AM · Restricted Project, Restricted Project
egorzhdan requested review of D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.
Mar 11 2022, 10:02 AM · Restricted Project, Restricted Project

Mar 9 2022

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.

Remove unused include

Mar 9 2022, 4:48 AM · Restricted Project, Restricted Project
egorzhdan added a reviewer for D121283: [Clang] Support multiple attributes in a single pragma: aaron.ballman.
Mar 9 2022, 4:47 AM · Restricted Project, Restricted Project
egorzhdan requested review of D121283: [Clang] Support multiple attributes in a single pragma.
Mar 9 2022, 4:46 AM · Restricted Project, Restricted Project

Mar 7 2022

egorzhdan added reviewers for D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes: ldionne, var-const, zoecarver, Mordante.
Mar 7 2022, 11:38 AM · Restricted Project, Restricted Project
Herald added a project to D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features: Restricted Project.

Apologies for landing this too quickly! I'll adjust this logic in a separate patch: https://reviews.llvm.org/D121141

Mar 7 2022, 11:37 AM · Restricted Project, Restricted Project
egorzhdan requested review of D121141: [Clang] Add `-funstable` flag to enable unstable and experimental features: follow-up fixes.
Mar 7 2022, 11:36 AM · Restricted Project, Restricted Project

Mar 1 2022

egorzhdan committed rG3cdc1c155b40: [Clang] Add `-funstable` flag to enable unstable and experimental features (authored by egorzhdan).
[Clang] Add `-funstable` flag to enable unstable and experimental features
Mar 1 2022, 4:35 AM
egorzhdan closed D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features.
Mar 1 2022, 4:35 AM · Restricted Project, Restricted Project

Feb 22 2022

egorzhdan committed rG3a1cb362370d: Add DriverKit support (authored by egorzhdan).
Add DriverKit support
Feb 22 2022, 5:43 AM
egorzhdan closed D118046: Add DriverKit support.
Feb 22 2022, 5:43 AM · Restricted Project

Feb 18 2022

egorzhdan added reviewers for D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features: ldionne, zoecarver, var-const.
Feb 18 2022, 1:12 PM · Restricted Project, Restricted Project
egorzhdan requested review of D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features.
Feb 18 2022, 1:11 PM · Restricted Project, Restricted Project

Feb 17 2022

egorzhdan updated the diff for D118046: Add DriverKit support.
  • Add unit-tests to verify that DriverKit version defaults to 19
  • Use DriverKit 20 as a minimum available version on arm & add a test for it
Feb 17 2022, 12:11 PM · Restricted Project

Feb 15 2022

egorzhdan added a comment to D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references.

Thank you @dgoldman, this approach looks good to me.
I don't have anything to add other than what @sammccall has already commented.

Feb 15 2022, 5:32 AM · Restricted Project

Feb 2 2022

egorzhdan accepted D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.

LGTM!

Feb 2 2022, 6:17 AM · Restricted Project

Feb 1 2022

egorzhdan abandoned D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute.

Thanks @aaron.ballman for your feedback. I will probably abandon this change until we have a more compelling reason to apply attributes to types via pragmas.

Feb 1 2022, 11:08 AM · Restricted Project

Jan 25 2022

egorzhdan updated the diff for D118046: Add DriverKit support.

Fix clang-format warnings in the added code

Jan 25 2022, 5:00 AM · Restricted Project

Jan 24 2022

egorzhdan requested review of D118046: Add DriverKit support.
Jan 24 2022, 7:37 AM · Restricted Project

Jan 21 2022

egorzhdan added a reviewer for D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute: arphaman.
Jan 21 2022, 3:14 PM · Restricted Project
egorzhdan requested review of D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute.
Jan 21 2022, 3:14 PM · Restricted Project

Jan 17 2022

egorzhdan accepted D117348: [Preprocessor] Reduce the memory overhead of `#define` directives.

LGTM!

Jan 17 2022, 10:59 AM · Restricted Project

Jan 12 2022

egorzhdan committed rG3a32d2e74e5c: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS… (authored by egorzhdan).
[Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS…
Jan 12 2022, 9:53 AM
egorzhdan closed D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability.
Jan 12 2022, 9:53 AM · Restricted Project
egorzhdan updated the diff for D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability.

Add a test for a diagnostic without VersionMap & fix clang-format warning

Jan 12 2022, 7:38 AM · Restricted Project

Jan 11 2022

egorzhdan committed rGfda47db8ee1d: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties (authored by egorzhdan).
[Clang][Sema] Fix attribute mismatch warning for ObjC class properties
Jan 11 2022, 4:32 AM
egorzhdan closed D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties.
Jan 11 2022, 4:32 AM · Restricted Project

Jan 10 2022

egorzhdan updated the diff for D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties.

Fix clang-format warning

Jan 10 2022, 3:05 PM · Restricted Project
egorzhdan updated the diff for D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties.

Diagnose mismatches between class property of a class and a class property of its superclass.

Jan 10 2022, 5:58 AM · Restricted Project

Jan 7 2022

egorzhdan added a comment to D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument.

We may have time to fit it in to the release, but no guarantees. Can you file an issue for this?

Jan 7 2022, 2:56 PM · Restricted Project
egorzhdan added a comment to D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument.

Thank you @aaron.ballman, I will try to get this patch into the next 13.0.x release.

Jan 7 2022, 1:17 PM · Restricted Project
egorzhdan updated the diff for D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability.

Remove accidental change

Jan 7 2022, 10:38 AM · Restricted Project
egorzhdan added a reviewer for D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability: arphaman.
Jan 7 2022, 10:14 AM · Restricted Project
egorzhdan requested review of D116822: [Clang][Sema] Use VersionMap from SDKSettings for remapping tvOS and watchOS availability.
Jan 7 2022, 10:14 AM · Restricted Project

Jan 5 2022

egorzhdan updated the diff for D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.

Fix lint warning

Jan 5 2022, 7:15 AM · Restricted Project
egorzhdan updated the diff for D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.

Add a test to verify that iOS_tvOS mapping is parsed correctly.

Jan 5 2022, 5:17 AM · Restricted Project

Jan 4 2022

egorzhdan added a reviewer for D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS: arphaman.
Jan 4 2022, 12:01 PM · Restricted Project
egorzhdan requested review of D116615: [Clang] Extract availability mapping from VersionMap for watchOS/tvOS.
Jan 4 2022, 12:00 PM · Restricted Project
egorzhdan added reviewers for D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties: jansvoboda11, arphaman.
Jan 4 2022, 9:39 AM · Restricted Project

Dec 31 2021

egorzhdan added a reviewer for D116459: [Clang][Sema] Adjust formatting (NFC): arphaman.
Dec 31 2021, 10:45 AM · Restricted Project
egorzhdan requested review of D116459: [Clang][Sema] Adjust formatting (NFC).
Dec 31 2021, 10:44 AM · Restricted Project

Dec 30 2021

egorzhdan requested review of D116412: [Clang][Sema] Fix attribute mismatch warning for ObjC class properties.
Dec 30 2021, 6:27 AM · Restricted Project

Dec 24 2021

egorzhdan added a reviewer for D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument: aaron.ballman.
Dec 24 2021, 1:22 PM · Restricted Project
egorzhdan requested review of D116272: [Clang][Sema] Avoid crashing for va_arg expressions with bool argument.
Dec 24 2021, 1:20 PM · Restricted Project