User Details
- User Since
- May 15 2021, 8:44 AM (106 w, 6 d)
Mon, May 15
@Bigcheese, @ChuanqiXu, could you please take a look at this patch?
Thu, May 4
Nov 24 2022
LGTM!
Nov 22 2022
Nov 21 2022
LGTM, thanks!
Nov 10 2022
Oct 31 2022
Preserve CodeCompletionResult::ResultKind and do the conversion to
CXCompletionResultKind in CIndexCodeCompletion.cpp.
Oct 30 2022
Fix clangd compilation
Oct 27 2022
Oct 21 2022
Sep 2 2022
Sep 1 2022
Aug 31 2022
Rebase to apply fixes to string conversion
XFAIL a test that was accidentally passing because of incorrect behavior
Aug 30 2022
- Add tests for conversion of doc comments to HTML/XML
- Fix a bug in StringRef -> CXString conversion logic for an empty string
Jul 22 2022
Thanks @brad @3405691582 @MaskRay for the review!
Jul 20 2022
- Add a test for OpenBSD
- Modify existing test file instead of adding a new file
Jul 13 2022
Jun 29 2022
Adjust commit message
Jun 28 2022
Jun 27 2022
Jun 10 2022
LGTM!
May 27 2022
Rebase & fix formatting
- Change arg type from std::string to StringRef
- Remove unnecessary //
• Remove unneeded test
May 26 2022
- Remove unnecessary trailing /
- Add -SAME in tests
May 25 2022
LGTM!
May 24 2022
I'm not super familiar with concepts but this LGTM, thanks!
May 20 2022
Looks like index-concepts.cpp is failing on Windows, @arphaman could you please take a look?
May 13 2022
May 12 2022
Remove static analyzer changes
Mar 22 2022
LGTM
Mar 21 2022
Fix clang-format warnings
Mar 18 2022
Mar 17 2022
- Fix off-by-one error in fix-it generation logic: the last SubjectMatchRule
(SubjectMatchRule_variable_not_is_parameter) was not handled properly
- Add a test for this
Mar 15 2022
Thanks for the review @aaron.ballman!
Merge two test files into one to speed up testing
Mar 14 2022
- Only allow one attribute syntax style per directive
- Adjust documentation
- Add a release note
Rename a lambda to improve readability
Mar 11 2022
Mar 9 2022
Remove unused include
Mar 7 2022
Apologies for landing this too quickly! I'll adjust this logic in a separate patch: https://reviews.llvm.org/D121141
Mar 1 2022
Feb 22 2022
Feb 18 2022
Feb 17 2022
- Add unit-tests to verify that DriverKit version defaults to 19
- Use DriverKit 20 as a minimum available version on arm & add a test for it
Feb 15 2022
Thank you @dgoldman, this approach looks good to me.
I don't have anything to add other than what @sammccall has already commented.
Feb 2 2022
LGTM!
Feb 1 2022
Thanks @aaron.ballman for your feedback. I will probably abandon this change until we have a more compelling reason to apply attributes to types via pragmas.
Jan 25 2022
Fix clang-format warnings in the added code