• Remove unnecessary trailing /
• Add -SAME in tests

LGTM!

I'm not super familiar with concepts but this LGTM, thanks!

Looks like index-concepts.cpp is failing on Windows, @arphaman could you please take a look?

Remove static analyzer changes

LGTM

Fix clang-format warnings

In D121283#3392137, @thakis wrote:

The commit message got a bit mutilated: 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6

Just FYI in case you didn't notice. In that case, update your commit workflow to make sure this doesn't happen next time :)

• Fix off-by-one error in fix-it generation logic: the last SubjectMatchRule

(SubjectMatchRule_variable_not_is_parameter) was not handled properly

• Add a test for this

Thanks for the review @aaron.ballman!

Merge two test files into one to speed up testing

• Only allow one attribute syntax style per directive
• Adjust documentation
• Add a release note

In D121283#3379225, @aaron.ballman wrote:

As a thought experiment, would it make sense to lift the restriction on the number of attributes allowed in a pragma, but not allow multiple attribute specifiers?

Rename a lambda to improve readability

In D121283#3373560, @aaron.ballman wrote:

why do we support multiple attribute *specifiers* in the same pragma? I would not expect to be able to mix attribute styles in the same pragma given that all of the individual styles allow you to specify multiple attributes within a single specifier

Remove unused include

Apologies for landing this too quickly! I'll adjust this logic in a separate patch: https://reviews.llvm.org/D121141

• Add unit-tests to verify that DriverKit version defaults to 19
• Use DriverKit 20 as a minimum available version on arm & add a test for it

Thank you @dgoldman, this approach looks good to me.
I don't have anything to add other than what @sammccall has already commented.

LGTM!

Thanks @aaron.ballman for your feedback. I will probably abandon this change until we have a more compelling reason to apply attributes to types via pragmas.

Fix clang-format warnings in the added code

LGTM!

Add a test for a diagnostic without VersionMap & fix clang-format warning

Fix clang-format warning

Diagnose mismatches between class property of a class and a class property of its superclass.

In D116272#3228427, @tstellar wrote:

We may have time to fit it in to the release, but no guarantees. Can you file an issue for this?

Thank you @aaron.ballman, I will try to get this patch into the next 13.0.x release.

Remove accidental change

Fix lint warning

Add a test to verify that iOS_tvOS mapping is parsed correctly.