Page MenuHomePhabricator
People egorzhdan

egorzhdan (Egor Zhdan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 15 2021, 8:44 AM (106 w, 6 d)

Recent Activity
View All

Mon, May 15

egorzhdan added a comment to D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap.

@Bigcheese, @ChuanqiXu, could you please take a look at this patch?

Mon, May 15, 3:28 AM · Restricted Project, Restricted Project

Thu, May 4

egorzhdan added a reviewer for D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap: bruno.
Thu, May 4, 7:17 AM · Restricted Project, Restricted Project
egorzhdan requested review of D149850: [Clang][Modules] Support `requires cplusplus20` in a modulemap.
Thu, May 4, 7:16 AM · Restricted Project, Restricted Project

Nov 24 2022

egorzhdan accepted D138630: [modules] Fix marking `ObjCMethodDecl::isOverriding` when there a no overrides..

LGTM!

Nov 24 2022, 3:56 AM · Restricted Project, Restricted Project

Nov 22 2022

egorzhdan closed D138434: [Clang][Sema] Added space after ',' in a warning.

Merged: https://reviews.llvm.org/rGcdfb65e5e7182a02005b3611aa28288890b9e296

Nov 22 2022, 5:29 AM · Restricted Project, Restricted Project
egorzhdan committed rGcdfb65e5e718: [Clang][Sema] Added space after ',' in a warning (authored by fahadnayyar).
[Clang][Sema] Added space after ',' in a warning
Nov 22 2022, 5:28 AM · Restricted Project, Restricted Project

Nov 21 2022

egorzhdan accepted D138434: [Clang][Sema] Added space after ',' in a warning.

LGTM, thanks!

Nov 21 2022, 7:18 AM · Restricted Project, Restricted Project

Nov 10 2022

egorzhdan committed rG97105e5bf70f: [libclang] Expose completion result kind in `CXCompletionResult` (authored by egorzhdan).
[libclang] Expose completion result kind in `CXCompletionResult`
Nov 10 2022, 4:17 PM · Restricted Project, Restricted Project
egorzhdan closed D136844: [libclang] Expose completion result kind in `CXCompletionResult`.
Nov 10 2022, 4:16 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 31 2022

egorzhdan updated the diff for D136844: [libclang] Expose completion result kind in `CXCompletionResult`.

Preserve CodeCompletionResult::ResultKind and do the conversion to
CXCompletionResultKind in CIndexCodeCompletion.cpp.

Oct 31 2022, 3:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
egorzhdan added inline comments to D136844: [libclang] Expose completion result kind in `CXCompletionResult`.
Oct 31 2022, 11:18 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 30 2022

egorzhdan added inline comments to D136844: [libclang] Expose completion result kind in `CXCompletionResult`.
Oct 30 2022, 8:28 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
egorzhdan updated the diff for D136844: [libclang] Expose completion result kind in `CXCompletionResult`.

Fix clangd compilation

Oct 30 2022, 8:27 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 27 2022

egorzhdan requested review of D136844: [libclang] Expose completion result kind in `CXCompletionResult`.
Oct 27 2022, 6:46 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Oct 21 2022

Herald added a project to D92797: APINotes: add initial stub of APINotesWriter: Restricted Project.
Oct 21 2022, 6:06 PM · Restricted Project, Restricted Project

Sep 2 2022

egorzhdan committed rG7c232b086720: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c` (authored by egorzhdan).
[Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`
Sep 2 2022, 4:35 AM · Restricted Project, Restricted Project
egorzhdan closed D133105: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`.
Sep 2 2022, 4:34 AM · Restricted Project, Restricted Project

Sep 1 2022

egorzhdan requested review of D133105: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`.
Sep 1 2022, 5:31 AM · Restricted Project, Restricted Project
egorzhdan added inline comments to D133009: [libclang] Fix conversion from `StringRef` to `CXString`.
Sep 1 2022, 5:29 AM · Restricted Project, Restricted Project
egorzhdan committed rG0cb080933654: [Clang][Comments] Parse `<img src=""/>` in doc comments correctly (authored by egorzhdan).
[Clang][Comments] Parse `<img src=""/>` in doc comments correctly
Sep 1 2022, 5:18 AM · Restricted Project, Restricted Project
egorzhdan closed D132932: [Clang][Comments] Parse `<img src=""/>` in doc comments correctly.
Sep 1 2022, 5:17 AM · Restricted Project, Restricted Project

Aug 31 2022

egorzhdan updated the diff for D132932: [Clang][Comments] Parse `<img src=""/>` in doc comments correctly.

Rebase to apply fixes to string conversion

Aug 31 2022, 9:42 AM · Restricted Project, Restricted Project
egorzhdan committed rG8c0935238527: [libclang] Fix conversion from `StringRef` to `CXString` (authored by egorzhdan).
[libclang] Fix conversion from `StringRef` to `CXString`
Aug 31 2022, 9:40 AM · Restricted Project, Restricted Project
egorzhdan closed D133009: [libclang] Fix conversion from `StringRef` to `CXString`.
Aug 31 2022, 9:40 AM · Restricted Project, Restricted Project
egorzhdan added inline comments to D133009: [libclang] Fix conversion from `StringRef` to `CXString`.
Aug 31 2022, 8:46 AM · Restricted Project, Restricted Project
egorzhdan added reviewers for D133009: [libclang] Fix conversion from `StringRef` to `CXString`: dario.domizioli, aaronpuchert.
Aug 31 2022, 6:03 AM · Restricted Project, Restricted Project
egorzhdan added inline comments to D133009: [libclang] Fix conversion from `StringRef` to `CXString`.
Aug 31 2022, 6:03 AM · Restricted Project, Restricted Project
egorzhdan updated the diff for D133009: [libclang] Fix conversion from `StringRef` to `CXString`.

XFAIL a test that was accidentally passing because of incorrect behavior

Aug 31 2022, 6:00 AM · Restricted Project, Restricted Project
egorzhdan requested review of D133009: [libclang] Fix conversion from `StringRef` to `CXString`.
Aug 31 2022, 2:59 AM · Restricted Project, Restricted Project

Aug 30 2022

egorzhdan added inline comments to D132932: [Clang][Comments] Parse `<img src=""/>` in doc comments correctly.
Aug 30 2022, 10:02 AM · Restricted Project, Restricted Project
egorzhdan added inline comments to D132932: [Clang][Comments] Parse `<img src=""/>` in doc comments correctly.
Aug 30 2022, 7:57 AM · Restricted Project, Restricted Project
egorzhdan updated the diff for D132932: [Clang][Comments] Parse `<img src=""/>` in doc comments correctly.
  • Add tests for conversion of doc comments to HTML/XML
  • Fix a bug in StringRef -> CXString conversion logic for an empty string
Aug 30 2022, 7:56 AM · Restricted Project, Restricted Project
egorzhdan added reviewers for D132932: [Clang][Comments] Parse `<img src=""/>` in doc comments correctly: arphaman, gribozavr, aaronpuchert.
Aug 30 2022, 5:05 AM · Restricted Project, Restricted Project
egorzhdan requested review of D132932: [Clang][Comments] Parse `<img src=""/>` in doc comments correctly.
Aug 30 2022, 5:03 AM · Restricted Project, Restricted Project

Jul 22 2022

egorzhdan committed rG1d0cc510516d: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD (authored by egorzhdan).
[Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD
Jul 22 2022, 6:31 AM · Restricted Project, Restricted Project
egorzhdan closed D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD.
Jul 22 2022, 6:30 AM · Restricted Project, Restricted Project, Restricted Project
egorzhdan added a comment to D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD.

Thanks @brad @3405691582 @MaskRay for the review!

Jul 22 2022, 6:29 AM · Restricted Project, Restricted Project, Restricted Project

Jul 20 2022

egorzhdan updated the diff for D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD.
  • Add a test for OpenBSD
  • Modify existing test file instead of adding a new file
Jul 20 2022, 11:45 AM · Restricted Project, Restricted Project, Restricted Project

Jul 13 2022

egorzhdan added reviewers for D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD: 3405691582, MaskRay.
Jul 13 2022, 8:49 AM · Restricted Project, Restricted Project, Restricted Project
egorzhdan requested review of D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD.
Jul 13 2022, 8:47 AM · Restricted Project, Restricted Project, Restricted Project

Jun 29 2022

egorzhdan committed rG5f2cf3a21f3a: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs… (authored by egorzhdan).
[Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs…
Jun 29 2022, 11:37 AM · Restricted Project, Restricted Project
egorzhdan closed D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing.
Jun 29 2022, 11:36 AM · Restricted Project, Restricted Project
egorzhdan updated the summary of D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing.
Jun 29 2022, 6:17 AM · Restricted Project, Restricted Project
egorzhdan updated the diff for D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing.

Adjust commit message

Jun 29 2022, 6:16 AM · Restricted Project, Restricted Project
egorzhdan requested review of D128814: [Clang][Preprocessor] Fix inconsistent `FLT_EVAL_METHOD` when compiling vs preprocessing.
Jun 29 2022, 6:11 AM · Restricted Project, Restricted Project

Jun 28 2022

egorzhdan committed rGbe4b40d5bc6c: [MC] Allow annotating custom sections as zerofill (authored by egorzhdan).
[MC] Allow annotating custom sections as zerofill
Jun 28 2022, 7:10 AM · Restricted Project, Restricted Project
egorzhdan closed D128654: [MC] Allow annotating custom sections as zerofill.
Jun 28 2022, 7:10 AM · Restricted Project, Restricted Project

Jun 27 2022

egorzhdan added a reviewer for D128654: [MC] Allow annotating custom sections as zerofill: jroelofs.
Jun 27 2022, 8:30 AM · Restricted Project, Restricted Project
egorzhdan requested review of D128654: [MC] Allow annotating custom sections as zerofill.
Jun 27 2022, 8:29 AM · Restricted Project, Restricted Project

Jun 10 2022

egorzhdan accepted D127408: [clang][driver] Introduce new -fdriver-only flag.

LGTM!

Jun 10 2022, 5:47 AM · Restricted Project, Restricted Project

May 27 2022

egorzhdan committed rGe917801eddbe: [Clang][Driver] Fix include paths for `--sysroot /` on Linux (authored by egorzhdan).
[Clang][Driver] Fix include paths for `--sysroot /` on Linux
May 27 2022, 8:52 AM · Restricted Project, Restricted Project
egorzhdan closed D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.
May 27 2022, 8:51 AM · Restricted Project, Restricted Project
egorzhdan updated the diff for D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.

Rebase & fix formatting

May 27 2022, 8:06 AM · Restricted Project, Restricted Project
egorzhdan added inline comments to D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.
May 27 2022, 6:34 AM · Restricted Project, Restricted Project
egorzhdan updated the diff for D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.
  • Change arg type from std::string to StringRef
  • Remove unnecessary //

• Remove unneeded test

May 27 2022, 6:31 AM · Restricted Project, Restricted Project

May 26 2022

egorzhdan updated the diff for D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.
  • Remove unnecessary trailing /
  • Add -SAME in tests
May 26 2022, 5:50 AM · Restricted Project, Restricted Project

May 25 2022

egorzhdan added inline comments to D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.
May 25 2022, 3:51 PM · Restricted Project, Restricted Project
egorzhdan accepted D126332: [clang] Fix the begin location of concepts specialization expression.

LGTM!

May 25 2022, 11:04 AM · Restricted Project, Restricted Project

May 24 2022

egorzhdan accepted D126031: [libclang] add supporting for indexing/visiting C++ concepts.

I'm not super familiar with concepts but this LGTM, thanks!

May 24 2022, 9:00 AM · Restricted Project, Restricted Project
egorzhdan added reviewers for D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux: arphaman, MaskRay.
May 24 2022, 4:15 AM · Restricted Project, Restricted Project
egorzhdan requested review of D126289: [Clang][Driver] Fix include paths for `--sysroot /` on Linux.
May 24 2022, 4:14 AM · Restricted Project, Restricted Project

May 20 2022

egorzhdan added a comment to D126031: [libclang] add supporting for indexing/visiting C++ concepts.

Looks like index-concepts.cpp is failing on Windows, @arphaman could you please take a look?

May 20 2022, 9:43 AM · Restricted Project, Restricted Project

May 13 2022

egorzhdan committed rGaf845d7e437a: [Clang] Fix DriverKit tests on Linux (authored by egorzhdan).
[Clang] Fix DriverKit tests on Linux
May 13 2022, 2:10 PM · Restricted Project, Restricted Project
egorzhdan committed rG2f04e703bff3: [Clang] Add DriverKit support (authored by egorzhdan).
[Clang] Add DriverKit support
May 13 2022, 12:35 PM · Restricted Project, Restricted Project
egorzhdan closed D121911: [Clang] Add DriverKit support.
May 13 2022, 12:35 PM · Restricted Project, Restricted Project

May 12 2022

egorzhdan updated the diff for D121911: [Clang] Add DriverKit support.

Remove static analyzer changes

May 12 2022, 11:06 AM · Restricted Project, Restricted Project

Mar 22 2022

egorzhdan accepted D122232: [clang][NFC] Refactor logic for picking standard library on Apple.

LGTM

Mar 22 2022, 8:58 AM · Restricted Project, Restricted Project

Mar 21 2022

egorzhdan updated the diff for D121911: [Clang] Add DriverKit support.

Fix clang-format warnings

Mar 21 2022, 7:07 AM · Restricted Project, Restricted Project

Mar 18 2022

egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.
In D121283#3392137, @thakis wrote:

The commit message got a bit mutilated: 33a9eac6aaa495fce6fd9b17cd48aa57a95461e6

Just FYI in case you didn't notice. In that case, update your commit workflow to make sure this doesn't happen next time :)

Mar 18 2022, 5:48 AM · Restricted Project, Restricted Project
egorzhdan committed rG33a9eac6aaa4: [Clang] Support multiple attributes in a single pragma (authored by egorzhdan).
[Clang] Support multiple attributes in a single pragma
Mar 18 2022, 5:21 AM · Restricted Project
egorzhdan closed D121283: [Clang] Support multiple attributes in a single pragma.
Mar 18 2022, 5:20 AM · Restricted Project, Restricted Project

Mar 17 2022

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.
  • Fix off-by-one error in fix-it generation logic: the last SubjectMatchRule

(SubjectMatchRule_variable_not_is_parameter) was not handled properly

  • Add a test for this
Mar 17 2022, 12:21 PM · Restricted Project, Restricted Project
egorzhdan requested review of D121911: [Clang] Add DriverKit support.
Mar 17 2022, 6:49 AM · Restricted Project, Restricted Project

Mar 15 2022

egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.

Thanks for the review @aaron.ballman!

Mar 15 2022, 11:47 AM · Restricted Project, Restricted Project
egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.

Merge two test files into one to speed up testing

Mar 15 2022, 11:46 AM · Restricted Project, Restricted Project

Mar 14 2022

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.
  • Only allow one attribute syntax style per directive
  • Adjust documentation
  • Add a release note
Mar 14 2022, 1:25 PM · Restricted Project, Restricted Project
egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.
In D121283#3379225, @aaron.ballman wrote:

As a thought experiment, would it make sense to lift the restriction on the number of attributes allowed in a pragma, but not allow multiple attribute specifiers?

Mar 14 2022, 12:58 PM · Restricted Project, Restricted Project
egorzhdan committed rG6ca2f1938f96: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array… (authored by egorzhdan).
[Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array…
Mar 14 2022, 5:48 AM · Restricted Project
egorzhdan closed D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.
Mar 14 2022, 5:47 AM · Restricted Project, Restricted Project
egorzhdan updated the diff for D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.

Rename a lambda to improve readability

Mar 14 2022, 5:11 AM · Restricted Project, Restricted Project

Mar 11 2022

egorzhdan added a comment to D121283: [Clang] Support multiple attributes in a single pragma.
In D121283#3373560, @aaron.ballman wrote:

why do we support multiple attribute *specifiers* in the same pragma? I would not expect to be able to mix attribute styles in the same pragma given that all of the individual styles allow you to specify multiple attributes within a single specifier

Mar 11 2022, 11:32 AM · Restricted Project, Restricted Project
egorzhdan requested review of D121475: [Clang][Sema] Avoid crashing for `__builtin_memcpy_inline` with an array argument.
Mar 11 2022, 10:02 AM · Restricted Project, Restricted Project

Mar 9 2022

egorzhdan updated the diff for D121283: [Clang] Support multiple attributes in a single pragma.

Remove unused include

Mar 9 2022, 4:48 AM · Restricted Project, Restricted Project
egorzhdan added a reviewer for D121283: [Clang] Support multiple attributes in a single pragma: aaron.ballman.
Mar 9 2022, 4:47 AM · Restricted Project, Restricted Project
egorzhdan requested review of D121283: [Clang] Support multiple attributes in a single pragma.
Mar 9 2022, 4:46 AM · Restricted Project, Restricted Project

Mar 7 2022

egorzhdan added reviewers for D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes: ldionne, var-const, zoecarver, Mordante.
Mar 7 2022, 11:38 AM · Restricted Project, Restricted Project
Herald added a project to D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features: Restricted Project.

Apologies for landing this too quickly! I'll adjust this logic in a separate patch: https://reviews.llvm.org/D121141

Mar 7 2022, 11:37 AM · Restricted Project, Restricted Project
egorzhdan requested review of D121141: [Clang] Add `-fexperimental-library` flag to enable unstable and experimental features: follow-up fixes.
Mar 7 2022, 11:36 AM · Restricted Project, Restricted Project

Mar 1 2022

egorzhdan committed rG3cdc1c155b40: [Clang] Add `-funstable` flag to enable unstable and experimental features (authored by egorzhdan).
[Clang] Add `-funstable` flag to enable unstable and experimental features
Mar 1 2022, 4:35 AM
egorzhdan closed D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features.
Mar 1 2022, 4:35 AM · Restricted Project, Restricted Project

Feb 22 2022

egorzhdan committed rG3a1cb362370d: Add DriverKit support (authored by egorzhdan).
Add DriverKit support
Feb 22 2022, 5:43 AM
egorzhdan closed D118046: Add DriverKit support.
Feb 22 2022, 5:43 AM · Restricted Project

Feb 18 2022

egorzhdan added reviewers for D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features: ldionne, zoecarver, var-const.
Feb 18 2022, 1:12 PM · Restricted Project, Restricted Project
egorzhdan requested review of D120160: [Clang] Add `-funstable` flag to enable unstable and experimental features.
Feb 18 2022, 1:11 PM · Restricted Project, Restricted Project

Feb 17 2022

egorzhdan updated the diff for D118046: Add DriverKit support.
  • Add unit-tests to verify that DriverKit version defaults to 19
  • Use DriverKit 20 as a minimum available version on arm & add a test for it
Feb 17 2022, 12:11 PM · Restricted Project

Feb 15 2022

egorzhdan added a comment to D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references.

Thank you @dgoldman, this approach looks good to me.
I don't have anything to add other than what @sammccall has already commented.

Feb 15 2022, 5:32 AM · Restricted Project

Feb 2 2022

egorzhdan accepted D116052: [clang] fix out of bounds access in an empty string when lexing a _Pragma with missing string token.

LGTM!

Feb 2 2022, 6:17 AM · Restricted Project

Feb 1 2022

egorzhdan abandoned D117931: [Clang] Support `address_space` attribute in `#pragma clang attribute.

Thanks @aaron.ballman for your feedback. I will probably abandon this change until we have a more compelling reason to apply attributes to types via pragmas.

Feb 1 2022, 11:08 AM · Restricted Project

Jan 25 2022

egorzhdan updated the diff for D118046: Add DriverKit support.

Fix clang-format warnings in the added code

Jan 25 2022, 5:00 AM · Restricted Project

Jan 24 2022

egorzhdan requested review of D118046: Add DriverKit support.
Jan 24 2022, 7:37 AM · Restricted Project