- User Since
- Mar 4 2016, 4:47 PM (275 w, 3 d)
Tue, Jun 8
Hi Amy, after your change, the compile time for one of our internal test files went from about 1 second to 30 seconds. I have put a repro and the details in PR50628, can you please take a look?
Sat, Jun 5
This change appears to be causing 6 or 7 lit tests to hang. Can you take a look and fix or revert?
Tue, Jun 1
Wed, May 26
Hi, we are noticing a regression in the quality of the code generated by the compiler for btver2 after this change.
Wed, May 19
Tue, May 18
Mon, May 17
Hi, this change has caused a regression in the codegen for one of our internal tests. Consider the following code:
May 14 2021
The test added in this commit was failing on the PS4 bot (https://lab.llvm.org/buildbot/#/builders/139/builds/4059). I've reverted the change in 59b419adc6e608db8d7c31efcc37f34c0b57b7d0 to get the bot green again.
May 6 2021
Apr 27 2021
Hi, the file you create here sectdata.txt is being flagged as a virus by Windows Defender in our internal bot causing the file to be automatically deleted and the test to fail. Is there a reason why you need to use that particular string for the file? Can something else be used that won't trigger the antivirus?
Apr 14 2021
This appears to be failing on the PS4 linux bot likely due to the PS4 target has exceptions disabled by default. Can you take a look?
Mar 31 2021
It also fails with the PS4 triple because we default to an external assembler that isn't present: https://lab.llvm.org/buildbot/#/builders/139/builds/2161/steps/6/logs/FAIL__Clang__as-version_s
Mar 30 2021
Mar 9 2021
Mar 8 2021
Hi, our internal x86_64 linux builder is failing after your commit with the error:
Feb 24 2021
FYI, arm64 is aarch64, not arm I believe. I've updated a few tests you added to reflect that.
Feb 21 2021
Feb 16 2021
Feb 11 2021
Feb 9 2021
It also failed on the PS4 linux bot: http://lab.llvm.org:8014/#/builders/125/builds/125
Feb 8 2021
Feb 5 2021
Jan 29 2021
PS4 changes lgtm.
Jan 22 2021
Updated patch with review feedback.
Thanks, I'll update my patch with your suggestions. I think I was using an older template for the jobs which is why I was using outdated stuff. Sorry about that!
Jan 19 2021
Update removing some unneeded stuff.
Jan 17 2021
Jan 15 2021
Jan 14 2021
Dec 18 2020
This issue also affects Windows, so please commit this change.
Dec 7 2020
Nov 23 2020
Hi Pavel, your change caused an assertion failure to be hit in our internal test suite. I have filed a repro with the assertion failure and a callstack in PR48277. Can you please take a look?
Nov 13 2020
The fix would normally be put in a separate change. If it is a small change, you could probably just do a post-commit review. We would like to get this either fixed or reverted so that we can get our internal build bot green again.
Oct 21 2020
Oct 19 2020
Sorry for the lack of context, I made my diffs using a new method this time, but I'll make sure it has the full context next time. Thanks!
Oct 13 2020
LGTM as well. I also tested it and it fails before your change, and passes with your change.
Hi, the test you added seems to pass both before and after your change, is this intended?
Oct 7 2020
Oct 2 2020
Sep 17 2020
I have reverted this change and the follow-up commit in b03c2b8395ba94fb53f1e73a6473faedf628bbd9. Hopefully this should get the bots green again.
Sep 2 2020
I have reverted this change in 8d2d0e84857cb1f2d01456eb433b5172d3a0772b to get the build bots green again.
Sep 1 2020
Aug 9 2020
Looks good, thanks for fixing this for us!
Aug 5 2020
Aug 4 2020
Jul 29 2020
Thanks for the fix!
Jul 22 2020
Jul 8 2020
Jul 1 2020
Jun 30 2020
@craig.topper, I made this fix after your refactor in 3537939cda86f0b5b06233eb99ddc9eb22935008. The main issue I wanted to bring to your attention is that you added FeatureLWP support to ZNVer1 which wasn't there before. If this is correct, please undo my change there. Thanks!
Jun 6 2020
I've reverted this change in g059ba74bb6f6166ca7c1783ef81dd37a5209b758 to get the bots green again.
Jun 2 2020
Matt, this change to the test was causing a failure in the upstream PS4 linux bot here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68593
May 23 2020
Hi, we noticed an issue with the GDB test suite that was bisected back to this change and I have put the details in PR46052. Can you take a look?