Page MenuHomePhabricator

dyung (Douglas Yung)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2016, 4:47 PM (367 w, 4 d)

Recent Activity

Fri, Mar 17

dyung added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@dyung I cannot reproduce this issue on two different machines in both cases tests work fine. For clang and llvm-jitlink binaries (the only binaries used in the tests) my changes are non-functional and I didn't change anything in compiler-rt or ORC. Are you able to reproduce the crashes locally?

So far I cannot on my own dev machines. I'll take the buildbot offline and try to see if I can figure out what is going on this weekend.

Fri, Mar 17, 9:25 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@dyung I cannot reproduce this issue on two different machines in both cases tests work fine. For clang and llvm-jitlink binaries (the only binaries used in the tests) my changes are non-functional and I didn't change anything in compiler-rt or ORC. Are you able to reproduce the crashes locally?

Fri, Mar 17, 5:01 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D143436: [clangd] Move standard options adaptor to CommandMangler.

@DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or revert if you need time to investigate?

Fri, Mar 17, 12:15 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D146189: [fuzzer] Use puts() rather than printf() in CopyFileToErr().

@rsundahl the test you added big-file-copy.test is failing on a buildbot, can you take a look?

Fri, Mar 17, 11:23 AM · Restricted Project, Restricted Project

Thu, Mar 16

dyung committed rG3e16488769b9: Mark test added in D145155 as requiring asserts since it uses the "-debug-only"… (authored by dyung).
Mark test added in D145155 as requiring asserts since it uses the "-debug-only"…
Thu, Mar 16, 3:04 PM · Restricted Project, Restricted Project

Wed, Mar 15

dyung committed rG406e2fbf6ac1: The test added in d8690bc requires ZLIB, so only run the test if… (authored by dyung).
The test added in d8690bc requires ZLIB, so only run the test if…
Wed, Mar 15, 8:21 PM · Restricted Project, Restricted Project

Tue, Mar 14

dyung added a comment to D145770: [clang-offload-bundler] Standardize TargetID field for bundler.

@lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, can you take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/37475

I don't know if it matters, but this bot only builds the x86_64 target.

Tue, Mar 14, 6:36 PM · Restricted Project, Restricted Project
dyung committed rG768211f48f2d: Mark test modified in e48ae0d as XFAIL for PS4/PS5 until the author can… (authored by dyung).
Mark test modified in e48ae0d as XFAIL for PS4/PS5 until the author can…
Tue, Mar 14, 6:36 PM · Restricted Project, Restricted Project
dyung added a comment to D145770: [clang-offload-bundler] Standardize TargetID field for bundler.

@lamb-j the test clang-offload-bundler.c is failing on the PS4 linux builder, can you take a look?

Tue, Mar 14, 4:28 PM · Restricted Project, Restricted Project

Thu, Mar 9

dyung added a comment to D143225: [SROA] Create additional vector type candidates based on store and load slices.

Hi @zhuhan0 one of our internal tests started to fail and I bisected it back to your change. I've put details and repro up in issue 61318, can you take a look?

Thu, Mar 9, 7:17 PM · Restricted Project, Restricted Project
dyung added a comment to D143225: [SROA] Create additional vector type candidates based on store and load slices.

Hi @zhuhan0 one of our internal tests started to fail and I bisected it back to your change. I've put details and repro up in issue 61318, can you take a look?

Thu, Mar 9, 6:57 PM · Restricted Project, Restricted Project

Mon, Mar 6

dyung added a comment to D145023: [memprof] Refactor tests to generate binaries and profiles on the fly..

@snehasish 3 of the tests you moved/added in this change are failing on a build bot, can you take a look and revert if you need time to investigate?

Mon, Mar 6, 3:22 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D132261: [SLP]Do not reduce repeated values, use scalar red ops instead..

@ABataev, one of our internal tests seems to hit an infinite loop in the compiler after this change. I have filed issue 61224 for the issue, can you take a look?

Mon, Mar 6, 10:46 AM · Restricted Project, Restricted Project

Fri, Mar 3

dyung added a reverting change for rGfe758254181a: Add the ability to segment GSYM files.: rGa14e3c2aa79f: Revert "Add the ability to segment GSYM files.".
Fri, Mar 3, 12:26 AM · Restricted Project, Restricted Project
dyung committed rGa14e3c2aa79f: Revert "Add the ability to segment GSYM files." (authored by dyung).
Revert "Add the ability to segment GSYM files."
Fri, Mar 3, 12:26 AM · Restricted Project, Restricted Project
dyung added a reverting change for D143793: Add the ability to segment GSYM files.: rGa14e3c2aa79f: Revert "Add the ability to segment GSYM files.".
Fri, Mar 3, 12:26 AM · Restricted Project, Restricted Project

Thu, Mar 2

dyung added a comment to D143793: Add the ability to segment GSYM files..

This change is causing multiple build bot failures in both the build and test stages:

Thu, Mar 2, 11:20 PM · Restricted Project, Restricted Project
dyung added a comment to D107662: [WebAssembly] Implement build-id feature.

@dschuff, I'm not sure if you are aware, but your change fails to build on Windows. You can see the failure on this buildbot:
https://lab.llvm.org/buildbot/#/builders/216/builds/17875

FAILED: tools/lld/wasm/CMakeFiles/lldWasm.dir/Writer.cpp.obj 
C:\bin\ccache.exe C:\PROGRA~2\MICROS~1\2019\BUILDT~1\VC\Tools\MSVC\1429~1.301\bin\HostX64\x64\cl.exe  /nologo /TP -DGTEST_HAS_RTTI=0 -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_GLIBCXX_ASSERTIONS -D_HAS_EXCEPTIONS=0 -D_LIBCPP_ENABLE_ASSERTIONS -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools\lld\wasm -IC:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\wasm -IC:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\include -Itools\lld\include -Iinclude -IC:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\llvm\include /DWIN32 /D_WINDOWS   /Zc:inline /Zc:preprocessor /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw /MD /O2 /Ob2   -wd4530 -wd4062  /EHs-c- /GR- -UNDEBUG -std:c++17 /showIncludes /Fotools\lld\wasm\CMakeFiles\lldWasm.dir\Writer.cpp.obj /Fdtools\lld\wasm\CMakeFiles\lldWasm.dir\lldWasm.pdb /FS -c C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\wasm\Writer.cpp
C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\wasm\Writer.cpp(263): error C2672: 'std::copy': no matching overloaded function found
C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\wasm\Writer.cpp(263): error C2780: '_FwdIt2 std::copy(_ExPo &&,_FwdIt1,_FwdIt1,_FwdIt2) noexcept': expects 4 arguments - 3 provided
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\xutility(4463): note: see declaration of 'std::copy'
C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\wasm\Writer.cpp(263): error C2782: '_OutIt std::copy(_InIt,_InIt,_OutIt)': template parameter '_InIt' is ambiguous
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\xutility(4452): note: see declaration of 'std::copy'
C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\wasm\Writer.cpp(263): note: could be '_Ty *'
        with
        [
            _Ty=uint8_t
        ]
C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\wasm\Writer.cpp(263): note: or       'std::_Array_iterator<_Ty,20>'
        with
        [
            _Ty=uint8_t
        ]
C:\buildbot-root\llvm-clang-x86_64-sie-win\llvm-project\lld\wasm\Writer.cpp(263): error C2784: '_OutIt std::copy(_InIt,_InIt,_OutIt)': could not deduce template argument for '_InIt' from '_Ty *'
        with
        [
            _Ty=uint8_t
        ]
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\VC\Tools\MSVC\14.29.30133\include\xutility(4452): note: see declaration of 'std::copy'

The failure was masked by an earlier failure which meant the buildbot never got to your code and so the failure didn't show up until the original problem was fixed.

Thu, Mar 2, 3:14 PM · Restricted Project, Restricted Project

Wed, Mar 1

dyung added a comment to D144677: [SelectionDAG] Transitively copy NodeExtraInfo on RAUW.

Hi @melver, we saw a large compile time increase in one of our internal tests which I bisected back to your change. I have filed issue #61108 for the problem, can you take a look?

Wed, Mar 1, 5:21 PM · Restricted Project, Restricted Project

Thu, Feb 23

dyung added a comment to D144673: Add tests to reproduce pointer/index width confusion crashes.

Do they really crash in -Asserts?

Thu, Feb 23, 7:55 PM · Restricted Project, Restricted Project

Feb 15 2023

dyung added a comment to D144030: [hwasan] Add definitions for missing operator delete functions .

It also failed with a similar error on our bot https://lab.llvm.org/buildbot/#/builders/247/builds/1627

Feb 15 2023, 12:22 PM · Restricted Project, Restricted Project

Feb 11 2023

dyung added a comment to D137527: [C++20] [Modules] [ClangScanDeps] Add ClangScanDeps support for C++20 Named Modules in P1689 format (2/4).

I'm still seeing random crashes today on a linux buildbot in the test you added P1689.cppm. Can you either fix or revert?

Feb 11 2023, 11:42 AM · Restricted Project, Restricted Project

Feb 8 2023

dyung added a comment to D143365: Remove -j argument to llvm-clang-x86_64-sie-win builder for lit testing.

If LIT default threads usage is what you are after, the patch looks good.

On some of my builders I have seen a benefit of restricting LIT with the number of jobs, because each "job" could use multiple threads on its own. If memory serves me well, reducing the number of LIT jobs to 32 off of available 64 threads reduced the overall test time. I assume you experimented on your worker and set what gives you the most benefit.

Feb 8 2023, 9:03 PM · Restricted Project, Restricted Project
dyung closed D143365: Remove -j argument to llvm-clang-x86_64-sie-win builder for lit testing.
Feb 8 2023, 9:01 PM · Restricted Project, Restricted Project
dyung committed rZORG91b1e24a8df6: Limit number of test threads for builder llvm-clang-x86_64-sie-win to the… (authored by dyung).
Limit number of test threads for builder llvm-clang-x86_64-sie-win to the…
Feb 8 2023, 9:01 PM · Restricted Project

Feb 6 2023

dyung added a comment to D131230: [RISCV] Allow mismatched SmallDataLimit and use Min for conflicting values.

@joshua-arch1 and @hiraditya this change is causing a test failure on many bots. Can you take a look and revert if you need time to investigate?

Feb 6 2023, 5:46 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D143365: Remove -j argument to llvm-clang-x86_64-sie-win builder for lit testing.

Running with ninja without -j means it will take more than the number of cores by default. If you want a single core, you need to specify -j1.

Feb 6 2023, 7:57 AM · Restricted Project, Restricted Project

Feb 5 2023

dyung requested review of D143365: Remove -j argument to llvm-clang-x86_64-sie-win builder for lit testing.
Feb 5 2023, 8:58 PM · Restricted Project, Restricted Project

Feb 4 2023

dyung added a comment to D143218: [mlgo] Hook up the interactive runner to the mlgo-ed passes.

There still seems to be failures related to this change, can you take a look please?

Feb 4 2023, 11:50 AM · Restricted Project, Restricted Project
dyung added a reverting change for rGabbd4da20438: [Sanitizers] Fix read buffer overrun in scanning loader commands: rG056769cdbc60: Revert "[Sanitizers] Fix read buffer overrun in scanning loader commands".
Feb 4 2023, 10:20 AM · Restricted Project, Restricted Project
dyung committed rG056769cdbc60: Revert "[Sanitizers] Fix read buffer overrun in scanning loader commands" (authored by dyung).
Revert "[Sanitizers] Fix read buffer overrun in scanning loader commands"
Feb 4 2023, 10:20 AM · Restricted Project, Restricted Project
dyung added a reverting change for D142164: [Sanitizers] Fix read buffer overrun in scanning loader commands: rG056769cdbc60: Revert "[Sanitizers] Fix read buffer overrun in scanning loader commands".
Feb 4 2023, 10:20 AM · Restricted Project, Restricted Project

Feb 2 2023

dyung added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..
-DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-scei-ps4

Hopefully this can help you to reproduce the problem.

Ah, thank you very much. And indeed, giving --target=x86_64-scei-ps4 to Clang-Tidy will make the test case fail, but using x86_64-linux-gnu works perfectly.
Now knowing the exact triple I think I can delve into the preprocessor stack or something to figure out why the Annex K.-related flags, my best bet is that it's explicitly forbidden from being defined. 😉

clang-tidy /tmp/LLVM-Build/tools/clang/tools/extra/test/clang-tidy/checkers/bugprone/Output/unsafe-functions.c.tmp.c --checks='-*,bugprone-unsafe-functions' -config={} -- --target=x86_64-linux-gnu -D__STDC_LIB_EXT1__=1 -D__STDC_WANT_LIB_EXT1__=1 -nostdinc++

My first wish is to figure out how to reliably disable the test case and have this quick-fix pushed immediately so the buildbots don't continue failing, and then we can figure out that this check should be disabled on this specific platform, or something like that...

Feb 2 2023, 7:08 AM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D91000: [clang-tidy] Add bugprone-unsafe-functions checker..

Ping @dyung, it looks like you're the owner of the relevant build-bot. I can't find any information what x86_64-sie is...

Meanwhile, it seems my attempt at fix is not actually fixing anything, I'm trying to figure out how to at least disable the check on this specific architecture. The rest of the architectures seem to be passing normally as expected. Something must be special within Clang's default environment or compiler configuration...

Feb 2 2023, 6:49 AM · Restricted Project, Restricted Project, Restricted Project

Jan 31 2023

dyung added a comment to D133392: [MTE] Add AArch64GlobalsTagging Pass.

Hi @hctim, the test you added is failing on buildbots where AArch64 is not built, can you either update the test to not require that backend, or mark the test as requiring it?

Jan 31 2023, 12:03 PM · Restricted Project, Restricted Project, Restricted Project

Jan 25 2023

dyung added a comment to D136702: [llvm-cov] Look up object files using debuginfod.

@mysterymath I reverted this change as well as follow-up change you made in order to unblock the build bots.

Jan 25 2023, 7:25 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a reverting change for rGefbc8bb18eda: [llvm-cov] Look up object files using debuginfod: rGbce910242e72: Revert "[llvm-cov] Look up object files using debuginfod".
Jan 25 2023, 7:13 PM · Restricted Project, Restricted Project, Restricted Project
dyung committed rGbce910242e72: Revert "[llvm-cov] Look up object files using debuginfod" (authored by dyung).
Revert "[llvm-cov] Look up object files using debuginfod"
Jan 25 2023, 7:13 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a reverting change for rG46013fc10a68: Fix compilation failure in CoverageMapping.cpp: rGd4e3a1dcf649: Revert "Fix compilation failure in CoverageMapping.cpp".
Jan 25 2023, 7:13 PM · Restricted Project, Restricted Project
dyung committed rGd4e3a1dcf649: Revert "Fix compilation failure in CoverageMapping.cpp" (authored by dyung).
Revert "Fix compilation failure in CoverageMapping.cpp"
Jan 25 2023, 7:13 PM · Restricted Project, Restricted Project
dyung added a reverting change for D136702: [llvm-cov] Look up object files using debuginfod: rGbce910242e72: Revert "[llvm-cov] Look up object files using debuginfod".
Jan 25 2023, 7:13 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D136702: [llvm-cov] Look up object files using debuginfod.

@mysterymath this change is causing problems on several bots related to your detection on whether curl is present or not. Can you take a look and revert if you need time to investigate?

Jan 25 2023, 4:38 PM · Restricted Project, Restricted Project, Restricted Project

Jan 24 2023

dyung added a comment to D142387: [SCCP] Use range info to prove AddInst has NUW flag..

@fhahn this change was causing many of our internal tests to hit an assertion failure which I bisected back to your change. I've filed issue #60280 with a repro. Can you take a look?

Jan 24 2023, 9:24 PM · Restricted Project, Restricted Project
dyung added a reverting change for rGde122cb92008: [SCCP] Use range info to prove AddInst has NUW flag.: rGc9401f2ebe63: Revert "[SCCP] Use range info to prove AddInst has NUW flag.".
Jan 24 2023, 9:23 PM · Restricted Project, Restricted Project
dyung committed rGc9401f2ebe63: Revert "[SCCP] Use range info to prove AddInst has NUW flag." (authored by dyung).
Revert "[SCCP] Use range info to prove AddInst has NUW flag."
Jan 24 2023, 9:23 PM · Restricted Project, Restricted Project
dyung added a reverting change for D142387: [SCCP] Use range info to prove AddInst has NUW flag.: rGc9401f2ebe63: Revert "[SCCP] Use range info to prove AddInst has NUW flag.".
Jan 24 2023, 9:23 PM · Restricted Project, Restricted Project
dyung added a reverting change for rG2b807336ad38: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants: rG8700beee9367: Revert "[15/15][Clang][RISCV][NFC] Set data member under Policy as constants".
Jan 24 2023, 1:02 PM · Restricted Project, Restricted Project
dyung added a reverting change for D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants: rG8700beee9367: Revert "[15/15][Clang][RISCV][NFC] Set data member under Policy as constants".
Jan 24 2023, 1:02 PM · Restricted Project, Restricted Project
dyung committed rG8700beee9367: Revert "[15/15][Clang][RISCV][NFC] Set data member under Policy as constants" (authored by dyung).
Revert "[15/15][Clang][RISCV][NFC] Set data member under Policy as constants"
Jan 24 2023, 1:02 PM · Restricted Project, Restricted Project
dyung added a comment to D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants.

Hi @eopXD this change seems to be causing builds on Windows to time out for some reason. Can you take a look?

Jan 24 2023, 9:48 AM · Restricted Project, Restricted Project

Jan 22 2023

dyung added a comment to D142046: [BPF][clang] Ignore stack protector options for BPF target.

@dyung I just pushed the fix to the 'main' branch (https://github.com/llvm/llvm-project/commit/183d075055c591dedead7ece972f1bdea611aa3b). Please check it out. Thanks for reporting!

Jan 22 2023, 12:51 PM · Restricted Project, Restricted Project

Jan 21 2023

dyung added a comment to D142046: [BPF][clang] Ignore stack protector options for BPF target.

Hi, our internal release build buildbot seems to have issues with this test. It seems you are expected the following function declaration in the emitted IR:

define dso_local void @_Z5test1PKc(ptr noundef %msg) #0 !dbg !19 {

But in a release build, it becomes:

define dso_local void @_Z5test1PKc(ptr noundef %0) #0 !dbg !19 {

Note that %msg became %0. Can you fix the test so that it works in release builds as well?

Jan 21 2023, 8:52 PM · Restricted Project, Restricted Project

Jan 11 2023

dyung added a comment to D141446: [llvm-profdata] Add option to cap profile output size.

We are also seeing an assertion failure in the added unit test on our internal Windows builder similar to what this bot is hitting:

Jan 11 2023, 10:28 PM · Restricted Project, Restricted Project
dyung committed rZORGbd3ff798680d: Update number of threads for building to take advantage of distributed build… (authored by dyung).
Update number of threads for building to take advantage of distributed build…
Jan 11 2023, 3:26 PM · Restricted Project
dyung closed D141466: Update number of threads for building to take advantage of distributed build cores on doug-worker-* builders.
Jan 11 2023, 3:26 PM · Restricted Project, Restricted Project
dyung requested review of D141466: Update number of threads for building to take advantage of distributed build cores on doug-worker-* builders.
Jan 11 2023, 12:54 AM · Restricted Project, Restricted Project

Jan 9 2023

dyung added a reverting change for rG5b72d0e4f5ee: [llvm-profdata] Add option to cap profile output size: rGac07911b455e: Revert "[llvm-profdata] Add option to cap profile output size".
Jan 9 2023, 11:54 PM · Restricted Project, Restricted Project
dyung committed rGac07911b455e: Revert "[llvm-profdata] Add option to cap profile output size" (authored by dyung).
Revert "[llvm-profdata] Add option to cap profile output size"
Jan 9 2023, 11:54 PM · Restricted Project, Restricted Project
dyung added a reverting change for rG9f4a9d3f4450: [ProfileData] Fix a warning: rG146f78bf03fd: Revert "[ProfileData] Fix a warning".
Jan 9 2023, 11:54 PM · Restricted Project, Restricted Project
dyung committed rG146f78bf03fd: Revert "[ProfileData] Fix a warning" (authored by dyung).
Revert "[ProfileData] Fix a warning"
Jan 9 2023, 11:54 PM · Restricted Project, Restricted Project
dyung added a reverting change for D139603: [llvm-profdata] Add option to cap profile output size: rGac07911b455e: Revert "[llvm-profdata] Add option to cap profile output size".
Jan 9 2023, 11:54 PM · Restricted Project, Restricted Project
dyung added inline comments to D139603: [llvm-profdata] Add option to cap profile output size.
Jan 9 2023, 8:00 PM · Restricted Project, Restricted Project
dyung added a comment to D139582: [GVN] Improve PRE on load instructions.

@dyung @chapuni thank you for the report, I have reverted it.
How did you investigate it ? I try to reproduce it according to https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild, but always got following error

...
+ BUILDBOT_MONO_REPO_PATH=
+ BUILDBOT_REVISION=llvmorg-
+ buildbot_update
+ echo @@@BUILD_STEP update llvmorg-@@@
@@@BUILD_STEP update llvmorg-@@@
+ [[ -d '' ]]
+ local DEPTH=100
+ [[ -d llvm-project ]]
+ cd llvm-project
+ git fetch origin
+ git clean -fd
+ local REV=llvmorg-
+ git checkout -f llvmorg-
error: pathspec 'llvmorg-' did not match any file(s) known to git
+ git status
On branch main

No commits yet

nothing to commit (create/copy files and use "git add" to track)
+ git rev-list --pretty --max-count=1 HEAD
fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
+ build_exception
+ echo

+ echo 'How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild'
How to reproduce locally: https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild
+ echo
...

I can't speak for the sanitizer bot, but for llvm-clang-x86_64-gcc-ubuntu you should be able to reproduce some of the failures by running:

  • cmake ../llvm-project/llvm -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_BUILD_TYPE=Release -DCLANG_ENABLE_CLANGD=OFF -DLLVM_BUILD_RUNTIME=ON -DLLVM_BUILD_TESTS=ON -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_INCLUDE_EXAMPLES=OFF '-DLLVM_LIT_ARGS=--verbose -j48' -DLLVM_USE_LINKER=gold '-DLLVM_ENABLE_PROJECTS=compiler-rt;clang;lld;cross-project-tests;llvm;clang-tools-extra' -GNinja
  • ninja check-fuzzer
Jan 9 2023, 7:06 PM · Restricted Project, Restricted Project
dyung added a comment to D139582: [GVN] Improve PRE on load instructions.

@Carrot This change seems to be causing some weird unit test failures that I cannot explain. Can you take a look and revert if you need time to investigate?

Jan 9 2023, 6:21 PM · Restricted Project, Restricted Project
dyung added a comment to D139603: [llvm-profdata] Add option to cap profile output size.

@huangjd the test you added seems to be failing on Windows. Can you take a look and revert if you need time to investigate?

Jan 9 2023, 5:31 PM · Restricted Project, Restricted Project
dyung added a comment to D140580: [SLP]Do not emit many extractelements, reuse the single one emitted..

Tried to reproduce but was unable to do it. Try to update the compiler, maybe it was fixed already

Jan 9 2023, 10:31 AM · Restricted Project, Restricted Project

Jan 8 2023

dyung committed rZORG706fe1d1ab7d: Turn on ccache and clean builds for llvm-clang-x86_64-sie-win builder. (authored by dyung).
Turn on ccache and clean builds for llvm-clang-x86_64-sie-win builder.
Jan 8 2023, 9:34 PM · Restricted Project
dyung closed D141217: Turn on ccache and clean builds for llvm-clang-x86_64-sie-win builder.
Jan 8 2023, 9:34 PM · Restricted Project, Restricted Project

Jan 7 2023

dyung retitled D141217: Turn on ccache and clean builds for llvm-clang-x86_64-sie-win builder from Turn on ccache and clean builds for llvm-clang-x86_64-sie-win worker to Turn on ccache and clean builds for llvm-clang-x86_64-sie-win builder.
Jan 7 2023, 11:23 PM · Restricted Project, Restricted Project
dyung requested review of D141217: Turn on ccache and clean builds for llvm-clang-x86_64-sie-win builder.
Jan 7 2023, 11:23 PM · Restricted Project, Restricted Project

Jan 6 2023

dyung added a comment to D140580: [SLP]Do not emit many extractelements, reuse the single one emitted..

Hi @ABataev, we are also seeing an internal test hit an assertion failure which I bisected back to your change and it is still currently failing with ToT (8304f6de94872cdcaba63039a61b8860fe367620).

c++
double *a, *f, *g, *h, *i;
double b;
long c, d, e, j;
void k() {
  for (;;) {
    h = &b;
    i = &b + j;
    for (; c; c++) {
      d = f[c];
      e = i[c] - h[c];
      a[c] = g[c];
      a[j + c] = d;
      a[2 * j + c] = e;
      a[3 * j + c] = c;
    }
  }
}

Compile with "-O2 -mavx2" to show the crash:

$ ~/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang -c -O2 -mavx2 test.cpp
clang: /home/dyung/src/upstream/llvm_clean_git/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:8820: llvm::Value* llvm::slpvectorizer::BoUpSLP::vectorizeOperand(llvm::slpvectorizer::BoUpSLP::TreeEntry*, unsigned int): Assertion `I->get()->isSame(VL) && "Expected same list of scalars."' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0.      Program arguments: /home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang -c -O2 -mavx2 test.cpp
1.      <eof> parser at end of file
2.      Optimizer
 #0 0x000056362caf68ff llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x3f968ff)
 #1 0x000056362caf489c llvm::sys::CleanupOnSignal(unsigned long) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x3f9489c)
 #2 0x000056362ca43e78 CrashRecoverySignalHandler(int) CrashRecoveryContext.cpp:0:0
 #3 0x00007f86cd094420 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x14420)
 #4 0x00007f86ccb6100b raise /build/glibc-SzIz7B/glibc-2.31/signal/../sysdeps/unix/sysv/linux/raise.c:51:1
 #5 0x00007f86ccb40859 abort /build/glibc-SzIz7B/glibc-2.31/stdlib/abort.c:81:7
 #6 0x00007f86ccb40729 get_sysdep_segment_value /build/glibc-SzIz7B/glibc-2.31/intl/loadmsgcat.c:509:8
 #7 0x00007f86ccb40729 _nl_load_domain /build/glibc-SzIz7B/glibc-2.31/intl/loadmsgcat.c:970:34
 #8 0x00007f86ccb51fd6 (/lib/x86_64-linux-gnu/libc.so.6+0x33fd6)
 #9 0x000056362cdefcd1 llvm::slpvectorizer::BoUpSLP::vectorizeOperand(llvm::slpvectorizer::BoUpSLP::TreeEntry*, unsigned int) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x428fcd1)
#10 0x000056362cdf2310 llvm::slpvectorizer::BoUpSLP::vectorizeTree(llvm::slpvectorizer::BoUpSLP::TreeEntry*) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x4292310)
#11 0x000056362cdef071 llvm::slpvectorizer::BoUpSLP::vectorizeOperand(llvm::slpvectorizer::BoUpSLP::TreeEntry*, unsigned int) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x428f071)
#12 0x000056362cdf0268 llvm::slpvectorizer::BoUpSLP::vectorizeTree(llvm::slpvectorizer::BoUpSLP::TreeEntry*) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x4290268)
#13 0x000056362cdff568 llvm::slpvectorizer::BoUpSLP::vectorizeTree(llvm::MapVector<llvm::Value*, llvm::SmallVector<llvm::Instruction*, 2u>, llvm::DenseMap<llvm::Value*, unsigned int, llvm::DenseMapInfo<llvm::Value*, void>, llvm::detail::DenseMapPair<llvm::Value*, unsigned int>>, std::vector<std::pair<llvm::Value*, llvm::SmallVector<llvm::Instruction*, 2u>>, std::allocator<std::pair<llvm::Value*, llvm::SmallVector<llvm::Instruction*, 2u>>>>>&, llvm::Instruction*) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x429f568)
#14 0x000056362ce0e5c1 (anonymous namespace)::HorizontalReduction::tryToReduce(llvm::slpvectorizer::BoUpSLP&, llvm::TargetTransformInfo*, llvm::TargetLibraryInfo const&) SLPVectorizer.cpp:0:0
#15 0x000056362ce10664 llvm::SLPVectorizerPass::vectorizeHorReduction(llvm::PHINode*, llvm::Value*, llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&, llvm::TargetTransformInfo*, llvm::SmallVectorImpl<llvm::WeakTrackingVH>&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x42b0664)
#16 0x000056362ce14706 llvm::SLPVectorizerPass::vectorizeRootInstruction(llvm::PHINode*, llvm::Value*, llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&, llvm::TargetTransformInfo*) (.constprop.0) SLPVectorizer.cpp:0:0
#17 0x000056362ce17e12 llvm::SLPVectorizerPass::vectorizeChainsInBlock(llvm::BasicBlock*, llvm::slpvectorizer::BoUpSLP&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x42b7e12)
#18 0x000056362ce1ad77 llvm::SLPVectorizerPass::runImpl(llvm::Function&, llvm::ScalarEvolution*, llvm::TargetTransformInfo*, llvm::TargetLibraryInfo*, llvm::AAResults*, llvm::LoopInfo*, llvm::DominatorTree*, llvm::AssumptionCache*, llvm::DemandedBits*, llvm::OptimizationRemarkEmitter*) (.part.0) SLPVectorizer.cpp:0:0
#19 0x000056362ce1bb6c llvm::SLPVectorizerPass::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x42bbb6c)
#20 0x000056362dec7676 llvm::detail::PassModel<llvm::Function, llvm::SLPVectorizerPass, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x5367676)
#21 0x000056362a374cb4 llvm::detail::PassModel<llvm::Function, llvm::PassManager<llvm::Function, llvm::AnalysisManager<llvm::Function>>, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Function>>::run(llvm::Function&, llvm::AnalysisManager<llvm::Function>&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x1814cb4)
#22 0x000056362c36bf7f llvm::ModuleToFunctionPassAdaptor::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x380bf7f)
#23 0x000056362a35b2a6 llvm::detail::PassModel<llvm::Module, llvm::ModuleToFunctionPassAdaptor, llvm::PreservedAnalyses, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x17fb2a6)
#24 0x000056362c36a0aa llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x380a0aa)
#25 0x000056362cef42d8 (anonymous namespace)::EmitAssemblyHelper::RunOptimizationPipeline(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>&, std::unique_ptr<llvm::ToolOutputFile, std::default_delete<llvm::ToolOutputFile>>&) BackendUtil.cpp:0:0
#26 0x000056362cef7274 (anonymous namespace)::EmitAssemblyHelper::EmitAssembly(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>) BackendUtil.cpp:0:0
#27 0x000056362cef7db5 clang::EmitBackendOutput(clang::DiagnosticsEngine&, clang::HeaderSearchOptions const&, clang::CodeGenOptions const&, clang::TargetOptions const&, clang::LangOptions const&, llvm::StringRef, llvm::Module*, clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream>>) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x4397db5)
#28 0x000056362de6b43b clang::BackendConsumer::HandleTranslationUnit(clang::ASTContext&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x530b43b)
#29 0x000056362eddd275 clang::ParseAST(clang::Sema&, bool, bool) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x627d275)
#30 0x000056362de69eb8 clang::CodeGenAction::ExecuteAction() (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x5309eb8)
#31 0x000056362d6e2579 clang::FrontendAction::Execute() (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x4b82579)
#32 0x000056362d668d5e clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x4b08d5e)
#33 0x000056362d7c7fe3 clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x4c67fe3)
#34 0x0000563629feca84 cc1_main(llvm::ArrayRef<char const*>, char const*, void*) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x148ca84)
#35 0x0000563629fe8bc7 ExecuteCC1Tool(llvm::SmallVectorImpl<char const*>&) driver.cpp:0:0
#36 0x000056362d4d2369 void llvm::function_ref<void ()>::callback_fn<clang::driver::CC1Command::Execute(llvm::ArrayRef<std::optional<llvm::StringRef>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>*, bool*) const::'lambda'()>(long) Job.cpp:0:0
#37 0x000056362ca4461a llvm::CrashRecoveryContext::RunSafely(llvm::function_ref<void ()>) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x3ee461a)
#38 0x000056362d4d2c1f clang::driver::CC1Command::Execute(llvm::ArrayRef<std::optional<llvm::StringRef>>, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char>>*, bool*) const (.part.0) Job.cpp:0:0
#39 0x000056362d49bdac clang::driver::Compilation::ExecuteCommand(clang::driver::Command const&, clang::driver::Command const*&, bool) const (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x493bdac)
#40 0x000056362d49c82d clang::driver::Compilation::ExecuteJobs(clang::driver::JobList const&, llvm::SmallVectorImpl<std::pair<int, clang::driver::Command const*>>&, bool) const (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x493c82d)
#41 0x000056362d4a5c6c clang::driver::Driver::ExecuteCompilation(clang::driver::Compilation&, llvm::SmallVectorImpl<std::pair<int, clang::driver::Command const*>>&) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x4945c6c)
#42 0x0000563629feb202 clang_main(int, char**) (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x148b202)
#43 0x00007f86ccb42083 __libc_start_main /build/glibc-SzIz7B/glibc-2.31/csu/../csu/libc-start.c:342:3
#44 0x0000563629fe38ce _start (/home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin/clang+0x14838ce)
clang-16: error: clang frontend command failed with exit code 134 (use -v to see invocation)
clang version 16.0.0 (https://github.com/llvm/llvm-project.git 8304f6de94872cdcaba63039a61b8860fe367620)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /home/dyung/src/upstream/8304f6de94872cdcaba63039a61b8860fe367620-linux/bin

Can you take a look?

Jan 6 2023, 4:52 PM · Restricted Project, Restricted Project

Dec 20 2022

dyung committed rG638b25711540: Fix test added in 95abdeb to set environment variables in a way that works on… (authored by dyung).
Fix test added in 95abdeb to set environment variables in a way that works on…
Dec 20 2022, 5:33 PM · Restricted Project, Restricted Project

Dec 14 2022

dyung committed rZORG61aeb95ec292: Add myself to be notified when any of the builders I manage fail. (authored by dyung).
Add myself to be notified when any of the builders I manage fail.
Dec 14 2022, 6:24 PM · Restricted Project
dyung closed D139735: Add additional buildbots to my notification list.
Dec 14 2022, 6:24 PM · Restricted Project, Restricted Project
dyung committed rZORGd0c37216a922: Remove -DLLVM_CCACHE_BUILD from some of my bots since it doesn't work when… (authored by dyung).
Remove -DLLVM_CCACHE_BUILD from some of my bots since it doesn't work when…
Dec 14 2022, 1:01 PM · Restricted Project
dyung closed D140041: Remove explicit LLVM ccache-ing.
Dec 14 2022, 1:01 PM · Restricted Project, Restricted Project
dyung requested review of D140041: Remove explicit LLVM ccache-ing.
Dec 14 2022, 11:26 AM · Restricted Project, Restricted Project
dyung added a reverting change for rG13fd37c931c2: [FileCheck] llvm::Optional => std::optional: rG547e40a91b1e: Revert "[FileCheck] llvm::Optional => std::optional".
Dec 14 2022, 10:06 AM · Restricted Project, Restricted Project
dyung committed rG547e40a91b1e: Revert "[FileCheck] llvm::Optional => std::optional" (authored by dyung).
Revert "[FileCheck] llvm::Optional => std::optional"
Dec 14 2022, 10:06 AM · Restricted Project, Restricted Project

Dec 9 2022

dyung committed rZORG6d673e2b31e9: Rename and reassign a few SIE workers/builds to reallocate resources more… (authored by dyung).
Rename and reassign a few SIE workers/builds to reallocate resources more…
Dec 9 2022, 4:45 PM · Restricted Project
dyung closed D138726: Rename and reassign a few SIE workers/builders.
Dec 9 2022, 4:45 PM · Restricted Project, Restricted Project
dyung requested review of D139735: Add additional buildbots to my notification list.
Dec 9 2022, 12:04 PM · Restricted Project, Restricted Project

Dec 8 2022

dyung added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.

@oontvoo the test you added is failing if the AArch64 target is not built: https://lab.llvm.org/buildbot/#/builders/139/builds/32439

Dec 8 2022, 10:45 PM · Restricted Project, Restricted Project, Restricted Project
dyung committed rG9c381c430e41: Mark test lld/test/MachO/fat-arch.s updated in e54cfa4 to require aarch64. (authored by dyung).
Mark test lld/test/MachO/fat-arch.s updated in e54cfa4 to require aarch64.
Dec 8 2022, 10:44 PM · Restricted Project
dyung added a comment to D139572: [lld-macho] Fix bug in reading of cpusubtype field.

@oontvoo the test you added is failing if the AArch64 target is not built: https://lab.llvm.org/buildbot/#/builders/139/builds/32439

Dec 8 2022, 8:14 PM · Restricted Project, Restricted Project, Restricted Project

Dec 7 2022

dyung added a comment to D138726: Rename and reassign a few SIE workers/builders.

The patch itself looks Ok.

Renaming workers means some extra cleaning on the buildbot, and we need to coordinate the worker credentials and when you will take the current workers down and will start the new.

How about committing this patch on Friday late afternoon, like 5:00 PM PST, so I could take the buildbot down without interfering with the normal activity? That would be a good time for you to shut the current workers down and bring the new up.

I assume this is one time change, right?

Please send me directly the new credentials.

Dec 7 2022, 11:11 AM · Restricted Project, Restricted Project
dyung added a comment to D138726: Rename and reassign a few SIE workers/builders.

ping

Dec 7 2022, 10:46 AM · Restricted Project, Restricted Project

Dec 6 2022

dyung added a reverting change for rG5951b0bb23f3: Store OptTable::Info::Name as a StringRef: rG4857b6f8fff6: Revert "Store OptTable::Info::Name as a StringRef".
Dec 6 2022, 7:38 PM · Restricted Project, Restricted Project, Restricted Project
dyung committed rG4857b6f8fff6: Revert "Store OptTable::Info::Name as a StringRef" (authored by dyung).
Revert "Store OptTable::Info::Name as a StringRef"
Dec 6 2022, 7:38 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a reverting change for D139274: Store OptTable::Info::Name as a StringRef: rG4857b6f8fff6: Revert "Store OptTable::Info::Name as a StringRef".
Dec 6 2022, 7:38 PM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D139274: Store OptTable::Info::Name as a StringRef.

@serge-sans-paille Your change is causing 24 test failures on the Linux PS4 bot, mostly with an assertion failure it seems. Can you take a look?

Dec 6 2022, 2:50 PM · Restricted Project, Restricted Project, Restricted Project

Dec 2 2022

dyung added a comment to D139210: [llvm-objcopy] Fix --add-section when section contain empty bytes.

@gmorer I had to revert your change because it was causing at least 2 Windows build bots to fail:

Dec 2 2022, 10:42 PM · Restricted Project, Restricted Project
dyung added a reverting change for rG0041382198f2: [llvm-objcopy] Fix --section-add when section contain empty bytes: rG34b8daf4a817: Revert "[llvm-objcopy] Fix --section-add when section contain empty bytes".
Dec 2 2022, 10:41 PM · Restricted Project, Restricted Project
dyung committed rG34b8daf4a817: Revert "[llvm-objcopy] Fix --section-add when section contain empty bytes" (authored by dyung).
Revert "[llvm-objcopy] Fix --section-add when section contain empty bytes"
Dec 2 2022, 10:41 PM · Restricted Project, Restricted Project
dyung added a reverting change for D139210: [llvm-objcopy] Fix --add-section when section contain empty bytes: rG34b8daf4a817: Revert "[llvm-objcopy] Fix --section-add when section contain empty bytes".
Dec 2 2022, 10:41 PM · Restricted Project, Restricted Project
dyung added a comment to D138474: [clang] Speedup LineOffsetMapping::get.

@serge-sans-paille, one of our internal tests hit an assertion failure which I bisected back to your change. I have filed issue 59321 with a repro. Can you take a look?

Dec 2 2022, 10:06 PM · Restricted Project, Restricted Project

Nov 29 2022

dyung added a comment to D133758: [VPlan] Add VPDerivedIVRecipe, use for VPScalarIVStepsRecipe..

@fhahn one of our internal tests also hit the same assertion failure and I have a reduced testcase for it if it helps. I was going to file a bug for it, but since you have already reverted the change, I'll hold off for now. Let me know if you would like the testcase we found.

Nov 29 2022, 2:12 PM · Restricted Project, Restricted Project

Nov 28 2022

dyung added a comment to D138252: [clang][deps] During scanning don't emit warnings-as-errors that are ignored with diagnostic pragmas..

@vsapsai I reverted your change because it was causing the test ClangScanDeps/no-werror.cpp to fail on the PS4/PS5 linux/Windows bots:

Nov 28 2022, 9:25 PM · Restricted Project, Restricted Project
dyung added a reverting change for rGeac90d1236cf: [clang][deps] During scanning don't emit warnings-as-errors that are ignored…: rG2f8ac1804827: Revert "[clang][deps] During scanning don't emit warnings-as-errors that are….
Nov 28 2022, 9:24 PM · Restricted Project, Restricted Project
dyung committed rG2f8ac1804827: Revert "[clang][deps] During scanning don't emit warnings-as-errors that are… (authored by dyung).
Revert "[clang][deps] During scanning don't emit warnings-as-errors that are…
Nov 28 2022, 9:24 PM · Restricted Project, Restricted Project