Page MenuHomePhabricator

dyung (Douglas Yung)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2016, 4:47 PM (202 w, 1 h)

Recent Activity

Tue, Jan 14

dyung committed rGc6e69880ae4d: Modify test to use -S instead of -c so that it works when an external assembler… (authored by dyung).
Modify test to use -S instead of -c so that it works when an external assembler…
Tue, Jan 14, 7:05 PM

Thu, Jan 9

dyung committed rG3727ca313783: Relax opcode checks in test for G_READCYCLECOUNTER to check for only a number… (authored by dyung).
Relax opcode checks in test for G_READCYCLECOUNTER to check for only a number…
Thu, Jan 9, 5:48 PM

Dec 12 2019

dyung committed rGbc0c60f714fc: Remove extra character I added to test my changes that I forgot to delete… (authored by dyung).
Remove extra character I added to test my changes that I forgot to delete…
Dec 12 2019, 6:25 PM
dyung committed rGb71475ff9ae0: Fix test to work correctly on 32-bit platforms. (authored by dyung).
Fix test to work correctly on 32-bit platforms.
Dec 12 2019, 5:29 PM

Dec 5 2019

dyung committed rGda650094b187: Fix build of LookupResult.cpp from aeda128 with Visual C++. (authored by dyung).
Fix build of LookupResult.cpp from aeda128 with Visual C++.
Dec 5 2019, 9:10 PM
dyung added a comment to D60499: [ASTImporter] Various source location and range import fixes..

This change caused the Import/namespace/struct-and-var/test.cpp test to fail on ARM due to an extra line with `-CXXRecordDecl being emitted by the compiler that was being matched instead of the intended line. I checked in a fix to tighten up the check a little more so that it gets the correct line in 757bc55. I don't think it should negatively affect the test, but please do review the change.

Dec 5 2019, 6:53 PM · Restricted Project
dyung committed rG757bc55f8314: Tighten up CHECK lines added in a9f10ebffa to work on ARM. (authored by dyung).
Tighten up CHECK lines added in a9f10ebffa to work on ARM.
Dec 5 2019, 6:44 PM

Nov 21 2019

dyung abandoned D70348: Add header guards for header files that should not be included on the PS4 platform.
Nov 21 2019, 2:10 AM · Restricted Project

Nov 15 2019

dyung added a comment to D70348: Add header guards for header files that should not be included on the PS4 platform.

You could probably just define add ORBIS to every line and then rely on the individual feature defines at the end of the line to re-enable the ones that are really supported. I assume the target-cpu is set to btver for ps4?

Nov 15 2019, 6:10 PM · Restricted Project
dyung created D70348: Add header guards for header files that should not be included on the PS4 platform.
Nov 15 2019, 3:42 PM · Restricted Project

Nov 12 2019

dyung committed rG7ebde1bf67da: Add a shim for setenv on PS4 since it does not exist. (authored by dyung).
Add a shim for setenv on PS4 since it does not exist.
Nov 12 2019, 3:29 PM
dyung closed D70033: Add a shim for setenv on PS4 since it does not exist on PS4.
Nov 12 2019, 3:29 PM · Restricted Project, Restricted Project

Nov 8 2019

dyung created D70033: Add a shim for setenv on PS4 since it does not exist on PS4.
Nov 8 2019, 3:56 PM · Restricted Project, Restricted Project

Oct 21 2019

dyung accepted D69196: Fix lld detection in standalone compiler-rt..

I tried applying this to our internal sources and it worked, so LGTM as well.

Oct 21 2019, 11:05 AM · Restricted Project, Restricted Project

Oct 18 2019

dyung added a comment to D69196: Fix lld detection in standalone compiler-rt..

Sorry for breaking this, I thought the change would be trivial, guess it was not. From what I can remember, Peter's change was causing our internal testing to break because we don't build/use LLD for our platform.

Oct 18 2019, 3:27 PM · Restricted Project, Restricted Project

Oct 11 2019

dyung committed rG0bb06f6f667e: Slightly relax restriction on exact order arguments must appear. (authored by dyung).
Slightly relax restriction on exact order arguments must appear.
Oct 11 2019, 7:27 PM
dyung committed rL374627: Slightly relax restriction on exact order arguments must appear..
Slightly relax restriction on exact order arguments must appear.
Oct 11 2019, 7:27 PM

Sep 30 2019

dyung committed rL373270: Request access for Douglas Yung.
Request access for Douglas Yung
Sep 30 2019, 3:47 PM

Sep 27 2019

dyung accepted D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.

LGTM

Sep 27 2019, 2:22 PM · Restricted Project, Restricted Project

Sep 13 2019

dyung committed rG8607b93eabac: Make test check position independent as they sometimes come out reversed. NFCI. (authored by dyung).
Make test check position independent as they sometimes come out reversed. NFCI.
Sep 13 2019, 3:21 PM
dyung committed rL371904: Make test check position independent as they sometimes come out reversed. NFCI..
Make test check position independent as they sometimes come out reversed. NFCI.
Sep 13 2019, 3:11 PM

Sep 9 2019

dyung committed rG4bd6eb8ff201: Relax opcode checks in test to check for only a number instead of a specific… (authored by dyung).
Relax opcode checks in test to check for only a number instead of a specific…
Sep 9 2019, 1:15 PM
dyung committed rL371447: Relax opcode checks in test to check for only a number instead of a specific….
Relax opcode checks in test to check for only a number instead of a specific…
Sep 9 2019, 1:11 PM

Sep 8 2019

dyung committed rGdebac75deae3: Relax opcode checks in test to check for only a number instead of a specific… (authored by dyung).
Relax opcode checks in test to check for only a number instead of a specific…
Sep 8 2019, 6:22 PM
dyung committed rL371355: Relax opcode checks in test to check for only a number instead of a specific….
Relax opcode checks in test to check for only a number instead of a specific…
Sep 8 2019, 6:22 PM

Aug 30 2019

dyung added a comment to D66921: GlobalISel: Add known bits to InstructionSelector.

Is someone working on a fix for this that will go in soon? I am about to revert this change because it is blocking our internal builds as well as breaking both of the public PS4 bots.

Aug 30 2019, 10:13 AM

Aug 27 2019

dyung committed rGe816421087b4: Fixup build of clang-interpreter example after change in r370122. (authored by dyung).
Fixup build of clang-interpreter example after change in r370122.
Aug 27 2019, 7:13 PM
dyung committed rL370151: Fixup build of clang-interpreter example after change in r370122..
Fixup build of clang-interpreter example after change in r370122.
Aug 27 2019, 7:13 PM
dyung added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Hi, this is causing 3 test failures on the PS4 linux bot. The changes may not have been initially flagged because a different issue was causing a build failure which masked the problem. I have bisected the test failures to this change though.

http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/53916

LLVM :: LTO/Resolution/X86/not-prevailing-weak-aliasee.ll
LLVM :: ThinLTO/X86/printer.ll
lld :: ELF/lto/drop-debug-info.ll

Aug 27 2019, 3:07 PM · Restricted Project, Restricted Project
dyung added a comment to D64931: Change X86 datalayout for three address spaces that specify pointer sizes..

Hi, this is causing 3 test failures on the PS4 linux bot. The changes may not have been initially flagged because a different issue was causing a build failure which masked the problem. I have bisected the test failures to this change though.

Aug 27 2019, 2:58 PM · Restricted Project, Restricted Project

Aug 26 2019

dyung added a comment to D66682: Fix stack_trace_compressor builds for Clang < 6.0.

@tejohnson Nested if ? :)

CMake Error at projects/compiler-rt/lib/gwp_asan/CMakeLists.txt:108 (if):
  if given arguments:

    "COMPILER_RT_BUILD_LIBFUZZER" "AND" "(" "GNU" "STREQUAL" "Clang" ")" "AND" "CMAKE_CXX_COMPILER_VERSION" "VERSION_GREATER_EQUAL" "6.0"

  Unknown arguments specified
Aug 26 2019, 2:54 AM · Restricted Project, Restricted Project

Aug 13 2019

dyung committed rG5ee4d7a859dc: [ORC] Fix clang-interpreter example code broken by r368707. (authored by dyung).
[ORC] Fix clang-interpreter example code broken by r368707.
Aug 13 2019, 6:04 PM
dyung committed rL368778: [ORC] Fix clang-interpreter example code broken by r368707..
[ORC] Fix clang-interpreter example code broken by r368707.
Aug 13 2019, 6:03 PM
dyung added a comment to D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.

Taking a step back and thinking about this, the compile command uses "-S", but explicitly specifies the output file to be "%t/module.pcm.o" (even though it is generating an assembly file instead of an object file), could we change the test to just check for "-o {{.*}}module.pcm.o "? That would work in all cases I think except for the extreme corner case where that string was part of the build directory name.

Aug 13 2019, 4:36 PM · Restricted Project, Restricted Project
dyung added a comment to D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'.

It's probably a pathological case, but wouldn't this still fail if the build directory contained ".s" followed by a space in the name? Something like "build-foo.s bar"?

Aug 13 2019, 3:39 PM · Restricted Project, Restricted Project
dyung committed rGfb1d80322462: Relax opcode checks in test to check for only a number instead of a specific… (authored by dyung).
Relax opcode checks in test to check for only a number instead of a specific…
Aug 13 2019, 3:09 PM
dyung committed rL368756: Relax opcode checks in test to check for only a number instead of a specific….
Relax opcode checks in test to check for only a number instead of a specific…
Aug 13 2019, 3:05 PM

Aug 9 2019

dyung committed rG867dbf288309: Update test to explicity test with -fintegrated-as and -fno-integrated-as and… (authored by dyung).
Update test to explicity test with -fintegrated-as and -fno-integrated-as and…
Aug 9 2019, 12:48 PM
dyung committed rL368474: Update test to explicity test with -fintegrated-as and -fno-integrated-as and….
Update test to explicity test with -fintegrated-as and -fno-integrated-as and…
Aug 9 2019, 12:48 PM
dyung closed D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..
Aug 9 2019, 12:48 PM · Restricted Project, Restricted Project
dyung added a comment to D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..

Something like "fix test for out-of-tree targets that don't enable the internal assembler by default by explicitly passing -fintegrated-as everywhere" or something like that.

Aug 9 2019, 11:35 AM · Restricted Project, Restricted Project
dyung updated the summary of D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..
Aug 9 2019, 11:26 AM · Restricted Project, Restricted Project
dyung added a comment to D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..

Actually it seems your original change already implemented that, so I think only the updated test change that I made is needed. Let me know if you disagree with that.

Aug 9 2019, 11:18 AM · Restricted Project, Restricted Project
dyung added a comment to D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..

Oh, I just re-read your comments and realized that we should claim the Wa_COMMA and Xassembler arguments, I'll reinstate the change to just claim those.

Aug 9 2019, 11:12 AM · Restricted Project, Restricted Project
dyung added a comment to D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..

Thanks! Looks like the change to the cpp file got lost? I only see the test change now.

Aug 9 2019, 11:01 AM · Restricted Project, Restricted Project

Aug 8 2019

dyung added inline comments to D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..
Aug 8 2019, 7:12 PM · Restricted Project, Restricted Project
dyung updated the diff for D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..

Reverted changes in Clang.cpp and updated test to expect warning when an external assembler is requested.

Aug 8 2019, 7:11 PM · Restricted Project, Restricted Project
dyung added inline comments to D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..
Aug 8 2019, 3:41 PM · Restricted Project, Restricted Project
dyung created D65974: Update test to explicitly test with -fintegrated-as and -fno-integrated-as and to expect warnings when appropriate..
Aug 8 2019, 2:20 PM · Restricted Project, Restricted Project

Aug 7 2019

dyung committed rG11538f0afabf: Add LLD as a requirement for hwasan tests because of change in r368111. (authored by dyung).
Add LLD as a requirement for hwasan tests because of change in r368111.
Aug 7 2019, 6:11 PM
dyung committed rL368242: Add LLD as a requirement for hwasan tests because of change in r368111..
Add LLD as a requirement for hwasan tests because of change in r368111.
Aug 7 2019, 6:07 PM

Aug 5 2019

dyung added a comment to D65734: [llvm-objdump] Quote filename to fix windows test failure.

I'm not at a Windows machine at the moment, so I can't test your fix, but I'm doubtful that it would actually work.

Aug 5 2019, 2:10 AM · Restricted Project

Aug 2 2019

dyung committed rG42618b270d32: Revert Fix and test inter-procedural register allocation for ARM (authored by dyung).
Revert Fix and test inter-procedural register allocation for ARM
Aug 2 2019, 3:15 PM
dyung committed rL367731: Revert Fix and test inter-procedural register allocation for ARM.
Revert Fix and test inter-procedural register allocation for ARM
Aug 2 2019, 3:15 PM

Aug 1 2019

dyung committed rG087a574af015: Change /build to /build* in top-level .gitignore. (authored by dyung).
Change /build to /build* in top-level .gitignore.
Aug 1 2019, 7:17 PM
dyung committed rL367641: Change /build to /build* in top-level .gitignore..
Change /build to /build* in top-level .gitignore.
Aug 1 2019, 7:14 PM
dyung closed D65559: Change /build to /build* in top-level .gitignore.
Aug 1 2019, 7:13 PM · Restricted Project
dyung added reviewers for D65559: Change /build to /build* in top-level .gitignore: jyknight, beanz.

Adding James and Chris as reviews as it was suggested they might have an interest in this change.

Aug 1 2019, 4:10 PM · Restricted Project
dyung added a reviewer for D65559: Change /build to /build* in top-level .gitignore: echristo.
Aug 1 2019, 1:18 AM · Restricted Project
dyung created D65559: Change /build to /build* in top-level .gitignore.
Aug 1 2019, 1:17 AM · Restricted Project

Jul 12 2019

dyung committed rG4d95c3684b31: [test][AArch64] Relax the opcode tests for FP min/max instructions. (authored by dyung).
[test][AArch64] Relax the opcode tests for FP min/max instructions.
Jul 12 2019, 2:42 PM
dyung committed rL365961: [test][AArch64] Relax the opcode tests for FP min/max instructions..
[test][AArch64] Relax the opcode tests for FP min/max instructions.
Jul 12 2019, 2:39 PM

Jun 26 2019

dyung accepted D63831: [scudo][standalone] Introduce the C & C++ wrappers [fixed].

I applied your patch and built it on our internal build bot that failed and these changes worked, so LGTM as well!

Jun 26 2019, 3:15 PM · Restricted Project, Restricted Project

Jun 24 2019

dyung committed rG1433b1b6ec7e: [NFC] Fix tests added in r364225 which failed on Windows due to incorrect path… (authored by dyung).
[NFC] Fix tests added in r364225 which failed on Windows due to incorrect path…
Jun 24 2019, 4:19 PM
dyung committed rL364249: [NFC] Fix tests added in r364225 which failed on Windows due to incorrect path….
[NFC] Fix tests added in r364225 which failed on Windows due to incorrect path…
Jun 24 2019, 4:19 PM
dyung committed rG8950d0a1f062: Fix test cl-response-file.c to work on all platforms including Windows/Solaris. (authored by dyung).
Fix test cl-response-file.c to work on all platforms including Windows/Solaris.
Jun 24 2019, 3:27 PM
dyung committed rL364245: Fix test cl-response-file.c to work on all platforms including Windows/Solaris..
Fix test cl-response-file.c to work on all platforms including Windows/Solaris.
Jun 24 2019, 3:26 PM
dyung closed D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris.
Jun 24 2019, 3:26 PM · Restricted Project, Restricted Project

Jun 21 2019

dyung committed rL364122: Fix UNSUPPORTED attribute from windows to system-windows..
Fix UNSUPPORTED attribute from windows to system-windows.
Jun 21 2019, 6:20 PM
dyung committed rG3df71e053705: Fix UNSUPPORTED attribute from windows to system-windows. (authored by dyung).
Fix UNSUPPORTED attribute from windows to system-windows.
Jun 21 2019, 6:16 PM
dyung committed rGc900c46d77f8: [NFC] Marking test added in r363975 as unsupported on Windows. (authored by dyung).
[NFC] Marking test added in r363975 as unsupported on Windows.
Jun 21 2019, 6:10 PM
dyung committed rL364120: [NFC] Marking test added in r363975 as unsupported on Windows..
[NFC] Marking test added in r363975 as unsupported on Windows.
Jun 21 2019, 6:10 PM
dyung added a comment to D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c.
In D63600#1554029, @rnk wrote:

This causes the test to fail on Windows:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/7712

There seems to be something wrong with the blamelist, so it didn't send email. I see this in the log from the previous build on that bot:

Updating llvm to 363241 at ...

But buildbot thinks the previous build was testing r364000, so it didn't send any notifications.

printf seems like the wrong command to use to test backslash handling, since it interprets them as escapes. %S expands to a path containing backslashes, and the test logs seem consistent with that theory. I'll go ahead and revert this.

Jun 21 2019, 3:48 PM · Restricted Project, Restricted Project
dyung created D63678: Fix test Clang :: Driver/cl-response-file.c for Solaris.
Jun 21 2019, 3:45 PM · Restricted Project, Restricted Project

Jun 18 2019

dyung committed rGc4d5c372853e: [TEST] Fix test on Windows by looking for substrings rather than a regex since… (authored by dyung).
[TEST] Fix test on Windows by looking for substrings rather than a regex since…
Jun 18 2019, 8:00 PM
dyung committed rL363761: [TEST] Fix test on Windows by looking for substrings rather than a regex.
[TEST] Fix test on Windows by looking for substrings rather than a regex
Jun 18 2019, 8:00 PM

Jun 14 2019

dyung added a comment to D63105: Add --print-supported-cpus flag for clang..

There are lots of tests under clang/test/ that target arm-- as a -triple. How is it that they don't fail in the same way? %clang_cc1 -triple arm-- is somehow different?

Jun 14 2019, 4:02 PM · Restricted Project
dyung added a comment to D63105: Add --print-supported-cpus flag for clang..

Hi Ziang,

Jun 14 2019, 3:33 PM · Restricted Project
dyung added a comment to D61790: [C++20] add Basic consteval specifier.

Hi, the test cxx2a-consteval.cpp that you added in this commit is failing on the PS4 Windows bot.

Jun 14 2019, 11:15 AM · Restricted Project, Restricted Project

Jun 13 2019

dyung committed rG5b188f8dac08: Add REQUIRES: zlib to test added in r363325 as the profile uses zlib… (authored by dyung).
Add REQUIRES: zlib to test added in r363325 as the profile uses zlib…
Jun 13 2019, 6:07 PM
dyung committed rL363347: Add REQUIRES: zlib to test added in r363325 as the profile uses zlib….
Add REQUIRES: zlib to test added in r363325 as the profile uses zlib…
Jun 13 2019, 6:07 PM

Jun 6 2019

dyung committed rGdbceb9b2203b: Fixup files added in r362636 to build with gcc 5.4. NFCI (authored by dyung).
Fixup files added in r362636 to build with gcc 5.4. NFCI
Jun 6 2019, 1:03 AM
dyung committed rL362682: Fixup files added in r362636 to build with gcc 5.4. NFCI.
Fixup files added in r362636 to build with gcc 5.4. NFCI
Jun 6 2019, 1:01 AM

May 30 2019

dyung committed rGf1e300ca1adf: Fix test to add missing '|' to regex. (authored by dyung).
Fix test to add missing '|' to regex.
May 30 2019, 3:20 PM
dyung committed rL362168: Fix test to add missing '|' to regex..
Fix test to add missing '|' to regex.
May 30 2019, 3:20 PM
dyung committed rG9b2aeb77b041: Mark test as requiring an ARM target. (authored by dyung).
Mark test as requiring an ARM target.
May 30 2019, 1:03 PM
dyung committed rL362140: Mark test as requiring an ARM target..
Mark test as requiring an ARM target.
May 30 2019, 1:02 PM

May 29 2019

dyung committed rGa0a20f38ec5b: Fix test added in r361903 to work on Windows. (authored by dyung).
Fix test added in r361903 to work on Windows.
May 29 2019, 2:18 AM
dyung committed rL361937: Fix test added in r361903 to work on Windows..
Fix test added in r361903 to work on Windows.
May 29 2019, 2:17 AM
dyung committed rC361937: Fix test added in r361903 to work on Windows..
Fix test added in r361903 to work on Windows.
May 29 2019, 2:17 AM

May 1 2019

dyung added a comment to D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools..

FYI, we had to disable clangd entirely after this patch, getting a weird problem with lit that we haven't figured out yet.
In case anybody else has seen something like this, and knows what's going on, please let us know.

  Running all regression tests
  llvm-lit.py: C:/j/w/opensource/opensource_to_sce_merge__2/o/llvm\utils\lit\lit\llvm\config.py:336: fatal: couldn't find 'clang' program, try setting CLANG in your environment
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 2. [C:\j\w\opensource\opensource_to_sce_merge__2\build\check-all.vcxproj]
May 1 2019, 4:49 PM · Restricted Project, Restricted Project

Apr 29 2019

dyung committed rG2ac6aca8af70: Make test more robust by writing stdout/stderr to different files. (authored by dyung).
Make test more robust by writing stdout/stderr to different files.
Apr 29 2019, 3:56 PM
dyung committed rL359512: Make test more robust by writing stdout/stderr to different files..
Make test more robust by writing stdout/stderr to different files.
Apr 29 2019, 3:55 PM
dyung committed rC359512: Make test more robust by writing stdout/stderr to different files..
Make test more robust by writing stdout/stderr to different files.
Apr 29 2019, 3:55 PM

Apr 22 2019

dyung committed rG16df7e086b6f: Relax test to check for a valid number instead of a specific number. (authored by dyung).
Relax test to check for a valid number instead of a specific number.
Apr 22 2019, 3:34 PM
dyung committed rL358926: Relax test to check for a valid number instead of a specific number..
Relax test to check for a valid number instead of a specific number.
Apr 22 2019, 3:34 PM

Apr 17 2019

dyung committed rG3333cc66436b: Fix test on PS4 which defaults to gnu99 which does not emit the expected… (authored by dyung).
Fix test on PS4 which defaults to gnu99 which does not emit the expected…
Apr 17 2019, 4:59 PM
dyung committed rC358626: Fix test on PS4 which defaults to gnu99 which does not emit the expected….
Fix test on PS4 which defaults to gnu99 which does not emit the expected…
Apr 17 2019, 4:58 PM
dyung committed rL358626: Fix test on PS4 which defaults to gnu99 which does not emit the expected….
Fix test on PS4 which defaults to gnu99 which does not emit the expected…
Apr 17 2019, 4:58 PM

Apr 16 2019

dyung committed rG1925f418722f: Modify test to use -S instead of -c so that it works when an external assembler… (authored by dyung).
Modify test to use -S instead of -c so that it works when an external assembler…
Apr 16 2019, 3:52 PM