Page MenuHomePhabricator

dyung (Douglas Yung)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2016, 4:47 PM (330 w, 3 d)

Recent Activity

Wed, Jun 29

dyung added a comment to D107695: [llvm] [lit] Support forcing lexical test order.

Hey, I don't know if this has anything to do with this change.

But I see the "llvm-clang-x86_64-sie-win" buildbot (https://lab.llvm.org/buildbot/#/builders/216) failing the reorder.py testcase randomly every 10-20 builds.

See https://lab.llvm.org/buildbot/#/builders/216 for the list of recent builds.

I didn't look deeply into the root cause here, but thought it would be good to ping here in case anyone has an idea to get the bot more stable.

I'm the owner of that buildbot, but unfortunately have not been able to get the failure to reproduce outside of the buildbot initiated build environment, so I haven't been able to really look into the issue. Any ideas how to possibly debug and/or fix the issue would be greatly appreciated as I've been a bit stuck on how to get it more stable!

Wed, Jun 29, 5:10 PM · Restricted Project, Restricted Project

Thu, Jun 23

dyung added a reverting change for rG8b987ca5e37e: Add support for decoding base64.: rGf401dd6f43b3: Revert "Add support for decoding base64.".
Thu, Jun 23, 9:48 PM · Restricted Project, Restricted Project
dyung committed rGf401dd6f43b3: Revert "Add support for decoding base64." (authored by dyung).
Revert "Add support for decoding base64."
Thu, Jun 23, 9:48 PM · Restricted Project, Restricted Project
dyung added a reverting change for D126254: Add support for decoding base64.: rGf401dd6f43b3: Revert "Add support for decoding base64.".
Thu, Jun 23, 9:48 PM · Restricted Project, Restricted Project
dyung added a comment to D128476: [Sanitizers] Cleanup handling of stat64/statfs64.

I can confirm that the change seems to be working for me!

Thu, Jun 23, 6:05 PM · Restricted Project, Restricted Project
dyung added a comment to D126254: Add support for decoding base64..

Your change is failing to build on the PS4 Windows bot, can you take a look and revert if it takes time to fix?

Thu, Jun 23, 5:48 PM · Restricted Project, Restricted Project
dyung added a comment to D125263: [CMake][MSVC] Compile with `/permissive-`.

We are seeing failures in our internal Windows build with an older version of the Visual C++ compiler that I bisected back to this commit. The errors are all similar to this:

I don't see any obvious reason for this to fail, or be affected by /permissive-. Can you attach and/or send me preprocessed source for the failing file?

Hi, I have create github issue #56173 with a preprocessed source that should show the error when built using an older version of Visual C++.

Thu, Jun 23, 2:14 AM · Restricted Project, Restricted Project

Wed, Jun 22

dyung added a comment to D122539: [SelectionDAG][DAGCombiner] Reuse exist node by reassociate.

Hi @bcl5980, one of our internal tests started to hit an assertion failure while building which I bisected back to this change. I have filed the details as issue #56170, can you take a look?

Wed, Jun 22, 7:24 PM · Restricted Project, Restricted Project
dyung added a comment to D125263: [CMake][MSVC] Compile with `/permissive-`.

We are seeing failures in our internal Windows build with an older version of the Visual C++ compiler that I bisected back to this commit. The errors are all similar to this:

I don't see any obvious reason for this to fail, or be affected by /permissive-. Can you attach and/or send me preprocessed source for the failing file?

I've worked around the issue locally by disabling the call to /permissive-. I'll see what I can do to get a preprocessed source.

Wed, Jun 22, 12:40 PM · Restricted Project, Restricted Project

Tue, Jun 21

dyung added a comment to D125263: [CMake][MSVC] Compile with `/permissive-`.

We are seeing failures in our internal Windows build with an older version of the Visual C++ compiler that I bisected back to this commit. The errors are all similar to this:

C:\src\upstream\llvm_clean_git\clang\include\clang/Basic/Sanitizers.def(41,1): error C2131: expression did not evaluate to a constant [C:\src\upstream\df6291a666d3-PS4-Release\tools\clang\lib\Basic\obj.clangBasic.vcxproj]
C:\src\upstream\llvm_clean_git\clang\include\clang/Basic/Sanitizers.def(41,1): message : failure was caused by call of undefined function or one not declared 'constexpr' [C:\src\upstream\df6291a666d3-PS4-Release\tools\clang\lib\Basic\obj.clangBasic.vcxproj]
C:\src\upstream\llvm_clean_git\clang\include\clang/Basic/Sanitizers.def(41,1): message : see usage of 'clang::SanitizerMask::bitPosToMask' [C:\src\upstream\df6291a666d3-PS4-Release\tools\clang\lib\Basic\obj.clangBasic.vcxproj]
Tue, Jun 21, 7:01 PM · Restricted Project, Restricted Project

Thu, Jun 16

dyung added a comment to D126061: [clang] Reject non-declaration C++11 attributes on declarations.

@mboehme, one of our internal tests started to fail to compile after this change due to the compiler no longer accepting what I think should be a valid attribute declaration. I have filed issue #56077 for the problem, can you take a look?

Thu, Jun 16, 7:01 PM · Restricted Project, Restricted Project
dyung accepted D127943: cmake: configure clang lit to use hmaptool from source directly.

I tried it on Windows building with both ninja and Visual Studio and both seem to work after your change. LGTM.

Thu, Jun 16, 3:46 AM · Restricted Project, Restricted Project

Tue, Jun 14

dyung added a comment to D126308: cmake: use llvm dir variables for clang/utils/hmaptool.

Can you take a look?

Hi @dyung , thanks for the report and sorry for the trouble!
Can you help me try to reproduce it?

Which version of Visual Studio, and what preset are you using?

Tue, Jun 14, 10:59 AM · Restricted Project, Restricted Project
dyung added a comment to D126308: cmake: use llvm dir variables for clang/utils/hmaptool.

Hi @mizvekov, this change seems to have broken the location of the hmaptool when using the Visual Studio builder on Windows. After your commit, 7 clang tests fail because hmaptool cannot be found at the expected location. For example, the test clang/test/Preprocessor/headermap-rel.c:

FAIL: Clang :: Preprocessor/headermap-rel.c (1 of 1)
******************** TEST 'Clang :: Preprocessor/headermap-rel.c' FAILED ********************
Script:
--
: 'RUN: at line 1';   rm -f D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.hmap
: 'RUN: at line 2';   'C:/Program Files/Python310/python.exe' D:\src\upstream\51608515faa7-PS4-Release\Release\bin\hmaptool write D:\src\upstream\llvm_clean_git\clang\test\Preprocessor/Inputs/headermap-rel/foo.hmap.json D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.hmap
: 'RUN: at line 3';   d:\src\upstream\51608515faa7-ps4-release\release\bin\clang.exe -cc1 -internal-isystem d:\src\upstream\51608515faa7-ps4-release\release\lib\clang\15.0.0\include -nostdsysteminc -E D:\src\upstream\llvm_clean_git\clang\test\Preprocessor\headermap-rel.c -o D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.i -I D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.hmap -F D:\src\upstream\llvm_clean_git\clang\test\Preprocessor/Inputs/headermap-rel
: 'RUN: at line 4';   d:\src\upstream\51608515faa7-ps4-release\release\bin\filecheck.exe D:\src\upstream\llvm_clean_git\clang\test\Preprocessor\headermap-rel.c -input-file D:\src\upstream\51608515faa7-PS4-Release\tools\clang\test\Preprocessor\Output\headermap-rel.c.tmp.i
--
Exit Code: 2
Tue, Jun 14, 3:38 AM · Restricted Project, Restricted Project

Mon, Jun 13

dyung added a comment to D124561: [lld-macho] Support EH frames under arm64.

Hi, your recommit of your changes are causing a test failure on the PS4 bots because the newly added test target arm64 is not present, can you either fixup the test to not require that or add a REQUIRES line?

Mon, Jun 13, 10:45 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jun 10

dyung added a comment to D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore.

Just another data point, but we noticed the same issue of clang++ missing after install on our internal Windows builds, and I bisected it to this commit.

Fri, Jun 10, 7:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars.

No idea why the conversion fails for the wide string.
First step is to reproduce the problem. I guess we should try in a Ubuntu VM.
Is there an easy way to see if other builders succeeded?

Fri, Jun 10, 12:52 PM · Restricted Project, Restricted Project
dyung added a comment to D127343: [Sanitizers] Cleanup handling of stat64/statfs64.

This seems to be causing 7 test failures on our internal linux buildbot:

  • MemorySanitizer-X86_64 :: Linux/glob_altdirfunc.cpp
  • MemorySanitizer-X86_64 :: stat64.cpp
  • MemorySanitizer-lld-X86_64 :: Linux/glob_altdirfunc.cpp
  • MemorySanitizer-lld-X86_64 :: stat64.cpp
  • SanitizerCommon-asan-x86_64-Linux :: Posix/lstat64.cpp
  • SanitizerCommon-msan-x86_64-Linux :: Posix/lstat64.cpp
  • SanitizerCommon-tsan-x86_64-Linux :: Posix/lstat64.cpp
Fri, Jun 10, 1:09 AM · Restricted Project, Restricted Project

Thu, Jun 9

dyung added a reverting change for rG826be330af9c: [lld-macho] Initial support for EH Frames: rG942f4e3a7cc9: Revert "[lld-macho] Initial support for EH Frames".
Thu, Jun 9, 5:27 AM · Restricted Project
dyung committed rG942f4e3a7cc9: Revert "[lld-macho] Initial support for EH Frames" (authored by dyung).
Revert "[lld-macho] Initial support for EH Frames"
Thu, Jun 9, 5:27 AM · Restricted Project
dyung added a reverting change for rG977d62c33e33: [lld-macho] Support EH frames under arm64: rG10641a42e228: Revert "[lld-macho] Support EH frames under arm64".
Thu, Jun 9, 5:27 AM · Restricted Project
dyung committed rG10641a42e228: Revert "[lld-macho] Support EH frames under arm64" (authored by dyung).
Revert "[lld-macho] Support EH frames under arm64"
Thu, Jun 9, 5:27 AM · Restricted Project
dyung added a reverting change for D123435: [lld-macho] Initial support for EH Frames: rG942f4e3a7cc9: Revert "[lld-macho] Initial support for EH Frames".
Thu, Jun 9, 5:27 AM · Restricted Project, Restricted Project, Restricted Project
dyung added a reverting change for D124561: [lld-macho] Support EH frames under arm64: rG10641a42e228: Revert "[lld-macho] Support EH frames under arm64".
Thu, Jun 9, 5:27 AM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D124561: [lld-macho] Support EH frames under arm64.

Hello,

When I run tests (check-all) on this commit I get the follwoing two failures:

Failed Tests (2):
  lld :: MachO/eh-frame.s
  lld :: MachO/icf-safe.s

They crash with

Command Output (stderr):
--
ld64.lld: ../../lld/MachO/UnwindInfoSection.cpp:216: void lld::macho::UnwindInfoSection::addSymbol(const lld::macho::Defined *): Assertion `!p.first->second->unwindEntry' failed.
/repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/eh-frame.s.script: line 17: 123869 Aborted                 ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /repo/uabelho/main-github/lld/test/MachO/Inputs/MacOSX.sdk -fatal_warnings -arch arm64 -lSystem -lc++ /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/eh-frame.s.tmp/eh-frame-arm64.o -o /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/eh-frame.s.tmp/eh-frame-arm64

and

Command Output (stderr):
--
ld64.lld: ../../lld/MachO/ICF.cpp:451: auto lld::macho::foldIdenticalSections()::(anonymous class)::operator()(lld::macho::ConcatInputSection *) const: Assertion `isec->icfEqClass[0] == 0' failed.
ld64.lld: ../../lld/MachO/ICF.cpp:451: auto lld::macho::foldIdenticalSections()::(anonymous class)::operator()(lld::macho::ConcatInputSection *) const: Assertion `isec->icfEqClass[0] == 0' failed.
/repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/icf-safe.s.script: line 6: 45777 Aborted                 ld64.lld -arch x86_64 -platform_version macos 11.0 11.0 -syslibroot /repo/uabelho/main-github/lld/test/MachO/Inputs/MacOSX.sdk -fatal_warnings -arch arm64 -lSystem --icf=safe -dylib -o /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/icf-safe.s.tmp/icf-safe.dylib /repo/uabelho/main-github/llvm/build-all/tools/lld/test/MachO/Output/icf-safe.s.tmp/icf-obj.o

Any idea what's happening?

Thu, Jun 9, 5:25 AM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D123435: [lld-macho] Initial support for EH Frames.

This breaks tests everywhere: http://45.33.8.238/linux/78091/step_11.txt

Thu, Jun 9, 5:23 AM · Restricted Project, Restricted Project, Restricted Project
dyung added a comment to D124561: [lld-macho] Support EH frames under arm64.

The test you changed is failing on the PS4 Windows/Linux bots due to the arm64 triple not being available. Can you please fix the test?

Thu, Jun 9, 1:46 AM · Restricted Project, Restricted Project, Restricted Project

Tue, Jun 7

dyung added a reverting change for rGe80748ff8840: [clang-diff] Fix assertion error when dealing with wide strings: rG7805ae257f6b: Revert "[clang-diff] Fix assertion error when dealing with wide strings".
Tue, Jun 7, 2:59 PM · Restricted Project, Restricted Project
dyung committed rG7805ae257f6b: Revert "[clang-diff] Fix assertion error when dealing with wide strings" (authored by dyung).
Revert "[clang-diff] Fix assertion error when dealing with wide strings"
Tue, Jun 7, 2:59 PM · Restricted Project, Restricted Project
dyung added a reverting change for D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars: rG7805ae257f6b: Revert "[clang-diff] Fix assertion error when dealing with wide strings".
Tue, Jun 7, 2:59 PM · Restricted Project, Restricted Project
dyung added a comment to D126651: [clang-diff] Fix getStmtValue when dealing with wide, UTF16 UTF32 chars.

Hi, the test you modified in your change seems to be failing on the PS4 linux build bot at https://lab.llvm.org/buildbot/#/builders/139/builds/22964.

Tue, Jun 7, 12:16 PM · Restricted Project, Restricted Project

May 31 2022

dyung added a comment to D120201: [Clang] Extend -gen-reproducer flag.

The test you added seems to be failing on the PS4 Windows bot. A quick glance seems to suggest that you aren't properly escaping the path separators somewhere. Can you take a look and revert if you need time to investigate?

https://lab.llvm.org/buildbot/#/builders/216/builds/5164

Should be fixed by https://github.com/llvm/llvm-project/commit/a0ef52cc102504c4282dec7001664ee020396681

May 31 2022, 10:46 AM · Restricted Project, Restricted Project
dyung added a comment to D120201: [Clang] Extend -gen-reproducer flag.

The test you added seems to be failing on the PS4 Windows bot. A quick glance seems to suggest that you aren't properly escaping the path separators somewhere. Can you take a look and revert if you need time to investigate?

May 31 2022, 10:41 AM · Restricted Project, Restricted Project

May 20 2022

dyung added a reverting change for rG6990e7477d24: [ConstantRange] Improve the implementation of binaryOr: rG54e3bf5f37d6: Revert "[ConstantRange] Improve the implementation of binaryOr".
May 20 2022, 10:24 AM · Restricted Project, Restricted Project
dyung committed rG54e3bf5f37d6: Revert "[ConstantRange] Improve the implementation of binaryOr" (authored by dyung).
Revert "[ConstantRange] Improve the implementation of binaryOr"
May 20 2022, 10:24 AM · Restricted Project, Restricted Project

May 10 2022

dyung added a comment to D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks.

Hi @jkorous, 4 of the tests you added seem to be failing on the PS4 linux and Window buildbots, can you take a look, and revert if it might take a while to investigate?

May 10 2022, 11:38 AM · Restricted Project, Restricted Project, Restricted Project

May 9 2022

dyung committed rG62f7dc7c037c: Add x86 to REQUIRES line in test as suggested in https://reviews.llvm. (authored by dyung).
Add x86 to REQUIRES line in test as suggested in https://reviews.llvm.
May 9 2022, 6:02 PM · Restricted Project
dyung added a comment to D124105: [ELF] Support -plugin-opt=stats-file=.

@MTC @arichardson The test stats-file-option.ll that is now enabled after this commit seems to fail if X86 is not one of the built targets. Can the test be rewritten to now require that, or an appropriate REQUIRES line added?

May 9 2022, 12:59 PM · Restricted Project, Restricted Project

May 8 2022

dyung added a comment to D123801: [DAG][PowerPC] Combine shuffle(bitcast(X), Mask) to bitcast(shuffle(X, Mask')).

@dmgreen, just a heads up that we are seeing an infinite loop in the compiler on an internal test which I have bisected to this change. I'm working on a repro at the moment and will post it when I can get it.

May 8 2022, 11:10 PM · Restricted Project, Restricted Project
dyung added a comment to D123801: [DAG][PowerPC] Combine shuffle(bitcast(X), Mask) to bitcast(shuffle(X, Mask')).

@dmgreen, just a heads up that we are seeing an infinite loop in the compiler on an internal test which I have bisected to this change. I'm working on a repro at the moment and will post it when I can get it.

May 8 2022, 9:28 PM · Restricted Project, Restricted Project

May 6 2022

dyung added a comment to D124950: [HWASan] Allow to linkify symbolizer output..

Hi, the test you added, hwasan_symbolize.cpp seems to be causing a failure on the sanitizer buildbot (https://lab.llvm.org/buildbot/#/builders/37/builds/13022):

FAIL: HWAddressSanitizer-x86_64 :: TestCases/hwasan_symbolize.cpp (71 of 86)
******************** TEST 'HWAddressSanitizer-x86_64 :: TestCases/hwasan_symbolize.cpp' FAILED ********************
Script:
--
: 'RUN: at line 1';      /b/sanitizer-x86_64-linux/build/clang_build/./bin/clang   -m64  -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -fsanitize-hwaddress-experimental-aliasing -mllvm -hwasan-generate-tags-with-calls=1 -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions -Wl,--build-id -g /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/hwasan/TestCases/hwasan_symbolize.cpp -o /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp
: 'RUN: at line 2';   echo '[{"prefix": "'"$(realpath $(dirname /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp)/../../../../../../)"'/", "link": "http://test.invalid/{file}:{line}"}]' > /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp.linkify
: 'RUN: at line 3';   env HWASAN_OPTIONS=disable_allocator_tagging=1:random_tags=0:fail_without_syscall_abi=0:symbolize=0 not  /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp 2>&1 | hwasan_symbolize --html --symbols $(dirname /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp) --index | FileCheck /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/hwasan/TestCases/hwasan_symbolize.cpp
: 'RUN: at line 4';   env HWASAN_OPTIONS=disable_allocator_tagging=1:random_tags=0:fail_without_syscall_abi=0:symbolize=0 not  /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp 2>&1 | hwasan_symbolize --html --linkify /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp.linkify --symbols $(dirname /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp) --index | FileCheck --check-prefixes=CHECK,LINKIFY /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/hwasan/TestCases/hwasan_symbolize.cpp
: 'RUN: at line 5';   env HWASAN_OPTIONS=disable_allocator_tagging=1:random_tags=0:fail_without_syscall_abi=0:symbolize=0 not  /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp 2>&1 | hwasan_symbolize --symbols $(dirname /b/sanitizer-x86_64-linux/build/clang_build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/hwasan_symbolize.cpp.tmp) --index | FileCheck /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/hwasan/TestCases/hwasan_symbolize.cpp
--
Exit Code: 2
Command Output (stderr):
--
Traceback (most recent call last):
  File "/b/sanitizer-x86_64-linux/build/clang_build/./bin/hwasan_symbolize", line 19, in <module>
    import html
ImportError: No module named html
FileCheck error: '<stdin>' is empty.
FileCheck command line:  FileCheck /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/test/hwasan/TestCases/hwasan_symbolize.cpp
--

And also our internal linux buildbot is reporting a failure after this commit:

/home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/hwasan/TestCases/hwasan_symbolize.cpp:17:14: error: LINKIFY: expected string not found in input
 // LINKIFY: <a href="http://test.invalid/compiler-rt/test/hwasan/TestCases/hwasan_symbolize.cpp:[[@LINE-1]]">
             ^
<stdin>:1:1: note: scanning from here
==27214==ERROR: HWAddressSanitizer: tag-mismatch on address 0x680400000064 at pc 0x55d1c8f6e76b<br/>
^
<stdin>:1:1: note: with "@LINE-1" equal to "16"
==27214==ERROR: HWAddressSanitizer: tag-mismatch on address 0x680400000064 at pc 0x55d1c8f6e76b<br/>
^
<stdin>:6:68: note: possible intended match here
&nbsp;&nbsp;&nbsp;&nbsp;#1 main in /home/siadmin/jenkins/w/opensource/opensource_build/working_dir/compiler-rt/test/hwasan/TestCases/hwasan_symbolize.cpp:16:10<br/>
                                                                   ^
May 6 2022, 12:41 AM · Restricted Project, Restricted Project

May 3 2022

dyung committed rG0cb59607dc9b: Mark test icf-safe.s as requiring aarch64 to fix buildbots which don't build… (authored by dyung).
Mark test icf-safe.s as requiring aarch64 to fix buildbots which don't build…
May 3 2022, 10:46 PM · Restricted Project

May 2 2022

dyung added a comment to D124643: [Object][DX] Initial DXContainer parsing support.

The PS4 linux buildbot which runs gcc is not building any longer after this change, @beanz can you take a look?

May 2 2022, 1:01 PM · Restricted Project, Restricted Project
dyung added a comment to D124699: [DeadArgElim] Set unused arguments for internal functions.

Hi @qcolombet, your change seems to be causing 2 test failures on the PS4 build bots, can you please take a look?

May 2 2022, 12:59 PM · Restricted Project, Restricted Project, Restricted Project

Apr 27 2022

dyung committed rG6adb8c220875: Fix test fail-file-open.test on Windows to hopefully fix the Windows buildbots. (authored by dyung).
Fix test fail-file-open.test on Windows to hopefully fix the Windows buildbots.
Apr 27 2022, 5:31 PM · Restricted Project, Restricted Project
dyung added a comment to D114115: [Driver] Support for compressed debug info on Fuchsia.

I think the problem here is that if zlib is not available, you won't get the clang command line you expect:

Apr 27 2022, 11:43 AM · Restricted Project, Restricted Project

Apr 21 2022

dyung committed rG311929267d29: Mark test stack-usage-safestack.c as requiring x86. (authored by dyung).
Mark test stack-usage-safestack.c as requiring x86.
Apr 21 2022, 1:59 PM · Restricted Project, Restricted Project

Apr 19 2022

dyung committed rGc95275420610: Make tests slightly more flexible for platforms which emit arguments in between… (authored by dyung).
Make tests slightly more flexible for platforms which emit arguments in between…
Apr 19 2022, 11:27 PM · Restricted Project, Restricted Project

Apr 13 2022

dyung added a comment to D120286: AMDGPU: Don't use unreachable on stores to unhandled address space.

Hi @arsenm, the test you added is failing on our internal linux build bot that builds a release build without asserts with the following error:

Command Output (stderr):
--
/home/dyung/src/upstream/llvm_clean_git/llvm/test/CodeGen/AMDGPU/store-to-constant-error.ll:4:9: error: SDAG: expected string not found in input
; SDAG: LLVM ERROR: Cannot select: t{{[0-9]+}}: ch = store<(store (s32) into %ir.ptr.load, addrspace 4)>
        ^
<stdin>:1:1: note: scanning from here
LLVM ERROR: Cannot select: 0x55f05ad6f228: ch = store<(store (s32) into %ir.ptr.load, addrspace 4)> 0x55f05acd7d38, Constant:i32<1>, 0x55f05ad6f020, undef:i64
^

Can you take a look?

Apr 13 2022, 11:28 AM · Restricted Project, Restricted Project

Apr 8 2022

dyung added a comment to D121556: [randstruct] Add randomize structure layout support.

Hi, the test you added is failing on the PS4 Windows bot https://lab.llvm.org/buildbot/#/builders/216/builds/2647.

Apr 8 2022, 1:56 PM · Restricted Project, Restricted Project

Apr 5 2022

dyung added a comment to D121445: [Clang][CSKY] Add the CSKY target and compiler driver.

Hi, one of the tests you added. csky-toolchain.c seems to be failing on a Windows build bot, and from a quick look, it appears to be a path separator issue. Can you take a look?

Apr 5 2022, 9:21 PM · Restricted Project, Restricted Project, Restricted Project

Mar 30 2022

dyung added a comment to D122611: [clang][extract-api] Add support for macros.

This change is causing 9 test failures on a buildbot, can you please take a look and revert if you need time to investigate?

Mar 30 2022, 11:28 AM · Restricted Project, Restricted Project

Mar 25 2022

dyung added a comment to D117522: [clang-tidy] Add modernize-macro-to-enum check.

I've reverted this change in order to get the build bots green again.

Mar 25 2022, 11:55 AM · Restricted Project, Restricted Project
dyung added a reverting change for rG39b80c8380c8: [clang-tidy] Add modernize-macro-to-enum check: rGcef52105bd4b: Revert "[clang-tidy] Add modernize-macro-to-enum check".
Mar 25 2022, 11:54 AM · Restricted Project, Restricted Project
dyung committed rGcef52105bd4b: Revert "[clang-tidy] Add modernize-macro-to-enum check" (authored by dyung).
Revert "[clang-tidy] Add modernize-macro-to-enum check"
Mar 25 2022, 11:54 AM · Restricted Project, Restricted Project
dyung added a reverting change for D117522: [clang-tidy] Add modernize-macro-to-enum check: rGcef52105bd4b: Revert "[clang-tidy] Add modernize-macro-to-enum check".
Mar 25 2022, 11:54 AM · Restricted Project, Restricted Project

Mar 24 2022

dyung added a comment to D120490: [ELF] Enable new passmanager plugin support for LTO.

This change is causing CMake failures on at least 2 different bots due to a missing dependency target "Bye". Can you take a look?

Mar 24 2022, 1:26 AM · Restricted Project, Restricted Project

Mar 18 2022

dyung added a comment to D121750: Add a cmake flag to turn `llvm_unreachable()` into builtin_trap() when assertions are disabled.

This seems to be breaking our internal Release Windows build with errors of the sort:

Mar 18 2022, 12:25 AM · Restricted Project, Restricted Project

Mar 16 2022

dyung added a comment to D121469: v256i32|64 reduction isel and tests.

The tests you added are failing on a Windows buildbot, I'm guessing it is because you are explicitly setting the output to /dev/stdout which likely doesn't exist on Windows. Can you take a look?

Mar 16 2022, 8:53 AM · Restricted Project, Restricted Project, Restricted Project

Mar 4 2022

dyung added a comment to D118642: [IVDescriptor] Find original 'Previous' for first-order recurrences..

@fhahn This change seems to be hitting an assertion failure in one of our internal tests. I have filed GHI#54223 with a repro. Can you take a look?

Mar 4 2022, 11:34 PM · Restricted Project, Restricted Project
dyung added a comment to D121014: [WebAssembly] Check bulk-memory when adjusting lang opts.

This change seems to be causing many bots to fail when running the clang :: Preprocessor/init.c test, can you take a look?

Mar 4 2022, 6:26 PM · Restricted Project, Restricted Project

Mar 3 2022

dyung added a comment to D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions.

Thanks for fixing the problem with the original commit, but in the future, if you make follow-up commits, can you change the commit message to reflect what the commit contains? Having three different commits with the exact same commit message can be very confusing.

Mar 3 2022, 11:52 PM · Restricted Project, Restricted Project
dyung added a comment to D120489: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions.

And the PS4 build bots:

Mar 3 2022, 10:50 AM · Restricted Project, Restricted Project

Mar 2 2022

dyung committed rGe81e5d788cd8: Add "REQUIRES: x86" to test as it calls llc with an x86_64 triple. (authored by dyung).
Add "REQUIRES: x86" to test as it calls llc with an x86_64 triple.
Mar 2 2022, 11:13 AM · Restricted Project

Feb 24 2022

dyung added a comment to D120254: [OpenCL] Align subgroup builtin guards.

If it helps, this is the cmake command I am using to build using gcc on linux:

CMake command: -G Ninja -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_VERSION_SUFFIX= -DLLVM_BUILD_RUNTIME=ON -DLLVM_TOOL_LLD_BUILD=OFF "-DLLVM_LIT_ARGS=--verbose -j80 --no-progress-bar --max-tests 10" -DCMAKE_BUILD_TYPE=Release -DLLVM_OPTIMIZED_TABLEGEN=ON -DLLVM_TARGETS_TO_BUILD=all -DLLVM_ENABLE_PROJECTS=clang;clang-tools-extra

Some of the stuff there probably isn't needed (it's taken from a general script that I make small changes to when trying to reproduce stuff), but is there for completeness.

Feb 24 2022, 2:36 AM · Restricted Project, Restricted Project
dyung added a comment to D120254: [OpenCL] Align subgroup builtin guards.

Hi, our internal release build bots are showing failures in two clang-tidy tests that I bisected back to your commit, clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and clang-tidy/checkers/altera-single-work-item-barrier.cpp. After this change, both are exhibiting this error:

Error while processing /home/dyung/src/upstream/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b-linux/tools/clang/tools/extra/test/clang-tidy/checkers/Output/altera-single-work-item-barrier.cpp.tmp.cpp.
error: enum type memory_scope not found; include the base header with -finclude-default-header [clang-diagnostic-error]

Oddly, this only fails in a release configuration. Can you take a look?

I'll try to reproduce the failure locally, but until I've done so perhaps you could try whether the following fixes one of the tests? If so, then the other test will likely need a similar fix.

diff --git a/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp b/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
index a6dbab7b72fc..9bc1bbf173cc 100644
--- a/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
+++ b/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
@@ -1,4 +1,4 @@
-// RUN: %check_clang_tidy %s altera-id-dependent-backward-branch %t -- -header-filter=.* "--" -cl-std=CL1.2 -c --include opencl-c.h
+// RUN: %check_clang_tidy %s altera-id-dependent-backward-branch %t -- -header-filter=.* "--" -cl-std=CL1.2 -c --include opencl-c.h --include opencl-c-base.h
 
 typedef struct ExampleStruct {
   int IDDepField;
Feb 24 2022, 2:33 AM · Restricted Project, Restricted Project
dyung added a comment to D120254: [OpenCL] Align subgroup builtin guards.

Hi, our internal release build bots are showing failures in two clang-tidy tests that I bisected back to your commit, clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and clang-tidy/checkers/altera-single-work-item-barrier.cpp. After this change, both are exhibiting this error:

Error while processing /home/dyung/src/upstream/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b-linux/tools/clang/tools/extra/test/clang-tidy/checkers/Output/altera-single-work-item-barrier.cpp.tmp.cpp.
error: enum type memory_scope not found; include the base header with -finclude-default-header [clang-diagnostic-error]

Oddly, this only fails in a release configuration. Can you take a look?

Feb 24 2022, 2:13 AM · Restricted Project, Restricted Project

Feb 18 2022

dyung committed rGacc08a2f1bd3: Add "REQUIRES: asserts" to test misched-predicate-virtreg.mir which uses "… (authored by dyung).
Add "REQUIRES: asserts" to test misched-predicate-virtreg.mir which uses "…
Feb 18 2022, 1:49 AM

Feb 17 2022

dyung added a comment to D120093: [memprof] Fix frame deserialization on big endian systems..

Hi Snehasish, your change is likely causing 3 test failures on the PS4 linux buildbot, can you take a look?

Feb 17 2022, 3:50 PM · Restricted Project
dyung added a comment to D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments.

Hi, the test you added is failing on the PS4 Linux bot, can you take a look?

https://lab.llvm.org/buildbot/#/builders/139/builds/17199

Looks like the compiled SPIR-V is slightly different for different build settings, for llvm-clang-x86_64-sie-ubuntu-fast, it is compiled to

define hidden spir_kernel void @_Z6kernelPi(i32 addrspace(1)* noundef %output.coerce) #0 {

so it is missing that extra hidden keyword.
And for clang-ve-ninja, it is compiled to

define spir_kernel void @_Z6kernelPi(i32 addrspace(1)* noundef %0) #0 {

so the kernel argument identifier is slightly different (%0 vs %output.coerce).

I could fix that, I wonder why it didn't trigger the same issue (for the hidden keyword) with this test tho, it is basically the same.

And why does those build test run only after merging? For future reference, can I try to run those myself before submitting?

Feb 17 2022, 12:15 PM · Restricted Project
dyung added a comment to D119207: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments.

Hi, the test you added is failing on the PS4 Linux bot, can you take a look?

Feb 17 2022, 11:18 AM · Restricted Project

Feb 11 2022

dyung added a comment to D118070: Make lld-link work in a non-MSVC shell.

I've reverted this and the follow-up change to fix the build in 437d4e01fe4c057509dff30efd560049ad07bc99.

Feb 11 2022, 11:50 PM · Restricted Project, Restricted Project
dyung added a reverting change for rG73e585e44d68: Reland "[lld/coff] Make lld-link work in a non-MSVC shell, add /winsysroot:": rG437d4e01fe4c: Revert "try to fix windows build after 73e585e44d" and.
Feb 11 2022, 11:50 PM
dyung added a reverting change for rG0574b5fc6574: try to fix windows build after 73e585e44d: rG437d4e01fe4c: Revert "try to fix windows build after 73e585e44d" and.
Feb 11 2022, 11:49 PM
dyung committed rG437d4e01fe4c: Revert "try to fix windows build after 73e585e44d" and (authored by dyung).
Revert "try to fix windows build after 73e585e44d" and
Feb 11 2022, 11:49 PM
dyung added a comment to D118070: Make lld-link work in a non-MSVC shell.

I'm not exactly sure why, but this change seems to be causing the Driver/cl-options.c test to fail on the PS4 Windows bot:

Feb 11 2022, 4:17 PM · Restricted Project, Restricted Project

Feb 10 2022

dyung committed rG98504fbb3d18: Make shtest-format.py CHECK lines more flexible (authored by dyung).
Make shtest-format.py CHECK lines more flexible
Feb 10 2022, 1:50 PM
dyung closed D118691: Make shtest-format.py CHECK lines more flexible.
Feb 10 2022, 1:50 PM · Restricted Project
dyung updated the diff for D118691: Make shtest-format.py CHECK lines more flexible.

Update change based on @probinson 's feedback.

Feb 10 2022, 1:43 AM · Restricted Project
dyung added a comment to D118376: [x86] try harder to scalarize a vector load with extracted integer op uses.

I was able to reproduce the issue with a small testcase that I have filed as issue 53695. Hope that helps.

Feb 10 2022, 12:54 AM · Restricted Project, Restricted Project

Feb 9 2022

dyung added a comment to D118691: Make shtest-format.py CHECK lines more flexible.

This is a simple change that could make Windows testing of this test more reliable I think. Could I get a quick review?

Feb 9 2022, 11:17 AM · Restricted Project

Feb 4 2022

dyung added a comment to D118376: [x86] try harder to scalarize a vector load with extracted integer op uses.

Just a heads up that we potentially saw an issue with this commit on some of our internal tests. I've bisected it down to your commit, but I need to make sure it reproduces with an opensource compiler (without our private changes), and if so I will post a bug with the information.

Feb 4 2022, 11:22 AM · Restricted Project, Restricted Project
dyung committed rZORG010945f2afe4: Revert PS4 linux bot to original configuration and add cross-project-tests… (authored by dyung).
Revert PS4 linux bot to original configuration and add cross-project-tests…
Feb 4 2022, 10:23 AM
dyung closed D118881: Revert PS4 linux bot to original configuration and add cross-project-tests builder.
Feb 4 2022, 10:23 AM · Restricted Project, Restricted Project

Feb 3 2022

dyung updated subscribers of D118881: Revert PS4 linux bot to original configuration and add cross-project-tests builder.
Feb 3 2022, 11:09 PM · Restricted Project, Restricted Project
dyung added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Oops, sorry about that. What is the correct way to test/reproduce the change? Do I / can I submit builds to the buildbot manually for testing?

Also, should I be rolling back this change, or no? Not sure of the protocol here, this is my first change to Clang.

P.S. that breakage is disturbing -- I would not have expected this sort of failure on any platform, and I'm not sure if it reflects a bug on PS4. (It seems to be that structs are passed in registers, even if the member variables of that struct cannot be.)

Feb 3 2022, 2:00 PM · Restricted Project
dyung added a comment to D114732: [clang] Mark `trivial_abi` types as "trivially relocatable"..

Hi, your change is causing a test failure in the test attr-trivial-abi.cpp that you modified on the PS4 Windows box:

Feb 3 2022, 12:13 PM · Restricted Project
dyung requested review of D118881: Revert PS4 linux bot to original configuration and add cross-project-tests builder.
Feb 3 2022, 2:00 AM · Restricted Project, Restricted Project

Feb 1 2022

dyung retitled D118691: Make shtest-format.py CHECK lines more flexible from Make shtest-format.py more CHECK lines more flexible to Make shtest-format.py CHECK lines more flexible.
Feb 1 2022, 3:33 AM · Restricted Project
dyung requested review of D118691: Make shtest-format.py CHECK lines more flexible.
Feb 1 2022, 3:33 AM · Restricted Project

Jan 28 2022

dyung added a comment to D117694: [UpdateTestChecks] Add --filter and --filter-out options.

Your change seems to be causing some test failures on a buildbot, can you take a look?

Jan 28 2022, 3:32 PM · Restricted Project, Restricted Project

Jan 26 2022

dyung closed D117729: Update PS4 bot configurations.

Not sure why this wasn't closed automatically, but the changes were committed in https://reviews.llvm.org/rZORGc561bb939d9acad8dc9dce45692de7fa5e673101.

Jan 26 2022, 10:33 PM · Restricted Project
dyung committed rZORGc561bb939d9a: Small updates to PS4 buildbots. (authored by dyung).
Small updates to PS4 buildbots.
Jan 26 2022, 9:28 PM
dyung added a comment to D117729: Update PS4 bot configurations.

Ping

Jan 26 2022, 6:29 PM · Restricted Project
dyung added a comment to D118183: Fix UB in DwarfExpression::emitLegacyZExt().

Hi Adrian, the test you updated in your commit is failing on the PS4 linux bot, can you take a look?

Jan 26 2022, 12:18 PM · Restricted Project, debug-info

Jan 21 2022

dyung committed rZORG5881c01a4e6f: Change -j64 to -j61 to avoid a python bug where lit just hangs after testing. (authored by dyung).
Change -j64 to -j61 to avoid a python bug where lit just hangs after testing.
Jan 21 2022, 12:59 PM

Jan 19 2022

dyung requested review of D117729: Update PS4 bot configurations.
Jan 19 2022, 4:04 PM · Restricted Project
dyung closed D117212: Add Windows PS4 builder.
Jan 19 2022, 3:44 PM · Restricted Project
dyung committed rZORGb25fbc405c67: Add worker sie-win-worker and builder llvm-clang-x86_64-sie-win. (authored by dyung).
Add worker sie-win-worker and builder llvm-clang-x86_64-sie-win.
Jan 19 2022, 3:44 PM
dyung updated the diff for D117212: Add Windows PS4 builder.

Remove compiler-rt as a dependency and build target.

Jan 19 2022, 2:18 AM · Restricted Project