Sorry for the lack of context, I made my diffs using a new method this time, but I'll make sure it has the full context next time. Thanks!

LGTM as well. I also tested it and it fails before your change, and passes with your change.

Hi, the test you added seems to pass both before and after your change, is this intended?

I have reverted this change and the follow-up commit in b03c2b8395ba94fb53f1e73a6473faedf628bbd9. Hopefully this should get the bots green again.

In D86360#2278087, @aeubanks wrote:

In D86360#2278086, @wolfgangp wrote:

This commit seems to cause a test failure on some bots, e.g. here.

I think it was already fixed, the bot has been green for the last 2 runs.

I have reverted this change in 8d2d0e84857cb1f2d01456eb433b5172d3a0772b to get the build bots green again.

Looks good, thanks for fixing this for us!

Thanks for the fix!

@craig.topper, I made this fix after your refactor in 3537939cda86f0b5b06233eb99ddc9eb22935008. The main issue I wanted to bring to your attention is that you added FeatureLWP support to ZNVer1 which wasn't there before. If this is correct, please undo my change there. Thanks!

I've reverted this change in g059ba74bb6f6166ca7c1783ef81dd37a5209b758 to get the bots green again.

Matt, this change to the test was causing a failure in the upstream PS4 linux bot here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68593

Hi, we noticed an issue with the GDB test suite that was bisected back to this change and I have put the details in PR46052. Can you take a look?

Removed REQUIRES line in test since it is not needed

In D50078#1999183, @Typz wrote:

In D50078#1998578, @hokein wrote:

In D50078#1998520, @Typz wrote:

In D50078#1998398, @dyung wrote:

Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly fail about 50% of the time on Windows.

Take the most recent 5 runs of the llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast buildbot. Builds #31973, 31975 and 31976 all failed because of that test failing.

On my local Windows computer, if I build your commit and run the FormatTest unit test multiple times (the same binary without changing anything or rebuilding), that above test fails roughly 50% of the time.

Can you take a look to figure out why your change might be causing this instability?

Hi,
That is very strange indeed, nothing is supposed to be random here...
I will try to have a look, but I don't have a windows computer to test, and never seen this issue on linux/macos :-/

The linux (s390x arch) buildbot is also failing, http://lab.llvm.org:8011/builders/clang-s390x-linux/builds/31811/steps/ninja%20check%201/logs/stdio.
I reverted it in 47ef09e4848a970c530928496b54085cfdba5a76 to make buildbot happy.

Unfortunately I don't have access to either an s390x or a windows machine; is there a way to trigger a "private" build on buildbot, to use the same setup/build env ?
Or some other way to quickly get the required build env?

(Otherwise, could you please check if adding initialization of ConditionalsLevel to 0 in constructor of WhitespaceManager::Change class (WhitespaceManager.cpp:43).cpp fixes the issue ?)

Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly fail about 50% of the time on Windows.

In D75849#1942411, @arphaman wrote:

In D75849#1942382, @arphaman wrote:

Hi @graywolf-at-work, @dvyukov

This change causes compiler-rt to fail to build lib/CMakeFiles/SanitizerLintCheck on Darwin with the following error:

clang-11: warning: include path for libstdc++ headers not found; pass '-stdlib=libc++' on the command line to use the libc++ standard library instead [-Wstdlibcxx-not-found]
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/nm: race_darwin_amd64.syso: No such file or directory.

Example: http://lab.llvm.org:8080/green/job/clang-stage1-RA/7900/consoleFull#-87031640a1ca8a51-895e-46c6-af87-ce24fa4cd561

Can you please take a look at this issue as soon as you can? Let me know if you need help reproducing this.

Apologies, I think I misdiagnosed the failure. I think there's another issue that follows the missing race_darwin_amd64.syso that is failing the build. I'll get back to you once I know more.

ping

I think there is still at least one bot failure due to this change:

It is also failing in at least 2 of the public bots:

`The test you added in this change seems to be failing on Windows, can you take a look?

This change caused the Import/namespace/struct-and-var/test.cpp test to fail on ARM due to an extra line with `-CXXRecordDecl being emitted by the compiler that was being matched instead of the intended line. I checked in a fix to tighten up the check a little more so that it gets the correct line in 757bc55. I don't think it should negatively affect the test, but please do review the change.

In D70348#1748580, @craig.topper wrote:

You could probably just define add ORBIS to every line and then rely on the individual feature defines at the end of the line to re-enable the ones that are really supported. I assume the target-cpu is set to btver for ps4?

I tried applying this to our internal sources and it worked, so LGTM as well.

Sorry for breaking this, I thought the change would be trivial, guess it was not. From what I can remember, Peter's change was causing our internal testing to break because we don't build/use LLD for our platform.

LGTM

Is someone working on a fix for this that will go in soon? I am about to revert this change because it is blocking our internal builds as well as breaking both of the public PS4 bots.