Page MenuHomePhabricator

dyung (Douglas Yung)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 4 2016, 4:47 PM (168 w, 17 h)

Recent Activity

Wed, May 1

dyung added a comment to D61187: [clangd] Move clangd tests to clangd directory. check-clangd is no longer part of check-clang-tools..

FYI, we had to disable clangd entirely after this patch, getting a weird problem with lit that we haven't figured out yet.
In case anybody else has seen something like this, and knows what's going on, please let us know.

  Running all regression tests
  llvm-lit.py: C:/j/w/opensource/opensource_to_sce_merge__2/o/llvm\utils\lit\lit\llvm\config.py:336: fatal: couldn't find 'clang' program, try setting CLANG in your environment
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V140\Microsoft.CppCommon.targets(171,5): error MSB6006: "cmd.exe" exited with code 2. [C:\j\w\opensource\opensource_to_sce_merge__2\build\check-all.vcxproj]
Wed, May 1, 4:49 PM · Restricted Project, Restricted Project

Mon, Apr 29

dyung committed rG2ac6aca8af70: Make test more robust by writing stdout/stderr to different files. (authored by dyung).
Make test more robust by writing stdout/stderr to different files.
Mon, Apr 29, 3:56 PM
dyung committed rL359512: Make test more robust by writing stdout/stderr to different files..
Make test more robust by writing stdout/stderr to different files.
Mon, Apr 29, 3:55 PM
dyung committed rC359512: Make test more robust by writing stdout/stderr to different files..
Make test more robust by writing stdout/stderr to different files.
Mon, Apr 29, 3:55 PM

Apr 22 2019

dyung committed rG16df7e086b6f: Relax test to check for a valid number instead of a specific number. (authored by dyung).
Relax test to check for a valid number instead of a specific number.
Apr 22 2019, 3:34 PM
dyung committed rL358926: Relax test to check for a valid number instead of a specific number..
Relax test to check for a valid number instead of a specific number.
Apr 22 2019, 3:34 PM

Apr 17 2019

dyung committed rG3333cc66436b: Fix test on PS4 which defaults to gnu99 which does not emit the expected… (authored by dyung).
Fix test on PS4 which defaults to gnu99 which does not emit the expected…
Apr 17 2019, 4:59 PM
dyung committed rC358626: Fix test on PS4 which defaults to gnu99 which does not emit the expected….
Fix test on PS4 which defaults to gnu99 which does not emit the expected…
Apr 17 2019, 4:58 PM
dyung committed rL358626: Fix test on PS4 which defaults to gnu99 which does not emit the expected….
Fix test on PS4 which defaults to gnu99 which does not emit the expected…
Apr 17 2019, 4:58 PM

Apr 16 2019

dyung committed rG1925f418722f: Modify test to use -S instead of -c so that it works when an external assembler… (authored by dyung).
Modify test to use -S instead of -c so that it works when an external assembler…
Apr 16 2019, 3:52 PM
dyung committed rC358537: Modify test to use -S instead of -c so that it works when an external assembler….
Modify test to use -S instead of -c so that it works when an external assembler…
Apr 16 2019, 3:51 PM
dyung committed rL358537: Modify test to use -S instead of -c so that it works when an external assembler….
Modify test to use -S instead of -c so that it works when an external assembler…
Apr 16 2019, 3:51 PM

Apr 15 2019

dyung committed rG45129145b9dd: Fix test on Windows that uses a different path separator character. (authored by dyung).
Fix test on Windows that uses a different path separator character.
Apr 15 2019, 2:42 PM
dyung committed rLLD358453: Fix test on Windows that uses a different path separator character..
Fix test on Windows that uses a different path separator character.
Apr 15 2019, 2:41 PM
dyung committed rL358453: Fix test on Windows that uses a different path separator character..
Fix test on Windows that uses a different path separator character.
Apr 15 2019, 2:41 PM

Mar 22 2019

dyung committed rG8316ea42992f: Revert "[llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and… (authored by dyung).
Revert "[llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and…
Mar 22 2019, 2:09 PM
dyung added a reverting change for rG94a0cffe250c: [llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and `GNU…: rG8316ea42992f: Revert "[llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and….
Mar 22 2019, 2:09 PM
dyung committed rL356811: Revert "[llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and….
Revert "[llvm-readobj] Separate `Symbol Version` dumpers into `LLVM style` and…
Mar 22 2019, 2:08 PM

Mar 20 2019

dyung committed rG6452ba478638: Revert "Reland r356547 after fixing the tests for Linux." (authored by dyung).
Revert "Reland r356547 after fixing the tests for Linux."
Mar 20 2019, 4:22 PM
dyung added a reverting change for rG538fb72226cf: Reland r356547 after fixing the tests for Linux.: rG6452ba478638: Revert "Reland r356547 after fixing the tests for Linux.".
Mar 20 2019, 4:22 PM
dyung committed rL356630: Revert "Reland r356547 after fixing the tests for Linux.".
Revert "Reland r356547 after fixing the tests for Linux."
Mar 20 2019, 4:20 PM
dyung committed rCTE356630: Revert "Reland r356547 after fixing the tests for Linux.".
Revert "Reland r356547 after fixing the tests for Linux."
Mar 20 2019, 4:20 PM

Mar 19 2019

dyung committed rG16a8c5412722: Retry to add workaround to build scoped enums with VS2015. NFCI. (authored by dyung).
Retry to add workaround to build scoped enums with VS2015. NFCI.
Mar 19 2019, 6:52 PM
dyung committed rL356534: Retry to add workaround to build scoped enums with VS2015. NFCI..
Retry to add workaround to build scoped enums with VS2015. NFCI.
Mar 19 2019, 6:51 PM
dyung committed rG30ff4363195d: Revert "Add workaround to build scoped enums with VS2015. NFCI." (authored by dyung).
Revert "Add workaround to build scoped enums with VS2015. NFCI."
Mar 19 2019, 5:40 PM
dyung added a reverting change for rG6080a6fb1949: Add workaround to build scoped enums with VS2015. NFCI.: rG30ff4363195d: Revert "Add workaround to build scoped enums with VS2015. NFCI.".
Mar 19 2019, 5:40 PM
dyung committed rL356533: Revert "Add workaround to build scoped enums with VS2015. NFCI.".
Revert "Add workaround to build scoped enums with VS2015. NFCI."
Mar 19 2019, 5:40 PM
dyung committed rG6080a6fb1949: Add workaround to build scoped enums with VS2015. NFCI. (authored by dyung).
Add workaround to build scoped enums with VS2015. NFCI.
Mar 19 2019, 5:28 PM
dyung committed rL356532: Add workaround to build scoped enums with VS2015. NFCI..
Add workaround to build scoped enums with VS2015. NFCI.
Mar 19 2019, 5:25 PM
dyung committed rG774239144191: Move options to separate checks that do not need to immediately follow the… (authored by dyung).
Move options to separate checks that do not need to immediately follow the…
Mar 19 2019, 12:34 PM
dyung committed rL356507: Move options to separate checks that do not need to immediately follow the….
Move options to separate checks that do not need to immediately follow the…
Mar 19 2019, 12:33 PM
dyung committed rC356507: Move options to separate checks that do not need to immediately follow the….
Move options to separate checks that do not need to immediately follow the…
Mar 19 2019, 12:33 PM

Mar 13 2019

dyung committed rG591040adc266: Fixup tests to check for any MCInst number instead of a specific one. (authored by dyung).
Fixup tests to check for any MCInst number instead of a specific one.
Mar 13 2019, 6:26 PM
dyung committed rL356115: Fixup tests to check for any MCInst number instead of a specific one..
Fixup tests to check for any MCInst number instead of a specific one.
Mar 13 2019, 6:26 PM

Mar 12 2019

dyung committed rGc61573c93f97: Fixup test to work after changes in r355878. (authored by dyung).
Fixup test to work after changes in r355878.
Mar 12 2019, 1:04 PM
dyung committed rL355959: Fixup test to work after changes in r355878..
Fixup test to work after changes in r355878.
Mar 12 2019, 1:03 PM
dyung committed rLLD355959: Fixup test to work after changes in r355878..
Fixup test to work after changes in r355878.
Mar 12 2019, 1:03 PM

Feb 27 2019

dyung committed rG83663fd989ef: Add username to TODO comment in sanitizer to satisfy sanitizer lint check. NFC (authored by dyung).
Add username to TODO comment in sanitizer to satisfy sanitizer lint check. NFC
Feb 27 2019, 5:21 PM
dyung committed rCRT355062: Add username to TODO comment in sanitizer to satisfy sanitizer lint check. NFC.
Add username to TODO comment in sanitizer to satisfy sanitizer lint check. NFC
Feb 27 2019, 5:21 PM
dyung committed rL355062: Add username to TODO comment in sanitizer to satisfy sanitizer lint check. NFC.
Add username to TODO comment in sanitizer to satisfy sanitizer lint check. NFC
Feb 27 2019, 5:21 PM

Feb 20 2019

dyung committed rG38dd1b3726c2: Attempt to fix VS2015 build breakage from r354517. NFCI. (authored by dyung).
Attempt to fix VS2015 build breakage from r354517. NFCI.
Feb 20 2019, 8:56 PM
dyung committed rCTE354545: Attempt to fix VS2015 build breakage from r354517. NFCI..
Attempt to fix VS2015 build breakage from r354517. NFCI.
Feb 20 2019, 8:55 PM
dyung committed rL354545: Attempt to fix VS2015 build breakage from r354517. NFCI..
Attempt to fix VS2015 build breakage from r354517. NFCI.
Feb 20 2019, 8:55 PM

Feb 14 2019

dyung committed rG48d680dd5667: Further relax restriction in tests to include where "-E" and "-S" must appear. (authored by dyung).
Further relax restriction in tests to include where "-E" and "-S" must appear.
Feb 14 2019, 1:37 PM
dyung committed rC354063: Further relax restriction in tests to include where "-E" and "-S" must appear..
Further relax restriction in tests to include where "-E" and "-S" must appear.
Feb 14 2019, 1:37 PM
dyung committed rL354063: Further relax restriction in tests to include where "-E" and "-S" must appear..
Further relax restriction in tests to include where "-E" and "-S" must appear.
Feb 14 2019, 1:36 PM
dyung committed rG7f95f9639118: Revert "Temporarily disable calls to getgrnam/getgrnam_r in test due to it… (authored by dyung).
Revert "Temporarily disable calls to getgrnam/getgrnam_r in test due to it…
Feb 14 2019, 2:41 AM
dyung committed rCRT354014: Revert "Temporarily disable calls to getgrnam/getgrnam_r in test due to it….
Revert "Temporarily disable calls to getgrnam/getgrnam_r in test due to it…
Feb 14 2019, 2:41 AM
dyung committed rL354014: Revert "Temporarily disable calls to getgrnam/getgrnam_r in test due to it….
Revert "Temporarily disable calls to getgrnam/getgrnam_r in test due to it…
Feb 14 2019, 2:41 AM

Feb 13 2019

dyung committed rG27343bd8f297: Relax test to check for a valid number instead of a specific number to be like… (authored by dyung).
Relax test to check for a valid number instead of a specific number to be like…
Feb 13 2019, 8:12 PM
dyung committed rL354007: Relax test to check for a valid number instead of a specific number.
Relax test to check for a valid number instead of a specific number
Feb 13 2019, 8:11 PM
dyung committed rG607a1b2234e3: Relax restriction in tests to where "-emit-llvm-bc" and "-emit-obj" must appear. (authored by dyung).
Relax restriction in tests to where "-emit-llvm-bc" and "-emit-obj" must appear.
Feb 13 2019, 5:12 PM
dyung committed rC354001: Relax restriction in tests to where "-emit-llvm-bc" and "-emit-obj" must appear..
Relax restriction in tests to where "-emit-llvm-bc" and "-emit-obj" must appear.
Feb 13 2019, 5:11 PM
dyung committed rL354001: Relax restriction in tests to where "-emit-llvm-bc" and "-emit-obj" must appear..
Relax restriction in tests to where "-emit-llvm-bc" and "-emit-obj" must appear.
Feb 13 2019, 5:11 PM

Feb 11 2019

dyung committed rGcfc512ab44e2: Fix VS2015 build problem introduced by r353370. (authored by dyung).
Fix VS2015 build problem introduced by r353370.
Feb 11 2019, 6:18 PM
dyung added a comment to D54975: [analyzer] Generalised the SMT state constraints .

Build and test passed for me with Visual Studio 2015 and on Linux. Should I submit the fix?

Feb 11 2019, 6:18 PM · Restricted Project
dyung committed rC353791: Fix VS2015 build problem introduced by r353370..
Fix VS2015 build problem introduced by r353370.
Feb 11 2019, 6:17 PM
dyung committed rL353791: Fix VS2015 build problem introduced by r353370..
Fix VS2015 build problem introduced by r353370.
Feb 11 2019, 6:17 PM
dyung added a comment to D54975: [analyzer] Generalised the SMT state constraints .

To be clear, this patch breaks compilation with Visual Studio 2015. Running tests requires that the code can be built, so no I didn't run the tests.

Maybe I didn't express myself very clearly: if you change it to ConstraintSMTType, do the tests pass?

If so, I don't see why not pushing the fix. Unfortunately, I don't have Windows to test it.

I can give it a try. But just to be clear, the fix is to change ConstraintSMTTy on line 22 to ConstraintSMTType? Would line 23 require a similar change, or is it fine as it currently is?

I can answer my own question, both seem to need updating. I am building/testing now.

Feb 11 2019, 5:23 PM · Restricted Project
dyung added a comment to D54975: [analyzer] Generalised the SMT state constraints .

To be clear, this patch breaks compilation with Visual Studio 2015. Running tests requires that the code can be built, so no I didn't run the tests.

Maybe I didn't express myself very clearly: if you change it to ConstraintSMTType, do the tests pass?

If so, I don't see why not pushing the fix. Unfortunately, I don't have Windows to test it.

I can give it a try. But just to be clear, the fix is to change ConstraintSMTTy on line 22 to ConstraintSMTType? Would line 23 require a similar change, or is it fine as it currently is?

Feb 11 2019, 4:50 PM · Restricted Project
dyung added a comment to D54975: [analyzer] Generalised the SMT state constraints .

To be clear, this patch breaks compilation with Visual Studio 2015. Running tests requires that the code can be built, so no I didn't run the tests.

Maybe I didn't express myself very clearly: if you change it to ConstraintSMTType, do the tests pass?

If so, I don't see why not pushing the fix. Unfortunately, I don't have Windows to test it.

Feb 11 2019, 4:24 PM · Restricted Project

Feb 8 2019

dyung committed rGb041a18bcf98: Temporarily disable calls to getgrnam/getgrnam_r in test due to it hitting… (authored by dyung).
Temporarily disable calls to getgrnam/getgrnam_r in test due to it hitting…
Feb 8 2019, 5:29 PM
dyung committed rL353594: Temporarily disable calls to getgrnam/getgrnam_r in test due to it hitting….
Temporarily disable calls to getgrnam/getgrnam_r in test due to it hitting…
Feb 8 2019, 5:29 PM
dyung committed rCRT353594: Temporarily disable calls to getgrnam/getgrnam_r in test due to it hitting….
Temporarily disable calls to getgrnam/getgrnam_r in test due to it hitting…
Feb 8 2019, 5:29 PM

Feb 5 2019

dyung committed rG92e3c97e8a2c: Fixup test on Windows with a case-insensitive filesystem due to path printing… (authored by dyung).
Fixup test on Windows with a case-insensitive filesystem due to path printing…
Feb 5 2019, 3:27 PM
dyung committed rL353238: Fixup test on Windows with a case-insensitive filesystem due to path printing….
Fixup test on Windows with a case-insensitive filesystem due to path printing…
Feb 5 2019, 3:27 PM

Jan 30 2019

dyung committed rL352735: Fixup test after r352704 since it changes how paths may be emitted..
Fixup test after r352704 since it changes how paths may be emitted.
Jan 30 2019, 11:58 PM
dyung committed rL352614: Add lit config file to skip tests if WebAssembly target is not available..
Add lit config file to skip tests if WebAssembly target is not available.
Jan 30 2019, 1:50 AM

Jan 25 2019

dyung committed rL352182: [llvm-objcopy] Add support for -g as an alias for --strip-debug.
[llvm-objcopy] Add support for -g as an alias for --strip-debug
Jan 25 2019, 1:57 AM
dyung closed D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Jan 25 2019, 1:57 AM
dyung updated the diff for D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.

Remove redundant testing and leave in one check that -g and --strip-debug produce identical output.

Jan 25 2019, 12:20 AM
dyung added inline comments to D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Jan 25 2019, 12:13 AM

Jan 24 2019

dyung updated the diff for D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.

Removed extra test lines that were not needed.

Jan 24 2019, 8:54 PM
dyung added inline comments to D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Jan 24 2019, 8:52 PM
dyung created D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug.
Jan 24 2019, 8:26 PM

Jan 23 2019

dyung committed rL352005: [docs] Remove extra character from git URL in Getting Started guide..
[docs] Remove extra character from git URL in Getting Started guide.
Jan 23 2019, 5:23 PM
dyung committed rL351999: [llvm-symbolizer] Add support for -i and -inlines as aliases for -inlining.
[llvm-symbolizer] Add support for -i and -inlines as aliases for -inlining
Jan 23 2019, 4:34 PM
dyung closed D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.
Jan 23 2019, 4:34 PM
dyung updated the diff for D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.

Update documentation for llvm-symbolizers with new switches.

Jan 23 2019, 3:55 AM
dyung updated the diff for D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.

Update test case as suggested.

Jan 23 2019, 3:31 AM
dyung updated the diff for D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.

Added -i/-inlines tests to newly added test flag-grouping.test.

Jan 23 2019, 3:19 AM
dyung updated the diff for D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.

Update review incorporating provided feedback.

Jan 23 2019, 2:43 AM

Jan 22 2019

dyung created D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining.
Jan 22 2019, 8:12 PM

Dec 19 2018

dyung committed rC349691: Disable -faddsig by default for PS4 target..
Disable -faddsig by default for PS4 target.
Dec 19 2018, 2:48 PM
dyung committed rL349691: Disable -faddsig by default for PS4 target..
Disable -faddsig by default for PS4 target.
Dec 19 2018, 2:48 PM

Dec 13 2018

dyung added inline comments to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
Dec 13 2018, 6:21 PM · Restricted Project
dyung added inline comments to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.
Dec 13 2018, 6:20 PM · Restricted Project
dyung added a comment to D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin.

I have reverted this in r349121 as it has been causing the PS4 bots to be red for hours now.

Dec 13 2018, 6:19 PM · Restricted Project
dyung committed rCTE349121: Revert "[clang-tidy] Share the forced linking code between clang-tidy tool and….
Revert "[clang-tidy] Share the forced linking code between clang-tidy tool and…
Dec 13 2018, 6:07 PM
dyung committed rL349121: Revert "[clang-tidy] Share the forced linking code between clang-tidy tool and….
Revert "[clang-tidy] Share the forced linking code between clang-tidy tool and…
Dec 13 2018, 6:07 PM
dyung added a comment to D55382: Make -Wstring-plus-int warns even if when the result is not out of bounds.

Actually this has been failing for 8 hours. So reverted in r349117. Also reverted your attempt to update the test. It wasn't updating the right test: r349118

Dec 13 2018, 4:57 PM

Dec 5 2018

dyung committed rL348447: Reapply fix from r348062 to fix test on Windows..
Reapply fix from r348062 to fix test on Windows.
Dec 5 2018, 6:16 PM
dyung committed rC348447: Reapply fix from r348062 to fix test on Windows..
Reapply fix from r348062 to fix test on Windows.
Dec 5 2018, 6:16 PM
dyung committed rC348425: Fix test change from r348365 to deal with Windows paths correctly..
Fix test change from r348365 to deal with Windows paths correctly.
Dec 5 2018, 3:13 PM
dyung committed rL348425: Fix test change from r348365 to deal with Windows paths correctly..
Fix test change from r348365 to deal with Windows paths correctly.
Dec 5 2018, 3:13 PM

Nov 21 2018

dyung committed rCRT347382: Add header <atomic> which is needed to compile with some older library versions..
Add header <atomic> which is needed to compile with some older library versions.
Nov 21 2018, 12:57 AM
dyung committed rL347382: Add header <atomic> which is needed to compile with some older library versions..
Add header <atomic> which is needed to compile with some older library versions.
Nov 21 2018, 12:57 AM

Nov 8 2018

dyung committed rC346468: Fix test from r346439 to also work on Windows due to path separator differences..
Fix test from r346439 to also work on Windows due to path separator differences.
Nov 8 2018, 6:46 PM
dyung committed rL346468: Fix test from r346439 to also work on Windows due to path separator differences..
Fix test from r346439 to also work on Windows due to path separator differences.
Nov 8 2018, 6:46 PM

Nov 3 2018

dyung committed rL346070: Fix test on Windows..
Fix test on Windows.
Nov 3 2018, 1:53 AM