Page MenuHomePhabricator

urnathan (Nathan Sidwell)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 6 2021, 8:14 AM (4 w, 5 d)

Recent Activity

Mon, May 3

urnathan requested review of D101777: Break out ShadowIntroducingDecl from UsingDecl.
Mon, May 3, 12:09 PM
urnathan committed rGab7316f1c64c: [clang] Spell correct variable (authored by urnathan).
[clang] Spell correct variable
Mon, May 3, 5:34 AM
urnathan closed D101753: clang: Fix variable spelling.
Mon, May 3, 5:34 AM · Restricted Project
urnathan requested review of D101753: clang: Fix variable spelling.
Mon, May 3, 5:03 AM · Restricted Project
urnathan committed rGfe4c9b3cb0c3: [clang] Remove libstdc++ friend template hack (authored by urnathan).
[clang] Remove libstdc++ friend template hack
Mon, May 3, 4:21 AM
urnathan closed D101392: Remove libstdc++ friend template hack.
Mon, May 3, 4:20 AM · Restricted Project
urnathan added a comment to D101370: using-enum part 2 (RFC).

Plan of action is to follow https://lists.llvm.org/pipermail/cfe-dev/2021-April/068074.html, break a ShadowIntroducingDecl base out of UsingDecl and then add UsingEnumDecl derived from that.

Mon, May 3, 4:15 AM

Fri, Apr 30

urnathan committed rGe90792d8c78b: [clang] Update comments on another libstdc++ HACK (authored by urnathan).
[clang] Update comments on another libstdc++ HACK
Fri, Apr 30, 9:30 AM
urnathan closed D101530: clang: Update comments on another libstdc++ HACK.
Fri, Apr 30, 9:29 AM · Restricted Project

Thu, Apr 29

urnathan requested review of D101530: clang: Update comments on another libstdc++ HACK.
Thu, Apr 29, 6:25 AM · Restricted Project
urnathan committed rG0ff41c2ebc99: Update libstdc++ hack comment (authored by urnathan).
Update libstdc++ hack comment
Thu, Apr 29, 3:57 AM
urnathan closed D101441: Update libstdc++ hack comment.
Thu, Apr 29, 3:57 AM · Restricted Project

Wed, Apr 28

urnathan requested review of D101441: Update libstdc++ hack comment.
Wed, Apr 28, 4:07 AM · Restricted Project
urnathan updated the diff for D101392: Remove libstdc++ friend template hack.

Richard, you are correct, I should have looked more. This update removes that boolean

Wed, Apr 28, 4:01 AM · Restricted Project

Tue, Apr 27

urnathan requested review of D101392: Remove libstdc++ friend template hack.
Tue, Apr 27, 12:34 PM · Restricted Project
urnathan added inline comments to D101370: using-enum part 2 (RFC).
Tue, Apr 27, 9:05 AM
urnathan added reviewers for D101370: using-enum part 2 (RFC): rsmith, bruno, aaron.ballman.
Tue, Apr 27, 8:55 AM
urnathan requested review of D101370: using-enum part 2 (RFC).
Tue, Apr 27, 8:53 AM

Thu, Apr 22

urnathan committed rG6ad7e87806c0: clang: libstdc++ LWM is 4.8.3 (authored by urnathan).
clang: libstdc++ LWM is 4.8.3
Thu, Apr 22, 5:27 AM
urnathan closed D100465: clang: Remove __atomic libstdc++ hack.
Thu, Apr 22, 5:26 AM · Restricted Project

Wed, Apr 21

urnathan updated the diff for D100276: [clang] p1099 using enum part 1.

Updated to fix formatting etc (pretty sure I got clang-format to work this time). I changed the pre-c++20 behaviour to be a warning along the lines you suggested. Trying to move the qualifier checking until after generating the shadow decls died horribly -- the shadow generation presumes the context is sane :(

Wed, Apr 21, 10:06 AM · Restricted Project
urnathan added a comment to D100276: [clang] p1099 using enum part 1.

thanks for the comments. My plan wrt documentation was to address that (and the feature macro) once the patches are in.

Wed, Apr 21, 5:01 AM · Restricted Project

Tue, Apr 20

urnathan closed D100680: clang: Add specificity to libstdc++ workaround.

057b6f5d0b3e 2021-04-16 | clang: Update libstdc++ issue workaround

Tue, Apr 20, 11:37 AM
urnathan committed rG057b6f5d0b3e: clang: Update libstdc++ issue workaround (authored by urnathan).
clang: Update libstdc++ issue workaround
Tue, Apr 20, 11:35 AM
urnathan updated the diff for D100465: clang: Remove __atomic libstdc++ hack.

Set 4.8.3 as oldest supported

Tue, Apr 20, 11:31 AM · Restricted Project
urnathan abandoned D100469: [PATCH] clang: Remove libstdc++ gets hack.
Tue, Apr 20, 11:27 AM

Mon, Apr 19

urnathan updated the diff for D100465: clang: Remove __atomic libstdc++ hack.

Change to 4.8.3 as oldest version

Mon, Apr 19, 6:27 AM · Restricted Project

Fri, Apr 16

urnathan updated the diff for D100465: clang: Remove __atomic libstdc++ hack.

Ok, hopefully right this time. I went with v4.9, as that's the version Richard mentioned in D100469, I just confused myself with 4.8.3. will email cfe-dev

Fri, Apr 16, 12:54 PM · Restricted Project
urnathan added a comment to D100469: [PATCH] clang: Remove libstdc++ gets hack.

yeah, I guess that would be a little agressive. See https://reviews.llvm.org/D100680 for a comment update

Fri, Apr 16, 12:38 PM
urnathan requested review of D100680: clang: Add specificity to libstdc++ workaround.
Fri, Apr 16, 12:38 PM
urnathan updated the diff for D100465: clang: Remove __atomic libstdc++ hack.

Added ReleaseNote about libstdc++ -- is that the best place to document such a requirement?

Fri, Apr 16, 11:54 AM · Restricted Project
urnathan updated the diff for D100465: clang: Remove __atomic libstdc++ hack.

Fix failing test -- I must have confused myself

Fri, Apr 16, 11:42 AM · Restricted Project
urnathan added a comment to D99861: [Clang] Record tokens in attribute arguments for user-defined C++/C2x attributes.

See also https://bugs.llvm.org/show_bug.cgi?id=46446. when I first fell into this issue, I did think it was trying to save the token stream as this patch is doing. Neat I thought :) although I'm a clang weenie, saving the tokens is putting this into deferred-parse territory, which makes me nervous. Wouldn't it be better for the ParsedAttrInfo objects to determine whether and how to parse their arguments. They could do so immediately, or save tokens, or whatever on a per-attribute per-argument basis. Isn't that more flexible? Add some ParsedAttrInfo defaults for the default cxx11, gnu & clang flavours of attributes?

Fri, Apr 16, 6:50 AM · Restricted Project

Wed, Apr 14

urnathan updated the diff for D100276: [clang] p1099 using enum part 1.

Remove orthogonal lbstdc++ FIXME comment

Wed, Apr 14, 4:59 AM · Restricted Project
urnathan requested review of D100469: [PATCH] clang: Remove libstdc++ gets hack.
Wed, Apr 14, 4:57 AM
urnathan requested review of D100465: clang: Remove __atomic libstdc++ hack.
Wed, Apr 14, 4:31 AM · Restricted Project

Mon, Apr 12

urnathan added inline comments to D100276: [clang] p1099 using enum part 1.
Mon, Apr 12, 6:00 AM · Restricted Project
urnathan added inline comments to D100276: [clang] p1099 using enum part 1.
Mon, Apr 12, 5:44 AM · Restricted Project

Sun, Apr 11

urnathan requested review of D100276: [clang] p1099 using enum part 1.
Sun, Apr 11, 3:35 PM · Restricted Project

Apr 9 2021

urnathan committed rG92498264269c: [clang] Tiny format fix (authored by urnathan).
[clang] Tiny format fix
Apr 9 2021, 5:21 AM
urnathan closed D100129: Tiny format fix.
Apr 9 2021, 5:20 AM · Restricted Project

Apr 8 2021

urnathan requested review of D100129: Tiny format fix.
Apr 8 2021, 10:48 AM · Restricted Project