- User Since
- Apr 6 2021, 8:14 AM (58 w, 6 d)
Wed, May 18
Tue, May 17
Please clarify. This is fixing a bug where the CFG was being incorrectly constructed.
Mon, May 16
ah, thanks for the clue!
Fri, May 13
hm, let's try that rebase again
Thu, May 12
Address CI issue
good to go, thanks!
Wed, May 11
Tue, May 10
Mon, May 9
Looks good to me, but perhaps leave it a few days for others to comment (my familiarity with this code is low). I do know people want relocatable outputs though.
Fri, May 6
Added special subst tests
Here's the earlier comment https://reviews.llvm.org/D122474#3409394
Wed, May 4
rebase, hopefully fix the CI tester
Tue, May 3
Removed the OutputBufferTest change. I had thought iterators could never be null, but I see I was mistaken.
Mon, May 2
I don't have anything to add to review, but thanks for picking this up.
rebased an updated to avoid the UB discovered in the earlier version.
Thu, Apr 28
alternatively could punt on the whole nullptr thing and just special case the zero-length memcpy and test comparison. thoughts?
(For amusement value, I do know MIPS' memcpy routines segfault on memcpy (dst, nullptr, 0))
Thanks! Do you want to file a PR about the mangling difference between GCC & clang -- I've not looked sufficiently carefully to determine who is wrong[*] here, but we can work with GCC to figure that out. [*] wrong may mean 'pragmatically incorrect' rather than 'technically incorrect', I mean no blame, it's just unfortunate.
Wed, Apr 27
Tue, Apr 26
rebase & ping?
rebase & ping?
Mon, Apr 25
[was out last week] It seems the demangler already gets this right, probably because it just looks like a regular nested name
You need to modify libcxxabi/src/demangle/ItaniumDemangle.h and deploy the cp-to-llvm.sh script therein.
Apr 13 2022
Rebased ontop of D123420
Apr 12 2022
Apr 11 2022
Tomasz, your comments on the rust demangler were most helpful. Perhaps you have bandwidth to look at this?
Apr 8 2022
D123390 is available for review.