This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] When expanding CONCAT_VECTORS, don't create INSERT_SUBVECTORS for undef subvectors.
ClosedPublic

Authored by craig.topper on Jan 14 2022, 6:22 PM.

Details

Summary

For fixed vectors, the undef will get expanded to an all zeros
build_vector. We don't want that so suppress creating the
insert_subvector.

Diff Detail

Event Timeline

craig.topper created this revision.Jan 14 2022, 6:22 PM
craig.topper requested review of this revision.Jan 14 2022, 6:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2022, 6:22 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
frasercrmck accepted this revision.Jan 17 2022, 3:48 AM

Good catch. LGTM.

This revision is now accepted and ready to land.Jan 17 2022, 3:48 AM
This revision was landed with ongoing or failed builds.Jan 17 2022, 2:43 PM
This revision was automatically updated to reflect the committed changes.