Page MenuHomePhabricator

[clang-format] Rename case sorting
ClosedPublic

Authored by HazardyKnusperkeks on Mar 4 2021, 2:18 AM.

Details

Summary

As discussed in D95017 the names case sensitive and insensitive should be switched.

Diff Detail

Unit TestsFailed

TimeTest
1,620 msx64 debian > libarcher.races::lock-unrelated.c
Script: -- : 'RUN: at line 13'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang -fopenmp -pthread -fno-experimental-isel -g -O1 -fsanitize=thread -I /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests -I /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/runtime/src -L /mnt/disks/ssd0/agent/llvm-project/build/lib -Wl,-rpath,/mnt/disks/ssd0/agent/llvm-project/build/lib /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests/races/lock-unrelated.c -o /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp -latomic && env TSAN_OPTIONS='ignore_noninstrumented_modules=0:ignore_noninstrumented_modules=1' /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests/deflake.bash /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp 2>&1 | tee /mnt/disks/ssd0/agent/llvm-project/build/projects/openmp/tools/archer/tests/races/Output/lock-unrelated.c.tmp.log | /mnt/disks/ssd0/agent/llvm-project/build/./bin/FileCheck /mnt/disks/ssd0/agent/llvm-project/openmp/tools/archer/tests/races/lock-unrelated.c

Event Timeline

HazardyKnusperkeks requested review of this revision.Mar 4 2021, 2:18 AM
HazardyKnusperkeks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2021, 2:18 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
curdeius accepted this revision.Mar 4 2021, 4:18 AM

LGTM. It's indeed more logical this way.
Hopefully the original author will confirm.

This revision is now accepted and ready to land.Mar 4 2021, 4:18 AM
PragmaNull accepted this revision.Mar 4 2021, 8:22 AM

Thank you!

LGTM. It's indeed more logical this way.
Hopefully the original author will confirm.

I'll give him one week, if he or nobody else comes along to object I'll push it.

kentsommer accepted this revision.Mar 5 2021, 1:29 AM

LGTM

Sorry for the slow response!

This revision was landed with ongoing or failed builds.Mar 5 2021, 12:43 PM
This revision was automatically updated to reflect the committed changes.

LGTM

Sorry for the slow response!

No problem, we all have some phases where we don't have or find the time.