Page MenuHomePhabricator
Differential D97927

[clang-format] Rename case sorting
ClosedPublic
Actions

Authored by HazardyKnusperkeks on Mar 4 2021, 2:18 AM.

Details

Reviewers
kentsommer
curdeius
MyDeveloperDay
PragmaNull
Commits
rG7b02794f0aeb: [clang-format] Rename case sorting
Summary

As discussed in D95017 the names case sensitive and insensitive should be switched.

Diff Detail

Event Timeline

HazardyKnusperkeks requested review of this revision.Mar 4 2021, 2:18 AM
HazardyKnusperkeks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptMar 4 2021, 2:18 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
HazardyKnusperkeks added a parent revision: D95017: [clang-format] Add case aware include sorting..Mar 4 2021, 2:19 AM
curdeius accepted this revision.Mar 4 2021, 4:18 AM

LGTM. It's indeed more logical this way.
Hopefully the original author will confirm.

This revision is now accepted and ready to land.Mar 4 2021, 4:18 AM
PragmaNull accepted this revision.Mar 4 2021, 8:22 AM

Thank you!

HazardyKnusperkeks added a comment.Mar 4 2021, 10:52 AM
In D97927#2603089, @curdeius wrote:

LGTM. It's indeed more logical this way.
Hopefully the original author will confirm.

I'll give him one week, if he or nobody else comes along to object I'll push it.

Harbormaster completed remote builds in B92016: Diff 328088.Mar 4 2021, 12:29 PM
kentsommer accepted this revision.Mar 5 2021, 1:29 AM

LGTM

Sorry for the slow response!

This revision was landed with ongoing or failed builds.Mar 5 2021, 12:43 PM
Closed by commit rG7b02794f0aeb: [clang-format] Rename case sorting (authored by HazardyKnusperkeks). · Explain Why
This revision was automatically updated to reflect the committed changes.
HazardyKnusperkeks added a commit: rG7b02794f0aeb: [clang-format] Rename case sorting.
HazardyKnusperkeks added a comment.Mar 5 2021, 12:44 PM
In D97927#2605914, @kentsommer wrote:

LGTM

Sorry for the slow response!

No problem, we all have some phases where we don't have or find the time.

Revision Contents
Changeset List

PathSize
clang/
docs/
8 lines
8 lines
include/
clang/
Format/
8 lines
lib/
Format/
8 lines
tools/
clang-format/
2 lines
unittests/
Format/
4 lines
4 lines

Diff 328615

View Options

clang/docs/ClangFormatStyleOptions.rst

Loading...
View Options

clang/docs/ReleaseNotes.rst

Loading...
View Options

clang/include/clang/Format/Format.h

Loading...
View Options

clang/lib/Format/Format.cpp

Loading...
View Options

clang/tools/clang-format/ClangFormat.cpp

Loading...
View Options

clang/unittests/Format/FormatTest.cpp

Loading...
View Options

clang/unittests/Format/SortIncludesTest.cpp

Loading...