Page MenuHomePhabricator

PragmaNull (Chris Johnson)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 18 2021, 9:24 AM (8 w, 1 d)

Recent Activity

Mar 4 2021

PragmaNull accepted D97927: [clang-format] Rename case sorting.

Thank you!

Mar 4 2021, 8:22 AM · Restricted Project, Restricted Project

Mar 2 2021

PragmaNull added a comment to D95017: [clang-format] Add case aware include sorting..
Mar 2 2021, 10:29 AM · Restricted Project, Restricted Project

Feb 18 2021

PragmaNull added a comment to D95017: [clang-format] Add case aware include sorting..

Do you have an idea for better names?
I see that e.g. MS documentation uses ascending order and case-sensitive order.

Feb 18 2021, 12:40 PM · Restricted Project, Restricted Project
PragmaNull added a comment to D95017: [clang-format] Add case aware include sorting..

I find the naming of the case sensitive options confusing here.
When I read "CaseSensitive" I think of the behavior of strcmp() which sorts according to "ASCIIbetical" order. But here "CaseSensitive" throws away case by comparing the result of "Filename.lower()" which I would consider case-insensitive, or the same behavior as a call to stricmp().

Feb 18 2021, 10:01 AM · Restricted Project, Restricted Project