Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/include/clang/Basic/riscv_vector.td | ||
---|---|---|
165 | Why do we need a flag? Can we just make ManualCodegen and ManualCodegenMask default to empty rather than a code sequence that we should never use? Then we can just detect them not being empty in place of the flag. | |
clang/utils/TableGen/RISCVVEmitter.cpp | ||
921 | !HeaderCodeStr.empty() | |
1039–1040 | It doesn't make sense to me to skip the emitExtDefStr for !hasAutoDef. The intrinsics without a definition are still sorted with the others. If they happen to have non-zero extensions and on the boundary of the different extension regions in the sorted list we still need to manage the #if/#endif for that boundary. |
address Craig's comments.
clang/utils/TableGen/RISCVVEmitter.cpp | ||
---|---|---|
1039–1040 | You are right, thanks for catch bug! |
clang/lib/Basic/Targets/RISCV.cpp | ||
---|---|---|
163 | I'm not sure if it makes sense to expose these from the compiler. Should we define them in the header instead? They don't look useful without the header. Most of the defines from the compiler are expressing capabilities like what features are enabled so these seem different. | |
168 | Are intending to support e128? | |
clang/utils/TableGen/RISCVVEmitter.cpp | ||
775 | !HeaderCode.empty() |
clang/lib/Basic/Targets/RISCV.cpp | ||
---|---|---|
168 | remove! thanks |
Why do we need a flag? Can we just make ManualCodegen and ManualCodegenMask default to empty rather than a code sequence that we should never use? Then we can just detect them not being empty in place of the flag.