Add tests to make sure common instructions are accepted in RV64
and not just RV32.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/MC/RISCV/rv64zbc-valid.s | ||
---|---|---|
8–9 | This file is new but git and/or arcanist decided to mark it as a copy with changes from a different file so this diff looks funny. |
Thanks for extending the test coverage!
Given that other than RVC, the RV64 variants of instruction set extensions are always additive, I have a slight preference for just adding some RV64 RUN lines to the rv32*-valid.s tests rather than copying and pasting the common instructions to the rv64*-valid.s files. This is consistent with what we do for the base extensions.
But this works fine, so I'm happy enough for it to land as is.
Reducing test duplication would be good, but if B already has a bunch of that then maybe it's better to land this and then have a follow-up commit that deduplicates a la RVI etc.
zext.h and rev8 from Zbb have different encodings between rv32 and rv64. Should we use different check prefixes for those?
This file is new but git and/or arcanist decided to mark it as a copy with changes from a different file so this diff looks funny.