Remove common instructions from rv64 tests since they are now
covered by the rv64 run lines in the rv32 tests.
Add rv32-only* tests for a few cases that aren't common between
r32 and rv64.
Addresses review feedback from D95150.
Paths
| Differential D95272
[RISCV] Add rv64 run lines to rv32 MC layer tests for B extension ClosedPublic Authored by craig.topper on Jan 22 2021, 4:04 PM.
Details Summary Remove common instructions from rv64 tests since they are now Add rv32-only* tests for a few cases that aren't common between Addresses review feedback from D95150.
Diff Detail
Event TimelineHerald added subscribers: NickHung, evandro, luismarques and 22 others. · View Herald TranscriptJan 22 2021, 4:04 PM Comment Actions Looking good; thanks for doing this. Should we change the name of the 32+64 tests now that they test both? Comment Actions
That's not what we've done elsewhere; rv64 is regarded as a superset of rv32, which is almost true. Comment Actions
Ah great, thanks: my mistake. If there's a precedent then that's fine. This revision is now accepted and ready to land.Jan 26 2021, 1:47 AM Closed by commit rGe1d6178951de: [RISCV] Add rv64 run lines to rv32 MC layer tests for B extension (authored by craig.topper). · Explain WhyJan 26 2021, 5:20 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 319445 llvm/test/MC/RISCV/rv32zba-valid.s
llvm/test/MC/RISCV/rv32zbb-valid.s
llvm/test/MC/RISCV/rv32zbbp-only-valid.s
llvm/test/MC/RISCV/rv32zbbp-valid.s
llvm/test/MC/RISCV/rv32zbc-valid.s
llvm/test/MC/RISCV/rv32zbe-valid.s
llvm/test/MC/RISCV/rv32zbf-valid.s
llvm/test/MC/RISCV/rv32zbp-only-valid.s
llvm/test/MC/RISCV/rv32zbp-valid.s
llvm/test/MC/RISCV/rv32zbproposedc-valid.s
llvm/test/MC/RISCV/rv32zbs-valid.s
llvm/test/MC/RISCV/rv32zbt-valid.s
llvm/test/MC/RISCV/rv64zba-valid.s
llvm/test/MC/RISCV/rv64zbb-valid.s
llvm/test/MC/RISCV/rv64zbbp-valid.s
llvm/test/MC/RISCV/rv64zbc-valid.s
llvm/test/MC/RISCV/rv64zbe-valid.s
llvm/test/MC/RISCV/rv64zbf-valid.s
llvm/test/MC/RISCV/rv64zbp-valid.s
llvm/test/MC/RISCV/rv64zbproposedc-valid.s
llvm/test/MC/RISCV/rv64zbs-valid.s
llvm/test/MC/RISCV/rv64zbt-valid.s
|