This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add rv64 run lines to rv32 MC layer tests for B extension
ClosedPublic

Authored by craig.topper on Jan 22 2021, 4:04 PM.

Details

Summary

Remove common instructions from rv64 tests since they are now
covered by the rv64 run lines in the rv32 tests.

Add rv32-only* tests for a few cases that aren't common between
r32 and rv64.

Addresses review feedback from D95150.

Diff Detail

Event Timeline

craig.topper created this revision.Jan 22 2021, 4:04 PM
craig.topper requested review of this revision.Jan 22 2021, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2021, 4:04 PM
Herald added a subscriber: MaskRay. · View Herald Transcript

Looking good; thanks for doing this. Should we change the name of the 32+64 tests now that they test both?

Looking good; thanks for doing this. Should we change the name of the 32+64 tests now that they test both?

That's not what we've done elsewhere; rv64 is regarded as a superset of rv32, which is almost true.

That's not what we've done elsewhere; rv64 is regarded as a superset of rv32, which is almost true.

Ah great, thanks: my mistake. If there's a precedent then that's fine.

This revision is now accepted and ready to land.Jan 26 2021, 1:47 AM
llvm/test/MC/RISCV/rv64zbbp-valid.s